keyar@chromium.org
163b56734f
Merged bench_pictures and render_pictures rendering methods.
...
bench_pictures now uses a class based method for choosing the benchmark type as well.
Review URL: https://codereview.appspot.com/6452070
git-svn-id: http://skia.googlecode.com/svn/trunk@4894 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-08-01 17:53:29 +00:00
bsalomon@google.com
f1478f8803
Fix skdiff when using windows path that begins with a drive letter
...
Review URL: https://mail.google.com/mail/u/0/?shva=1#inbox/138d92244ca33549
git-svn-id: http://skia.googlecode.com/svn/trunk@4838 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-07-30 19:16:02 +00:00
keyar@chromium.org
cc6e5efe03
Added an option to specify the tiling size to render_pictures.
...
With this change I should be able to start merging the rendering implementations of bench_pictures and render_pictures.
Review URL: https://codereview.appspot.com/6427061
git-svn-id: http://skia.googlecode.com/svn/trunk@4816 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-07-27 20:09:26 +00:00
epoger@google.com
4a6ba46b9f
Update list of platforms to rebaseline
...
Review URL: https://codereview.appspot.com/6441061
git-svn-id: http://skia.googlecode.com/svn/trunk@4806 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-07-27 15:19:54 +00:00
robertphillips@google.com
fc91dc7004
Windows compiler complaint cleanup
...
http://codereview.appspot.com/6441055/
git-svn-id: http://skia.googlecode.com/svn/trunk@4796 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-07-26 21:18:31 +00:00
keyar@chromium.org
451bb9f801
Changed to a class based method in passing around the rendering method for render_pictures.
...
This is based on a comment for https://codereview.appspot.com/6427061/
Review URL: https://codereview.appspot.com/6405080
git-svn-id: http://skia.googlecode.com/svn/trunk@4786 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-07-26 17:27:57 +00:00
keyar@chromium.org
472b379b5b
render_pictures can now do tiling based rendering.
...
Review URL: https://codereview.appspot.com/6401057
git-svn-id: http://skia.googlecode.com/svn/trunk@4707 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-07-20 22:34:27 +00:00
epoger@google.com
3af4ff46a7
skdiff output: indicate which result types would cause failure
...
Review URL: https://codereview.appspot.com/6419053
git-svn-id: http://skia.googlecode.com/svn/trunk@4676 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-07-19 17:35:04 +00:00
borenet@google.com
855cd7aa5e
Update download_baselines.py
...
No longer using *-fixed
Added Android
Review URL: https://codereview.appspot.com/6428047
git-svn-id: http://skia.googlecode.com/svn/trunk@4662 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-07-18 21:23:40 +00:00
rmistry@google.com
a8a977a97b
Update docs and trunk dirs if they exist overriding any local merge conflicts.
...
Created to fix bug http://code.google.com/p/skia/issues/detail?id=710 :
housekeeping buildbot: conflict in UpdateDoxygen step.
git-svn-id: http://skia.googlecode.com/svn/trunk@4640 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-07-17 18:27:03 +00:00
keyar@chromium.org
21e3ed2e9a
bench_pictures now has an option for benchmarking record time.
...
Review URL: https://codereview.appspot.com/6350102
git-svn-id: http://skia.googlecode.com/svn/trunk@4632 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-07-16 19:20:14 +00:00
epoger@google.com
2865988361
skdiff: cap return value at 255 to avoid automatic 'wrapping' (%256) of return value
...
Review URL: https://codereview.appspot.com/6409045
git-svn-id: http://skia.googlecode.com/svn/trunk@4629 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-07-16 18:01:06 +00:00
keyar@chromium.org
a2333d9703
Added pipe as a rendering option for render_pictures.
...
I will add tiling as a rendering option and then figure out a way to not have the code duplicated between render_pictures and bench_pictures.
Review URL: https://codereview.appspot.com/6392066
git-svn-id: http://skia.googlecode.com/svn/trunk@4626 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-07-16 17:29:16 +00:00
epoger@google.com
dfbf24e5e7
skdiff: replace --failonmismatches with repeatable --failonresult option
...
Review URL: https://codereview.appspot.com/6392064
git-svn-id: http://skia.googlecode.com/svn/trunk@4611 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-07-13 21:22:02 +00:00
senorblanco@chromium.org
3cbbb543ef
Mac build fix for Keyar. Unreviewed.
...
git-svn-id: http://skia.googlecode.com/svn/trunk@4607 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-07-13 18:55:53 +00:00
keyar@chromium.org
1cbd47c4b1
Preparations for adding options and different render types to render_pictures.
...
Review URL: https://codereview.appspot.com/6345107
git-svn-id: http://skia.googlecode.com/svn/trunk@4603 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-07-13 18:22:59 +00:00
keyar@chromium.org
3e8483e0de
Benchmark tiling now better reflects how it is done in Chrome.
...
Namely, the tile backing stores are all the same size.
Review URL: https://codereview.appspot.com/6352099
git-svn-id: http://skia.googlecode.com/svn/trunk@4602 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-07-13 18:15:04 +00:00
epoger@google.com
c665832fbf
update-doxygen.sh: update local copy of workspace rather than checking it out fresh every time
...
Review URL: https://codereview.appspot.com/6346099
git-svn-id: http://skia.googlecode.com/svn/trunk@4590 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-07-12 23:35:28 +00:00
keyar@chromium.org
b5e30abbeb
Changed cmsecs to msecs to be consistent with bench.
...
We are using wall time and not cpu time and so the proper name for this
should probably be outputted.
Review URL: https://codereview.appspot.com/6345104
git-svn-id: http://skia.googlecode.com/svn/trunk@4587 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-07-12 21:16:49 +00:00
keyar@chromium.org
4916971526
Added a benchmark for measuring picture unflattening time.
...
Review URL: https://codereview.appspot.com/6354097
git-svn-id: http://skia.googlecode.com/svn/trunk@4582 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-07-12 19:19:55 +00:00
epoger@google.com
70044cc496
rename NO_ERROR to kNoError, because Windows defines a NO_ERROR macro elsewhere
...
TBR=rmistry
Review URL: https://codereview.appspot.com/6355100
git-svn-id: http://skia.googlecode.com/svn/trunk@4581 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-07-12 18:37:55 +00:00
epoger@google.com
46a45963fa
skdiff: add --failonmismatches and --listfilename options, plus cleanup
...
These changes are needed in order to switch the buildbots from using "gm -r" to "skdiff" to compare gm results, and should be generally good for humans too.
Review URL: https://codereview.appspot.com/6392054
git-svn-id: http://skia.googlecode.com/svn/trunk@4579 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-07-12 18:16:02 +00:00
keyar@chromium.org
a4091ba864
Each benchmark that needs a bitmap will now make its own.
...
Before, the bitmaps were created and then passed to the benchmark. However, some benchmarks in the future will not require bitmaps. This will remove the necessity of passing around an extraneous bitmap to those tests.
Review URL: https://codereview.appspot.com/6356081
git-svn-id: http://skia.googlecode.com/svn/trunk@4519 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-07-10 19:53:59 +00:00
keyar@chromium.org
0665f25b31
bench_pictures can now take percentages for tiling width and height.Review URL: https://codereview.appspot.com/6354074
...
Review URL: https://codereview.appspot.com/6354074
git-svn-id: http://skia.googlecode.com/svn/trunk@4516 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-07-10 18:30:18 +00:00
robertphillips@google.com
59f46b81f8
Fixed Windows compiler complaints
...
http://codereview.appspot.com/6392044
git-svn-id: http://skia.googlecode.com/svn/trunk@4511 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-07-10 17:30:58 +00:00
keyar@chromium.org
2724ae0bb1
bench_pictures will now output the number of tiles for a tiled benchmark.
...
Review URL: https://codereview.appspot.com/6387044
git-svn-id: http://skia.googlecode.com/svn/trunk@4507 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-07-10 15:13:21 +00:00
keyar@chromium.org
a6318194df
skdiff now has the option to not print out the directories it is using.
...
Further, test_pictures.py will call skdiff with this option.
Review URL: https://codereview.appspot.com/6347066
git-svn-id: http://skia.googlecode.com/svn/trunk@4497 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-07-09 21:01:50 +00:00
rmistry@google.com
bcf0c5229c
* Adding arguments to specify the working directory and whether the script should try to commit at the end.
...
* Redirecting doxygen output to a last_run_output.txt file.
* Maintaining backwards compatibility.
Context-
This CL is a preparatory CL for the housekeeping slave. The slave will use this script to update Doxygen docs. The script will not be used to commit and instead the slave will call AddMergeIntoSvn to commit.
Review URL: https://codereview.appspot.com/6348076
git-svn-id: http://skia.googlecode.com/svn/trunk@4495 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-07-09 20:53:03 +00:00
keyar@chromium.org
70b4222344
Tiles that extend beyond the picture are now clipped.
...
Review URL: https://codereview.appspot.com/6352078
git-svn-id: http://skia.googlecode.com/svn/trunk@4491 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-07-09 19:51:05 +00:00
keyar@chromium.org
cf6c44cf92
Added a sgpipe benchmark.
...
Review URL: https://codereview.appspot.com/6349070
git-svn-id: http://skia.googlecode.com/svn/trunk@4490 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-07-09 19:37:40 +00:00
keyar@chromium.org
d1dc920097
Allow specific files and multiple inputs for picture testing tools.
...
Changed the render_pictures, bench_pictures and test_pictures.py so that multiple inputs can be given. Furthermore, specific files can also be specified.
Unit tests have also been added for picture_utils.cpp.
Review URL: https://codereview.appspot.com/6345054
git-svn-id: http://skia.googlecode.com/svn/trunk@4486 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-07-09 18:32:08 +00:00
bsalomon@google.com
c0961f5d23
Rebaseline MSAA16 AA clip images. We now enable MSAA when stencil clipping if the clip element is AA.
...
git-svn-id: http://skia.googlecode.com/svn/trunk@4393 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-06-28 19:50:27 +00:00
epoger@google.com
28060e7c94
Improve sorting of skdiff output, and make it consistent across platforms
...
BUG=https://code.google.com/p/skia/issues/detail?id=677
Review URL: https://codereview.appspot.com/6351045
git-svn-id: http://skia.googlecode.com/svn/trunk@4388 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-06-28 16:47:34 +00:00
reed@google.com
006db0f1b8
land https://codereview.appspot.com/6349043/
...
git-svn-id: http://skia.googlecode.com/svn/trunk@4375 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-06-27 19:33:29 +00:00
epoger@google.com
da4af24c9c
skdiff: no longer skip .pdf files by default
...
Review URL: https://codereview.appspot.com/6257080
git-svn-id: http://skia.googlecode.com/svn/trunk@4330 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-06-25 18:45:50 +00:00
twiz@google.com
6cf5303b93
Adding files skipped from previous patch: http://code.google.com/p/skia/source/detail?r=4310
...
Review URL: https://codereview.appspot.com/6339043/
git-svn-id: http://skia.googlecode.com/svn/trunk@4312 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-06-22 18:55:55 +00:00
twiz@google.com
a31b8bb58d
Refactoring in preparation for adding the picture benchmarking program.
...
Review URL: https://codereview.appspot.com/6339043/
git-svn-id: http://skia.googlecode.com/svn/trunk@4310 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-06-22 18:24:56 +00:00
reed@google.com
1bdf7fe8f6
tools/pinspect: quick tool to inspeact the header (and rough validity) of 1 or more picture files
...
Review URL: https://codereview.appspot.com/6295085
git-svn-id: http://skia.googlecode.com/svn/trunk@4258 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-06-14 18:58:40 +00:00
junov@chromium.org
777442d52e
Adding the render_pictures test tool
...
Submitted on behalf of keyar@chromium.org
Review URL: https://codereview.appspot.com/6300056/
git-svn-id: http://skia.googlecode.com/svn/trunk@4235 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-06-12 14:56:36 +00:00
caryclark@google.com
3dd459151f
fix warnings on Mac in miscellaneous files
...
Fix these class of warnings:
- unused functions
- unused locals
- sign mismatch
- missing function prototypes
- missing newline at end of file
- 64 to 32 bit truncation
The changes prefer to link in dead code in the debug build
with 'if (false)' than to comment it out, but trivial cases
are commented out or sometimes deleted if it appears to be
a copy/paste error.
Review URL: https://codereview.appspot.com/6305047
git-svn-id: http://skia.googlecode.com/svn/trunk@4186 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-06-06 12:11:10 +00:00
epoger@google.com
be6188d647
skdiff: return nonzero exit value if there are any mismatches
...
This will allow us to replace "gm -r" in our buildbots with "skdiff". This will speed things up, and work around http://code.google.com/p/skia/issues/detail?id=473 ('PDF gradtext gm image results are nondeterministic')
Review URL: https://codereview.appspot.com/6242071
git-svn-id: http://skia.googlecode.com/svn/trunk@4097 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-05-31 15:13:45 +00:00
epoger@google.com
76222c0ef2
skdiff: internally track lists of ALL result types, not just baseMissing and comparisonMissing
...
This does not change skdiff output at all; verified using tools/tests/run.sh
Review URL: https://codereview.appspot.com/6260057
git-svn-id: http://skia.googlecode.com/svn/trunk@4096 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-05-31 15:12:09 +00:00
epoger@google.com
8e4e51d69b
test-only: add test coverage of skdiff over input with identical bits or pixels
...
Review URL: https://codereview.appspot.com/6260055
git-svn-id: http://skia.googlecode.com/svn/trunk@4084 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-05-30 19:12:45 +00:00
epoger@google.com
6dbf6cde3b
svndiff: report added and deleted files, not just modified files
...
Review URL: https://codereview.appspot.com/6260052
git-svn-id: http://skia.googlecode.com/svn/trunk@4063 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-05-29 21:28:12 +00:00
epoger@google.com
2e0a061c09
Add svndiff tool: runs skdiff over all pending changes in SVN checkout
...
This is needed for
https://goto.google.com/HowToLandSkiaChangesThatChangeWebkitLayoutTests ,
and will be generally useful beyond that too.
Review URL: https://codereview.appspot.com/6256052
git-svn-id: http://skia.googlecode.com/svn/trunk@4052 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-05-25 19:48:05 +00:00
epoger@google.com
0f645b68a3
download_baselines.py : only set svn properties of files whose content has changed
...
and while I was at it, sort the filenames before acting on them, to make the output easier to read
BUG=http://code.google.com/p/skia/issues/detail?id=618
Review URL: https://codereview.appspot.com/6223061
git-svn-id: http://skia.googlecode.com/svn/trunk@4031 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-05-22 19:14:01 +00:00
epoger@google.com
46256ea736
Add to skdiff: test images for bitwise equality before testing for pixel-wise equality
...
- we now check for bitwise equality of files before bothering with pixel
comparisons (this will help with formats for which we don't have good
decoders, like PDF)
- unparsable files are now reported as differing, unless they are bitwise equal
(before, they were always reported as matching!)
- "largest area mismatch" is now based on same-size image pairs only;
previously, if any image pairs had mismatching size, it was 100%
- removed repetitive "image size mismatch, so no diff to display" messages
- changed format of leftmost table cells to be more readable
BUG=http://code.google.com/p/skia/issues/detail?id=473
Review URL: https://codereview.appspot.com/6208089
git-svn-id: http://skia.googlecode.com/svn/trunk@4027 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-05-22 13:45:35 +00:00
epoger@google.com
a611c3ea53
Remove chromium mode from skdiff, because it is no longer actively used.
...
Ran tools/tests/run.sh to validate this change.
TBR=caryclark1
Review URL: https://codereview.appspot.com/6222045
git-svn-id: http://skia.googlecode.com/svn/trunk@4005 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-05-18 20:10:06 +00:00
epoger@google.com
90cb9b325c
skdiff test-only change: add test of --nodiffs mode, make tests validate return value
...
Review URL: https://codereview.appspot.com/6206085
git-svn-id: http://skia.googlecode.com/svn/trunk@3999 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-05-18 18:25:26 +00:00
epoger@google.com
a44435296a
test-only change: update run.sh and rearrange dirs to ease addition of more tests
...
Review URL: https://codereview.appspot.com/6220044
git-svn-id: http://skia.googlecode.com/svn/trunk@3995 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-05-17 17:12:38 +00:00