epoger@google.com
46a45963fa
skdiff: add --failonmismatches and --listfilename options, plus cleanup
...
These changes are needed in order to switch the buildbots from using "gm -r" to "skdiff" to compare gm results, and should be generally good for humans too.
Review URL: https://codereview.appspot.com/6392054
git-svn-id: http://skia.googlecode.com/svn/trunk@4579 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-07-12 18:16:02 +00:00
junov@chromium.org
a6c9e0e02b
Cleanup restore offsets at end of SkPicture recording
...
Review URL: http://codereview.appspot.com/6355099/
TEST=skia unit test CanvasTest, test step TwoClipOps
BUG=https://code.google.com/p/chromium/issues/detail?id=133432
git-svn-id: http://skia.googlecode.com/svn/trunk@4577 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-07-12 17:47:34 +00:00
tomhudson@google.com
d0c1a06cb9
Introduces new SingleTextureEffect base class for GrCustomStage objects.
...
This class tracks the texture that the object uses. A future commit will get rid of the
GrTexture pointer currenty stored in the GrDrawState, allowing us to have CustomStages
*without* textures.
Requires gyp change on next roll.
http://codereview.appspot.com/6306097/
git-svn-id: http://skia.googlecode.com/svn/trunk@4576 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-07-12 17:23:52 +00:00
bsalomon@google.com
d7727ceb82
Refactor how precision is handled with GrGLShaderVar
...
Review URL: http://codereview.appspot.com/6392049/
git-svn-id: http://skia.googlecode.com/svn/trunk@4575 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-07-12 16:40:03 +00:00
reed@google.com
ba68cdb415
rebaseline macpro for convexpaths (test was changed)
...
git-svn-id: http://skia.googlecode.com/svn/trunk@4574 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-07-12 15:59:09 +00:00
chudy@google.com
f32f6e8323
Added annotation for gm's -wp flag
...
Review URL: https://codereview.appspot.com/6345098
git-svn-id: http://skia.googlecode.com/svn/trunk@4573 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-07-12 15:42:37 +00:00
reed@google.com
83ca337348
check a hashtable before using a bsearch
...
Review URL: https://codereview.appspot.com/6345097
git-svn-id: http://skia.googlecode.com/svn/trunk@4572 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-07-12 15:27:54 +00:00
junov@chromium.org
02662b7feb
Fixing bad assertion test that was trippin-up debug buildbots
...
TBR=http://codereview.appspot.com/6344109
git-svn-id: http://skia.googlecode.com/svn/trunk@4569 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-07-12 14:44:52 +00:00
senorblanco@chromium.org
c76230868d
Fix the lighting filters unit test and re-enable it.
...
Review URL: http://codereview.appspot.com/6355098/
git-svn-id: http://skia.googlecode.com/svn/trunk@4568 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-07-12 14:39:07 +00:00
chudy@google.com
233e4b80e0
Bug Fix: Delete redraws correctly when redraw command execution is paused
...
Review URL: https://codereview.appspot.com/6392053
git-svn-id: http://skia.googlecode.com/svn/trunk@4567 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-07-12 14:38:49 +00:00
chudy@google.com
e606d6e210
SkHitBox added.
...
SkHitBox is a class that determines which draw command is associated with the pixel located at x,y. By calculating a single point instead of the entire bitmap at once there is no visible performance slowdown.
Review URL: https://codereview.appspot.com/6350098
git-svn-id: http://skia.googlecode.com/svn/trunk@4565 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-07-12 14:31:25 +00:00
chudy@google.com
e565de4fad
Seperated Space for displaying breakpoint and deletion icons
...
Review URL: https://codereview.appspot.com/6356094
git-svn-id: http://skia.googlecode.com/svn/trunk@4563 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-07-12 14:15:54 +00:00
junov@chromium.org
6fc5699e77
Fixing type mask computation in SkMatrix to make it faster and make it so that matrices have the same type masks as their inverses.
...
This patch also add bench tests that call invert() followed by mapRect() on various types of matrices. Performance of these tests was greatly affected by typemask computation
Review URL: http://codereview.appspot.com/6380043/
BUG=https://code.google.com/p/chromium/issues/detail?id=135259
git-svn-id: http://skia.googlecode.com/svn/trunk@4562 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-07-12 14:01:32 +00:00
robertphillips@google.com
50a69a0727
Altered complexclip GM to test out saveLayer w/ a bound and clipping
...
http://codereview.appspot.com/6344108/
git-svn-id: http://skia.googlecode.com/svn/trunk@4561 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-07-12 13:48:46 +00:00
caryclark@google.com
027de226c1
shape ops work in progress
...
M Intersection/Simplify.cpp
git-svn-id: http://skia.googlecode.com/svn/trunk@4560 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-07-12 12:52:50 +00:00
senorblanco@chromium.org
5f47a39916
The correct fix for the lighting filters on Windows: set the GL calling
...
convention for all targets, not just gpu, since effects now makes GL calls too.
Build fix; unreviewed.
git-svn-id: http://skia.googlecode.com/svn/trunk@4559 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-07-12 00:34:39 +00:00
robertphillips@google.com
56c79b1037
Added GrContext::AutoClipStack to encapsulate setting\resetting of clip stack
...
http://codereview.appspot.com/6343097/
git-svn-id: http://skia.googlecode.com/svn/trunk@4558 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-07-11 20:57:46 +00:00
senorblanco@chromium.org
eb311845c1
Fix lighting filters on Windows, and re-enable the GPU path.
...
Review URL: http://codereview.appspot.com/6354094/
git-svn-id: http://skia.googlecode.com/svn/trunk@4557 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-07-11 20:49:26 +00:00
reed@google.com
b0a34d80c5
idea: add annotation to SkPaint
...
Review URL: https://codereview.appspot.com/6355050
git-svn-id: http://skia.googlecode.com/svn/trunk@4555 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-07-11 19:57:55 +00:00
bsalomon@google.com
548a433ec3
Fix linux warnings
...
Review URL: http://codereview.appspot.com/6354093/
git-svn-id: http://skia.googlecode.com/svn/trunk@4554 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-07-11 19:45:22 +00:00
bsalomon@google.com
641ca9c808
Fix dumb copy/paste bug that breaks GLProgramTest on debug builds with GS support.
...
git-svn-id: http://skia.googlecode.com/svn/trunk@4553 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-07-11 19:35:52 +00:00
reed@google.com
e9bb623e4d
add default: to switch statement, to avoid warning/error for unhandled cases.
...
git-svn-id: http://skia.googlecode.com/svn/trunk@4552 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-07-11 18:56:10 +00:00
reed@google.com
79382af267
remove debugging printfs
...
git-svn-id: http://skia.googlecode.com/svn/trunk@4551 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-07-11 18:55:23 +00:00
robertphillips@google.com
fea85ac3e3
Minor refactoring to make GrAutoMatrix a nested sub-class of GrContext
...
http://codereview.appspot.com/6356092/
git-svn-id: http://skia.googlecode.com/svn/trunk@4549 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-07-11 18:53:23 +00:00
reed@google.com
19393dff0c
add flatten/unflatten to SkDataSet
...
Review URL: https://codereview.appspot.com/6374057
git-svn-id: http://skia.googlecode.com/svn/trunk@4548 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-07-11 18:48:37 +00:00
senorblanco@chromium.org
a2fdb338c7
Disable GPU path for lighting filters, due to Windows weirdness. Unreviewed.
...
git-svn-id: http://skia.googlecode.com/svn/trunk@4547 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-07-11 18:47:11 +00:00
robertphillips@google.com
bca1c5de48
Fixed merge error in r4545
...
git-svn-id: http://skia.googlecode.com/svn/trunk@4546 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-07-11 18:25:24 +00:00
robertphillips@google.com
3e11c0bd92
Forced GrClip to always have conservative bounds
...
http://codereview.appspot.com/6353089/
git-svn-id: http://skia.googlecode.com/svn/trunk@4545 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-07-11 18:20:35 +00:00
bsalomon@google.com
ad5e937c11
Make GrGLShaderBuilder produce the shader strings
...
Review URL: http://codereview.appspot.com/6356089/
git-svn-id: http://skia.googlecode.com/svn/trunk@4544 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-07-11 18:11:27 +00:00
caryclark@google.com
fa4a6e9646
shape ops work in progress
...
M Intersection/SimplifyRect4x4_Test.cpp
M Intersection/Simplify.cpp
M Intersection/SimplifyFindNext_Test.cpp
M Intersection/SimplifyNew_Test.cpp
M Intersection/op.htm
git-svn-id: http://skia.googlecode.com/svn/trunk@4543 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-07-11 17:52:32 +00:00
reed@google.com
91bd45967c
add SkDataSet class, so SkAnnotation can be more immutable-like
...
Review URL: https://codereview.appspot.com/6354091
git-svn-id: http://skia.googlecode.com/svn/trunk@4542 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-07-11 17:24:49 +00:00
senorblanco@chromium.org
22b13f3628
Disable lighting filter unit test temporarily; unreviewed.
...
git-svn-id: http://skia.googlecode.com/svn/trunk@4541 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-07-11 17:10:26 +00:00
senorblanco@chromium.org
0ec1eab877
Mac GLSL fixes; unreviewed.
...
git-svn-id: http://skia.googlecode.com/svn/trunk@4539 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-07-11 16:44:49 +00:00
senorblanco@chromium.org
6730cbb80a
More build fixes; unreviewed.
...
git-svn-id: http://skia.googlecode.com/svn/trunk@4537 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-07-11 16:35:00 +00:00
senorblanco@chromium.org
bd9fad67b8
Mac build fix; unreviewed.
...
git-svn-id: http://skia.googlecode.com/svn/trunk@4536 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-07-11 16:25:37 +00:00
senorblanco@chromium.org
894790d77c
This patch implements the diffuse and specular lighting filters in Ganesh.
...
There are three light types for each: distant, point and spot, whose code
generation lives in a GrGLLight class hierarchy. This similar to the CPU
implementation, where each light type provides a function to compute the vector
from the surface plane to the light (surfaceToLight) and to compute the light
colour (emitLightColour). Instead of templated member functions, as in the CPU
implementation, these are virtual functions to emit the light-specific GLSL
code.
All of the code for the GPU path lives in the same file as that for the CPU
path, SkLightingImageFilter.cpp. In order to provide Ganesh a hook to access
it, SkImageFilter now has a asNewCustomStage() virtual, which allows an image
filter to return a GrCustomStage representing that filter.
Note that this patch does not handle the border conditions correctly (the
[top|bottom][Left|Right]Normal() functions in the CPU implementation). That
will come in a future patch.
Review URL: http://codereview.appspot.com/6345081/
git-svn-id: http://skia.googlecode.com/svn/trunk@4535 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-07-11 16:01:22 +00:00
bsalomon@google.com
eb715c8d5c
VariableVisibility -> ShaderType
...
Review URL: http://codereview.appspot.com/6344103/
git-svn-id: http://skia.googlecode.com/svn/trunk@4534 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-07-11 15:03:31 +00:00
bsalomon@google.com
f3ccda7d4f
Fix assumption that enabled stage implies texture is present
...
Review URL: http://codereview.appspot.com/6353087/
git-svn-id: http://skia.googlecode.com/svn/trunk@4532 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-07-11 14:56:33 +00:00
tomhudson@google.com
cb325ceda1
Change TextContext handling of stages and draw targets; this allows us to
...
assert in GrContext::setPaint() that all stages are disabled every time
the paint is set.
Watch for possible performance implications.
http://codereview.appspot.com/6347043/
git-svn-id: http://skia.googlecode.com/svn/trunk@4531 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-07-11 14:41:19 +00:00
epoger@google.com
96dde45518
whitespace change to trigger Skia buildbots after master update/restart
...
git-svn-id: http://skia.googlecode.com/svn/trunk@4530 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-07-11 13:47:04 +00:00
bsalomon@google.com
3a52d68b40
Revert SkNO_RETURN_HINT fix in favor of a simpler fix
...
git-svn-id: http://skia.googlecode.com/svn/trunk@4529 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-07-11 13:30:08 +00:00
bsalomon@google.com
22f0761d78
Fix SkNO_RETURN_HINT warnings on mac/clang
...
Review URL: http://codereview.appspot.com/6392048/
git-svn-id: http://skia.googlecode.com/svn/trunk@4528 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-07-11 12:52:04 +00:00
bsalomon@google.com
38034861d6
Commit baselines for convexpaths GM.
...
git-svn-id: http://skia.googlecode.com/svn/trunk@4527 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-07-11 12:45:23 +00:00
mike@reedtribe.org
bad1b2ff1d
add SkPath::contains(x, y)
...
git-svn-id: http://skia.googlecode.com/svn/trunk@4526 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-07-11 01:51:33 +00:00
bsalomon@google.com
927ee823fc
Rebaseline due to r4518.
...
git-svn-id: http://skia.googlecode.com/svn/trunk@4525 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-07-10 21:56:41 +00:00
bungeman@google.com
37946b5b2e
Move animated view headers to correct directory.
...
git-svn-id: http://skia.googlecode.com/svn/trunk@4524 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-07-10 21:54:31 +00:00
rileya@google.com
ab2fe82840
Replace all instances of 'clear' with 'pop's in conical gradient pdf impl, looks like the pdf spec doesn't support Postscript's 'clear' stack operator. Should fix some warnings on mac buildbots.
...
git-svn-id: http://skia.googlecode.com/svn/trunk@4521 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-07-10 20:41:38 +00:00
rileya@google.com
6219728eec
Added pdf implementation of conical gradient.
...
Also fixed an erroneous comment in the gpu implementation.
Review URL: https://codereview.appspot.com/6351076
git-svn-id: http://skia.googlecode.com/svn/trunk@4520 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-07-10 20:05:23 +00:00
keyar@chromium.org
a4091ba864
Each benchmark that needs a bitmap will now make its own.
...
Before, the bitmaps were created and then passed to the benchmark. However, some benchmarks in the future will not require bitmaps. This will remove the necessity of passing around an extraneous bitmap to those tests.
Review URL: https://codereview.appspot.com/6356081
git-svn-id: http://skia.googlecode.com/svn/trunk@4519 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-07-10 19:53:59 +00:00
bsalomon@google.com
a51ab8416d
Preserve convex control point polygon in cubic->quadratic approximation
...
GM test modified, will require rebaselining.
Review URL: http://codereview.appspot.com/6355088/
git-svn-id: http://skia.googlecode.com/svn/trunk@4518 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-07-10 19:53:34 +00:00