AuroraMiddleware/skia2
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
14,809 Commits 1 Branch 0 Tags 544 MiB
4e8e3421aa
Commit Graph

14809 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
robertphillips
4e8e3421aa Move SkRecordComputeLayers and CollectLayers into SkRecordDraw.cpp 
Rather then exposing parts of FillBounds (as in Expose FillBounds to allow GrPictureUtils::CollectLayers to be layered on top of it - https://codereview.chromium.org/698643002/), this CL moves CollectLayers into SkRecordDraw.cpp to accomplish the layering.

Review URL: https://codereview.chromium.org/716913003
 2014-11-12 06:46:08 -08:00
joshualitt
b103d0c64a rebase 
TBR=
BUG=skia:

Review URL: https://codereview.chromium.org/717033002
 2014-11-12 05:44:25 -08:00
tfarina
a3d33c546f Cleanup: Remove submit_try script. 
It is probably broken, and by now nobody should be using it really
anyway.

BUG=None
R=borenet@google.com

Review URL: https://codereview.chromium.org/720603002
 2014-11-12 05:34:47 -08:00
reed
6a070dc06a experimental 
BUG=skia:

Review URL: https://codereview.chromium.org/716793004
 2014-11-11 19:36:10 -08:00
mtklein
ad8aa1dcf3 Clang incorrectly thinks this typedef is unused. 
BUG=skia:3059

Review URL: https://codereview.chromium.org/715093003
 2014-11-11 18:52:02 -08:00
egdaniel
cd8b6307fe Add isUnblended query to GrDrawState. 
BUG=skia:

Review URL: https://codereview.chromium.org/715873002
 2014-11-11 14:46:05 -08:00
bsalomon
453cf40ac7 Add GrGpuResource::CacheAccess 
Internal only helper class for manipulating and accessing cache keys.

BUG=skia:2889

Review URL: https://codereview.chromium.org/703303003
 2014-11-11 14:15:57 -08:00
scroggo
3c3fe7ce48 Revert of Move from libstlport to libc++ for Android framework builds (patchset #1 id:1 of https://codereview.chromium.org/714113002/) 
Reason for revert:
The code this depends on is not ready yet. We can submit once https://android-review.googlesource.com/#/c/113924/ is submitted.

Original issue's description:
> Move from libstlport to libc++ for Android framework builds
>
> Committed: https://skia.googlesource.com/skia/+/ce259510a738fab05a0d456440104f5aba1c9d72

TBR=tomhudson@google.com,djsollen@google.com
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/718793003
 2014-11-11 13:58:44 -08:00
joshualitt
4052a8e4f2 Remove coverage from grpaint 
BUG=skia:

Review URL: https://codereview.chromium.org/683133006
 2014-11-11 13:46:30 -08:00
reed
b969fc0f83 notice null colorfilter in legacy unflattening 
BUG=skia:3117

Review URL: https://codereview.chromium.org/691383003
 2014-11-11 13:13:35 -08:00
reed
f539b8cdee modify nothingToDraw to notice filters 
This reverts commit c71ffd4e76.

TBR=

Review URL: https://codereview.chromium.org/683003003
 2014-11-11 12:51:33 -08:00
bungeman
842ab70966 Fix "Add support for rebaselining from trybots." 
Commit d09ade4b44 was missing a needed edit.
 2014-11-11 15:28:02 -05:00
mtklein
c71ffd4e76 Revert of modify nothingToDraw to notice filters (patchset #1 id:1 of https://codereview.chromium.org/717753002/) 
Reason for revert:
modecolorfilters, perhaps more changed

Original issue's description:
> modify nothingToDraw to notice filters
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/d5688c509293a450c058e0cc1f4673be2931bb5c

TBR=djsollen@google.com,reed@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review URL: https://codereview.chromium.org/717813002
 2014-11-11 12:13:16 -08:00
reed
d5688c5092 modify nothingToDraw to notice filters 
BUG=skia:

Review URL: https://codereview.chromium.org/717753002
 2014-11-11 11:00:55 -08:00
mtklein
bf5dd4170f Add benchmark to compare different BBH query patterns. 
On my laptop:
maxrss	loops	min	median	mean	max	stddev	samples   	config	bench
  37M	1	14ms	14.2ms	14.6ms	18.2ms	9%	▁█▁▁▁▁▂▂▂▁	gpu	tiled_playback_tilegrid_tiled
  40M	1	17ms	17.2ms	17.2ms	17.6ms	1%	▆▃▁█▄▇▂▁▁▁	gpu	tiled_playback_tilegrid_random
  40M	1	14.6ms	14.9ms	15.8ms	19.1ms	11%	▂▁▁▁▁▁▁█▅█	gpu	tiled_playback_rtree_tiled
  43M	1	16.5ms	16.7ms	16.8ms	17.4ms	1%	▂▃▅█▃▂▁▃▃▂	gpu	tiled_playback_rtree_random
  43M	1	15.9ms	16.1ms	16.5ms	18.7ms	6%	▁▁█▇▁▁▁▂▁▁	gpu	tiled_playback_none_tiled
  44M	1	17.9ms	17.9ms	18ms	18.1ms	1%	▂▁▅▁▇▃▁▂█▇	gpu	tiled_playback_none_random

TileGrid and RTree perform pretty much the same, both beating no BBH.

BUG=skia:3085

Review URL: https://codereview.chromium.org/699313006
 2014-11-11 10:39:27 -08:00
scroggo
909b04b630 Fix Android framework build. 
Need to include (transitively) SkUserConfig before checking
SK_SUPPORT_GPU.

Review URL: https://codereview.chromium.org/693613005
 2014-11-11 09:45:33 -08:00
robertphillips
05699e5fe0 Remove multipicturedraw GMs from ignored-tests.txt 
TBR=jcgregorio@google.com

Review URL: https://codereview.chromium.org/718763002
 2014-11-11 09:42:38 -08:00
joshualitt
3595fc6a92 more gms to ignore 
TBR=
BUG=skia:

Review URL: https://codereview.chromium.org/691143006
 2014-11-11 09:28:30 -08:00
joshualitt
4dd9988642 remove separate color from coverage 
BUG=skia:

Review URL: https://codereview.chromium.org/699023003
 2014-11-11 08:51:30 -08:00
bsalomon
672550ddb6 Remove bogus assert 
content key can be set after pending io scheduled (e.g. when scaling up a npot texture to pot).

BUG=skia:2889
TBR=robertphillips@google.com

Review URL: https://codereview.chromium.org/693843004
 2014-11-11 08:29:01 -08:00
robertphillips
1e4595a050 Rebaseline problem (Galaxy S4) multipicturedraw GMs 
This CL rebaselines the buggy multipicturedraw GMs related to:

Always enable layer hoisting in Skia (https://codereview.chromium.org/698493002/)

TBR=jcgregorio@google.com

BUG=skia:3116

Review URL: https://codereview.chromium.org/715823002
 2014-11-11 08:17:39 -08:00
bungeman
d09ade4b44 Add support for rebaselining from trybots. 
This adds support to rebaseline_server to fetch actual results from
tryjobs run on rietveld issues.

Review URL: https://codereview.chromium.org/688353003
 2014-11-11 08:11:56 -08:00
robertphillips
28246af2ef Rebaseline multipicturedraw GMs 
This CL rebaselines the multipicturedraw GMs as a follow up to:

Always enable layer hoisting in Skia (https://codereview.chromium.org/698493002/)

TBR=jcgregorio@google.com

Review URL: https://codereview.chromium.org/714153002
 2014-11-11 07:55:45 -08:00
reed
79c77a405a update dox 
BUG=skia:
TBR=djsollen@google.com

Review URL: https://codereview.chromium.org/697363004
 2014-11-11 07:54:11 -08:00
joshualitt
43b46d1f56 rebase from early clip 
TBR=
BUG=skia:

Review URL: https://codereview.chromium.org/707413003
 2014-11-11 07:40:16 -08:00
egdaniel
69bb90c214 Remove cached OptDrawState from GrDrawState. 
Since we now snap and create the ODS one time in the inorder draw buffer,
there is no need for us to keep a cached version of it around.

BUG=skia:

Review URL: https://codereview.chromium.org/701123003
 2014-11-11 07:32:45 -08:00
reed
ddbc491151 guard call to CGColorSpaceCopyICCProfile in case we're building for iOS 
BUG=skia:

Review URL: https://codereview.chromium.org/712363003
 2014-11-11 07:27:25 -08:00
bsalomon
6d4488c5e0 Remove all knowledge of resource keys from the legacy cache. 
BUG=skia:2889

Review URL: https://codereview.chromium.org/705413002
 2014-11-11 07:27:16 -08:00
scroggo
a99f9eeed6 Reenable deprecation warnings on Android framework. 
Most recently introduced here: https://codereview.chromium.org/304333002

It appears these are not currently needed (I just disabled it and
successfully built).

Since we appear to be out of the transitional period, I propose we
remove them so we can know if we deprecate something Android uses
(and fix the call site).

Review URL: https://codereview.chromium.org/696063006
 2014-11-11 07:04:33 -08:00
djsollen
ce259510a7 Move from libstlport to libc++ for Android framework builds 
Review URL: https://codereview.chromium.org/714113002
 2014-11-11 07:02:03 -08:00
kkinnunen
839425177c Avoid warning in nanobench related to loop count with nvprmsaa4 
The tests path_hairline_{small,big}_AA_conic were calling the test
function with NVPR. This caused a warning in nanobench.

The here removed hunk comes from commit referring to skia:2042 ("Enable
NVPR by default"). This is a workaround for a bug. The bug is fixed by
the commit referring to skia:2078 ("Logan bot fails NVPR assertion in
bench").

The proper fix is indeed make sure that path renderer chain ends up
trying software path renderer, if the path contains conics and is a
hairline.

The removed hunk refers also to skia:2033 ("Figure out what is happening
with conic path segments in NVPR"). The above solution is correct also in case
NVPR would support conics, as NVPR would not still support hairlines.

BUG=skia:2078

Review URL: https://codereview.chromium.org/685213005
 2014-11-11 06:57:07 -08:00
mtklein
5da116f920 start again on Sk4x with portable version and unit tests 
work on tests

CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu13.10-GCE-NoGPU-x86_64-Debug-ASAN-Trybot,Test-Ubuntu12-ShuttleA-GTX660-x86-Debug-Trybot,Test-Win7-ShuttleA-HD2000-x86_64-Debug-Trybot,Test-Win7-ShuttleA-HD2000-x86-Debug-Trybot
BUG=skia:

Review URL: https://codereview.chromium.org/704923003
 2014-11-11 06:16:42 -08:00
reed
c536942dc9 initial checkin for experimenting 
BUG=skia:

Review URL: https://codereview.chromium.org/696063005
 2014-11-11 04:56:05 -08:00
robertphillips
81f71b6630 Change where layer hoisting data is gathered 
This CL:
1) removes the EXPERIMENTAL_optimize on SkCanvas & SkDevice
2) moves the saveLayer gathering step to endRecording
3) Replaces GPUOptimize with SkRecordComputeLayers
4) Update bench_pictures & render_pictures to provide the new flag

#2 also necessitated moving the BBH computation (and record optimization) out of SkPicture's ctor (and into endRecording)

Review URL: https://codereview.chromium.org/718443002
 2014-11-11 04:54:49 -08:00
skia.buildbots
bffcb52ffe Update SKP version 
Automatic commit by the RecreateSKPs bot.

TBR=

Review URL: https://codereview.chromium.org/711253003
 2014-11-10 23:03:28 -08:00
joshualitt
d53a82706e Snap optdrawstate in inorder draw buffer and pass into gpu 
BUG=skia:

Review URL: https://codereview.chromium.org/709133003
 2014-11-10 16:03:15 -08:00
halcanary
ac6c4fc524 tests/Time.cpp: more verbose errors 
Review URL: https://codereview.chromium.org/711143002
 2014-11-10 14:39:24 -08:00
halcanary
be519ad718 Simplify canvas calls in SkDocument_PDF 
As suggested by reed@ in http://crrev.com/711133002

TBR=reed@google.com

Review URL: https://codereview.chromium.org/707533003
 2014-11-10 14:22:15 -08:00
scroggo
207a1c96ee Remove outdated comment in SkImageDecoder.h 
The comment was no longer relevant with
https://codereview.chromium.org/483593002

Review URL: https://codereview.chromium.org/715673002
 2014-11-10 14:18:24 -08:00
halcanary
93f8161293 SkDocument_PDF does somthing with the trimBox parameter. 
Fixes change introduced in http://crrev.com/645563002

This will allow SkDocument to be a drop-in repalcement to
SkPDFDocument/SkPDFDevice in Chromium.

Review URL: https://codereview.chromium.org/711133002
 2014-11-10 14:01:57 -08:00
bungeman
c9232dcda0 Remove SK_FM_NEW_MATCH_FAMILY_STYLE_CHARACTER. 
This removes the old guarded code and enables the new api
introduced with "Update fontMgr to take list of bcp47 language tags."
c20386e393 . Blink on Android is
already using the new code.

Review URL: https://codereview.chromium.org/705843004
 2014-11-10 13:29:33 -08:00
scroggo
b61e206138 Add tests (and fix!) for known bad ICO files. 
We previously saw crashes decoding bad ICO files. Add tests for
known bad files.

While testing, I learned that one of them still crashes. Check for
large offset and size separately to fix the crash.

BUG=skia:2878

Review URL: https://codereview.chromium.org/712123002
 2014-11-10 13:12:25 -08:00
jvanverth
428b2a5a4f Re-enable no-longer-flaky GMs 
TBR=jcgregorio@google.com

Review URL: https://codereview.chromium.org/684413004
 2014-11-10 12:12:55 -08:00
bsalomon
fe369ee34b Move GrResourceKey static functions from .h to .cpp to fix shared lib builds 
TBR=robertphillips@google.com

Review URL: https://codereview.chromium.org/718493002
 2014-11-10 11:59:06 -08:00
bsalomon
8b79d23f82 Use GrResourceCache2 to service content key lookups 
BUG=skia:2889

Review URL: https://codereview.chromium.org/707493002
 2014-11-10 10:19:06 -08:00
halcanary
8e74b1565c Fix SkTime::GetDateTime Posix implementation, add unit test. 
The year was off by 1900

Review URL: https://codereview.chromium.org/714633002
 2014-11-10 09:20:22 -08:00
reed
7c74885e01 flag imageinfo as srgb 
intended uses:
- flag a SkSurface as sRGB (only supported by Ganesh for now)
- flag images (e.g. png or jpeg) as sRGB if the codec tells us that

wins:
- faster gamma-correct text (esp. w/ distance-fields) when we can use sRGB for text
- better color fidelity when the screen really is sRGB

Review URL: https://codereview.chromium.org/676883003
 2014-11-10 08:57:21 -08:00
robertphillips
6beeb8f3cc Small refactoring of layer discovery code 
This CL removes CollectLayers' reliance on having the top most picture (by removing the unused fPictureID member). This then allows making CollectLayers' API closer to that of SkRecordFillBounds in order to facilitate using them interchangeably.

Review URL: https://codereview.chromium.org/714533002
 2014-11-10 08:48:29 -08:00
jvanverth
ebb4fa3ee3 Update some flaky GMs to see if they stick. 
TBR=jcgregorio@google.com

Review URL: https://codereview.chromium.org/713893002
 2014-11-10 08:27:31 -08:00
robertphillips
a63f32e879 Address MSAA rendering in layer hoisting 
This became relevant whilst attempting to rebaseline the multipicturedraw GMs after turning on layer hoisting inside Skia.

Review URL: https://codereview.chromium.org/709943003
 2014-11-10 08:10:42 -08:00