AuroraMiddleware/skia2
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
27,503 Commits 1 Branch 0 Tags 544 MiB
4f783f8ada
Commit Graph

622 Commits

Author SHA1 Message Date
Stephan Altmueller
babb101291 Move iOS app packaging to the cloud 
This moves the signing and packaging of 
ios apps from the host that drives the device
to the cloud machine where the app is built.
This is in preparation of moving to Raspberry Pi 
hosts.


BUG=skia:5331

Change-Id: I4918272a6c734f5344351f0726b7721fde042234
Reviewed-on: https://skia-review.googlesource.com/9906
Commit-Queue: Stephan Altmueller <stephana@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
Reviewed-by: Mike Klein <mtklein@chromium.org>
 2017-04-05 16:29:13 +00:00
Kevin Lubick
be5387b930 Remove Tab3 from pool 
This device is rather old and was continuously failing anyway.

Bug: skia:
NOTRY=true
Change-Id: Ifd0bed7ded76c805993973f835c1d11f35802d00
Reviewed-on: https://skia-review.googlesource.com/11341
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
 2017-04-05 11:51:04 +00:00
Kevin Lubick
261ea19c4d Add recipe to build for Asus Flip Chromebook 
This build includes the GPU-specific code (EGL, GLES)

The armhf_sysroot should be generic enough to support
other ARM targets, like the Raspberry Pi.

I split out the EGL dependencies into their own CIPD package
(chromebook_c100p_lib) to facilitate the modularity of the approach.

When we add another ARM chromebook, maybe one that has different libraries,
we should be able to re-use armhf_sysroot and then a newly created CIPD asset for
that specific GPU (if needed).

Maybe this also can be used to build for the chromecasts (thus the TODO)

Bug: skia:
NOTRY=true

Change-Id: Icc131025932dc8d41da5be39f3c5cad0aa95d848
Reviewed-on: https://skia-review.googlesource.com/11064
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
 2017-04-05 11:39:04 +00:00
Mike Klein
35ffbe65ae Revert "Update clang linux to release_40" 
This reverts commit a08104abf2.

Reason for revert: MSAN's failing immediately, and ASAN is catching a new leak:

==20306==ERROR: LeakSanitizer: detected memory leaks

Direct leak of 4112 byte(s) in 257 object(s) allocated from:
    #0 0x138828b  (/b/s/w/irNps76D/out/Release/dm+0x138828b)
    #1 0x2c07b76  (/b/s/w/irNps76D/out/Release/dm+0x2c07b76)



Original change's description:
> Update clang linux to release_40
> 
> Bug: skia:
> Change-Id: Ibe2406592024a4eb20b278ad189d3abddec129d9
> Reviewed-on: https://skia-review.googlesource.com/11285
> Reviewed-by: Mike Klein <mtklein@chromium.org>
> Commit-Queue: Mike Klein <mtklein@chromium.org>
> 

TBR=mtklein@chromium.org,mtklein@google.com,kjlubick@google.com,reviews@skia.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Change-Id: I178c129cf19ed38f0a91ea3eea583643daadc2c7
Reviewed-on: https://skia-review.googlesource.com/11288
Reviewed-by: Mike Klein <mtklein@chromium.org>
Commit-Queue: Mike Klein <mtklein@chromium.org>
 2017-04-04 20:35:06 +00:00
Kevin Lubick
a08104abf2 Update clang linux to release_40 
Bug: skia:
Change-Id: Ibe2406592024a4eb20b278ad189d3abddec129d9
Reviewed-on: https://skia-review.googlesource.com/11285
Reviewed-by: Mike Klein <mtklein@chromium.org>
Commit-Queue: Mike Klein <mtklein@chromium.org>
 2017-04-04 20:03:04 +00:00
Eric Boren
8b3f9e64ff Bundle recipes for use on RPi 
This saves ~1:30 of overhead when the isolate cache is warm.

Bug: skia:5813
Change-Id: I5053d66e865ca6500b82567f83be8042568e22cf
Reviewed-on: https://skia-review.googlesource.com/11063
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
 2017-04-04 16:01:47 +00:00
Ben Wagner
dbcb607f3c [cleanup] rename var in perf script to match sktest script 
NOTRY=true

Change-Id: Ib3c03092045289eb0828f951b1213ecab893d0d9
Reviewed-on: https://skia-review.googlesource.com/10969
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
 2017-04-03 19:35:42 +00:00
UpdateSKPs
e074b03677 Update SKP version 
Automatic commit by the RecreateSKPs bot.

TBR=update-skps@skia.org
NO_MERGE_BUILDS

Change-Id: If3040a5c77537c3696f1af89ea9ea39dc6938a1e
Reviewed-on: https://skia-review.googlesource.com/11026
Reviewed-by: update-skps <update-skps@skia.org>
Commit-Queue: update-skps <update-skps@skia.org>
 2017-04-02 06:25:45 +00:00
Ben Wagner
6b1f0249e6 Fix perf configs for ANGLE bots. 
Don't run non-ANGLE configs on ANGLE bots.

Also, stop perfing angle_gl_es2, since it's not used by Chrome. Add perfing for
ANGLE MSAA, and omit test that fails with MSAA config.

NOTRY=true
BUG=skia:6457

Change-Id: Iafe605a369e6bfddddeee3d30a538ec889eb0952
Reviewed-on: https://skia-review.googlesource.com/10968
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
 2017-03-31 21:04:36 +00:00
Kevin Lubick
92a3661af8 Update NVidia Shields to NRD90M 
BUG=skia:

Change-Id: I9411bfa3a9324224e2dd830a47fa025d750cbebc
Reviewed-on: https://skia-review.googlesource.com/10044
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
 2017-03-31 18:26:07 +00:00
Kevin Lubick
c9807b8428 Add Linux HD2000 jobs 
Bug: skia:6400
NOTRY=TRUE
Change-Id: I253ef2d0b137a4a36f26dcabb8cc4a1919ed9b60
Reviewed-on: https://skia-review.googlesource.com/10759
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
 2017-03-30 19:31:47 +00:00
Ben Wagner
1bc8508d59 Remove Galaxy J5 bot. 
NOTRY=true

Change-Id: I9288e5928a08fc57545866aad1cc8b70f86eed6d
Reviewed-on: https://skia-review.googlesource.com/10801
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
 2017-03-30 19:23:07 +00:00
Robert Iannucci
d1443efcb8 [recipes.cfg] Disable autoroller 
Bug: skia:
Change-Id: Ie87deb32bf2fb257b1aac25bdef9d5c978d0320b
Reviewed-on: https://skia-review.googlesource.com/10542
Reviewed-by: Ravi Mistry <rmistry@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
 2017-03-30 01:09:00 +00:00
Greg Daniel
978533c302 Remove blacklist of Vulkan GPUMemoryTest 
This was blacklisted on Nvidia Windows. A recent change was made that may
be a possible fix for this test involving the uploading of initial mip map
memory.

BUG=skia:6092

Change-Id: Ie75c4665bea1f5139a674b9e0f53a9aac4a97f98
Reviewed-on: https://skia-review.googlesource.com/10285
Commit-Queue: Greg Daniel <egdaniel@google.com>
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
 2017-03-29 18:29:22 +00:00
Kevin Lubick
334e88c21a Update Galaxy S7s to March 2017 patch 
Bug: skia:6434
NOTRY=true
NOTREECHECKS=true

Change-Id: I7daaccbf14facb4dec8929e0e819add7c4e41a46
Reviewed-on: https://skia-review.googlesource.com/10398
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
 2017-03-29 12:07:21 +00:00
recipe-roller
03fde118be Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/bb49d6609717078440ca257a1960cd34033bd047 build_scan.py: Add scripts/master to path (hinoka@google.com)

TBR=iannucci@chromium.org

Change-Id: I82c58c585d6a3e470aee13b788c32c52cc6e6297
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Reviewed-on: https://skia-review.googlesource.com/10332
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
 2017-03-28 23:18:38 +00:00
recipe-roller
8383ac46c6 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/d67cc72477ac9cf51dac9ff5aa56fd5f996f09d9 Roll recipe dependencies (trivial). (recipe-roller@chromium.org)
  https://crrev.com/720ae5cfa1f63afa71fa2e753a3d43cc0b166b28 [recipes.cfg] set autoroll recipe options (iannucci@chromium.org)
depot_tools:
  https://crrev.com/b2e5564353be2974b1241d1bd57b3259100b14ea [recipes.cfg] set autoroll recipe options (iannucci@chromium.org)

TBR=borenet@google.com

Change-Id: I8e4aea83c0d89e6933d1563bd790bd85cc5e33f2
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Reviewed-on: https://skia-review.googlesource.com/10328
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
 2017-03-28 22:37:34 +00:00
Robert Iannucci
d60ec06047 [recipes.cfg] set autoroll recipe options 
Bug: skia:
Change-Id: Icdc01ffba00dfda37bcb467f2a4a33aef0991f56
Reviewed-on: https://skia-review.googlesource.com/10245
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
 2017-03-28 19:57:32 +00:00
Robert Iannucci
7a69340368 Manually roll recipes (trivial) 
build:
  https://crrev.com/cd172a28588cc11a2ea2d3ee591bbcb7a1fc3ba8 Dart: Remove ie10 from builders, remove some FYI builders
  https://crrev.com/f0b49fc15bf7bc2d9e39210e091f0dd4481da1c4 Revert "chromite: Change cbuildbot/api to to cbuildbot_launch."
  https://crrev.com/988789b7bf6b0bdf1033ee178da4e28340137dab Roll recipe dependencies (trivial).

depot_tools:
  https://crrev.com/5904e2a3d7b88b8609681c7354bf2ae2c1f2bed6 Roll recipe dependencies (trivial).

recipe_engine:
  https://crrev.com/4fcdb75517198a9ca32c7c4aecbe2e6f54b8b6c2 [package.proto] convert deps from list to map.

Bug: skia:
Change-Id: I7aa2236d39e2ec6f882d589a4719dca4baca7500
Reviewed-on: https://skia-review.googlesource.com/10243
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
 2017-03-28 17:29:34 +00:00
Robert Iannucci
654dfeeace Manually roll recipes (trivial) 
Also converts recipes.cfg to new JSONPB format.

build:
  https://crrev.com/cf2a231cfaea22f03affe7d3ccdf8634d35a855d flutter: rename libsky_shell.so to libflutter.so
  https://crrev.com/47f1d3af26e30e7120f18450f28dd9ad095f69ba Roll recipe dependencies (trivial).
  https://crrev.com/67b26be7760cdce0e165e39e3d7cc88101725429 Allow passing arg to `repo sync` in chromite module
  https://crrev.com/6b2f23904dfb05b0b382cea4a9db373ec1041696 chromium: Adding tansell@chromium.org as OWNER for Chromium recipes.
  https://crrev.com/3966f1d05c265be673d4a4e52983370680bd2741 Dart: Add gclient runhooks to SDK builder recipe.
  https://crrev.com/3f370ccee1f85de227a40a27f384b1fd47811148 Install goma for cbuildbots.
  https://crrev.com/c9ea42272c232c77bffb476a64243ca6663fff44 Roll recipe dependencies (trivial).
  https://crrev.com/2458a11e565207234a11f0745b6c04c042e7d636 Roll recipe dependencies (trivial).
  https://crrev.com/c255c84a5881e193dcc7c6037cc37badb35c26c9 flutter: rename sky_shell to flutter_tester
  https://crrev.com/49099195df9831c746bc6437aea4b50bce14965d chromite: Change cbuildbot/api to to cbuildbot_launch.
  https://crrev.com/0ce9a9f88802d6be5e016b8a4efc190a21441e29 Roll recipe dependencies (trivial).
  https://crrev.com/e2406a2458aa7697979d6df86e92892077f16822 Roll recipe dependencies (trivial).

depot_tools:
  https://crrev.com/2e401be12ef1ec44f4a81c6bc8acaf793c71e4de Roll recipe dependencies (trivial).
  https://crrev.com/8b5b594115480a6b4c4bbe384cc7afaecd814a4b add "generic" infra path config
  https://crrev.com/284e34ae2878ddd2cda671554b444db8512fa2ab Revert "add "generic" infra path config"
  https://crrev.com/f7023e7cf0a6606080d9f53c5a9e6e8271443914 Roll recipe dependencies (trivial).
  https://crrev.com/757f20796948ff4a9264dad5293bdff2f94d9c43 Reland: add "generic" infra path config
  https://crrev.com/e663133f6f2695efba0705e82ee581f6eb424e6c Roll recipe dependencies (trivial).

recipe_engine:
  https://crrev.com/51395b1ba1ea684f5e99d2bb03c934f2ac441984 [recipes.cfg] ONLY support jsonpb.
  https://crrev.com/230fcdf5d57a084071e3617885b3286353ab1350 [package.proto] add options for autoroller recipe to recipes.cfg.
  https://crrev.com/8ec7b6d3ca59e7c178ad1b03e4408da556fddafa [recipes.cfg] set canonical_url and autoroller options

Bug:

Change-Id: I8308cf3633258703a3bd24ab49bf6e0db6c87cc9
Reviewed-on: https://skia-review.googlesource.com/10242
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
 2017-03-28 11:51:16 +00:00
Ben Wagner
c119a2f3b5 Omit ImageStorageLoad on IntelBayTrail Ubuntu 
BUG=skia:6358
NOTRY=true

Change-Id: I1d85bc37008988220c0454e8ec4a72bef2ec043d
Reviewed-on: https://skia-review.googlesource.com/10100
Reviewed-by: Ethan Nicholas <ethannicholas@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
 2017-03-27 21:02:29 +00:00
Kevin Lubick
465748c246 Update ATT Galaxy S7 to Android N 
This updates both Galaxy S7s to use the longer device_os added in
https://chrome-internal-review.googlesource.com/c/339125/
to avoid subtle version skew when Galaxy S7 applies an update but doesn't
toggle Android version.

BUG=skia:
NOTRY=true

Change-Id: I7c0a3197592f8738abae46ffb3e31dc0f50d2b6a
Reviewed-on: https://skia-review.googlesource.com/10178
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
 2017-03-27 16:24:41 +00:00
Robert Iannucci
cf3ee92854 Manually roll recipes (trivial) 
All up to date!

build:
  https://crrev.com/f2c0ca26abeccab331fc6bd8c7c0514165a78e54 Roll recipe dependencies (trivial).
  https://crrev.com/843d18d4c63d75f0eb68a2df934baab02c0bf6c4 swarming: Improve collect_isolated_script_task error handling.
  https://crrev.com/9af80f3466b63bdd4a5d75345795c3516a20a522 Roll recipe dependencies (trivial).
  https://crrev.com/feba551470a06709553c1e96d0a03f13deca07ed WebRTC: Fix packaging of iOS API Framework.
  https://crrev.com/b82322f802034133234fc7016150d842d6b9e987 V8: Add more indirect dependencies.
  https://crrev.com/6067fa67669785c0fc3172dcb80dd0de2d452d19 swarming: collect_isolated_script_task changes.
  https://crrev.com/379d0539704468101ca772ba0c0b084ed164daa7 WebRTC: Add rtc_enable_bwe_test_logging=true to more configs bots.
  https://crrev.com/323e766b5401d5649909df231ecf7c581fce298a Enable service tests on kernel builders
  https://crrev.com/fb25c3b3af9ae0e62d55ce8837470e6939256ae2 Remove unused skia_swarming and CT recipe modules
  https://crrev.com/890c03dc5c040219372674ac321765460e01d016 Add gen/skia/public/interfaces to generated bindings paths
  https://crrev.com/1f580164c505a6d5f4c80c1a298cdb461e3fafdc Remove unused recipe expectations
  https://crrev.com/36ee491ef076c973bb7debf85ca21f422f4da279 Roll recipe dependencies (trivial).
  https://crrev.com/2fa361b5f8b4f7fb70fe01928897f8a08427258d Roll recipe dependencies (trivial).
  https://crrev.com/dcd5ed1a860a2dc0825a8ea49f7b130b6c947d92 Rename Quadro M2000 machines to Quadro P400.
  https://crrev.com/7c59a8aef946bf372345a47b70f3a013e7af34ad Roll recipe dependencies (trivial).
  https://crrev.com/47899c1186474197f5fe8d17390b8d6299f89fee crashpad: Make tests work with paths instead of configuration names
  https://crrev.com/df7c8aed80f6fa17717a4eef7d22c8a359e5c080 Use isolate go binary on iOS FYI builders
  https://crrev.com/7e669897df98ea92c5d63d6f4be03ac5f3380908 Roll recipe dependencies (trivial).
  https://crrev.com/78eaaf5947ea93387ec9ff7c578bf32676500194 Run new recipes 'test' command
  https://crrev.com/03c61e3c727963a97435adcb7fda3351e420e4a6 WebRTC: Add webrtc_perf_tests to Android trybots.
  https://crrev.com/18868576df07b88794c5b5402f011a165bb61fb7 Fix recipe tests
  https://crrev.com/eca15296bf0f928789c471f134c7cc9f8e34452d Add patch size estimation to Android perf builders.
  https://crrev.com/b71ef7dff40d848b8878373eedb599fe98709a04 WebRTC: Add bwe_simulations_tests sanity check.
  https://crrev.com/ce3f62b49d89a8e02f006159e3a460b0c856c3fb Enable uploading images to skia gold in parallel
  https://crrev.com/b05c4bc3761d4c41d70952e0bcf2efa71cb174af Roll recipe dependencies (trivial).
  https://crrev.com/d87947e7dc733a192b4d29fd32cfb7c8c9791daa Roll recipe dependencies (trivial).
  https://crrev.com/26c73a64dd8f6c17f73cdbc5b2324df2ccda3389 Remove NVIDIA Shield GPU.FYI bot
  https://crrev.com/ad447d745f0b15d374d977f0a355e4d910861f33 Gatekeeper: Pass in credentials for accessing Milo
  https://crrev.com/4e48b5ec0b17fa90512a2abb5c8302556c468cf4 Make 'Android Builder (dbg)' download VR test APKs
  https://crrev.com/379e6a8c13e2c12fe10676c3ff31d8864aadbca7 Use isolate go binary for all iOS builders
  https://crrev.com/ddc2f1946cebc0fee8a726704277a9ee08c64900 Simplify layout_test_wrapper.py (take 2).
  https://crrev.com/b69e0ff7c3c6609297730fc796fc0863805c1662 Fix command argument list in layout_test_wrapper.py.
  https://crrev.com/30584dea7ace8de1ac915cb186ca68b99e176cf9 chromium: Fixing the results handler for LayoutTests.
  https://crrev.com/b192b269842218eb78a467e9a520ff9b6c2446db Rename Win AMD R5 230 to R7 240 after GPU swap.
  https://crrev.com/4ff14cf2450222d65926c67acb2e319bc2cd96b7 Hacks to run locally
  https://crrev.com/e4d63fc7eac4b4f7d4e24d5252a83a189a760931 Revert "Hacks to run locally"
  https://crrev.com/62e780a27c4f11cec2a63a113ffc3273dcff3320 WebRTC: Add low_bandwidth_audio_test on desktop.
  https://crrev.com/26805613e283cd0c796bfe37143026bc89bb1446 WebRTC: Add building of low_bandwidth_audio_test to perf bots
  https://crrev.com/ac4da194a237c33a590c3518515c2ea148037f86 chromium: Fixing the test results handler for skipped tests.
  https://crrev.com/786366148079983fd99174150715b5b819d7a303 chromium: Process the full WebKit Layout Tests results.
  https://crrev.com/8bcb947602f5586c890174bf48529761ec1e6289 chromium: Change WebKit Layout Tests results upload.
  https://crrev.com/072216afe61f9604972a1aceedabc34685053b6e Revert "chromium: Process the full WebKit Layout Tests results."
  https://crrev.com/d7dea9fe527267a9cb0137ea7642cc289d6a7365 WebRTC: Use test name instead of command for perf_dashboard_id fallback.
  https://crrev.com/ba9dbab1eca7aee547b9b844ca5b415f0af81b57 Move to new angler device.
  https://crrev.com/fca33caaf9efacc4011304ab7ad3791c2b06a2a5 WebRTC: Remove low_bandwidth_audio_test on Mac and Windows.
  https://crrev.com/898c6ac014d81e25bdc2f2ffa499d6cf623ff82d Roll recipe dependencies (trivial).
  https://crrev.com/ef3b843e396d4bf5dc58809dbc6fe9999e1b8b5f Revert "Gatekeeper: Pass in credentials for accessing Milo"
  https://crrev.com/107f5de0aa9ad771f0e4ac7b9572b4081c7782ad Roll recipe dependencies (trivial).
  https://crrev.com/9d5c32ab34717333e7aedfabdd4118163b7f5eeb Roll recipe dependencies (trivial).
  https://crrev.com/4d8948186392e550f9113e0a0fd3bf8892da7894 Roll recipe dependencies (trivial).
  https://crrev.com/aa51b056ae211e3918489aa37b24a10f7feaec48 Roll recipe dependencies (trivial).
  https://crrev.com/ee25e07fc187ccbb2af62fe56bcc9444c3c5b9d3 [recipes.cfg] convert to JSON
  https://crrev.com/bd7fdc1212522513f464ca3f189018872ff26eca Revert "[recipes.cfg] convert to JSON"
  https://crrev.com/8d686035a02029411b43079563ecfe9a0c3777c3 Decommission Linux Release (AMD R5 230) GPU.FYI bot
  https://crrev.com/b9ede07dcc65de05933ce80fa23a0507fcd7c3c5 [remote_run] bump canary version of recipes-py.
  https://crrev.com/4d843c3c4e2253fdbb674d91390bbcd03361e0fc [Findit] Run compile on last good revision if the culprit is the first revision in regression range.
  https://crrev.com/6c1d2f31109446c7ae7d2e1fec69437a68e02da0 Gatekeeper: Use milo
  https://crrev.com/655fd4581bc29b89d0bbde07c71d2df3ff9095c9 reland "Gatekeeper: Pass in credentials for accessing Milo""
  https://crrev.com/d13b1feb856b8159917c591c806a606e4fe5e4d3 Gatekeeper: Don't be verbose
  https://crrev.com/e3eedb9983fa7966f99536baae6ebc26272fd60d Retry tests without the patch on iOS try bot failures
  https://crrev.com/c15677597961c6f980914ce5e25e95d02323c722 [remote_run] bump prod version of recipes-py
  https://crrev.com/b40d5bac94616d5df8e6317fd4c8919a0ec67e3b chromium: Make layout-test-wrapper produce the full results.
  https://crrev.com/c8b04fa68d968242aae885947bacdb7116d6886b Reland: [recipes.cfg] convert to JSON
  https://crrev.com/17f33c9a7735dba20c9d80f954eeaabdd28e72d1 [remote_run.py] bump kitchen canary version
  https://crrev.com/63e56fb2bd232f5929c0376d681ef18312058168 chromium.fyi: Remove BlinkStep from Linux RandomOrder bots.
  https://crrev.com/dda63076137c0ef95b5d64f62a5c67d9e6bf84be Roll recipe dependencies (trivial).
  https://crrev.com/e7de363248f87ec5e004375edb55d4ff4a148c3c Manually roll recipes.cfg
  https://crrev.com/3325687c9d892d7dee9ea639c9557a4920032c91 Invoke dart-sdk-* builders via recipes, add trigger at the end
  https://crrev.com/111855ccccb7ac786af35256462317fe714f698f Add new Dart analyze source recipe and builder to FYI
  https://crrev.com/7616b7167c887b266c2ba12c5796717b53b075f8 V8: Bump shards on slowest bots
  https://crrev.com/739b537a90ab43eda58b0d16f87a38f151b02b4a Roll recipe dependencies (trivial).
  https://crrev.com/26d3abcaa429c315ebfe56ecf1bc503b1ccaca97 Roll recipe dependencies (trivial).
  https://crrev.com/7486b36c875fa1410613e8eea0f6d084bfe8a0b2 Add maksim.sisov@chromium.org to Ozone Linux bot
  https://crrev.com/4dbb302e82655768d714dff8b58601a321bef8a7 Roll recipe dependencies (trivial).

depot_tools:
  https://crrev.com/e08398fde847b8afe7822652b79c2b0dcd16308a Roll recipe dependencies (trivial).
  https://crrev.com/c07db621521d62557d089b3e94484c1831395487 Roll recipe dependencies (trivial).
  https://crrev.com/e718958ca03fc0766459fecf7820a300b206d7be define builder_cache base path
  https://crrev.com/b87fa094099214b2f2c433f2590c6c62f1493e7f Roll recipe dependencies (trivial).
  https://crrev.com/14db1dfd88b987c9119f59f75f1f27b8e7c49602 Revert "define builder_cache base path"
  https://crrev.com/7a1f04d377764d9039cde0c4aa4b55c42a411c23 Implement presubmit API to get the old contents of an affected file.
  https://crrev.com/2da34fea2979af25cf1c7ff5f5e5dfbb70d2339c Fix typo in pydoc for OldContents().
  https://crrev.com/42494916d40bb9f92d7fe4732f9a5623bcbb67e6 Roll recipe dependencies (trivial).
  https://crrev.com/8d63166147f518efdc84f6b9082b4161e0188991 Roll recipe dependencies (trivial).
  https://crrev.com/d75686454bb0ad8d4718ff6bf9613772ca8027b5 gerrit_util: Use httplib2 for communication instead of httplib.
  https://crrev.com/25ab6a34c2d37ed806e49c334c8b79404d03c8f1 Revert "gerrit_util: Use httplib2 for communication instead of httplib."
  https://crrev.com/89d04858c88d91acf491e259d293ba3206713357 gerrit_util: Use httplib2 for communication instead of httplib.
  https://crrev.com/05c96f1fab336629a713713094049e1edecbc651 Roll recipe dependencies (trivial).
  https://crrev.com/3a16ed155e3f7ac56db71f207d5779fc97c3bae8 Use Bug: footer for Gerrit CLs
  https://crrev.com/8ec608527e095382a640f3cb1c30464ad1dce850 bot_update: don't retry rebasing Gerrit patches.
  https://crrev.com/2add8a99684cdc6c68a25e2dd7dba6dcf680c129 Roll recipe dependencies (trivial).
  https://crrev.com/e9b94890b6de526673e6995e1395353b1e752299 [recipes.cfg] convert to JSON
  https://crrev.com/f14709556d5d51394ac8f7d603d14795eba2c883 Move recipes to their own subdirectory
  https://crrev.com/5afa324b6a6908060b8ca2c5138e637ae4507885 Roll recipe dependencies (trivial).
  https://crrev.com/f83e262e6d10b480df069129c3eddfab0a22c4b7 Adjust paths in bot_update.py after moving recipes to subdir
  https://crrev.com/bb86fbbef1e7b8eb279a88f4548f059527d2810b git cl upload for Gerrit: warn if uploader is not CL owner.
  https://crrev.com/296bd843290fd661d2645322137c9d9925c4cfd7 Update to packaging script for VS 2017
  https://crrev.com/ce0080373244a65ba8f8bc8766096e96472e51e3 Roll recipe dependencies (trivial).
  https://crrev.com/cb23864e6801c27e0fb9a2ec908e1e8a24382a71 Roll recipe dependencies (trivial).
  https://crrev.com/5be3bdd70e1d95b88c93ca38c0c870e2399dede7 Roll recipe dependencies (trivial).

recipe_engine:
  https://crrev.com/fb61dcf4145be9d98f85d02af72a498f09782800 [autoroll] cache commit_metadata operations.
  https://crrev.com/6488afec4a1b4ac51a8601e308c42cd6a176c190 [recipes.cfg] upgrade recipes.cfg to JSON.
  https://crrev.com/157bae7bdfe2608d4bff84eaa90db0fdae71e26b Add structured JSON result output to new 'test' command
  https://crrev.com/ef924b01de36ab3c70e79f7782acb3f66ffdd3fd [package.proto] Make recipe json loading forwards-compatible
  https://crrev.com/3e8a9964590120020a29e2749a99c043197d088b repo_test_util: use new 'test' command
  https://crrev.com/033f8117b5cb6de01ad56606aca0437b2ba7cd7c Update documentation about recipe tests
  https://crrev.com/3125a3b89e18dff89cf6d59f0a0486d832521bf1 [recipes.cfg] Switch to json for real, add canonical_repo_url.
  https://crrev.com/fd0d8541ec8f579c68bf8214acfaf08f23117882 autoroll: use new 'test' command
  https://crrev.com/e3bd68e54e94d7ec339fd7c8d90544975386f4fe Add support for recipe/test filters in new 'test' command
  https://crrev.com/4439877a3ea1acd4c3f4cf805fba138aeb5b16a5 [test_test.py] make root_dir realpath.
  https://crrev.com/84b34416f3e1b1582cf81ab7ffea34f1e84b1c95 [package.py] No trailing whitespace in json proto dump.

Bug: skia:
Change-Id: I0f4b1a8fcac9d0b3fc20a713b2caf3b1ba629db7
Reviewed-on: https://skia-review.googlesource.com/10127
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
 2017-03-27 14:30:31 +00:00
Robert Iannucci
bf3bf86709 Manually roll recipes 
build:
  crrev.com/232ecb4e8e9a3175db1c14449dca0230ae01b80c Switch to an explicit swarming.summary placeholder instead of json.output.

Bug: skia:
Change-Id: I7c0dd6ce6225d48541c574ff6f38ea70e1823f1f
Reviewed-on: https://skia-review.googlesource.com/10126
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
 2017-03-27 13:48:19 +00:00
Robert Iannucci
342977ced7 Manually roll recipes (trivial) 
build:
  https://crrev.com/758ae9ec2bff2bb48071f78b80af3f84177870e4 Roll recipe dependencies (trivial).
  https://crrev.com/0796b26a2bbec373b875a604d1adfa6b8a7b9b75 Roll recipe dependencies (trivial).
  https://crrev.com/a14699eda6eb7971c71167d36901e2a374f6b744 Remove old recipe expectations
  https://crrev.com/2e802841367cdd8c47fb5a1b42f898948265b402 Roll recipe dependencies (trivial).
  https://crrev.com/34cf1f66235a1b70e97519055cbcff298971dd19 Remove recipe roller master from Kitchen whitelist
  https://crrev.com/f4a7f3ea36bd971090d02fa8dac321f0bfc867c1 Roll recipe dependencies (trivial).

depot_tools:
  https://crrev.com/0d6b46e32b99c7f6b7ecef5cde843aaf4e43449a git cl comment: require explicit --codereview with -i|--issue flag.
  https://crrev.com/aebadcc3a4349a0845fcab60242c6b146d0db1c8 Roll recipe dependencies (trivial).
  https://crrev.com/742adbd76f8d4c730866ba02d2e4b71524ce9049 Run new recipes 'test' command
  https://crrev.com/328f60d1a072d24b07e2726d447aa7c089c7b07e Roll recipe dependencies (trivial).

recipe_engine:
  https://crrev.com/aa0a2d61cd31decf9a5c048b677ba38eb209a1c6 Correctly handle tricky characters in test names in new 'test' command
  https://crrev.com/81de92519dd374d9b193362034fae8861476bc5f [autoroll] make autoroller propagate changes to recipes.py.
  https://crrev.com/0ee0446195595e5df02fc2dc82e4988b601b113e Carefully clean more unused recipe expectation directories in new 'test' command
  https://crrev.com/803d6ead998b4bbca601fb3a984e76ddc063806d Fix autoroll command.

Bug: skia:
Change-Id: I1a2bf0bf64b3ec9b27df785fcbf7d4b9e28727ac
Reviewed-on: https://skia-review.googlesource.com/10125
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
 2017-03-27 13:02:42 +00:00
Robert Iannucci
1af55b9a99 Manually roll recipes 
Removes unused recipe expectation.

build:
  https://crrev.com/e0f3d95ef043b98fcceb1f34b03f9b8fac091eb9 Roll recipe dependencies (trivial).

depot_tools:
  https://crrev.com/0bbe6fa00ef873080c4f6d145ea7a00497eeed3f Roll recipe dependencies (trivial).

recipe_engine:
  https://crrev.com/e300f3a3b8193b84b88599faa30c0301e155c906 Handle unused recipe expectations in new 'test' command

Bug: skia:
Change-Id: I3f00821de5b7f5158c6da2ff1206f2e1ec133e0f
Reviewed-on: https://skia-review.googlesource.com/10124
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
 2017-03-27 12:30:50 +00:00
Robert Iannucci
ad1de45fa5 Manually roll recipes (trivial) 
build:
  https://crrev.com/440839111a2a562ca2ac214817d821cd480146a8 V8: Bump shards on arm branch builders
  https://crrev.com/7b6d0f6ecffaef81bbbcb8ffc5a522df08fd7e02 Roll recipe dependencies (trivial).
  https://crrev.com/5be20abc2276ab5ae7ab83707ed4966710475aec gatekeeper_ng: whitelist more masters for CBE
  https://crrev.com/1efede1c3cd2b2435cb27cac164fcd61a98199ae Roll recipe dependencies (trivial).
  https://crrev.com/4715a9958d426ec473c6f3e62dd58687640484e4 Roll recipe dependencies (trivial).
  https://crrev.com/973870a62af1f77ac5356fbabd9a471a4fdf6c91 Add 'CFI ThinLTO Linux ToT' buildbot (recipes part).
  https://crrev.com/d2d4c12efbc6df3fc7d1a2eca3d461f1b6b2efb4 Roll recipe dependencies (trivial).
  https://crrev.com/82f8e1417a99f8251595f6f9a75bdbe0e400e8b5 Don't write .isolate as JSON
  https://crrev.com/55807bc812e28d83f30a2efbebc8ba113693eaae Push bisect changes to prod.
  https://crrev.com/b08eff6b36e7c66482b38fa179da7f4992da60d6 Roll recipe dependencies (trivial).
  https://crrev.com/03fd1250afda1212ca9b63b43c49ae5a68e0e53d chromium: Rework layout test results archiving.
  https://crrev.com/f30cd17e8aaf3def5994b8384da96ef56e80b3dd Add a cast audio bot.
  https://crrev.com/6e47d11dafc3ca058652d7c93a60080462f0961e Temporary workaround missing commit_position in blink_downstream DEPS.

depot_tools:
  https://crrev.com/625986dba7852518199ec002fd4cece02929f4ab git cl comment: implement adding comment for Gerrit.
  https://crrev.com/680253d31518b5865a45be4d63bc1ed74a4f16e9 git cl description: don't bother if description diff is trailing whitespace.
  https://crrev.com/d8aa49f35b8d3e981d0afc3d539aae35a2f89415 git cl comment: refactor fetching comments for Rietveld and add tests.
  https://crrev.com/5a0cf20452b7dac174dd0377f5b030379ba543ef git cl comment: implement fetching comments for Gerrit.
  https://crrev.com/ecf3dbe49fcf18982c5d8fbfd8a9ed30d6d9e714 Roll recipe dependencies (trivial).
  https://crrev.com/e86f6de84296601c61a3d3e6d7655e596535c4d6 Fix smoke test to not hard-code python executable location.

recipe_engine:
  https://crrev.com/78f105cbebb6e8dc99d64638d400868851cb0c40 Add --train support to the new 'test' command

Bug: skia:
Change-Id: Ib1abe064f6684dcd6bdbdbe2f17c5fa9c506299a
Reviewed-on: https://skia-review.googlesource.com/10123
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
 2017-03-27 11:52:49 +00:00
UpdateSKPs
d003e24f3f Update SKP version 
Automatic commit by the RecreateSKPs bot.

TBR=update-skps@skia.org
NO_MERGE_BUILDS

Change-Id: I78f9d076d702bdc7b7e0e58d60fd5b3c320707b8
Reviewed-on: https://skia-review.googlesource.com/10131
Reviewed-by: update-skps <update-skps@skia.org>
Commit-Queue: update-skps <update-skps@skia.org>
 2017-03-26 07:32:35 +00:00
Ben Wagner
37b1d84436 Omit tests causing IntelIris540 Vulkan to crash/fail. 
BUG=skia:6398
NOTRY=true

Change-Id: I630727a2d69116bfb49fe1dece7b6417e10c251c
Reviewed-on: https://skia-review.googlesource.com/9872
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
 2017-03-24 20:19:22 +00:00
Greg Daniel
d3caa77f3c Update Linux Intel Release driver with patch to fix Vulkan 
BUG=skia:

Change-Id: I973460374f2d4cbe141753ecd84cbefa68c9d8d0
Reviewed-on: https://skia-review.googlesource.com/10054
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Commit-Queue: Greg Daniel <egdaniel@google.com>
 2017-03-24 16:50:55 +00:00
Brian Salomon
528ca9bd91 Run angle in 8 sample msaa on desktop 
Change-Id: If752152daabcdb7420fd13863fea4ce49f725aab
Reviewed-on: https://skia-review.googlesource.com/10108
Reviewed-by: Brian Osman <brianosman@google.com>
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
 2017-03-24 16:40:34 +00:00
Greg Daniel
e2dad1081c Remove tests from blacklist for Vk AMD 
From recent changes these should now all pass.

BUG=skia:6396

Change-Id: I4423de1a192017794a732e5bb6eeef7ccc87407c
Reviewed-on: https://skia-review.googlesource.com/10048
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Greg Daniel <egdaniel@google.com>
 2017-03-23 19:36:33 +00:00
Kevin Lubick
4610a9b3c1 Consolidate Linux GCE dimensions 
It appears we were not setting the CPU for our Build
Tasks, which confused our capacity metrics.


BUG=skia:

Change-Id: I60cbe3b99b9de6865141f124df5618975bf65a05
Reviewed-on: https://skia-review.googlesource.com/10020
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
 2017-03-22 21:33:16 +00:00
Brian Salomon
4b33ef643e Disable msaa configs on Intel 
Change-Id: Ia66fa9c27ca2e5b7193b727c30bc0cf836a51c6d
Reviewed-on: https://skia-review.googlesource.com/10023
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
 2017-03-22 21:28:44 +00:00
Brian Osman
ca0913ceb9 Further widen nondeterministic processor testing 
Add in all Windows and Mac bots

BUG=skia:6395

Change-Id: Ib0d2b36330a44c7cb04833fad6d55b3aa884aafe
Reviewed-on: https://skia-review.googlesource.com/10007
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
 2017-03-22 16:27:18 +00:00
Matt Sarett
3adf1c3b94 Run discardable test bots as single-threaded 
This should fix any flakiness caused by dynamically exceeding memory
limits.

CQ_INCLUDE_TRYBOTS=skia.primary:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-SK_USE_DISCARDABLE_SCALEDIMAGECACHE

BUG=skia:4703

Change-Id: Ifd581539bacdb25a5f2f8f994c6c119d5576e294
Reviewed-on: https://skia-review.googlesource.com/9977
Reviewed-by: Mike Klein <mtklein@chromium.org>
Commit-Queue: Matt Sarett <msarett@google.com>
 2017-03-21 18:03:18 +00:00
Mike Klein
fa74caa095 Add iOS simulator support and a Build bot. 
CQ_INCLUDE_TRYBOTS=skia.primary:Build-Mac-Clang-x64-Release-iOS

BUG=skia:6329

Change-Id: I4a9d79469683797ff54727b6a1031f438939ce9b
Reviewed-on: https://skia-review.googlesource.com/9517
Commit-Queue: Mike Klein <mtklein@chromium.org>
Reviewed-by: Joe Gregorio <jcgregorio@google.com>
 2017-03-21 15:50:08 +00:00
Kevin Lubick
291547d4e7 Add Chromecast Perf jobs 
It starts out with some skps and resource-based perf
because all skps wouldn't fit and skimages are far too large

BUG=skia:

Change-Id: Icb07ffa84d39a85a8bc595e74ef934df921e749a
Reviewed-on: https://skia-review.googlesource.com/9901
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
 2017-03-21 14:52:26 +00:00
Stephan Altmueller
5f3b94074e Move build tasks to MacOS 10.12 
BUG=skia:

Change-Id: I5317dde5262ff6e880fa54a660f09205c616f1a4
Reviewed-on: https://skia-review.googlesource.com/9898
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Stephan Altmueller <stephana@google.com>
 2017-03-21 14:33:48 +00:00
Greg Daniel
a3b6a55151 In Vulkan make sure to add barriers between write operations 
BUG=skia:6396

Change-Id: I60faf6ad9095f18c64e33a0359e30239efbac79f
Reviewed-on: https://skia-review.googlesource.com/9963
Reviewed-by: Jim Van Verth <jvanverth@google.com>
Commit-Queue: Greg Daniel <egdaniel@google.com>
 2017-03-21 14:28:53 +00:00
Ben Wagner
bb91bd3a12 Enable GLES on Intel Linux bots. 
BUG=skia:6401
NOTRY=true

Change-Id: Ief434ca38ffd504198e8d3656a0a869d0faa9ebf
Reviewed-on: https://skia-review.googlesource.com/9822
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
 2017-03-21 13:53:13 +00:00
Eric Boren
bbb24f2ab8 Followup fixes for recipe roll 
Simplifying some environment madness. Nobody gets to modify default_env.
Always apply it in run.__call__(). Add depot_tools path to PATH in
default_env. Result is simpler but now default_env is applied in many
more places, which should be harmless.

BUG=skia:

Change-Id: I8299d50bde2bc3e2d47568a267d1d962a3fc3d56
Reviewed-on: https://skia-review.googlesource.com/9916
Reviewed-by: Ravi Mistry <rmistry@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
 2017-03-21 12:51:40 +00:00
Eric Boren
53262d0ff4 Roll Recipe DEPS 
BUG=skia:

Change-Id: Ic89d1b49aba842fb41c82ad6fc8f5ebe787893bd
Reviewed-on: https://skia-review.googlesource.com/9884
Commit-Queue: Eric Boren <borenet@google.com>
Reviewed-by: Ravi Mistry <rmistry@google.com>
 2017-03-21 11:07:41 +00:00
UpdateSKPs
29dd456c89 Update SKP version 
Automatic commit by the RecreateSKPs bot.

TBR=update-skps@skia.org
NO_MERGE_BUILDS

Change-Id: Ib127e14dbb73735e8ec509a4b76e66554c493e1c
Reviewed-on: https://skia-review.googlesource.com/9859
Reviewed-by: update-skps <update-skps@skia.org>
Commit-Queue: update-skps <update-skps@skia.org>
 2017-03-20 22:54:33 +00:00
Greg Daniel
c5cc2dee25 Set maxVertexAttrib limit for Vulkan 
BUG=skia:6396

Change-Id: If31507816ca9978a64d3bd25b282b373d292e7aa
Reviewed-on: https://skia-review.googlesource.com/9856
Commit-Queue: Greg Daniel <egdaniel@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
 2017-03-20 20:35:04 +00:00
Brian Salomon
9c614669fc Disable msaa nanobench on iOS due to crashes 
BUG=skia:6399

Change-Id: I9351579cdc78a59a99cc9ecbcac0c5146d186bd1
Reviewed-on: https://skia-review.googlesource.com/9902
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
 2017-03-20 19:00:19 +00:00
Eric Boren
a159085008 Roll Recipe DEPS 
Backing up from https://skia-review.googlesource.com/c/9884 due to failures.

BUG=skia:

Change-Id: I12182044191f5df56518f355262bbf83f8c5c1f8
Reviewed-on: https://skia-review.googlesource.com/9895
Commit-Queue: Eric Boren <borenet@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
 2017-03-20 17:36:33 +00:00
Brian Osman
c00f5306c5 Fix expected extension for CIPD on Windows 
New depot_tools copy is a batch file

BUG=skia:

Change-Id: Id1497f7f7d7d93600fbfbf5991f7582380781ae8
Reviewed-on: https://skia-review.googlesource.com/9896
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
 2017-03-20 16:45:13 +00:00
Brian Salomon
dcf0ab0dc5 Switch 16 sample gpu configs to 8 samples 
BUG=skia:

Change-Id: I053cce7c05c74860cbace00cd94ea4b96e9a482c
Reviewed-on: https://skia-review.googlesource.com/9889
Commit-Queue: Brian Salomon <bsalomon@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
 2017-03-20 16:22:17 +00:00
Ravi Mistry
25d540fa6e Enable CIPD automatic GCE authentication and fix upload_skps.py 
BUG=skia:6385

Change-Id: I4bb278f99eb3131138a37b7f8752ef404766811e
Reviewed-on: https://skia-review.googlesource.com/9824
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
 2017-03-20 16:14:01 +00:00