Commit Graph

477 Commits

Author SHA1 Message Date
reed
4a2a17dc83 unsuppress after rebaselining
BUG=skia:
TBR=
NOTRY=True

Review URL: https://codereview.chromium.org/824693002
2014-12-22 05:20:11 -08:00
joshualitt
f53ff623fa rebase coloremoji
NOTRY=True
TBR=
BUG=skia:

Review URL: https://codereview.chromium.org/822553002
2014-12-20 10:30:09 -08:00
joshualitt
290c09b8bb initial changes to add local matrix to primitive processor
BUG=skia:

Review URL: https://codereview.chromium.org/820523002
2014-12-19 13:45:20 -08:00
reed
f4ceea5219 update ignore list for prev CL
BUG=skia:
TBR=
NOTRY=True
NOTREECHECKS=True

Review URL: https://codereview.chromium.org/810123003
2014-12-19 07:54:11 -08:00
reed
438b0d754d Enable new gradients + suppress gms for now
This reverts commit 2c770271e6.

BUG=skia:
TBR=

Review URL: https://codereview.chromium.org/811753003
2014-12-19 07:40:26 -08:00
joshualitt
0cd35a24f2 rebase and update ignore
TBR=
NOTRY=True
BUG=skia:

Review URL: https://codereview.chromium.org/816963002
2014-12-19 06:47:20 -08:00
joshualitt
c2625821b3 Remove the low hanging fruit with coord change matrices
BUG=skia:

Review URL: https://codereview.chromium.org/793013003
2014-12-18 16:40:55 -08:00
joshualitt
334c9fb492 rebase blurrects
NOTRY=True
TBR=
BUG=skia:

Review URL: https://codereview.chromium.org/810593004
2014-12-18 15:52:56 -08:00
joshualitt
0f296d184f quick adding to ignore
NOTRY=True
TBR=
BUG=skia:

Review URL: https://codereview.chromium.org/795943003
2014-12-18 14:36:17 -08:00
joshualitt
72a3b0f0b9 rebase and update ignores
NOTRY=True
TBR=
BUG=skia:

Review URL: https://codereview.chromium.org/816813002
2014-12-18 14:24:35 -08:00
reed
2c770271e6 Revert of enable new gradients + suppress gms for now (patchset #1 id:1 of https://codereview.chromium.org/807513004/)
Reason for revert:
crashy

Original issue's description:
> enable new gradients + suppress gms for now
>
> BUG=skia:
> TBR=
> NOTRY=True
>
> Committed: https://skia.googlesource.com/skia/+/8142a57fa1bf582b66efde276cd43d40c525bc16

TBR=
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review URL: https://codereview.chromium.org/814963002
2014-12-18 12:59:39 -08:00
reed
8142a57fa1 enable new gradients + suppress gms for now
BUG=skia:
TBR=
NOTRY=True

Review URL: https://codereview.chromium.org/807513004
2014-12-18 12:53:37 -08:00
joshualitt
341400ea7b I could create new GMs if you prefer.
BUG=skia:

Review URL: https://codereview.chromium.org/812163002
2014-12-18 11:54:14 -08:00
joshualitt
cecb093334 adding bleed back to ignore
TBR=
NOTRY=True
BUG=skia:

Review URL: https://codereview.chromium.org/810713003
2014-12-18 11:08:48 -08:00
joshualitt
ccd552b007 rebase
TBR=
NOTRY=True
BUG=skia:

Review URL: https://codereview.chromium.org/812423002
2014-12-18 11:00:52 -08:00
joshualitt
16b2789895 Change to create device coord coordset
BUG=skia:

Review URL: https://codereview.chromium.org/812063002
2014-12-18 07:47:17 -08:00
reed
ed9f7a9220 rebaseline after fix to cornerpatheffect
BUG=skia:
TBR=
NOTRY=True

Review URL: https://codereview.chromium.org/814523004
2014-12-17 07:49:59 -08:00
reed
2b9445b84e fix end-point and conic bugs in cornerpatheffect
fixes bug in GM/patheffect -- will need to be rebaselined

BUG=skia:

Review URL: https://codereview.chromium.org/803213003
2014-12-17 05:50:55 -08:00
scroggo
41b4d77d02 Massive rebaseline for SkRandom.
All of the following GMs have been switched from SkLCGRandom to
SkRandom. Update their expectations for the new images.

-beziers
-circles
-convexpaths
-complexclip2
-complexclip2_rect_aa
-complexclip2_rect_bw
-complexclip2_path_aa
-complexclip2_path_bw
-complexclip2_rrect_aa
-complexclip2_rrect_bw
-cubicpath
-cubicclosepath
-degeneratesegments
-emptypath
-getpostextpath
-hittestpath
-linepath
-lineclosepath
-points
-polygons
-quadpath
-quadclosepath
-strokerects
-strokes_round
-strokes_poly

BUG=skia:3241
TBR=mtklein

Review URL: https://codereview.chromium.org/806263002
2014-12-16 10:59:56 -08:00
joshualitt
af7aac81b4 rebase gms and update ignore
NOTRY=True
TBR=
BUG=skia:

Review URL: https://codereview.chromium.org/811433004
2014-12-15 17:42:43 -08:00
joshualitt
9b98932ada This change will ultimately pull uniform color, and to a much lesser degree uniform coverage, into GPs. There are still some loose ends because drawstate has the ability to override the GP, but fixing these cleanly will have to wait until we have deferred geometry in place and can make attribute / uniform decisions on the fly.
BUG=skia:

Review URL: https://codereview.chromium.org/746423007
2014-12-15 14:16:27 -08:00
scroggo
caaf8e611d Add missed convexpaths.
TBR=reed
NOTRY=True
NOTREECHECKS=True
BUG=skia:3241

Review URL: https://codereview.chromium.org/805043005
2014-12-15 13:25:49 -08:00
scroggo
f9d610179d There can be only one (SkRandom)!
Remove SkLCGRandom. We already decided the new one was better, which is
why we wrote the new SkRandom.

Convert GMs that were using SkLCGRandom to use the improved SkRandom.
Motivated by the fact that these GMs draw differently on some runs. We
believe this to be a result of using the old SkLCGRandom.

Add each of the tests that were using SkLCGRandom to ignore-tests.txt,
since we expect they'll draw differently using SkRandom.

Move a trimmed down version of SkLCGRandom into SkDiscretePathEffect.
In order to preserve the old behavior, trim down SkLCGRandom to only
the methods used by SkDiscretePathEffect, and hide it in
SkDiscretePathEffect's cpp file.

BUG=skia:3241

Review URL: https://codereview.chromium.org/805963002
2014-12-15 12:54:51 -08:00
Brian Salomon
bd163707a0 Rebaseline after circle normalization change.
TBR=bensong@google.com

Review URL: https://codereview.chromium.org/806893002
2014-12-15 11:34:37 -05:00
bsalomon
ce1c8869cf Do circle anti-aliasing in normalized space to avoid precision issues with half-floats on Adreno.
Review URL: https://codereview.chromium.org/761593006
2014-12-15 07:11:22 -08:00
egdaniel
bd17ac55dd Remove gms from ignore-tests.
TBR=

BUG=skia:

Review URL: https://codereview.chromium.org/800033002
2014-12-12 11:01:29 -08:00
joshualitt
dfc2e34e74 rebase and remove ignores
NOTRY=True
TBR=
BUG=skia:

Review URL: https://codereview.chromium.org/788193005
2014-12-11 17:26:44 -08:00
joshualitt
56995b5cc0 Remove GP from drawstate, revision of invariant output for GP
BUG=skia:

Committed: https://skia.googlesource.com/skia/+/c6bc58eded89b0c0a36b8e20e193c200f297a0da

Review URL: https://codereview.chromium.org/791743003
2014-12-11 15:44:02 -08:00
egdaniel
c230414861 Create xfer processor backend.
This includes:
-Having an actual XP stage at the end of the gl pipeline.
-All Blending work is handled by XP until actually setting GL blend states
-GLPrograms test to test XP

BUG=skia:

Committed: https://skia.googlesource.com/skia/+/4dffc940c430eec66d4707490eace19c9b3f7904

Review URL: https://codereview.chromium.org/764643004
2014-12-11 13:15:14 -08:00
fmalita
0de8010432 Poppler rebaseline for clipped-bitmap-shaders-clamp
Follow-up for https://codereview.chromium.org/787043006.

TBR=scroggo@google.com

Review URL: https://codereview.chromium.org/798533003
2014-12-11 08:20:38 -08:00
joshualitt
8da8e9d751 rebase hairlines
TBR=
BUG=skia:

Review URL: https://codereview.chromium.org/795133002
2014-12-11 06:53:34 -08:00
joshualitt
294738268d Revert of Create xfer processor backend. (patchset #6 id:100001 of https://codereview.chromium.org/764643004/)
Reason for revert:
CL breaks windows DM

Original issue's description:
> Create xfer processor backend.
>
> This includes:
> -Having an actual XP stage at the end of the gl pipeline.
> -All Blending work is handled by XP until actually setting GL blend states
> -GLPrograms test to test XP
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/4dffc940c430eec66d4707490eace19c9b3f7904

TBR=bsalomon@google.com,joshualitt@chromium.org,egdaniel@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review URL: https://codereview.chromium.org/789343002
2014-12-10 15:03:01 -08:00
joshualitt
5f9ba17a02 Revert of Add more ignore gm's for recent Xfer Processor CL (patchset #1 id:1 of https://codereview.chromium.org/786083004/)
Reason for revert:
Preventing revert of cl breaking windows DM

Original issue's description:
> Add more ignore gm's for recent Xfer Processor CL
>
> TBR=bsalomon@google.com
> NOTRY=true
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/125251133a62a07225b7119ab3ac90153ba4c58a

TBR=bsalomon@google.com,egdaniel@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review URL: https://codereview.chromium.org/794883002
2014-12-10 14:57:56 -08:00
joshualitt
bd528cdb51 fix for chrome bug with sub pixel hairlines
BUG=skia:

Review URL: https://codereview.chromium.org/796573002
2014-12-10 14:23:40 -08:00
joshualitt
8c0f615fdd Revert of Remove GP from drawstate, revision of invariant output for GP (patchset #9 id:160001 of https://codereview.chromium.org/791743003/)
Reason for revert:
breaks mac

Original issue's description:
> Remove GP from drawstate, revision of invariant output for GP
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/c6bc58eded89b0c0a36b8e20e193c200f297a0da

TBR=bsalomon@google.com,egdaniel@google.com,joshualitt@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review URL: https://codereview.chromium.org/794843002
2014-12-10 14:12:22 -08:00
joshualitt
c6bc58eded Remove GP from drawstate, revision of invariant output for GP
BUG=skia:

Review URL: https://codereview.chromium.org/791743003
2014-12-10 13:48:57 -08:00
robertphillips
da3124d05a Rebaseline imagefiltersscaled images (and rm from ignored-tests file)
Rebaselines for https://codereview.chromium.org/785893004/ (Fix MatrixImageFilter computeFastBounds)

TBR=scroggo@google.com

Review URL: https://codereview.chromium.org/794673004
2014-12-10 12:23:09 -08:00
Florin Malita
18abd1acef Suppress clipped-bitmap-shaders-clamp
Pending PDF rebaseline after c54d8db4d1

TBR=scroggo@google.com

Review URL: https://codereview.chromium.org/788143003
2014-12-10 12:23:18 -05:00
egdaniel
125251133a Add more ignore gm's for recent Xfer Processor CL
TBR=bsalomon@google.com
NOTRY=true

BUG=skia:

Review URL: https://codereview.chromium.org/786083004
2014-12-10 08:14:44 -08:00
egdaniel
4dffc940c4 Create xfer processor backend.
This includes:
-Having an actual XP stage at the end of the gl pipeline.
-All Blending work is handled by XP until actually setting GL blend states
-GLPrograms test to test XP

BUG=skia:

Review URL: https://codereview.chromium.org/764643004
2014-12-10 07:43:50 -08:00
Brian Salomon
269edd5f7e Rebaseline after texture coord precision changes.
TBR=scroggo@google.com

Review URL: https://codereview.chromium.org/788903003
2014-12-09 15:29:19 -05:00
bsalomon
17168df779 Use texture size to determine precision of texture coord varyings.
Review URL: https://codereview.chromium.org/778783002
2014-12-09 09:00:49 -08:00
robertphillips
e4c53202e9 Rebaselines for https://codereview.chromium.org/785893004/ (Fix MatrixImageFilter computeFastBounds)
The msaa4 image diffs aren't actually due to the named CL

TBR=scroggo@google.com

Review URL: https://codereview.chromium.org/787093002
2014-12-09 07:15:20 -08:00
robertphillips
eeb6f0c3c0 Rebaseline multipicturedraw GMs
This is clean up after https://codereview.chromium.org/753253002/ (Use variable length key (rather than accumulated matrix) as save layer hoisting key)

TBR=halcanary@google.com

Review URL: https://codereview.chromium.org/783523002
2014-12-04 08:43:54 -08:00
joshualitt
ed8bdc5193 bug fix for cubic low precision
TBR=
BUG=skia:

Review URL: https://codereview.chromium.org/776953002
2014-12-03 09:29:53 -08:00
Mike Klein
43c79b9c64 Rebaseline verylargebitmap
BUG=skia:

Review URL: https://codereview.chromium.org/778693002
2014-12-03 11:32:37 -05:00
joshualitt
2dd1ae016d First step to moving vertex attributes to the geometryProcessor
BUG=skia:

Review URL: https://codereview.chromium.org/761563002
2014-12-03 06:24:10 -08:00
Justin Novosad
5234075b1c Adding a PictureResolution option to SkPictureImageFilter
This change adds an option to SkPictureImageFilter to make it
rasterize SkPicture in a resolution that matches the local coordinate
space (equivalent to the record-time device space).

BUG=skia:3176
R=reed@google.com, senorblanco@chromium.org

Review URL: https://codereview.chromium.org/753073010
2014-12-02 14:50:56 -05:00
derekf
367e1867b2 use drawRect when drawing a bitmap with anti-aliasing on a non-msaa target
If the dest isn't pixel aligned, or if a non 90 degree rotation is
present, we need to use drawRect() for drawing anti-aliased bitmaps on
non-msaa targets or the edges won't be anti-aliased as intended.

Note: If the bitmap size is bigger than max texture size we fall back to drawBitmapCommon.

Original-Author: Henry Song <henrysong@samsung.com>

Review URL: https://codereview.chromium.org/649313003
2014-12-02 11:02:06 -08:00
robertphillips
01d6e5f462 Use variable length key (rather than accumulated matrix) as save layer hoisting key
Adding the rendering canvas' CTM to the layer hoisting key (i.e., Add support for hoisting layers in pictures drawn with a matrix - https://codereview.chromium.org/748853002/) has increased the cache miss rate due to accumulated floating point error. This CL fixes part of the issue by using the chain of operation indices leading to each saveLayer as the key. The canvas' CTM must still form part of the key but should be less subject to accumulated error.

BUG=skia:2315

Review URL: https://codereview.chromium.org/753253002
2014-12-01 09:09:27 -08:00