Robert Phillips
54190c42dd
Revert "Store discard request on the opList and remove GrDiscardOp"
...
This reverts commit b681a0f1b0https://skia-review.googlesource.com/32640
> Reviewed-by: Brian Salomon <bsalomon@google.com>
> Commit-Queue: Robert Phillips <robertphillips@google.com>
TBR=egdaniel@google.com ,bsalomon@google.com,robertphillips@google.com
Change-Id: I8a89fae7bb11791bd023d7444a074bb34d006fd0
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/32704
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
2017-08-09 20:10:06 +00:00
Yuqian Li
dd3feeeec9
Move gFDot6INVERSE definition to cpp file
...
Bug: skia:6946
Change-Id: Iee029a73ae899b0f73910b45c7cf83bd37dc07c3
Reviewed-on: https://skia-review.googlesource.com/32840
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Yuqian Li <liyuqian@google.com>
2017-08-09 19:42:34 +00:00
Brian Osman
6a7d56fa0f
Support single line objects and arrays
...
This is just a formatting nicety. The new caps dump has several large
arrays of structs, and keeping each object on one line makes them much
more readable. (It also limits the total length of the output, which
helps when scanning through).
Example of the output, before and after this change:
https://gist.github.com/brianosman/872f33be9af49031023b791e7db0b1fb
Bug: skia:
Change-Id: I0fe0c2241b0c7f451b0837500e554d0491126d5e
Reviewed-on: https://skia-review.googlesource.com/32820
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2017-08-09 19:41:35 +00:00
Brian Osman
175af0d011
GrContext::dump that produces JSON formatted output
...
Includes caps, GL strings, and extensions
Bug: skia:
Change-Id: I1e8b3dd50fb68357f9de8ca6149cf65443d027ef
Reviewed-on: https://skia-review.googlesource.com/32340
Commit-Queue: Brian Osman <brianosman@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
2017-08-09 18:52:05 +00:00
Mike Klein
a07e4302cf
add gamma stage
...
Until now we've been using 3 separate parametric stages to apply
gamma to r,g,b. That works fine, but is kind of unnecessarily
slow, and again less clear in a stack trace than seeing "gamma".
The new bench runs in about 60% of the time the old one does
on my Trashcan.
BUG=skia:6939
Change-Id: I079698d3009b081f1c23a2e27fc26e373b439610
Reviewed-on: https://skia-review.googlesource.com/32721
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>
2017-08-09 18:51:44 +00:00
Robert Phillips
b681a0f1b0
Store discard request on the opList and remove GrDiscardOp
...
Change-Id: Ic1f76bb91c16b23df1fe71c07a4d5ad5abf1dc26
Reviewed-on: https://skia-review.googlesource.com/32640
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
2017-08-09 18:11:34 +00:00
Mike Reed
c270423de1
use unsigned to avoid runtime overflow detection
...
Bug: skia:
Change-Id: I487930955f75048ea27a1bcc61f7e0849c63759b
Reviewed-on: https://skia-review.googlesource.com/32681
Commit-Queue: Mike Reed <reed@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
2017-08-09 17:51:57 +00:00
skia-deps-roller@chromium.org
5400c0b0e2
Roll skia/third_party/externals/angle2/ 880683b17..85d624a51 (3 commits)
...
880683b173..85d624a510https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls
CQ_INCLUDE_TRYBOTS=skia.primary:Perf-Win10-MSVC-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-ANGLE,Perf-Win10-MSVC-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-ANGLE,Perf-Win10-MSVC-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-ANGLE,Perf-Win10-MSVC-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-ANGLE,Perf-Win10-MSVC-ShuttleC-GPU-GTX960-x86_64-Debug-ANGLE,Perf-Win10-MSVC-ZBOX-GPU-GTX1070-x86_64-Debug-ANGLE,Test-Win10-MSVC-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-ANGLE,Test-Win10-MSVC-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-ANGLE,Test-Win10-MSVC-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-ANGLE,Test-Win10-MSVC-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-ANGLE,Test-Win10-MSVC-ShuttleC-GPU-GTX960-x86_64-Debug-ANGLE,Test-Win10-MSVC-ZBOX-GPU-GTX1070-x86_64-Debug-ANGLE
TBR=bungeman@google.com
Change-Id: I2877eca8f889a8b2bb53aad3a6767632f1f14c15
Reviewed-on: https://skia-review.googlesource.com/32642
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
2017-08-09 17:46:04 +00:00
Eric Karl
e1fc9ac045
Improve float-based dither logic
...
This code simulates the integer-based ordered-dither using step/mod
with only floating point values. Produces similar results.
R=bsalomon@google.com
Bug: skia:4430
Change-Id: I1406f751f0ddd6bfd14e532dfb4efc0bb5784992
Reviewed-on: https://skia-review.googlesource.com/28942
Commit-Queue: Eric Karl <ericrk@chromium.org>
Reviewed-by: Brian Salomon <bsalomon@google.com>
2017-08-09 17:43:25 +00:00
skia-deps-roller@chromium.org
7e59e391ef
Roll skia/third_party/externals/angle2/ 3c76d59f1..880683b17 (2 commits)
...
3c76d59f12..880683b173https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls
CQ_INCLUDE_TRYBOTS=skia.primary:Perf-Win10-MSVC-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-ANGLE,Perf-Win10-MSVC-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-ANGLE,Perf-Win10-MSVC-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-ANGLE,Perf-Win10-MSVC-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-ANGLE,Perf-Win10-MSVC-ShuttleC-GPU-GTX960-x86_64-Debug-ANGLE,Perf-Win10-MSVC-ZBOX-GPU-GTX1070-x86_64-Debug-ANGLE,Test-Win10-MSVC-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-ANGLE,Test-Win10-MSVC-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-ANGLE,Test-Win10-MSVC-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-ANGLE,Test-Win10-MSVC-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-ANGLE,Test-Win10-MSVC-ShuttleC-GPU-GTX960-x86_64-Debug-ANGLE,Test-Win10-MSVC-ZBOX-GPU-GTX1070-x86_64-Debug-ANGLE
TBR=bungeman@google.com
Change-Id: I1ac9af88bdbff37e36475d767f65ca1402e7e90a
Reviewed-on: https://skia-review.googlesource.com/32560
Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
2017-08-09 16:13:34 +00:00
Mike Reed
828f1d5195
handle overflows in float->int
...
rects are already auto-vectorized, so no need to explicitly write a 4f version of SkRect::round()
Bug: skia:
Change-Id: I098945767bfcaa7093d770c376bd17ff3bdc9983
Reviewed-on: https://skia-review.googlesource.com/32060
Commit-Queue: Mike Reed <reed@google.com>
Reviewed-by: Florin Malita <fmalita@chromium.org>
2017-08-09 16:07:24 +00:00
Robert Phillips
74c627f0bd
Fix stencil clear load in Vulkan
...
A later clear call was nuking the stencil clear load setting.
Bug: skia:6936
Change-Id: Ib2c5cd930273cd6e613ca7191f8b7806abe6c218
Reviewed-on: https://skia-review.googlesource.com/32541
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
2017-08-09 15:01:34 +00:00
Robert Phillips
19e51dcd1e
Store GrRenderTarget in GrGpuCommandBuffer
...
Change-Id: I545d53ffb5f9d450b87a360516b03bdd47232a70
Reviewed-on: https://skia-review.googlesource.com/32460
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
2017-08-09 14:30:54 +00:00
Brian Osman
69fd008199
Added SkJSONWriter
...
This is a stand-alone helper class for writing properly
structured JSON to an SkWStream. It currently solves two
problems (although this CL only uses it in one context):
1) Performance. Writing out JSON this way is about 10x
faster than using JSONCPP. For the large amounts of data
generated by the tracing system, that's a big win.
2) Makes it easy to emit structured JSON from code that's
not fully centralized. We'd like to spit out JSON that
describes a GrContext, GrGpu, GrCaps, etc... Doing that
with simple string manipulation is complex, and spreads
this logic over all those functions. Using JSONCPP adds
yet another (large) third party library dependency (that
we only build into our own tools right now).
This went through several revisions. I originally planned
it as a stateful SkString wrapper, so the user could just
build their JSON as a string. That's O(N^2), though,
because SkString grows by a (small) constant amount. Even
using a better growth strategy still means needing RAM
for all the resulting text, which is usually pointless.
This version has a constant memory cost, so writing huge
amounts of JSON to disk (tracing a long DM run can emit
100's of MBs) doesn't stress resources.
Bug: skia:
Change-Id: Ia716524b246db0f97d332da60d2ce9903069e748
Reviewed-on: https://skia-review.googlesource.com/31204
Commit-Queue: Brian Osman <brianosman@google.com>
Reviewed-by: Mike Klein <mtklein@chromium.org>
2017-08-09 13:46:24 +00:00
Eric Boren
bca3b8d8e0
Revert "Bring recipes up to date."
...
This reverts commit e4024d5dab12e7ca4#2 )
> eb1feb90 [cipd] Bump version, log at warning (#2 ).
> 9f9d82ac Revert "[cipd] Bump version, log at warning."
> 18aa2d93 [cipd] Bump version, log at warning.
> fc6196b3 gclient flatten: preserve variable placeholders (reland #1 )
> 5aa5cd76 depot_tools: add gerrit repo and ref to apply_gerrit_ref()
> 56766f1d Add experimental downstream recipe trybots to depot_tools
> 44855b94 Revert "[bootstraps] Sync at gclient, suppress output."
> 393ba066 Revert "gclient flatten: preserve variable placeholders"
> e79ddeaa gclient flatten: preserve variable placeholders
> 5a80eab0 Use -prerelease flag to vswhere when packaging VS
> 4d92fe43 [bootstraps] Sync at gclient, suppress output.
> 357415cb gclient flatten: fix a bug with some recursedeps not being processed
> 3d6363b3 Roll recipe dependencies (trivial).
> b396315c Bump led version.
> a3a515a4 Revert "Generalize git index refresh to bot_update."
> 06e1aa07 Generalize git index refresh to bot_update.
> 7f12a2e4 [bootstrap/win] Roll bleeding edge entry bat.
> f7543cdd git-cl: accept --force for -f everywhere
> 642dd84c [win/bootstrap] Use "for" instead of "set".
> ca01e2c8 git cl issue 0: Remove Change-Id from message, not description
> 290f5f56 Remove "create-ntfs-junction".
> ff9a5dec Roll recipe dependencies (trivial).
> d2dbea66 Roll recipe dependencies (trivial).
> fc62f768 Simplify notify behavior in git-cl
> cfbb775f Roll recipe dependencies (trivial).
> ae895075 Use doseq=True when re-encoding url query parameters
> 98681d11 Remove obsolete destination-branch-check flag
> 8aa774cf Fix bot_update example
> dd1bc7c0 [cipd] Generate other platform suffixes.
> 383ace4b Fix git-crrev-parse on Mac.
> e5adf612 Fix typo with --send-email [sic] flags
> 0ed616a4 Roll recipe dependencies (trivial).
> 636b13fc Let Changelist().AddComment() mark changes as Ready
> 68b54e78 [bootstrap/win] Upgrade Python to 2.7.13.
> f3d5a114 Enable Gerrit-destination-branch check by default
> 31f3e63c Revert "Revert "[tryserver] Remove unused methods.""
> c4dd3e82 [bootstrap/win] Remove support for legacy installs
> cc27ecb0 Revert "[tryserver] Remove unused methods."
> 68f6f279 [bootstrap/win] Always use "cipd.bat".
> 3a8717e1 [bootstrap/win] Remove legacy Git support.
> 6bac8a84 GitHyperBlameMainTest.testBadFilename: Work around git-blame bug.
> 4e5207d6 git-cl issue 0: Don't operate on empty description
> 22a9cf54 git_footers: fix bug stdin-based message input.
> 02e59414 Fix bot_update's usage of the destination branch
> 83eb1cd5 Roll recipe dependencies (trivial).
> 400e989b 'git cl issue 0': Remove Change-Id
> 133ac1ab [tryserver] Remove unused methods.
> b08ba657 git_footer: be more resilient to malformed footers
> 9d842bab [recipe_modules/git] Remove logging.
> 3d9b5881 [win_tools] Use bundled Python CIPD packages (#2 ).
> 209a681f [git] Remove hard-coded "depot_tools" Git.
> e8eed65f Always copy "python.bat".
> aab09ca6 Whitelist "python_bin_reldir.txt".
> af5c20f5 Revert "[win_tools] Use bundled Python CIPD packages."
> 7dadf05d Query Gerrit for destination branch in bot_update
> bf144679 [win_tools] Use bundled Python CIPD packages.
> b80fac66 Roll recipe dependencies (trivial).
> 265255f5 [bootstrap/win] Replace "python.bat" only on downgrade.
> 24025d3e tryserver: add support for gerrit footers
> 903ea731 [activity.py] Identify Gerrit-style bug annotations in commit messages
> 49b8147b Add support to query a CL's branch to gerrit recipe module
> 4cb9d742 [bootstrap/win] Enable revert from upcoming patch.
> 13e88538 Ignore the ".bleeding_edge" file.
> c8173825 git cl creds-check: improve report and give better recommendation.
> 4978917c Adjust CQ config for luci.infra.try -> luci.infra.depot_tools.try bucket move
> 9cb802ca Improve gerrit recipe_module example
> 79e897b0 [git_bootstrap] Support new Git bundles.
> 8af46469 Roll recipe dependencies (trivial).
> 1f767e17 Fix autoninja.py for ninja -t compatibility
> 7466d1a9 [cipd] Run client in .bat to preserve STDIN.
> 13f258bf Remove SVN bootstrapping and some tooling.
> b12c5256 Roll recipe dependencies (trivial).
> 016f92e6 Roll recipe dependencies (trivial).
> 68506985 Roll recipe dependencies (trivial).
> 215ded77 Fix testFlattenPinAllDeps
> 271a1680 gclient flatten: implement --pin-all-deps
> fb022017 gclient flatten: include vars
> e36a8431 Roll recipe dependencies (trivial).
> de37c012 Fix git-numberer swallowing of footers for Rietveld.
> 4e89144a git-cl: fix auth error message computation
> 7c2e05b4 [cipd] Fix CIPD bootstraps run concurrently.
> aaf93f48 gclient flatten: refactor flatten code to a class
> 807caf84 gclient flatten: remove --require-pinned-revisions
> 6fbf12f2 Enable query for changes in gerrit recipe module
> c6846aa2 gclient flatten: fix a bug with deps_os getting omitted for recursed deps
> 4baaa11c gclient: avoid adding potentially duplicate entries to work queue
> d3790251 gclient: apply custom_vars when evaluating conditions
> a8fdab96 Roll recipe dependencies (trivial).
> e82c0dec [cipd] Fail if setup has an error.
> b1ad2f04 Update CIPD client, vpython and "LUCI editor".
> 6a1ab843 Roll recipe dependencies (trivial).
> 32f0e5d7 Roll recipe dependencies (trivial).
> bc9c5ccf Roll recipe dependencies (trivial).
> 54adb2a3 Generate initial recipes README.
> 603545b7 Roll recipe dependencies (trivial).
> e015878d gclient flatten: fix an issue with an deps_os entry getting added to deps
> 6014b566 gclient flatten: also handle allowed_hosts
> 70b3f3aa [bot_update] Pass spec as file.
> 1af0a337 Roll recipe dependencies (trivial).
> dc598e82 [bot_update] Prefix PATH, cleanup.
>
> Bug: skia:
> Change-Id: I0eea2dd126c130299ac39fe9b54a714cb0612563
> Reviewed-on: https://skia-review.googlesource.com/32420
> Reviewed-by: Eric Boren <borenet@google.com>
> Commit-Queue: Eric Boren <borenet@google.com>
TBR=borenet@google.com ,iannucci@google.com
Change-Id: I6ed89db0757ffeb366da96d655372e9710aa589e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: skia:
Reviewed-on: https://skia-review.googlesource.com/32520
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
2017-08-09 13:03:15 +00:00
Robert Iannucci
e4024d5dab
Bring recipes up to date.
...
* Move recipe_engine URL to new canonical URL
* Add README.recipes.md (auto-generated doc from docstrings in repo,
regenerated with `recipes.py test train`).
* Bring depot_tools up to date
recipe_engine:
464fc26 Update a couple more URLs.
38808d0 Switch recipes-py CQ to Gerrit
c7cdc9c Update canonical URL.
6bac51f Fix urls to googlesource.
5cf5e58 Convert code review to Gerrit
e92def4 Add source manifest proto to recipe_engine.
e0ddd60 Move internal downstream recipe roll trybots to production
3cae8e9 Add file.filesizes to recipe engine core modules.
862f333 Vendor 'luci_context' library.
6de5241 Add add_json_log='on_failure' to json module.
e183af0 [recipe_engine] Set presentation.status before OutputPlaceholder.result.
3b99cdd Fix "recipes.py test diff" not raising a failure
8e8339a [path] Fix root path mocking.
00799cc Add experimental internal downstream recipe trybots
0ca88ae Pretty up all recipe_engine documentation.
de3238c Fix UnboundLocalError in find_recipe.
9b47d24 Move downstream recipe roll trybots to production
da3467b Recursively apply recipe overrides
3d76281 [uuid] Remove unused uuid module
9959b07 Remove shutil module.
26475d6 Add more experimental downstream trybots
5c349eb [file] allow glob to handle nested patterns
12e7ca4#2 )
eb1feb90 [cipd] Bump version, log at warning (#2 ).
9f9d82ac Revert "[cipd] Bump version, log at warning."
18aa2d93 [cipd] Bump version, log at warning.
fc6196b3 gclient flatten: preserve variable placeholders (reland #1 )
5aa5cd76 depot_tools: add gerrit repo and ref to apply_gerrit_ref()
56766f1d Add experimental downstream recipe trybots to depot_tools
44855b94 Revert "[bootstraps] Sync at gclient, suppress output."
393ba066 Revert "gclient flatten: preserve variable placeholders"
e79ddeaa gclient flatten: preserve variable placeholders
5a80eab0 Use -prerelease flag to vswhere when packaging VS
4d92fe43 [bootstraps] Sync at gclient, suppress output.
357415cb gclient flatten: fix a bug with some recursedeps not being processed
3d6363b3 Roll recipe dependencies (trivial).
b396315c Bump led version.
a3a515a4 Revert "Generalize git index refresh to bot_update."
06e1aa07 Generalize git index refresh to bot_update.
7f12a2e4 [bootstrap/win] Roll bleeding edge entry bat.
f7543cdd git-cl: accept --force for -f everywhere
642dd84c [win/bootstrap] Use "for" instead of "set".
ca01e2c8 git cl issue 0: Remove Change-Id from message, not description
290f5f56 Remove "create-ntfs-junction".
ff9a5dec Roll recipe dependencies (trivial).
d2dbea66 Roll recipe dependencies (trivial).
fc62f768 Simplify notify behavior in git-cl
cfbb775f Roll recipe dependencies (trivial).
ae895075 Use doseq=True when re-encoding url query parameters
98681d11 Remove obsolete destination-branch-check flag
8aa774cf Fix bot_update example
dd1bc7c0 [cipd] Generate other platform suffixes.
383ace4b Fix git-crrev-parse on Mac.
e5adf612 Fix typo with --send-email [sic] flags
0ed616a4 Roll recipe dependencies (trivial).
636b13fc Let Changelist().AddComment() mark changes as Ready
68b54e78 [bootstrap/win] Upgrade Python to 2.7.13.
f3d5a114 Enable Gerrit-destination-branch check by default
31f3e63c Revert "Revert "[tryserver] Remove unused methods.""
c4dd3e82 [bootstrap/win] Remove support for legacy installs
cc27ecb0 Revert "[tryserver] Remove unused methods."
68f6f279 [bootstrap/win] Always use "cipd.bat".
3a8717e1 [bootstrap/win] Remove legacy Git support.
6bac8a84 GitHyperBlameMainTest.testBadFilename: Work around git-blame bug.
4e5207d6 git-cl issue 0: Don't operate on empty description
22a9cf54 git_footers: fix bug stdin-based message input.
02e59414 Fix bot_update's usage of the destination branch
83eb1cd5 Roll recipe dependencies (trivial).
400e989b 'git cl issue 0': Remove Change-Id
133ac1ab [tryserver] Remove unused methods.
b08ba657 git_footer: be more resilient to malformed footers
9d842bab [recipe_modules/git] Remove logging.
3d9b5881 [win_tools] Use bundled Python CIPD packages (#2 ).
209a681f [git] Remove hard-coded "depot_tools" Git.
e8eed65f Always copy "python.bat".
aab09ca6 Whitelist "python_bin_reldir.txt".
af5c20f5 Revert "[win_tools] Use bundled Python CIPD packages."
7dadf05d Query Gerrit for destination branch in bot_update
bf144679 [win_tools] Use bundled Python CIPD packages.
b80fac66 Roll recipe dependencies (trivial).
265255f5 [bootstrap/win] Replace "python.bat" only on downgrade.
24025d3e tryserver: add support for gerrit footers
903ea731 [activity.py] Identify Gerrit-style bug annotations in commit messages
49b8147b Add support to query a CL's branch to gerrit recipe module
4cb9d742 [bootstrap/win] Enable revert from upcoming patch.
13e88538 Ignore the ".bleeding_edge" file.
c8173825 git cl creds-check: improve report and give better recommendation.
4978917c Adjust CQ config for luci.infra.try -> luci.infra.depot_tools.try bucket move
9cb802ca Improve gerrit recipe_module example
79e897b0 [git_bootstrap] Support new Git bundles.
8af46469 Roll recipe dependencies (trivial).
1f767e17 Fix autoninja.py for ninja -t compatibility
7466d1a9 [cipd] Run client in .bat to preserve STDIN.
13f258bf Remove SVN bootstrapping and some tooling.
b12c5256 Roll recipe dependencies (trivial).
016f92e6 Roll recipe dependencies (trivial).
68506985 Roll recipe dependencies (trivial).
215ded77 Fix testFlattenPinAllDeps
271a1680 gclient flatten: implement --pin-all-deps
fb022017 gclient flatten: include vars
e36a8431 Roll recipe dependencies (trivial).
de37c012 Fix git-numberer swallowing of footers for Rietveld.
4e89144a git-cl: fix auth error message computation
7c2e05b4 [cipd] Fix CIPD bootstraps run concurrently.
aaf93f48 gclient flatten: refactor flatten code to a class
807caf84 gclient flatten: remove --require-pinned-revisions
6fbf12f2 Enable query for changes in gerrit recipe module
c6846aa2 gclient flatten: fix a bug with deps_os getting omitted for recursed deps
4baaa11c gclient: avoid adding potentially duplicate entries to work queue
d3790251 gclient: apply custom_vars when evaluating conditions
a8fdab96 Roll recipe dependencies (trivial).
e82c0dec [cipd] Fail if setup has an error.
b1ad2f04 Update CIPD client, vpython and "LUCI editor".
6a1ab843 Roll recipe dependencies (trivial).
32f0e5d7 Roll recipe dependencies (trivial).
bc9c5ccf Roll recipe dependencies (trivial).
54adb2a3 Generate initial recipes README.
603545b7 Roll recipe dependencies (trivial).
e015878d gclient flatten: fix an issue with an deps_os entry getting added to deps
6014b566 gclient flatten: also handle allowed_hosts
70b3f3aa [bot_update] Pass spec as file.
1af0a337 Roll recipe dependencies (trivial).
dc598e82 [bot_update] Prefix PATH, cleanup.
Bug: skia:
Change-Id: I0eea2dd126c130299ac39fe9b54a714cb0612563
Reviewed-on: https://skia-review.googlesource.com/32420
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
2017-08-09 12:49:04 +00:00
Mike Reed
c94ff43cf8
add flag for google3, need to update test
...
Bug: skia:
Change-Id: I9e896efdf3741f02c29f17dc7dfa4dd2dcf43728
Reviewed-on: https://skia-review.googlesource.com/32403
Reviewed-by: Mike Reed <reed@google.com>
2017-08-08 23:28:38 +00:00
Robert Phillips
952144753d
Add explicit clear of stencil buffer before opLists that use them
...
Change-Id: I9e2468e1331c6593dbc6da3ad510f08d1c589e8d
Reviewed-on: https://skia-review.googlesource.com/32041
Commit-Queue: Stan Iliev <stani@google.com>
Reviewed-by: Greg Daniel <egdaniel@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
2017-08-08 22:32:36 +00:00
Ravi Mistry
8d8b016f52
Fix config in run_ct_skps.py
...
This stopped working after https://skia-review.googlesource.com/c/9871
Bug: skia:6934
Change-Id: I5fe88518806ba68acf2315bf06ec845ce975cf7f
Reviewed-on: https://skia-review.googlesource.com/32185
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
2017-08-08 22:13:40 +00:00
Mike Reed
3404207e24
use rasterpipeline for images if matrix is >= scale+translate
...
Bug: skia:
Change-Id: I36112fe54c6f2d0965d0b88f0291d7ffe0902715
Reviewed-on: https://skia-review.googlesource.com/30480
Commit-Queue: Mike Reed <reed@google.com>
Reviewed-by: Mike Klein <mtklein@chromium.org>
Reviewed-by: Florin Malita <fmalita@chromium.org>
2017-08-08 21:32:42 +00:00
Florin Malita
4d011bef0a
Remove unneeded GrGradientEffect Tegra3 workaround
...
The workaround for canUseMinAndAbsTogether() is implemented in
GLSLCodeGenerator, so presumably not needed here.
(https://cs.chromium.org/chromium/src/third_party/skia/src/sksl/SkSLGLSLCodeGenerator.cpp?rcl=0ac06e47269a40c177747310a613d213c95d1d6d&l=223 )
Change-Id: Id8179ff17b929ed2d79ef9463c0f2008f3591b00
Reviewed-on: https://skia-review.googlesource.com/32181
Reviewed-by: Ethan Nicholas <ethannicholas@google.com>
Commit-Queue: Florin Malita <fmalita@chromium.org>
2017-08-08 21:31:39 +00:00
Ethan Nicholas
1af6d68dad
added canUseFractForNegativeValues to standalone shader caps
...
Bug: skia:
Change-Id: I1097bc19b12266fe57775f6d15d731254bfffd2e
Reviewed-on: https://skia-review.googlesource.com/32186
Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
Commit-Queue: Florin Malita <fmalita@chromium.org>
Reviewed-by: Florin Malita <fmalita@chromium.org>
2017-08-08 21:04:22 +00:00
Mike Klein
b12e178dbe
rewrite SkColorLookUpTable::interpDimension()
...
- Avoid calling floor() and ceil(), which are real
external calls on most platforms.
- Interpolate all output channels in parallel.
- Simplify recursion, allow the compiler to unroll.
Change-Id: I9ef814e91b18c5775292ca20e9ec01222b6a89cf
Reviewed-on: https://skia-review.googlesource.com/32182
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>
2017-08-08 20:37:13 +00:00
Florin Malita
3b30c4f188
Relocate gradient negative fract() workaround to GLSLCodeGenerator
...
Change-Id: If5aba5b266f86f677b6e63b0f79792f1d3213336
Reviewed-on: https://skia-review.googlesource.com/32202
Reviewed-by: Ethan Nicholas <ethannicholas@google.com>
Commit-Queue: Florin Malita <fmalita@chromium.org>
2017-08-08 20:18:33 +00:00
Ben Wagner
26308e1757
Remove last uses of SkTypeface::style() in Skia.
...
The Lua typeface.getStyle now returns SkFontStyle.
Dumping a glyph cache entry is now more accurate.
SkTypeface::MakeFromTypeface now does a more accurate check.
Change-Id: I6150636c8c674353bd0eed4d95aa0794d3919c39
Reviewed-on: https://skia-review.googlesource.com/32200
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Ben Wagner <bungeman@google.com>
2017-08-08 20:11:53 +00:00
Mike Reed
5a625e08f0
add tool_util to compare images
...
Bug: skia:
Change-Id: I826190aa15cf42a3ca7f3c7d5271ead5b514c116
Reviewed-on: https://skia-review.googlesource.com/32220
Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Mike Reed <reed@google.com>
2017-08-08 20:07:32 +00:00
Mike Klein
50d0d05357
add an invert stage for inverse CMYK -> CMYK
...
This will be faster, but maybe more importantly it helps make debugging
a stack trace clearer. It's confusing to see a "parametric transfer
function" stages followed by a table transfer function stages...
This leads to a little bit of cleanup in SkColorSpaceXform_A2B.
I am uncertain whether we still need parametric_a. I need to do some
more tracing through the code before I'd say it's impossible to reach in
addTransferFn().
Change-Id: I52e85019f92d012a3086fc94cf64ae6c9307ea94
Reviewed-on: https://skia-review.googlesource.com/32040
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>
2017-08-08 18:01:20 +00:00
Florin Malita
34335c5a8d
Streamline GrGradientEffect mirror tiling
...
Using the same branch-less method as raster pipeline.
Change-Id: Iaaa36330dbf49961bdfc288cad031d891d8ff589
Reviewed-on: https://skia-review.googlesource.com/31280
Commit-Queue: Florin Malita <fmalita@chromium.org>
Reviewed-by: Brian Salomon <bsalomon@google.com>
2017-08-08 17:20:50 +00:00
Florin Malita
b81a8b9c74
Consolidate GrGradientEffect analytical impls
...
There's a lot of commonality, we can share more code.
Change-Id: I6528358763459c4e8af17fe5f6763752cfffdf39
Reviewed-on: https://skia-review.googlesource.com/31023
Commit-Queue: Florin Malita <fmalita@chromium.org>
Reviewed-by: Brian Salomon <bsalomon@google.com>
2017-08-08 16:42:59 +00:00
Brian Salomon
e9bf6dc100
Don't compare against uninit edge in SkPath::conservativelyContainsRect
...
Bug: chromium:752478
Change-Id: Ic281f06b300329ea9823b3eb76cc56b7a43fd2a5
Reviewed-on: https://skia-review.googlesource.com/31520
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
2017-08-08 15:38:30 +00:00
Brian Osman
04e4dd3eed
Added new test image (ICC v4 CMYK) to colorimages
...
Image origin: https://github.com/flutter/flutter/issues/11521
Bug: skia:
Change-Id: I5af8b155a4979c83d3dd9c0bdd15e0052c6d1f88
Reviewed-on: https://skia-review.googlesource.com/32000
Commit-Queue: Brian Osman <brianosman@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>
Reviewed-by: Mike Klein <mtklein@chromium.org>
Reviewed-by: Eric Boren <borenet@google.com>
2017-08-08 15:32:24 +00:00
Florin Malita
8a0044f1bd
Tiling support for GrGradientEffect kTwo_ColorType/kThree_ColorType
...
(re-land of https://skia-review.googlesource.com/c/30780 )
Currently only the hard-stop specializations support tiling.
Consolidate the tiling code and expand to kTwo_ColorType,
kThree_ColorType also.
BUG=6925
Change-Id: I017b4accba30e87367e139333e96246cb362b6a4
Reviewed-on: https://skia-review.googlesource.com/31422
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Florin Malita <fmalita@chromium.org>
2017-08-08 15:27:36 +00:00
Ben Wagner
c6c10b4518
Remove SkTypeface::Style from fuzzers and lua.
...
Change-Id: I53be039e21a4c11ec3a4bc54c1424cd3e15afc6a
Reviewed-on: https://skia-review.googlesource.com/31643
Reviewed-by: Ben Wagner <bungeman@google.com>
Commit-Queue: Ben Wagner <bungeman@google.com>
2017-08-08 15:27:19 +00:00
Ravi Mistry
0ac06e4726
Bot updates for SkiaCT tasks.
...
Use gcc-4.8 when compiling for Ubuntu14. Rename the CT tasks to make it
clear their child tasks run on Ubuntu14.
Move to Debian-9.1 bots created with the changes in
https://skia-review.googlesource.com/c/31281 and
https://skia-review.googlesource.com/c/31820
Change the cache dir used by the ct_skps recipe so that changing the
bot name doesn't invalidate the cache.
Bug: skia:6921
Bug: skia:6818
No-Try: true
Change-Id: Idaac8187427b5c2c7bffe66ad6674496b8cd0c0e
Reviewed-on: https://skia-review.googlesource.com/31242
Commit-Queue: Ravi Mistry <rmistry@google.com>
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Ravi Mistry <rmistry@google.com>
2017-08-08 14:17:49 +00:00
Robert Phillips
65a88fadab
Add GrDebugMarkerOp
...
Change-Id: I948838dea13d2f36194ca1043ab37e72759794e0
Reviewed-on: https://skia-review.googlesource.com/31740
Commit-Queue: Robert Phillips <robertphillips@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
2017-08-08 13:23:20 +00:00
Mike Reed
bdc3afa577
simplify gm matrices
...
rm gm that appears to have been there solely for pdf, but we don't use
it for that now.
Bug: skia:
Change-Id: I3cf88db923c2445b7c95dda14da679a594117643
Reviewed-on: https://skia-review.googlesource.com/31760
Reviewed-by: Derek Sollenberger <djsollen@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
2017-08-08 12:43:19 +00:00
Brian Salomon
95db9b3cb1
Make bmp text position attribute be highp
...
Bug: chromium:746290
Change-Id: I90968ab3633fb50a13087500a7df7fb8adbf2af8
Reviewed-on: https://skia-review.googlesource.com/31423
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
2017-08-07 19:51:30 +00:00
Greg Daniel
e0996536a8
Add another blacklist for win Intel perf
...
Started happening after an SKP updated. This looks to be another bug
in the llvm compiler Intel is using for windows vulkan.
Bug: skia:6863
Change-Id: If2bf4c4b61d0958a21e1e56eae6497310fcff3f8
Reviewed-on: https://skia-review.googlesource.com/31640
Reviewed-by: Ethan Nicholas <ethannicholas@google.com>
Reviewed-by: Ben Wagner <bungeman@google.com>
Commit-Queue: Greg Daniel <egdaniel@google.com>
2017-08-07 19:14:25 +00:00
Mike Reed
8aeec29bec
simplify shaderbase -- remove shaderproc -- no measurable speed diff
...
Bug: skia:
Change-Id: Id355e3e480847fe78f904735e59353c4eb3ba2bb
Reviewed-on: https://skia-review.googlesource.com/31560
Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Mike Reed <reed@google.com>
2017-08-07 18:46:40 +00:00
Ravi Mistry
0f5505bfa2
Add failing SKP from new SKP repository to the ImgDecode blacklist
...
Bug: skia:6818
Change-Id: I03efbba1e67ed9c5e55eda056985d1be5fda13b2
Reviewed-on: https://skia-review.googlesource.com/31464
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
2017-08-07 17:28:50 +00:00
Greg Daniel
8eec2e3d2d
Remove blacklist of win nvidia vulkan skimage test
...
Bug: skia:6554
Change-Id: I59aaf6115aa33d73078386ba8e0791ae9e334fe7
Reviewed-on: https://skia-review.googlesource.com/31421
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Greg Daniel <egdaniel@google.com>
2017-08-07 17:03:10 +00:00
skia-deps-roller@chromium.org
9deaab6964
Roll skia/third_party/externals/angle2/ 188fd5f6f..3c76d59f1 (1 commit)
...
188fd5f6fc..3c76d59f12https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls
CQ_INCLUDE_TRYBOTS=skia.primary:Perf-Win10-MSVC-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-ANGLE,Perf-Win10-MSVC-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-ANGLE,Perf-Win10-MSVC-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-ANGLE,Perf-Win10-MSVC-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-ANGLE,Perf-Win10-MSVC-ShuttleC-GPU-GTX960-x86_64-Debug-ANGLE,Perf-Win10-MSVC-ZBOX-GPU-GTX1070-x86_64-Debug-ANGLE,Test-Win10-MSVC-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-ANGLE,Test-Win10-MSVC-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-ANGLE,Test-Win10-MSVC-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-ANGLE,Test-Win10-MSVC-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-ANGLE,Test-Win10-MSVC-ShuttleC-GPU-GTX960-x86_64-Debug-ANGLE,Test-Win10-MSVC-ZBOX-GPU-GTX1070-x86_64-Debug-ANGLE
TBR=bungeman@google.com
Change-Id: I65f1952176007aadba4840e875a48ed734568cb7
Reviewed-on: https://skia-review.googlesource.com/31443
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
2017-08-07 16:58:24 +00:00
Mike Reed
8780edabf2
add 'R' to toggle rasterpipeline in sampleapp
...
Bug: skia:
Change-Id: I5b198c883140a281d9304fe3c44978cd8fcabce9
Reviewed-on: https://skia-review.googlesource.com/31461
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Reed <reed@google.com>
2017-08-07 16:54:50 +00:00
Heather Miller
3d35d14657
fix Vulkan doc typo
...
No-Try: true
Docs-Preview: https://skia.org/?cl=31463
Bug: skia:6923
Change-Id: I8dcb40a186dac59ca0ec684afff26c81e97bcc9c
Reviewed-on: https://skia-review.googlesource.com/31463
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Heather Miller <hcm@google.com>
2017-08-07 16:53:19 +00:00
Florin Malita
2045e3b455
Avoid int overflow in LinearGradientContext::shade4_dx_clamp
...
Change-Id: I86e01aa00b14f8a4b6e64169821768ab5ece9aa3
Reviewed-on: https://skia-review.googlesource.com/31481
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Florin Malita <fmalita@chromium.org>
2017-08-07 16:04:30 +00:00
Chris Dalton
b072bb6a5c
CCPR: Process quadratic flat edges without soft msaa
...
The artifacts previously thought to require msaa can be handled by
(1) converting near-linear quadratics into lines, and (2) ensuring all
quadratic segments are monotonic with respect to the vector of their
closing edge [P2 -> P0].
No. 1 was already in effect.
No. 2 is implemented by this change.
Now we only fall back on soft msaa for the two corner pixels.
This change also does some generic housekeeping in the quadratic
processor.
Bug: skia:
Change-Id: Ib3309c2ed86d3d8bec5f451125a69326e82eeb1c
Reviewed-on: https://skia-review.googlesource.com/29721
Commit-Queue: Chris Dalton <csmartdalton@google.com>
Reviewed-by: Greg Daniel <egdaniel@google.com>
2017-08-07 15:21:30 +00:00
Yuqian Li
399b3c2a01
Add AAA and DAA toggles to viewer
...
Bug: skia:
Change-Id: I0ee397d2b2c81a25918cb28be426cf5162da772f
Reviewed-on: https://skia-review.googlesource.com/30561
Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Yuqian Li <liyuqian@google.com>
2017-08-07 15:09:59 +00:00
Yuqian Li
522101ff97
Remove SK_NO_ANALYTIC_AA
...
Google3 now has that guard flag removed.
Bug: skia:
Change-Id: I6dede8c815e9f55bd769daef3982fd2fa8a7d6be
Reviewed-on: https://skia-review.googlesource.com/31201
Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Yuqian Li <liyuqian@google.com>
2017-08-07 14:37:05 +00:00
Yuqian Li
54043a0c32
Flush threaded device when reaching max queue size
...
Our SkThreadedBMPDevice is very experimental so I didn't handle this
edge case earlier. Maybe it's now a good time to fix it.
Bug: skia:
Change-Id: Ie3938475449c1341d34200ff3afe4589836950fc
Reviewed-on: https://skia-review.googlesource.com/31203
Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Yuqian Li <liyuqian@google.com>
2017-08-07 14:34:30 +00:00
Mike Reed
1aa731a24c
remove unused shadeSpanAlpha -- handled by rasterpipeline
...
Bug: skia:
Change-Id: If13510cbc340b920342d7d4df9ce34ef1081e434
Reviewed-on: https://skia-review.googlesource.com/31420
Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Mike Reed <reed@google.com>
2017-08-07 14:32:00 +00:00
