Commit Graph

1471 Commits

Author SHA1 Message Date
Ravi Mistry
57737161fd Add Housekeeper-PerCommit-Bookmaker to cq.cfg with 100% experiment%
NoTry: true
Bug: skia:7432
Change-Id: Ic55be5b18b47d7ae9ce40247e6f2c99c0c998b4b
Reviewed-on: https://skia-review.googlesource.com/89904
Reviewed-by: Ravi Mistry <rmistry@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
2018-01-03 13:11:09 +00:00
Ravi Mistry
d4731e995c Housekeeper-PerCommit-Bookmaker bot to verify that docs match includes
Example failure- https://chromium-swarm.appspot.com/task?id=3a97e6c00ff78010
Example success- https://chromium-swarm.appspot.com/task?id=3a9814b474fcf910

Bug: skia:7432
Change-Id: I2459b7568ac2d12a0ed81b1eec9ddd61cff5b643
Reviewed-on: https://skia-review.googlesource.com/87767
Commit-Queue: Ravi Mistry <rmistry@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2018-01-02 20:49:31 +00:00
UpdateSKPs
dbcdbc40d4 Update SKP version
Automatic commit by the RecreateSKPs bot.

TBR=update-skps@skia.org
NO_MERGE_BUILDS

Change-Id: I1aa9189cde5d4fc5df289afc434f8c3060f353f8
Reviewed-on: https://skia-review.googlesource.com/90140
Reviewed-by: update-skps <update-skps@skia.org>
Commit-Queue: update-skps <update-skps@skia.org>
2017-12-31 07:19:09 +00:00
UpdateSKPs
3c678ffe2c Update SKP version
Automatic commit by the RecreateSKPs bot.

TBR=update-skps@skia.org
NO_MERGE_BUILDS

Change-Id: I5daecb02cb3bd24b2d6921eee78ad6ce58b50101
Reviewed-on: https://skia-review.googlesource.com/89460
Reviewed-by: update-skps <update-skps@skia.org>
Commit-Queue: update-skps <update-skps@skia.org>
2017-12-24 07:48:31 +00:00
Ravi Mistry
0482ced2cd Revert "Update isolate binaries and update isolate recipe"
This reverts commit 8bc327bffb.

Reason for revert: Isolate tests step in CT_ bots taking 5x longer.

Original change's description:
> Update isolate binaries and update isolate recipe
> 
> Context: Email to skiabot@ from mcgreevy@
> 
> Bug: skia:
> Change-Id: Ic3bc19600809bde5adcd9edd23ba4d8b126ec852
> Reviewed-on: https://skia-review.googlesource.com/88540
> Reviewed-by: Kevin Lubick <kjlubick@google.com>
> Commit-Queue: Ravi Mistry <rmistry@google.com>

TBR=benjaminwagner@google.com,rmistry@google.com,kjlubick@google.com

Change-Id: Ifda029a65bf6414dc40502356870101ac3f88cb8
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: skia:
Reviewed-on: https://skia-review.googlesource.com/89280
Reviewed-by: Ravi Mistry <rmistry@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
2017-12-22 18:53:56 +00:00
Kevin Lubick
60bb2d52d9 Quarantine android bots instead of shutting off device
This should make it easier to diagnose and remotely fix
the devices/hosts.

Only works because of
https://chrome-internal-review.googlesource.com/c/infradata/config/+/535542

Bug: skia:
Change-Id: Idf11a09da6c7367212a0ac0b0b959cbf49fed85b
Reviewed-on: https://skia-review.googlesource.com/89181
Reviewed-by: Ravi Mistry <rmistry@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
2017-12-22 16:12:35 +00:00
Ravi Mistry
8bc327bffb Update isolate binaries and update isolate recipe
Context: Email to skiabot@ from mcgreevy@

Bug: skia:
Change-Id: Ic3bc19600809bde5adcd9edd23ba4d8b126ec852
Reviewed-on: https://skia-review.googlesource.com/88540
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
2017-12-22 12:55:35 +00:00
Ben Wagner
63457577c5 Remove Linux IntelIris540 jobs.
Replacing IntelIris540 with IntelIris640, added in
https://skia-review.googlesource.com/c/skia/+/87202. I verified that
Gold results are still identical (modulo flakes). See also
https://skia-review.googlesource.com/c/skia/+/87721 and
https://skia-review.googlesource.com/c/skia/+/78640.

No-Try: true
Change-Id: Ifc7e80e92d6203d922e00b59127b136632af7afc
Reviewed-on: https://skia-review.googlesource.com/88427
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2017-12-21 21:01:36 +00:00
Ben Wagner
41c26eaf95 Switch CQ from IntelIris540 to 640 for Ubuntu bot.
Change-Id: I587be7c5e5da175e1f5f165511cbd14308cb9a95
Reviewed-on: https://skia-review.googlesource.com/87721
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2017-12-20 21:25:36 +00:00
Michael McGreevy
094327d6a7 Roll isolate binaries generated at infra@2aafb3b.
Note: I skipped the presubmit when uploading, because I had issues setting up my skia checkout correctly.

Roll isolate binaries generated at infra@2aafb3b.

Isolate sha1s were taken from the following builds:
https://luci-milo.appspot.com/buildbot/chromium.infra/infra-continuous-precise-64/10401
https://luci-milo.appspot.com/buildbot/chromium.infra/infra-continuous-mac-10.10-64/9823
https://luci-milo.appspot.com/buildbot/chromium.infra/infra-continuous-win-64/10680


This cl brings the skia isolate binaries up to date with the main chrome infra setup
(see similar cl at https://chromium-review.googlesource.com/c/chromium/src/+/834928).
These new versions introduce an "--exparchive" flag for both "isolate archive" and
"isolate batcharchive", which will enable the skia isolate recipes to be transitioned
away from the "isolate exparchive" command.


Change-Id: I535500e678b2c2faa784720d72ae661aa975277f
Reviewed-on: https://skia-review.googlesource.com/87500
Reviewed-by: Ravi Mistry <rmistry@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
2017-12-20 12:32:04 +00:00
Ben Wagner
ab10c8258d Re-add IntelIris640 Linux bots.
These were removed in
https://skia-review.googlesource.com/c/skia/+/78640
However, we've now decided on the 640 rather than the 540 due to
inventory.

No-Try: true
Change-Id: Icf6db636287e151d3dd3ac74cfddf8f6bd3bea6a
Reviewed-on: https://skia-review.googlesource.com/87202
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2017-12-19 20:52:16 +00:00
Brian Salomon
5c6ac64516 Revert "Revert "move homogenous with stride to matrixpriv""
This reverts commit de71572f65.

Revert "Revert "Transform vertices for distance field glyphs on CPU.""

This reverts commit f226e66d75.

Change-Id: I2545afae3beb1d6b14bba056853ed826ae7a4679
Reviewed-on: https://skia-review.googlesource.com/86603
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
2017-12-19 20:23:06 +00:00
UpdateSKPs
c2a4101e48 Update SKP version
Automatic commit by the RecreateSKPs bot.

TBR=update-skps@skia.org
NO_MERGE_BUILDS

Change-Id: I3e3d0f7416d928db399f25f42717a9186b49a70b
Reviewed-on: https://skia-review.googlesource.com/87041
Reviewed-by: update-skps <update-skps@skia.org>
Commit-Queue: update-skps <update-skps@skia.org>
2017-12-19 16:03:06 +00:00
Kevin Lubick
031e7cf5ed Make sure we get the LITTLE cores out of powersave
Bug: skia:7420
NOTRY=true
Change-Id: I785135a3abc17f63d715d459668c768a6014d9b3
Reviewed-on: https://skia-review.googlesource.com/87001
Reviewed-by: Ravi Mistry <rmistry@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
2017-12-19 15:32:46 +00:00
Ben Wagner
b578b87c70 Add Goma to CQ as experimental.
This duplicates a non-Goma Build so that we can get a better comparison
of how much Goma improves tryjob build times.

Change-Id: I9fc72b466abf07b8a47d4ced2da1ab526228b82c
Reviewed-on: https://skia-review.googlesource.com/85920
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2017-12-15 22:37:50 +00:00
Ben Wagner
832415e395 Use n1-highcpu-64 machines for Windows Builds.
Bug: skia:7409
Change-Id: I6c9d86af147f5234a0484e43e053ce1758cb312d
Reviewed-on: https://skia-review.googlesource.com/85400
Reviewed-by: Mike Klein <mtklein@chromium.org>
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2017-12-15 17:50:18 +00:00
Ben Wagner
905f8df4f5 Add cert dimension for Mac Builders.
This will make it easier to transition to new cert.

Bug: skia:7408
Change-Id: I9263851233f492c5e62155b61541783aa86ba634
Reviewed-on: https://skia-review.googlesource.com/85006
Reviewed-by: Stephan Altmueller <stephana@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2017-12-14 20:40:27 +00:00
Ben Wagner
f53e6c912d Temporarily specify machine_type for Win GCE bots.
Bug: skia:7409
Change-Id: Ic86696880858b9744bf9cea86caa3564c1a5e5af
Reviewed-on: https://skia-review.googlesource.com/85003
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2017-12-14 19:22:47 +00:00
Ben Wagner
a376e640c6 Enable Goma fallback by default.
Add a job that doesn't allow fallback so we know when things aren't
working as expected.

Change-Id: If993976d6807635bde455c2091f8a1ba18c41e27
Reviewed-on: https://skia-review.googlesource.com/83700
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2017-12-14 17:56:31 +00:00
Ben Wagner
b403816d56 Switch Goma test jobs to ANGLE/Vulkan.
No-Try: true
Change-Id: I229c2839d423d543ea7bd1aedec893d7bfeb27ea
Reviewed-on: https://skia-review.googlesource.com/83701
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2017-12-14 17:52:32 +00:00
Kevin Lubick
e9188850ec Revert "Revert "Disable extra CPUs during Nanobench""
This reverts commit 43307c09b9.

Reason for revert: Fixed this time.  Echo 1 > already online cpu
returns exit code 1, which makes python over-react.

Original change's description:
> Revert "Disable extra CPUs during Nanobench"
>
> This reverts commit 32af335e7a.
>
> Reason for revert: many unhappy android bots
>
> Original change's description:
> > Disable extra CPUs during Nanobench
> >
> > The previous experiment revealed that nanobench can
> > run on any of the online CPUs, so rather than put
> > the ones we don't need/want into powersave mode, just
> > disable them.
> >
> > Maybe in the future we can run CPU tests on the big
> > or LITTLE cpus to get perf data on higher end or
> > lower end cpus, but only if we get very stable
> > results from this.
> >
> > Bug: skia:7378
> > Change-Id: I057513a691093e7f73c0f5790e17fab1a5ec0bc4
> > Reviewed-on: https://skia-review.googlesource.com/84820
> > Reviewed-by: Kevin Lubick <kjlubick@google.com>
> > Commit-Queue: Kevin Lubick <kjlubick@google.com>
>
> TBR=borenet@google.com,mtklein@google.com,kjlubick@google.com
>
> Change-Id: I23c37a6bde631e95f0b4ae7277ec8fcf325a00e9
> Bug: skia:7378
> Reviewed-on: https://skia-review.googlesource.com/84921
> Reviewed-by: Mike Klein <mtklein@google.com>
> Commit-Queue: Mike Klein <mtklein@google.com>

No-Tree-Checks: true
Change-Id: Ie7f0a3dc6ba55c124c796aba16a0f0497f285f3a
Bug: skia:7378
Reviewed-on: https://skia-review.googlesource.com/84865
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
2017-12-14 15:21:01 +00:00
Mike Klein
43307c09b9 Revert "Disable extra CPUs during Nanobench"
This reverts commit 32af335e7a.

Reason for revert: many unhappy android bots

Original change's description:
> Disable extra CPUs during Nanobench
> 
> The previous experiment revealed that nanobench can
> run on any of the online CPUs, so rather than put
> the ones we don't need/want into powersave mode, just
> disable them.
> 
> Maybe in the future we can run CPU tests on the big
> or LITTLE cpus to get perf data on higher end or
> lower end cpus, but only if we get very stable
> results from this.
> 
> Bug: skia:7378
> notry=true
> notreechecks=true
> Change-Id: I057513a691093e7f73c0f5790e17fab1a5ec0bc4
> Reviewed-on: https://skia-review.googlesource.com/84820
> Reviewed-by: Kevin Lubick <kjlubick@google.com>
> Commit-Queue: Kevin Lubick <kjlubick@google.com>

TBR=borenet@google.com,mtklein@google.com,kjlubick@google.com

Change-Id: I23c37a6bde631e95f0b4ae7277ec8fcf325a00e9
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: skia:7378
Reviewed-on: https://skia-review.googlesource.com/84921
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
2017-12-14 12:18:42 +00:00
Kevin Lubick
32af335e7a Disable extra CPUs during Nanobench
The previous experiment revealed that nanobench can
run on any of the online CPUs, so rather than put
the ones we don't need/want into powersave mode, just
disable them.

Maybe in the future we can run CPU tests on the big
or LITTLE cpus to get perf data on higher end or
lower end cpus, but only if we get very stable
results from this.

Bug: skia:7378
notry=true
notreechecks=true
Change-Id: I057513a691093e7f73c0f5790e17fab1a5ec0bc4
Reviewed-on: https://skia-review.googlesource.com/84820
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
2017-12-14 11:49:01 +00:00
Ravi Mistry
4793d3bd2c [Infra] Automatically submit docs updates
No-Tree-Checks: true
Bug: skia:7310
Change-Id: I9c26ba4d4c3f4952ec37538b7125294de153e0e6
Reviewed-on: https://skia-review.googlesource.com/84864
Commit-Queue: Ravi Mistry <rmistry@google.com>
Reviewed-by: Ravi Mistry <rmistry@google.com>
2017-12-13 22:56:30 +00:00
Ravi Mistry
6df4befce6 [Infra] Fix skiaserve source location again
Bug: skia:7399
Change-Id: I749764f2dfc8239e9849cc09e68fb28932d58243
Reviewed-on: https://skia-review.googlesource.com/84861
Reviewed-by: Ravi Mistry <rmistry@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
2017-12-13 22:01:40 +00:00
Ben Wagner
22794a43a8 Add Goma for all Windows Clang Builds.
Change-Id: I26e75cf6cd865ec6c47b7766679177bfd30387da
Reviewed-on: https://skia-review.googlesource.com/82921
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2017-12-13 20:51:00 +00:00
Mike Klein
d1dd1ef070 cleanup {ASAN,MSAN}_{FAAA,FDAA,FSAA} bots
We no longer have any reason to suspect there's anything wrong with
these configurations, and we're not actively debugging anything
related to them anymore.

I've kept the normal Debug/Release bots.

Change-Id: I1a3d8087b519d6f01223d3b33bce762511056d1a
Reviewed-on: https://skia-review.googlesource.com/84522
Reviewed-by: Yuqian Li <liyuqian@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>
2017-12-13 20:45:30 +00:00
Mike Klein
c1ff9168c7 clean up float-cast-overflow blacklist
These should be free of overflows now.

Bug: skia:7052
Change-Id: I05118fb8f565ffb0d973b6d93a8cd8d8e27f31a9
Reviewed-on: https://skia-review.googlesource.com/84561
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>
2017-12-13 20:09:10 +00:00
Ben Wagner
37491d2674 [recipes] Provide tokenized extra_config and use it most places.
Change-Id: I7baae5f90b2e510b66443cda449071c7c6ec9ec7
Reviewed-on: https://skia-review.googlesource.com/83520
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2017-12-13 18:26:32 +00:00
Eric Boren
543de8f8a6 infra_test.py: Suggest "go get" for more types of errors
Bug: skia:7384
Change-Id: Ifcb19c864d422781d6023606406ac2b7dd23b0f8
Reviewed-on: https://skia-review.googlesource.com/84121
Reviewed-by: Greg Daniel <egdaniel@google.com>
Reviewed-by: Ravi Mistry <rmistry@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
2017-12-13 16:28:00 +00:00
Kevin Lubick
d3fbe70d3e Fix CQ.cfg copypasta
Bug: skia:
NOTRY=true
Change-Id: Id5eddbbc96d045f027e31a61961329bb54f43bd3
Reviewed-on: https://skia-review.googlesource.com/84620
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Kevin Lubick <kjlubick@google.com>
2017-12-13 16:14:32 +00:00
Kevin Lubick
7c83b24a15 Promote QuadroP400-Vulkan to CQ
Also add Nexus5x to experimental CQ

Bug: skia:
Change-Id: Ic6996e70cd9b372672fff0138a85ffe4610b4dff
NOTRY=true
Reviewed-on: https://skia-review.googlesource.com/84560
Reviewed-by: Joe Gregorio <jcgregorio@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
2017-12-13 15:54:12 +00:00
Kevin Lubick
e3b013047d Experiment with turning CPUs off during perf
Perf was nice and flat after https://skia-review.googlesource.com/c/skia/+/83240
but there was a 4-5x slowdown on the benchmarks themselves,
indicating that perhaps we were running nanobench on the
LITTLE cores (now on powersave) instead of the big cores we
thought (which were recently scaled down).

This experiment will show us FOR CERTAIN that we are
running on core 0 or 1 which is at .6 max frequency.

We expect to see a speedup from the previous results.

This is leading to turning of CPUs we don't need
to make sure nanobench is running on the ones we expect.

Bug: skia:
NOTRY=true
Change-Id: Ida65181e4d90e778e65e3f22d761288b9ade64f6
Reviewed-on: https://skia-review.googlesource.com/84201
Reviewed-by: Mike Klein <mtklein@chromium.org>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
2017-12-13 11:38:22 +00:00
Ravi Mistry
c0720db247 [Infra] Fix revision in upload_skiaserve
Bug: skia:7399
Change-Id: I44b9ed895b0a0fccb08eecec1dc20d386c90c883
Reviewed-on: https://skia-review.googlesource.com/84280
Reviewed-by: Ravi Mistry <rmistry@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
2017-12-13 02:40:10 +00:00
Ravi Mistry
d82cd17254 [Infra] Missing configuration in out dir
Bug: skia:7399
Change-Id: I3a5991d24a4657cc25d9064057c6a1a46f00580f
Reviewed-on: https://skia-review.googlesource.com/84240
Reviewed-by: Ravi Mistry <rmistry@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
2017-12-12 23:31:59 +00:00
Ravi Mistry
6f13622452 Store skiaserve binary in GS from Release Android compile bots
Bug: skia:7399
Change-Id: Id60773f77694b06a938f9a126f30ca56e4965d30
Reviewed-on: https://skia-review.googlesource.com/83981
Commit-Queue: Ravi Mistry <rmistry@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2017-12-12 22:37:05 +00:00
Ravi Mistry
578d451756 Use new bookmaker flag to status.json
Bug: skia:7310
Change-Id: I7eeb73eb6d9c07549bf7a5d7c2d8b4d3049ac3da
Reviewed-on: https://skia-review.googlesource.com/83860
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
2017-12-12 15:36:29 +00:00
Kevin Lubick
1763492c32 Fix scaling logic for NexusPlayer and AndroidOne
They seem to be their own special cases for what
governors they support.

Bug: skia:
NOTRY=true
Change-Id: I7bb220e1d3ba6851c17c7e6ef327aab24ffdba42
Reviewed-on: https://skia-review.googlesource.com/83900
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
2017-12-12 13:31:49 +00:00
Kevin Lubick
3250a487ea Search more for stacktrace to symbolize
If the stacktrace wasn't in the last 200 lines, we couldn't
find and symbolize it.
https://chromium-swarm.appspot.com/task?id=3a5e86a9d0e04e10&refresh=10

We increase the window to 500 lines to account for large memory maps.

Bug: skia:7397
NOTRY=true
Change-Id: Ic8583e383663a9beb62a32e90a5bd5d73d7446a7
Reviewed-on: https://skia-review.googlesource.com/83540
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Greg Daniel <egdaniel@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2017-12-12 13:26:39 +00:00
Kevin Lubick
f1585aabeb Scale extra CPUs to powersave during nanobench.
This scaling logic correctly accounts for some devices
which have multiple CPUs.  Previously, we were scaling
the smaller of these CPUs, which likely had a negative
impact on nanobench, given nanobench was single threaded
and the CPUs weren't allowed to idle much (because we
set the CPU).

This CL sets those additional CPUs to powersave when we run
nanobench and then correctly scales down the beefier
CPU we want to run nanobench on.

For DM, we just run it in ondemand mode, which will
hopefully be "as fast as possible", but allow the CPU
governor to scale down if overheating becomes a problem.

Bug: skia:7378
notry=TRUE
Change-Id: I45ca5d9fb32182233d1b2d094842c879f2b84da4
Reviewed-on: https://skia-review.googlesource.com/83240
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Mike Klein <mtklein@chromium.org>
2017-12-12 12:36:09 +00:00
Ravi Mistry
5ca9413b9b [Bookmaker bot] Output fiddleout.json earlier and do not send to CQ for now
Bug: skia:7310
Change-Id: Id6c2f15b72d6837f6536e25dbc3d01cac32af74b
Reviewed-on: https://skia-review.googlesource.com/83640
Reviewed-by: Ravi Mistry <rmistry@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
2017-12-11 22:17:29 +00:00
Hal Canary
a4935104a5 resources: optionally link them into our binary
To enable, set skia_embed_resources=true in args.gn.

Also add *-EmbededResouces bots.

Change-Id: Ia69b26e926a3ad4676a4fa021894432ea2104538
Reviewed-on: https://skia-review.googlesource.com/82626
Commit-Queue: Hal Canary <halcanary@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
2017-12-11 22:06:38 +00:00
Ben Wagner
dba0bc843a Re-add '--gpuThreads 0' tests.
Bug: skia:7394
Change-Id: I2e7ed586d81d19a0b7895ff81ce6670eb7cc5003
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/83445
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2017-12-11 19:50:58 +00:00
Ben Wagner
603144229b Remove PixelC CPU jobs.
The Nexus5x took these jobs in https://skia-review.googlesource.com/c/skia/+/82624

Also filed skia:7394 for missing coverage of "--gpuThreads 0".

Bug: skia:7382
Change-Id: If0fd823722d8b8cc3845f8d96a0a285fec935f74
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/83360
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2017-12-11 17:58:08 +00:00
Ben Wagner
c279851bc2 Add Goma Test/Perf jobs.
No-Try: true
Change-Id: I9c07250623603be1baccdc177191326017784aa2
Reviewed-on: https://skia-review.googlesource.com/82604
Reviewed-by: Eric Boren <borenet@google.com>
Reviewed-by: Yuqian Li <liyuqian@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2017-12-11 16:08:28 +00:00
UpdateSKPs
c34676349d Update SKP version
Automatic commit by the RecreateSKPs bot.

TBR=update-skps@skia.org
NO_MERGE_BUILDS

Change-Id: I15dc0bd674fcf806ee992c3e9b1d569b52bbaf88
Reviewed-on: https://skia-review.googlesource.com/83180
Reviewed-by: update-skps <update-skps@skia.org>
Commit-Queue: update-skps <update-skps@skia.org>
2017-12-10 07:46:40 +00:00
Ravi Mistry
edc4f3e604 Add new Bookmaker bot that runs nightly
The new bot:
1) Extracts all fiddles out of markdown files.
2) Forces fiddle.skia.org to compile all those fiddles and get output in JSON.
3) Scans the output and reports any compiletime/runtime errors.
4) Updates markdown in site/user/api/ using the new hashes (if any) from fiddle.skia.org.

To ensure the bot does not check in unexpected changes:
* upload_md.py makes sure that all modified files are under site/user/api/. It errors out if this is not the case.
* CLs with docs only changes normally have 'NoTry: true' added to their descriptions. This is not done for the new bot because we want to run it through trybots to make sure nothing unexpected snuck in.
* rmistry@ and caryclark@ are automatically CC'ed on all uploaded changes. I plan to watch the bot closely for at least a couple of weeks.


Bug: skia:7310
Change-Id: I759fc8bae1e32a6f175e3b1a895947d14ca5fe3a
Reviewed-on: https://skia-review.googlesource.com/79941
Commit-Queue: Ravi Mistry <rmistry@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2017-12-08 22:26:38 +00:00
Ben Wagner
2fc5322a04 Remove Nexus10.
Bug: skia:7381
Change-Id: I8e151c5c57f6344c9cdf165bbb78a4ed308491c8
NoTry: true
Reviewed-on: https://skia-review.googlesource.com/82804
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2017-12-08 22:07:18 +00:00
Ben Wagner
3f39bf8fe5 Add Goma support in gn_flavor.
Using full paths in skia.h causes "file not found" with Goma. All other
Builds seem fine without the path, so I changed find_headers.py to use
the basename.

Change-Id: Ib520e91a92ebffe36a736eb53f643d359f5bb2ce
Reviewed-on: https://skia-review.googlesource.com/79360
Reviewed-by: Greg Daniel <egdaniel@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2017-12-08 20:09:18 +00:00
Kevin Lubick
0b1b9c233a Update Acer Chromebooks version
Bug: skia:
NOTRY=true
Change-Id: Id03af4d45b51ea2b7ba5afd1e398f832cb9706da
Reviewed-on: https://skia-review.googlesource.com/82920
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2017-12-08 19:25:48 +00:00
Ben Wagner
b744f5b846 Add Nexus5x CPU jobs.
Bug: skia:7382
Change-Id: Ie6d86bba408b59825263f35345f415352a095f1f
NoTry: true
Reviewed-on: https://skia-review.googlesource.com/82624
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2017-12-08 19:01:18 +00:00
Eric Boren
8b225c1396 [infra] Stop the recipe roller
Bug: chromium:793309
Change-Id: I882da905088ffaf19869a78fa5453de2603e08f9
Reviewed-on: https://skia-review.googlesource.com/82644
Reviewed-by: Ravi Mistry <rmistry@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
2017-12-08 17:55:10 +00:00
Brian Osman
e562f413ea Update Windows clang asset
For reference, the version number is pulled from:

  chromium/src/third_party/llvm-build/cr_build_revision

This version of clang includes fixes for bugs in the latest
Windows 10 SDK headers.

Bug: skia:
Change-Id: Ieee6eb2dff2f98a2340a8433135b6c3f916c0577
Reviewed-on: https://skia-review.googlesource.com/82721
Commit-Queue: Brian Osman <brianosman@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2017-12-08 16:55:10 +00:00
Kevin Lubick
7f5d5d2bab Fix scaling issues for some devices (e.g. Pixel)
Bug: skia:
NOTRY=true
Change-Id: Ia6a80ecb97b5d30197932ec7d340163624e315bd
Reviewed-on: https://skia-review.googlesource.com/82682
Reviewed-by: Ravi Mistry <rmistry@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
2017-12-08 15:41:50 +00:00
Ben Wagner
3f330693a0 Add Nexus5 CPU jobs.
Bug: skia:7381
Change-Id: I4e5446420e38e0a6fdeba6f8f89e0685e5f8ac41
NoTry: true
Reviewed-on: https://skia-review.googlesource.com/82301
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2017-12-08 14:30:40 +00:00
recipe-roller
275d92c3d7 Roll recipe dependencies (nontrivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


Please review the expectation changes, and LGTM+CQ.


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
depot_tools:
  https://crrev.com/bb85b3636b13b7a3514a198b30c583439c009970 bot_update source manifest: fix test_api.py to match the actual output (hinoka@google.com)


R=kjlubick@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: If6efa9cbe00163301023a847c06f10e37067f4c0
Reviewed-on: https://skia-review.googlesource.com/82540
Commit-Queue: Eric Boren <borenet@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2017-12-08 14:12:30 +00:00
Brian Salomon
f06c358267 Remove instanced rendering
Change-Id: I4219b1d23a647b849ee41fe71b53e1c45edfc3f4
Reviewed-on: https://skia-review.googlesource.com/82241
Reviewed-by: Chris Dalton <csmartdalton@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
2017-12-08 13:41:10 +00:00
Brian Osman
852ca318a1 Updated MSVC toolchain to 2017, and further refactored GN
'windk' is no longer a thing. There are two separate variables to point
at your compiler (win_vc), and SDK (win_sdk).

'msvc' is no longer a thing, either. By default, we look for 2017 and
then 2015 (in the default locations). If neither is located, use an
assert to let users know they should set win_vc. Then, detect if win_vc
points at a 2017 or 2015 installation, and configure it automatically.

Because the toolchain is now 2017, update the GN files to handle building
x86 in that configuration. In fact, we only support x86 builds (with 2017
or 2015) using the toolchain assets. Keep a 2015 toolchain around as a
new asset, so we can add bot coverage.

Docs-Preview: https://skia.org/?cl=81841
Bug: skia:
Change-Id: I8c68a6f949e54c0e798a219450bbb9406f8dc6ac
Reviewed-on: https://skia-review.googlesource.com/81841
Reviewed-by: Mike Klein <mtklein@chromium.org>
Commit-Queue: Brian Osman <brianosman@google.com>
2017-12-08 01:46:30 +00:00
Ravi Mistry
a4ceaa1e5a [Infra] Add ability to specify a cc_list to git_utils.py
Bug: skia:7310
Change-Id: I8ef505025e2cf0b7859e54e85293efed16704398
Reviewed-on: https://skia-review.googlesource.com/82200
Commit-Queue: Ravi Mistry <rmistry@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2017-12-07 20:11:00 +00:00
Ben Wagner
1cfb6bc9b6 Decrease threads for Nexus7 further.
Bug: skia:7381
NoTry: true
Change-Id: Ib04e7d0e5dccadef47bf2f132e070ddc4910e38d
Reviewed-on: https://skia-review.googlesource.com/81962
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2017-12-07 17:32:13 +00:00
Kevin Lubick
4fd283eb7a Use full paths for adb
Add logic to run on Nexus 5xs in Golo.

Bug:788839
Change-Id: I12290d11a0b1b0f012ada216da3e5b2599979c5e
Reviewed-on: https://skia-review.googlesource.com/81861
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2017-12-07 17:06:59 +00:00
Ben Wagner
5cf6d32e80 Add Nexus7 CPU jobs.
Bug: skia:7381
Change-Id: I2dd5443c81cd895eb1d68b0cd90221a7e2e07d46
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/80843
Reviewed-by: Mike Klein <mtklein@chromium.org>
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2017-12-07 16:12:39 +00:00
Ben Wagner
52423f3684 Move PixelXL jobs to the Pixel.
NoTry: true
Change-Id: I3964ed7c18af1204cc7b11d2d0ac673512f5f5ed
Reviewed-on: https://skia-review.googlesource.com/81860
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2017-12-07 15:44:20 +00:00
Eric Boren
9d78afdd3d Revert "[infra] Move commands from isolates to gen_tasks.go"
This reverts commit 66db75da67.

Reason for revert: Breaking PDFium/Flutter

Original change's description:
> [infra] Move commands from isolates to gen_tasks.go
> 
> This has the side effect of bundling recipes for all tasks,
> which will be required anyway to run recipes in the future.
> 
> Bug: skia:7050
> Change-Id: Ia30a95c750f2a237a8bf60263b2981682673c043
> Reviewed-on: https://skia-review.googlesource.com/81300
> Commit-Queue: Eric Boren <borenet@google.com>
> Reviewed-by: Kevin Lubick <kjlubick@google.com>

TBR=borenet@google.com,bungeman@google.com,rmistry@google.com,kjlubick@google.com

Change-Id: I38e00294f098ac91285a5cc464414654fc79a9e9
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: skia:7050
Reviewed-on: https://skia-review.googlesource.com/81741
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
2017-12-07 14:54:11 +00:00
Eric Boren
66db75da67 [infra] Move commands from isolates to gen_tasks.go
This has the side effect of bundling recipes for all tasks,
which will be required anyway to run recipes in the future.

Bug: skia:7050
Change-Id: Ia30a95c750f2a237a8bf60263b2981682673c043
Reviewed-on: https://skia-review.googlesource.com/81300
Commit-Queue: Eric Boren <borenet@google.com>
Reviewed-by: Kevin Lubick <kjlubick@google.com>
2017-12-07 14:45:30 +00:00
Ben Wagner
ee3123c1cc Specify long build ID in Android dimensions.
No-Try: true
Change-Id: I345c93aea0b2047a83a09226bb4ddd1115bc2717
Reviewed-on: https://skia-review.googlesource.com/81461
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Kevin Lubick <kjlubick@google.com>
2017-12-07 14:15:00 +00:00
Leon Scroggins III
4f498fc6f0 Update to the latest version of libjpeg-turbo
Bug: b/70203010

From https://github.com/libjpeg-turbo/libjpeg-turbo/commit/c308d434.
This commit fixes a bug in BitmapRegionDecoder, and is the tip of tree.

Rather than using our mirror, just pull in upstream directly. Move our
config files into third_party/libjpeg-turbo, so we can just DEPS to
upstream. These files are unchanged, except jconfig.h, where I added a
comment regarding arithmetic coding.

Add a test image which demonstrates the bug.

Change-Id: I00f8f961f69e407dc31ca6d15c66518aa0acbafd
Reviewed-on: https://skia-review.googlesource.com/81442
Reviewed-by: Mike Klein <mtklein@chromium.org>
Commit-Queue: Leon Scroggins <scroggo@google.com>
2017-12-07 13:15:20 +00:00
Brian Osman
5f87262595 Reland "Always use the Win 10 SDK, and optionally detect/use the latest version"
This is a reland of 6da1d32c16
Original change's description:
> Always use the Win 10 SDK, and optionally detect/use the latest version
> 
> For bot toolchain builds, we were already using the Win 10 SDK. Local
> 2015 builds were using a strange hybrid of Win 10 and Win 8 SDKs. Now
> we always use the Win 10 SDK exclusively.
> 
> This adds two new GN arguments: win_sdk, which points at the top level
> Windows 10 SDK directory, and win_sdk_version, which can be used to
> pin to a specific version. (Otherwise we use a script to detect the
> most recent version).
> 
> Bug: skia:
> Change-Id: I5aabb5eb9e7f483e3676b67b50356ddd0421cf7d
> Reviewed-on: https://skia-review.googlesource.com/81304
> Reviewed-by: Mike Klein <mtklein@chromium.org>
> Commit-Queue: Brian Osman <brianosman@google.com>

Bug: skia:
Change-Id: Ide0d6bd3413c4fe7a8bada7d3d32bdba9709d11b
Reviewed-on: https://skia-review.googlesource.com/81501
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
2017-12-06 22:32:59 +00:00
Ravi Mistry
f5ab269a9d Revert "Always use the Win 10 SDK, and optionally detect/use the latest version"
This reverts commit 6da1d32c16.

Reason for revert:
Caused Build-Win-Clang-arm64-Release-Android to fail.
Eg: https://chromium-swarm.appspot.com/task?id=3a467f1ddd15fb10&refresh=10

Original change's description:
> Always use the Win 10 SDK, and optionally detect/use the latest version
> 
> For bot toolchain builds, we were already using the Win 10 SDK. Local
> 2015 builds were using a strange hybrid of Win 10 and Win 8 SDKs. Now
> we always use the Win 10 SDK exclusively.
> 
> This adds two new GN arguments: win_sdk, which points at the top level
> Windows 10 SDK directory, and win_sdk_version, which can be used to
> pin to a specific version. (Otherwise we use a script to detect the
> most recent version).
> 
> Bug: skia:
> Change-Id: I5aabb5eb9e7f483e3676b67b50356ddd0421cf7d
> Reviewed-on: https://skia-review.googlesource.com/81304
> Reviewed-by: Mike Klein <mtklein@chromium.org>
> Commit-Queue: Brian Osman <brianosman@google.com>

TBR=mtklein@chromium.org,borenet@google.com,bungeman@google.com,brianosman@google.com

Change-Id: Id044114fc685d570741e3f5ed003c4be2ffa84a3
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: skia:
Reviewed-on: https://skia-review.googlesource.com/81500
Reviewed-by: Ravi Mistry <rmistry@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
2017-12-06 21:51:30 +00:00
Mike Klein
bbfe515474 remove ThermalManager
It throttles 1000x more than intended, and I suspect that some of the
trip points it uses to decide when to throttle make no sense.  We've
already turned it off on the Nexus 5x.

Change-Id: Idf556a83fe61ccc5f63c7bede3eecbe80087e28b
Reviewed-on: https://skia-review.googlesource.com/81303
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>
2017-12-06 21:25:29 +00:00
Brian Osman
6da1d32c16 Always use the Win 10 SDK, and optionally detect/use the latest version
For bot toolchain builds, we were already using the Win 10 SDK. Local
2015 builds were using a strange hybrid of Win 10 and Win 8 SDKs. Now
we always use the Win 10 SDK exclusively.

This adds two new GN arguments: win_sdk, which points at the top level
Windows 10 SDK directory, and win_sdk_version, which can be used to
pin to a specific version. (Otherwise we use a script to detect the
most recent version).

Bug: skia:
Change-Id: I5aabb5eb9e7f483e3676b67b50356ddd0421cf7d
Reviewed-on: https://skia-review.googlesource.com/81304
Reviewed-by: Mike Klein <mtklein@chromium.org>
Commit-Queue: Brian Osman <brianosman@google.com>
2017-12-06 21:02:09 +00:00
Joe Gregorio
a3ad18344c Move experimental CQ bots to non-experimental. Add 3 more CQ bots as experimental.
Bug: skia:
Change-Id: I916c3efeab3a98e9f4fba217a35db0751298d10d
Reviewed-on: https://skia-review.googlesource.com/81341
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Joe Gregorio <jcgregorio@google.com>
2017-12-06 20:33:59 +00:00
Kevin Lubick
0f727ff90d Add dimension to differentiate Golo from Skolo for Android tasks
Bug: skia:
NOTRY=true
Change-Id: Ice619a9eed43bc3b1ecd54f1851f527bd0623cd2
Reviewed-on: https://skia-review.googlesource.com/81380
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2017-12-06 20:15:35 +00:00
Greg Daniel
ec34a71bea Add to blacklist for intel405 vulkan bot
Bug: skia:7322
Change-Id: Ic6672d1e00c810ed958df1ad08608d735ec61cb1
Reviewed-on: https://skia-review.googlesource.com/81002
Reviewed-by: Ravi Mistry <rmistry@google.com>
Commit-Queue: Greg Daniel <egdaniel@google.com>
2017-12-06 18:03:39 +00:00
Kevin Lubick
cad08c855e Fix infra tests
Bug: skia:
NOTRY=true
Change-Id: I2e6bfbcd469fc8d0b7e49e3045aa3a21bb68c47a
Reviewed-on: https://skia-review.googlesource.com/81020
Reviewed-by: Ravi Mistry <rmistry@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
2017-12-06 14:33:58 +00:00
Kevin Lubick
1946aaf15c Disable ThermalManager for Nexus5x
It's causing a lot of sleep for being too hot.  ThermalManager assumes
the trip points are static, when in fact, they are dynamic.

Bug: skia:7378
NOTRY=true
Change-Id: I907a42986831b7072a03a0423afd5a36bb2dfa74
Reviewed-on: https://skia-review.googlesource.com/80981
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
2017-12-06 14:04:28 +00:00
Kevin Lubick
4c6bde2a27 Don't set min frequency for Android devices
Bug: skia:7378
NOTRY=true
No-Tree-Checks: true
Change-Id: Iaacbc8eadaa4da9832a53d4794a2214625bef9b6
Reviewed-on: https://skia-review.googlesource.com/80842
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Kevin Lubick <kjlubick@google.com>
2017-12-05 21:28:48 +00:00
Mike Klein
89662e6981 ANGLE -> Clang
Switch all ANGLE bots to build with Clang, sort, and dedup.

And remove -x86- ANGLE builders... there's no good reason to have
builders for this config unless we're going to Test/Perf it.

Bug: skia:7377

Change-Id: I1daf8ffa98e098274a4de0ff2c40a4a7e958b211
Reviewed-on: https://skia-review.googlesource.com/80740
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>
2017-12-05 19:25:38 +00:00
Mike Klein
f32b27d2e4 remove mips support and bots
The NDK has deprecated mips and mips64:
https://developer.android.com/ndk/guides/abis.html

Might as well clean this up now while I remember.

Change-Id: Ie4b2334c75208082067cc16fe355d0349c7e0904
Reviewed-on: https://skia-review.googlesource.com/80560
Reviewed-by: Derek Sollenberger <djsollen@google.com>
2017-12-05 17:19:45 +00:00
Kevin Lubick
64ca6be98c Add release_version as dimension for ChromeOS tasks
This should prevent version skew and allow us to include this in
Gold results/bugs.

Bug: skia:
NOTRY=true
Change-Id: I9edacbb478e310eca39d2b56ac2059f26b0cb127
Reviewed-on: https://skia-review.googlesource.com/79940
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Stephan Altmueller <stephana@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
2017-12-04 21:35:59 +00:00
Ben Wagner
7d0cd9c3c6 Fix recipe comments for ASAN.
No-Try: true
Change-Id: Ifd97ba438fd30d2d9197857c86bfb010a97827a3
Reviewed-on: https://skia-review.googlesource.com/79702
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2017-12-04 18:39:59 +00:00
Ben Wagner
bee6cacc54 Merge UBSAN_float_cast_overflow into ASAN.
The new check was a different config while we fixed the errors. Most
errors are now fixed, and merging these will help with running both on
the CQ.

No-Try: true
Change-Id: I5804ecea84a8dbbaacf6a4ea96e2af9505641d49
Reviewed-on: https://skia-review.googlesource.com/79323
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Mike Klein <mtklein@chromium.org>
2017-12-04 17:08:09 +00:00
Kevin Lubick
8da3655c6e Make new CQ jobs experimental
Also fix typo in CQ jobs

Bug: skia:
NOTRY=true
Change-Id: I74d6a382b4e93fdaceabd2adf9b060a6b88caae6
Reviewed-on: https://skia-review.googlesource.com/79761
Reviewed-by: Eric Boren <borenet@google.com>
Reviewed-by: Ravi Mistry <rmistry@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
2017-12-04 15:51:58 +00:00
Kevin Lubick
ea6138253b Add additional dimension for Valgrind bots
See also: https://chrome-internal-review.googlesource.com/c/infradata/config/+/520679

This should help prevent many many Valgrind bots from
taking all the resources from the rest of the P400 bots
(including the CQ).  This is a temporary measure, hopefully
TaskScheduler will be able to do this by itself in the future.

Bug: skia:
NOTRY=true
Change-Id: Ia618f9bd90364c6658e6b08b19c8bf214e5c33d9
Reviewed-on: https://skia-review.googlesource.com/79760
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2017-12-04 15:29:28 +00:00
Kevin Lubick
4d022b50e1 Add 2 bots to CQ
Bug: skia:7369
NOTRY=true
Change-Id: I72fd0d816d5239de89957b2f95de4ecf3942198e
Reviewed-on: https://skia-review.googlesource.com/79701
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Joe Gregorio <jcgregorio@google.com>
2017-12-04 14:45:24 +00:00
UpdateSKPs
79ee73938d Update SKP version
Automatic commit by the RecreateSKPs bot.

TBR=update-skps@skia.org
NO_MERGE_BUILDS

Change-Id: I85b1de73d1c326e3c5fba07107f4e27d3834e2d9
Reviewed-on: https://skia-review.googlesource.com/79441
Reviewed-by: update-skps <update-skps@skia.org>
Commit-Queue: update-skps <update-skps@skia.org>
2017-12-03 07:54:32 +00:00
Ben Wagner
2219544816 Remove IntelIris640 bot.
IntelIris640 is 100% identical to IntelIris540 on Gold.

No-Try: true
Change-Id: I0e5342b182267a7d6ee510329b7c8ab7cb3a479e
Reviewed-on: https://skia-review.googlesource.com/78640
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2017-11-30 22:16:08 +00:00
Ben Wagner
9f9716281c Promote experimental tryjob to be blocking.
Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All has been
running for a while as an experimental tryjob and seems to be fast
enough and useful enough to be a real tryjob.

Bug: skia:7229
Change-Id: I7b47be03e7e29a3ef573933ed6c054802e111c80
Reviewed-on: https://skia-review.googlesource.com/78300
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>
Reviewed-by: Mike Klein <mtklein@chromium.org>
2017-11-30 15:50:12 +00:00
Kevin Lubick
de2f1dfebd Turn up Nexus10 CPU frequencies
The previous list was created from scaling_min_freq and scaling_max_freq
instead of cpuinfo_min_freq and cpuinfo_max_freq which are the actual mins
and maxes, not the current (transient) settings of the governor.

Before:
Test-Release: 61 minutes
Perf-Debug: 41 minutes

After:
Test-Release: 32 minutes
Perf-Debug: 16 minutes

NOTRY=true
Bug: skia:
Change-Id: I9b431e92d2abcecb4fe643389daddc912a1399e1
Reviewed-on: https://skia-review.googlesource.com/78141
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
2017-11-30 15:32:52 +00:00
Kevin Lubick
1c8092ac64 Make cpu scaling more robust
Some bots, especially the Nexus 7s, seemed to occasionally
fail when setting the CPU frequency.  I was unable to
repro this behavior, so this is a shotgun approach.

We add a 5 second delay between setting and checking,
checking frequency using scaling_cur_freq instead of
scaling_setspeed, set the min_freq as well as max_freq,
and retry up to 3 times if setting cpu frequency fails.

NOTRY=true
Bug: skia:
Change-Id: Id4d85d8d509c9dba8e3a0e06b5992f5adadf36d2
Reviewed-on: https://skia-review.googlesource.com/78140
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2017-11-30 14:13:22 +00:00
Ben Wagner
5eaa297267 Revert "Temporarily add Ubuntu IntelHD4400 jobs."
This reverts commit 373588426b.

Reason for revert: Have enough digests on Gold now.

Original change's description:
> Temporarily add Ubuntu IntelHD4400 jobs.
> 
> I want to compare this with the IntelBayTrail and if the results are
> similar, replace those bots.
> 
> No-Try: true
> Change-Id: Ib5476fe91dc446182cd1b37e93fe17962dcf961a
> Reviewed-on: https://skia-review.googlesource.com/76900
> Reviewed-by: Kevin Lubick <kjlubick@google.com>
> Commit-Queue: Ben Wagner <benjaminwagner@google.com>

TBR=benjaminwagner@google.com,kjlubick@google.com

Change-Id: Ica07d1ee635e59e3d3da51ee73591ffe08310e34
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/77860
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
2017-11-29 21:11:06 +00:00
Brian Salomon
7072e226ab Ignore deserialized path convexity and first direction.
Change-Id: Ib7bfff6225774b83d9b6e9c5baae254aab17353b
Reviewed-on: https://skia-review.googlesource.com/77680
Commit-Queue: Brian Salomon <bsalomon@google.com>
Reviewed-by: Robert Phillips <robertphillips@google.com>
2017-11-29 20:38:56 +00:00
Kevin Lubick
814b149ce3 Isolate the biggest CIPD assets to trim down on overhead
This change, when combined with https://skia-review.googlesource.com/c/buildbot/+/77701
should cut down on the duplicated work of extracting the large
toolchains from CIPD.

Since the Isolate* steps can be cached (i.e. are idempotent)
they will only run about 1/week (unless updated) and
all subsequent tasks (primarily Builds) will go much faster.

We estimate the overhead on Build-Debian-Android to go from
about 90s (which was more time than the actual build) to
about 10s.  Build-Win-Vulkan's overhead will improve from
about 180s to about 35s (1/3 of which is uploading to isolate).

Other CIPD assets could be handled in a similar fashion;
the ones here are the biggest offenders and the lowest
hanging fruit.  Doing this to other assets (e.g. clang_win)
would have minimal improvements (<10s).

There are other tasks with large amounts of overhead
(e.g. Build-Mac-Android, Build-Win-Android, Build-WASM)
but none of those are depended on by any Tests, so any
speed-ups would have less wide-reaching-impact, at the
cost of using more Isolate cache/diskspace.

See https://docs.google.com/document/d/1DFlcpqg7XqEPE5oYT1V3so2ih2285heS5w3mPT-GMBA/edit#
for more information.

Bug: skia:
Change-Id: I40dd87fe72c3d49292762a09dad6df0dfbe78f61
Reviewed-on: https://skia-review.googlesource.com/77560
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
2017-11-29 20:32:45 +00:00
Eric Boren
0425febe61 Update CT bots to Debian-9.2
This has the side effect of using the bots in the new GCE project as
well.

Bug: skia:7278
Change-Id: Ie14c93d6e3d12ccbfb679089bc50bca482fbf605
Reviewed-on: https://skia-review.googlesource.com/76261
Commit-Queue: Eric Boren <borenet@google.com>
Reviewed-by: Ravi Mistry <rmistry@google.com>
2017-11-29 18:45:05 +00:00
Eric Boren
9a9e38753a [infra] Provide Buildbucket Build ID in dm.json
Bug: skia:
Change-Id: Iefef7d617e58de2b3be2e27aac075f822641e4ce
Reviewed-on: https://skia-review.googlesource.com/77641
Reviewed-by: Stephan Altmueller <stephana@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
2017-11-29 18:38:35 +00:00
Ben Wagner
3f67914c01 Upgrade Macs to 10.13.1.
Bug: skia:7203
Change-Id: I741d15eabe502fd4c130e8ab3c3cfb92e3794e43
NoTry: true
Reviewed-on: https://skia-review.googlesource.com/68080
Reviewed-by: Stephan Altmueller <stephana@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2017-11-29 17:46:35 +00:00
Ben Wagner
373588426b Temporarily add Ubuntu IntelHD4400 jobs.
I want to compare this with the IntelBayTrail and if the results are
similar, replace those bots.

No-Try: true
Change-Id: Ib5476fe91dc446182cd1b37e93fe17962dcf961a
Reviewed-on: https://skia-review.googlesource.com/76900
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2017-11-29 16:23:55 +00:00
Ben Wagner
935a35bce4 Remove temporary image Swarming dimension.
Change-Id: Iee28f684bd6fa541e36f677ee4261e637cbd4611
Reviewed-on: https://skia-review.googlesource.com/77201
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2017-11-29 15:16:15 +00:00
Ben Wagner
0762bdf069 Upgrade GalaxyS6.
Bug: skia:7308
Change-Id: Ia84f67c310104fc75e81757de8cb8e57add763d0
Reviewed-on: https://skia-review.googlesource.com/76621
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Ben Wagner <bungeman@google.com>
2017-11-28 17:22:07 +00:00
Jim Van Verth
443a913b8f Add create_bundle support for GN
Docs-Preview: https://skia.org/?cl=75383
Bug: skia:7339
Change-Id: I985734e8b7b5af21a82cb8ee59acbfb5ff1d3ff7
Reviewed-on: https://skia-review.googlesource.com/75383
Commit-Queue: Jim Van Verth <jvanverth@google.com>
Reviewed-by: Mike Klein <mtklein@chromium.org>
2017-11-28 15:29:07 +00:00
Ben Wagner
9f553932a4 Switch Coverage GPU bot to Golo.
No-Try: true
Change-Id: I0b9f6ef3651e5309af316d7ea7e170b48f54cdeb
Reviewed-on: https://skia-review.googlesource.com/76620
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2017-11-28 14:39:57 +00:00
Kevin Lubick
082f00a60e Don't scale CPU for internal bots
For internal hardware, it tends not to work - they work at one
clock speed, despite advertising others.

Bug: skia:
NOTRY=true
Change-Id: I10bf0fc1ab4d60bfbc2eefcef5b42ceab9e3f435
Reviewed-on: https://skia-review.googlesource.com/76720
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Kevin Lubick <kjlubick@google.com>
2017-11-28 13:37:17 +00:00
Brian Salomon
cf7e1d06bc Make EGL test context access GL via GrGLInterface
Bug: skia:7334
Change-Id: I5153ef83ae350648a15d6dc427b03d464258608b
Reviewed-on: https://skia-review.googlesource.com/75980
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
2017-11-27 16:50:26 +00:00
UpdateSKPs
f8fa50f099 Update SKP version
Automatic commit by the RecreateSKPs bot.

TBR=update-skps@skia.org
NO_MERGE_BUILDS

Change-Id: I327662727f6ab0bf2b22d94f707940bf50e9005d
Reviewed-on: https://skia-review.googlesource.com/75821
Reviewed-by: update-skps <update-skps@skia.org>
Commit-Queue: update-skps <update-skps@skia.org>
2017-11-26 07:43:43 +00:00
Ben Wagner
2040ed2bd9 Rename AMDHD7770 to RadeonHD7770.
Also drive-by cleanup of "Win8-MSVC-ShuttleB", none of which currently
exist.

No-Try: true
Change-Id: Ide28481939b7ec2a0733ab07673379c951123f5d
Reviewed-on: https://skia-review.googlesource.com/75361
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2017-11-24 23:13:22 +00:00
Brian Osman
e1e926a79c Remove obsolete iOSShell references from infra scripts
Bug: skia:
Change-Id: I36cb94877d513fc81c211b0e58b5c4be0451ac91
Reviewed-on: https://skia-review.googlesource.com/74601
Commit-Queue: Brian Osman <brianosman@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2017-11-22 16:06:05 +00:00
Brian Osman
fe546d09f8 VisualBench is not a thing anymore
Bug: skia:
Change-Id: I391cbc6cb2bf2ae88af0612964f4265788c8e771
Reviewed-on: https://skia-review.googlesource.com/74600
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2017-11-22 16:00:54 +00:00
UpdateSKPs
4419a58a9c Update SKP version
Automatic commit by the RecreateSKPs bot.

TBR=update-skps@skia.org
NO_MERGE_BUILDS

Change-Id: Ic62e7b8951a3a48521af18d2d660aca8802b7d8f
Reviewed-on: https://skia-review.googlesource.com/75341
Reviewed-by: update-skps <update-skps@skia.org>
Commit-Queue: update-skps <update-skps@skia.org>
2017-11-22 15:51:56 +00:00
Kevin Lubick
3ad5e61d80 Fix scaling on Nexus 7 bots
Bug: skia:
NOTRY=true
Change-Id: I1a1755dd03f2e6ebd8d9b2c9235cca8eb34f04ad
Reviewed-on: https://skia-review.googlesource.com/75280
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
2017-11-22 15:34:34 +00:00
Kevin Lubick
d1bbd5f777 Make CPU scaling code cleaner
This also makes *sure* the CPU frequency we set the
device to actually "takes".  Along the way, I learned
if scaling_max_freq is < the frequency we set, the
scaling_max_freq will be used instead, which was
happening to the PixelCs and AndroidOnes.

As a result, this may make those two Test- configs faster.

Bug: skia:
Change-Id: I10c98d37e296a19e1cf67bfe7269bb59cdd912d5
Reviewed-on: https://skia-review.googlesource.com/74360
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2017-11-21 22:38:20 +00:00
Ben Wagner
bb68066cfd Remove Skolo NVIDIA Linux bots.
Docs-Preview: https://skia.org/?cl=74160
No-Try: true
Change-Id: Icb3a8ac00e640de345f4fbed89642bee569bbe9b
Reviewed-on: https://skia-review.googlesource.com/74160
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Chris Dalton <csmartdalton@google.com>
2017-11-21 19:43:09 +00:00
UpdateSKPs
2aa09dbe8a Update SKP version
Automatic commit by the RecreateSKPs bot.

TBR=update-skps@skia.org
NO_MERGE_BUILDS

Change-Id: I38b6170ddafd237af0bb77ab1a351edc7b3c28d5
Reviewed-on: https://skia-review.googlesource.com/74221
Reviewed-by: update-skps <update-skps@skia.org>
Commit-Queue: update-skps <update-skps@skia.org>
2017-11-21 18:19:49 +00:00
UpdateSKPs
0a3adc0b0a Update SKP version
Automatic commit by the RecreateSKPs bot.

TBR=update-skps@skia.org
NO_MERGE_BUILDS

Change-Id: Ib8cf343936639298d468f3655d07ad400fc136b7
Reviewed-on: https://skia-review.googlesource.com/74260
Reviewed-by: update-skps <update-skps@skia.org>
Commit-Queue: update-skps <update-skps@skia.org>
2017-11-21 16:46:39 +00:00
Kevin Lubick
cac3819901 Remove Nexus 6ps
These will be replaced by the Nexus 5x.

Bug: skia:7309
No-Try: true
Change-Id: I2a56a494203f2af41f16dcfd55ebe1ca28e9e939
Reviewed-on: https://skia-review.googlesource.com/73881
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
2017-11-21 13:41:29 +00:00
UpdateSKPs
3173727f42 Update SKP version
Automatic commit by the RecreateSKPs bot.

TBR=update-skps@skia.org
NO_MERGE_BUILDS

Change-Id: I01733172ab89cb19aae8fae95f70be4802664998
Reviewed-on: https://skia-review.googlesource.com/73941
Reviewed-by: update-skps <update-skps@skia.org>
Commit-Queue: update-skps <update-skps@skia.org>
2017-11-20 22:28:18 +00:00
Greg Daniel
0eef674a5e Add gm to win vulkan intell blacklist
Bug: skia:6398
Change-Id: Ic04fa93dfe59c3c2b9322ffbe24e4791da9056ee
Reviewed-on: https://skia-review.googlesource.com/73802
Reviewed-by: Herb Derby <herb@google.com>
Commit-Queue: Greg Daniel <egdaniel@google.com>
2017-11-20 21:28:18 +00:00
Kevin Lubick
bca95a5ac5 Put CPU frequency scaling in recipes
Bug: skia:
Change-Id: I994f67c3043306d7fa612feb03f8fbe8d7bf4c91
Reviewed-on: https://skia-review.googlesource.com/73760
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2017-11-20 21:14:18 +00:00
Ben Wagner
32eb5ba7af Add bug number to comment.
No-Try: true
Change-Id: I9fe2b133264eb74b066364d5a490aae2de232bd3
Reviewed-on: https://skia-review.googlesource.com/73820
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2017-11-20 19:28:18 +00:00
Ben Wagner
34b4b37a40 Switch to new Windows image.
Change-Id: I667e0b8206461df797f0f5e481fe78a3f928481a
Reviewed-on: https://skia-review.googlesource.com/73261
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2017-11-20 17:30:58 +00:00
Ben Wagner
5ff3ee316a Expand Windows GPU test configs.
No-Try: true
Change-Id: I2511801c746d3e434cd5eb7cc553bdc7b35fcf74
Reviewed-on: https://skia-review.googlesource.com/72680
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2017-11-20 16:02:48 +00:00
Ben Wagner
b842703085 Add Linux IntelHD405 Vulkan jobs.
No-Try: true
Change-Id: Id2631fc8df97b2a76775b01db212085d94c82906
Reviewed-on: https://skia-review.googlesource.com/72902
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2017-11-20 15:23:48 +00:00
Ben Wagner
eb549c8c0e Add Nexus5x
Bug: skia:7309
NoTry: true
Change-Id: I9d9e18f8fe8bc53a54de26533485b262ba825ea7
Reviewed-on: https://skia-review.googlesource.com/72980
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2017-11-17 20:48:06 +00:00
Ben Wagner
e686cc4efa Specify image dimension for all Win2016 tasks.
Followup to https://skia-review.googlesource.com/c/skia/+/73260, which
missed Build tasks.

Change-Id: I73c346adea2af9180cdf69b7fba0f586c35a6a47
Reviewed-on: https://skia-review.googlesource.com/73341
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2017-11-17 20:28:36 +00:00
Ben Wagner
28db288ec2 Specify image dimension for Win2016.
Will remove after transition to new image.

Change-Id: I4254643aa1279b6e2046d2cdef9ff1d481f85531
Reviewed-on: https://skia-review.googlesource.com/73260
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2017-11-17 19:06:26 +00:00
Leon Scroggins III
03588412c8 Fix webp bug compositing alpha frames on opaque (better fix)
The old code made the wrong assumptions about premultiplication.

There are three relevant steps here for decoding a webp frame:
1 tell libwebp to decode
2 colorXform the result (sometimes)
3 blend with the prior frame (sometimes)

Rearrange the code to premultiply at the blend step, in a linear space.
If the client wants unpremul, the blend step will unpremul after.

If there is no blending, the colorXform (if any) will premultiply.

If only step 1 is necessary, let libwebp premultiply.

This fixes an animated image that has an opaque frame 0 followed by a
frame with alpha that blends with it.

Add the test image that failed (https://mathiasbynens.be/demo/animated-webp)

The prior fix is in 42bae8faa4. It did
not properly handle the colorXform when there was no blending step.

Change-Id: I2b9d265ba162eaf7e55a106c8f79341826cee0d3
Reviewed-on: https://skia-review.googlesource.com/72281
Commit-Queue: Leon Scroggins <scroggo@google.com>
Reviewed-by: Mike Klein <mtklein@chromium.org>
2017-11-17 13:28:45 +00:00
Mike Klein
bc13605c62 remove Win10 GDI bot
One (Win7) GDI bot is enough.

Change-Id: I03312c21e7b6da2a50225fd5dbc50bc69a6bd4c2
Reviewed-on: https://skia-review.googlesource.com/72640
Reviewed-by: Ben Wagner <bungeman@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>
2017-11-16 18:13:12 +00:00
Ben Wagner
d8e3bd77a2 Remove Win7/Win8 Perf-Release jobs.
The bots that execute these jobs produce noisy perf numbers.

No-Try: true
Change-Id: Icb3a54e324e0823f680042838b6f883ff5937f93
Reviewed-on: https://skia-review.googlesource.com/72200
Reviewed-by: Mike Klein <mtklein@chromium.org>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2017-11-15 21:47:20 +00:00
Ben Wagner
fd66b5f82b Remove/move remaining Win2k8 GCE jobs.
Bug: skia:7305
Change-Id: Ifb270cba27daaef75d3930f990e19215a251ca28
Reviewed-on: https://skia-review.googlesource.com/71921
Reviewed-by: Mike Klein <mtklein@chromium.org>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2017-11-15 20:42:42 +00:00
Brian Salomon
559f556d9d Remove support for image load/store
This isn't used and has become a maintenance burden.

Change-Id: I5f3af8f91e5c4f073fe4ea30e0a7f1f61efeea47
Reviewed-on: https://skia-review.googlesource.com/70640
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
2017-11-15 20:06:12 +00:00
Ben Wagner
78935c2455 Move FxAA jobs to Win2016.
Bug: skia:7305
Change-Id: I3cfdb15c11d08143dce66046d66b0ce633277384
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/71862
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Yuqian Li <liyuqian@google.com>
2017-11-15 19:01:32 +00:00
Mike Klein
7893212d1f remove COLR from the big Vulkan blacklist
Change-Id: I15b76d5da795ee01eb7e403721beebf5f67d1bc4
Reviewed-on: https://skia-review.googlesource.com/71920
Reviewed-by: Mike Klein <mtklein@chromium.org>
Commit-Queue: Mike Klein <mtklein@chromium.org>
2017-11-15 18:42:27 +00:00
Ben Wagner
22d7de57ce Switch CQ from Win2k8 to Win2016.
Bug: skia:7305
Change-Id: I18d9656ca74e27ed2c2ac18c55d056901a4ac683
Reviewed-on: https://skia-review.googlesource.com/71721
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2017-11-15 18:37:57 +00:00
Eric Boren
170c39c98a Update GCE bots to Debian 9.2
Bug: skia:
Change-Id: Ie56f848889cfc7331109aed997a85bc42e27f60e
Reviewed-on: https://skia-review.googlesource.com/70724
Commit-Queue: Eric Boren <borenet@google.com>
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
2017-11-15 18:02:46 +00:00
Ben Wagner
d3fdcc9271 Switch Win builders from Win2k8 to Win2016.
Bug: skia:7296
Change-Id: Id30df3ed2264679338913f275caa69b8e2278075
Reviewed-on: https://skia-review.googlesource.com/70661
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2017-11-15 15:29:16 +00:00
Greg Daniel
41886c8913 Add back more nexus player blacklists for Vulkan
Bug: skia:
Change-Id: I020fe58771d2bd6fd029b5b6a688f78530ef359c
Reviewed-on: https://skia-review.googlesource.com/71760
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Greg Daniel <egdaniel@google.com>
2017-11-15 14:58:56 +00:00
Leon Scroggins
2009c20309 Revert "Fix webp bug compositing alpha frames on opaque"
This reverts commit 42bae8faa4.

Reason for revert: Breaking GMs. A more extensive fix is needed.

Original change's description:
> Fix webp bug compositing alpha frames on opaque
> 
> select_xform_alpha is used to determine how the color transform should
> handle alpha values. In a similar way, we're using it here to determine
> whether to premultiply pixels before blending them. In this case, the
> source is unpremul, so we should be premultiplying them, but since we
> are compositing on an opaque frame, the dst must be opaque and
> select_xform_alpha returns kOpaque. As a result, we do not premultiply
> (and even hint to the transform that the pixels are opaque). Since this
> all applies to the pre-blended pixels, we should not care that the dst
> is opaque. So drop the call to select_xform_alpha and just use the alpha
> type of the source. This matches the comment on the lines above.
> 
> Add the test image that failed (https://mathiasbynens.be/demo/animated-webp)
> 
> Change-Id: Ibd13c1f067bdf369ce1c882d4f6057aadccfa313
> Reviewed-on: https://skia-review.googlesource.com/71560
> Commit-Queue: Leon Scroggins <scroggo@google.com>
> Reviewed-by: Mike Klein <mtklein@chromium.org>

TBR=mtklein@chromium.org,scroggo@google.com

Change-Id: I6f535ff9b773a93e02a0358b830291594a6e738c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/71720
Reviewed-by: Leon Scroggins <scroggo@google.com>
Commit-Queue: Leon Scroggins <scroggo@google.com>
2017-11-15 13:49:27 +00:00
Leon Scroggins III
42bae8faa4 Fix webp bug compositing alpha frames on opaque
select_xform_alpha is used to determine how the color transform should
handle alpha values. In a similar way, we're using it here to determine
whether to premultiply pixels before blending them. In this case, the
source is unpremul, so we should be premultiplying them, but since we
are compositing on an opaque frame, the dst must be opaque and
select_xform_alpha returns kOpaque. As a result, we do not premultiply
(and even hint to the transform that the pixels are opaque). Since this
all applies to the pre-blended pixels, we should not care that the dst
is opaque. So drop the call to select_xform_alpha and just use the alpha
type of the source. This matches the comment on the lines above.

Add the test image that failed (https://mathiasbynens.be/demo/animated-webp)

Change-Id: Ibd13c1f067bdf369ce1c882d4f6057aadccfa313
Reviewed-on: https://skia-review.googlesource.com/71560
Commit-Queue: Leon Scroggins <scroggo@google.com>
Reviewed-by: Mike Klein <mtklein@chromium.org>
2017-11-14 21:33:14 +00:00
Mike Klein
629d8588b9 remove Win2016 NativeFonts bots
Change-Id: I7df9d1a9118fbd9c545912a38af4f94276f20b0f
Reviewed-on: https://skia-review.googlesource.com/71521
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>
2017-11-14 20:55:34 +00:00
Ben Wagner
9592817042 Add Win2016 jobs.
Bug: skia:7197
No-Try: true
Change-Id: If2c8939739bc0583a08c0fcb400d28a90599f047
Reviewed-on: https://skia-review.googlesource.com/69401
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2017-11-14 18:25:04 +00:00
Mike Klein
0030c5ed3c generalize IntelIris540 Win/Vulkan blacklists
These won't have the "Win" or "Win10" bits in them anymore.

Change-Id: I2917c4227efcac7c2169a111fdaf62fcd83ea94a
Reviewed-on: https://skia-review.googlesource.com/70800
Reviewed-by: Brian Osman <brianosman@google.com>
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>
2017-11-13 19:06:21 +00:00
Mike Klein
0c5fdcb189 streamline GDI bots
- Replace build-time GDI support in all of Skia
   with run-time GDI support only in DM.

 - Make the GDI bots NativeFont bots paralelling
   the other NativeFonts bots.

Change-Id: I424b20f6983d8a8ba8574650efefea2b8776bbe2
Reviewed-on: https://skia-review.googlesource.com/70721
Reviewed-by: Ben Wagner <bungeman@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>
2017-11-13 18:47:11 +00:00
Greg Daniel
4c723832df Add tilesmode_npot to nexus player blacklist
readd [scaled_]tilemodes_npot to blacklist after it was removed last week
since it is failing randomly on bots.

Bug: skia:
Change-Id: Ieef97470c1ae4c960fa6efb7294e2ff203cc0bd6
Reviewed-on: https://skia-review.googlesource.com/70740
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Greg Daniel <egdaniel@google.com>
2017-11-13 18:20:20 +00:00
Brian Salomon
f44754a42b Drop support for OSMesa in test tools and remove build bot
Change-Id: Ic85ee05fe292a36a053ca7a20ccce24a4da4fae2
Reviewed-on: https://skia-review.googlesource.com/70026
Reviewed-by: Joe Gregorio <jcgregorio@google.com>
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
2017-11-13 16:20:10 +00:00
Mike Klein
c207da8d40 disable native fonts except on NativeFonts bots
a.k.a. GM fontpocalypse

Change-Id: If834940574adea29b48f35abec61f0a1c9bd59d3
Reviewed-on: https://skia-review.googlesource.com/69881
Reviewed-by: Mike Klein <mtklein@chromium.org>
Commit-Queue: Mike Klein <mtklein@chromium.org>
2017-11-12 13:50:26 +00:00
UpdateSKPs
dee8a432ac Update SKP version
Automatic commit by the RecreateSKPs bot.

TBR=update-skps@skia.org
NO_MERGE_BUILDS

Change-Id: I9ea3e46640e7eebbf3b2f6455cfcaa597021bed3
Reviewed-on: https://skia-review.googlesource.com/70401
Reviewed-by: update-skps <update-skps@skia.org>
Commit-Queue: update-skps <update-skps@skia.org>
2017-11-12 13:24:56 +00:00
Mike Klein
5b4a6ab255 make NativeFonts bots Debug bots
Change-Id: I590b60862891c4232d90f9c6dbd93cb1bedc0672
Reviewed-on: https://skia-review.googlesource.com/69903
Reviewed-by: Ben Wagner <bungeman@google.com>
2017-11-10 21:50:09 +00:00
Ben Wagner
0ecc2b7e19 Unomit NexusPlayer tests after latest OS upgrade.
NoTry: true
Change-Id: I1212830dcd997901d13208c4729477fda600e4d7
Reviewed-on: https://skia-review.googlesource.com/67960
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2017-11-10 16:07:37 +00:00
Ravi Mistry
42ceab02f3 Switch CT_BENCH_10k_SKPs bot to use QuadroP400
Bug: skia:7272
Change-Id: I634f00c57b0c999a65d22a748b83a6ff5c35fd74
Reviewed-on: https://skia-review.googlesource.com/68940
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
2017-11-08 21:43:37 +00:00
Ben Wagner
85fb42ae4c Upgrade Skolo Win NVIDIA drivers.
NoTry: true
Change-Id: If69505d7fc4f373680a3251989975b030fa0aede
Reviewed-on: https://skia-review.googlesource.com/68219
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2017-11-07 23:53:36 +00:00
Chris Dalton
035fcdfe57 Blacklist path_text_clipped on Chromecast
The test takes so long that the bot times out.

Bug: skia:
Change-Id: I77e7b192a1df1f422e61f09a931b7576fa55fbde
Reviewed-on: https://skia-review.googlesource.com/68440
Commit-Queue: Chris Dalton <csmartdalton@google.com>
Reviewed-by: Kevin Lubick <kjlubick@google.com>
2017-11-07 22:58:46 +00:00
Brian Osman
09eba3cad9 Test SkColorSpaceXformCanvas on GTX1070 bots
Bug: skia:
Change-Id: I48e37d1449c14298d03eea9c07a9aee1af78b47a
Reviewed-on: https://skia-review.googlesource.com/67809
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2017-11-07 14:37:18 +00:00
Kevin Lubick
57eea942a6 Restore Pixelbook jobs
These were accidentally deleted on https://skia-review.googlesource.com/c/skia/+/66880

Bug: skia:
NOTRY=true
Change-Id: I99a13b236aa626ed224dbc503707d16c08b5219d
Reviewed-on: https://skia-review.googlesource.com/68204
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
2017-11-07 14:21:38 +00:00
Brian Osman
f4a95bc22b Add a new testcase to test.py (GTX1070 Windows)
I'm going to be adding changes to bots matching this pattern, but want
the previous expectation files in first.

Bug: skia:
Change-Id: I61101a0ce7c66dde1e28dc307f8f7c5f66d6644e
Reviewed-on: https://skia-review.googlesource.com/67852
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2017-11-06 19:34:19 +00:00
Ben Wagner
4d3b672b5c Revert "Specify minor MacOS version before upgrade."
This reverts commit c2d18f34de.

Reason for revert: GPU bots are on 10.12.6.

Original change's description:
> Specify minor MacOS version before upgrade.
>
> Bug: skia:7203
> NoTry: true
> Change-Id: I24a098bff3897e36cf2a6125980e842b37261a2a
> Reviewed-on: https://skia-review.googlesource.com/67320
> Reviewed-by: Stephan Altmueller <stephana@google.com>
> Commit-Queue: Ben Wagner <benjaminwagner@google.com>

TBR=benjaminwagner@google.com,stephana@google.com

NoTry: true
Bug: skia:7203
Change-Id: I173248ad99d88706be3b10f862fee4ff9da33e83
Reviewed-on: https://skia-review.googlesource.com/67808
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
2017-11-06 19:28:29 +00:00
Mike Klein
9a01a215bb add a few NativeFonts bots
These are no different from other bots yet, except that they only run
8888 GMs and unit tests.  They will in the future pass --nativeFonts
true, while other bots will pass --nativeFonts false, the effect of
which has not quite yet been pinned down.

Change-Id: I467852269856dda05330957bc357ef15a2c2a1eb
Reviewed-on: https://skia-review.googlesource.com/67769
Commit-Queue: Mike Klein <mtklein@chromium.org>
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Ben Wagner <bungeman@google.com>
2017-11-06 18:54:50 +00:00
Mike Klein
7a13d871ca pass -k 0 to ninja
This makes failing builds print all failures, not just the first.
Successful builds, the usual case, are unaffected.

Change-Id: I8dde21e913f6715e7760b298a87f51d1b40a8789
Reviewed-on: https://skia-review.googlesource.com/67803
Reviewed-by: Ben Wagner <bungeman@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>
2017-11-06 15:01:19 +00:00
UpdateSKPs
6e0424ec5e Update SKP version
Automatic commit by the RecreateSKPs bot.

TBR=update-skps@skia.org
NO_MERGE_BUILDS

Change-Id: I7e1e5e3d80c1944be67be90e107d261302d1e6a0
Reviewed-on: https://skia-review.googlesource.com/67922
Commit-Queue: update-skps <update-skps@skia.org>
Reviewed-by: update-skps <update-skps@skia.org>
2017-11-05 08:06:18 +00:00
recipe-roller
bf1c2159c2 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
depot_tools:
  https://crrev.com/ae97943bbcac71a0d99efcc340bf85ace0cc9d8e watchlists: Precompile filepath regular expressions before using them. (raphael.kubo.da.costa@intel.com)
  https://crrev.com/c59738523c35c088d2f665b2169ea2dd9e07a508 Change rietveld.py to use GET on get_depends_on_patchset (agable@chromium.org)
  https://crrev.com/0a01aa6823702cdf3de2d41e019b4646d27ea30c Update depot_tools bleeding-edge git to 2.15.0 (agable@chromium.org)
  https://crrev.com/eba8347018794e4bc42b5171a31fa85fbe60e8ce Add CheckVPythonSpec for verifying .vpython file syntax (sergiyb@chromium.org)
  https://crrev.com/dce9b6295fae56482e084c5f29b2ffb2d9875c3b tests: Use the right clean up method name for some test cases. (raphael.kubo.da.costa@intel.com)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I6ae8f62229ad5e59729cdbac681f663807d803e6
Reviewed-on: https://skia-review.googlesource.com/67725
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
2017-11-03 21:28:14 +00:00
Ben Wagner
c2d18f34de Specify minor MacOS version before upgrade.
Bug: skia:7203
NoTry: true
Change-Id: I24a098bff3897e36cf2a6125980e842b37261a2a
Reviewed-on: https://skia-review.googlesource.com/67320
Reviewed-by: Stephan Altmueller <stephana@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2017-11-03 16:26:34 +00:00
Ben Wagner
9539a8c5e6 Upgrade angler and fugu to latest OS.
No-Try: true
Change-Id: I5fb4678c40956b8cd7fd89c43451d59aeebcab27
Reviewed-on: https://skia-review.googlesource.com/66883
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2017-11-03 13:39:30 +00:00
Mike Klein
ec9e18a944 Revert "Include Vulkan in all Android builds on the CQ"
This reverts commit 6516293c12.

Reason for revert:

Build-Debian9-Clang-arm-Debug-Android_Vulkan and Build-Debian9-Clang-mips64el-Debug-Android_Vulkan don't exist yet.  (Build-Debian9-Clang-arm64-Debug-Android_Vulkan does.)

Original change's description:
> Include Vulkan in all Android builds on the CQ
> 
> Bug: skia:
> Change-Id: I3988b0e16ab0d6b7e14523afb9aa38ddc0a26ece
> Reviewed-on: https://skia-review.googlesource.com/66980
> Commit-Queue: Chris Dalton <csmartdalton@google.com>
> Reviewed-by: Ben Wagner <benjaminwagner@google.com>

TBR=mtklein@google.com,benjaminwagner@google.com,rmistry@google.com,csmartdalton@google.com

Change-Id: I7128ec16f79775f413f22be2b663a87a73ca0dfe
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: skia:
Reviewed-on: https://skia-review.googlesource.com/67660
Reviewed-by: Mike Klein <mtklein@chromium.org>
Commit-Queue: Mike Klein <mtklein@chromium.org>
2017-11-03 12:21:30 +00:00
Chris Dalton
6516293c12 Include Vulkan in all Android builds on the CQ
Bug: skia:
Change-Id: I3988b0e16ab0d6b7e14523afb9aa38ddc0a26ece
Reviewed-on: https://skia-review.googlesource.com/66980
Commit-Queue: Chris Dalton <csmartdalton@google.com>
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
2017-11-02 23:38:51 +00:00
Yuqian Li
ab246cb58d Add a GPU calmbench bot
Bug: skia:
Change-Id: I354c295ce04f5e478e88f724e0b17ce90496a4cc
Reviewed-on: https://skia-review.googlesource.com/65341
Commit-Queue: Yuqian Li <liyuqian@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2017-11-02 19:04:21 +00:00
Kevin Lubick
d7af1dbb64 Rename chromebook jobs to be more human friendly
Bug: skia:
NOTRY=true
Change-Id: I500eae85ec334dc7121266ebd2f41dc526ec4695
Reviewed-on: https://skia-review.googlesource.com/66880
Reviewed-by: Mike Klein <mtklein@chromium.org>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
2017-11-02 18:07:34 +00:00
Kevin Lubick
b718fbb7f4 Add Pixelbook to tree
Bug: skia:7249
NOTRY=true
Change-Id: I7ab6bc28d567ca5ae75df9c1e56b46c307032024
Reviewed-on: https://skia-review.googlesource.com/66143
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
2017-11-02 13:36:21 +00:00
Kevin Lubick
af79192aa3 Make CPU coverage bot a bit faster
Adding -O1 and reducing the shards to cut down on overhead
in post-production.  This seems to save us a few minutes
(e.g. ~26 -> ~23 minutes).

The optimized code has about 600 fewer reachable lines of code
(according to the Coverage measurement), which is acceptable
given our tests run on -O1 or better.

Experiments (in this review) show that O3 is faster than O1, 
but not significantly enough where we want to deviate from 
our normal Debug bots:
Control: 73 minutes
-O1: 59 minutes
-O2: 60 minutes
-O3: 50 minutes

Bug: skia:
NOTRY=true
Change-Id: I33344c1cd2408373004d010e36ce27d6aa03deb2
Reviewed-on: https://skia-review.googlesource.com/65503
Reviewed-by: Mike Klein <mtklein@chromium.org>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
2017-11-02 13:15:51 +00:00
Stan Iliev
9d8850b93c Revert "Add testcase for gbr config running on GTX1070 bots to test.py"
This reverts commit 85e98387a3.

Reason for revert: brakes build

Original change's description:
> Add testcase for gbr config running on GTX1070 bots to test.py
> 
> Bug: skia:
> Change-Id: I1f993100af712ce688dd21b5e510ffae4b587dce
> Reviewed-on: https://skia-review.googlesource.com/66155
> Commit-Queue: Brian Osman <brianosman@google.com>
> Commit-Queue: Mike Klein <mtklein@chromium.org>
> Reviewed-by: Mike Klein <mtklein@chromium.org>

TBR=mtklein@chromium.org,mtklein@google.com,brianosman@google.com

Change-Id: I3abebe01bb0285377321ed150cca0c76e8636a39
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: skia:
Reviewed-on: https://skia-review.googlesource.com/66422
Reviewed-by: Stan Iliev <stani@google.com>
Commit-Queue: Stan Iliev <stani@google.com>
2017-11-01 21:40:41 +00:00
Stan Iliev
596c45eaec Revert "Test SkColorSpaceXformCanvas on GTX1070 bots"
This reverts commit d4685403e2.

Reason for revert: Brakes build on Test-Win10-Clang-ZBOX-GPU-GTX1070-x86_64-Debug-All

Original change's description:
> Test SkColorSpaceXformCanvas on GTX1070 bots
> 
> Bug: skia:
> Change-Id: I98042ea6e7fe8b81e5f1cb38d8287a6cff394279
> Reviewed-on: https://skia-review.googlesource.com/66151
> Reviewed-by: Brian Salomon <bsalomon@google.com>
> Commit-Queue: Brian Osman <brianosman@google.com>

TBR=mtklein@google.com,bsalomon@google.com,brianosman@google.com

Change-Id: I5567441404554c33c35f5487ffdac199640ddb70
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: skia:
Reviewed-on: https://skia-review.googlesource.com/66462
Reviewed-by: Stan Iliev <stani@google.com>
Commit-Queue: Stan Iliev <stani@google.com>
2017-11-01 21:15:11 +00:00
Ben Wagner
8f21f2172f Add Win2k8 QuadroP400 jobs.
This is a placeholder until we can get ANGLE working on these bots.

Bug: skia:6734
Change-Id: I8361da10acaa3c85faaa8ebfc1f1797d3f5e90f7
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/26368
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2017-11-01 19:33:51 +00:00
recipe-roller
28441ec6b5 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
depot_tools:
  https://crrev.com/5d790d53ea6ec3c761415a1154de11756b87c37a Revert "Reland "bot_update recipe: Upload source manifest"" (hinoka@chromium.org)
  https://crrev.com/70dea4270ec17be5af9f04492d3ba15f58df4501 Reland 2 "bot_update recipe: Upload source manifest" (hinoka@google.com)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I0f8e6f7b3bc71649b9efc8ffdba1f208921a400c
Reviewed-on: https://skia-review.googlesource.com/66303
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
2017-11-01 19:26:05 +00:00
Ben Wagner
721718059f Upgrade GT610 to Win 10 Creators Update.
Bug: 777523
No-Try: true
Change-Id: I0b9fe60c571dd9a96d6fd27c74071ef1809b4da5
Reviewed-on: https://skia-review.googlesource.com/66158
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2017-11-01 19:21:01 +00:00
recipe-roller
acf02025fc Roll recipe dependencies (nontrivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


Please review the expectation changes, and LGTM+CQ.


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
depot_tools:
  https://crrev.com/47b67c426b1d7120803e09f570e1cca312b34249 Reland "bot_update recipe: Upload source manifest" (hinoka@google.com)


R=kjlubick@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I22d3c671c6d0e654be19661c8e0d9795f920dc56
Reviewed-on: https://skia-review.googlesource.com/66060
Commit-Queue: Eric Boren <borenet@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
Reviewed-by: Ryan Tseng <hinoka@google.com>
2017-11-01 19:00:50 +00:00
Brian Osman
85e98387a3 Add testcase for gbr config running on GTX1070 bots to test.py
Bug: skia:
Change-Id: I1f993100af712ce688dd21b5e510ffae4b587dce
Reviewed-on: https://skia-review.googlesource.com/66155
Commit-Queue: Brian Osman <brianosman@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>
Reviewed-by: Mike Klein <mtklein@chromium.org>
2017-11-01 17:24:40 +00:00
Brian Osman
d4685403e2 Test SkColorSpaceXformCanvas on GTX1070 bots
Bug: skia:
Change-Id: I98042ea6e7fe8b81e5f1cb38d8287a6cff394279
Reviewed-on: https://skia-review.googlesource.com/66151
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2017-11-01 16:24:30 +00:00
Mike Klein
0b78a6912e another batch of lowp stages
The 4444 image in all_bitmap_configs now draws slightly different before
and after serialization.  (It's serialized as 8888.)  Still looks fine.

Change-Id: I1396cf1550b6769a1734ed25d59bd5b1866dfacd
Reviewed-on: https://skia-review.googlesource.com/65960
Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Mike Klein <mtklein@chromium.org>
2017-11-01 12:13:37 +00:00
recipe-roller
a44b013a32 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
depot_tools:
  https://crrev.com/a0c5f0850a4c3c5a61ca84dabfb1c788d5c4b9b1 Reland "gclient runhooks: now with less spammy progress notifications" (dcheng@chromium.org)
  https://crrev.com/93c5d606cba441999c3b49b94274c8ad31b34c2f Update progress before running the hook. (dcheng@chromium.org)
  https://crrev.com/aca1d58ea1b36f977f51abe2314eb6a140bab226 [vpython] Update vpython (iannucci@chromium.org)
  https://crrev.com/e346e411d56a33575a9818310e73a66f17de3da0 depot_tools: Use armv6 for cipd's GOARCH when on armv7 host. (bpastene@chromium.org)
  https://crrev.com/83fd81f8a4eef6c8f176a7257662b18cac3e89be download_from_google_storage: Fix tests and rename (hinoka@google.com)
  https://crrev.com/bfc4082f431375a49de0a5a18fd0e6685715426f Flush stdout before squash attempt (amoylan@chromium.org)
  https://crrev.com/781e71e49fe543b1d8791750a0a6cd870ef7fdef [presubmit] Add check to call validation endpoint for config files (myjang@google.com)
  https://crrev.com/105e11e2516ce928c9efc90364b5ffba74162786 Fix help string typo. (davidben@chromium.org)
  https://crrev.com/7d1c484ecd93e94c5258dc330602ac37c5efab44 Extract bug number from branch name for git cl upload (battre@chromium.org)
  https://crrev.com/ab816ce8ff61f206ea9d3734b6736fea9fa07aa5 Fix depot_tools errors that cause runhooks to be inoperable for Cygwin (hichris123@gmail.com)
  https://crrev.com/b23d855ac1edf9d88df651c32bbaf0e8669c6cc5 Add vs_files.ciopfs to gitignore (thomasanderson@chromium.org)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I3302304c9ae12ffd8c8be062bd1cbca0e5841481
Reviewed-on: https://skia-review.googlesource.com/66020
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
2017-10-31 22:51:06 +00:00
Kevin Lubick
b018f7b79b Add Pixel 2 XL to waterfall
Bug: skia:7249
NOTRY=true
Change-Id: I877c8aa40c4529fdf7ae98b61e5742b93ce78c70
Reviewed-on: https://skia-review.googlesource.com/65821
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
2017-10-31 19:58:44 +00:00
Mike Klein
b7ea3da8cf Revert "gbr- has been brg- this whole time..."
This reverts commit 5b9a037bf4.

Reason for revert: 

I got confused in here somewhere and everything is drawing wrong.

Original change's description:
> gbr- has been brg- this whole time...
> 
> Rewrite things to make that a little clearer.
> 
> A red pixel ends up in channel 2, what would naively draw as blue
> without a rotation.  A green pixel ends up in channel 0, which would
> naively draw as red without rotation.  A blue pixel ends up in channel
> 1, which would naively draw as green without this rotation.
> 
> So this transformation is:
> 
>    r -> b
>    g -> r
>    b -> g
> 
> i.e. rgb_to_brg
> 
> Change-Id: I12331ff2622194e34a44f421f656fbe4db5d3dca
> Reviewed-on: https://skia-review.googlesource.com/65521
> Commit-Queue: Brian Osman <brianosman@google.com>
> Reviewed-by: Brian Osman <brianosman@google.com>

TBR=mtklein@chromium.org,brianosman@google.com

Change-Id: Ib29800b242bf736b20d61375d3c437c8f4ffdce0
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/65781
Reviewed-by: Mike Klein <mtklein@chromium.org>
Commit-Queue: Mike Klein <mtklein@chromium.org>
2017-10-31 17:42:16 +00:00
Mike Klein
5b9a037bf4 gbr- has been brg- this whole time...
Rewrite things to make that a little clearer.

A red pixel ends up in channel 2, what would naively draw as blue
without a rotation.  A green pixel ends up in channel 0, which would
naively draw as red without rotation.  A blue pixel ends up in channel
1, which would naively draw as green without this rotation.

So this transformation is:

   r -> b
   g -> r
   b -> g

i.e. rgb_to_brg

Change-Id: I12331ff2622194e34a44f421f656fbe4db5d3dca
Reviewed-on: https://skia-review.googlesource.com/65521
Commit-Queue: Brian Osman <brianosman@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
2017-10-31 16:43:24 +00:00
Kevin Lubick
674027a6b8 Update Pixel Cs to (actual) latest version
I chose the wrong image last time :(

Bug: skia:6176
NOTRY=true
Change-Id: I4b3d9f0d71673bc7ab15a26db52d36cbb494f9c8
Reviewed-on: https://skia-review.googlesource.com/65502
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
2017-10-31 13:51:44 +00:00
Robert Phillips
4c390b96f3 Suppress Gr*PathRendererTests on Vulkan NexusPlayer and Iris 540
Bug: skia:7244
Change-Id: Ifacb60b9c61daa8e1d96837363cba807afdc9be4
Reviewed-on: https://skia-review.googlesource.com/65122
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
2017-10-30 17:54:39 +00:00
Kevin Lubick
d2b8af1152 Update Pixel Cs to new version
Bug: skia:6176
NOTRY: true
Change-Id: Ic287556f6e4fa3bffc53e1ca0ca11cc955a4f278
Reviewed-on: https://skia-review.googlesource.com/65101
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
2017-10-30 16:20:29 +00:00
Yuqian Li
228da62fa7 Output calmbench json in nanobench format
Meanwhile, we also make the bot name more similar to the perf bot.

Bug: skia:
Change-Id: I8b0e6aa2d927aa4a0ce57606345589adb6e920b3
Reviewed-on: https://skia-review.googlesource.com/64082
Reviewed-by: Eric Boren <borenet@google.com>
Reviewed-by: Joe Gregorio <jcgregorio@google.com>
Commit-Queue: Yuqian Li <liyuqian@google.com>
2017-10-30 13:52:08 +00:00
UpdateSKPs
2d8d196318 Update SKP version
Automatic commit by the RecreateSKPs bot.

TBR=update-skps@skia.org
NO_MERGE_BUILDS

Change-Id: I93389ae509c54cce5b49126beff8b19a79166cbe
Reviewed-on: https://skia-review.googlesource.com/64960
Commit-Queue: update-skps <update-skps@skia.org>
Reviewed-by: update-skps <update-skps@skia.org>
2017-10-29 07:41:47 +00:00
Ben Wagner
d8a9dc958e Add IntelIris540 to CQ as experimental tryjob.
Bug: skia:7229
Change-Id: I99a4a8ff4bef9e3fd9a3232e6cc3d54474305714
Reviewed-on: https://skia-review.googlesource.com/64480
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2017-10-27 13:45:57 +00:00
Ben Wagner
1a2b3f0f93 Remove Nexus10 GPU jobs.
The latest OS is Lollipop, and it was originally released November 2012.
The GPU is not in the top 26 according to UMA stats (I haven't collected
data for lower than 26). We test the same GPU with the
Chromebook_303C12, and bsalomon says "Personally, I'm OK with just
relying on ChromeOS for testing."

No-Try: true
Change-Id: Ib17033153faab9d99613e7d2d069524c9435f65e
Reviewed-on: https://skia-review.googlesource.com/64066
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2017-10-26 19:58:28 +00:00
Ben Wagner
bb7e8e3072 Ignore generated README.recipes.md
No-Try: true
Change-Id: I9ecabb4e2427bf84d81d9f0f3250038e8162bea7
Reviewed-on: https://skia-review.googlesource.com/64220
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2017-10-26 18:07:27 +00:00
Ben Wagner
077710b06f Move FxAA jobs to Win2k8, Clang, GCE, 64-bit; run fewer configs.
These jobs were originally added in
https://skia-review.googlesource.com/c/skia/+/60540.

No-Try: true
Change-Id: I38677933dbb05dac8df9ea236af9a5d7b8227623
Reviewed-on: https://skia-review.googlesource.com/63742
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Yuqian Li <liyuqian@google.com>
2017-10-26 17:20:47 +00:00
Brian Osman
d52c6c27b7 Blacklist more composeshader GMs on Intel Vk
Bug: skia:
Change-Id: I16243853adb7722c41bfa6872557c3378e0bb589
Reviewed-on: https://skia-review.googlesource.com/63642
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2017-10-25 20:33:18 +00:00
Chris Dalton
4d3f20f9b3 Add full skpbench jobs for Pixel phone
Bug: skia:
Change-Id: I1b2ae213f332a3597e834e036efb8dad8df12b8b
Reviewed-on: https://skia-review.googlesource.com/63541
Commit-Queue: Chris Dalton <csmartdalton@google.com>
Reviewed-by: Kevin Lubick <kjlubick@google.com>
2017-10-25 18:51:14 +00:00
Mike Klein
f8e353d5eb oops, android_blink_rel is on a different master
Change-Id: I7407edae21c5bdc82a6db49118e78e8f8bb2b92c
Reviewed-on: https://skia-review.googlesource.com/63781
Reviewed-by: Ravi Mistry <rmistry@google.com>
2017-10-25 16:33:47 +00:00
Mike Klein
fb4d3f0fb1 make all layout test bots available as Skia trybots
c.f. https://chromium-review.googlesource.com/c/chromium/src/+/737859,
with its bots triggered by Blink's rebaseline-cl script.

Change-Id: Ic83a4cbab2da56c1195de7ba9072fe379904b2b7
Reviewed-on: https://skia-review.googlesource.com/63681
Reviewed-by: Ravi Mistry <rmistry@google.com>
2017-10-25 13:59:05 +00:00
Ben Wagner
b2fd61a058 Move most remaining ANGLE bots to Clang.
Sort job names.

Docs-Preview: https://skia.org/?cl=63080
No-Try: true
Change-Id: Ia72c055c4ddb903063b8a4be5ebd6ba92fc8b6d6
Reviewed-on: https://skia-review.googlesource.com/63080
Reviewed-by: Mike Klein <mtklein@chromium.org>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2017-10-24 18:01:21 +00:00
Yuqian Li
2ebf3d11f1 Upload calmbench results
Bug: skia:
Change-Id: I31c8a625e2b4ed30a8cf0f03035b311ca1c21f88
Reviewed-on: https://skia-review.googlesource.com/63060
Commit-Queue: Yuqian Li <liyuqian@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2017-10-24 14:19:31 +00:00
Yuqian Li
19aaabf8fd Add compiler configuration to calmbench bots
Now the calmbench bot has the same name schema as the build bots
and we're testing using Clang instead of GCC. In the future, we
may also import some configuration schemas from perf bots.

Bug: skia:
Change-Id: Idd9556cff36b749a6c9139d34f70ac50ca48fbba
Reviewed-on: https://skia-review.googlesource.com/62920
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Yuqian Li <liyuqian@google.com>
2017-10-23 17:43:19 +00:00
Mike Klein
30578893c5 add -SafeStack bots
These bots use https://clang.llvm.org/docs/SafeStack.html.

This separates the safe (constant size?) parts of the stack like return
address and some local variables apart from the unsafe over- and
underflow prone array uses.  These go on the "unsafe stack".

In theory this makes sense on {Linux,Mac}x{Debug,Release},
but let's just start with Linux/Debug.

Change-Id: I9f5cbeb7081e7d9ac8e1298ca0d86880a6085cfa
Reviewed-on: https://skia-review.googlesource.com/62743
Reviewed-by: Yuqian Li <liyuqian@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>
2017-10-23 15:32:28 +00:00
UpdateSKPs
7f1f9976da Update SKP version
Automatic commit by the RecreateSKPs bot.

TBR=update-skps@skia.org
NO_MERGE_BUILDS

Change-Id: Id778f19da2f72b70562d5827d6e42fbb8d48cf10
Reviewed-on: https://skia-review.googlesource.com/62660
Reviewed-by: update-skps <update-skps@skia.org>
Commit-Queue: update-skps <update-skps@skia.org>
2017-10-22 07:32:37 +00:00
Chris Dalton
1e6b36eb57 Add skpbench jobs for CCPR
Adds new runs that benchmark just a handful of skps with CCPR.
This will also be Pixel's small debut on skpbench.

Bug: skia:
Change-Id: I7e4c3aeaa083ffe29c275f1c021ee62d177b6172
Reviewed-on: https://skia-review.googlesource.com/62302
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Chris Dalton <csmartdalton@google.com>
2017-10-20 19:34:17 +00:00
recipe-roller
3740e8de02 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
depot_tools:
  https://crrev.com/5fd1defbcc525aa11f3eef1e5c065de3cdfc6c21 gclient runhooks: now with less spammy progress notifications (dcheng@chromium.org)
  https://crrev.com/a21b5b314bcdef9f29d9ea1325accf3920a5f937 Revert "gclient runhooks: now with less spammy progress notifications" (dcheng@chromium.org)
  https://crrev.com/3cf028ea0f2858366e0238730135bf8082d0b2f4 [bot_update] Only kick in deadline after the first try. (jchinlee@chromium.org)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Id12dbb2d6d2f8b8a15199ac56de9da5b4d6b1a1d
Reviewed-on: https://skia-review.googlesource.com/62180
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
2017-10-20 02:42:45 +00:00
Ben Wagner
3a26d2da29 Remove GTX660 from CQ.
No-Try: true
Change-Id: I47c5e122dd4521587fd7d44596b0516792cd89f5
Reviewed-on: https://skia-review.googlesource.com/61907
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2017-10-19 16:42:58 +00:00