Commit Graph

2468 Commits

Author SHA1 Message Date
Joe Gregorio
6dd3b73f1b [assets] Add CockroackDB as an asset for testing.
Change-Id: I3202bdedebb0f33968a739dd25f6dbcd7d5b4429
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/272997
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Joe Gregorio <jcgregorio@google.com>
2020-02-24 17:28:15 +00:00
Weston Tracey
cc08d9fabf Update tasks.json based on Go Deps Cl.
Merge commit 'refs/changes/95/272895/2' of https://skia.googlesource.com/skia


Update Go Deps

Change-Id: I8d56caafce1d21bd6bead373c96f57ed0c7d96a7
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/273016
Auto-Submit: Weston Tracey <westont@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
2020-02-24 16:54:15 +00:00
Ben Wagner
108a494984 Omit crashing bench on iOS Metal
Bug: skia:9799
Change-Id: I341a83b575a4e4595756c3ee055fcbc1418bc962
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/272636
Auto-Submit: Ben Wagner aka dogben <benjaminwagner@google.com>
Commit-Queue: Jim Van Verth <jvanverth@google.com>
Reviewed-by: Jim Van Verth <jvanverth@google.com>
2020-02-24 15:40:35 +00:00
Ben Wagner
998066127e Update XCode
Chromium now requires the 10.15 SDK
(https://bugs.chromium.org/p/chromium/issues/detail?id=1023913), which
breaks the CommandBuffer bot because it's trying to compile with XCode
10.3, which provides the 10.14 SDK.

What's worse, due to reasons I don't fully understand, after failing to
compile CommandBuffer due to the dependence on the 10.15 SDK, the ninja
out dir is poisoned for future compiles that don't depend on the 10.15
SDK.

Also includes a code snippet from
https://skia-review.googlesource.com/c/skia/+/264429 to find the xSAN
dylibs.

Change-Id: I3cd7661a5ea984ea6899e7a5e8cf878581538d9e
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/272736
Reviewed-by: Ben Wagner aka dogben <benjaminwagner@google.com>
2020-02-23 23:15:26 +00:00
Ben Wagner
828a7ef39d [infra] Switch iOS to updated libimobiledevice.
Bug: skia:9799
Change-Id: I94069d58bde1762ef19122605147bd75232b6ed8
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/270446
Commit-Queue: Ben Wagner aka dogben <benjaminwagner@google.com>
Reviewed-by: Weston Tracey <westont@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2020-02-21 16:21:20 +00:00
Ben Wagner
31d0dc1620 [infra] Add ios-dev-image-11.4 asset
Needed for https://skia-review.googlesource.com/c/skia/+/270446

Bug: skia:9799
Change-Id: I0b5814aa3bae73ca6c231b5ced7a0c94e0efa6dc
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/270447
Commit-Queue: Ben Wagner aka dogben <benjaminwagner@google.com>
Reviewed-by: Weston Tracey <westont@google.com>
2020-02-21 16:01:40 +00:00
Mike Klein
5f1ad0dc47 rm release swiftshader msan bots
They're not any faster than the debug ones.

Change-Id: I793706d36bd868277db2b6e39a53cb4e1075e0b1
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/271880
Auto-Submit: Mike Klein <mtklein@google.com>
Commit-Queue: Ben Wagner aka dogben <benjaminwagner@google.com>
Reviewed-by: Ben Wagner aka dogben <benjaminwagner@google.com>
2020-02-19 15:32:01 +00:00
Ben Wagner
f8b21d5913 [infra] Merge SwiftShader into CPU dimensions logic
Followup to https://skia-review.googlesource.com/c/skia/+/270838

Change-Id: I5b6146abc6f84499a1e1014610221d276254f962
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/271060
Commit-Queue: Mike Klein <mtklein@google.com>
Auto-Submit: Ben Wagner aka dogben <benjaminwagner@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
2020-02-18 15:34:15 +00:00
Ben Wagner
78b471760d [infra] fix recipe bug
We shouldn't modify self.m.vars.extra_tokens in the docker flavor.

I noticed this when doing some debugging. It doesn't seem to be causing
any problems currently.

Change-Id: I2239787f8aec8a25a6a26418c633e68840f74e04
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/271058
Commit-Queue: Eric Boren <borenet@google.com>
Auto-Submit: Ben Wagner aka dogben <benjaminwagner@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2020-02-18 12:22:05 +00:00
skia-recreate-skps
8935981317 Update SKP version
Automatic commit by the RecreateSKPs bot.

TBR=rmistry@google.com
NO_MERGE_BUILDS

Change-Id: I25a6847e397f8b20085324781c55bb86acc31665
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/271206
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
2020-02-16 12:40:49 +00:00
Ben Wagner
f88dabbb4d [infra] Move Swiftshader to MEDIUM GCE machines
Change-Id: I9d9c1ee0aacba8598869fb702436a7c6bf668323
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/270838
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Ben Wagner aka dogben <benjaminwagner@google.com>
2020-02-14 15:48:30 +00:00
Ben Wagner
1a97683ddc [infra] Pin iOS tasks to old libimobiledevice
The iPhone11 doesn't work with the old version, but our recipes don't
yet work on the new version, so I'm pinning the version in order to
stage the rollout of the new version.

Change-Id: I778c664aee7fbd33442d57d1b36607c8bc0f43e5
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/270443
Auto-Submit: Ben Wagner aka dogben <benjaminwagner@google.com>
Reviewed-by: Weston Tracey <westont@google.com>
Commit-Queue: Ben Wagner aka dogben <benjaminwagner@google.com>
2020-02-13 20:43:13 +00:00
Kevin Lubick
c499ec8227 Remove chromecast jobs
If we need to support the Ultras, I vote we use taskdrivers instead of
these old recipes.

Bug: skia:9899
Change-Id: I9a3adedde5e7b28d90d3f836ccab0c7fe40abd38
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/270440
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
2020-02-13 19:51:12 +00:00
Mike Klein
2979f95e11 more MSAN dbg->rel cycling
Remove old Debug jobs that I added Release mirrors to
earlier today.  The release jobs look fine and faster,
taking between 50-80% the time of the debug jobs.

Add SwiftShader release MSAN jobs to try the same there.

Change-Id: I2a40e079bc95edc318d4da02299273fb0dd736af
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/270537
Reviewed-by: Ben Wagner aka dogben <benjaminwagner@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
2020-02-13 16:20:19 +00:00
Mike Klein
3c3b543c7c try release MSAN jobs
Wonder if these run faster?

Change-Id: I410a77e757398172bdcb01fcaea375aa2a900883
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/270390
Auto-Submit: Mike Klein <mtklein@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
Commit-Queue: Ben Wagner aka dogben <benjaminwagner@google.com>
Reviewed-by: Ben Wagner aka dogben <benjaminwagner@google.com>
2020-02-12 16:47:05 +00:00
Mike Klein
ea81679818 remove chorizo cpu jobs
never cared about these

Bug: skia:9899
Change-Id: I1d467da491365668cbd2cb2fc606af63247b11da
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/270102
Auto-Submit: Mike Klein <mtklein@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
2020-02-11 18:16:17 +00:00
Weston Tracey
3e71209b06 [infra] Add ccache for mac default builds.
Also add pre and post build ccache stats reporting to provide insight for cache size, hit rate, etc.

Bug: skia:9887
Change-Id: I3786fb661ef9f14bdc9fcc7cbcecd1f1a588479f
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/269370
Commit-Queue: Weston Tracey <westont@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2020-02-11 13:18:36 +00:00
Eric Boren
cdf2491afa Update Go Deps
Change-Id: Icf2dde726b7f7dfd9fd3b567650d670e0fceb1bf
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/269992
Commit-Queue: Eric Boren <borenet@google.com>
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
2020-02-11 12:13:36 +00:00
Mike Klein
cb1ba160da add -O1 to debug docker builds
I've been failing to repro the attached bug locally,
but I did notice that we're missing an -O1 like we
usually add to Debug bot builds.

Bug: skia:9793, skia:9664
Change-Id: If30ccfd55bad3e49862d453a754ed9fcbed9bbde
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/269938
Auto-Submit: Mike Klein <mtklein@google.com>
Commit-Queue: Weston Tracey <westont@google.com>
Reviewed-by: Weston Tracey <westont@google.com>
2020-02-10 22:23:44 +00:00
skia-recreate-skps
be7a92c487 Update SKP version
Automatic commit by the RecreateSKPs bot.

TBR=rmistry@google.com
NO_MERGE_BUILDS

Change-Id: I16375f352411cbb5a23d4c09c6c74426914bb766
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/269658
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
2020-02-09 08:30:26 +00:00
Mike Klein
dfec731dbf build both tsan and msan libc++
std::call_once() will trigger false positive races without
a libc++ (specifically __call_once()) built with TSAN itself.

Interestingly, there's a built-in interceptor for this
use case, only on Mac: https://reviews.llvm.org/D24188.

Fixes: skia:9884
Change-Id: I7b2c031c15b78ec7302c42b4e4ac365d596c2c33
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/265567
Commit-Queue: Mike Klein <mtklein@google.com>
Reviewed-by: Ben Wagner aka dogben <benjaminwagner@google.com>
2020-02-07 21:33:03 +00:00
Weston Tracey
1b14aa25a3 [infra] Reland "Use ccache for linux default builds."
This reverts commit 5e27550437.

Reason for revert: Will be modified with fix.

Original change's description:
> Revert "Use ccache for linux default builds."
>
> This reverts commit 9f3eef796f.
>
> Reason for revert: breaking https://chromium-swarm.appspot.com/tasklist?f=sk_name%3AHousekeeper-PerCommit-CheckGeneratedFiles
>
> Original change's description:
> > Use ccache for linux default builds.
> >
> > Change-Id: I6bd2439c59f165d56f093185aba818d186b62761
> > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/268903
> > Commit-Queue: Weston Tracey <westont@google.com>
> > Reviewed-by: Ben Wagner aka dogben <benjaminwagner@google.com>
>
> TBR=benjaminwagner@google.com,westont@google.com
>
> Change-Id: I3c5a8f456d03c880a24294e61ae116bd5a1e3db8
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/269481
> Reviewed-by: Leon Scroggins <scroggo@google.com>
> Commit-Queue: Leon Scroggins <scroggo@google.com>

TBR=benjaminwagner@google.com,scroggo@google.com,westont@google.com

Change-Id: I6937e44421d8705ca80649bc7df474944d7206bb
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/269483
Commit-Queue: Weston Tracey <westont@google.com>
Reviewed-by: Weston Tracey <westont@google.com>
Reviewed-by: Ben Wagner aka dogben <benjaminwagner@google.com>
2020-02-07 20:58:23 +00:00
Leon Scroggins
5e27550437 Revert "Use ccache for linux default builds."
This reverts commit 9f3eef796f.

Reason for revert: breaking https://chromium-swarm.appspot.com/tasklist?f=sk_name%3AHousekeeper-PerCommit-CheckGeneratedFiles

Original change's description:
> Use ccache for linux default builds.
> 
> Change-Id: I6bd2439c59f165d56f093185aba818d186b62761
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/268903
> Commit-Queue: Weston Tracey <westont@google.com>
> Reviewed-by: Ben Wagner aka dogben <benjaminwagner@google.com>

TBR=benjaminwagner@google.com,westont@google.com

Change-Id: I3c5a8f456d03c880a24294e61ae116bd5a1e3db8
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/269481
Reviewed-by: Leon Scroggins <scroggo@google.com>
Commit-Queue: Leon Scroggins <scroggo@google.com>
2020-02-07 20:09:43 +00:00
Weston Tracey
9f3eef796f Use ccache for linux default builds.
Change-Id: I6bd2439c59f165d56f093185aba818d186b62761
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/268903
Commit-Queue: Weston Tracey <westont@google.com>
Reviewed-by: Ben Wagner aka dogben <benjaminwagner@google.com>
2020-02-07 16:42:28 +00:00
Weston Tracey
046f9893b9 Add ccache_mac cipd package scripts.
Change-Id: If71fc5fe27b4cf60cf963fff86d3e6a8224bf853
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/269150
Auto-Submit: Weston Tracey <westont@google.com>
Reviewed-by: Ben Wagner aka dogben <benjaminwagner@google.com>
Commit-Queue: Ben Wagner aka dogben <benjaminwagner@google.com>
2020-02-06 22:00:57 +00:00
Ravi Mistry
f6e3eaf051 Change name from skia.primary->luci.skia.skia.primary
From https://bugs.chromium.org/p/chromium/issues/detail?id=1024947#c9

Bug: chromium:1024947
Change-Id: Iad04cb1f9c6900b0c098db46d40289cd98578c03
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/268939
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
2020-02-06 13:14:21 +00:00
Weston Tracey
637c0b527c Add ccache_linux cipd package.
Change-Id: I47e2cda64404b7c0eea8d07bb2bb0d12b63d43e8
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/268839
Commit-Queue: Weston Tracey <westont@google.com>
Auto-Submit: Weston Tracey <westont@google.com>
Reviewed-by: Ben Wagner aka dogben <benjaminwagner@google.com>
2020-02-05 19:58:37 +00:00
Mike Klein
95712dd429 run .skps on PDF bots
Change-Id: Icd1795a5b1aa59ffcaaa60e3d409ea8a3a0e36da
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/268644
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
2020-02-04 17:54:31 +00:00
Jim Van Verth
b71f023957 Enable async MTLLibrary and MTLRenderPipelineState creation.
Renables the Programs test on the Metal bots.

Bug: skia:9817
Change-Id: Ie1f0b520e37793e5a45ab85a55fd3cdc5f775977
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/266572
Reviewed-by: Herb Derby <herb@google.com>
Commit-Queue: Jim Van Verth <jvanverth@google.com>
2020-01-31 16:43:30 +00:00
Mike Klein
055f5355d5 pdf rasterization
- add Mac PDF rasterizer
- create a mac pdf bot
- blacklist some GMs that CG takes forever to rasterize
- remove obsolete --dont_write pdf feature

This new Mac -PDF bot is now the _only_ bot running PDF code.
Obviously we can expand from here.

pdfium was looking like a pain to build and/or integrate
into our own build.  pdftocairo looked promising, and is
already installed on the bots, but it is very slow and
prone to error.  CG was the next thing I tried.

Change-Id: I82b04121f484e7dd78f60a648485a09218dd5279
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/267810
Commit-Queue: Mike Klein <mtklein@google.com>
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Mike Reed <reed@google.com>
2020-01-30 21:21:28 +00:00
Ravi Mistry
a5ec04d8fa Turn off failure comments from G3 bot
Too noisy.

Change-Id: I454573b92730854697147415333d1874d3c02bfa
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/267617
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
2020-01-30 15:02:27 +00:00
Robert Phillips
99044e1a6a Update wacky_yuv_formats GM to demonstrate YUV resizing on the GPU
Change-Id: Idd2b75ca84c1d7984aa983820b4325fbbda2b753
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/266203
Commit-Queue: Robert Phillips <robertphillips@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
2020-01-29 14:16:36 +00:00
Kevin Lubick
f76da63fbd [canvaskit] Update build script to support latest Emscripten
Add workaround for https://github.com/emscripten-core/emscripten/issues/10072

Note to reviewer, please check out the steps I added
in canvaskit/README.md to document this process.

Bug: skia:9816
Change-Id: Idbe7ff08ac62f4f4d70e656384831b8d24c4a684
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/266941
Reviewed-by: Eric Boren <borenet@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
2020-01-28 15:41:58 +00:00
Eric Boren
999d1d7df8 [infra] Update infra dep
I'm hoping this fixes UpdateGoDeps.

Bug: skia:9505
Change-Id: I4493f61f0257176b0e90e50bd9456041dc398a51
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/266843
Reviewed-by: Ravi Mistry <rmistry@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
2020-01-27 19:48:46 +00:00
skia-recreate-skps
f85fe13668 Update SKP version
Automatic commit by the RecreateSKPs bot.

TBR=rmistry@google.com
NO_MERGE_BUILDS

Change-Id: I1db6deb2e874e5b5c56bbcc72eec68eecae229fb
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/266714
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
2020-01-26 06:09:21 +00:00
Mike Klein
5f622d1ea8 add skvm msan bot, move asan back to linux
Leak sanitizer ought not to complain any more
now that I'm cleaning up my thread_local caches.

Add an MSAN bot for paranoia about bug.

Bug: skia:9819
Change-Id: I34600b7d40b6ecbc245d1b0acbca5b2fedf83b5d
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/266523
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
2020-01-24 15:55:22 +00:00
Mike Klein
5df511a308 link clang bots against our prepackaged libc++
This will let ASAN bots find __cxa_thread_atexit(),
letting us clean up thread_local values at thread
exit rather than having to leak them.

Change-Id: Ifd09a1efe659744bb26adf7280bb0f95722a2325
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/266529
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
2020-01-24 15:49:17 +00:00
Mike Klein
45add166fd silly hack -- move SkVM/ASAN bot to Mac
This should clear up the apparent leaks,
because Mac doesn't support leak sanitizer.

Change-Id: I688edd50265cfd15346f3fa2b8c1d06a2d3d8125
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/266368
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
2020-01-24 13:48:56 +00:00
Mike Klein
20b16bd5e1 force skvm interpreter in ASAN builds, add bots
I think this should catch the use-after-free when it runs
gm/lumafilter.  Reassuring to have running... may also want
to add MSAN bots.

Change-Id: Ia8ed9acdb66b2e5fca02d91922d01dddbd7f2207
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/266359
Commit-Queue: Mike Klein <mtklein@google.com>
Commit-Queue: Mike Reed <reed@google.com>
Auto-Submit: Mike Klein <mtklein@google.com>
Reviewed-by: Mike Reed <reed@google.com>
2020-01-23 21:44:56 +00:00
Brian Osman
22c44e7f5f Disable Programs test on MacBook10.1-Metal
Bug: skia:9817
Change-Id: I0cee480888a6e2da06d70750dbce9f98c7303516
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/266197
Reviewed-by: Jim Van Verth <jvanverth@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2020-01-23 15:12:06 +00:00
Ben Wagner
ba16336168 Reduce binary size of GCC Debug builds
Change-Id: I2643a949d21bdacc7263f30d3a8b2ff9000929fc
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/265878
Auto-Submit: Ben Wagner aka dogben <benjaminwagner@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
2020-01-23 00:08:52 +00:00
Brian Salomon
2055827845 Disable Programs test on TecnoSparkPro3 Debug test bot
Bug: skia:9814
Change-Id: I6c78ac3fdf8c4b2abb111d68801779a01ed259d3
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/265766
Auto-Submit: Brian Salomon <bsalomon@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
2020-01-22 18:53:54 +00:00
skia-recreate-skps
e8fc3ffdad Update SKP version
Automatic commit by the RecreateSKPs bot.

TBR=rmistry@google.com
NO_MERGE_BUILDS

Change-Id: I11cc80b8cf90b92b338f0f1677d5d4ec2babb054
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/265268
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
2020-01-19 08:15:00 +00:00
Chris Dalton
0f6bb8a62f Add a temporary job to test GrGpuTessellationPathRenderer
Change-Id: Id55d47c97102367face69bfaa32d82e7db4ce2e7
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/264500
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Chris Dalton <csmartdalton@google.com>
2020-01-15 19:30:55 +00:00
Mike Klein
0a0ae9ed2a manually roll swiftshader
some of the cmake flags changed names

c.f. https://swiftshader.googlesource.com/SwiftShader.git/+/f6d3cbb2830306f3ef51a72cd3f798684d107c14

Change-Id: I6f5f7d06c88035c097d7079ef93665110d15be70
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/264291
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
2020-01-14 13:22:37 +00:00
skia-recreate-skps
1ef92e079c Update SKP version
Automatic commit by the RecreateSKPs bot.

TBR=rmistry@google.com
NO_MERGE_BUILDS

Change-Id: I1e9494bc5922f76d631a200f4558357ee016267b
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/263859
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
2020-01-12 06:09:27 +00:00
Ravi Mistry
ab2c14d26d Add retries to Android compile bot for when GS returns 502s
Eg:
https://logs.chromium.org/logs/skia/48c12c1309160011/+/steps/Trigger_and_wait_for_task_on_android_compile_server/0/stdout
and
https://logs.chromium.org/logs/skia/499f3fbf91c98e11/+/steps/Trigger_and_wait_for_task_on_android_compile_server/0/stdout

Bug: skia:9770
Change-Id: I94f1b58440548f0e7f87a8d1d38eea146e5f4e52
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/263208
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
2020-01-09 21:08:44 +00:00
Ravi Mistry
04e77813f8 Revert "Prevent de-duplication of Housekeeper-PerCommit-BuildTaskDrivers"
This reverts commit 81158535ed.

Reason for revert: Hopefully not needed after https://skia-review.googlesource.com/c/skia/+/262217

Original change's description:
> Prevent de-duplication of Housekeeper-PerCommit-BuildTaskDrivers
> 
> Without this the task was getting deduped with tasks that ran days ago.
> Eg: https://chromium-swarm.appspot.com/task?d=true&id=496142b461f15f10
> 
> Bug: skia:9514
> Change-Id: I1c93e3f298ef5d6be222578618759b5fb63ca8c1
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/261555
> Reviewed-by: Ravi Mistry <rmistry@google.com>
> Commit-Queue: Ravi Mistry <rmistry@google.com>

TBR=borenet@google.com,rmistry@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: skia:9514
Change-Id: I90d2d5b52394b791dc744e12c149b31c64af3027
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/263198
Reviewed-by: Ravi Mistry <rmistry@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
2020-01-08 18:18:43 +00:00
Greg Daniel
8ec605e353 Add debug gpu abandon bots and fix yuv crash.
Change-Id: I0199aee1c164a0671c364300f9ce86bb4f7dd9ab
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/263027
Commit-Queue: Greg Daniel <egdaniel@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
Reviewed-by: Robert Phillips <robertphillips@google.com>
2020-01-08 16:57:22 +00:00
Eric Boren
fa424b2e6a [infra] Fix build_task_drivers.sh, update infra dep
build_task_drivers was always syncing infra to tip-of-tree. Fix it to
use the pinned revision.

Change-Id: Iea6c54e4f62f30e986880d50b38ee0fb612a7a83
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/262217
Commit-Queue: Eric Boren <borenet@google.com>
Reviewed-by: Ravi Mistry <rmistry@google.com>
2020-01-08 14:53:41 +00:00
Eric Boren
039afd96fd [recipes] Remove unnecessary depot_tools dependency in flavor module
Change-Id: Ic1f3896a450bd81bb8c4859d3998c9873af821f6
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/263016
Reviewed-by: Ravi Mistry <rmistry@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
2020-01-08 12:46:21 +00:00
Ben Wagner
943f9c632c Reland "Fixes for Vulkan Debug layers"
This reverts commit f01813ec5f.

Reason for revert: enabling for Debug only

Original change's description:
> Revert "Fixes for Vulkan Debug layers"
>
> This reverts commit 45ce9c7a2b.
>
> Reason for revert: causes bad perf results
>
> Original change's description:
> > Fixes for Vulkan Debug layers
> >
> > Followup to https://skia-review.googlesource.com/c/skia/+/187921. Fixes
> > the path to the layers for the updated SDK.
> >
> > Change-Id: I329b99be25bb23931963b711887da59a84bbf792
> > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/262064
> > Commit-Queue: Greg Daniel <egdaniel@google.com>
> > Auto-Submit: Ben Wagner aka dogben <benjaminwagner@google.com>
> > Reviewed-by: Greg Daniel <egdaniel@google.com>
>
> TBR=egdaniel@google.com,benjaminwagner@google.com
>
> Change-Id: I00241e8d3f03d98fcbba542bc429ebf6fd338e39
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/262934
> Reviewed-by: Ben Wagner aka dogben <benjaminwagner@google.com>
> Commit-Queue: Ben Wagner aka dogben <benjaminwagner@google.com>

Change-Id: I87ec2d21ed7ebc6af2616471d3b414d4b759954a
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/262935
Commit-Queue: Ben Wagner aka dogben <benjaminwagner@google.com>
Reviewed-by: Ben Wagner aka dogben <benjaminwagner@google.com>
Reviewed-by: Greg Daniel <egdaniel@google.com>
2020-01-07 22:08:23 +00:00
Ben Wagner aka dogben
f01813ec5f Revert "Fixes for Vulkan Debug layers"
This reverts commit 45ce9c7a2b.

Reason for revert: causes bad perf results

Original change's description:
> Fixes for Vulkan Debug layers
> 
> Followup to https://skia-review.googlesource.com/c/skia/+/187921. Fixes
> the path to the layers for the updated SDK.
> 
> Change-Id: I329b99be25bb23931963b711887da59a84bbf792
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/262064
> Commit-Queue: Greg Daniel <egdaniel@google.com>
> Auto-Submit: Ben Wagner aka dogben <benjaminwagner@google.com>
> Reviewed-by: Greg Daniel <egdaniel@google.com>

TBR=egdaniel@google.com,benjaminwagner@google.com

Change-Id: I00241e8d3f03d98fcbba542bc429ebf6fd338e39
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/262934
Reviewed-by: Ben Wagner aka dogben <benjaminwagner@google.com>
Commit-Queue: Ben Wagner aka dogben <benjaminwagner@google.com>
2020-01-07 20:29:22 +00:00
Ben Wagner
45ce9c7a2b Fixes for Vulkan Debug layers
Followup to https://skia-review.googlesource.com/c/skia/+/187921. Fixes
the path to the layers for the updated SDK.

Change-Id: I329b99be25bb23931963b711887da59a84bbf792
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/262064
Commit-Queue: Greg Daniel <egdaniel@google.com>
Auto-Submit: Ben Wagner aka dogben <benjaminwagner@google.com>
Reviewed-by: Greg Daniel <egdaniel@google.com>
2020-01-07 17:47:52 +00:00
Ben Wagner
2df621e68d Add NativeFonts job for Mac 10.15 CPU
Change-Id: Icf81d2fd50e060e9e9ca2876f5ed7192d0d18d7a
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/258885
Commit-Queue: Ben Wagner aka dogben <benjaminwagner@google.com>
Auto-Submit: Ben Wagner aka dogben <benjaminwagner@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2020-01-07 15:17:20 +00:00
Ben Wagner
8969a1641b Add missing Metal jobs
Change-Id: If571718c1f159762bf87ab41066a691505c30504
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/261186
Commit-Queue: Ben Wagner aka dogben <benjaminwagner@google.com>
Auto-Submit: Ben Wagner aka dogben <benjaminwagner@google.com>
Reviewed-by: Jim Van Verth <jvanverth@google.com>
2020-01-06 23:19:07 +00:00
Ben Wagner
6ea680581f Remove Win2016 jobs.
Change-Id: Ibba3e8f42928d19eb12ee15ca9937a043984977f
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/262224
Commit-Queue: Ravi Mistry <rmistry@google.com>
Auto-Submit: Ben Wagner aka dogben <benjaminwagner@google.com>
Reviewed-by: Ravi Mistry <rmistry@google.com>
2020-01-06 21:03:44 +00:00
Joe Gregorio
4679cb8557 Don't use CIPD_PKG_CPYTHON for P30.
Bug: skia:9602
Change-Id: Ia57b3f23502cff829879c3035c4ae37a4145a65b
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/262220
Auto-Submit: Joe Gregorio <jcgregorio@google.com>
Reviewed-by: Ravi Mistry <rmistry@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
2020-01-06 16:00:11 +00:00
skia-recreate-skps
d445e2b6fc Update SKP version
Automatic commit by the RecreateSKPs bot.

TBR=rmistry@google.com
NO_MERGE_BUILDS

Change-Id: I0a585bc7babf5e2e79a87464e4dde16fae4cd2ed
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/262237
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
2020-01-05 06:10:07 +00:00
Mike Klein
365c366b47 remove FAAA/FSAA bots
These were a backstop to catch regressions in an area of code that we're
no longer actively developing (how we choose rasterization algorithms.)

Change-Id: If0b4bf71593fc9f895a69d6aa36c86ea4f8ac141
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/261844
Commit-Queue: Mike Klein <mtklein@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
2020-01-03 20:19:57 +00:00
Mike Klein
4eef4fd854 remove redundant Debug bots that have ASAN bots
Remove any Debug bot that's not on the CQ and has a corresponding ASAN
bot (fudging it a little on one Mac bot that had a Metal-only ASAN bot.)

Change-Id: Ie82dce2c37ee1dfebb8686bb1774baaed80d8fd4
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/261842
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
2020-01-03 20:16:07 +00:00
Ben Wagner
dfde190ab0 [infra] Upgrade Win to 2019
Change-Id: I709792f697d5acc5e1c7c0df361f48d8170e2a34
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/261377
Commit-Queue: Ben Wagner aka dogben <benjaminwagner@google.com>
Reviewed-by: Ravi Mistry <rmistry@google.com>
2020-01-03 18:32:37 +00:00
Mike Klein
c22967e74f remove almost all Release ASAN bots
There's little need to run a Release ASAN bot when we've an equivalent
Debug ASAN bot.  This removes almost all Release ASAN bots and adds one
Debug ASAN bot.

The only Release ASAN bots I've kept are a bot on the CQ,
Perf-Ubuntu18-Clang-Golo-GPU-QuadroP400-x86_64-Release-All-ASAN, and the
corresponding Build bot.  We could leave that forever, replace it with
a Debug bot, or just take it off the CQ.

Change-Id: Ic0864fe2efdc39a95e204c7dfaaace238f2098ed
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/262087
Commit-Queue: Mike Klein <mtklein@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
Reviewed-by: Ben Wagner aka dogben <benjaminwagner@google.com>
2020-01-03 17:24:07 +00:00
Brian Osman
54bb838716 split CPU BonusConfigs SAN bots out explicitly
This logic that any GCE CPU *SAN bot is implicitly
a BonusConfigs bot is confusing... make it explicit.

This also means we can make BonusConfigs CPU bots
run disjoint work like the BonusConfigs GPU bots do.
No need to run the default configs redundantly.

Change-Id: I1219091f065a3d1135973bffea7c8774a8ca1ad6
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/262085
Commit-Queue: Mike Klein <mtklein@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
2020-01-03 17:21:47 +00:00
Ben Wagner
4cbf1de4ac [infra] Use POSIX paths for Docker containers
This makes the Housekeeper-PerCommit-InfraTests_Win task less broken.

Change-Id: Icd82b172dede83b69ed415fb03c3c47b54b5df5d
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/261997
Auto-Submit: Ben Wagner aka dogben <benjaminwagner@google.com>
Reviewed-by: Ravi Mistry <rmistry@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
2020-01-03 15:32:47 +00:00
Ben Wagner
7ac038f302 Move Android GPU ASAN jobs to NVIDIA_Shield.
Followup to https://skia-review.googlesource.com/c/skia/+/261933; Pixel
bots don't have enough capacity.

Change-Id: I3b3413c32170a31ba25a53cbbdc15b65b9c66f33
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/261996
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
Commit-Queue: Ben Wagner aka dogben <benjaminwagner@google.com>
Auto-Submit: Ben Wagner aka dogben <benjaminwagner@google.com>
2020-01-02 21:03:54 +00:00
Ben Wagner
1edebbac8c Add xSAN jobs for Vulkan
Change-Id: Ib77bb0e14e0957ca48817f09246042a3c38519a4
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/261277
Commit-Queue: Ben Wagner aka dogben <benjaminwagner@google.com>
Auto-Submit: Ben Wagner aka dogben <benjaminwagner@google.com>
Reviewed-by: Greg Daniel <egdaniel@google.com>
2020-01-02 20:35:18 +00:00
Mike Klein
c36a45d34d add some useful Debug/ASAN bots
We've realized we'd like to have a few more Debug Perf bots, and it
seems like maybe a good way to satisfy that is to backfill anywhere
we've got a Release Perf ASAN bot but not a Debug one.

In net, this adds:

   1) some Android ASAN Debug Build bots, both 32- and 64-bit ARM
   2) some Android ASAN Debug _Test_ bots using those new builds
   3) one CPU and one GPU Debug ASAN Perf bot

This CL originally was intended just to fulfill 3); I didn't anticipate
finding those testing gaps filled by 1) and 2), and if we find those new
bots to be a bother we can revert them.  They seemed like glaring enough
holes to try to fix now.

Change-Id: I5714522db52bb5bde458b724091a227229e55fea
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/261933
Commit-Queue: Mike Klein <mtklein@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
2020-01-02 19:38:53 +00:00
Ben Wagner
c2b6d7f50b Enable Vulkan Debug layers
Bug: skia:8709
Change-Id: Ie7033d4545df10011af1c1f207bce9ceaff829c0
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/187921
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Ben Wagner aka dogben <benjaminwagner@google.com>
Auto-Submit: Ben Wagner aka dogben <benjaminwagner@google.com>
2020-01-02 17:15:46 +00:00
Ben Wagner
b9137be12f Fix asan_device_setup path
https://skia-review.googlesource.com/c/skia/+/225483 updated only one of
two paths. Define them in the same place.

Change-Id: I6d517368f6a703d7c8cd4def6fa227a602dc0ffc
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/261289
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Auto-Submit: Ben Wagner aka dogben <benjaminwagner@google.com>
Reviewed-by: Kevin Lubick <kjlubick@google.com>
2020-01-02 14:21:46 +00:00
Ben Wagner
da11774fcc [infra] Handle failure from addr2line
An error from addr2line (e.g. unknown binary type) can truncate the
output, hiding the remainder of the stack trace. Instead print the
original line.

Change-Id: I563aae4333a79a17560378e399e79b60c79f9ac7
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/261288
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Auto-Submit: Ben Wagner aka dogben <benjaminwagner@google.com>
Reviewed-by: Kevin Lubick <kjlubick@google.com>
2020-01-02 13:16:16 +00:00
Ben Wagner
b6f98ea2c6 Enable ASAN on Windows
Docs-Preview: https://skia.org/?cl=261336
Change-Id: Ied00d717a37d92179c01158b2fbdfa47a52270c1
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/261336
Commit-Queue: Mike Klein <mtklein@google.com>
Auto-Submit: Ben Wagner aka dogben <benjaminwagner@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
2019-12-30 17:06:26 +00:00
Ben Wagner
96464fc252 Update Linux Vulkan SDK
Change-Id: I9492db5395505041ddacf659eb67c490e4437b0d
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/261287
Commit-Queue: Greg Daniel <egdaniel@google.com>
Auto-Submit: Ben Wagner aka dogben <benjaminwagner@google.com>
Reviewed-by: Greg Daniel <egdaniel@google.com>
2019-12-30 14:32:16 +00:00
skia-recreate-skps
a5dd1c74bd Update SKP version
Automatic commit by the RecreateSKPs bot.

TBR=rmistry@google.com
NO_MERGE_BUILDS

Change-Id: I466d173a1e93a05283617028be4d9d5e4fe601d5
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/261717
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
2019-12-29 06:10:44 +00:00
Chris Dalton
5a2f962313 Add back door support for GLSL tessellation shaders
Implements tessellation support at the Ganesh level, and adds back
door methods for supplying raw GLSL strings directly to the OpenGL
driver. Adds a new gm to verify tessellation is works in GL.

Change-Id: Idfc285b955cbe5e8e6bf0475be8b518b0cc6ed2c
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/261196
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Chris Dalton <csmartdalton@google.com>
2019-12-27 22:34:10 +00:00
Ravi Mistry
81158535ed Prevent de-duplication of Housekeeper-PerCommit-BuildTaskDrivers
Without this the task was getting deduped with tasks that ran days ago.
Eg: https://chromium-swarm.appspot.com/task?d=true&id=496142b461f15f10

Bug: skia:9514
Change-Id: I1c93e3f298ef5d6be222578618759b5fb63ca8c1
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/261555
Reviewed-by: Ravi Mistry <rmistry@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
2019-12-27 18:28:54 +00:00
Ravi Mistry
82462f237b Remove "-v2" from docker image names
Going to try to replace cloud build. I disabled the cloud build triggers
at https://pantheon.corp.google.com/cloud-build/triggers?project=skia-public

Bug: skia:9514
Change-Id: I6ac6e74f64fe5b1ecf33cea4b0fb7b53767b17a6
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/261548
Reviewed-by: Ravi Mistry <rmistry@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
2019-12-27 14:47:09 +00:00
Brian Osman
6a59754389 Actually update win_toolchain to 2019 (14.24.28314)
Change-Id: Ieb695288f2643a2959b76777d02af67ac49c245d
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/261544
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2019-12-26 21:59:52 +00:00
Brian Osman
f2d522a3f4 Update MSVC toolchain asset to 2019
This leaves the Win SDK at 10.0.17763.0 (I got errors when trying to
move to something newer).

It moves from VS 2017 to VS 2019 (14.16.27023), which fixes an internal
compiler error in recent ANGLE. We're also generally overdue for
switching to 2019, which has been released and stable for quite a while.

Docs-Preview: https://skia.org/?cl=261542
Change-Id: Iba15d52f558e92407866315681c2e99711c6d26a
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/261542
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2019-12-26 20:19:42 +00:00
Ravi Mistry
e19d055814 Add bots to push apps from skia/skia-wasm docker images
The DAG of tasks looks correct in trybot runs:
* PushAppsFromSkiaDockerImage : https://task-scheduler.skia.org/job/Mpjs8xzG975AtyXiqtjJ
* PushAppsFromWASMDockerImage : https://task-scheduler.skia.org/job/qrnzS6DZ764tXktCdT8U
* PushAppsFromSkiaWASMDockerImages : https://task-scheduler.skia.org/job/92nAAKGATVH141oDNtHI

Bug: skia:9514
Change-Id: I7b62a4f70e60f762844f0c5caea5607ce0826098
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/261536
Reviewed-by: Ravi Mistry <rmistry@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
2019-12-26 17:42:23 +00:00
skia-recreate-skps
ac29f1342f Update SKP version
Automatic commit by the RecreateSKPs bot.

TBR=rmistry@google.com
NO_MERGE_BUILDS

Change-Id: Ie6549664e29dcf2c8025c6112599da475c645751
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/261401
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
2019-12-22 06:10:41 +00:00
Kevin Lubick
2702dc77e0 Create code size treemaps for executable containing GL/Vulkan
DM is already available and should have GL or Vulkan backends in it.

Change-Id: Ie1dad639d0d20aae86ed8d8435c0787e15880767
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/261148
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Greg Daniel <egdaniel@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2019-12-20 15:01:16 +00:00
Ben Wagner
e6d31bd089 [infra] Use unbuffered I/O for run_recipe
This probably makes very little difference, but it might be helpful in
certain situations to see the unbuffered raw output.

Change-Id: Id0adf77ab3a8d0221d6dc8b7aea39fe9785b03dd
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/261137
Commit-Queue: Eric Boren <borenet@google.com>
Auto-Submit: Ben Wagner aka dogben <benjaminwagner@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2019-12-19 19:26:19 +00:00
Mike Klein
8fec4140f6 Reland "roll clang_win"
This is a reland of 3bf8e40537

Original change's description:
> roll clang_win
> 
> Change-Id: Ide83513b28ac982e24dcb73c9f5766df7531bc47
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/260810
> Reviewed-by: Brian Osman <brianosman@google.com>
> Commit-Queue: Mike Klein <mtklein@google.com>

Change-Id: I504db10e17e7b79284b1e222fb10a059801fedd4
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/260878
Reviewed-by: Mike Klein <mtklein@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
2019-12-18 21:03:22 +00:00
Mike Klein
4e7e6c5fe8 Revert "roll clang_win"
This reverts commit 3bf8e40537.

Reason for revert: -Werror in ANGLE.

Original change's description:
> roll clang_win
> 
> Change-Id: Ide83513b28ac982e24dcb73c9f5766df7531bc47
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/260810
> Reviewed-by: Brian Osman <brianosman@google.com>
> Commit-Queue: Mike Klein <mtklein@google.com>

TBR=mtklein@google.com,bsalomon@google.com,brianosman@google.com

Change-Id: I9215e596cd7b33944f2c1364dfedd3049a6bcbb4
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/260877
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
2019-12-18 18:45:15 +00:00
Mike Klein
3bf8e40537 roll clang_win
Change-Id: Ide83513b28ac982e24dcb73c9f5766df7531bc47
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/260810
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
2019-12-18 18:19:45 +00:00
Ravi Mistry
e6a2ad81ab Build and push skia-release and skia-wasm-release docker images
Bug: skia:9514
Change-Id: Ia76a2b233f87b4fc68010fdea8e942498b5986ed
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/260397
Reviewed-by: Joe Gregorio <jcgregorio@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
2019-12-18 13:29:55 +00:00
Robert Phillips
dd699690d0 Update SKP version (take 2)
Automatic commit by the RecreateSKPs bot.

TBR=rmistry@google.com
NO_MERGE_BUILDS

Reviewed-on: https://skia-review.googlesource.com/c/skia/+/260183
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Change-Id: I4cabaf580cfe2713128d9026762c25476e0aeafd
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/260402
Reviewed-by: Ravi Mistry <rmistry@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
2019-12-17 16:14:42 +00:00
Hal Canary
5d8b193868 fix build minimal_ios_mtl_skia_app
Change-Id: I9af324bec969a1f7feb84f8e5ea97b573c56694f
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/260396
Commit-Queue: Hal Canary <halcanary@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2019-12-16 19:44:36 +00:00
Hal Canary
efb4ed86cf SkMetalDeviceToGrContext: no longer needs any Skia headers
Also: mv experimental/skottie_ios tools/skottie_ios_app

Motivation:  make using SkMetalViewBridge that much easier for clients.

Change-Id: I985930ae0751d218e89c48c57b69d85ad7a1e703
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/259279
Reviewed-by: Hal Canary <halcanary@google.com>
Commit-Queue: Hal Canary <halcanary@google.com>
2019-12-16 18:09:40 +00:00
Eric Boren
397030ad04 Revert "Update SKP version"
This reverts commit 706eb5788e.

Reason for revert: Bad skp causing crashes

Original change's description:
> Update SKP version
> 
> Automatic commit by the RecreateSKPs bot.
> 
> TBR=rmistry@google.com
> NO_MERGE_BUILDS
> 
> Change-Id: Ic0889b3314f1d0c9853682da9de96e4fa574a7fc
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/260183
> Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
> Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>

TBR=rmistry@google.com,skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: I30cf1f796d983b8bc5171cfc1112e0b7eded8f0f
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/260256
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
2019-12-16 14:59:43 +00:00
skia-recreate-skps
706eb5788e Update SKP version
Automatic commit by the RecreateSKPs bot.

TBR=rmistry@google.com
NO_MERGE_BUILDS

Change-Id: Ic0889b3314f1d0c9853682da9de96e4fa574a7fc
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/260183
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
2019-12-15 08:12:45 +00:00
Kevin Lubick
c9b4d279d2 [infra] Update go to 1.13.5
Change-Id: I318e1a4d0cad258489ff25595cfc28b619317aac
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/259805
Reviewed-by: Ben Wagner aka dogben <benjaminwagner@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
2019-12-13 18:42:13 +00:00
Mike Klein
7c00778b20 roll clang to 9.0
Change-Id: Idd54caf1a9688a5de2fba08e8ae834f209aefc1c
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/242879
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
2019-12-11 22:35:35 +00:00
Ben Wagner
2ae348247a Update iOS provisioning profile.
Change-Id: I05172b01fb4a6baeac9a0a762537abd3fc5ad417
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/259163
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Auto-Submit: Ben Wagner aka dogben <benjaminwagner@google.com>
Reviewed-by: Kevin Lubick <kjlubick@google.com>
2019-12-11 12:54:42 +00:00
Mike Klein
1bb7e2378d test for c++17 w/ c++14 stdlib
Apparently some of our stdlibs are not even quite c++11 compliant.

Bug: skia:9700
Change-Id: I842c2dd2eba55d576aa60b2b3a4734dbace00f6b
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/259074
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
2019-12-10 22:22:30 +00:00
skia-recreate-skps
b60ec7f98b Update SKP version
Automatic commit by the RecreateSKPs bot.

TBR=rmistry@google.com
NO_MERGE_BUILDS

Change-Id: I0f920a066b8eaa15206f4257bb669630b1bba8de
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/258681
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
2019-12-08 17:04:58 +00:00
Ben Wagner
3af8955037 Add additional Mac Metal jobs
Add Perf testing for Metal on MacBookAir7,2 and MacMini7,1. Also run
Test Debug Metal on MacMini7,1.

Change-Id: Id1a457cd41dda1dee8fc6893e87a6701782b0b2e
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/258002
Commit-Queue: Jim Van Verth <jvanverth@google.com>
Auto-Submit: Ben Wagner aka dogben <benjaminwagner@google.com>
Reviewed-by: Jim Van Verth <jvanverth@google.com>
2019-12-05 16:08:42 +00:00
Eric Boren
7e9dc42228 [infra] Auto-submit the CL to update supported branch configs
Change-Id: Ib4baeec7dc7247b81c7e4a1ef7f85ef378e4be19
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/257621
Commit-Queue: Eric Boren <borenet@google.com>
Reviewed-by: Heather Miller <hcm@google.com>
Reviewed-by: Ben Wagner aka dogben <benjaminwagner@google.com>
2019-12-04 12:44:46 +00:00
Florin Malita
a4f1391bb9 Reland "[skottie] Remove defensive seek(0) from Animation ctor"
This reverts commit e0f374bf8f.

Reason for revert: including tracing fix
Original change's description:
> Revert "[skottie] Remove defensive seek(0) from Animation ctor"
>
> This reverts commit 042fe0847b.
>
> Reason for revert: SkottieTracing bots not happy.
>
> Original change's description:
> > [skottie] Remove defensive seek(0) from Animation ctor
> >
> > It potentially causes unnecessary image frame loads.
> >
> > Well-behaved clients should always seek() before calling render().
> >
> > Bug: skia:9686
> > Change-Id: If16257dc947941541d9ae8906b5ec7b1754dd7df
> > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/257625
> > Reviewed-by: Mike Reed <reed@google.com>
> > Commit-Queue: Florin Malita <fmalita@chromium.org>
>
> TBR=fmalita@chromium.org,reed@google.com,aparchur@google.com
>
> Change-Id: I3b7efdfc8e0aed1deb8756d585f946b4309d469d
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: skia:9686
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/257630
> Reviewed-by: Florin Malita <fmalita@chromium.org>
> Commit-Queue: Florin Malita <fmalita@chromium.org>

TBR=fmalita@chromium.org,reed@google.com,aparchur@google.com

Bug: skia:9686
Change-Id: Ib8a5d76821685cfa7e7dac61bcc31da5629d9055
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/257632
Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Florin Malita <fmalita@chromium.org>
2019-12-03 18:26:40 +00:00