scroggo@google.com
ccd7afb6fb
Reland 'Add path utils, plus a test for it.'
...
Build SkPathJoin and SkBasename on windows also.
Previous CL did not build on Windows because the two functions were
accidentally placed inside an ifdef that did not include windows.
Move the functions to the top of the file, and add a comment by the
endif for clarity.
Previously reviewed at https://codereview.chromium.org/15747004/
Review URL: https://codereview.chromium.org/15740024
git-svn-id: http://skia.googlecode.com/svn/trunk@9295 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-28 16:45:07 +00:00
scroggo@google.com
dbbcaa8983
Revert "Add path utils, plus a test for it."
...
This reverts commit d172374b46cae0bd5d7c024b9848f5bdafcc6a16.
This CL broke on Windows.
Review URL: https://codereview.chromium.org/15986004
git-svn-id: http://skia.googlecode.com/svn/trunk@9278 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-24 18:28:57 +00:00
scroggo@google.com
1bee037044
Add path utils, plus a test for it.
...
SkOSFile:
Added class SkOSPath with functions for
modifying strings representing path names.
OSPathTest.cpp:
Test of the new utilities.
factory.cpp:
Use SkPathJoin.
gmmain and gm_expectations:
Use SkOSPath::SkPathJoin instead of a local version.
skimage_main.cpp:
Use the new location of SkPathJoin and SkBasename.
R=epoger@google.com
Review URL: https://codereview.chromium.org/15747004
git-svn-id: http://skia.googlecode.com/svn/trunk@9277 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-24 18:12:17 +00:00
epoger@google.com
d4993ff360
GM: create GmResultDigest that encapsulates digest type ("bitmap-64bitMD5") and value (12345)
...
R=scroggo@google.com
Review URL: https://codereview.chromium.org/15883004
git-svn-id: http://skia.googlecode.com/svn/trunk@9271 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-24 14:33:28 +00:00
epoger@google.com
659c8c06cd
GM: make behavior of make_filename() more late-binding
...
This will be needed to add the option of writing out files with
checksum-based filenames.
R=scroggo@google.com
Review URL: https://codereview.chromium.org/15415003
git-svn-id: http://skia.googlecode.com/svn/trunk@9215 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-21 15:45:45 +00:00
epoger@google.com
ce057fec92
GM: include filename extension (.png) of each output file in JSON summary
...
Doing this so that, once we *do* start writing PDF checksums into the JSON
summary, we'll be able to distinguish those from the PNG checksums.
Otherwise, we could have naming collisions.
R=scroggo@google.com
Review URL: https://codereview.chromium.org/14890017
git-svn-id: http://skia.googlecode.com/svn/trunk@9119 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-14 15:17:46 +00:00
scroggo@google.com
6843bdb706
Write/compare against expectations in skimage tool.
...
skimage:
Add two new modes: one to write expectations to a json file, and
another to compare results against expectations.
Use SkPATH_SEPARATOR instead of '/'.
gm_expectations:
Split into a static library so it can be used by skimage.
Make functions non static and move function definitions into source
file.
Capitalize static member functions to follow the coding style
guidelines.
BUG=https://code.google.com/p/skia/issues/detail?id=1241
R=epoger@google.com
Review URL: https://codereview.chromium.org/14670021
git-svn-id: http://skia.googlecode.com/svn/trunk@9069 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-08 19:14:23 +00:00
epoger@google.com
366a770159
GM: now that we use MD5 instead of CityHash, the JSON should say so
...
(this should have been part of https://code.google.com/p/skia/source/detail?r=8992 )
R=bungeman@google.com
Review URL: https://codereview.chromium.org/14758003
git-svn-id: http://skia.googlecode.com/svn/trunk@9038 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-07 15:51:54 +00:00
epoger@google.com
76c913db20
GM: specify that currently used checksums are CityHashes of SkBitmaps
...
(distinct from other hash algorithms we may switch to, or hashes of
files such as PDFs that cannot be read into an SkBitmap)
Review URL: https://codereview.chromium.org/14284018
git-svn-id: http://skia.googlecode.com/svn/trunk@8877 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-04-26 15:06:44 +00:00
epoger@google.com
908f583662
rename SkBitmapChecksummer as SkBitmapHasher, and prepare for it to possibly use
...
some algorithm other than CityHash
Review URL: https://codereview.chromium.org/14170010
git-svn-id: http://skia.googlecode.com/svn/trunk@8639 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-04-12 02:23:55 +00:00
epoger@google.com
b0f8b430de
GM: remove enableMissingWarning in favor of verbose flag, and trim output in nonverbose mode
...
Review URL: https://codereview.chromium.org/14080003
git-svn-id: http://skia.googlecode.com/svn/trunk@8600 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-04-10 18:46:25 +00:00
epoger@google.com
5efdd0cb9c
gm: write all messages to stdout/stderr with "GM:" preamble to distinguish from various debug messages coming from elsewhere
...
Review URL: https://codereview.chromium.org/12691009
git-svn-id: http://skia.googlecode.com/svn/trunk@8126 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-13 14:18:40 +00:00
epoger@google.com
d271d245e9
gm: Add ability to compare against checksums (as opposed to image files)
...
Review URL: https://codereview.appspot.com/7306071
git-svn-id: http://skia.googlecode.com/svn/trunk@7724 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-02-13 18:14:48 +00:00
epoger@google.com
84a1802b07
gm: report max-pixel-error if comparing against PNG files (not checksums)
...
Review URL: https://codereview.appspot.com/7241064
git-svn-id: http://skia.googlecode.com/svn/trunk@7526 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-02-01 20:39:15 +00:00
epoger@google.com
3726960733
re-land r7258 with fixes and tests
...
BUG=http://code.google.com/p/skia/issues/detail?id=1079
TBR=reed
Review URL: https://codereview.appspot.com/7132060
git-svn-id: http://skia.googlecode.com/svn/trunk@7291 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-19 04:21:27 +00:00
epoger@google.com
9ef89ce8b7
Roll out r7258
...
BUG=http://code.google.com/p/skia/issues/detail?id=1079
TBR=robertphillips
Review URL: https://codereview.appspot.com/7138065
git-svn-id: http://skia.googlecode.com/svn/trunk@7289 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-18 21:45:42 +00:00
epoger@google.com
a243b22422
Reapply r7198 with Mac/Windows fixes
...
BUG=https://code.google.com/p/skia/issues/detail?id=1067
Review URL: https://codereview.appspot.com/7138056
git-svn-id: http://skia.googlecode.com/svn/trunk@7258 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-17 17:54:28 +00:00
epoger@google.com
bc159bdcd0
Revert r7198 until I can fix https://code.google.com/p/skia/issues/detail?id=1067
...
Review URL: https://codereview.appspot.com/7124043
git-svn-id: http://skia.googlecode.com/svn/trunk@7203 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-15 20:24:03 +00:00
epoger@google.com
06b8a19b56
gm: use new Expectations struct instead of comparison bitmaps
...
Review URL: https://codereview.appspot.com/7088044
git-svn-id: http://skia.googlecode.com/svn/trunk@7198 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-15 19:10:16 +00:00