Commit Graph

8785 Commits

Author SHA1 Message Date
reed@google.com
1c028bd395 fix state machine so we know simple only loops once, but we can call maprect in debug mode
Revert "Revert of r10943."

This reverts commit 9e83074cce521d3cc3b8b3a9b819a612a07d800a.

BUG=
R=tomhudson@google.com

Review URL: https://codereview.chromium.org/23618005

git-svn-id: http://skia.googlecode.com/svn/trunk@10981 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-28 15:23:19 +00:00
commit-bot@chromium.org
e997c26e2e ARM Skia NEON patches - 15 - Preparation work for Blitmask optims
Blitmask: copy empty factory functions to a new file

Signed-off-by: Kévin PETIT <kevin.petit@arm.com>

BUG=
R=djsollen@google.com

Author: kevin.petit.arm@gmail.com

Review URL: https://chromiumcodereview.appspot.com/21120007

git-svn-id: http://skia.googlecode.com/svn/trunk@10980 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-28 15:07:58 +00:00
commit-bot@chromium.org
515dcd3603 Replace uses of GR_DEBUG by SK_DEBUG.
BUG=None
R=bsalomon@google.com, robertphillips@google.com

Author: tfarina@chromium.org

Review URL: https://chromiumcodereview.appspot.com/23137022

git-svn-id: http://skia.googlecode.com/svn/trunk@10978 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-28 14:17:03 +00:00
scroggo@google.com
4d213ab944 Handle SkStream::rewind properly.
include/core/SkStream.h:
Update documentation to state that rewinding a stream at the beginning
should return true. This is important because our decoders fail if
rewind returns false, assuming that the stream is not at the beginning.

src/images/SkImageDecoder_libpng.cpp:
If rewind fails, call png_error.

src/images/SkImageDecoder_libwebp.cpp:
If rewind fails, report an error and return false.

src/images/SkImageRef.cpp:
If rewind fails report an error and return false.
FIXME: Need to handle flattening properly. Should I perhaps move
writeStream into SkOrderedWriteBuffer?

src/images/SkJpegUtility.cpp:
Report a jpeg error on failure to rewind.

BUG=https://b.corp.google.com/issue?id=8432093
R=bungeman@google.com, djsollen@google.com, reed@google.com

Review URL: https://codereview.chromium.org/22861028

git-svn-id: http://skia.googlecode.com/svn/trunk@10977 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-28 13:08:54 +00:00
robertphillips@google.com
d42d96f44c Missed a Nexus4 image rebaseline
git-svn-id: http://skia.googlecode.com/svn/trunk@10976 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-28 12:50:16 +00:00
robertphillips@google.com
d162092bb4 Performance trigger rebaselines of theverge on Nexus7 for r10936 (Blur refactoring)
git-svn-id: http://skia.googlecode.com/svn/trunk@10975 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-28 12:37:31 +00:00
commit-bot@chromium.org
7a1885b8ab Whitespace change to test the Commit Queue.
(SkipBuildbotRuns)

R=borenet@google.com

Author: rmistry@google.com

Review URL: https://chromiumcodereview.appspot.com/23448008

git-svn-id: http://skia.googlecode.com/svn/trunk@10974 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-28 12:36:22 +00:00
robertphillips@google.com
a99aba7d55 Remove less then useful configs from bench_pictures runs
https://codereview.chromium.org/23618004/



git-svn-id: http://skia.googlecode.com/svn/trunk@10973 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-28 12:31:49 +00:00
djsollen@google.com
50c9567912 fix issue on devices running an OS prior to 4.2 when the fallback font file was potential stored in a different location on device.
BUG=chromium:183830
R=scroggo@google.com

Review URL: https://codereview.chromium.org/23621002

git-svn-id: http://skia.googlecode.com/svn/trunk@10972 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-28 12:29:45 +00:00
scroggo@google.com
7b905ae523 Revert "Update expectations for skimage."
This reverts commit c154d36bd319baa1472189ecb212805e08f3c00b.

Reverting due to build failure in prerender.

git-svn-id: http://skia.googlecode.com/svn/trunk@10970 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-28 10:50:37 +00:00
scroggo@google.com
46ab3d052f Update expectations for skimage.
Now that expectations have moved to use the builder_name rather than
the gm_subdir (see https://code.google.com/p/skia/source/detail?r=10923),
check in a new set which uses the proper name.

Review URL: https://codereview.chromium.org/23600004

git-svn-id: http://skia.googlecode.com/svn/trunk@10969 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-28 10:26:01 +00:00
skia.committer@gmail.com
7bd141dce4 Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@10968 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-28 07:01:18 +00:00
shawnsingh@chromium.org
63bf68df05 Add performance benchmark before landing perf improvements that remove sk_bezero in SkMatrix44
BUG=skia:1558
R=jvanverth@google.com

Review URL: https://codereview.chromium.org/22872015

git-svn-id: http://skia.googlecode.com/svn/trunk@10967 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-28 05:07:26 +00:00
bungeman@google.com
7687578d3a Fix for 10963: Use mx instead of my where mx is wanted.
git-svn-id: http://skia.googlecode.com/svn/trunk@10966 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-28 03:16:02 +00:00
robertphillips@google.com
81d8dacbce Some missed tilemodes image rebaselines
git-svn-id: http://skia.googlecode.com/svn/trunk@10965 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-27 22:25:53 +00:00
robertphillips@google.com
b5cfd1f8ab Image rebaselines for Win7 x86 Debug/Nexus4 Release/Ubuntu x86 Debug and Release
git-svn-id: http://skia.googlecode.com/svn/trunk@10964 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-27 22:21:11 +00:00
bungeman@google.com
e1b9bad071 Clear unknown DirectWrite font metrics.
git-svn-id: http://skia.googlecode.com/svn/trunk@10963 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-27 21:51:37 +00:00
senorblanco@chromium.org
fbaea53366 In image filters, apply the CTM and offset to the crop rect. This is necessary to compensate for both clipping applied by the compositor (communicated via the CTM) and for cropping applied in upstream image filters (communicated via the offset). This requires a few ugly conversions, since the crop rect is an SkIRect, and the ctm is an SkMatrix.
I also had to offset the matrix passed to filter evaluation by drawSprite() and internalDrawBitmap() by the primitive position. This is the same offset that is applied when drawing the primitive, to compensate for the internal saveLayer().

Also apply the total matrix to the filter params in asNewEffect(), so that (for example) lighting params are offset by both the compositor clipping and upstream crop rects.

R=reed@google.com

Review URL: https://codereview.chromium.org/23295017

git-svn-id: http://skia.googlecode.com/svn/trunk@10961 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-27 21:37:01 +00:00
robertphillips@google.com
9d54db045b Image rebaselines for Ubuntu NoGPU x86_64
git-svn-id: http://skia.googlecode.com/svn/trunk@10960 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-27 21:34:37 +00:00
robertphillips@google.com
4d2af895db Image rebaselines for Nexus7 Release/Debug
git-svn-id: http://skia.googlecode.com/svn/trunk@10959 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-27 21:31:22 +00:00
robertphillips@google.com
276e5d1871 Image baselines for Nexus 10 Debug/Release
git-svn-id: http://skia.googlecode.com/svn/trunk@10958 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-27 21:18:50 +00:00
robertphillips@google.com
dbcc577079 Image rebaselines for Nexus S Debug/Release
git-svn-id: http://skia.googlecode.com/svn/trunk@10957 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-27 21:13:15 +00:00
robertphillips@google.com
d1f437188d Image rebaselines for Mac 10.7 x86/x86_64 Debug/Release
git-svn-id: http://skia.googlecode.com/svn/trunk@10956 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-27 21:03:01 +00:00
robertphillips@google.com
a1b44cdecf Image rebaselines for Mac10.6 x86/x86_64 Debug/Release
git-svn-id: http://skia.googlecode.com/svn/trunk@10955 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-27 20:43:50 +00:00
scroggo@google.com
57a529877e Only destroy huffman if build succeeded.
The earlier code assumed that if jpeg_create_huffman_index
succeeded but jpeg_build_huffman_index failed that the
index would still need to be destroyed. This is not the
case. Only call jpeg_destroy_huffman_index if both
succeeded.

BUG=http://b.corp.google.com/issue?id=10263847

Review URL: https://codereview.chromium.org/22859042

git-svn-id: http://skia.googlecode.com/svn/trunk@10954 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-27 20:42:22 +00:00
robertphillips@google.com
319e01f1aa Image rebaselines for Ubuntu12 x86 Debug & Release & x86_64 Debug
git-svn-id: http://skia.googlecode.com/svn/trunk@10952 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-27 20:29:57 +00:00
robertphillips@google.com
16c3ec99b7 Image rebaselines for Win7 x86 Release
git-svn-id: http://skia.googlecode.com/svn/trunk@10951 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-27 20:06:15 +00:00
robertphillips@google.com
cb1908525a Image rebaselines for Win7 x86_64 Release & Debug
git-svn-id: http://skia.googlecode.com/svn/trunk@10950 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-27 20:02:18 +00:00
robertphillips@google.com
b6c57d6693 Image baselines for Win7 x86 Release ANGLE & DirectWrite
git-svn-id: http://skia.googlecode.com/svn/trunk@10949 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-27 19:44:06 +00:00
robertphillips@google.com
b495688ada Win7 x86 Debug DirectWrite rebaselines for 10936
git-svn-id: http://skia.googlecode.com/svn/trunk@10948 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-27 19:39:03 +00:00
robertphillips@google.com
2e6a5911f9 Rebaselines for Win7 x86 Debug ANGLE
git-svn-id: http://skia.googlecode.com/svn/trunk@10946 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-27 19:31:04 +00:00
bungeman@google.com
33346487cb Fix _GDI::generateCharToGlyph to properly handle missing glyphs.
git-svn-id: http://skia.googlecode.com/svn/trunk@10945 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-27 19:05:32 +00:00
rmistry@google.com
e09d6f4819 Revert of r10943.
Review URL: https://codereview.chromium.org/23626002

git-svn-id: http://skia.googlecode.com/svn/trunk@10944 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-27 18:53:41 +00:00
reed@google.com
42cb6c0247 add SkDeviceLooper to handle larger-than-fixedpoint
BUG=

Review URL: https://codereview.chromium.org/23392006

git-svn-id: http://skia.googlecode.com/svn/trunk@10943 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-27 17:53:52 +00:00
djsollen@google.com
92e3f08c91 Fix issue when the family name is reused among multiple families.
BUG=chromium:274117
R=reed@google.com

Review URL: https://codereview.chromium.org/23592002

git-svn-id: http://skia.googlecode.com/svn/trunk@10942 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-27 17:40:03 +00:00
epoger@google.com
1c9518b09d Remove experimental/json-expectations , no longer needed.
R=scroggo@google.com

Review URL: https://codereview.chromium.org/23498007

git-svn-id: http://skia.googlecode.com/svn/trunk@10941 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-27 16:48:04 +00:00
robertphillips@google.com
b75233b7fa Fix compiler warning/error in r10936
git-svn-id: http://skia.googlecode.com/svn/trunk@10938 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-27 16:31:31 +00:00
mtklein@google.com
9f842d3904 New warning -> new pattern for fingers to learn for asserting failure.
The Ubuntu Clang compile bot has a warning enabled now that yells about !"foo"
before it breaks Chrome's build where the same warning is -Werror.

BUG=
R=reed@google.com

Review URL: https://codereview.chromium.org/23586002

git-svn-id: http://skia.googlecode.com/svn/trunk@10937 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-27 16:15:37 +00:00
robertphillips@google.com
7ce661d19c Blur refactoring
https://codereview.chromium.org/21835004/



git-svn-id: http://skia.googlecode.com/svn/trunk@10936 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-27 16:14:03 +00:00
mtklein@google.com
45891b8e37 factory can draw now too
BUG=skia:1564
R=epoger@google.com

Review URL: https://codereview.chromium.org/23607002

git-svn-id: http://skia.googlecode.com/svn/trunk@10935 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-27 16:07:48 +00:00
fmalita@google.com
d0f1a4fb28 Fix clip expansion in SkPictureRecord::recordRestoreOffsetPlaceholder()
For operations which can expand the region, zeroing previous clip ops' restore offsets is not enough: we need to also break the chain - otherwise the next restore() will simply traverse back and reset the skip offsets.

R=robertphillips@google.com

Review URL: https://codereview.chromium.org/22987003

git-svn-id: http://skia.googlecode.com/svn/trunk@10934 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-27 15:50:19 +00:00
fmalita@google.com
b9168ed432 Adding SkLumaXfermode GM results.
Review URL: https://codereview.chromium.org/23596004

git-svn-id: http://skia.googlecode.com/svn/trunk@10933 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-27 13:54:36 +00:00
mtklein@google.com
6688e18f8d Four cmykjpeg GMs that weren't done yet yesterday.
This does not fix the other failures yet.

BUG=
R=borenet@google.com

Review URL: https://codereview.chromium.org/23591002

git-svn-id: http://skia.googlecode.com/svn/trunk@10932 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-27 13:03:03 +00:00
skia.committer@gmail.com
10adca5c4a Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@10929 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-27 07:02:54 +00:00
vandebo@chromium.org
26e1449d85 [PDF] Fix printing crashes caused by font streams that don't support getMemoryBase().
An apparently recently change started putting web fonts into SkStream objects that don't support getMemoryBase().  This change uses writeStream to avoid needing to call getMemoryBase().

BUG=chromium:274440
R=bungeman@google.com

Review URL: https://codereview.chromium.org/23437004

git-svn-id: http://skia.googlecode.com/svn/trunk@10928 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-26 22:52:09 +00:00
fmalita@google.com
3b3ce3bff5 Update SkLumaMaskXfermode partial coverage handling.
Use lerp-to-dst instead of straight coverage scaling to align the behavior with
the other transfer modes.

R=reed@google.com

Review URL: https://codereview.chromium.org/23453004

git-svn-id: http://skia.googlecode.com/svn/trunk@10927 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-26 21:46:34 +00:00
reed@google.com
f272e3554a test drawing large-coord aa rects
git-svn-id: http://skia.googlecode.com/svn/trunk@10926 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-26 21:27:03 +00:00
scroggo@google.com
b9050d73f9 Remove mismatched delete.
Use SkAutoTArray to create an array and delete it safely.

BUG=https://code.google.com/p/skia/issues/detail?id=1547
R=bungeman@google.com

Review URL: https://codereview.chromium.org/23068033

git-svn-id: http://skia.googlecode.com/svn/trunk@10925 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-26 21:20:04 +00:00
mtklein@google.com
6e6dc653fc rebaseline most cmykjpeg from blank to an image
BUG=
R=borenet@google.com

Review URL: https://codereview.chromium.org/23447002

git-svn-id: http://skia.googlecode.com/svn/trunk@10924 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-26 20:40:35 +00:00
vandebo@chromium.org
ec415a8eac Revert "[PDF] Fix printing crashes caused by font streams that don't support getMemoryBase()."
This reverts commit r10918

Review URL: https://codereview.chromium.org/23351007

git-svn-id: http://skia.googlecode.com/svn/trunk@10920 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-26 18:28:55 +00:00