Commit Graph

59563 Commits

Author SHA1 Message Date
Robert Phillips
64f3f988e4 [graphite] Add structure to SkPaintParamsKey data payload
Right now this just checks the creation of the key in debug. In follow up CLs we will pass the data payload to the glue code.

The additional key structure also obviates the need for the block-specific Dump methods.

Bug: skia:12701
Change-Id: Ieddea596de92a4f6b3cf6003f33d7f01d3d28c20
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/508678
Reviewed-by: Michael Ludwig <michaelludwig@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
2022-02-23 19:07:52 +00:00
Ben Wagner
1fb32bb4cd Provide current color to all CoreText color glyphs
While `CPAL` glyphs may explicitly use the current foreground color,
`sbix` glyphs may also need the current foreground color to be correct.
If a font with an `sbix` table contains glyphs with paths but without
an entry in the `sbix` table the glyph may be drawn from the path.
However, it is not possible to know when this might occur with the
current CoreText API, so it is necessary for correctness to provide the
current foreground color for `sbix` fonts as well.

This is actually quite wasteful as it means caching `sbix` glyphs on a
per-current foreground color basis. However, usually the current
foreground color isn't changing for these fonts.

Change-Id: I1c95820d981d463fde673966b31c2c47ab2f3292
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/512147
Reviewed-by: Herb Derby <herb@google.com>
Commit-Queue: Ben Wagner <bungeman@google.com>
Auto-Submit: Ben Wagner <bungeman@google.com>
2022-02-23 19:00:50 +00:00
Harry Terkelsen
fe13e83056 Touch up CanvasKit build
Change-Id: I7ea4428787c69b4045a234403d8ca33c2aff2b7d
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/511876
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Ben Wagner <bungeman@google.com>
2022-02-23 18:58:40 +00:00
Evgenii Stepanov
3ec010334e Fix use-after-dtor in SkCanvas.
SkCanvas::fMCStack uses SkCanvas::fMCRecStorage for storage, and will
access it in the destructor. Reorder the fields so that fMCStack is destroyed
before fMCRecStorage.
Change-Id: Ie09b9b52820d2dec4b75552dc5c2349b845a01ef
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/509536
Reviewed-by: Derek Sollenberger <djsollen@google.com>
Commit-Queue: Derek Sollenberger <djsollen@google.com>
2022-02-23 18:55:52 +00:00
Herb Derby
041157848b clean up for Device::drawGlyphRunList
Clean up drawGlyphRunList suggested in a previous CL. The main
serialized strikes, and serialized Slugs is getting large. So,
I broke it up.

Change-Id: I1d116bcf3b28d95e31b4eec7666c0856cea54a48
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/512159
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Herb Derby <herb@google.com>
2022-02-23 18:55:38 +00:00
Brian Osman
fe6cca4958 Add SK_BUILD_FOR_DEBUGGER define when compiling WASM SKP debugger
Change-Id: Ib9ade4c80595716c4c2f9ef803decfe3c7726f68
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/512142
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Nathaniel Nifong <nifong@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2022-02-23 18:50:28 +00:00
skia-autoroll
a99d9671ff Roll SwiftShader from b8d7deae87a7 to 7529468c7902 (5 revisions)
https://swiftshader.googlesource.com/SwiftShader.git/+log/b8d7deae87a7..7529468c7902

2022-02-22 capn@google.com Exhaustively test the log2 implementation's conformance
2022-02-22 capn@google.com Assert exp2 is exact at integer values
2022-02-22 capn@google.com Make inc() flush subnormals to zero when DAZ is enabled
2022-02-22 sugoi@google.com Fix dynamic rendering with multiview
2022-02-22 swiftshader.regress@gmail.com Regres: Update test lists @ b8d7deae

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-skia-autoroll
Please CC erikrose@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Test-Debian10-Clang-GCE-GPU-SwiftShader-x86_64-Debug-All-SwiftShader
Bug: None
Tbr: erikrose@google.com
Change-Id: I9ea1ee5ad929bdb78cb902345c6ddeb3da4e5e5d
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/512117
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2022-02-23 18:50:25 +00:00
skia-autoroll
2146d45a11 Roll Dawn from 35faf22cf07f to bf44da52b98e (5 revisions)
https://dawn.googlesource.com/dawn.git/+log/35faf22cf07f..bf44da52b98e

2022-02-22 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Tint from 16d5739b7337 to 1fcb2a7a24ec (1 revision)
2022-02-22 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from ad48e4f3534c to c8d440b173d7 (6 revisions)
2022-02-22 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 3645f3bd40d8 to 7529468c7902 (6 revisions)
2022-02-22 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from c4494a52a20a to b80635caaac3 (5 revisions)
2022-02-22 rharrison@chromium.org Roll third_party/tint/ aa58a6934..16d5739b7 (1 commit)

Also rolling transitive DEPS:
  https://dawn.googlesource.com/tint from aa58a6934c27 to 1fcb2a7a24ec

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dawn-skia-autoroll
Please CC shrekshao@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Build-Debian10-Clang-x86_64-Debug-Dawn
Bug: None
Tbr: shrekshao@google.com
Change-Id: I65eb06d724019b5ec853e7c45c5b6def54d067e6
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/512116
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2022-02-23 18:45:11 +00:00
Jim Van Verth
8b53da2b37 Avoid catastrophic cancellation when computing det for QuadUVMatrix
With data with large values we can get into situations where clearly
degenerate quads are not giving a zero determinant, because of
errors when computing the additions and subtractions in sequence.
The solution is to compute the subtractions first, and then add them
together.

Bug: oss-fuzz:41445
Change-Id: I7febead4b020e11a137f1703b761af70c14e4e47
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/511796
Reviewed-by: Michael Ludwig <michaelludwig@google.com>
Commit-Queue: Jim Van Verth <jvanverth@google.com>
2022-02-23 18:45:08 +00:00
Matt Turner
a8689e3d4d Give a human-intelligible message if gn generates a warning
If gn generates an otherwise harmless warning, find_headers.py will fail
to parse the gn-generated JSON because gn prints both the warning and
the JSON to stdout. Though find_headers.py prints the output of gn if
JSON parsing fails, a human investigating this failure is likely to
assume that the warning they see is from the build system, not from
find_headers.py, and is not related to the failure.

For example, this warning about an argument which has no effect breaks
the build:

    WARNING at build arg file (use "gn args <out_dir>" to edit):36:36: Build argument has no effect.
    skia_skqp_global_error_tolerance = 8
                                       ^
    [...]

Change-Id: Iafa7252ba161e4def1438f5d9480b64fdaa887d2
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/510536
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2022-02-23 18:40:03 +00:00
Matt Turner
9f26069e76 [skqp] Call gpuSetup() from SkQP::evaluateGM()
gpuSetup() is responsible for calling skiagm::onGpuSetup() which is
responsible for initializing compressed images used in the following
SkQP tests:

- gl_compressed_textures
- gl_compressed_textures_nmof
- gl_compressed_textures_npot
- gles_compressed_textures
- gles_compressed_textures_nmof
- gles_compressed_textures_npot
- vk_compressed_textures
- vk_compressed_textures_nmof
- vk_compressed_textures_npot

Without this patch each of these tests crash. I suspect these tests were
broken by commit a84caa3a5f ("Make some GMs compatible with the *ooprddl
configs").

Change-Id: Iae864996b9b171084c8ceb5374765d510ff56b49
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/510056
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2022-02-23 18:40:00 +00:00
Kevin Lubick
6d26915ceb [infra] Remove windows job from CQ due to capacity issues
Change-Id: I51d3f94bcb483e6e3de6f54a2e10683b0ea6d3d0
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/512162
Reviewed-by: Robert Phillips <robertphillips@google.com>
Reviewed-by: Erik Rose <erikrose@google.com>
2022-02-23 18:39:47 +00:00
Robert Phillips
99ba004574 [graphite] Add blendMode uniform to blend/compose shader
Bug: skia:12701
Change-Id: I648948875a2e9401c0c73cdf4c9c8053c9ba69af
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/510227
Reviewed-by: Michael Ludwig <michaelludwig@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
2022-02-23 18:21:05 +00:00
John Stiles
ac374fad55 Remove unused #includes from SkSLString.
These weren't used and added complexity to the dependency graph.

Change-Id: I7e97d73d520b7123e534485d7840538d6b468c48
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/512145
Commit-Queue: John Stiles <johnstiles@google.com>
Auto-Submit: John Stiles <johnstiles@google.com>
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
2022-02-23 16:27:09 +00:00
Kevin Lubick
bf4b034027 [bazel] Show CanvasKit can be loaded in POC karma_test
In order to load CanvasKit, we need to add support for statically
served files. On the karma side, this is done by adding an
object [1] to the files list (example: [2]).

Then, we need to include canvaskit.js in with the karma test
files and use the callback to load canvaskit.wasm from the
correct file location.

[1] http://karma-runner.github.io/6.3/config/files.html
[2] 4f7b656012/modules/canvaskit/karma.conf.js (L13)
Change-Id: I7482d6e949a5e8efd0ca882efe5afbe0dc16c0e4
Bug: skia:12541
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/510736
Reviewed-by: Leandro Lovisolo <lovisolo@google.com>
2022-02-23 14:53:01 +00:00
Kevin Lubick
a2d3958e1f [bazel] Make custom karma_test rule
Run the tests in headless mode and output the logs
bazel test :hello_world --test_output=all

Start up a visible web browser with the karma test driver
(need to go to Debug tab to actually run tests)
bazel run :hello_world

Suggested review order
 - package.json to see the karma dependencies to run
   jasmine tests on chrome and firefox.
 - WORKSPACE.bazel to see how the packages listed in
   package.json and package-lock.json are downloaded
   into the Bazel sandbox/cache via the npm_install rule.
   As mentioned in the package.json comment, the version
   of build_bazel_rules_nodejs which emscripten uses [1]
   is 4.4.1 and if we tried to install it ourselves, that
   installation will be ignored. We also bring in hermetic
   browsers via io_bazel_rules_webtesting.
 - bazel/karma_test.bzl which defines a new rule _karma_test
   and a macro karma_test which joins the new rule with
   an existing web_test rule to run it on a hermetic browser
   which Bazel downloads. This rule takes heavy inspiration
   from @bazel/concatjs [2], but is much simpler and lets us
   configure more things (e.g. proxies, so we can work with
   test_on_env).
 - karma.bazel.js, which is a pretty ordinary looking karma
   configuration file [2] with effectively a JS macro
   BAZEL_APPLY_SETTINGS. JS doesn't have a preprocessor or
   actual macros, but this string will be replaced by the
   JS code in karma_test.bzl which will set correct filepaths
   for Bazel content.
 - All other files.

[1] c33c7be17f/bazel/deps.bzl (L10)
[2] 700b7a3c5f/packages/concatjs/web_test/karma_web_test.bzl (L318)
[3] http://karma-runner.github.io/6.3/config/configuration-file.html
Change-Id: Id64c0a86d6be37d627762cef0beaaf23ad390ac1
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/509717
Reviewed-by: Leandro Lovisolo <lovisolo@google.com>
2022-02-23 14:53:01 +00:00
Leon Scroggins
4ae863ba8a Revert "Reland "Add defines to skqp build""
This reverts commit 2ceed56917.

Reason for revert: Still breaking android

Original change's description:
> Reland "Add defines to skqp build"
>
> Change-Id: Ic038e6e3279eda7994cf29d886bee0d4d2e69e0b
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/511802
> Reviewed-by: Leon Scroggins <scroggo@google.com>
> Commit-Queue: Nathaniel Nifong <nifong@google.com>

Change-Id: Ic93e9e9cedac2fd7313681f44ba4e87ff1b91241
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/512156
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Leon Scroggins <scroggo@google.com>
2022-02-23 13:51:18 +00:00
Brian Osman
1e420a3652 Revert "Fix dithering on drawImage[Rect] calls"
This reverts commit 10241484aa.

Reason for revert: Speculative revert for b/220676062

Original change's description:
> Fix dithering on drawImage[Rect] calls
>
> Bug: skia:12516
> Change-Id: Ibb68558e0f474143df3c6a5fb0fb3d4881529226
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/508677
> Reviewed-by: Brian Osman <brianosman@google.com>
> Commit-Queue: Michael Ludwig <michaelludwig@google.com>

Bug: skia:12516
Change-Id: If496c6be355bbb026ffe478512f8a6334116bb66
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/511806
Commit-Queue: Brian Osman <brianosman@google.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
2022-02-22 23:17:20 +00:00
Brian Osman
fd1f1b3503 Revert "Don't dither const shaders that don't have a GP override"
This reverts commit 05a4b12dbd.

Reason for revert: Speculative fix for b/220676062

Original change's description:
> Don't dither const shaders that don't have a GP override
>
> https://gold.skia.org/detail?test=gradients_no_texture&digest=008c796df4da7fbb6718e96db2c36c90
>
> If paintFP was only non-null because it came from the main SkShader, we
> should defer to SkPaintPriv's check that the shader is not a constant.
> We don't have a isConstant() for FPs so this assumes that if the GP
> overrides it with a new FP it probably is doing something spatially
> interesting and does need the dithering.
>
> Bug: skia:12516
> Change-Id: I7935ba8f0baf91e7b7ba07280452871c60ffd3e8
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/509996
> Commit-Queue: Michael Ludwig <michaelludwig@google.com>
> Auto-Submit: Michael Ludwig <michaelludwig@google.com>
> Reviewed-by: Brian Osman <brianosman@google.com>
> Commit-Queue: Brian Osman <brianosman@google.com>

Bug: skia:12516
Change-Id: I9c45f457d42cd5890cc110617e1636ffa6669503
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/511807
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2022-02-22 23:11:40 +00:00
Nathaniel Nifong
2ceed56917 Reland "Add defines to skqp build"
Change-Id: Ic038e6e3279eda7994cf29d886bee0d4d2e69e0b
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/511802
Reviewed-by: Leon Scroggins <scroggo@google.com>
Commit-Queue: Nathaniel Nifong <nifong@google.com>
2022-02-22 22:06:12 +00:00
Arthur Eubanks
59de321c10 Add #include <algorithm> to SkTArray.h
SkTArray.h uses std::max() which is part of <algorithm>.
Some libc++ changes have stopped exporting <algorithm> from certain headers, causing skia to break with ToT libc++.

2e2f3158c6

Change-Id: Iee4e00b3b3a6cbe2c1881453d05c0658e95a767b
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/512016
Commit-Queue: Arthur Eubanks <aeubanks@google.com>
Auto-Submit: Arthur Eubanks <aeubanks@google.com>
Reviewed-by: Erik Rose <erikrose@google.com>
Commit-Queue: Erik Rose <erikrose@google.com>
Reviewed-by: Michael Ludwig <michaelludwig@google.com>
2022-02-22 21:52:15 +00:00
Greg Daniel
9608bbe95a [graphite] Initialze bound buffer tracking in render encoder.
Change-Id: I682e6cd5e02b7b43740c51caf59451da9e789a75
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/511799
Reviewed-by: Jim Van Verth <jvanverth@google.com>
Commit-Queue: Greg Daniel <egdaniel@google.com>
2022-02-22 21:23:15 +00:00
Leon Scroggins
debfdffe08 Revert "Add defines to skqp build"
This reverts commit 5637705cea.

Reason for revert: Breaking the Android roll

Original change's description:
> Add defines to skqp build
>
> Change-Id: I35f312045937ab2486084524d4ed32bc305524e3
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/510856
> Reviewed-by: Derek Sollenberger <djsollen@google.com>
> Commit-Queue: Nathaniel Nifong <nifong@google.com>

Change-Id: Ia20c56238a651df2aa758dc2c99f67c32067deb4
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/511800
Auto-Submit: Leon Scroggins <scroggo@google.com>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
2022-02-22 20:38:08 +00:00
Herb Derby
98209f67c0 additional serialize(void*, size_t) to match SkTextBlob
Add serialize(void*, size_t) to mirror the SkTextBlob serialization
methods.

Bug: chromium:1278340

Change-Id: Ie3868d882263a0ec8833d4c9404e7410d30ac6ae
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/511798
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Herb Derby <herb@google.com>
2022-02-22 19:36:40 +00:00
Herb Derby
c25fd021ed change to serialize/Deserialize API
Switch to using the public API similar to SkTextBlob for
serialize/Deserialize. Add deserializeSlug to SkStrikeClient.

Bug: chromium:1278340

Change-Id: I91b93487859c662e3bfdfba49ba4758f13529cd9
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/511601
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Herb Derby <herb@google.com>
2022-02-22 19:03:49 +00:00
Julia Lavrova
0861eaf302 Fixing getRectForRange in case with ellipsis
Bug: skia:510084
Change-Id: I49cd012676347f298cce885827546a781698ba97
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/510857
Reviewed-by: Ben Wagner <bungeman@google.com>
Commit-Queue: Julia Lavrova <jlavrova@google.com>
2022-02-22 18:43:20 +00:00
Herb Derby
5c2a0f7907 improve GrGlyphVector::MakeFromBuffer's error checking
This fixes a build bot problem. Because this is run with
--nonativeFonts, we are building a descriptor that can't be
turned into a strike. Make failure to find the strike return
an error instead of asserting.

In addition, use the proper code idiom for checking condition in
other parts of the code.

Change-Id: I3fc4051bf93e8f5308ac55bebd4218c04b5a6620
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/511797
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Herb Derby <herb@google.com>
2022-02-22 18:05:40 +00:00
Ben Wagner
da1de8fa8b Remove SK_IGNORE_FREETYPE_COLRV0_LOAD_FLAGS_FIX
All users have been updated. This flag and the code it guards can now be
removed.

Bug: skia:12956
Change-Id: I8115235fdbe12f8afa1973f43f0f2870447e5e01
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/511756
Auto-Submit: Ben Wagner <bungeman@google.com>
Reviewed-by: Dominik Röttsches <drott@google.com>
Commit-Queue: Dominik Röttsches <drott@google.com>
2022-02-22 16:35:31 +00:00
Herb Derby
4f7b656012 use TypefaceID conversion for unflattening
Use the SkStrikeClient to do the TypefaceID translation if present
when creating a GrGlyphVector.

With this change, Chromium should be able to use the
flatten/MakeFromBuffer API. Currently, this will only
serialize DirectMask (the most common type) drawing.

Other SubRun type will follow soon.

Bug: chromium:1278340

Change-Id: I08a46c7e4e13f7bd899abfdad89c5b3db2548d6a
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/511416
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Herb Derby <herb@google.com>
2022-02-22 15:53:39 +00:00
Herb Derby
fca03fe881 fix matrix use in coversion, and update test to catch it
This failure happens when using the SkRemoteGlyphCache system
*and* serializing slugs. The problem is that the origin from the
blob conversion was applied twice causing all the sub-pixel
positions to be off. This often pass because this position often
is {0, 0}.

Change-Id: I0384cfc1de5c32851381390661d1f4a8a6595ab2
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/510724
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Herb Derby <herb@google.com>
2022-02-22 15:15:43 +00:00
Nathaniel Nifong
5637705cea Add defines to skqp build
Change-Id: I35f312045937ab2486084524d4ed32bc305524e3
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/510856
Reviewed-by: Derek Sollenberger <djsollen@google.com>
Commit-Queue: Nathaniel Nifong <nifong@google.com>
2022-02-22 14:39:13 +00:00
skia-autoroll
f6ddffef16 Roll SwiftShader from d25df2a67cd2 to b8d7deae87a7 (2 revisions)
https://swiftshader.googlesource.com/SwiftShader.git/+log/d25df2a67cd2..b8d7deae87a7

2022-02-21 capn@google.com Eliminate initialization of fragment shader inputs
2022-02-21 capn@google.com Use legacy math precision for the Pipeline source set as well

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-skia-autoroll
Please CC erikrose@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Test-Debian10-Clang-GCE-GPU-SwiftShader-x86_64-Debug-All-SwiftShader
Bug: None
Tbr: erikrose@google.com
Change-Id: I77add1e6aad24038ccb991685e3e278c361d7855
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/511497
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2022-02-22 04:48:17 +00:00
skia-autoroll
8167b78589 Roll Dawn from 87cb7572eaef to 35faf22cf07f (3 revisions)
https://dawn.googlesource.com/dawn.git/+log/87cb7572eaef..35faf22cf07f

2022-02-21 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from d25df2a67cd2 to 3645f3bd40d8 (1 revision)
2022-02-21 rharrison@chromium.org tint->dawn: Shuffle tint repo layout
2022-02-21 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from de37ad1754e2 to c4494a52a20a (1 revision)

Also rolling transitive DEPS:
  https://dawn.googlesource.com/tint from 38f1e9c75c5c to aa58a6934c27

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dawn-skia-autoroll
Please CC shrekshao@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Build-Debian10-Clang-x86_64-Debug-Dawn
Bug: None
Tbr: shrekshao@google.com
Change-Id: I64de095605304b9e8e8da3ace58eca12bd3d82d4
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/511496
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2022-02-22 04:39:48 +00:00
Ben Wagner
ed0e1a8af7 Plumb FreeType glyph loading flags for COLRv0.
Previously, FreeType was always instructed to hint or autohint the layer
glyphs of COLRv0 fonts. Instead, pass the appropriate loading flags
through so that the layer glyphs will be created similarly to how the
base glyph would be handled. The behavior change is gated on
SK_IGNORE_FREETYPE_COLRV0_LOAD_FLAGS_FIX because this will require
rebaselining some Blink layout tests.

Also ensure that COLRv1 subglyphs are never hinted or autohinted for
now. These are a bit more complex and allowing hinting will need to be
handled separately.

Bug: skia:12956
Change-Id: Ia69f7a0e207b1af885ed5039f9e53007125b707e
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/510876
Reviewed-by: Ben Wagner <bungeman@google.com>
Reviewed-by: Dominik Röttsches <drott@google.com>
Commit-Queue: Ben Wagner <bungeman@google.com>
2022-02-21 22:50:43 +00:00
skia-autoroll
cd0e202767 Roll SwiftShader from b4a56a893496 to d25df2a67cd2 (5 revisions)
https://swiftshader.googlesource.com/SwiftShader.git/+log/b4a56a893496..d25df2a67cd2

2022-02-18 sugoi@google.com Implement buffer memory requirement for VK_KHR_maintenance4
2022-02-18 sugoi@google.com VK_KHR_dynamic_rendering support
2022-02-18 capn@google.com Use non-conformant transcendentals for Chromium
2022-02-18 sugoi@google.com Merge changes I3c7eb72e,Ib40d778f,I9d83501b,Idbe4c715
2022-02-18 swiftshader.regress@gmail.com Regres: Update test lists @ b4a56a89

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-skia-autoroll
Please CC erikrose@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Test-Debian10-Clang-GCE-GPU-SwiftShader-x86_64-Debug-All-SwiftShader
Bug: None
Tbr: erikrose@google.com
Change-Id: I0665ad3eb663fe00ad36b7b762723577e2deba9a
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/511278
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2022-02-21 04:55:41 +00:00
skia-autoroll
19a779987f Roll Dawn from 1220bbcbd2ed to 87cb7572eaef (15 revisions)
https://dawn.googlesource.com/dawn.git/+log/1220bbcbd2ed..87cb7572eaef

2022-02-19 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 3d75b1dc9aa9 to d25df2a67cd2 (1 revision)
2022-02-19 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from abcbeebfb58b to ad48e4f3534c (1 revision)
2022-02-19 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 78c64dd74ee5 to de37ad1754e2 (2 revisions)
2022-02-19 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Tint from d29d3d574080 to 38f1e9c75c5c (4 revisions)
2022-02-19 jiawei.shao@intel.com Add validations on the format of a resolve target
2022-02-19 bajones@chromium.org Updating names of attachment clear values
2022-02-19 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from b4a56a893496 to 3d75b1dc9aa9 (4 revisions)
2022-02-18 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from f987c40d5cc6 to abcbeebfb58b (8 revisions)
2022-02-18 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Tint from 16446e5b7437 to d29d3d574080 (2 revisions)
2022-02-18 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from b1bdce5f2feb to 78c64dd74ee5 (4 revisions)
2022-02-18 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Tint from 6f5316ba460b to 16446e5b7437 (3 revisions)
2022-02-18 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Tint from 7274b8ac19c4 to 6f5316ba460b (1 revision)
2022-02-18 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 8941bdeeafac to b4a56a893496 (2 revisions)
2022-02-18 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 671fcf732d8f to b1bdce5f2feb (5 revisions)
2022-02-18 shaobo.yan@intel.com CopyTextureForBrowser(): Validate src/dst texture state

Also rolling transitive DEPS:
  https://dawn.googlesource.com/tint from 7274b8ac19c4 to 38f1e9c75c5c

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dawn-skia-autoroll
Please CC kainino@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Build-Debian10-Clang-x86_64-Debug-Dawn
Bug: None
Tbr: kainino@google.com
Change-Id: Ifc688bab70d64aab37af56fc3d45f9b45fb5e18e
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/511277
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2022-02-21 04:40:46 +00:00
skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com
3d1667b349 Update SKP version
Automatic commit by the RecreateSKPs bot.

Change-Id: Ib875341dc8d79dde40e430386c5a86216b9b86a5
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/511017
Commit-Queue: skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Bot-Commit: skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
2022-02-20 08:13:14 +00:00
skia-autoroll
ac41af4e4c Roll SK Tool from 3de963393cc9 to f3effad886f1
https://skia.googlesource.com/buildbot.git/+log/3de963393cc9..f3effad886f1

2022-02-20 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update CIPD Packages

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/sk-tool-skia
Please CC lovisolo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Tbr: lovisolo@google.com
Change-Id: I12dac2c6fdb390f522e2af44bbfe2162b9c23dd9
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/511057
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2022-02-20 06:28:42 +00:00
Michael Ludwig
b9c27d3e7c Delete InstanceWriter in StrokeFixedCountTessellator
writePatches() just calls into PatchWriter directly now.

Change-Id: Icbdbd554f04f7a609b199a709922cb63fce5c8f0
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/502060
Reviewed-by: Christopher Dalton <csmartdalton@google.com>
Commit-Queue: Michael Ludwig <michaelludwig@google.com>
2022-02-19 01:45:10 +00:00
Ben Wagner
7ba51a1c5e Test removing table lookup from color determination.
In theory this shouldn't make a difference since copying the table
tags should be a super minimal operation (literally reading a few
bytes out of the font header). However, CoreText and CoreGraphics
work in mysterious ways and this may actually be an expensive
operation.

Bug: chromium:1297957
Bug: chromium:1297978
Change-Id: Ia640f4c7469d5d10b3243a5d0e939633a2b6ba7b
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/510719
Reviewed-by: Herb Derby <herb@google.com>
Commit-Queue: Ben Wagner <bungeman@google.com>
2022-02-18 23:41:00 +00:00
Robert Phillips
02f1bcf6d1 [graphite] Update memory handling between keybuilder and the key
This updates the key builder system so the builder can be used in a tight loop with the memory backing the key being reused.

Bug: skia:12701
Change-Id: I79a72ca26570dcfea9aa45b0fbad8e598688ee98
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/510016
Reviewed-by: Michael Ludwig <michaelludwig@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
2022-02-18 21:00:42 +00:00
Greg Daniel
7af43100d5 [graphite] Fix shader dictionary's map key equality check.
Change-Id: I3d1433fba70d5283cb76c960c2e5e7aab0b53ef5
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/510816
Reviewed-by: Michael Ludwig <michaelludwig@google.com>
Commit-Queue: Greg Daniel <egdaniel@google.com>
2022-02-18 20:25:39 +00:00
Herb Derby
fae2cc3b80 use flatten/unflattend Slugs to draw
This CL using GPU draws every TextBlob by converting it to a
Slug, flattening the Slug, unflattening the Slug to a dstSlug,
and then uses the dstSlug to draw the TextBlob.

Since only DirectMask sub runs are working I have disabled some
code to all empty sub runs. This will be restored in the final
version.

This adds a compile-time flag to control this behavior:
SK_EXPERIMENTAL_SIMULATE_DRAWGLYPHRUNLIST_WITH_SLUG_SERIALIZE

Bug: chromium:1278340

Change-Id: I7674593b0d6e1f871e1c526af76407a1977a8836
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/510419
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Herb Derby <herb@google.com>
2022-02-18 15:11:22 +00:00
Michael Ludwig
a3728924bb Reland "Use VectorXform to determine parametric segments for stroke curves"
This reverts commit 832b9ac092.

Reason for revert: Fix is in PS1->PS4

Original change's description:
> Revert "Use VectorXform to determine parametric segments for stroke curves"
>
> This reverts commit ee45d92013.
>
> Reason for revert: missed declaring PRECISION in the tessellation shader stages
>
> Original change's description:
> > Use VectorXform to determine parametric segments for stroke curves
> >
> > Change-Id: I088119d01d31d58b154e49479aa071ac68938cb4
> > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/502059
> > Reviewed-by: Jim Van Verth <jvanverth@google.com>
> > Commit-Queue: Michael Ludwig <michaelludwig@google.com>
>
> Change-Id: I2aeb6d8f2dfc403cd556d130f8a50a0cae8568cb
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/510204
> Auto-Submit: Michael Ludwig <michaelludwig@google.com>
> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>

Change-Id: I2f63ac168b8c02a8ea6e346b14089439d3bd8446
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/510205
Auto-Submit: Michael Ludwig <michaelludwig@google.com>
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
2022-02-18 15:01:45 +00:00
Heather Miller
8c2a82270e Update Skia milestone to 101
Change-Id: I78fd07c10a8dd3ff76b6040109afdf4b47b69eb0
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/510656
Reviewed-by: Heather Miller <hcm@google.com>
Auto-Submit: Heather Miller <hcm@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
2022-02-18 12:46:42 +00:00
Ben Wagner
0ec715d6cd Correct FreeType palette setup.
Use the override index as intended instead of the index into the
override list as the palette entry index to override. Correct the bounds
check on the override index. Modify an existing test to exercise this.

Bug: skia:12576
Change-Id: Ide8327ff0536eee252c6a83e997ad540a98ba957
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/510596
Auto-Submit: Ben Wagner <bungeman@google.com>
Reviewed-by: Herb Derby <herb@google.com>
Commit-Queue: Herb Derby <herb@google.com>
2022-02-18 05:08:22 +00:00
skia-autoroll
621e0f8d25 Roll SwiftShader from 4228bb95b5b5 to b4a56a893496 (4 revisions)
https://swiftshader.googlesource.com/SwiftShader.git/+log/4228bb95b5b5..b4a56a893496

2022-02-17 sergeyu@google.com [Fuchsia] Stop ignoring warnings in llvm-10.0
2022-02-17 capn@google.com Make shader inputs/outputs only statically indexable
2022-02-17 sugoi@google.com VK_EXT_inline_uniform_block implementation
2022-02-17 capn@google.com Fix rr::RoundIntClamped() for architectures other than x86 and ARM

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-skia-autoroll
Please CC fmalita@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Test-Debian10-Clang-GCE-GPU-SwiftShader-x86_64-Debug-All-SwiftShader
Bug: None
Tbr: fmalita@google.com
Change-Id: I7869076f132dff5cd6c191b7041b24bf1548d5a1
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/510338
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2022-02-18 04:51:13 +00:00
skia-autoroll
17d903e0d8 Roll Dawn from 6cc74dce933e to 1220bbcbd2ed (11 revisions)
https://dawn.googlesource.com/dawn.git/+log/6cc74dce933e..1220bbcbd2ed

2022-02-18 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Tint from 555e94e7e365 to 7274b8ac19c4 (4 revisions)
2022-02-18 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 4d9fe6bf1f0c to f987c40d5cc6 (1 revision)
2022-02-17 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 4228bb95b5b5 to 8941bdeeafac (2 revisions)
2022-02-17 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Tint from c9735450c0c2 to 555e94e7e365 (1 revision)
2022-02-17 brandon1.jones@intel.com Add Validation For External Texture Bind Group Layout Mismatch
2022-02-17 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from ae9c94f1bda1 to 671fcf732d8f (4 revisions)
2022-02-17 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Tint from afb02e8ec7cd to c9735450c0c2 (1 revision)
2022-02-17 hao.x.li@intel.com Fix QueryInternalShaderTests
2022-02-17 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 956ca5369840 to 4d9fe6bf1f0c (18 revisions)
2022-02-17 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 043a8084c1cb to 4228bb95b5b5 (3 revisions)
2022-02-17 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from afacf7f9967a to ae9c94f1bda1 (8 revisions)

Also rolling transitive DEPS:
  https://dawn.googlesource.com/tint from afb02e8ec7cd to 7274b8ac19c4

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dawn-skia-autoroll
Please CC kainino@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Build-Debian10-Clang-x86_64-Debug-Dawn
Bug: None
Tbr: kainino@google.com
Change-Id: I127251795b969410b1cf1fa284d86990f714fc61
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/510337
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2022-02-18 04:41:21 +00:00
Jim Van Verth
d49161e835 More PolyUtils fixes.
First, the convex check still had a bug when determining if we've
wrapped around more than once. If the delta between two coordinates was
0, then that doesn't trigger a sign change (as expected), but it
will get copied as the next value to check against. Instead we should
be checking against the previous non-zero value.

Second, the ActiveEdgeList for isSimple had a bug where two very large
segments were ending up with equal p0 and v values due to floating
point error. Added a check for this and we'll treat those edges as
effectively coincident.

Bug: oss-fuzz:44753
Change-Id: I84bccdf629e6173d14c040b0e6f6c997f4b48001
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/510416
Auto-Submit: Jim Van Verth <jvanverth@google.com>
Reviewed-by: Michael Ludwig <michaelludwig@google.com>
Commit-Queue: Michael Ludwig <michaelludwig@google.com>
2022-02-18 02:10:41 +00:00
Herb Derby
418fdebf1c move top-level Slug creation from buffer to GrSlug
Change-Id: Ieef75feb64614a6ece4c88deaaf147fe1ac0b311
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/510420
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Herb Derby <herb@google.com>
2022-02-17 22:26:55 +00:00