tfarina@chromium.org
658650c5b4
Remove unused methods from SkWindow.
...
I came to this while grepping for deprecated SkBitmap's eraseRGB()
method.
BUG=None
TEST=SampleApp still links
R=reed@google.com , robertphillips@google.com
Review URL: https://codereview.chromium.org/147433002
git-svn-id: http://skia.googlecode.com/svn/trunk@13184 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-25 18:45:45 +00:00
commit-bot@chromium.org
c2abd54eda
add alternative to isRect named asRect
...
This defines yunchao's proposed interface in terms of
an existing implementation.
BUG=skia:
R=reed@google.com , yunchao.he@intel.com
Author: caryclark@google.com
Review URL: https://codereview.chromium.org/140953003
git-svn-id: http://skia.googlecode.com/svn/trunk@13183 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-25 16:54:31 +00:00
reed@google.com
eb9a46cbbb
add legacy/helper allocN32Pixels, and convert gm to use it
...
This is an intermediate api, but might help us quickly get to a point where
no one is creating bitmaps in a 2-step process (setConfig + alloc).
BUG=skia:
R=halcanary@google.com
Review URL: https://codereview.chromium.org/140593005
git-svn-id: http://skia.googlecode.com/svn/trunk@13182 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-25 16:46:20 +00:00
skia.committer@gmail.com
d2ac07b64b
Sanitizing source files in Housekeeper-Nightly
...
git-svn-id: http://skia.googlecode.com/svn/trunk@13181 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-25 07:01:49 +00:00
commit-bot@chromium.org
709ca75f03
SkOnce: add option to call another cleanup function once at exit.
...
Use this to clean up empty SkData and SkPathRef.
Current leaks:
Leaked SkRefCntBase: 40
Leaked SkFlattenable: 32
Leaked SkPixelRef: 32
Leaked SkMallocPixelRef: 32
Leaked SkFontConfigInterface: 1
Leaked SkWeakRefCnt: 1
Leaked SkTypeface: 1
Leaked SkFontMgr: 1
Leaked SkDataTable: 3
Leaked SkImage: 1
Leaked ???: 1
Leaked ???: 1
BUG=skia:
R=halcanary@google.com , reed@google.com
Author: mtklein@google.com
Review URL: https://codereview.chromium.org/132803005
git-svn-id: http://skia.googlecode.com/svn/trunk@13180 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-24 22:38:39 +00:00
commit-bot@chromium.org
3a9ade7f37
Updates bench expectations; adds new platforms.
...
BUG=skia:
R=borenet@google.com , robertphillips@google.com
Author: bensong@google.com
Review URL: https://codereview.chromium.org/131343009
git-svn-id: http://skia.googlecode.com/svn/trunk@13179 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-24 21:50:03 +00:00
commit-bot@chromium.org
a8c7f7702f
fix (some) 64bit warnings -- size_t -> int
...
BUG=skia:
R=mtklein@google.com
Author: reed@google.com
Review URL: https://codereview.chromium.org/147053003
git-svn-id: http://skia.googlecode.com/svn/trunk@13178 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-24 21:46:29 +00:00
tfarina@chromium.org
8f6884aab8
Cleanup: Sanitize the order of includes under tests/
...
Initially this was to make sure Test.h appeared after the Sk*.h includes.
Patch generated by the following command line:
$ ~/chromium/src/tools/sort-headers.py tests/*.cpp
BUG=None
TEST=tests
R=robertphillips@google.com
Review URL: https://codereview.chromium.org/145313004
git-svn-id: http://skia.googlecode.com/svn/trunk@13177 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-24 20:56:26 +00:00
commit-bot@chromium.org
d8ed85101e
Turn NVPR on by default (but off in tools).
...
BUG=skia:2042
Committed: http://code.google.com/p/skia/source/detail?r=13164
R=robertphillips@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/144003006
git-svn-id: http://skia.googlecode.com/svn/trunk@13176 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-24 20:49:44 +00:00
commit-bot@chromium.org
8f22011449
Add a sample doc in markdown format.
...
BUG=skia:
R=epoger@google.com , halcanary@google.com , borenet@google.com , jcgregorio@google.com , bungeman@google.com
Author: mtklein@google.com
Review URL: https://codereview.chromium.org/146943002
git-svn-id: http://skia.googlecode.com/svn/trunk@13175 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-24 19:25:39 +00:00
reed@google.com
9ebcac5463
add installPixels
...
BUG=skia:
R=halcanary@google.com
Review URL: https://codereview.chromium.org/143073008
git-svn-id: http://skia.googlecode.com/svn/trunk@13174 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-24 18:53:42 +00:00
commit-bot@chromium.org
bde4ba2ce6
Revert of Use SkMScalar as intermediates in SkMatrix44::setConcat. ( https://codereview.chromium.org/146823002/ )
...
Reason for revert:
This will break many Chromium tests when we roll.
Original issue's description:
> Use SkMScalar as intermediates in SkMatrix44::setConcat.
>
> BUG=skia:
>
> Committed: http://code.google.com/p/skia/source/detail?r=13167
R=reed@google.com
TBR=reed@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Author: mtklein@google.com
Review URL: https://codereview.chromium.org/147033002
git-svn-id: http://skia.googlecode.com/svn/trunk@13173 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-24 18:48:00 +00:00
commit-bot@chromium.org
d1630e8fc0
new tool: download all GM images for a given builder, ready for skdiff
...
BUG=skia:1919
R=rmistry@google.com , bsalomon@google.com
Author: epoger@google.com
Review URL: https://codereview.chromium.org/143653006
git-svn-id: http://skia.googlecode.com/svn/trunk@13172 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-24 18:34:11 +00:00
commit-bot@chromium.org
227c246731
Resolve a few memory leaks in tests.
...
Purge the global scaled image cache after use in tests. The cache was
right to hold on to the pixels indefinitely, but this change makes it
easier to run down actual memory leaks.
Add SK_DECLARE_INST_COUNT to several classes.
BUG=skia:
R=reed@google.com
Author: halcanary@google.com
Review URL: https://codereview.chromium.org/145443004
git-svn-id: http://skia.googlecode.com/svn/trunk@13171 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-24 18:33:07 +00:00
commit-bot@chromium.org
dd10e0ec4c
make GM self-test run gm/rebaseline_server unittests
...
R=borenet@google.com
Author: epoger@google.com
Review URL: https://codereview.chromium.org/143983017
git-svn-id: http://skia.googlecode.com/svn/trunk@13170 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-24 18:28:35 +00:00
halcanary@google.com
68c74884d0
Revert "Turn NVPR on by default (but off in tools)."
...
This reverts commit 83d81c96de
.
Broke Windows build. Autorevert didn't work.
TBR=bsalomon@google.com ,robertphillips@google.com
NOTREECHECKS=true
NOTRY=true
NOPRESUBMIT=true
BUG=skia:2042
Review URL: https://codereview.chromium.org/146863003
git-svn-id: http://skia.googlecode.com/svn/trunk@13169 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-24 16:04:09 +00:00
senorblanco@chromium.org
0ded88d431
[Reland of r13154, since the Housekeeping bot seems to have reverted it in r13155. Next time I'll put the "do not disturb" sign on my commit.]
...
Refactor SkMorphologyImageFilter, CPU and GPU paths. This required making opts/ dependent on effects/, so that we could use the SkMorphologyProc type in SkMorphologyImageFilter.h.
Correctness and performance covered by existing tests; no change in functionality.
R=bsalomon@google.com , djsollen@google.com , reed@google.com
Committed: https://code.google.com/p/skia/source/detail?r=13154
BUG=skia:
Review URL: https://codereview.chromium.org/135013004
git-svn-id: http://skia.googlecode.com/svn/trunk@13168 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-24 15:43:50 +00:00
commit-bot@chromium.org
94ecb66c49
Use SkMScalar as intermediates in SkMatrix44::setConcat.
...
BUG=skia:
R=reed@google.com
Author: mtklein@google.com
Review URL: https://codereview.chromium.org/146823002
git-svn-id: http://skia.googlecode.com/svn/trunk@13167 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-24 15:30:46 +00:00
senorblanco@chromium.org
0903c3473c
Add new baselines for imagefiltersscaled GM.
...
TBR=borenet
Review URL: https://codereview.chromium.org/145993005
git-svn-id: http://skia.googlecode.com/svn/trunk@13166 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-24 15:02:11 +00:00
commit-bot@chromium.org
cc40f06db7
Add factory class for generating various flavors of GrTextContext.
...
This is the first pass of making Gr*TextContext more generic and easily
subclassed. The next stage will be making GrBitmapTextContext and
GrDistanceFieldTextContext more similar by moving the SkDraw loop into
each subclass.
BUG=skia:2018
Committed: http://code.google.com/p/skia/source/detail?r=13142
R=bsalomon@google.com , reed@google.com
Author: jvanverth@google.com
Review URL: https://codereview.chromium.org/144283002
git-svn-id: http://skia.googlecode.com/svn/trunk@13165 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-24 14:38:27 +00:00
commit-bot@chromium.org
83d81c96de
Turn NVPR on by default (but off in tools).
...
BUG=skia:2042
R=robertphillips@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/144003006
git-svn-id: http://skia.googlecode.com/svn/trunk@13164 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-24 14:38:13 +00:00
commit-bot@chromium.org
1c2f8c2973
modify authors file format to use python fnmatch
...
BUG=skia:2060
R=rmistry@google.com
Author: hcm@google.com
Review URL: https://codereview.chromium.org/145963002
git-svn-id: http://skia.googlecode.com/svn/trunk@13163 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-24 12:39:25 +00:00
bungeman@google.com
1b532f1231
Rebaselines for r13156.
...
There seems to be an issue where expectations are missing from storage.
Either they didn't actually upload, we pointed at the wrong one.
git-svn-id: http://skia.googlecode.com/svn/trunk@13162 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-23 23:34:38 +00:00
bungeman@google.com
3bfd12d881
Rebaselines for r13156.
...
The thing blurred in imageblur is actually text.
Who knew?
git-svn-id: http://skia.googlecode.com/svn/trunk@13161 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-23 23:25:19 +00:00
skia.committer@gmail.com
8f7ed2cfd8
Sanitizing source files in Housekeeper-Nightly
...
git-svn-id: http://skia.googlecode.com/svn/trunk@13160 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-23 22:26:04 +00:00
bungeman@google.com
5aa1116177
Rebaselines for r13156.
...
These are for affected baselines which are now failing,
but the expected image appears to be unavailable.
git-svn-id: http://skia.googlecode.com/svn/trunk@13159 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-23 22:24:41 +00:00
bungeman@google.com
5a246719a5
Rebaseline for r13156.
...
git-svn-id: http://skia.googlecode.com/svn/trunk@13158 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-23 22:19:16 +00:00
tfarina@chromium.org
b2c323a91a
Remove unused SampleTests.cpp source file.
...
We never compile this file.
BUG=None
TEST=tests
R=reed@google.com , robertphillips@google.com
Review URL: https://codereview.chromium.org/143823016
git-svn-id: http://skia.googlecode.com/svn/trunk@13157 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-23 21:30:43 +00:00
bungeman@google.com
f6f56878bc
Clarify kAutohinting is kForceAutohinting.
...
BUG=skia:2047
R=reed@google.com
Review URL: https://codereview.chromium.org/139943004
git-svn-id: http://skia.googlecode.com/svn/trunk@13156 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-23 19:01:36 +00:00
skia.committer@gmail.com
1878a44c74
Sanitizing source files in Housekeeper-Nightly
...
git-svn-id: http://skia.googlecode.com/svn/trunk@13155 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-23 18:48:56 +00:00
senorblanco@chromium.org
76d4d04b18
Refactor SkMorphologyImageFilter, CPU and GPU paths. This required making opts/ dependent on effects/, so that we could use the SkMorphologyProc type in SkMorphologyImageFilter.h.
...
Correctness and performance covered by existing tests; no change in functionality.
R=bsalomon@google.com , djsollen@google.com , reed@google.com
Review URL: https://codereview.chromium.org/135013004
git-svn-id: http://skia.googlecode.com/svn/trunk@13154 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-23 18:45:23 +00:00
commit-bot@chromium.org
9e63883725
Add a suppressions file for leak sanitizer.
...
LeakSanitizer is built into AddressSanitizer, and runs with no extra speed
penalty. Most interestingly, it's got a lock-free allocator, so it doesn't
bottleneck threaded code.
This file is enough to supress all leak warnings except from the Nvidia driver
on my desktop for tests and dm. Looks like lsan doesn't or can't pay attention
to leaked globals (-fno-common doesn't affect this).
BUG=skia:
R=robertphillips@google.com
Author: mtklein@google.com
Review URL: https://codereview.chromium.org/145033010
git-svn-id: http://skia.googlecode.com/svn/trunk@13153 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-23 18:42:31 +00:00
commit-bot@chromium.org
94da31dd3b
Upstream Android Changes from K release
...
R=scroggo@google.com
Author: djsollen@google.com
Review URL: https://codereview.chromium.org/145233002
git-svn-id: http://skia.googlecode.com/svn/trunk@13152 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-23 17:21:28 +00:00
commit-bot@chromium.org
6dda827913
add leaks flag to show unref'd insts
...
Leaks are shown optionally instead of always for tests, gm, and bench.
The current display does not show actual leaks necessarily, but
shows global objects that were not deleted when the test ended.
To enable the end-of-run leak display, pass --leaks or -l.
BUG=skia:
R=mtklein@google.com
Author: caryclark@google.com
Review URL: https://codereview.chromium.org/143943009
git-svn-id: http://skia.googlecode.com/svn/trunk@13151 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-23 17:21:19 +00:00
bungeman@google.com
4732df6941
Basic support for vector FON.
...
This change gives vector FON fonts slightly better support than bitmap
FON fonts which we already have some support for.
This also fixes the calculation of the y component of advances for
bitmap and vector FON glyphs.
git-svn-id: http://skia.googlecode.com/svn/trunk@13150 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-23 15:22:42 +00:00
commit-bot@chromium.org
fed2ab6483
No deduping dictionaries for matrices and regions.
...
There's little benefit to deduping matrices and regions: they're infrequently
used, and doubly infrequently reused. Their use-weighted byte cost is tiny.
There is some downside to deduping matrices and regions. Even when they're not
used, we prepare dictionaries for deduping them for every picture. Each of
these dictionaries costs 160 bytes, so two unused dictionaries make a big chunk
of the ~1100 bytes it takes to allocate an SkPictureRecord. (~330 come from
parent class SkCanvas, 768 from SkPictureRecord itself, here reduced to 448).
One side benefit of not deduping these guys is that the change weighs -140 lines of code.
It may go without saying, but this breaks the picture format.
Testing: out/Debug/tests && out/Debug/dm (which runs all picture modes by default)
BUG=skia:1850
R=reed@google.com , bensong@google.com , robertphillips@google.com
Author: mtklein@google.com
Review URL: https://codereview.chromium.org/143883006
git-svn-id: http://skia.googlecode.com/svn/trunk@13149 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-23 15:16:05 +00:00
commit-bot@chromium.org
09647969cf
Remove extraneous folders from includes.
...
R=reed@google.com , bsalomon@google.com , mtklein@google.com
Author: scroggo@google.com
Review URL: https://codereview.chromium.org/145203003
git-svn-id: http://skia.googlecode.com/svn/trunk@13148 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-23 14:30:21 +00:00
commit-bot@chromium.org
c896f4de12
Both gears and snow should detect if Path is available, and also report on the console if present.
...
BUG=skia:
R=robertphillips@google.com
Author: jcgregorio@google.com
Review URL: https://codereview.chromium.org/143743004
git-svn-id: http://skia.googlecode.com/svn/trunk@13147 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-23 13:53:12 +00:00
tfarina@chromium.org
5a064e3af8
Remove more unnamed namespace usages.
...
Skia prefers 'static' over 'unnamed' namespaces.
BUG=None
TEST=skgpu and tools
R=robertphillips@google.com , bsalomon@google.com
Review URL: https://codereview.chromium.org/139743010
git-svn-id: http://skia.googlecode.com/svn/trunk@13146 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-23 02:02:57 +00:00
mike@reedtribe.org
d173b87608
remove SkScalarMul macro
...
git-svn-id: http://skia.googlecode.com/svn/trunk@13145 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-23 02:02:45 +00:00
commit-bot@chromium.org
517c1e2921
Chromium Codereview Comparison Script.
...
This script takes two Codereview URLs, looks at the trybot results for
the two codereviews and compares the results.
Motivation: This should speed up the DEPS roll procedure.
BUG=skia:2039
R=robertphillips@google.com , borenet@google.com
Author: halcanary@google.com
Review URL: https://codereview.chromium.org/143503003
git-svn-id: http://skia.googlecode.com/svn/trunk@13144 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-22 22:57:19 +00:00
commit-bot@chromium.org
f1d63aa80d
Revert of Add factory class for generating various flavors of GrTextContext. ( https://codereview.chromium.org/144283002/ )
...
Reason for revert:
Breaks Chrome. Need to fix template issue.
Original issue's description:
> Add factory class for generating various flavors of GrTextContext.
>
> This is the first pass of making Gr*TextContext more generic and easily
> subclassed. The next stage will be making GrBitmapTextContext and
> GrDistanceFieldTextContext more similar by moving the SkDraw loop into
> each subclass.
>
> BUG=skia:2018
>
> Committed: http://code.google.com/p/skia/source/detail?r=13142
R=bsalomon@google.com , reed@google.com
TBR=bsalomon@google.com , reed@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:2018
Author: jvanverth@google.com
Review URL: https://codereview.chromium.org/145023006
git-svn-id: http://skia.googlecode.com/svn/trunk@13143 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-22 22:01:41 +00:00
commit-bot@chromium.org
ce96b651d3
Add factory class for generating various flavors of GrTextContext.
...
This is the first pass of making Gr*TextContext more generic and easily
subclassed. The next stage will be making GrBitmapTextContext and
GrDistanceFieldTextContext more similar by moving the SkDraw loop into
each subclass.
BUG=skia:2018
R=bsalomon@google.com , reed@google.com
Author: jvanverth@google.com
Review URL: https://codereview.chromium.org/144283002
git-svn-id: http://skia.googlecode.com/svn/trunk@13142 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-22 21:37:03 +00:00
commit-bot@chromium.org
7873333236
Remove GetGr() hack.
...
It seems no GM are using this.
BUG=None
TEST=SampleApp
R=bsalomon@google.com , caryclark@google.com
Author: tfarina@chromium.org
Review URL: https://codereview.chromium.org/144543003
git-svn-id: http://skia.googlecode.com/svn/trunk@13141 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-22 14:43:47 +00:00
commit-bot@chromium.org
566a3f1a1f
update mesa version mapping to GL version
...
mesa3d have updated to 10.0 to support OpenGL 3.3, see http://www.mesa3d.org/index.html . At least Intel has implemented mesa 10.0 on IA.
BUG=None
R=bsalomon@google.com
Author: yunchao.he@intel.com
Review URL: https://codereview.chromium.org/143803012
git-svn-id: http://skia.googlecode.com/svn/trunk@13140 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-22 14:37:08 +00:00
skia.committer@gmail.com
394c7bb04d
Sanitizing source files in Housekeeper-Nightly
...
git-svn-id: http://skia.googlecode.com/svn/trunk@13139 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-22 07:01:54 +00:00
tfarina@chromium.org
58674817a7
Remove unnamed namespace usage from tests/
...
Skia preference is to use 'static' keyword rather than use unnamed
namespace.
BUG=None
TEST=tests
R=robertphillips@google.com , bsalomon@google.com
Review URL: https://codereview.chromium.org/132403008
git-svn-id: http://skia.googlecode.com/svn/trunk@13138 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-21 23:39:22 +00:00
commit-bot@chromium.org
34f47f9e7c
Add reviewers to roll_deps.py, remove linux_heapcheck bot
...
The --reviewers and --cc are disabled for now, while we work on the workflow.
BUG=skia:
R=robertphillips@google.com
Author: halcanary@google.com
Review URL: https://codereview.chromium.org/143903005
git-svn-id: http://skia.googlecode.com/svn/trunk@13137 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-21 21:38:49 +00:00
commit-bot@chromium.org
0c95d664df
Remove a stray setReserve that causes dynamic allocation in picture creation.
...
This brings us down to about 10 calls to malloc per picture.
No measurable change in bench_record or bench_pictures.
BUG=
R=reed@google.com
Author: mtklein@google.com
Review URL: https://codereview.chromium.org/132693009
git-svn-id: http://skia.googlecode.com/svn/trunk@13136 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-21 20:48:46 +00:00
commit-bot@chromium.org
764ea79201
Rename Logan skimage expectations: .jon -> .json
...
BUG=skia:
R=scroggo@google.com
Author: borenet@google.com
Review URL: https://codereview.chromium.org/144253002
git-svn-id: http://skia.googlecode.com/svn/trunk@13135 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-21 20:03:09 +00:00