AuroraMiddleware/skia2
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
24,961 Commits 1 Branch 0 Tags 544 MiB
6686617001
Commit Graph

317 Commits

Author SHA1 Message Date
jcgregorio
106a9ff313 Add extracting GM comments to the housekeeper bot. 
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2237033002

Review-Url: https://codereview.chromium.org/2237033002
 2016-08-12 08:50:29 -07:00
rmistry
70c43efb6e Turn on SVGs for all Test bots 
BUG=skia:5628
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2240153002

Review-Url: https://codereview.chromium.org/2240153002
 2016-08-12 07:25:53 -07:00
rmistry
bcba19dd02 Use SVGs CIPD package and use SVG as a DM source. 
Currently only turned on for one bot. May turn it on for more after more conversations.

BUG=skia:5628

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2231943002

Review-Url: https://codereview.chromium.org/2231943002
 2016-08-11 12:36:58 -07:00
mtklein
18655efb7a GN: take over some exisiting bots 
As an experiment, instead of replacing these with -GN twins, take
them over in-place.  This should take over:

  -FAST
  -SKFOO

CQ_INCLUDE_TRYBOTS=master.client.skia:Perf-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-SK_USE_DISCARDABLE_SCALEDIMAGECACHE-Trybot,Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-SK_USE_DISCARDABLE_SCALEDIMAGECACHE-Trybot,Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot,Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Fast-Trybot

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2229463002

Review-Url: https://codereview.chromium.org/2229463002
 2016-08-11 07:51:53 -07:00
rmistry
d71fe83ac2 Update VERSION of "svg" asset. 
Removing the SVG due to the reason in https://docs.google.com/document/d/1kYRvUxZTnm1tI_0bTU0BX9jqSSTqPUhGXJVcD3Rcg2c/edit?disco=AAAAAqQSPSc

BUG=skia:5628
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2232003002

Review-Url: https://codereview.chromium.org/2232003002
 2016-08-10 16:36:15 -07:00
jcgregorio
9d155afef4 Package Go 1.6.2 in CIPD 
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2230853003

Review-Url: https://codereview.chromium.org/2230853003
 2016-08-10 08:44:44 -07:00
rmistry
d1cfb5bebe Add "svg" asset 
BUG=skia:5628
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2235763002

Review-Url: https://codereview.chromium.org/2235763002
 2016-08-10 07:23:51 -07:00
rmistry
5eab99183c Move ct_skps recipe from tools repo to Skia repo. 
Also move the isolate file and script from Chromium repo to the Skia repo.

BUG=skia:5620
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2221413002

Review-Url: https://codereview.chromium.org/2221413002
 2016-08-09 13:46:48 -07:00
rmistry
3df72283ee Use slave_build instead of checkout in run/api.py 
BUG=skia:5620
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2221423002

Review-Url: https://codereview.chromium.org/2221423002
 2016-08-09 11:15:57 -07:00
borenet
1413d52c53 Speculative fix for SKP partner-dir upload 
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2229433002

Review-Url: https://codereview.chromium.org/2229433002
 2016-08-08 06:26:00 -07:00
borenet
dfa55f2db4 [recipes] Smush the rest of builder_spec into appropriate places, other cleanup 
BUG=skia:5578
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2219873003

Review-Url: https://codereview.chromium.org/2219873003
 2016-08-08 04:34:01 -07:00
mtklein
03591a762c finish SkLiteDL 
- makeThreadsafe()
    - fix up some alignment problems
    - drawVertices / drawPatch
    - work around drawPicture() + default paint bugs?
    - turn on tests.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2219343002

Review-Url: https://codereview.chromium.org/2219343002
 2016-08-07 13:35:47 -07:00
update-skps
dad1aef9a8 Update SKP version 
Automatic commit by the RecreateSKPs bot.

TBR=
NO_MERGE_BUILDS
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2220833002

Review-Url: https://codereview.chromium.org/2220833002
 2016-08-07 01:52:47 -07:00
borenet
2c3112d517 [recipes] Increase test coverage 
Remove a bunch of "pragma: no cover" by removing unused code or adding test bots to cover.

BUG=skia:5578
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2215443003

Review-Url: https://codereview.chromium.org/2215443003
 2016-08-05 06:30:10 -07:00
borenet
e2251acbaa [recipes] Separate builder_spec into compile/test/perf recipes 
BUG=skia:5578
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2205473002

Review-Url: https://codereview.chromium.org/2205473002
 2016-08-05 05:40:59 -07:00
borenet
d460a3c256 [recipes] Remove build environment vars from default_env 
BUG=skia:5578
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2209423002

Review-Url: https://codereview.chromium.org/2209423002
 2016-08-05 05:18:06 -07:00
msarett
b8d1aac87a Create a separate src for colorspace tests 
This will allow me to run these tests in sRGB mode, while
leaving most of the image tests disabled.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2206953006

Review-Url: https://codereview.chromium.org/2206953006
 2016-08-04 12:22:06 -07:00
borenet
3f5a47599b [recipes] Fixes for Coverage bot 
BUG=skia:5578
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2217523002

Review-Url: https://codereview.chromium.org/2217523002
 2016-08-04 12:16:03 -07:00
borenet
c7233ef925 [recipes] Stop pretending that buildbot_spec is a step, simplify 
Since we no longer have to call out to obtain the buildbot_spec, merge
the two functions in vars API.  As a side effect, this applies
default_env to the sync steps as well, which shouldn't have an
appreciable effect on bot behavior.

BUG=skia:5578
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2209343002

Review-Url: https://codereview.chromium.org/2209343002
 2016-08-04 11:33:02 -07:00
borenet
538d5b68e8 Move builder_spec, [dm|nanobench]_flags, builder_name_schema to recipes 
- builder_name_schema becomes its own recipe module.
- builder_spec, dm, and nanobench flags move into vars module.
- recipe expectation diffs include:
  - no more buildbot_spec.py step
  - "real" dm and nanobench flags, instead of --dummy-flags
  - some inconsequential stuff in visualbench, which is removed anyway.

BUG=skia:5578
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2215803002

Review-Url: https://codereview.chromium.org/2215803002
 2016-08-04 11:07:10 -07:00
msarett
6fc699aab7 Update skimage VERSION: attempt 3 
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2211973002

Review-Url: https://codereview.chromium.org/2211973002
 2016-08-04 10:39:22 -07:00
mtklein
691b78423e Slim the CQ down to the GN bots, where they exist. 
If no one objects to my "GN bot plan" email, this unblocks us from removing
a bunch of non-GN bots.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2207073002

CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-GN-Trybot,Test-Ubuntu-GCC-ShuttleA-GPU-GTX660-x86_64-Release-GN-Trybot

Review-Url: https://codereview.chromium.org/2207073002
 2016-08-04 09:47:38 -07:00
msarett
2825bad08c Revert of Update skimage VERSION: attempt 2 (patchset #1 id:1 of https://codereview.chromium.org/2213973002/ ) 
Reason for revert:
Think this is going to break Windows again.

Original issue's description:
> Update skimage VERSION: attempt 2
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2213973002
>
> Committed: https://skia.googlesource.com/skia/+/d6dec3f4a1365d34e147234acf3c4a3629146457

TBR=borenet@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review-Url: https://codereview.chromium.org/2216523003
 2016-08-04 07:46:44 -07:00
msarett
d6dec3f4a1 Update skimage VERSION: attempt 2 
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2213973002

Review-Url: https://codereview.chromium.org/2213973002
 2016-08-04 07:29:09 -07:00
borenet
aa6a80526f Revert of Update to new skimage VERSION (patchset #1 id:1 of https://codereview.chromium.org/2211633002/ ) 
Reason for revert:
The CIPD package is broken

Original issue's description:
> Update to new skimage VERSION
> TBR=borenet@google.com
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2211633002
>
> Committed: https://skia.googlesource.com/skia/+/52d1be5ca7b1ba8cc450be7dd6377ea5bb73386a

TBR=msarett@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review-Url: https://codereview.chromium.org/2216613002
 2016-08-04 04:47:23 -07:00
msarett
52d1be5ca7 Update to new skimage VERSION 
TBR=borenet@google.com
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2211633002

Review-Url: https://codereview.chromium.org/2211633002
 2016-08-03 15:48:32 -07:00
borenet
bc20a701d8 [Recipes] Move test and perf steps into test and perf recipes 
This looks like another big change, but I really just moved blocks of code around.  Again, no expectations diffs because no behavior is changed.

BUG=skia:5578
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2198973002

Review-Url: https://codereview.chromium.org/2198973002
 2016-08-03 10:38:44 -07:00
borenet
9e3d3d8b36 Fix fake_specs.py, update recipe expectation 
BUG=skia:5578
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2200763002

Review-Url: https://codereview.chromium.org/2200763002
 2016-08-03 10:10:07 -07:00
borenet
1436a09e1f Re-organize Skia recipes 
Break Skia recipe module into:
  - skia_vars: defines and stores variables (eg. paths)
  - skia_step: utilities for running Skia steps
  - skia_flavor: flavor-specific stuff
  - skia: top-level setup, checkout, test/perf steps, etc etc

This establishes a saner dependency structure for the recipes; skia_vars
is at the bottom level, skia_step depends on it, skia_flavor depends on
both of them, skia depends on all of the above, and the recipes
themselves may depend on any or all of them.

Next steps:
  - Merge buildbot_spec into skia_vars
  - Move test_steps and perf_steps from skia recipe_module into
    swarm_test and swarm_perf recipes
  - Cleaner checkout_steps process

BUG=skia:5578
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2198173002

Review-Url: https://codereview.chromium.org/2198173002
 2016-08-03 08:23:10 -07:00
borenet
b6aafe66a0 Fix Chrome build for RecreateSKPs and CommandBuffer bots for GYP->GN 
BUG=skia:5597
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2199273002

Review-Url: https://codereview.chromium.org/2199273002
 2016-08-02 07:02:52 -07:00
borenet
ed696276fd More fixes for SwarmBucket 
BUG=skia:5581
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2202053005
NOTRY=true

Review-Url: https://codereview.chromium.org/2202053005
 2016-08-02 06:50:50 -07:00
borenet
d6dd44140d Roll recipe DEPS 
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2205863002

Review-Url: https://codereview.chromium.org/2205863002
 2016-08-02 05:11:16 -07:00
borenet
f5b675efbe Stop running nanobench on Test.*Debug bots 
We'll need to add Perf.*Debug bots to achieve the same coverage.

BUG=skia:4768
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2189393002
NOTREECHECKS=true

Review-Url: https://codereview.chromium.org/2189393002
 2016-08-01 05:08:52 -07:00
jcgregorio
01f696e30f perf: Upload results to gs://skia-perf, not gs://chromium-skia-gm. 
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2197643002

Review-Url: https://codereview.chromium.org/2197643002
 2016-07-29 10:54:30 -07:00
mtklein
f6593a68d9 Add some GN builders to the CQ. 
This parallels the set of bots we use to gate commits already.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2189283003

Review-Url: https://codereview.chromium.org/2189283003
 2016-07-29 10:41:37 -07:00
mtklein
830c913625 GN: ccache+clang needs -Qunused-arguments 
An alternative is to define CCACHE_CPP2, but
I thought I'd try this more visible way first.

(CCACHE_CPP2 may turn out to be required anyway
if we start seeing warnings about tautological compares.)

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2193203002

TBR=jcgregorio@google.com
NOTRY=true

Review-Url: https://codereview.chromium.org/2193203002
 2016-07-29 06:03:52 -07:00
mtklein
2a1134e3f5 GN: Always quote cc and cxx. 
To fix:
    ERROR at the command-line "--args":1:34: Unexpected token '+'
    is_debug=true cc=clang cxx=clang++

TBR=jcgregorio@google.com
NOTRY=true

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2193593003

Review-Url: https://codereview.chromium.org/2193593003
 2016-07-29 05:39:35 -07:00
mtklein
9081ceb123 GN: use ccache if available and the requested compiler. 
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2186553006

Review-Url: https://codereview.chromium.org/2186553006
 2016-07-29 05:07:39 -07:00
jcgregorio
50d1847815 Fix expectations for GN bot. 
BUG=skia:

Review-Url: https://codereview.chromium.org/2191933002
 2016-07-28 11:55:51 -07:00
borenet
f49d9d77bb Add swarmbucket_wrapper recipe 
BUG=skia:5581
NOTRY=true
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2185203003

Review-Url: https://codereview.chromium.org/2185203003
 2016-07-28 10:50:54 -07:00
jcgregorio
ba59595ea3 recipes: Add a GN flavor. 
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2189713003

Review-Url: https://codereview.chromium.org/2189713003
 2016-07-28 09:38:59 -07:00
borenet
9c18546b78 Fixes for SwarmBucket bot 
- Print all build properties for debugging purposes.
- Use correct path root for swarmbucket.
- Write a dummy .gclient file if missing.

BUG=skia:5581
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2190933002

Review-Url: https://codereview.chromium.org/2190933002
 2016-07-28 08:58:38 -07:00
jcgregorio
4b9ebab04d upload_bench_results - fix GS upload path. 
_UploadJSONResults does '/'.join() so the trailing / is unnecessary.

BUG=skia:
R=borenet
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2187903003

Review-Url: https://codereview.chromium.org/2187903003
 2016-07-27 14:34:06 -07:00
borenet
151aee4220 Fix silently-failing compile 
Ouch...

TBR=rmistry
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2191663002

Review-Url: https://codereview.chromium.org/2191663002
 2016-07-27 14:05:54 -07:00
kjlubick
e772aeea08 Add Vulkan runtime dll 
This gets copied into the out/ dir on compile and allows dm.exe to run anywhere, even if the Vulkan SDK is not installed.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2188543002

Review-Url: https://codereview.chromium.org/2188543002
 2016-07-27 12:59:12 -07:00
borenet
9913dfca2a Make the experimental SwarmBucket bot use the SkiaTriggers pool 
BUG=skia:5581
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2187023002

Review-Url: https://codereview.chromium.org/2187023002
 2016-07-27 12:45:35 -07:00
borenet
b53a886924 Include "revision" tag for all Swarming tasks 
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2186993002

Review-Url: https://codereview.chromium.org/2186993002
 2016-07-27 09:36:17 -07:00
borenet
7b2ed4c649 Fix Perf data upload 
BUG=skia:5563
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2187603005

Review-Url: https://codereview.chromium.org/2187603005
 2016-07-27 08:51:55 -07:00
egdaniel
735109c248 Add gyp define to enable vulkan debug layers 
On Debug vulkan bots, running with the debug layers on seems to be adding
more than an hour to the total running time. Since we suppress any output
on the bots anyways the debug layers are serving no purpose. Thus I am
adding a gyp define to disable the layers on the bot.

With this change, by default when running vulkan in Debug, the debug_layers
will be enabled. The bots should disable the layers. Android framework
should also have them disabled by default.

TBR=djsollen@google.com

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2185953003

Review-Url: https://codereview.chromium.org/2185953003
 2016-07-27 08:03:57 -07:00
borenet
c043324e56 Tweaks for the experimental SwarmBucket bot 
BUG=skia:5581
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2181073005

Review-Url: https://codereview.chromium.org/2181073005
 2016-07-27 07:02:08 -07:00
borenet
39683791cc Fix Housekeeper-PerCommit 
BUG=skia:5563
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2183023004

Review-Url: https://codereview.chromium.org/2183023004
 2016-07-27 05:21:45 -07:00
borenet
1ed2ae45f5 Move Skia recipes from build repo 
BUG=skia:5563
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2175373002

Review-Url: https://codereview.chromium.org/2175373002
 2016-07-26 11:52:17 -07:00
update-skps
5fa38fa287 Update SKP version 
Automatic commit by the RecreateSKPs bot.

TBR=
NO_MERGE_BUILDS
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2177053002

Review-Url: https://codereview.chromium.org/2177053002
 2016-07-24 01:30:17 -07:00
borenet
1543487fc6 Change SKPs to new asset management format 
BUG=skia:5427
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2169653003
DOCS_PREVIEW= https://skia.org/?cl=2169653003

Review-Url: https://codereview.chromium.org/2169653003
 2016-07-22 08:31:07 -07:00
borenet
85f0e63ca4 Add "skp" asset 
Don't get rid of SKP_VERSION and associated stuff just yet.

BUG=skia:5427
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2167763002
DOCS_PREVIEW= https://skia.org/?cl=2167763002

Review-Url: https://codereview.chromium.org/2167763002
 2016-07-21 10:27:00 -07:00
egdaniel
725266a9b1 Add vulkan compile bot to CQ 
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2166353003

Review-Url: https://codereview.chromium.org/2166353003
 2016-07-21 09:29:01 -07:00
kjlubick
f2944815e5 Add vulkan sdk to CIPD 
BUG=skia:5427
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2164953002

Review-Url: https://codereview.chromium.org/2164953002
 2016-07-20 10:18:49 -07:00
borenet
baaea531c2 Convert SK Images to new assets format 
Depends on https://codereview.chromium.org/2162563002/

BUG=skia:5427
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2155163002

Review-Url: https://codereview.chromium.org/2155163002
 2016-07-18 10:36:43 -07:00
borenet
f1120ea72c Convert Win toolchain to CIPD package 
BUG=skia:5427
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2111713003

Review-Url: https://codereview.chromium.org/2111713003
 2016-07-15 08:34:08 -07:00
skia.buildbots
d6e8e64530 Update Win toolchain 
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2116173002
NOTREECHECKS=true
NOTRY=true
TBR=rmistry@google.com

Review-Url: https://codereview.chromium.org/2116173002
 2016-07-01 17:29:18 -07:00
benjaminwagner
ab2b52e286 Specify new Windows Toolchain isolated hash. 
NOTREECHECKS=true
NOTRY=true
TBR=rmistry@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2121443002

Review-Url: https://codereview.chromium.org/2121443002
 2016-07-01 15:51:41 -07:00
borenet
501ca7f538 Add Android SDK asset 
This will allow us to use CIPD to install the Android SDK on bots.

BUG=skia:5427
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2086003002

Review-Url: https://codereview.chromium.org/2086003002
 2016-06-30 05:20:03 -07:00
rmistry
0829e49af2 Add blacklist for the Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-CT_IMG_DECODE_100k_SKPs bot 
BUG=skia:5462
BUG=skia:5466
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2101403003

# Try bots do not run this code.
NOTRY=true

Review-Url: https://codereview.chromium.org/2101403003
 2016-06-28 10:17:03 -07:00
borenet
f9bd9da14a Add CIPD support for bot assets 
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2085473002

Review-Url: https://codereview.chromium.org/2085473002
 2016-06-28 04:41:49 -07:00
tandrii
23e9f7c501 Make bucket names explicit in cq.cfg. 
Don't assume bucket name to start with 'master.'.

NOTRY=True
BUG=chromium:617627
R=rmistry@google.com,sergiyb@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2096733005

Review-Url: https://codereview.chromium.org/2096733005
 2016-06-24 11:27:29 -07:00
rmistry
9afccaaf8e Reland of add a Chrome builder to the CQ (patchset #1 id:1 of https://codereview.chromium.org/2087913003/ ) 
Reason for revert:
Will watch this after it is in.

Original issue's description:
> Revert of add a Chrome builder to the CQ (patchset #1 id:1 of https://codereview.chromium.org/2085333002/ )
>
> Reason for revert:
> Reverting due to purple trybots in https://codereview.chromium.org/2087343002/
>
> We will have to investigate..
>
> Original issue's description:
> > add a Chrome builder to the CQ
> >
> > This appears to be the fastest Chrome builder, averaging 8-9 minutes.
> >
> > BUG=skia:
> > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2085333002
> >
> > Committed: https://skia.googlesource.com/skia/+/cb4efa90ab5f6ea7cf5e0f44aec6f4e6418aad3d
>
> TBR=reed@google.com,mtklein@google.com,mtklein@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/1afb8f8965b0549525c1ad8d8baa885ccdb48f6d

TBR=reed@google.com,mtklein@google.com,mtklein@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review-Url: https://codereview.chromium.org/2096613002
 2016-06-23 04:16:38 -07:00
rmistry
1afb8f8965 Revert of add a Chrome builder to the CQ (patchset #1 id:1 of https://codereview.chromium.org/2085333002/ ) 
Reason for revert:
Reverting due to purple trybots in https://codereview.chromium.org/2087343002/

We will have to investigate..

Original issue's description:
> add a Chrome builder to the CQ
>
> This appears to be the fastest Chrome builder, averaging 8-9 minutes.
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2085333002
>
> Committed: https://skia.googlesource.com/skia/+/cb4efa90ab5f6ea7cf5e0f44aec6f4e6418aad3d

TBR=reed@google.com,mtklein@google.com,mtklein@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review-Url: https://codereview.chromium.org/2087913003
 2016-06-22 10:41:02 -07:00
mtklein
cb4efa90ab add a Chrome builder to the CQ 
This appears to be the fastest Chrome builder, averaging 8-9 minutes.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2085333002

Review-Url: https://codereview.chromium.org/2085333002
 2016-06-22 10:22:55 -07:00
borenet
0f1469bcda Add asset management scripts 
These provide an easy way to create assets to be used by bots,
eg. Android SDK.

To create an asset:
$ infra/bots/assets/assets.py add android_sdk
(adds scripts in infra/bots/assets/android_sdk)

To upload a new version of an asset:
$ infra/bots/assets/android_sdk/upload.py -t $ANDROID_SDK_ROOT
(uploads Android SDK to GS, writes a version file)
$ git commit
$ git cl upload

To download the current version of the asset:
$ infra/bots/assets/android_sdk/download.py -t ../tmp

BUG=skia:5427
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2069543002

Review-Url: https://codereview.chromium.org/2069543002
 2016-06-15 12:07:42 -07:00
borenet
09b4224be3 Add housekeeper_skia.isolate 
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2054883002

Review-Url: https://codereview.chromium.org/2054883002
 2016-06-09 12:58:11 -07:00
borenet
1346c25071 isolate_android_sdk: Find or download isolate binary, fix infra path 
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2016353003

Review-Url: https://codereview.chromium.org/2016353003
 2016-05-27 11:11:22 -07:00
liyuqian
62d9bcc110 Update Android SDK 
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2016363002

Review-Url: https://codereview.chromium.org/2016363002
 2016-05-27 08:08:34 -07:00
borenet
4ca5539df5 Add isolate_android_sdk.py script and android_sdk_hash 
BUG=skia:5298
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1975893002

Review-Url: https://codereview.chromium.org/1975893002
 2016-05-13 08:41:04 -07:00
benjaminwagner
ae5c01d52b Add XSAN suppression files to infrabots.isolate. Only compile 'dm' and 'nanobench' for XSAN flavors. 
Needed for https://codereview.chromium.org/1920283002

BUG=skia:5157
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1859413003

Review-Url: https://codereview.chromium.org/1859413003
 2016-05-04 06:35:50 -07:00
mtklein
d1adec1870 Update Win toolchain 
I believe this now correctly updates us to VS 2015 update 2.

CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Win-MSVC-x86-Debug-VS2015-Trybot

https://isolateserver.appspot.com/browse?namespace=default-gzip&digest=3c710fd7f4df8ec24fde62681536fad21be2751c

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1926813007

Review-Url: https://codereview.chromium.org/1926813007
 2016-04-28 11:02:36 -07:00
rmistry
12135f50bd Add dry_run_access_list to Skia's cq.proto 
This will give all users who have access to our trybots access to our dry run CQ as well.

BUG=591183
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1926783002

Review-Url: https://codereview.chromium.org/1926783002
 2016-04-27 09:43:21 -07:00
borenet
6f4c1aa8f9 Don't isolate the Skia repo for Swarming compiles 
BUG=skia:
NOTREECHECKS=true
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1886343002

Review URL: https://codereview.chromium.org/1886343002
 2016-04-27 06:06:25 -07:00
rmistry
eff1920deb Add new coverage_skia.isolate 
Coverage is different from the other recipes because it needs both skia_repo and test artifacts. The primary reason is: the path to the out directory is compiled into the binary, which is why the compile and test steps need to be combined.

The isolate file will be used from the updated coverage recipe in https://codereview.chromium.org/1862713002/

BUG=skia:5159
NOTREECHECKS=true

Review URL: https://codereview.chromium.org/1893503003
 2016-04-18 04:13:48 -07:00
borenet
b0070197ff More iOS swarming bot fixes 
- Copy the packaged app into xcodebuild/...
- Isolate ios/bin directory

BUG=skia:5155
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1860333002

Review URL: https://codereview.chromium.org/1860333002
 2016-04-06 11:38:55 -07:00
rmistry
50cff2c5ac Add valgrind suppression file to infrabots.isolate 
BUG=skia:5149
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1859083002

Review URL: https://codereview.chromium.org/1859083002
 2016-04-05 08:31:48 -07:00
borenet
cafbfe65a0 Support for Android Swarming bots 
BUG=skia:4763
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1819033002

Review URL: https://codereview.chromium.org/1819033002
 2016-04-01 07:18:28 -07:00
borenet
15bc5603e4 Fixes for Swarming recipes 
BUG=skia:4763
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1827413002
NOTRY=true

Review URL: https://codereview.chromium.org/1827413002
 2016-03-30 07:41:32 -07:00
kjlubick
2e59f1f2fd Splitting up wait_for_device into two pieces 
BUG=skia:5111
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1829753004

Review URL: https://codereview.chromium.org/1829753004
 2016-03-25 05:22:40 -07:00
borenet
0f5e41461a Add experimental Swarmbucket bot 
Docs here:
https://chromium.googlesource.com/infra/infra/+/master/appengine/cr-buildbucket/doc/swarming.md

NOTRY=true
BUG=skia:4763
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1820323002

Review URL: https://codereview.chromium.org/1820323002
 2016-03-22 09:37:57 -07:00
borenet
423ba24cac Swarming: Ensure depot_tools is in PATH when compiling 
Turns out we were "lucky" for our Linux bots which already have depot_tools in PATH. The Mac bot does have depot_tools, but it's not in PATH.  Add it in the script to ensure we can always get to it.

NOTRY=true
BUG=skia:4763
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1823653002

Review URL: https://codereview.chromium.org/1823653002
 2016-03-21 09:02:51 -07:00
borenet
98ed14ea05 Remove --verbose from DM on Swarming bots 
TBR=mtklein
BUG=skia:4763
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1817563002

Review URL: https://codereview.chromium.org/1817563002
 2016-03-18 11:27:43 -07:00
borenet
57d66ddf50 Fix Linux Swarming bots 
NOTRY=true
NOTREECHECKS=true
BUG=skia:4763
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1806323003

Review URL: https://codereview.chromium.org/1806323003
 2016-03-17 09:19:09 -07:00
borenet
64e9816429 Some fixes for Swarming bots 
BUG=skia:4763
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1813443003

Review URL: https://codereview.chromium.org/1813443003
 2016-03-17 09:01:33 -07:00
borenet
523fa2a332 Fix compile on Windows swarming bot 
BUG=skia:4763
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1791513002

Review URL: https://codereview.chromium.org/1791513002
 2016-03-16 07:27:05 -07:00
borenet
8749cfa2ca Add CMake builder to CQ 
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1810523002

Review URL: https://codereview.chromium.org/1810523002
 2016-03-16 07:07:25 -07:00
borenet
2f56b1aba2 Fixes for Win toolchain isolate 
NOTRY=true
BUG=skia:4763, skia:4553
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1782943002

Review URL: https://codereview.chromium.org/1782943002
 2016-03-11 04:54:42 -08:00
borenet
2bcfb4bec3 Add isolate_win_toolchain.py 
Intended to be run manually by a developer on Windows.
Downloads the requested Windows toolchain, uploads it
to the isolate server, records the isolated hash in
the JSON file and uploads a CL to update that file.

BUG=skia:4553, skia:4763
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1775073002

Review URL: https://codereview.chromium.org/1775073002
 2016-03-10 07:01:39 -08:00
borenet
f2e2a1e290 Swarming bots: fix trybots 
Requires a recipe-side change as well.

NOTRY=true
BUG=skia:4763
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1768333002

Review URL: https://codereview.chromium.org/1768333002
 2016-03-08 05:33:03 -08:00
borenet
d8d046c81f Swarming bots: add build products whitelist 
Should reduce output isolate size (and therefore upload time) for
compile task by ~10x

NOTRY=true
BUG=skia:4763
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1768273002

Review URL: https://codereview.chromium.org/1768273002
 2016-03-07 10:57:26 -08:00
borenet
d4f89e4e39 Swarming tasks: print start and end time 
This will help determine how long each component of the task takes.

NOTRY=true
BUG=skia:4763
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1769583002

Review URL: https://codereview.chromium.org/1769583002
 2016-03-04 10:58:21 -08:00
borenet
f1215a537f Swarming bots: setup for skipping download of build products 
Turns out it's pretty easy to pass the compile outputs to the test task by just adding the hash to the "includes" list in the .isolated file.  So the flow is:
1. Isolate skia repo
2. Run compile task, record hash of results
3. Isolate test inputs for DM. This writes a .isolated file
4. Edit the .isolated file from #3 to include the hash from #2
5. Upload the modified .isolated file to the isolate server
6. Trigger the swarming task for DM
7. Wait for DM task to finish, download results from isolate server
8. Upload results to GS as normal

I expect the swarming bots to break when this is committed due to the moved out directory.  The associated recipe change will fix them.

NOTRY=true
BUG=skia:4763
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1759553003

Review URL: https://codereview.chromium.org/1759553003
 2016-03-04 04:55:26 -08:00
stephana
7c0b9feee9 Temporarily disable ios compile bot 
BUG=skia:
TBR=rmistry
NOTRY=true
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1757053002

Review URL: https://codereview.chromium.org/1757053002
 2016-03-02 12:45:04 -08:00
borenet
c803ef125d Swarming bots: Add support for perf steps 
NOTRY=true
BUG=skia:4763
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1754843002

Review URL: https://codereview.chromium.org/1754843002
 2016-03-02 08:06:27 -08:00
borenet
c58487e088 Swarming Bots: fix resource path 
TBR=rmistry
NOTRY=true
BUG=skia:4763
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1749873002

Review URL: https://codereview.chromium.org/1749873002
 2016-02-29 10:48:40 -08:00
borenet
ea2dabd9c8 Swarming bots: Fix tester out dir 
TBR=rmistry
NOTRY=true
BUG=skia:4763
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1751463002

Review URL: https://codereview.chromium.org/1751463002
 2016-02-29 10:17:38 -08:00
borenet
1e83a2a239 Fix Swarming compile out dir 
TBR=rmistry
NOTRY=true
BUG=skia:4763
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1743353002

Review URL: https://codereview.chromium.org/1743353002
 2016-02-29 10:06:33 -08:00
borenet
c0cb60d453 Swarming Tests: create tmp dir if it doesn't exist 
TBR=rmistry
NOTRY=true
BUG=skia:4763
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1749623003

Review URL: https://codereview.chromium.org/1749623003
 2016-02-29 08:39:27 -08:00
borenet
17597fe29d Swarming tests: Fix uninteresting hash file path 
TBR=rmistry
NOTRY=true
BUG=skia:4763
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1746063002

Review URL: https://codereview.chromium.org/1746063002
 2016-02-29 08:19:42 -08:00
borenet
a7a6f2e01d Add test_skia.py, isolates for test_skia, images, skps 
This enables running DM through Swarming.

NOTRY=true
BUG=skia:4763
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1743113003

Review URL: https://codereview.chromium.org/1743113003
 2016-02-29 05:57:31 -08:00
borenet
3fe4df6d8b Add luci-go isolate.sha1 files 
NOTRY=true
BUG=skia:3775, skia:4763
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1711013002

Review URL: https://codereview.chromium.org/1711013002
 2016-02-18 10:13:14 -08:00
borenet
d9fa758292 Port Skia recipe to normal Python scripts, move to Skia repo 
BUG=skia:4763
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1703663002

Review URL: https://codereview.chromium.org/1703663002
 2016-02-18 08:05:48 -08:00
mtklein
3f20f511dc update CQ with new bot names 
NOTRY=true
NOTREECHECKS=true

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1675643002

Review URL: https://codereview.chromium.org/1675643002
 2016-02-05 06:10:38 -08:00
borenet
4894565528 Add Test-Ubuntu-GCC-ShuttleA-GPU-GTX660-x86_64-Release to the CQ 
BUG=skia:4758
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1564743003

Review URL: https://codereview.chromium.org/1564743003
 2016-01-06 10:54:50 -08:00
borenet
258ade521b Add iOS compile bot to the CQ 
BUG=skia:4252

Review URL: https://codereview.chromium.org/1501453005
 2015-12-04 10:19:21 -08:00
sergiyb
613f20aa4b Moved committer list to chrome-infra-auth and deleted it from the repo 
R=rmistry@chromium.org
BUG=chromium:511311

Review URL: https://codereview.chromium.org/1314153006
 2015-09-02 13:37:54 -07:00
rmistry
a3710c3262 Specify try_job_retry_config for Skia try jobs 
Retry config support was added to the CQ in https://chromereviews.googleplex.com/240527013/
This CL uses the retry config in Skia's cq.cfg file.

CQ's default failure_retry_weight is 1. We set it to 2 which will immediately go beyond the try job quota and will not retry for failures. It will retry for transient errors.

BUG=chromium:522460
TBR=mtklein
NOTRY=true

Review URL: https://codereview.chromium.org/1330473002
 2015-09-02 05:23:23 -07:00
nodir
f3782fa76f Build buckets: tryjob access 
Allowed project-skia-tryjob-access group to schedule builds on public
skia build buckets

R=borenet@chromium.org, rmistry@chromium.org
BUG=495680

Review URL: https://codereview.chromium.org/1256333006
 2015-07-30 10:32:27 -07:00
nodir
db8e4382a4 Skia project metadata 
Added project.cfg metadata file for chrome-infra

R=borenet@google.com, rmistry@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=507723

Review URL: https://codereview.chromium.org/1231383004
 2015-07-13 06:23:24 -07:00
mtklein
a981e74097 Add a 64-bit ARM builder to the CQ. 
It's possible this rarely breaks, but I do write ARMv8 code frequently
enough that it'll help prevent broken trees.

BUG=skia:

Review URL: https://codereview.chromium.org/1209763003
 2015-06-24 14:52:24 -07:00
sheyang
12555d7efb Add signcla verifier to skia. 
This verifier is just informative now.

BUG=457428

Review URL: https://codereview.chromium.org/1193433003
 2015-06-17 09:15:52 -07:00
sergiyb
2baef5a1e1 Added CQ config to skia repo 
This must land in sync with https://chromereviews.googleplex.com/204307013 and
revert in sync.

R=rmistry@chromium.org, tandrii@chromium.org
NOTRY=true
NOTREECHECKS=true
BUG=chromium:471767

Review URL: https://codereview.chromium.org/1153093004
 2015-06-08 05:12:56 -07:00
nodir
038b01c081 /infra directory 
Added /infra directory, it will contain chrome-infra specific files, in
particular configs for chrome infra services.

/infra/project-config/cr-buildbucket.cfg defines buckets on
cr-buildbucket.appspot.com

R=borenet@google.com
BUG=skia:

Review URL: https://codereview.chromium.org/1164633002
 2015-06-01 09:39:11 -07:00