brianosman
fad98562d8
Prototype code that turns any/every flattenable into JSON
...
This makes inspecting things in SkDebugger far more useful - any filter
or other complex object on the paint is ultimately visible. You still
have to do some guess work to figure out what the fields actually mean,
but you can at least cross-reference with the code in flatten().
Screenshots:
Before: https://screenshot.googleplex.com/a6JM5HBBe6G.png
After : https://screenshot.googleplex.com/XQfr4YJ6mnH.png
Changes to public API are just removals and changes to make
some functions virtual.
TBR=reed@google.com
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1920423002
Review-Url: https://codereview.chromium.org/1920423002
2016-05-04 11:06:28 -07:00
borenet
43bf511ead
Delete ChromeOS code
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1926163002
Review-Url: https://codereview.chromium.org/1926163002
2016-04-29 14:01:34 -07:00
ethannicholas
f67531f713
unified PNG encoding between SkDrawCommand and skiaserve
...
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1818043003
Review URL: https://codereview.chromium.org/1818043003
2016-03-21 10:19:39 -07:00
robertphillips
9ea8acdf3f
Unbust the old debugger
...
AFAICT the recent STL changes have introduced some QT conflicts.
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1753813002
Review URL: https://codereview.chromium.org/1753813002
2016-03-01 09:34:38 -08:00
jbroman
bbfe47bd0f
Add a dependency from the debugger on tools.gyp:url_data_manager.
...
BUG=skia:4947
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1695753003
Review URL: https://codereview.chromium.org/1695753003
2016-02-12 11:29:23 -08:00
ethannicholas
50a8dd0a00
Moved Canvas->JSON and JSON->Canvas functionality into SkDebugCanvas.
...
SkJSONCanvas and SkJSONRenderer will be deleted once the debug server
has been updated.
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1681643002
Committed: https://skia.googlesource.com/skia/+/32fff1ba0c759d97ab78320b7ae46dd7696a4e6e
Committed: https://skia.googlesource.com/skia/+/46cb6d6b82b0ab71033aef91419e8beae25bb8a4
Review URL: https://codereview.chromium.org/1681643002
2016-02-10 05:40:46 -08:00
caryclark
d116561ddc
Revert of Moved Canvas->JSON and JSON->Canvas functionality into SkDebugCanvas. (patchset #3 id:40001 of https://codereview.chromium.org/1681643002/ )
...
Reason for revert:
breaks various android builds, e.g.
acb02999d4/logs/build_error.log
external/skia/bench/../tools/debugger/SkDrawCommand.cpp:602:9: error: use of undeclared identifier 'free'
free(data);
Original issue's description:
> Moved Canvas->JSON and JSON->Canvas functionality into SkDebugCanvas.
> SkJSONCanvas and SkJSONRenderer will be deleted once the debug server
> has been updated.
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1681643002
>
> Committed: https://skia.googlesource.com/skia/+/32fff1ba0c759d97ab78320b7ae46dd7696a4e6e
>
> Committed: https://skia.googlesource.com/skia/+/46cb6d6b82b0ab71033aef91419e8beae25bb8a4
TBR=jcgregorio@google.com ,joshualitt@chromium.org,ethannicholas@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/1683093002
2016-02-10 04:34:08 -08:00
ethannicholas
46cb6d6b82
Moved Canvas->JSON and JSON->Canvas functionality into SkDebugCanvas.
...
SkJSONCanvas and SkJSONRenderer will be deleted once the debug server
has been updated.
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1681643002
Committed: https://skia.googlesource.com/skia/+/32fff1ba0c759d97ab78320b7ae46dd7696a4e6e
Review URL: https://codereview.chromium.org/1681643002
2016-02-09 14:37:55 -08:00
ethannicholas
3cb954245c
moved debugger support files from src/utils/debugger to tools/debugger
...
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1678893003
Review URL: https://codereview.chromium.org/1678893003
2016-02-09 12:44:06 -08:00
robertphillips
f42fca4027
Add gpu implementation of OverdrawXfermode
...
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1607253002
Committed: https://skia.googlesource.com/skia/+/8bc3cf88bbf5e5d5724356f076931bb70a6117ba
Review URL: https://codereview.chromium.org/1607253002
2016-01-27 05:00:04 -08:00
robertphillips
e429c88a81
Revert of Add gpu implementation of OverdrawXfermode (patchset #6 id:100001 of https://codereview.chromium.org/1607253002/ )
...
Reason for revert:
Overdraw Xfer mode using new fangled glsl features
Original issue's description:
> Add gpu implementation of OverdrawXfermode
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1607253002
>
> Committed: https://skia.googlesource.com/skia/+/8bc3cf88bbf5e5d5724356f076931bb70a6117ba
TBR=egdaniel@google.com
# Not skipping CQ checks because original CL landed more than 1 days ago.
Review URL: https://codereview.chromium.org/1626443002
2016-01-22 06:53:57 -08:00
robertphillips
8bc3cf88bb
Add gpu implementation of OverdrawXfermode
...
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1607253002
Review URL: https://codereview.chromium.org/1607253002
2016-01-20 12:00:22 -08:00
robertphillips
87ed6be0e4
Get debugger compiling again
...
Recent house cleaning has broken the debugger - mainly around the defunct profiling feature. This makes CL it even more defunct.
Review URL: https://codereview.chromium.org/1416723006
2015-10-26 09:28:12 -07:00
mtklein
cd1f2daf44
add -Iinclude/private anywhere we have -Isrc/core
...
I'll be moving headers from src/core to include/private, so this guarantees
that anyone who was finding them via -Isrc/core can now find them via
-Iinclude/private.
This is purely mechanical, mostly to preserve my sanity, so it's likely
(harmless) overkill.
Chromium's GYP and GN builds already set -Iinclude/private for Skia builds.
BUG=skia:4126
Review URL: https://codereview.chromium.org/1265443002
2015-07-28 08:55:14 -07:00
Mike Klein
478c9e4851
Revert "Move headers used by headers in include/ to include/private."
...
This reverts commit 928e16565f
.
BUG=skia:
Review URL: https://codereview.chromium.org/1213093004 .
2015-07-01 16:35:59 -04:00
mtklein
928e16565f
Move headers used by headers in include/ to include/private.
...
Some of this is transitive, like SkRecords.h used by SkMiniRecorder.h
used by (public) SkPictureRecorder.h.
BUG=skia:
Committed: https://skia.googlesource.com/skia/+/a89f55198bdc58f0b6f6196907ab25a6afc1a661
Review URL: https://codereview.chromium.org/1217293004
2015-07-01 11:55:42 -07:00
jvanverth
4417c7f8bb
Revert "Move headers used by headers in include/ to include/private."
...
This reverts commit a89f55198b
.
Reason: breaking the roll.
TBR=mtklein@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/1216033008
2015-07-01 09:45:46 -07:00
mtklein
a89f55198b
Move headers used by headers in include/ to include/private.
...
Some of this is transitive, like SkRecords.h used by SkMiniRecorder.h
used by (public) SkPictureRecorder.h.
BUG=skia:
Review URL: https://codereview.chromium.org/1217293004
2015-07-01 08:41:15 -07:00
borenet
4808757d7a
Remove all code related to NaCl
...
BUG=skia:3600
DOCS_PREVIEW= https://skia.org/?cl=1036283002
Review URL: https://codereview.chromium.org/1036283002
2015-04-02 12:16:36 -07:00
scroggo
3e5622764a
Add copyright headers to remaining gyp files.
...
Prevents some PRESUBMIT errors.
TBR=mtklein@google.com
Review URL: https://codereview.chromium.org/1035523003
2015-03-25 10:22:41 -07:00
kkinnunen
63a470227b
debugger: Make draw command image widget resize
...
Make draw command image widget resize. The widget was not resizing,
effectively preventing the window from being resized smaller.
Make the rasterized draw command image be proportional to the widget
size. The draw rasterization canvas is still an equilateral rectangle
with dimensions of the smaller side of the widget.
Makes the widget re-rasterize the image only when the draw command
changes, not for each widget paint.
Renames the widget from "image widget" to "draw command geometry
widget".
Makes the background of the image black, similar to the raster widget
background.
Adds a tooltip saying "Command geometry" for the widget, so that user might
understand what the contents should be.
This commit is part of work that tries to make the debugger window to be
a bit more resizeable, so that it would fit 1900x1200 screen.
Review URL: https://codereview.chromium.org/787143004
2014-12-30 23:03:56 -08:00
robertphillips
eb3379fe70
Turn off warnings as errors for the debugger
...
Compiling the debugger on Linux was running afoul of warnings-as-errors
Review URL: https://codereview.chromium.org/812673004
2014-12-17 11:27:47 -08:00
mtklein
9ac68ee259
Move BenchTimer to tools as Timer
...
This breaks a bunch of circular dependencies between tools and gm and bench.
BUG=skia:
Committed: https://skia.googlesource.com/skia/+/4ed75287aed6371c6e4a41ffcc78c8a49c9810ed
CQ_EXTRA_TRYBOTS=tryserver.skia:Build-Mac10.7-Clang-Arm7-Debug-iOS-Trybot,Test-Ubuntu12-ShuttleA-GTX660-x86-Debug-Trybot
R=tfarina@chromium.org , mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/344213003
2014-06-20 11:29:21 -07:00
mtklein
9e64b78ff6
Revert of Move BenchTimer to tools as Timer ( https://codereview.chromium.org/344213003/ )
...
Reason for revert:
GpuTimer broken
Original issue's description:
> Move BenchTimer to tools as Timer
>
> This breaks a bunch of circular dependencies between tools and gm and bench.
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/4ed75287aed6371c6e4a41ffcc78c8a49c9810ed
R=tfarina@chromium.org , mtklein@chromium.org
TBR=mtklein@chromium.org , tfarina@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Author: mtklein@google.com
Review URL: https://codereview.chromium.org/346753003
2014-06-20 10:43:07 -07:00
mtklein
4ed75287ae
Move BenchTimer to tools as Timer
...
This breaks a bunch of circular dependencies between tools and gm and bench.
BUG=skia:
R=tfarina@chromium.org , mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/344213003
2014-06-20 10:31:49 -07:00
commit-bot@chromium.org
d08d23b385
Small tweaks to be able to build everything target:
...
- fParsed is unused.
- Quiet down a bogus -Wuninitialized warning in QWeakPointer.
Tested Clang and GCC on Linux.
BUG=
R=bungeman@google.com
Author: mtklein@google.com
Review URL: https://codereview.chromium.org/128573002
git-svn-id: http://skia.googlecode.com/svn/trunk@12970 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-08 21:16:14 +00:00
commit-bot@chromium.org
611fde182a
Remove the comments settings for vim tab width and expansion variables.
...
These add unnecessary bloat for everyone to carry around, so we just
remove them now.
The same change was made in chromium by Tony in
http://codereview.chromium.org/7310019 - crrev.com/92046
BUG=None
TEST=./gyp_skia
R=mtklein@google.com
Author: tfarina@chromium.org
Review URL: https://codereview.chromium.org/92673003
git-svn-id: http://skia.googlecode.com/svn/trunk@12443 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-02 22:23:03 +00:00
robertphillips@google.com
35349d80b3
Revert r11342 (Add infrastructure for testing the debugger code) due to build breakages
...
git-svn-id: http://skia.googlecode.com/svn/trunk@11343 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-18 13:28:10 +00:00
commit-bot@chromium.org
15ec2ea617
Add infrastructure for testing the debugger code.
...
This creates the necessarily files and GYP targets to start adding tests
for the debugger code. There is currently one test added, more will be added
once the infrastructure is in place.
BUG=
R=mtklein@google.com
Author: dsinclair@chromium.org
Review URL: https://chromiumcodereview.appspot.com/23589007
git-svn-id: http://skia.googlecode.com/svn/trunk@11342 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-18 13:01:17 +00:00
fmalita@google.com
4df1673c13
Build fix after r9598.
...
Updated include paths for debugger backend classes.
R=bungeman@google.com
Review URL: https://codereview.chromium.org/16866017
git-svn-id: http://skia.googlecode.com/svn/trunk@9600 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-13 21:25:45 +00:00
fmalita@google.com
86681b37bd
Expose debugger backend classes externally.
...
SkDebugCanvas & friends are useful beyond the Qt debugger app - Chromium's picture inspector (in development) is at the point where it could take advantage of it.
This patch moves SkDrawCommand, SkDebugCanvas & SkObjectParser from trunk/debugger to trunk/src/utils (since several tools already use these, this seems appropriate), and makes SkDrawCommand & SkDebugCanvas' symbols visible externally (SK_API).
R=reed@google.com
Review URL: https://codereview.chromium.org/16638014
git-svn-id: http://skia.googlecode.com/svn/trunk@9598 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-13 20:59:14 +00:00
borenet@google.com
05d550ed36
GYP Changes and Scripts for Compiling Skia for ChromeOS
...
For now, this requires having a complete ChromeOS checkout.
R=djsollen@google.com
Review URL: https://codereview.chromium.org/16099011
git-svn-id: http://skia.googlecode.com/svn/trunk@9505 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-11 15:52:19 +00:00
djsollen@google.com
52f0297aaf
Prepare skia for shared library build on android
...
This reapplies revision 9378 after the buildbot has been updated.
R=borenet@google.com , djsollen@google.com
Review URL: https://codereview.chromium.org/15855006
git-svn-id: http://skia.googlecode.com/svn/trunk@9395 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-03 12:10:19 +00:00
djsollen@google.com
a96627fd24
prepare skia for shared library build on android
...
R=borenet@google.com , djsollen@google.com
Committed: https://code.google.com/p/skia/source/detail?r=9378
Review URL: https://codereview.chromium.org/15855006
git-svn-id: http://skia.googlecode.com/svn/trunk@9379 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-31 20:09:47 +00:00
djsollen@google.com
cf5348f5aa
prepare skia for shared library build on android
...
R=borenet@google.com , djsollen@google.com
Review URL: https://codereview.chromium.org/15855006
git-svn-id: http://skia.googlecode.com/svn/trunk@9378 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-31 20:02:56 +00:00
borenet@google.com
6a98b8c0b5
Copy NaCl directory into trunk/platform_tools, adjust paths
...
(SkipBuildbotRuns)
R=djsollen@google.com
Review URL: https://codereview.chromium.org/14771017
git-svn-id: http://skia.googlecode.com/svn/trunk@9008 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-06 12:50:00 +00:00
skia.committer@gmail.com
754a3eb73b
Sanitizing source files in Skia_Periodic_House_Keeping
...
git-svn-id: http://skia.googlecode.com/svn/trunk@8033 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-08 07:01:25 +00:00
borenet@google.com
327b9b205a
Gyp changes for NaCl debugger
...
Review URL: https://codereview.chromium.org/12544011
git-svn-id: http://skia.googlecode.com/svn/trunk@8015 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-07 15:33:28 +00:00
robertphillips@google.com
2f10475733
Fix moc generation with SK_SUPPORT_GPU defined
...
https://codereview.appspot.com/7305088/
git-svn-id: http://skia.googlecode.com/svn/trunk@7725 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-02-13 20:12:21 +00:00
humper@google.com
f515ffc3d4
Show the paint's typeface information in the details pane of the debugger.
...
Also add a convenience constructor for SkMemoryStream that takes the SkData directly
(instead of having to construct an empty one and call setData).
Review URL: https://codereview.appspot.com/7065045
git-svn-id: http://skia.googlecode.com/svn/trunk@7048 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-07 15:48:19 +00:00
robertphillips@google.com
6dec8fcb44
Add drawing of paths to debugger
...
https://codereview.appspot.com/6850082/
git-svn-id: http://skia.googlecode.com/svn/trunk@6532 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-11-21 17:11:02 +00:00
robertphillips@google.com
8a1cdaece7
Breakdown profile time by command type in the overview pane
...
https://codereview.appspot.com/6851073/
git-svn-id: http://skia.googlecode.com/svn/trunk@6492 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-11-19 20:44:29 +00:00
robertphillips@google.com
2bde91dcb6
Add profiling to debugger
...
https://codereview.appspot.com/6817114/
git-svn-id: http://skia.googlecode.com/svn/trunk@6430 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-11-15 14:57:57 +00:00
bungeman@google.com
b3e77940a6
Generate debugger mocs into out instead of src.
...
https://codereview.appspot.com/6674044/
git-svn-id: http://skia.googlecode.com/svn/trunk@5953 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-10-15 14:31:29 +00:00
bsalomon@google.com
d980478e6f
Fix Qt OpenGL lib name on Windows and change the default qt_sdk var value on windows.
...
Over-the-shoulder review from robertphillips@google.com
git-svn-id: http://skia.googlecode.com/svn/trunk@5894 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-10-11 14:33:10 +00:00
borenet@google.com
efb1d77ad2
Build Skia as a static library
...
- Roll GYP so that we get non-thin archives on Linux
- Add merge_static_libs.py
- Add skia_core_lib target which builds core, ports, opts*, and utils
- Replace dependencies on core/ports/opts/utils with skia_core_libs
- Rename exportable libraries with "skia_"
Review URL: https://codereview.appspot.com/6619049
git-svn-id: http://skia.googlecode.com/svn/trunk@5889 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-10-10 19:45:51 +00:00
fmalita@google.com
bacfcfb11c
Generate debugger MOCs on the fly
...
Added gyp rules to generate Qt MOC files at build time, and removed the pre-packaged versions.
Tested on Mac with Qt 4.6.4 & 4.8.3, and on Linux with Qt 4.8.1.
R=caryclark@google.com ,robertphillips@google.com,djsollen@google.com
BUG=
Review URL: https://codereview.appspot.com/6561054
git-svn-id: http://skia.googlecode.com/svn/trunk@5707 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-09-27 13:34:34 +00:00
fmalita@google.com
36631b99f9
Fix Xcode 4.x debugger build
...
Adding a mac_framework_dirs entry to help Xcode find the Qt frameworks.
R=djsollen@google.com
BUG=
Review URL: https://codereview.appspot.com/6564056
git-svn-id: http://skia.googlecode.com/svn/trunk@5702 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-09-26 18:32:58 +00:00
caryclark@google.com
129dee8014
fix mac builds
...
comment out 64 bit / mac error check
git-svn-id: http://skia.googlecode.com/svn/trunk@5654 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-09-24 21:38:38 +00:00
caryclark@google.com
18b3823d29
unbreak the build part ii
...
allow android in debugger.gyp
git-svn-id: http://skia.googlecode.com/svn/trunk@5651 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-09-24 20:08:43 +00:00