AuroraMiddleware/skia2
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
16,125 Commits 1 Branch 0 Tags 544 MiB
68c7b6aa98
Commit Graph

16125 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
yunchao.he
90acb8e97c a typo in SkResourceCacheTest 
BUG=skia:

Review URL: https://codereview.chromium.org/868613002
 2015-01-23 17:06:21 -08:00
mtklein
1eea9fcb24 Revert of Fix Morphology effects sourcing outside of the crop rect. (patchset #6 id:100001 of https://codereview.chromium.org/781153002/) 
Reason for revert:
Looks like this is causing memory leaks:
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu13.10-GCE-NoGPU-x86_64-Debug-ASAN/builds/1155/steps/dm/logs/stdio

And causing crashes on Mac 10.6:
http://build.chromium.org/p/client.skia/builders/Test-Mac10.6-MacMini4.1-GeForce320M-x86_64-Debug/builds/1417/steps/dm/logs/stdio

Original issue's description:
> Fix Morphology effects sourcing outside of the crop rect.
>
> BUG=skia:1766
>
> Committed: https://skia.googlesource.com/skia/+/f6be925b5615f07039ce95c3433039694a8d1679

TBR=junov@google.com,junov@chromium.org,bsalomon@google.com,reed@google.com,cwallez@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:1766

Review URL: https://codereview.chromium.org/868973005
 2015-01-23 16:09:32 -08:00
tfarina
d47d013b44 Cleanup: Delete buildbot_globals.py script. 
rebaseline_server was the only user of this code but it was removed in
https://chromium.googlesource.com/skia/+/3886046f008f0542de36cbeb35e220404e7c88a9

So there aren't more users of this script and we can remove it now.

BUG=skia:3200
R=borenet@google.com

Review URL: https://codereview.chromium.org/873593005
 2015-01-23 14:48:53 -08:00
cwallez
f6be925b56 Fix Morphology effects sourcing outside of the crop rect. 
BUG=skia:1766

Review URL: https://codereview.chromium.org/781153002
 2015-01-23 13:35:10 -08:00
bsalomon
db558dde22 Zap the scratch key on non-RT textures when scratch textures are disabled. 
Review URL: https://codereview.chromium.org/870103002
 2015-01-23 13:19:00 -08:00
bsalomon
63c992f6c0 Fix the speeling of "purgeable" in Gr code 
TBR=robertphillips@google.com

Review URL: https://codereview.chromium.org/874693002
 2015-01-23 12:47:59 -08:00
halcanary
6a144345d7 Cleanup SkPDFObject::emit* 
Review URL: https://codereview.chromium.org/869783003
 2015-01-23 11:45:10 -08:00
mtklein
1c4029296f remove unused GM flags 
Depends on https://codereview.chromium.org/873753002/

Thumbs up to CLion for refactoring this for me.

BUG=skia:

Review URL: https://codereview.chromium.org/867963004
 2015-01-23 11:07:08 -08:00
bsalomon
a3ca15c314 Remove deprecated SkSurface::NewRenderTarget factories 
Review URL: https://codereview.chromium.org/837723008
 2015-01-23 11:02:50 -08:00
mtklein
205de46789 run clean branch baseline only once 
BUG=skia:

Review URL: https://codereview.chromium.org/874643002
 2015-01-23 10:39:55 -08:00
mtklein
cf5d9c993d Spin off GM::runAsBench() from flags. 
This will let us kill flags.

BUG=skia:

Review URL: https://codereview.chromium.org/873753002
 2015-01-23 10:31:45 -08:00
fmalita
7a2c8f3f28 Fix SampleApp picture-mode transform. 
The multi-picture-draw path should not ignore the inherited transform.

R=reed@google.com,robertphillips@google.com

Review URL: https://codereview.chromium.org/867303002
 2015-01-23 10:03:15 -08:00
bsalomon
eaaaf0b16c Take budgeted param when snapping new image. 
Review URL: https://codereview.chromium.org/872543002
 2015-01-23 08:08:04 -08:00
tfarina
528eadceab Fix 'Revert' instructions. 
In the not so new pure Git world, 'svn fetch' and 'svn rebase' are not
needed anymore.

BUG=None
R=borenet@google.com

Review URL: https://codereview.chromium.org/872433004
 2015-01-23 08:06:13 -08:00
halcanary
68b60c3d5a Collect everything Skia into one document. 
http://skiadocs.com:8000/dev/contrib/directory?cl=866133002

Review URL: https://codereview.chromium.org/866133002
 2015-01-23 07:52:58 -08:00
reed
2ff257bd95 check for too-large rowBytes 
BUG=446164

Review URL: https://codereview.chromium.org/871993003
 2015-01-23 07:51:14 -08:00
halcanary
fb35940de7 In Correctness Testing Doc, render --option correctly 
TBR=mtklein@google.com
NOTRY=true

Review URL: https://codereview.chromium.org/871993004
 2015-01-23 07:47:55 -08:00
halcanary
8de56326e3 minor changes left out of http://crrev.com/873543002 
TBR=mtklein@google.com

Review URL: https://codereview.chromium.org/872643005
 2015-01-23 07:22:58 -08:00
bsalomon
c2f35b750a Allow unbudgeted resources to be recycled by the cache as scratch. 
Review URL: https://codereview.chromium.org/870743002
 2015-01-23 07:19:22 -08:00
bsalomon
4dffede04a Fix self assigment in GrResourceKey 
TBR=robertphillips@google.com

BUG=skia:3340

Review URL: https://codereview.chromium.org/866263007
 2015-01-23 07:17:55 -08:00
mtklein
727c594d4b Add a basic doc for correctness testing (DM). 
https://skia.org/dev/contrib/testing?cl=868983002

BUG=skia:

Review URL: https://codereview.chromium.org/868983002
 2015-01-23 07:14:16 -08:00
mtklein
a07b297585 Update compiler warning flags 
- add -Wsign-compare, which has been catching useful issues for Kimmo;
 - add -Winit-self and -Wpointer-arith to Mac builds so everyone's using
   the same flags;
 - try try removing -Wno-uninitialized.  This was only for the old 10.6
   compiler that we have warnings set as non-errors now.

BUG=skia:

Review URL: https://codereview.chromium.org/872793002
 2015-01-23 07:01:26 -08:00
bsalomon
1ea1ebce10 Remove GrBinHashKey 
Review URL: https://codereview.chromium.org/861323002
 2015-01-23 06:46:16 -08:00
kkinnunen
016dffb7b3 Compile fix after Add specialized content key class for resources 
gcc (Ubuntu/Linaro 4.6.4-1ubuntu1~12.04) 4.6.4
error: comparison between signed and unsigned integer expressions

Review URL: https://codereview.chromium.org/871013002
 2015-01-23 06:43:05 -08:00
halcanary
530ea8e24b More changes to SkPDFShader to eliminate multiple inheritance! 
Review URL: https://codereview.chromium.org/873543002
 2015-01-23 06:17:35 -08:00
reed
f803da12cf add newImage API 
BUG=skia:3277
related bug: skbug.com/3276

Review URL: https://codereview.chromium.org/821083002
 2015-01-23 05:58:07 -08:00
mtklein
a17241bd0a Write dm.json periodically instead of only once at the end. 
This way if a bot crashes, we might get some partial results in gold rather
than none.  We do the same sort of thing in nanobench for perf.

BUG=skia:3255

Review URL: https://codereview.chromium.org/872443003
 2015-01-23 05:48:00 -08:00
mtklein
2f6bb6b852 minor readability / refactors 
I have been hacking at this test trying to understand why the N5 is
still sometimes crashy (it seems, less but not zero now). No luck so far.

But, while I've been reading and hacking at it, I think I've made a
few small improvements, mostly to readability.

BUG=skia:

Review URL: https://codereview.chromium.org/870803002
 2015-01-23 05:47:55 -08:00
reed
7983bf914a more reinforcement that images never have zero width or height 
BUG=skia:

Review URL: https://codereview.chromium.org/869743002
 2015-01-23 04:24:16 -08:00
bsalomon
24db3b1c35 Add specialized content key class for resources. 
Review URL: https://codereview.chromium.org/858123002
 2015-01-23 04:24:05 -08:00
skia.buildbots
f98f2bb0e7 Update SKP version 
Automatic commit by the RecreateSKPs bot.

TBR=

Review URL: https://codereview.chromium.org/866383002
 2015-01-23 04:19:00 -08:00
halcanary
bc59ac6b12 Simplify SkPDFShader class. Now invalid objects are never created. 
"Constructors should not do real work"

I have verified that all test PDFs render identically.

Review URL: https://codereview.chromium.org/862113004
 2015-01-23 04:18:53 -08:00
mtklein
cada95ad9b Move FP texture test buffers to heap. 
This is a speculative fix for the crashing N5 bots.  It looks like the bots are
always failing in or around FloatingPointTextureTest.

It looks like sometimes they're hitting a SIGBUS, which I suspect is stack
overflow.  FloatingPointTextureTest allocates ~320K on the stack, which may
be too much.  This CL moves those buffers to the heap.  For consistency I did
the same with the half-float tests, though they're only using ~1/8th the stack.

It looks like sometimes the bots are failing to malloc.  I don't understand that,
and this CL doesn't address that directly.  But it's possible this is still a stack
overflow, just trashing RAM and causing arbitrary mayhem instead of a SIGBUS.

I have no idea why this is a problem only on the N5.  I have been unable to
reproduce this locally, neither with a K N5 nor an L N5, but the bots are pretty
reliable.

NOTREECHECKS=true
BUG=skia:

Review URL: https://codereview.chromium.org/871623002
 2015-01-22 13:50:35 -08:00
reed
5c05a1b137 remove unnecessary guard flags for android (for conics) 
BUG=skia:
NOTREECHECKS=True

Review URL: https://codereview.chromium.org/868783002
 2015-01-22 13:41:00 -08:00
mtklein
2d63859f6f android_run_skia: dump logcat on failure 
logcat -c clears the log before we run.
logcat -d dumps the log stdout and exits.

BUG=skia:

Review URL: https://codereview.chromium.org/870643002
 2015-01-22 10:43:34 -08:00
dongseong.hwang
8f25c667ea Initialize the pad memory in GrBufferAllocPool. 
Msan bot detects Use-of-uninitialized-value on the pad.

BUG=445745

Review URL: https://codereview.chromium.org/865913002
 2015-01-22 10:40:20 -08:00
mtklein
75de4f827f Put close_gif() in an anonymous namespace. 
Not a big deal, but matches the intention of it being a file-scoped function
better.  This mirrors a recent google3 change for clients who don't use C++11.

BUG=skia:

Review URL: https://codereview.chromium.org/865243002
 2015-01-22 10:32:25 -08:00
scroggo
6d7e47a8e0 Muck with the right cinfo. 
In SkImageDecoder_libjpeg, modify cinfo *after* destroying it and
creating a new one in its place.

Should fix build breakage.

Committed: https://skia.googlesource.com/skia/+/3629865bac20ae8092177f519594f79f89d09fb0

Review URL: https://codereview.chromium.org/858333002
 2015-01-22 10:27:25 -08:00
egdaniel
8dd688b756 Rename GrOptDrawState to GrPipeline and GrDrawState to GrPipelineBuilder 
BUG=skia:

Review URL: https://codereview.chromium.org/858343002
 2015-01-22 10:16:09 -08:00
reed
e44acc9617 remove more dead code 
BUG=skia:

Review URL: https://codereview.chromium.org/865873003
 2015-01-22 09:37:46 -08:00
reed
b0dfb546f5 remove (unused) GatherPixelRefs 
BUG=skia:

Review URL: https://codereview.chromium.org/869463002
 2015-01-22 09:03:25 -08:00
mtklein
50282b4390 fLuminance is unsed unless SK_GAMMA_APPLY_TO_A8 is defined 
BUG=skia:

Review URL: https://codereview.chromium.org/865103002
 2015-01-22 07:59:52 -08:00
bungeman
44af7ba4bc Fix SkIStream nits. 
Fix comment, constness of one field, and delete already checks for NULL.

TBR=reed@google.com
Trivial change to debatably public api.

Review URL: https://codereview.chromium.org/868643003
 2015-01-22 07:33:51 -08:00
joshualitt
2fdeda0498 XPFactory lazily initializie in drawstate / GrPaint 
BUG=skia:

Review URL: https://codereview.chromium.org/866573002
 2015-01-22 07:11:45 -08:00
egdaniel
dcfb7cf336 Remove the need for asCoeff in SkXfermode. 
BUG=skia:

Review URL: https://codereview.chromium.org/864833002
 2015-01-22 06:52:29 -08:00
bungeman
2dca817edb Remove staging SkStream::unref(). 
SkStream::unref() was added to ease transitioning off of SkStream
deriving from SkRefCnt. It is no longer needed, remove it.

TBR=reed@google.com

Review URL: https://codereview.chromium.org/861413002
 2015-01-22 06:08:31 -08:00
skia.buildbots
faff2c4598 Update SKP version 
Automatic commit by the RecreateSKPs bot.

TBR=

Review URL: https://codereview.chromium.org/807263005
 2015-01-21 23:09:41 -08:00
mtklein
4daa6f613c Don't require -DSK_USE_POSIX_THREADS. 
To compile SkCondVar, we already require either pthreads or Windows.  This
simplifies that code to not need SK_USE_POSIX_THREADS to be explicitly defined.
We'll just look to see if we're targeting Windows, and if not, assume pthreads.

Both before and after this CL, that code will fail to compile if we're not on
Windows and don't have pthreads.

BUG=skia:

Review URL: https://codereview.chromium.org/869443003
 2015-01-21 19:51:27 -08:00
mtklein
55e88b226c More natural way to serialize GPU tasks and tests. 
This basically takes out the Windows-only hacks and promotes them to
cross-platform behavior driven by --gpu_threading.
    - When --gpu_threading is false (the default), this puts GPU tasks and tests
      together in the same GPU enclave.  They all run serially.
    - When --gpu_threading is true, both the tests and the tasks run totally
      independently, just like the thread-safe CPU-bound work.

BUG=skia:3255

Review URL: https://codereview.chromium.org/847273005
 2015-01-21 15:50:13 -08:00
bungeman
aa7079b4a1 Revert of Muck with the right cinfo. (patchset #2 id:20001 of https://codereview.chromium.org/858333002/) 
Reason for revert:
Appears to cause Android dm to segfault.

Original issue's description:
> Muck with the right cinfo.
>
> In SkImageDecoder_libjpeg, modify cinfo *after* destroying it and
> creating a new one in its place.
>
> Should fix build breakage.
>
> Committed: https://skia.googlesource.com/skia/+/3629865bac20ae8092177f519594f79f89d09fb0

TBR=scroggo@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/858323003
 2015-01-21 15:08:10 -08:00