Commit Graph

2465 Commits

Author SHA1 Message Date
Ben Wagner
45ce9c7a2b Fixes for Vulkan Debug layers
Followup to https://skia-review.googlesource.com/c/skia/+/187921. Fixes
the path to the layers for the updated SDK.

Change-Id: I329b99be25bb23931963b711887da59a84bbf792
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/262064
Commit-Queue: Greg Daniel <egdaniel@google.com>
Auto-Submit: Ben Wagner aka dogben <benjaminwagner@google.com>
Reviewed-by: Greg Daniel <egdaniel@google.com>
2020-01-07 17:47:52 +00:00
Ben Wagner
2df621e68d Add NativeFonts job for Mac 10.15 CPU
Change-Id: Icf81d2fd50e060e9e9ca2876f5ed7192d0d18d7a
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/258885
Commit-Queue: Ben Wagner aka dogben <benjaminwagner@google.com>
Auto-Submit: Ben Wagner aka dogben <benjaminwagner@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2020-01-07 15:17:20 +00:00
Ben Wagner
8969a1641b Add missing Metal jobs
Change-Id: If571718c1f159762bf87ab41066a691505c30504
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/261186
Commit-Queue: Ben Wagner aka dogben <benjaminwagner@google.com>
Auto-Submit: Ben Wagner aka dogben <benjaminwagner@google.com>
Reviewed-by: Jim Van Verth <jvanverth@google.com>
2020-01-06 23:19:07 +00:00
Ben Wagner
6ea680581f Remove Win2016 jobs.
Change-Id: Ibba3e8f42928d19eb12ee15ca9937a043984977f
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/262224
Commit-Queue: Ravi Mistry <rmistry@google.com>
Auto-Submit: Ben Wagner aka dogben <benjaminwagner@google.com>
Reviewed-by: Ravi Mistry <rmistry@google.com>
2020-01-06 21:03:44 +00:00
Joe Gregorio
4679cb8557 Don't use CIPD_PKG_CPYTHON for P30.
Bug: skia:9602
Change-Id: Ia57b3f23502cff829879c3035c4ae37a4145a65b
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/262220
Auto-Submit: Joe Gregorio <jcgregorio@google.com>
Reviewed-by: Ravi Mistry <rmistry@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
2020-01-06 16:00:11 +00:00
skia-recreate-skps
d445e2b6fc Update SKP version
Automatic commit by the RecreateSKPs bot.

TBR=rmistry@google.com
NO_MERGE_BUILDS

Change-Id: I0a585bc7babf5e2e79a87464e4dde16fae4cd2ed
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/262237
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
2020-01-05 06:10:07 +00:00
Mike Klein
365c366b47 remove FAAA/FSAA bots
These were a backstop to catch regressions in an area of code that we're
no longer actively developing (how we choose rasterization algorithms.)

Change-Id: If0b4bf71593fc9f895a69d6aa36c86ea4f8ac141
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/261844
Commit-Queue: Mike Klein <mtklein@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
2020-01-03 20:19:57 +00:00
Mike Klein
4eef4fd854 remove redundant Debug bots that have ASAN bots
Remove any Debug bot that's not on the CQ and has a corresponding ASAN
bot (fudging it a little on one Mac bot that had a Metal-only ASAN bot.)

Change-Id: Ie82dce2c37ee1dfebb8686bb1774baaed80d8fd4
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/261842
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
2020-01-03 20:16:07 +00:00
Ben Wagner
dfde190ab0 [infra] Upgrade Win to 2019
Change-Id: I709792f697d5acc5e1c7c0df361f48d8170e2a34
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/261377
Commit-Queue: Ben Wagner aka dogben <benjaminwagner@google.com>
Reviewed-by: Ravi Mistry <rmistry@google.com>
2020-01-03 18:32:37 +00:00
Mike Klein
c22967e74f remove almost all Release ASAN bots
There's little need to run a Release ASAN bot when we've an equivalent
Debug ASAN bot.  This removes almost all Release ASAN bots and adds one
Debug ASAN bot.

The only Release ASAN bots I've kept are a bot on the CQ,
Perf-Ubuntu18-Clang-Golo-GPU-QuadroP400-x86_64-Release-All-ASAN, and the
corresponding Build bot.  We could leave that forever, replace it with
a Debug bot, or just take it off the CQ.

Change-Id: Ic0864fe2efdc39a95e204c7dfaaace238f2098ed
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/262087
Commit-Queue: Mike Klein <mtklein@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
Reviewed-by: Ben Wagner aka dogben <benjaminwagner@google.com>
2020-01-03 17:24:07 +00:00
Brian Osman
54bb838716 split CPU BonusConfigs SAN bots out explicitly
This logic that any GCE CPU *SAN bot is implicitly
a BonusConfigs bot is confusing... make it explicit.

This also means we can make BonusConfigs CPU bots
run disjoint work like the BonusConfigs GPU bots do.
No need to run the default configs redundantly.

Change-Id: I1219091f065a3d1135973bffea7c8774a8ca1ad6
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/262085
Commit-Queue: Mike Klein <mtklein@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
2020-01-03 17:21:47 +00:00
Ben Wagner
4cbf1de4ac [infra] Use POSIX paths for Docker containers
This makes the Housekeeper-PerCommit-InfraTests_Win task less broken.

Change-Id: Icd82b172dede83b69ed415fb03c3c47b54b5df5d
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/261997
Auto-Submit: Ben Wagner aka dogben <benjaminwagner@google.com>
Reviewed-by: Ravi Mistry <rmistry@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
2020-01-03 15:32:47 +00:00
Ben Wagner
7ac038f302 Move Android GPU ASAN jobs to NVIDIA_Shield.
Followup to https://skia-review.googlesource.com/c/skia/+/261933; Pixel
bots don't have enough capacity.

Change-Id: I3b3413c32170a31ba25a53cbbdc15b65b9c66f33
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/261996
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
Commit-Queue: Ben Wagner aka dogben <benjaminwagner@google.com>
Auto-Submit: Ben Wagner aka dogben <benjaminwagner@google.com>
2020-01-02 21:03:54 +00:00
Ben Wagner
1edebbac8c Add xSAN jobs for Vulkan
Change-Id: Ib77bb0e14e0957ca48817f09246042a3c38519a4
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/261277
Commit-Queue: Ben Wagner aka dogben <benjaminwagner@google.com>
Auto-Submit: Ben Wagner aka dogben <benjaminwagner@google.com>
Reviewed-by: Greg Daniel <egdaniel@google.com>
2020-01-02 20:35:18 +00:00
Mike Klein
c36a45d34d add some useful Debug/ASAN bots
We've realized we'd like to have a few more Debug Perf bots, and it
seems like maybe a good way to satisfy that is to backfill anywhere
we've got a Release Perf ASAN bot but not a Debug one.

In net, this adds:

   1) some Android ASAN Debug Build bots, both 32- and 64-bit ARM
   2) some Android ASAN Debug _Test_ bots using those new builds
   3) one CPU and one GPU Debug ASAN Perf bot

This CL originally was intended just to fulfill 3); I didn't anticipate
finding those testing gaps filled by 1) and 2), and if we find those new
bots to be a bother we can revert them.  They seemed like glaring enough
holes to try to fix now.

Change-Id: I5714522db52bb5bde458b724091a227229e55fea
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/261933
Commit-Queue: Mike Klein <mtklein@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
2020-01-02 19:38:53 +00:00
Ben Wagner
c2b6d7f50b Enable Vulkan Debug layers
Bug: skia:8709
Change-Id: Ie7033d4545df10011af1c1f207bce9ceaff829c0
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/187921
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Ben Wagner aka dogben <benjaminwagner@google.com>
Auto-Submit: Ben Wagner aka dogben <benjaminwagner@google.com>
2020-01-02 17:15:46 +00:00
Ben Wagner
b9137be12f Fix asan_device_setup path
https://skia-review.googlesource.com/c/skia/+/225483 updated only one of
two paths. Define them in the same place.

Change-Id: I6d517368f6a703d7c8cd4def6fa227a602dc0ffc
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/261289
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Auto-Submit: Ben Wagner aka dogben <benjaminwagner@google.com>
Reviewed-by: Kevin Lubick <kjlubick@google.com>
2020-01-02 14:21:46 +00:00
Ben Wagner
da11774fcc [infra] Handle failure from addr2line
An error from addr2line (e.g. unknown binary type) can truncate the
output, hiding the remainder of the stack trace. Instead print the
original line.

Change-Id: I563aae4333a79a17560378e399e79b60c79f9ac7
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/261288
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Auto-Submit: Ben Wagner aka dogben <benjaminwagner@google.com>
Reviewed-by: Kevin Lubick <kjlubick@google.com>
2020-01-02 13:16:16 +00:00
Ben Wagner
b6f98ea2c6 Enable ASAN on Windows
Docs-Preview: https://skia.org/?cl=261336
Change-Id: Ied00d717a37d92179c01158b2fbdfa47a52270c1
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/261336
Commit-Queue: Mike Klein <mtklein@google.com>
Auto-Submit: Ben Wagner aka dogben <benjaminwagner@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
2019-12-30 17:06:26 +00:00
Ben Wagner
96464fc252 Update Linux Vulkan SDK
Change-Id: I9492db5395505041ddacf659eb67c490e4437b0d
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/261287
Commit-Queue: Greg Daniel <egdaniel@google.com>
Auto-Submit: Ben Wagner aka dogben <benjaminwagner@google.com>
Reviewed-by: Greg Daniel <egdaniel@google.com>
2019-12-30 14:32:16 +00:00
skia-recreate-skps
a5dd1c74bd Update SKP version
Automatic commit by the RecreateSKPs bot.

TBR=rmistry@google.com
NO_MERGE_BUILDS

Change-Id: I466d173a1e93a05283617028be4d9d5e4fe601d5
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/261717
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
2019-12-29 06:10:44 +00:00
Chris Dalton
5a2f962313 Add back door support for GLSL tessellation shaders
Implements tessellation support at the Ganesh level, and adds back
door methods for supplying raw GLSL strings directly to the OpenGL
driver. Adds a new gm to verify tessellation is works in GL.

Change-Id: Idfc285b955cbe5e8e6bf0475be8b518b0cc6ed2c
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/261196
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Chris Dalton <csmartdalton@google.com>
2019-12-27 22:34:10 +00:00
Ravi Mistry
81158535ed Prevent de-duplication of Housekeeper-PerCommit-BuildTaskDrivers
Without this the task was getting deduped with tasks that ran days ago.
Eg: https://chromium-swarm.appspot.com/task?d=true&id=496142b461f15f10

Bug: skia:9514
Change-Id: I1c93e3f298ef5d6be222578618759b5fb63ca8c1
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/261555
Reviewed-by: Ravi Mistry <rmistry@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
2019-12-27 18:28:54 +00:00
Ravi Mistry
82462f237b Remove "-v2" from docker image names
Going to try to replace cloud build. I disabled the cloud build triggers
at https://pantheon.corp.google.com/cloud-build/triggers?project=skia-public

Bug: skia:9514
Change-Id: I6ac6e74f64fe5b1ecf33cea4b0fb7b53767b17a6
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/261548
Reviewed-by: Ravi Mistry <rmistry@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
2019-12-27 14:47:09 +00:00
Brian Osman
6a59754389 Actually update win_toolchain to 2019 (14.24.28314)
Change-Id: Ieb695288f2643a2959b76777d02af67ac49c245d
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/261544
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2019-12-26 21:59:52 +00:00
Brian Osman
f2d522a3f4 Update MSVC toolchain asset to 2019
This leaves the Win SDK at 10.0.17763.0 (I got errors when trying to
move to something newer).

It moves from VS 2017 to VS 2019 (14.16.27023), which fixes an internal
compiler error in recent ANGLE. We're also generally overdue for
switching to 2019, which has been released and stable for quite a while.

Docs-Preview: https://skia.org/?cl=261542
Change-Id: Iba15d52f558e92407866315681c2e99711c6d26a
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/261542
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2019-12-26 20:19:42 +00:00
Ravi Mistry
e19d055814 Add bots to push apps from skia/skia-wasm docker images
The DAG of tasks looks correct in trybot runs:
* PushAppsFromSkiaDockerImage : https://task-scheduler.skia.org/job/Mpjs8xzG975AtyXiqtjJ
* PushAppsFromWASMDockerImage : https://task-scheduler.skia.org/job/qrnzS6DZ764tXktCdT8U
* PushAppsFromSkiaWASMDockerImages : https://task-scheduler.skia.org/job/92nAAKGATVH141oDNtHI

Bug: skia:9514
Change-Id: I7b62a4f70e60f762844f0c5caea5607ce0826098
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/261536
Reviewed-by: Ravi Mistry <rmistry@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
2019-12-26 17:42:23 +00:00
skia-recreate-skps
ac29f1342f Update SKP version
Automatic commit by the RecreateSKPs bot.

TBR=rmistry@google.com
NO_MERGE_BUILDS

Change-Id: Ie6549664e29dcf2c8025c6112599da475c645751
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/261401
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
2019-12-22 06:10:41 +00:00
Kevin Lubick
2702dc77e0 Create code size treemaps for executable containing GL/Vulkan
DM is already available and should have GL or Vulkan backends in it.

Change-Id: Ie1dad639d0d20aae86ed8d8435c0787e15880767
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/261148
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Greg Daniel <egdaniel@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2019-12-20 15:01:16 +00:00
Ben Wagner
e6d31bd089 [infra] Use unbuffered I/O for run_recipe
This probably makes very little difference, but it might be helpful in
certain situations to see the unbuffered raw output.

Change-Id: Id0adf77ab3a8d0221d6dc8b7aea39fe9785b03dd
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/261137
Commit-Queue: Eric Boren <borenet@google.com>
Auto-Submit: Ben Wagner aka dogben <benjaminwagner@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2019-12-19 19:26:19 +00:00
Mike Klein
8fec4140f6 Reland "roll clang_win"
This is a reland of 3bf8e40537

Original change's description:
> roll clang_win
> 
> Change-Id: Ide83513b28ac982e24dcb73c9f5766df7531bc47
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/260810
> Reviewed-by: Brian Osman <brianosman@google.com>
> Commit-Queue: Mike Klein <mtklein@google.com>

Change-Id: I504db10e17e7b79284b1e222fb10a059801fedd4
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/260878
Reviewed-by: Mike Klein <mtklein@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
2019-12-18 21:03:22 +00:00
Mike Klein
4e7e6c5fe8 Revert "roll clang_win"
This reverts commit 3bf8e40537.

Reason for revert: -Werror in ANGLE.

Original change's description:
> roll clang_win
> 
> Change-Id: Ide83513b28ac982e24dcb73c9f5766df7531bc47
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/260810
> Reviewed-by: Brian Osman <brianosman@google.com>
> Commit-Queue: Mike Klein <mtklein@google.com>

TBR=mtklein@google.com,bsalomon@google.com,brianosman@google.com

Change-Id: I9215e596cd7b33944f2c1364dfedd3049a6bcbb4
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/260877
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
2019-12-18 18:45:15 +00:00
Mike Klein
3bf8e40537 roll clang_win
Change-Id: Ide83513b28ac982e24dcb73c9f5766df7531bc47
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/260810
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
2019-12-18 18:19:45 +00:00
Ravi Mistry
e6a2ad81ab Build and push skia-release and skia-wasm-release docker images
Bug: skia:9514
Change-Id: Ia76a2b233f87b4fc68010fdea8e942498b5986ed
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/260397
Reviewed-by: Joe Gregorio <jcgregorio@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
2019-12-18 13:29:55 +00:00
Robert Phillips
dd699690d0 Update SKP version (take 2)
Automatic commit by the RecreateSKPs bot.

TBR=rmistry@google.com
NO_MERGE_BUILDS

Reviewed-on: https://skia-review.googlesource.com/c/skia/+/260183
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Change-Id: I4cabaf580cfe2713128d9026762c25476e0aeafd
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/260402
Reviewed-by: Ravi Mistry <rmistry@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
2019-12-17 16:14:42 +00:00
Hal Canary
5d8b193868 fix build minimal_ios_mtl_skia_app
Change-Id: I9af324bec969a1f7feb84f8e5ea97b573c56694f
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/260396
Commit-Queue: Hal Canary <halcanary@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2019-12-16 19:44:36 +00:00
Hal Canary
efb4ed86cf SkMetalDeviceToGrContext: no longer needs any Skia headers
Also: mv experimental/skottie_ios tools/skottie_ios_app

Motivation:  make using SkMetalViewBridge that much easier for clients.

Change-Id: I985930ae0751d218e89c48c57b69d85ad7a1e703
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/259279
Reviewed-by: Hal Canary <halcanary@google.com>
Commit-Queue: Hal Canary <halcanary@google.com>
2019-12-16 18:09:40 +00:00
Eric Boren
397030ad04 Revert "Update SKP version"
This reverts commit 706eb5788e.

Reason for revert: Bad skp causing crashes

Original change's description:
> Update SKP version
> 
> Automatic commit by the RecreateSKPs bot.
> 
> TBR=rmistry@google.com
> NO_MERGE_BUILDS
> 
> Change-Id: Ic0889b3314f1d0c9853682da9de96e4fa574a7fc
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/260183
> Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
> Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>

TBR=rmistry@google.com,skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: I30cf1f796d983b8bc5171cfc1112e0b7eded8f0f
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/260256
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
2019-12-16 14:59:43 +00:00
skia-recreate-skps
706eb5788e Update SKP version
Automatic commit by the RecreateSKPs bot.

TBR=rmistry@google.com
NO_MERGE_BUILDS

Change-Id: Ic0889b3314f1d0c9853682da9de96e4fa574a7fc
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/260183
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
2019-12-15 08:12:45 +00:00
Kevin Lubick
c9b4d279d2 [infra] Update go to 1.13.5
Change-Id: I318e1a4d0cad258489ff25595cfc28b619317aac
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/259805
Reviewed-by: Ben Wagner aka dogben <benjaminwagner@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
2019-12-13 18:42:13 +00:00
Mike Klein
7c00778b20 roll clang to 9.0
Change-Id: Idd54caf1a9688a5de2fba08e8ae834f209aefc1c
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/242879
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
2019-12-11 22:35:35 +00:00
Ben Wagner
2ae348247a Update iOS provisioning profile.
Change-Id: I05172b01fb4a6baeac9a0a762537abd3fc5ad417
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/259163
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Auto-Submit: Ben Wagner aka dogben <benjaminwagner@google.com>
Reviewed-by: Kevin Lubick <kjlubick@google.com>
2019-12-11 12:54:42 +00:00
Mike Klein
1bb7e2378d test for c++17 w/ c++14 stdlib
Apparently some of our stdlibs are not even quite c++11 compliant.

Bug: skia:9700
Change-Id: I842c2dd2eba55d576aa60b2b3a4734dbace00f6b
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/259074
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
2019-12-10 22:22:30 +00:00
skia-recreate-skps
b60ec7f98b Update SKP version
Automatic commit by the RecreateSKPs bot.

TBR=rmistry@google.com
NO_MERGE_BUILDS

Change-Id: I0f920a066b8eaa15206f4257bb669630b1bba8de
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/258681
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
2019-12-08 17:04:58 +00:00
Ben Wagner
3af8955037 Add additional Mac Metal jobs
Add Perf testing for Metal on MacBookAir7,2 and MacMini7,1. Also run
Test Debug Metal on MacMini7,1.

Change-Id: Id1a457cd41dda1dee8fc6893e87a6701782b0b2e
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/258002
Commit-Queue: Jim Van Verth <jvanverth@google.com>
Auto-Submit: Ben Wagner aka dogben <benjaminwagner@google.com>
Reviewed-by: Jim Van Verth <jvanverth@google.com>
2019-12-05 16:08:42 +00:00
Eric Boren
7e9dc42228 [infra] Auto-submit the CL to update supported branch configs
Change-Id: Ib4baeec7dc7247b81c7e4a1ef7f85ef378e4be19
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/257621
Commit-Queue: Eric Boren <borenet@google.com>
Reviewed-by: Heather Miller <hcm@google.com>
Reviewed-by: Ben Wagner aka dogben <benjaminwagner@google.com>
2019-12-04 12:44:46 +00:00
Florin Malita
a4f1391bb9 Reland "[skottie] Remove defensive seek(0) from Animation ctor"
This reverts commit e0f374bf8f.

Reason for revert: including tracing fix
Original change's description:
> Revert "[skottie] Remove defensive seek(0) from Animation ctor"
>
> This reverts commit 042fe0847b.
>
> Reason for revert: SkottieTracing bots not happy.
>
> Original change's description:
> > [skottie] Remove defensive seek(0) from Animation ctor
> >
> > It potentially causes unnecessary image frame loads.
> >
> > Well-behaved clients should always seek() before calling render().
> >
> > Bug: skia:9686
> > Change-Id: If16257dc947941541d9ae8906b5ec7b1754dd7df
> > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/257625
> > Reviewed-by: Mike Reed <reed@google.com>
> > Commit-Queue: Florin Malita <fmalita@chromium.org>
>
> TBR=fmalita@chromium.org,reed@google.com,aparchur@google.com
>
> Change-Id: I3b7efdfc8e0aed1deb8756d585f946b4309d469d
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: skia:9686
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/257630
> Reviewed-by: Florin Malita <fmalita@chromium.org>
> Commit-Queue: Florin Malita <fmalita@chromium.org>

TBR=fmalita@chromium.org,reed@google.com,aparchur@google.com

Bug: skia:9686
Change-Id: Ib8a5d76821685cfa7e7dac61bcc31da5629d9055
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/257632
Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Florin Malita <fmalita@chromium.org>
2019-12-03 18:26:40 +00:00
skia-recreate-skps
fd0c257451 Update SKP version
Automatic commit by the RecreateSKPs bot.

TBR=rmistry@google.com
NO_MERGE_BUILDS

Change-Id: I5129dfa31a06c272ae1ce8a24988c0182201b923
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/257302
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
2019-12-01 08:15:09 +00:00
Ben Wagner
73beaaa48f [infra] Upgrade Radeon driver
Bug: skia:9652
Change-Id: Ie689762392206d8fa53460f30398d9980458e862
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/256356
Commit-Queue: Ben Wagner aka dogben <benjaminwagner@google.com>
Reviewed-by: Kevin Lubick <kjlubick@google.com>
2019-11-27 20:56:21 +00:00
Ben Wagner
bf46a27cdd [infra] Update Win10 in Skolo
The new driver in https://skia-review.googlesource.com/c/skia/+/256356
is unhappy with Win10 v1903, so updating to v1909.

Change-Id: Icb0f22a7e6af23835edea333f9b506b3896f46e6
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/256821
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Commit-Queue: Ben Wagner aka dogben <benjaminwagner@google.com>
2019-11-27 20:08:03 +00:00
Ben Wagner
c21705992f [infra] Upgrade NVIDIA driver
Bug: skia:9652
Change-Id: I5a8b1e4468daf7201effa866404fab8fbe312a77
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/256417
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Commit-Queue: Ben Wagner aka dogben <benjaminwagner@google.com>
2019-11-26 20:45:04 +00:00
Ben Wagner
616aa01b29 [infra] Upgrade Intel Skylake driver
Bug: skia:9652
Change-Id: I86da27902a22ae11f7b442e4a616d3127798f69a
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/256358
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Commit-Queue: Ben Wagner aka dogben <benjaminwagner@google.com>
2019-11-26 19:59:54 +00:00
Eric Boren
882115da6b [infra] Make CheckGeneratedFiles use Clang
Bug: skia:9675
Change-Id: Ie9fcd38a4d6c1e369bb2c3740de664a87d1a322c
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/256660
Reviewed-by: Herb Derby <herb@google.com>
Reviewed-by: Ben Wagner aka dogben <benjaminwagner@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
2019-11-26 18:04:44 +00:00
Ben Wagner
61169e9c47 Fix asset_utils when no service_account_json
Change-Id: I0524c96e3a6ab1a342872d5d0d903e87526dffeb
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/256230
Auto-Submit: Ben Wagner aka dogben <benjaminwagner@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2019-11-25 16:17:46 +00:00
Ben Wagner
6c4c685b2b Remove Debian9 GCC jobs and related code
Also update some recipe expectations to use job names that currently
exist.

Bug: skia:9632
Change-Id: I35883474a91ffb9fb2ab3b16089c7c80b5df0bd6
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/255982
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Commit-Queue: Ben Wagner aka dogben <benjaminwagner@google.com>
2019-11-24 23:51:04 +00:00
Kevin Lubick
241e81339b [skolo] Remove internal hardware 2
Bug: skia:7160, skia:9517
Change-Id: I5c00dca477de88bc46cbc12829a97fb36aed8f14
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/255979
Reviewed-by: Eric Boren <borenet@google.com>
Reviewed-by: Ben Wagner aka dogben <benjaminwagner@google.com>
2019-11-22 19:00:20 +00:00
Ravi Mistry
68e470de86 [G3 compile bot] Add comment to CL when there is an interesting failure
Also, create and use new service account for the G3 compile bots.

Interesting failure here refers to when the bot fails only because of
test failures and not:
* merge failures
* unknown failure reasons (eg: some flaky timeouts from the script running in borg)
* when the bot is not owned or approved by a Googler

NoTry: true
Bug: skia:9631
Change-Id: I964fd7874269116cca0e25d1b516283a00d5133f
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/254278
Commit-Queue: Ravi Mistry <rmistry@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2019-11-22 16:08:03 +00:00
Ben Wagner
4d3ac513db Add Docker-based GCC Test tasks
Since we've moved compilation to a Debian10 Docker container, the
resulting binaries won't run on Debian9 unless we also run them in a
Debian10 Docker container.

Test-Debian10-GCC-GCE-CPU-AVX2-x86-Debug-All-Docker failures are
tracked in skia:9664.

Bug: skia:9632, skia:9664
Change-Id: I97edc142cf558e30d11bd7bc3b5d1b423ba2418b
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/255152
Auto-Submit: Ben Wagner aka dogben <benjaminwagner@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Kevin Lubick <kjlubick@google.com>
2019-11-22 12:32:32 +00:00
Ben Wagner
0788481c63 Remove Build-Ubuntu18-GCC job
This partially reverts
https://skia-review.googlesource.com/c/skia/+/254797. The Ubuntu18 GCC
job was added in anticipation of using it for Valgrind jobs; however,
https://skia-review.googlesource.com/c/skia/+/255537 switches Valgrind
to Clang, which makes this unnecessary.

Bug: skia:9632
Change-Id: I97d7e0d4e3be109ae48b386140117aac4279618f
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/255790
Commit-Queue: Ben Wagner aka dogben <benjaminwagner@google.com>
Reviewed-by: Kevin Lubick <kjlubick@google.com>
2019-11-21 22:40:32 +00:00
Ben Wagner
bff12d60f6 [infra] Add service_account_json option to asset utils
Change-Id: If2686949009ba6fdf703ea794c0764c0e9966590
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/252261
Auto-Submit: Ben Wagner aka dogben <benjaminwagner@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Ben Wagner aka dogben <benjaminwagner@google.com>
2019-11-21 22:33:42 +00:00
Kevin Lubick
9c2b7cfe90 [canvaskit] Try some things to reduce GPU test flakiness
1) some flags that "The Internet" says may help
2) retry running the test script up to 3 times.

I wasn't able to reproduce the crashes with a non-Docker
Chrome, only in the Docker container, which was
very hard to debug.

Change-Id: I87f31c32f63b2770d8d5afa6a8e4b90c35dbf0bb
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/255820
Reviewed-by: Eric Boren <borenet@google.com>
Reviewed-by: Leandro Lovisolo <lovisolo@google.com>
2019-11-21 20:56:42 +00:00
Mike Klein
364506e999 build with Clang for Valgrind bots (take 2)
I had enough trouble merging that I've written a new CL.

This CL switches the Valgrind bots to Clang and resorts jobs.json.

Looks like we need to go back to limiting to SSE 4.1 when building with
Clang.  (We're much more aggressive about using AVX+ with Clang than we
were GCC.)

Change-Id: Ifbd3126a6ceb9b1c5ed0cf676d0f80d5457fce7e
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/255537
Commit-Queue: Mike Klein <mtklein@google.com>
Reviewed-by: Ben Wagner aka dogben <benjaminwagner@google.com>
2019-11-21 17:50:28 +00:00
Hal Canary
389c8e9d2d [minor] mark scripts as executable
if a filename ends with `.py` and  the file begins with '#!.*python.*',
make it executable.

Change-Id: I41de516ff37343d3b0979bde9fd61813aec7365c
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/254439
Commit-Queue: Hal Canary <halcanary@google.com>
Commit-Queue: Ben Wagner <bungeman@google.com>
Auto-Submit: Hal Canary <halcanary@google.com>
Reviewed-by: Ben Wagner <bungeman@google.com>
2019-11-21 17:06:27 +00:00
Leon Scroggins III
b5a4004a3e Add arm64 Wuffs perf bots
Bug: chromium:1023191
Bug: skia:8235

Chromium has detected a performance regression on the Nexus 5x when
switching to Wuffs. Benchmark Wuffs on Nexus 5x to help isolate and
fix the problem.

Change-Id: I36a13845ec83290d640263499ec4e5aca7b1239a
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/255080
Commit-Queue: Leon Scroggins <scroggo@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
Reviewed-by: Ben Wagner aka dogben <benjaminwagner@google.com>
2019-11-20 18:56:51 +00:00
Eric Boren
23f0b1512a [infra] Use CIPD packages from infra repo
Includes recipe hack because Kitchen introduced a directory level:
https://chromium-review.googlesource.com/c/infra/infra/+/1446288

Change-Id: I1afe43ea75964a2940e561f8d2bbfda3dd1f57e2
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/255256
Commit-Queue: Eric Boren <borenet@google.com>
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Ravi Mistry <rmistry@google.com>
2019-11-20 14:02:48 +00:00
Ben Wagner
f4fcbd4290 Add additional GCC Builds using Docker
Bug: skia:9632
Change-Id: If487a89a5750d6493bca3e841837a0a71b01c554
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/254797
Auto-Submit: Ben Wagner aka dogben <benjaminwagner@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Kevin Lubick <kjlubick@google.com>
2019-11-20 12:59:08 +00:00
Mike Klein
f4a0f57e30 drop sse4.1 limit on valgrind bots
I think we may not need this limit since 3.15.0 added f16c support.

Cq-Include-Trybots: skia.primary:Test-Ubuntu18-GCC-Golo-GPU-QuadroP400-x86_64-Release-All-Valgrind_PreAbandonGpuContext,Perf-Ubuntu18-GCC-Golo-GPU-QuadroP400-x86_64-Release-All-Valgrind,Test-Ubuntu18-GCC-Golo-GPU-QuadroP400-x86_64-Release-All-Valgrind,Test-Ubuntu18-GCC-Golo-GPU-QuadroP400-x86_64-Release-All-Valgrind_AbandonGpuContext
Change-Id: I4de547069ca0c77f2208c86f995496880df75d36
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/255342
Commit-Queue: Mike Klein <mtklein@google.com>
Reviewed-by: Ben Wagner aka dogben <benjaminwagner@google.com>
2019-11-20 02:00:08 +00:00
Ben Wagner
681a54e77b Use docker recipe module for Docker Build
Bug: skia:9632
Change-Id: I85e0314404105edf6044775d8ff2433104e2b59e
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/254969
Commit-Queue: Ben Wagner aka dogben <benjaminwagner@google.com>
Reviewed-by: Kevin Lubick <kjlubick@google.com>
2019-11-19 18:54:49 +00:00
Ben Wagner
51aabc94be Add Debian10 GCC Docker Build
Bug: skia:9632
Change-Id: I779fa02cd7227b4d68cc8b0d1c1781473ad0741d
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/254499
Commit-Queue: Ben Wagner aka dogben <benjaminwagner@google.com>
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Herb Derby <herb@google.com>
2019-11-19 18:50:29 +00:00
Ben Wagner
c5e528e15b Update Valgrind to 3.15.0.
Bug: skia:9632
Change-Id: Ide4a077fa9a4c2588e6c2561348b0bbb778e9f68
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/254976
Commit-Queue: Eric Boren <borenet@google.com>
Auto-Submit: Ben Wagner aka dogben <benjaminwagner@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2019-11-19 11:28:52 +00:00
Leon Scroggins III
a8ea23db00 Run nanobench on droids.gif
Bug: chromium:1023191
Bug: skia:8235

Chromium is showing a performance regression on this image when
switching to Wuffs. (It is checked into Chromium as
src/third_party/blink/perf_tests/image_decoder/resources/droids.gif.)
Test it on our bots to help us verify we've fixed it.

Change-Id: I9a02e6fe9bdcfa1704aefbc1ea2cd3f0e6ac4409
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/255081
Reviewed-by: Ben Wagner aka dogben <benjaminwagner@google.com>
Commit-Queue: Leon Scroggins <scroggo@google.com>
2019-11-18 18:47:19 +00:00
Ben Wagner
9c17be5301 [infra] Update docs with respect to Go modules.
Docs-Preview: https://skia.org/?cl=255085
Change-Id: I8911862ca9814b89b8598ad743b1faa9c524399f
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/255085
Commit-Queue: Ben Wagner aka dogben <benjaminwagner@google.com>
Commit-Queue: Joe Gregorio <jcgregorio@google.com>
Reviewed-by: Joe Gregorio <jcgregorio@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
Auto-Submit: Ben Wagner aka dogben <benjaminwagner@google.com>
2019-11-18 18:04:19 +00:00
skia-recreate-skps
cc1d4e6ae0 Update SKP version
Automatic commit by the RecreateSKPs bot.

TBR=rmistry@google.com
NO_MERGE_BUILDS

Change-Id: I1454920bff343474913e884d701664158c260f97
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/255043
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
2019-11-18 12:54:23 +00:00
John Rosasco
24cbdab97e SKQP Build for Fuchsia SDK
Change-Id: I2619784eca0f7a4dd66f2db0104cb746d9266b4e
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/244369
Commit-Queue: John Rosasco <rosasco@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
2019-11-18 12:34:28 +00:00
Mike Reed
2319b803c2 remove unused (by clients) SkMultiPictureDraw
More cleaning to do if we like this idea...

Change-Id: I608143db085911565dd5f5426f7ee6436ec58cdf
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/254680
Commit-Queue: Mike Reed <reed@google.com>
Reviewed-by: Robert Phillips <robertphillips@google.com>
2019-11-15 18:18:36 +00:00
Ravi Mistry
c95e54b558 Specify only luci buckets instead of hardcoding trybot names
I verified that this works

NoTry: true
Bug: skia:9639
Change-Id: Iacc0a865330c2049c8c124365122aa16c4493746
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/254676
Commit-Queue: Ravi Mistry <rmistry@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2019-11-14 21:11:58 +00:00
Mike Klein
066c3e5d4d add Release SkVMBlitter bot
Now that assert_true()  leads to different code generation
in Debug and Release builds, we should probably test both.

Cq-Include-Trybots: skia.primary:Test-Debian9-Clang-GCE-CPU-AVX2-x86_64-Debug-All-SK_USE_SKVM_BLITTER,Test-Debian9-Clang-GCE-CPU-AVX2-x86_64-Release-All-SK_USE_SKVM_BLITTER
Change-Id: Icd3b67f09d964becb595ce9c95e7ebadae8da9b2
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/253898
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
Auto-Submit: Mike Klein <mtklein@google.com>
2019-11-12 19:52:15 +00:00
skia-recreate-skps
11ac816acf Update SKP version
Automatic commit by the RecreateSKPs bot.

TBR=rmistry@google.com
NO_MERGE_BUILDS

Change-Id: I6bdffe1001d3422e1664009d10c1153bdcda0f7c
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/253866
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
2019-11-11 15:17:58 +00:00
Eric Boren
5676060b8c [infra] Remove Calmbench and ParentRevision bots
Change-Id: I760cf53928ce81403359f7af1486312fb1236d08
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/252931
Reviewed-by: Joe Gregorio <jcgregorio@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
2019-11-06 15:03:43 +00:00
Eric Boren
e2edfba592 [recipes] CanvasKit, PathKit, some others don't need bot_update
Bug: skia:9588
Change-Id: I8dc915f9cedd40b94f37f3d1ae89bb7d4767814f
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/252186
Commit-Queue: Eric Boren <borenet@google.com>
Reviewed-by: Kevin Lubick <kjlubick@google.com>
2019-11-05 18:46:34 +00:00
Ben Wagner
057985ad67 Fail Skpbench on unsupported hardware
Stop running Skpbench on unsupported hardware.

Change-Id: Iafde07d493dcccdd41dffea09255da68cf44afdb
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/252044
Commit-Queue: Ben Wagner aka dogben <benjaminwagner@google.com>
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Auto-Submit: Ben Wagner aka dogben <benjaminwagner@google.com>
2019-11-05 18:21:19 +00:00
Eric Boren
2697d14ac6 Reland "[recipes] Assert that Git is obtained from CIPD"
This reverts commit 491eba5f1d.

Reason for revert: Should be fixed

Original change's description:
> Revert "[recipes] Assert that Git is obtained from CIPD"
> 
> This reverts commit 6751f171c6.
> 
> Reason for revert: Missed at least one
> 
> Original change's description:
> > [recipes] Assert that Git is obtained from CIPD
> > 
> > Bug: skia:9538
> > Change-Id: I0e2bed991e099646c89fd87895851caf5d0734b8
> > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/251658
> > Reviewed-by: Kevin Lubick <kjlubick@google.com>
> > Commit-Queue: Eric Boren <borenet@google.com>
> 
> TBR=borenet@google.com,kjlubick@google.com
> 
> Change-Id: Ic90ae5672ce605f1667d7f961026303905824032
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: skia:9538
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/252190
> Reviewed-by: Eric Boren <borenet@google.com>
> Commit-Queue: Eric Boren <borenet@google.com>

TBR=borenet@google.com,kjlubick@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: skia:9538
Change-Id: I2dfbd66c75e6b41a5f63b3f89bf8988827a639d9
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/252480
Reviewed-by: Eric Boren <borenet@google.com>
Reviewed-by: Ravi Mistry <rmistry@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
2019-11-04 16:40:29 +00:00
Eric Boren
e99683ac6d [infra] Make SkottieWASM and LottieWeb use git from CIPD
Bug: skia:9588
Change-Id: Ie37eeae3a971d74edee50d87d96d452fad1b38a4
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/252476
Reviewed-by: Ravi Mistry <rmistry@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
2019-11-04 16:05:06 +00:00
skia-recreate-skps
4cc2dc64ff Update SKP version
Automatic commit by the RecreateSKPs bot.

TBR=rmistry@google.com
NO_MERGE_BUILDS

Change-Id: Ie683f87b64ffa456a8ec2f054e2f589d70f90359
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/252376
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
2019-11-03 08:37:13 +00:00
Eric Boren
491eba5f1d Revert "[recipes] Assert that Git is obtained from CIPD"
This reverts commit 6751f171c6.

Reason for revert: Missed at least one

Original change's description:
> [recipes] Assert that Git is obtained from CIPD
> 
> Bug: skia:9538
> Change-Id: I0e2bed991e099646c89fd87895851caf5d0734b8
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/251658
> Reviewed-by: Kevin Lubick <kjlubick@google.com>
> Commit-Queue: Eric Boren <borenet@google.com>

TBR=borenet@google.com,kjlubick@google.com

Change-Id: Ic90ae5672ce605f1667d7f961026303905824032
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: skia:9538
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/252190
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
2019-11-01 18:57:59 +00:00
Eric Boren
6751f171c6 [recipes] Assert that Git is obtained from CIPD
Bug: skia:9538
Change-Id: I0e2bed991e099646c89fd87895851caf5d0734b8
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/251658
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
2019-11-01 18:47:08 +00:00
Eric Boren
0509373cd5 [infra] Make CheckGeneratedFiles use git from CIPD
Bug: skia:9588
Change-Id: Idb80f1714865c2aa81615b8fc26afd591c3f4b24
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/252179
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
2019-11-01 18:43:47 +00:00
Eric Boren
2540704a38 [infra] Update git, make [Canvas|Path]Kit et al use git from CIPD
These docker-based tests don't actually need a checkout, but removing it
is proving time consuming and syncs are timing out.

Probably related to skia:9588

Bug: skia:9588
Change-Id: I39532f1d9cd1f6116fab341e648a517b98a312c2
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/252156
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
2019-11-01 13:40:23 +00:00
Ben Wagner
5b6ccbb6b5 [infra] Upgrade MacBookAir to 10.15.
Also add a NativeFonts GPU bot pending the availability of CPU bots
(https://bugs.chromium.org/p/chromium/issues/detail?id=1018242).

Change-Id: I16c19ae2e05be16b622c14289e255d0a342c0654
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/251817
Reviewed-by: Kevin Lubick <kjlubick@google.com>
2019-10-31 19:26:28 +00:00
Ben Wagner
ac65db506d Add Pixel4 jobs
Change-Id: Ic112266665f5ef3512a7904b181862ea2eb009b2
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/251816
Commit-Queue: Ben Wagner aka dogben <benjaminwagner@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Auto-Submit: Ben Wagner aka dogben <benjaminwagner@google.com>
Reviewed-by: Kevin Lubick <kjlubick@google.com>
2019-10-31 17:25:54 +00:00
recipe-roller
9dc47bffdb Roll recipe dependencies (nontrivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


Please review the expectation changes, and LGTM+CQ.


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/acfec855b3a03ad8c28df551c3ea7a6bbee75967 [file][cipd] Run YAPF (joshuaseaton@google.com)
  https://crrev.com/64c4a05dc93199fc5a8aca78f9427b09bd43776c [file] Add read text to presentation (joshuaseaton@google.com)
  https://crrev.com/1485ed120ff670c0b32905d28c824e7af6f32aa6 [cipd] Add CIPD UI link to register() presentation (joshuaseaton@google.com)


R=kjlubick@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: If102c0ccd69f1393348bd02d3619ed4b0b6b3d6b
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/251820
Commit-Queue: Eric Boren <borenet@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2019-10-31 13:45:53 +00:00
Hal Canary
014f540f70 BotsCfg/Perf/RemoteGlyphCache: bots to download and use traces
This runs the following benches in Perf-Android-*-CPU-* bots:
  - SkDiffBench-amazon
  - SkDiffBench-espn
  - SkDiffBench-googlecat
  - SkDiffBench-qq
  - SkDiffBench-taobao
  - SkDiffBench-wikicat
  - SkDiffBench-yahoo
  - SkDiffBench-youtube

CQ_INCLUDE_TRYBOTS=skia.primary:Perf-Android-Clang-NVIDIA_Shield-CPU-TegraX1-arm64-Release-All-Android

Change-Id: If8b51bd09cfb0bfcc04258bc68a94e1e4e24de90
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/251205
Commit-Queue: Hal Canary <halcanary@skia.org>
Reviewed-by: Kevin Lubick <kjlubick@google.com>
2019-10-29 22:24:54 +00:00
Michael Ludwig
b987862c86 Blacklist bulkrect benchmarks on chorizo
Change-Id: I487fb2e68de683301ce3d7ad19465b71d48c28e4
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/251249
Reviewed-by: Michael Ludwig <michaelludwig@google.com>
Commit-Queue: Michael Ludwig <michaelludwig@google.com>
2019-10-28 22:04:15 +00:00
Ravi Mistry
18f5b1a6dd [Android compile bots] Add comment to CL when both nopatch and withpatch builds fail
Also, create and use new service account for the Android compile bots.

NoTry: true
Bug: skia:9568
Change-Id: I974229a87f8c00bf6e4d0d5e49bbfdde6ca84e19
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/250978
Commit-Queue: Ravi Mistry <rmistry@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2019-10-28 14:55:01 +00:00
skia-recreate-skps
62160f2f35 Update SKP version
Automatic commit by the RecreateSKPs bot.

TBR=rmistry@google.com
NO_MERGE_BUILDS

Change-Id: Id8b4fbb9b89e64281fb67ef5d3d1a05166a3d2e3
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/251156
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
2019-10-27 08:52:26 +00:00
Hal Canary
60e7962ee9 Upload text blob traces as assets for the bots
Change-Id: I611cd923f21e73d6393678ceeb308626da2498a4
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/250816
Commit-Queue: Hal Canary <halcanary@google.com>
Reviewed-by: Herb Derby <herb@google.com>
2019-10-25 14:04:50 +00:00
Ravi Mistry
3ceaf8d1c8 Remove Perf LottieWeb_Canvas CPU/GPU bots
Context is in https://bugs.chromium.org/p/skia/issues/detail?id=9566#c6

NoTry: true
Bug: skia:9566
Change-Id: Ib4f7ecca7a789486c2aad00e7951542f37190f27
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/250977
Commit-Queue: Ravi Mistry <rmistry@google.com>
Reviewed-by: Ben Wagner aka dogben <benjaminwagner@google.com>
2019-10-25 14:01:00 +00:00
Ravi Mistry
7f5344a0a1 Move SkottieWASM/LottieWeb* GPU bots to Golo
NoTry: true
Bug: skia:9566
Change-Id: Id3d00a3dfbf4893170dabbfecb039c1f6736ec03
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/250976
Reviewed-by: Ben Wagner aka dogben <benjaminwagner@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
2019-10-25 13:37:20 +00:00
Ravi Mistry
d8c69b645b Make NUC7i5BNK SkottieWASM/Lottie_Web bots ON_DEMAND
NoTry: true
Bug: skia:9566
Change-Id: I8d8a993719065319e05b6adb91ed73585b37f7c5
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/250737
Commit-Queue: Ravi Mistry <rmistry@google.com>
Reviewed-by: Ben Wagner aka dogben <benjaminwagner@google.com>
2019-10-24 21:07:33 +00:00
Jim Van Verth
5a8f3e4aac Reland "Enable Programs (formerly GLPrograms) test for other APIs"
This is a reland of 598741667a

Original change's description:
> Enable Programs (formerly GLPrograms) test for other APIs
> 
> Bug: skia:9365
> Change-Id: I2eeac4e628425411b0a8f9ffa94ad61d58254b77
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/249806
> Reviewed-by: Robert Phillips <robertphillips@google.com>
> Reviewed-by: Eric Boren <borenet@google.com>
> Commit-Queue: Jim Van Verth <jvanverth@google.com>

Bug: skia:9365
Change-Id: I94db6cb2b1465edbb2e6d32708b835a76e12cbc6
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/250016
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Jim Van Verth <jvanverth@google.com>
2019-10-24 19:53:25 +00:00
Chris Dalton
6e38ce7c08 Disable msaa on Pixel3a
Bug: b/143074513
Change-Id: I1110ee542483b07b12e808bcd2decd6ce24f0a15
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/249920
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Chris Dalton <csmartdalton@google.com>
2019-10-23 20:25:17 +00:00
Eric Boren
a715ff5043 Use urllib_request instead of urllib2 in PRESUBMIT.
urllib_request was introduced in crrev.com/c/1866170 to add
python 3 compatibility.

Bug: 1009814
Change-Id: Iecc246d4f251983051bd0cf812903831ea7e0c2d
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/249588
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
2019-10-22 20:30:56 +00:00
Michael Ludwig
6387dc19f6 Revert "Enable Programs (formerly GLPrograms) test for other APIs"
This reverts commit 598741667a.

Reason for revert: segfaults on Pixel bots

Original change's description:
> Enable Programs (formerly GLPrograms) test for other APIs
> 
> Bug: skia:9365
> Change-Id: I2eeac4e628425411b0a8f9ffa94ad61d58254b77
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/249806
> Reviewed-by: Robert Phillips <robertphillips@google.com>
> Reviewed-by: Eric Boren <borenet@google.com>
> Commit-Queue: Jim Van Verth <jvanverth@google.com>

TBR=borenet@google.com,jvanverth@google.com,robertphillips@google.com

Change-Id: I286c637490bb8a21c0020a8935ce4c850b98f6b0
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: skia:9365
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/249978
Reviewed-by: Michael Ludwig <michaelludwig@google.com>
Commit-Queue: Michael Ludwig <michaelludwig@google.com>
2019-10-22 15:39:49 +00:00
Jim Van Verth
598741667a Enable Programs (formerly GLPrograms) test for other APIs
Bug: skia:9365
Change-Id: I2eeac4e628425411b0a8f9ffa94ad61d58254b77
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/249806
Reviewed-by: Robert Phillips <robertphillips@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Jim Van Verth <jvanverth@google.com>
2019-10-22 14:36:09 +00:00
Kevin Lubick
588e39a30e [canvaskit] Include CodeReviewSystem on JSON uploaded
Change-Id: Ie70a3a852fdae7d41ae8be4c7bb71d3cf9a5b55b
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/249805
Reviewed-by: Leandro Lovisolo <lovisolo@google.com>
2019-10-21 18:03:32 +00:00
skia-recreate-skps
d26e865f41 Update SKP version
Automatic commit by the RecreateSKPs bot.

TBR=rmistry@google.com
NO_MERGE_BUILDS

Change-Id: I8c9df362cbdc56534b6740fdc3827bf50443081e
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/249676
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
2019-10-20 08:44:19 +00:00
recipe-roller
7605c89c00 Roll recipe dependencies (nontrivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


Please review the expectation changes, and LGTM+CQ.


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
depot_tools:
  https://crrev.com/b594247e39a48445ccfc7e70678f97e1de451057 Reland "depot_tools: Run recipe scripts using vpython." (ehmaldonado@chromium.org)


R=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ie378193914415e50da479e1229afe85f66dbaba3
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/249292
Commit-Queue: Ravi Mistry <rmistry@google.com>
Reviewed-by: Ravi Mistry <rmistry@google.com>
2019-10-18 20:27:47 +00:00
Kevin Lubick
3085d9ac7d [canvaskit] Roll chrome version for testing
Also disabling failing perf test.

Change-Id: I5776a5dfba0d429ad6a9d725de26c585e61ba37b
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/249427
Reviewed-by: Hal Canary <halcanary@google.com>
2019-10-18 17:37:52 +00:00
Ben Wagner
63acfe3dd6 [infra] Retry failed pushes in Android flavor
It seems like we see quite a few "force quarantined" bots when pushing
resources to the device fails. Rewrite copy_directory_contents_to_device
to use the _adb method, which automatically retries.

Change-Id: Iae36f8e42e85a58fdddc8c9dc80e693a371fab8b
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/248560
Commit-Queue: Eric Boren <borenet@google.com>
Auto-Submit: Ben Wagner aka dogben <benjaminwagner@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2019-10-14 18:14:07 +00:00
skia-recreate-skps
a7e1b45d9c Update SKP version
Automatic commit by the RecreateSKPs bot.

TBR=rmistry@google.com
NO_MERGE_BUILDS

Change-Id: Ibd8d8778c7aa90affeceabcf426c094738f96c62
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/248459
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
2019-10-13 23:14:38 +00:00
Eric Boren
10367f81f7 [infra] Fix presubmit by pinning tools/build
Change-Id: I9f44062d43c8e6810247050521cdb4f450827d23
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/247961
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
2019-10-11 14:18:28 +00:00
Kevin Lubick
69537d7989 [skottie-perf] Remove beetle from list of tests
Change-Id: I8a92ec53224b4ce42afaf69fcdac9f5eff1deb61
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/247637
Reviewed-by: Ravi Mistry <rmistry@google.com>
2019-10-10 13:27:14 +00:00
Kevin Lubick
fa5a138170 [canvaskit] Update to build with emscripten 1.38.47
Bug: skia:9052
Change-Id: Ic1aec2c9b8ace556f5b77862582894f59fd26b64
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/247302
Reviewed-by: Kevin Lubick <kjlubick@google.com>
2019-10-09 15:08:10 +00:00
Greg Daniel
82e1145cd0 Also blacklist path_text benches on vulkan pixel3a.
Bug: skia:9413
Change-Id: I17b7629e1d2f8d24f8f3c7f4ecb4f788b3a41401
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/247039
Auto-Submit: Greg Daniel <egdaniel@google.com>
Reviewed-by: Ben Wagner aka dogben <benjaminwagner@google.com>
Commit-Queue: Greg Daniel <egdaniel@google.com>
2019-10-08 15:33:20 +00:00
Robert Phillips
0fb139607b Black list failing test(s) on internal bot
Bug: skia:9517
Change-Id: Iaf0a44056c6a893a8b64989edc2615fa5d9cdef8
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/247037
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
2019-10-08 14:54:30 +00:00
Ben Wagner
a6f07c5b5c Reland "Use integer patchset and issue variables."
This is a reland of 50b1248ed8

Fixes from the original are in PS2. Change several recipes to use the
shared 'is_trybot' variable, and explicitly check for 0 rather than
relying on patch_ref not being set.

Original change's description:
> Use integer patchset and issue variables.
>
> See https://skia-review.googlesource.com/c/buildbot/+/246397/
>
> Change-Id: I39dae809abdc63007f65bc05040809d1a870b118
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/246302
> Commit-Queue: Ben Wagner aka dogben <benjaminwagner@google.com>
> Reviewed-by: Eric Boren <borenet@google.com>

Change-Id: Ibe1d4f0dc1dc61c39eee6c980bd7509fc260101b
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/246919
Commit-Queue: Eric Boren <borenet@google.com>
Auto-Submit: Ben Wagner aka dogben <benjaminwagner@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2019-10-08 11:28:17 +00:00
Ben Wagner aka dogben
0943c92aab Revert "Use integer patchset and issue variables."
This reverts commit 50b1248ed8.

Reason for revert: Upload scripts are putting results in the wrong place.

Original change's description:
> Use integer patchset and issue variables.
> 
> See https://skia-review.googlesource.com/c/buildbot/+/246397/
> 
> Change-Id: I39dae809abdc63007f65bc05040809d1a870b118
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/246302
> Commit-Queue: Ben Wagner aka dogben <benjaminwagner@google.com>
> Reviewed-by: Eric Boren <borenet@google.com>

TBR=borenet@google.com,benjaminwagner@google.com

Change-Id: I2d93c16a6b57eebb3b01ddf0b9d67b21b56eaef9
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/246918
Reviewed-by: Ben Wagner aka dogben <benjaminwagner@google.com>
Commit-Queue: Ben Wagner aka dogben <benjaminwagner@google.com>
2019-10-07 23:28:28 +00:00
Ben Wagner
50b1248ed8 Use integer patchset and issue variables.
See https://skia-review.googlesource.com/c/buildbot/+/246397/

Change-Id: I39dae809abdc63007f65bc05040809d1a870b118
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/246302
Commit-Queue: Ben Wagner aka dogben <benjaminwagner@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2019-10-07 20:31:51 +00:00
skia-recreate-skps
a7d9c0d86c Update SKP version
Automatic commit by the RecreateSKPs bot.

TBR=rmistry@google.com
NO_MERGE_BUILDS

Change-Id: I65ef2dd3e984d2c6f9e0d9b17b476924688a7d7e
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/246682
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
2019-10-06 08:08:26 +00:00
Kevin Lubick
513109e9de Remove skiaserve as build output
Bug: skia:7399

Change-Id: I0cabc3c04f1b1af3277c35e2d16712d821be2c5b
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/246300
Reviewed-by: Ravi Mistry <rmistry@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
2019-10-04 16:41:19 +00:00
Kevin Lubick
9e951cd782 Reduce bandwidth to RPIs
PS1 refactors to make copying more explicit.

Change-Id: I35c3aecd10bbdb5ab2a462c72b062d979f48fce8
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/246099
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Ben Wagner aka dogben <benjaminwagner@google.com>
2019-10-04 14:50:49 +00:00
Ravi Mistry
d46ffc59a2 Remove always red SK_SUPPORT_LEGACY_CLIPTOLAYERFLAG bot and it's builder
IIUC, the flag is no longer used.

Bug: skia:9482
Change-Id: I6c4c327423f0a356151fe0a15c45c6923deac147
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/246316
Reviewed-by: Ravi Mistry <rmistry@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
2019-10-04 13:44:49 +00:00
Brian Salomon
7a90175f56 Half float tests working on command buffer
Bug: chromium:697030
Change-Id: I3ca52213edf933abb58023a44daf8533e68a4715
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/245618
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
2019-10-02 18:18:23 +00:00
Mike Klein
1e9112fbb4 roll mips toolchain to gcc 8
Just like https://skia-review.googlesource.com/c/skia/+/118681/,
but one more, and...

   - GCC now needs libisl19
   - more warnings to stifle... disable warnings-as-errors.

Cq-Include-Trybots: skia.primary:Build-Debian9-GCC-mips64el-Debug,Build-Debian9-GCC-mips64el-Release
Change-Id: I35c2f71caebb47bd1bd253923cbddbe3f9b95477
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/245352
Reviewed-by: Ravi Mistry <rmistry@google.com>
Reviewed-by: Ben Wagner aka dogben <benjaminwagner@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
2019-10-01 16:51:18 +00:00
Ben Wagner
35048fab8a Add iPhone8 jobs
Bug: skia:8271
Change-Id: I51494eb84329b54a5429add74e2b7ded7731eb30
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/244637
Commit-Queue: Eric Boren <borenet@google.com>
Auto-Submit: Ben Wagner aka dogben <benjaminwagner@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2019-09-30 16:02:14 +00:00
Ben Wagner
076c50cc00 Use CIPD package for iOS provisioning profile.
Docs-Preview: https://skia.org/?cl=244996
Bug: skia:8271
Change-Id: I94e15138918e224221baa7a8a2829e05e938fa8d
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/244996
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Ben Wagner aka dogben <benjaminwagner@google.com>
2019-09-30 15:47:19 +00:00
skia-recreate-skps
bbdcfe9660 Update SKP version
Automatic commit by the RecreateSKPs bot.

TBR=rmistry@google.com
NO_MERGE_BUILDS

Change-Id: I18f2d492166021b2349e91cc8688b7d639bf63ec
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/245051
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
2019-09-29 10:58:44 +00:00
Ben Wagner
097e1c6594 Switch to device_type dimension for iOS devices
Change-Id: Ia71228659b18233e8734658a12ea6839aaf71747
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/244719
Auto-Submit: Ben Wagner aka dogben <benjaminwagner@google.com>
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Commit-Queue: Ben Wagner aka dogben <benjaminwagner@google.com>
2019-09-27 17:37:15 +00:00
Jim Van Verth
95df613ed1 Remove MoltenVK configs from the bots.
With Metal up and running these are no longer needed.

Change-Id: I79948707060afc3a9d2d3a4d531a7d3e5d08298d
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/243696
Commit-Queue: Jim Van Verth <jvanverth@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2019-09-24 17:00:03 +00:00
Greg Daniel
a18173b3ee Fix TEST_BUILDER name in perf recipe.
Change-Id: Ia27920f405db6db09d1519134526e6a120bd1f4c
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/243425
Commit-Queue: Greg Daniel <egdaniel@google.com>
Commit-Queue: Ben Wagner aka dogben <benjaminwagner@google.com>
Auto-Submit: Greg Daniel <egdaniel@google.com>
Reviewed-by: Ben Wagner aka dogben <benjaminwagner@google.com>
2019-09-23 19:03:13 +00:00
Greg Daniel
86fce3f417 Remove Vulkan Nexus5x bot.
The 5x vulkan driver is starting to show a lot of its bugs that are becoming
a pain to work around for testing. Since the driver will probably not be updated
on this device so we wouldn't ship vulkan on it, I am removing it from our test
pool.

Bug: skia:9124
Bug: skia:9027
Bug: skia:9271
Change-Id: I89166af19f77c3c00a1f877dc4fe78596bbfa9c9
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/243422
Commit-Queue: Greg Daniel <egdaniel@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
2019-09-23 18:08:02 +00:00
skia-recreate-skps
8b9de72766 Update SKP version
Automatic commit by the RecreateSKPs bot.

TBR=rmistry@google.com
NO_MERGE_BUILDS

Change-Id: I348f7b8a746e23fc7dc17beb591302c49cab1a67
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/243266
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
2019-09-22 18:08:26 +00:00
Hal Canary
4119443532 experimental/skottie_ios: Skottie iOS/Metal App
To use, see instructions in experimental/skottie_ios/README.md .

No-Try: true
Change-Id: I4fb71576c5e38c7776d14561930b8c2598cfb48f
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/240284
Commit-Queue: Hal Canary <halcanary@google.com>
Reviewed-by: Jim Van Verth <jvanverth@google.com>
2019-09-16 19:10:24 +00:00
Hal Canary
3388c1a15e gn: split out iOS templates to gn/ios.gni
motivation:  BUILD.gn os too big, also can be reused in modules.

Also: add a BUILD.gn for minimal_ios_mtl_skia_app that uses the
template.

CQ_INCLUDE_TRYBOTS=skia.primary:Build-Mac-Clang-arm64-Debug-iOS_Metal,Build-Mac-Clang-arm64-Release-iOS,Test-iOS-Clang-iPhone7-GPU-PowerVRGT7600-arm64-Debug-All-Metal,Test-iOS-Clang-iPhone6-GPU-PowerVRGX6450-arm64-Release-All

Change-Id: I70ebb9668cce51ea9fa671a3d8c93041fbedcbfa
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/241761
Commit-Queue: Jim Van Verth <jvanverth@google.com>
Reviewed-by: Jim Van Verth <jvanverth@google.com>
Auto-Submit: Hal Canary <halcanary@google.com>
2019-09-16 18:49:24 +00:00
Brian Osman
4af42fcca1 Fix precompiling shaders on GLES / Android
We need to specify attribute locations and (sometimes) frag shader
output locations. Desktop GL worked fine without this, but Flutter
ran into this problem, and a Pixel 2 reproduced the issue.

Note that both APIs (BindFragDataLocation and BindAttribLocation)
don't take effect until the next time the program is linked, so
we have to relink the program after applying those changes.

I was afraid that re-linking would eliminate the perf benefits of
pre-compiling the shaders, but (at least on Pixel 2) that's not
the case. I traced the life of a single program, and the initial
link (during precompile) was 4.4 ms. The re-link took 0.23 ms.

Change-Id: Iadb3b425a8cf9f6a52e015c2e37f875c0fd73d6d
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/241758
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2019-09-16 17:13:23 +00:00
skia-recreate-skps
cb52badca0 Update SKP version
Automatic commit by the RecreateSKPs bot.

TBR=rmistry@google.com
NO_MERGE_BUILDS

Change-Id: I99fa92a361bee1ce98242c2b61a1ad4fb7705319
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/241668
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
2019-09-15 08:21:11 +00:00
Ben Wagner
5a2ba9996b Omit path_text benches on Pixel3a
Bug: skia:9413
Change-Id: If64176e0f5553077179479df0ec11767391eaaa9
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/240876
Auto-Submit: Ben Wagner aka dogben <benjaminwagner@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
2019-09-12 02:51:08 +00:00
Brian Salomon
7c8c67ec80 Blacklist InitialTextureClear on TecnoSpark3Pro
Change-Id: I28be8b0d6c21cfea662e7bb234ea4962b6612d40
Bug: skia:9421
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/240796
Commit-Queue: Brian Salomon <bsalomon@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
Auto-Submit: Brian Salomon <bsalomon@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
2019-09-11 21:22:09 +00:00
Ben Wagner
3f44902450 Omit benches that time out on Pixel3a
I failed to notice the failing tryjob on
https://skia-review.googlesource.com/c/skia/+/240557

Bug: skia:9413
Change-Id: Iffb83d7210e08107eadee8ffd47158cce3078a1d
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/240682
Commit-Queue: Mike Klein <mtklein@google.com>
Auto-Submit: Ben Wagner aka dogben <benjaminwagner@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
2019-09-11 17:34:43 +00:00
Ben Wagner
ba36ee7826 Update to XCode 10.3
Bug: skia:9194
Change-Id: Ideecb40fc4f30a8ffac64877431332886d95045a
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/230578
Auto-Submit: Ben Wagner aka dogben <benjaminwagner@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Ben Wagner aka dogben <benjaminwagner@google.com>
2019-09-11 17:00:13 +00:00
Ben Wagner
d96ef09317 Add Pixel3a (sargo) jobs
Change-Id: I9fc907efc12105195d0256e00657091b3e5f20fb
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/240557
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Auto-Submit: Ben Wagner aka dogben <benjaminwagner@google.com>
2019-09-11 11:45:43 +00:00
Oliver Newman
c13cb6e624 Handle output placeholder missing backing file
In preparation for this CL:
https://chromium-review.googlesource.com/c/infra/luci/recipes-py/+/1777143

Currently, if no test step data is provided for a step that uses an
output placeholder, the placeholder evaluates to an empty string. After
that CL lands, the placeholder will instead evaluate to None, breaking
any non-mocked code that assumes a non-null placeholder result.

There were dozens of places where these env var fetches would've needed
mocking, so I figured it was easier to just silently handle the case
where the placeholder backing file doesn't exist. Especially for trivial
cases like these environment variable fetches where the backing file is
a temporary file created just for that step (no `leak_to` argument
specified), it should be impossible for the backing file to not exist
unless you're doing some really weird stuff.

Change-Id: Ibb646142ee8471b2444f54fe78c640a94d18a607
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/240663
Commit-Queue: Eric Boren <borenet@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2019-09-11 11:16:33 +00:00
Brian Salomon
b2d5d40a33 Adapt GrRectBlur for cases with rect W/H less than six sigma.
Add GM that generates reference blur rect images and compares against
actual.

Change-Id: If0ce291e211fefe96af8afdf0a60636b5f40ef47
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/239757
Commit-Queue: Brian Salomon <bsalomon@google.com>
Reviewed-by: Robert Phillips <robertphillips@google.com>
2019-09-10 14:39:07 +00:00
recipe-roller
a47836e01a Roll recipe dependencies (nontrivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


Please review the expectation changes, and LGTM+CQ.


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/f362dc019e5cedc0e5ce334039a16afcbc95dcb4 Reland "[fileutil] Add support for recursive glob" (atyfto@google.com)


R=kjlubick@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I3c1a79eb1f1fc8a23bf02ac25f17b8673d7dd199
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/240416
Commit-Queue: Eric Boren <borenet@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2019-09-10 11:50:47 +00:00
Ben Wagner
2d0f1a86fe [infra] Switch Mac builders to 10.14.6.
Bug: skia:9194
Change-Id: I33acb878528c461f51989f2a65df7b33ea38f2a7
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/240277
Commit-Queue: Eric Boren <borenet@google.com>
Auto-Submit: Ben Wagner aka dogben <benjaminwagner@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2019-09-10 11:09:17 +00:00
Robert Iannucci
0a42768997 Remove use of deprecated tempfile module in skia.
The lack of 'rmfile' steps is OK because all of the temporary paths
are created within swarming's sandbox; swarming will clean everything
up after the recipe has quit.

R=borenet@google.com

Change-Id: Ibb8dc612ec8eb98fe966c9caa90ba59db48dbfba
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/239797
Auto-Submit: Robbie Iannucci <iannucci@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2019-09-07 01:43:49 +00:00
Ben Wagner
3805613933 [infra] Update Mac 10.14 bots to 10.14.6
Bug: chromium:989139
Change-Id: I556c34d53bf5e58ab4975284650dd73f48eb9755
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/239927
Reviewed-by: Ben Wagner aka dogben <benjaminwagner@google.com>
Commit-Queue: Ben Wagner aka dogben <benjaminwagner@google.com>
2019-09-06 22:36:20 +00:00
Brian Osman
ed58e004e0 Add support for pre-compiling cached SkSL shaders
The client can do a test run of their application with
a persistent cache set to SkSL mode. They store the key
and data blobs that are produced.

Ship those blobs with the application. At startup, call
GrContext::precompileShader for each key/data pair. This
compiles the shaders, and stores the GL program ID, plus
a small amount of metadata in our runtime program cache.

Caveats:
* Currently only implemented for the GL backend. Other
  backends will require more metadata to do any useful
  amount of work. Metal may need a more drastic workflow
  change, involving offline compilation of the shaders.
* Currently only implemented for cached SkSL (not GLSL
  or program binaries). Supporting other formats again
  requires more metadata, and the cached shaders become
  increasingly specialized to GPU and driver versions.
* Reusing the cached SkSL on different hardware is not
  supported. Many driver workarounds are implemented in
  the SkSL -> GLSL transformation, but some are higher
  level. Limiting device variance by artificially hiding
  extensions may help, but there are no guarantees.

* The 'gltestprecompile' DM config exercises this code
  similarly to 'gltestpersistentcache', ensuring that
  results are visually identical when precompiling, and
  that no cache misses occur after precompiling.

Change-Id: Id314c5d5f5a58fe503a0505a613bd4a540cc3589
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/239438
Reviewed-by: Greg Daniel <egdaniel@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2019-09-06 19:45:09 +00:00
skia-recreate-skps
59ed3b9880 Update SKP version
Automatic commit by the RecreateSKPs bot.

TBR=rmistry@google.com
NO_MERGE_BUILDS

Change-Id: I11b04e87d75eb0043c94fe481c2dcd913b398003
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/239583
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
2019-09-05 20:51:02 +00:00
Ravi Mistry
04ceda5e58 Allow PRIVATE_SKPS_GS to be empty in assets/skp/create.py
NoTry: true
Change-Id: I9dd3ef35812f3a2c6d3c51627f908d3f9d939bda
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/239441
Reviewed-by: Ravi Mistry <rmistry@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
2019-09-05 17:24:35 +00:00