Commit Graph

60838 Commits

Author SHA1 Message Date
Robert Phillips
6e0a205f80 [graphite] Expand capabilities of SkCombinationsBuilder
This CL adds the ability to add child combinations to the top-level
combinations added to the builder.

Bug: skia:12701
Change-Id: Ibe182c631bb9811d82e314ba58823b1708058165
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/542299
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
2022-06-03 13:29:50 +00:00
Kevin Lubick
4ff73144c3 [infra] Remove CheckGeneratedBazelFiles job
The job had been removed from jobs.json previously. We no
longer intend to generate Bazel files using gazelle, which
is what this checked.

Change-Id: I1bcf98deae3831a18b9a70e4f0a295eb3f2785b8
Bug: skia:12541
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/546137
Reviewed-by: Eric Boren <borenet@google.com>
Reviewed-by: Ravi Mistry <rmistry@google.com>
2022-06-03 13:02:15 +00:00
Leandro Lovisolo
6a00ee05ff [gcs_mirror] Add support for URLs ending with ".tgz".
This was necessary to mirror https://binaries.cockroachdb.com/cockroach-v21.1.9.linux-amd64.tgz in https://skia-review.googlesource.com/c/buildbot/+/546543.

Bug: skia:13293
Change-Id: Ib6d5db6864bd82f51321a44d5f15410d37d92ff7
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/546541
Auto-Submit: Leandro Lovisolo <lovisolo@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Kevin Lubick <kjlubick@google.com>
2022-06-03 11:51:43 +00:00
skia-autoroll
b9be86b038 Roll vulkan-deps from ef513cbf195c to e94c0d48eb5a (4 revisions)
https://chromium.googlesource.com/vulkan-deps.git/+log/ef513cbf195c..e94c0d48eb5a

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-skia-autoroll
Please CC bungeman@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in skia: https://bugs.chromium.org/p/skia/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Build-Debian10-Clang-x86_64-Debug-Dawn;skia/skia.primary:Build-Debian10-Clang-x86_64-Release-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE
Bug: None
Tbr: bungeman@google.com
Change-Id: I5648f7dc471f13079cb86b3aa11a4844130fe0fb
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/546373
Bot-Commit: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2022-06-03 11:17:01 +00:00
skia-autoroll
74949fc4c2 Roll ANGLE from e04314fd8f19 to 53ec886e412e (9 revisions)
e04314fd8f..53ec886e41

2022-06-03 syoussefi@chromium.org Vulkan: Externally synchronize the pipeline cache
2022-06-02 kpiddington@apple.com Metal shaders fail to compile with "error: unknown type name 'uint'
2022-06-02 b.schade@samsung.com Vulkan: Add feature to use VK_FILTER_LINEAR for YUVConversionInfo
2022-06-02 gert.wollny@collabora.com Capture/Replay: support capturing eglCreateImage/eglDestroyImage
2022-06-02 syoussefi@chromium.org Vulkan: Suppress forced-xfb-emulation tests on pixel 6
2022-06-02 gman@chromium.org Metal: Validate total bits used in color attachments
2022-06-02 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 466e443100e6 to ee0d0b41a626 (2 revisions)
2022-06-02 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from f6e0343d6b36 to 795b7900dc69 (491 revisions)
2022-06-02 kbr@chromium.org Uptream Vivante and VMWare vendor ID recognition.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-skia-autoroll
Please CC bungeman@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Build-Debian10-Clang-x86_64-Release-ANGLE;skia/skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC8i5BEK-GPU-IntelIris655-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE
Tbr: bungeman@google.com
Change-Id: I929991ccf737a4b5694791cb81e06306a946da30
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/546366
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2022-06-03 05:51:35 +00:00
skia-autoroll
3789354a30 Roll SwiftShader from 1bf3ae22a00d to 19e3080dfe86 (9 revisions)
https://swiftshader.googlesource.com/SwiftShader.git/+log/1bf3ae22a00d..19e3080dfe86

2022-06-02 srisser@google.com Move SIMD::Pointer to rr::Pointer4
2022-06-02 sugoi@google.com Remove unused allocateZero function
2022-06-02 sugoi@google.com Merge changes I988caf15,I62185327
2022-06-02 sugoi@google.com Fix early fragment tests
2022-06-02 sugoi@google.com Compute occlusion sample count early when using earlyFragmentTests
2022-06-02 sugoi@google.com Write stencil early when using earlyFragmentTests
2022-06-02 sugoi@google.com PixelRoutine::stencilOperation() refactor
2022-06-02 sugoi@google.com Return value refactor for stencilOperation()
2022-06-02 srisser@google.com Extend SIMD::Pointer to use multiple full pointers

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-skia-autoroll
Please CC bungeman@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Test-Debian10-Clang-GCE-GPU-SwiftShader-x86_64-Debug-All-SwiftShader
Bug: None
Tbr: bungeman@google.com
Change-Id: Ib28e9c3c155ce240bef6a990a92285fcfa85dbc0
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/546367
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2022-06-03 04:46:36 +00:00
Arman Uguray
02031e67d0 [sksl][wgsl] Support WGSL in SkSLMemoryLayout
- SkSLMemoryLayout now handles WGSL uniform and storage address space
  memory alignment and size calculations.
- MemoryLayout::IsSupported is now an instance method that checks for
  type support based on the specified language standard.
- Unit tests have been added for WGSL memory layout types.

Bug: skia:13092
Change-Id: I2fe161998a0b551ca7c3c1d118b6a8cc1ae95a5b
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/545398
Reviewed-by: John Stiles <johnstiles@google.com>
Commit-Queue: Arman Uguray <armansito@google.com>
2022-06-03 00:40:12 +00:00
skia-autoroll
81737585ff Roll vulkan-deps from 7ab4802b330f to ef513cbf195c (5 revisions)
https://chromium.googlesource.com/vulkan-deps.git/+log/7ab4802b330f..ef513cbf195c

Also rolling transitive DEPS:
  https://skia.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools from b930e734ea19 to c94501352d54
  https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers from 245d25ce8c33 to 3ef4c97fd6ea
  https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools from dd7e8d2fbbda to ef9db7a8ec52

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-skia-autoroll
Please CC bungeman@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in skia: https://bugs.chromium.org/p/skia/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Build-Debian10-Clang-x86_64-Debug-Dawn;skia/skia.primary:Build-Debian10-Clang-x86_64-Release-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE
Bug: None
Tbr: bungeman@google.com
Change-Id: I1ba9262b5a2579c377414815f88849ec4cc04e66
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/546363
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2022-06-02 22:38:03 +00:00
John Stiles
8ad66c2340 Migrate Analysis::IsTrivialExpression to its own cpp.
In a followup, I'll be making changes to this algorithm for skia:13378.
This CL migrates the code as-is.

Change-Id: I86cfddeb7c8eb6d4e191371944fb7c3707f13ba6
Bug: skia:13378
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/546418
Auto-Submit: John Stiles <johnstiles@google.com>
Reviewed-by: Arman Uguray <armansito@google.com>
Commit-Queue: John Stiles <johnstiles@google.com>
2022-06-02 20:39:08 +00:00
Herb Derby
fed5f770d3 Cleanup includes and forwards for TextBlob, etc.
Change-Id: I3ea9261457b1c7ff28fa159ac91ae2d788fc1470
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/546108
Commit-Queue: Herb Derby <herb@google.com>
Reviewed-by: Robert Phillips <robertphillips@google.com>
2022-06-02 19:49:09 +00:00
Kevin Lubick
d0519f1219 [bazel] Add Presubmit exception for public.bzl
Change-Id: I75a0adb334dc23d81e5861112e24d36ed0ddf4af
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/546497
Reviewed-by: John Stiles <johnstiles@google.com>
2022-06-02 19:45:05 +00:00
Kevin Lubick
d39593de31 [bazel] Fix presubmit to properly ignore missing buildifier
Change-Id: I27ecb7f9a9a8f407cfd257a2d421ed8044ae6e71
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/546496
Reviewed-by: John Stiles <johnstiles@google.com>
2022-06-02 19:23:25 +00:00
John Stiles
37b5f3b164 Replace optional<DSLType> with null.
DSLType is now a simple wrapper around SkSL::Type*. Previously, its type
was determined through a combination of a Type* and a TypeConstant enum,
and fSkSLType == nullptr was used as a sentinel to mean "use the type
constant instead", which meant that we couldn't have a null DSLType
as it would fall back to the type-constant.

We can now return `DSLType(nullptr)` to indicate an error case in type
handling code, instead of needing to wrap the DSLType in an optional<>.

Change-Id: Iebaab86162b526a7fcb93d253367a7e4881ef6d0
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/545781
Auto-Submit: John Stiles <johnstiles@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: John Stiles <johnstiles@google.com>
2022-06-02 18:28:56 +00:00
Kevin Lubick
29a8e48613 [canvaskit] Deploy v0.34.1
Change-Id: I978a33e6827a00701a51a818cc43e864e1645af3
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/546416
Reviewed-by: Joe Gregorio <jcgregorio@google.com>
2022-06-02 17:41:31 +00:00
Ben Wagner
6886d924a0 Add SubRunContainer to public.bzl
Missed this particular build in "Move SubRunContainer to its own .h
and .cpp" [0][1].

[0] https://skia-review.googlesource.com/c/skia/+/545776
[1] d881def3e5

Change-Id: Icabef047b5397d1ba29237ecdd3e2dfa39e43205
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/546111
Reviewed-by: Kevin Lubick <kjlubick@google.com>
2022-06-02 17:13:36 +00:00
Ben Wagner
fda62fdd83 Roll FreeType from b98dd169 to c26872ed (4 commits)
b98dd169a1..c26872ed59

Change-Id: I9338be245358974d9f6bb9bc92e99f01d3398a16
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/546110
Reviewed-by: Herb Derby <herb@google.com>
Commit-Queue: Ben Wagner <bungeman@google.com>
2022-06-02 17:12:12 +00:00
Herb Derby
c2fac25c6e Remove redundant positionMatrix in TextBlob
Change-Id: I3f913a37e261d2b0916b7f8d15f26c4ec809827f
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/546107
Commit-Queue: Herb Derby <herb@google.com>
Reviewed-by: Robert Phillips <robertphillips@google.com>
2022-06-02 16:51:41 +00:00
Herb Derby
d881def3e5 Move SubRunContainer to its own .h and .cpp
Move SubRunContainer, and all the associated classes used by it.

Change-Id: Ib61787f1e8442f0f8cc1354fbc04a867e3b6c670
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/545776
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Herb Derby <herb@google.com>
2022-06-02 15:53:31 +00:00
John Stiles
9f85e0e12d Further reduce the size of DSLType.
DSLType stored an `fPosition` which was only used in one place, when
reporting that a function is not allowed to return a particular type.
Those errors now highlight the type and function name together, which is
not really any worse than before. This allows us to shrink DSLType down
to its minimal form, just a pointer to an SkSL::Type and nothing else.

Change-Id: I4b430cb996472da0ae57bc2ab095cd123d2c3f51
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/546097
Commit-Queue: John Stiles <johnstiles@google.com>
Auto-Submit: John Stiles <johnstiles@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
2022-06-02 14:02:29 +00:00
John Stiles
a98b3a1f0c Reduce the size of DSLType.
This CL removes the TypeConstant member from DSLType. The constructor
which takes a TypeConstant now sets the `fSkSLType` field immediately
instead of saving the value and deferring lookup until `skslType()` is
called.

This caused some ripple-effect issues in type setup code which were
fixable by replacing nullptr with Poison.

Change-Id: I8fa73cdf5f0bcd3de143c9a25ea43392d75c7dec
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/545780
Reviewed-by: Brian Osman <brianosman@google.com>
Auto-Submit: John Stiles <johnstiles@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2022-06-02 14:02:23 +00:00
Kevin Lubick
f64f211283 [bazel] Use pre-built taskdriver for faster BazelBuild jobs
With a hot Bazel cache, https://task-scheduler.skia.org/job/4XhwJfG1wR38Hp3dF1pI
took 59 seconds and did not have to wait 1-2 minutes
for TaskScheduler to schedule a prerequisite task
and Swarming to deduplicate said task, which is
the best case scenario for "all hot caches".

Change-Id: Ic86599e0b886ecded836641cceb19b623065a91e
Bug: skia:12541
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/546136
Reviewed-by: Eric Boren <borenet@google.com>
2022-06-02 13:46:53 +00:00
Robert Phillips
cb8e5b28f0 Remove MSVC __popcnt intrinsic special casing
MSVC is a very marginal compiler for us (and we don't call SkPopCount that often) so we've deemed it not worth the extra complexity to handle the __popcnt intrinsic.

Change-Id: I1d838727eab503cd99a72d07e9787280d0948b29
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/545896
Commit-Queue: Robert Phillips <robertphillips@google.com>
Reviewed-by: Herb Derby <herb@google.com>
Reviewed-by: John Stiles <johnstiles@google.com>
2022-06-02 13:43:32 +00:00
Ian Prest
18fdfe83a5 Add SkSurfaceProps parameter to several APIs
In general, SkSurfaceProps is only needed when rendering text.  However,
there are several existing APIs that don't allow SkSurfaceProps to be
passed in by the user.

This change adds new SkSurfaceProps parameters to several public-facing
APIs:
  1. SkRasterHandleAllocator::MakeCanvas
  -- The props are used by the canvas whenever text is rendered.

  2. SkImage::MakeFromPicture and SkImageGenerator::MakeFromPicture
  -- The props are used to render any text in the SkPicture object.

Change-Id: Ic48e8a30bb12b3170415c644de1a007b5eefb818
Bug: skia:13369
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/545396
Reviewed-by: Ben Wagner <bungeman@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2022-06-02 13:12:33 +00:00
Kevin Lubick
455addeff6 [bazel] Add 4 CI jobs, 1 CQ job to test Bazel builds
Needed to fix the Dawn and Harfbuzz Bazel rules.

Change-Id: I21f63c970bdc972b97e42ef85d82d7f478bd45e2
Bug: skia:12541
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/545721
Reviewed-by: Eric Boren <borenet@google.com>
2022-06-02 12:36:28 +00:00
Kevin Lubick
ee62fad9a4 [bazel] Add "skia_internal" target that exposes private API for tests/tools.
Organization v3.5, if we are keeping track :)

This splits the "srcs" filegroup into "srcs" and "private_hdrs",
and renames "hdrs" to "public_hdrs".

To assist with the split, I created the macro split_srcs_and_hdrs.
Rather than keep two separate lists of header and source files,
I figured it would be easiest, at least for the common case,
to keep one list of files and then have a for loop split them
apart. I've tried to be consistent with having the list
of files be named with a _FILES suffix - maybe we can use this
as a marker to generate .gni files in the future?

Suggested review order:
 - //bazel/macros.bzl. Note this needs a corresponding
   G3 change (http://cl/452279799) as well. The exports_files_legacy
   change is the better approach to something I manually
   handled yesterday when fixing the G3 roll.
 - //BUILD.bazel to see the new target skia_internal and
   the previous skia_core renamed to skia_public.
 - //src/core/BUILD.bazel to see a typical usage of
   split_srcs_and_hdrs.
 - //include/... to see the change to public_hdrs and
   private_hdrs
 - //src/... to see many more usages of split_srcs_and_hdrs
 - //tools/... to see changes to skia_internal where
   appropriate.
 - Everything else. Note that //modules/... might also need
   to be built with skia_internal instead of skia_public,
   but we can fix that up later, if necessary.

Change-Id: Ie1cc969455d97b029b2d77faa222c4a9bad70671
Bug: skia:12541
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/545716
Reviewed-by: Ben Wagner <bungeman@google.com>
Reviewed-by: Leandro Lovisolo <lovisolo@google.com>
2022-06-02 11:23:50 +00:00
skia-autoroll
89fea08f6b Roll vulkan-deps from b0ac9f33937d to 7ab4802b330f (4 revisions)
https://chromium.googlesource.com/vulkan-deps.git/+log/b0ac9f33937d..7ab4802b330f

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-skia-autoroll
Please CC bungeman@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in skia: https://bugs.chromium.org/p/skia/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Build-Debian10-Clang-x86_64-Debug-Dawn;skia/skia.primary:Build-Debian10-Clang-x86_64-Release-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE
Bug: None
Tbr: bungeman@google.com
Change-Id: I0d855fabaa93cd23073ad95a42125a756f70187a
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/546056
Bot-Commit: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2022-06-02 08:20:00 +00:00
skia-autoroll
85c75b7d9c Roll ANGLE from 9800a3cf3f7c to e04314fd8f19 (14 revisions)
9800a3cf3f..e04314fd8f

2022-06-02 syoussefi@chromium.org Vulkan: Include state in pipeline graph dump
2022-06-02 gman@chromium.org Metal:Dynamically choose max draw buffers.
2022-06-02 gman@chromium.org Metal: Upstream clear performance fix
2022-06-02 gman@chromium.org Metal: Update MAX_LOD_BIAS
2022-06-01 ffz@google.com Code Cleanup
2022-06-01 senorblanco@chromium.org D3D11: implement stencil texturing.
2022-06-01 syoussefi@chromium.org Vulkan: Pipeline creation feedback in perf counters
2022-06-01 syoussefi@chromium.org Vulkan: Use 64-bit counters
2022-06-01 syoussefi@chromium.org Vulkan: Fix xfb emulation bug w.r.t array elements
2022-06-01 jmadill@chromium.org Update extension support (June 1, 2022).
2022-06-01 romanl@google.com Revert "Use a temporary timeout multipler for trace tests."
2022-06-01 angle-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 59aa5963cf64 to 23b710f1a0b3 (6 revisions)
2022-06-01 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 51c43dc015b7 to 466e443100e6 (2 revisions)
2022-06-01 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 85bb5555c93e to f6e0343d6b36 (473 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-skia-autoroll
Please CC bungeman@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Build-Debian10-Clang-x86_64-Release-ANGLE;skia/skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC8i5BEK-GPU-IntelIris655-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE
Tbr: bungeman@google.com
Change-Id: I9d73e96f070bd15b1b8583b22699ae595b8c5c58
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/545937
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2022-06-02 05:51:33 +00:00
skia-autoroll
d788590483 Roll SwiftShader from 55dd5e7034ed to 1bf3ae22a00d (2 revisions)
https://swiftshader.googlesource.com/SwiftShader.git/+log/55dd5e7034ed..1bf3ae22a00d

2022-06-01 sugoi@google.com Fix border comparison with depth 16
2022-06-01 srisser@google.com Make vk_pipeline dependent on Reactor

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-skia-autoroll
Please CC bungeman@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Test-Debian10-Clang-GCE-GPU-SwiftShader-x86_64-Debug-All-SwiftShader
Bug: None
Tbr: bungeman@google.com
Change-Id: I43cb14e5ad76d52eb9200d606126c932ee78a1c7
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/545938
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2022-06-02 04:49:34 +00:00
skia-autoroll
2b1ed68f03 Roll Dawn from 25b7e98d1100 to 232abaefc35d (26 revisions)
https://dawn.googlesource.com/dawn.git/+log/25b7e98d1100..232abaefc35d

2022-06-02 hogehoge@gachapin.jp Delint for "use after move"
2022-06-02 shrekshao@google.com Fix typo maxOS -> macOS
2022-06-02 jie.a.chen@intel.com Remove stride in ExternalImageDescriptorDmaBuf
2022-06-02 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 466e443100e6 to 1bf3ae22a00d (1 revision)
2022-06-01 bclayton@google.com tint: Stub intrinsic @const evaluation
2022-06-01 bclayton@google.com tint/writer/spirv: Tweak builtin tests to use 'var's
2022-06-01 bclayton@google.com tools: intrinsic-gen - [[decoration]] -> @attribute
2022-06-01 bclayton@google.com tint/resolver: Enable abstract-numerics
2022-06-01 bclayton@google.com tint: Shuffle builtin test directories
2022-06-01 bclayton@google.com tint: Add tests showing tint:1332 is fixed
2022-06-01 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 9800a3cf3f7c to b03f278925c6 (4 revisions)
2022-06-01 bclayton@google.com Roll third_party/webgpu-cts/ 70091fdb8..d275c5e1e (3 commits)
2022-06-01 bclayton@google.com tint/transform: Remove FoldConstants
2022-06-01 bclayton@google.com tint/sem: Fix Constant constructor with initializer_list
2022-06-01 bclayton@google.com tint/writer/spirv: Inline constant expressions
2022-06-01 bclayton@google.com tint/sem: Consider sign bit for Constant helpers.
2022-06-01 bclayton@google.com tint/writer/hlsl: Inline constant expressions
2022-06-01 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from ba231aba2243 to 23b710f1a0b3 (5 revisions)
2022-06-01 cwallez@chromium.org Stop validating ExternalTextureDescriptor::colorSpace prior to removal
2022-06-01 bclayton@google.com cts: Remove use of intel-0x5912 and intel-0x3e9b tags
2022-06-01 zhaoming.jiang@intel.com Tint: num_workgroups use free binding group if not specified
2022-06-01 bclayton@google.com tint/writer/msl: Inline constant expressions
2022-06-01 cwallez@chromium.org Add support for SurfaceDescriptorFromWaylandSurface
2022-06-01 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 55dd5e7034ed to 466e443100e6 (1 revision)
2022-06-01 enrico.galli@intel.com dawn/native: Add support for feature "indirect-first-instance"
2022-06-01 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 0b533e64cf61 to 9800a3cf3f7c (9 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dawn-skia-autoroll
Please CC lokokung@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Build-Debian10-Clang-x86_64-Debug-Dawn
Bug: None
Tbr: lokokung@google.com
Change-Id: I53abf8cace8c45524d9018510bf4b8ea523a9b47
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/545939
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2022-06-02 04:41:40 +00:00
Ben Wagner
3daf310ed8 Roll HarfBuzz from 8d1b000a to 858570b1 (460 commits)
8d1b000a3e..858570b1d9

Change-Id: I04ae10351707eed0897792a7b0214648f5f80d9c
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/544238
Reviewed-by: Herb Derby <herb@google.com>
Commit-Queue: Ben Wagner <bungeman@google.com>
2022-06-01 22:10:39 +00:00
Herb Derby
e02ed227f6 Move SubRun alloc estimator to SubRunContainer
Change-Id: I7da5a6757a68e74012958b61fbe7195f9d262776
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/545777
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Herb Derby <herb@google.com>
2022-06-01 20:43:42 +00:00
skia-autoroll
38847f13db Roll vulkan-deps from 23b710f1a0b3 to b0ac9f33937d (1 revision)
https://chromium.googlesource.com/vulkan-deps.git/+log/23b710f1a0b3..b0ac9f33937d

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-skia-autoroll
Please CC bungeman@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in skia: https://bugs.chromium.org/p/skia/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Build-Debian10-Clang-x86_64-Debug-Dawn;skia/skia.primary:Build-Debian10-Clang-x86_64-Release-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE
Bug: None
Tbr: bungeman@google.com
Change-Id: Ic429ca4b0576d7d5c9bd71bdb2cf137cf11cb127
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/545710
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2022-06-01 19:39:14 +00:00
Brian Salomon
586e6354aa SkMeshSpecification supports uniforms.
Currently there is no way to specify the data that is bound to them.
That will come in later changes.

Bug: skia:12720
Change-Id: I3301a825486469396a13a4095b66d9e0b81f183b
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/543716
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
2022-06-01 19:37:35 +00:00
skia-autoroll
479fa1c9ca Roll SK Tool from 7773a2b07a31 to 1b7947e28c99
https://skia.googlesource.com/buildbot.git/+log/7773a2b07a31..1b7947e28c99

2022-06-01 borenet@google.com [bcid] Add skia-infra-corp to kube/clusters/config.json
2022-06-01 borenet@google.com [autoroll] Fix meta-config-generator deleting and recreating files
2022-05-31 rmistry@google.com [gerrit] Add topic to ChangeInfo and add new topic SearchTerm
2022-05-31 rmistry@google.com [CT] Create member variables for each metrics analysis element
2022-05-31 rmistry@google.com [CT] Create member variables for each chromium analysis element

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/sk-tool-skia
Please CC kjlubick@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Tbr: kjlubick@google.com
Change-Id: If2cb6de21011e5fb705a3ca36e5c227694fef5fd
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/545708
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2022-06-01 19:16:50 +00:00
Kevin Lubick
61f0ea4f7a [bazel] Move remaining codec build rules to //bazel/external
There are no functional changes to the rules, just a relocation.

Change-Id: I90af5ec792fc54ce2978b0bbb1afd2c932e183b4
Bug: skia:12541
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/545719
Reviewed-by: Ben Wagner <bungeman@google.com>
2022-06-01 19:12:14 +00:00
Arman Uguray
bd969a089d [sksl] Disallow boolean uniforms
Booleans and structs/interface blocks that transitively contain a
boolean member are no longer allowed to be used as a uniform. This is
because SPIR-V and WGSL currently disallow OpTypeBool in host-shareable
storage classes.

Change-Id: I10315c7f261ff10a07636265968a91d9c421da55
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/542776
Reviewed-by: Brian Osman <brianosman@google.com>
Reviewed-by: John Stiles <johnstiles@google.com>
Commit-Queue: Arman Uguray <armansito@google.com>
2022-06-01 18:07:08 +00:00
Kevin Lubick
3aed21ce0e [bazel] Fix Dawn rules (new generated files)
Corresponding Dawn change: https://dawn-review.googlesource.com/c/dawn/+/90962

Change-Id: Ib9d2163c7874b7fb9fb5ab88de6d96a133c4ecbd
Bug: skia:12541
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/545718
Reviewed-by: Arman Uguray <armansito@google.com>
2022-06-01 18:02:30 +00:00
Robert Phillips
1d27124c48 Add SkPopCount
Change-Id: Ic750608c2053eb1253e6cb21109b0ad5ac32a55a
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/545362
Commit-Queue: Robert Phillips <robertphillips@google.com>
Reviewed-by: Herb Derby <herb@google.com>
Reviewed-by: John Stiles <johnstiles@google.com>
2022-06-01 17:55:22 +00:00
John Stiles
5723585ba3 Disable the CFI sanitizer only when casting pointers.
The cast of newly-allocated memory to T* is the only thing that triggers
a CFI error; we can let CFI instrument the rest of the code normally.

Change-Id: I0e6ab76dbddf031967bee34f5a05986ff58e6714
Bug: skia:13339
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/545676
Auto-Submit: John Stiles <johnstiles@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: John Stiles <johnstiles@google.com>
2022-06-01 15:10:35 +00:00
Kevin Lubick
bebf8e34c3 [bazel] Fix typo
Change-Id: I6f091e5ef99cfa8a26a033d37415391b2ee63e55
Bug: skia:12541
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/545369
Commit-Queue: Ben Wagner <bungeman@google.com>
Reviewed-by: Ben Wagner <bungeman@google.com>
2022-06-01 13:44:40 +00:00
Florin Malita
1da7be7a85 Cleanup SkText warnings
Some unused var and pessimizing move warnings, e.g.

../../experimental/sktext/src/Text.cpp:316:12: warning: moving a local object in a return statement prevents copy elision [-Wpessimizing-move]
    return std::move(shapedText);
           ^
../../experimental/sktext/src/Text.cpp:316:12: note: remove std::move call here
    return std::move(shapedText);
           ^~~~~~~~~~

Change-Id: Id5c220b7a850b2013e2bf065a87d4a296bd0369c
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/542522
Reviewed-by: Julia Lavrova <jlavrova@google.com>
Commit-Queue: Florin Malita <fmalita@google.com>
Auto-Submit: Florin Malita <fmalita@chromium.org>
2022-06-01 13:03:05 +00:00
Kevin Lubick
97caefd055 [bazel] Move zlib and libpng out of //third_party/BUILD.bazel
I had to copy some config_settings out of //bazel/common_config_settings
because these are now treated as separate entities and cannot
see that file.

For libpng, note that we use a genrule to create the
pnglibconf.h instead of pointing to one somewhere else.
This ended up being easier than other things I tried.

Another approach would be to not depend on the version
in third_party/externals, but to clone it via
new_git_repository [1] and apply a patch that creates
the configuration file.

[1] https://bazel.build/rules/lib/repo/git#new_git_repository

Bug: skia:12541
Change-Id: I9a284775dc0f2bdabb145518d5f0803c74fb99fa
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/545368
Reviewed-by: Ben Wagner <bungeman@google.com>
2022-06-01 12:19:01 +00:00
skia-autoroll
b217400869 Roll vulkan-deps from ba231aba2243 to 23b710f1a0b3 (5 revisions)
https://chromium.googlesource.com/vulkan-deps.git/+log/ba231aba2243..23b710f1a0b3

Also rolling transitive DEPS:
  https://skia.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers from 5a121866927a to b2a156e1c043
  https://skia.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools from 130a05d2e3e5 to b930e734ea19

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-skia-autoroll
Please CC bungeman@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in skia: https://bugs.chromium.org/p/skia/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Build-Debian10-Clang-x86_64-Debug-Dawn;skia/skia.primary:Build-Debian10-Clang-x86_64-Release-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE
Bug: None
Tbr: bungeman@google.com
Change-Id: I00adf5f736be51459ab338f941bd569bd88623ff
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/545529
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2022-06-01 06:51:02 +00:00
skia-autoroll
48cb5bc138 Roll ANGLE from 0b533e64cf61 to 9800a3cf3f7c (9 revisions)
0b533e64cf..9800a3cf3f

2022-06-01 chris@rive.app Add a test for imageLoad after glClear to the texture
2022-05-31 jmadill@chromium.org Vulkan: Switch resource tracking.
2022-05-31 jmadill@chromium.org Vulkan: Track used command buffers in ResourceUse.
2022-05-31 senorblanco@chromium.org D3D11: minor cleanup to getSRVLevel().
2022-05-31 geofflang@google.com GL: Temporarily enable validation for all GL calls.
2022-05-31 ggabu423@gmail.com Fix to invalidate cache when binding Transform Feedback.
2022-05-31 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from d070309f7d15 to 51c43dc015b7 (1 revision)
2022-05-31 geofflang@chromium.org Revert "Initialize buffer contents separately from BufferImpl::setData"
2022-05-31 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 312583ebe76f to 85bb5555c93e (843 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-skia-autoroll
Please CC bungeman@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Build-Debian10-Clang-x86_64-Release-ANGLE;skia/skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC8i5BEK-GPU-IntelIris655-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE
Tbr: bungeman@google.com
Change-Id: If199df15478cd75a2e449b7438dc6e7aab7ff60c
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/545523
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2022-06-01 05:51:07 +00:00
skia-autoroll
f19abf4c3a Roll SwiftShader from 51c43dc015b7 to 55dd5e7034ed (1 revision)
https://swiftshader.googlesource.com/SwiftShader.git/+log/51c43dc015b7..55dd5e7034ed

2022-05-31 capn@google.com Optimize SPIR-V matrix operations using FMA

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-skia-autoroll
Please CC bungeman@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Test-Debian10-Clang-GCE-GPU-SwiftShader-x86_64-Debug-All-SwiftShader
Bug: None
Tbr: bungeman@google.com
Change-Id: I28d09121392fc11aef4de9cff6566768519701d9
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/545524
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2022-06-01 04:52:41 +00:00
skia-autoroll
2c1259e699 Roll Dawn from f45180a428d2 to 25b7e98d1100 (61 revisions)
https://dawn.googlesource.com/dawn.git/+log/f45180a428d2..25b7e98d1100

2022-06-01 bclayton@google.com tint/writer/glsl: Inline constant expressions
2022-06-01 jie.a.chen@intel.com Explicit vkImage create to wrap video frame
2022-06-01 jrprice@google.com tint/spirv: Fix atomicCompareExchangeWeak
2022-05-31 amaiorano@google.com tint: update origin-trial-changes.md for atomicCompareExchangeWeak changes
2022-05-31 bclayton@google.com tint/resolver: Implement candidate overload resolution
2022-05-31 bclayton@google.com tint: Remove use of inf / nans from e2e tests
2022-05-31 bclayton@google.com tint/sem: Add more helpers to Constant
2022-05-31 enga@chromium.org Return an error surface if surface creation fails
2022-05-31 bclayton@google.com tint/writer/wgsl: Emit 'f' suffix on FloatLiteralExpressions
2022-05-31 bclayton@google.com tint/resolver: Materialize RHS of non-phony assignments
2022-05-31 enga@chromium.org Fix typo in OWNERS file
2022-05-31 enga@chromium.org Remove custom serialization of device properties
2022-05-31 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 59aa5963cf64 to ba231aba2243 (1 revision)
2022-05-31 bclayton@google.com tint/resolver: Materialize array size expression
2022-05-31 enga@chromium.org Ensure the Vulkan fuzzer uses SwiftShader
2022-05-31 hogehoge@gachapin.jp Change wgpu::VertexStepMode::VertexBufferNotUsed enum value
2022-05-31 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 51c43dc015b7 to 55dd5e7034ed (1 revision)
2022-05-31 bclayton@google.com tint/resolver: Materialize array index expression
2022-05-31 amaiorano@google.com Implement atomicCompareExchangeWeak returning struct instead of vec2
2022-05-31 bclayton@google.com tint: Add Checked[Add|Mul|Madd]()
2022-05-31 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 33b254fe85e3 to 0b533e64cf61 (3 revisions)
2022-05-30 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from d070309f7d15 to 51c43dc015b7 (1 revision)
2022-05-30 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from a2fe4445dce5 to 33b254fe85e3 (4 revisions)
2022-05-30 dsinclair@chromium.org Update some forward declarations.
2022-05-30 bclayton@google.com tint: Lex abstract integers
2022-05-30 bclayton@google.com tools: Add colored icons to the CTS roll msgs
2022-05-30 bclayton@google.com Roll third_party/webgpu-cts/ 5f05d6d5e..70091fdb8 (2 commits)
2022-05-30 dsinclair@chromium.org Update clang-tidy configuration.
2022-05-29 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 9ea3967d3e8b to a2fe4445dce5 (1 revision)
2022-05-28 bclayton@google.com tint/resolver: Materialize arguments to @workgroup_size
2022-05-28 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from e46647cbc883 to 59aa5963cf64 (5 revisions)
2022-05-28 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from b267c009d4d6 to 9ea3967d3e8b (4 revisions)
2022-05-28 bclayton@google.com tint/resolver: Materialize argument to bitcast
2022-05-28 bclayton@google.com tint/resolver: Add tests for implicit type materialization
2022-05-28 enga@chromium.org Update Dawn tests and fuzzers to create adapters/devices on the wire
2022-05-27 senorblanco@chromium.org ANGLE/D3D11: reenable now-passing bind groups tests.
2022-05-27 bclayton@google.com tint/resolver: Rename test field names, update comments
2022-05-27 bclayton@google.com tint/resolver: Make Materialize() handle nullptr expressions
2022-05-27 bclayton@google.com tint: Remove ConversionFailure::kTooSmall
2022-05-27 bclayton@google.com tint/resolver: Ensure that validation is done before CollectTextureSamplerPairs()
2022-05-27 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from aa2201725270 to b267c009d4d6 (4 revisions)
2022-05-27 bclayton@google.com tools: Automatically generate resource_files.txt
2022-05-27 bclayton@google.com tint/reader/wgsl: Error if a hex float is not exactly representable
2022-05-27 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 090d24c0ff24 to e46647cbc883 (4 revisions)
2022-05-27 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 5ca5b0ae5a7d to d070309f7d15 (5 revisions)
2022-05-27 jiawei.shao@intel.com Vulkan: Remove deprecated VK_MAKE_VERSION
2022-05-27 jiawei.shao@intel.com Fix a Kokoro build error and a presubmit warning
2022-05-27 bclayton@google.com dawn: Add missing #include
2022-05-27 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 54e08a5af1f7 to aa2201725270 (4 revisions)
2022-05-27 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from c1e419261c41 to 090d24c0ff24 (9 revisions)
2022-05-27 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from b29b3ba75888 to 5ca5b0ae5a7d (3 revisions)
2022-05-27 enga@chromium.org Workaround UBSAN errors re incorrect function pointer types
2022-05-27 jiawei.shao@intel.com Vulkan: Support feature chromium_experimental_dp4a
2022-05-26 bajones@chromium.org Begin auto generating GPUInfo utilities
2022-05-26 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 891dd5b3d8eb to 54e08a5af1f7 (4 revisions)
2022-05-26 kainino@chromium.org Remove TextureView test suppressions for Mac AMD
2022-05-26 senorblanco@chromium.org ANGLE/D3D11: remove suppression for now-passing test.
2022-05-26 enga@chromium.org Reduce fuzzer log spam
2022-05-26 bclayton@google.com tint/reader/wgsl: Lex abstract floats
2022-05-26 bclayton@google.com tint/reader/wgsl: Use C++17 hex floats for tests
2022-05-26 bclayton@google.com tint/reader/wgsl: Lex abstract hex floats

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dawn-skia-autoroll
Please CC lokokung@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Build-Debian10-Clang-x86_64-Debug-Dawn
Bug: None
Tbr: lokokung@google.com
Test: Test: dawn_end2end_tests
Change-Id: I9f202489233a336f396adacc4fc7dcc73a794b0e
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/545522
Bot-Commit: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2022-06-01 04:41:09 +00:00
John Stiles
817dd601f8 Reland "Disable Control-Flow Integrity in SkTArray when casting buffer to T*."
This reverts commit ef7c45a0fa.

Reason for revert: avoiding perf regression

Original change's description:
> Revert "Disable Control-Flow Integrity in SkTArray when casting buffer to T*."
>
> This reverts commit 0b1384de5a.
>
> Reason for revert: visible impact on performance: http://screen/4N7DNCQNSgtzzBo http://go/crb/1330618
>
> Original change's description:
> > Disable Control-Flow Integrity in SkTArray when casting buffer to T*.
> >
> > We disable Control-Flow Integrity sanitization (go/cfi) when updating
> > the item-array buffer. CFI flags this code as dangerous because we are
> > casting `buffer` to a T* while the buffer's contents might still be
> > uninitialized memory. When T has a vtable, this is especially risky
> > because we could hypothetically access a virtual method on fItemArray
> > and jump to an unpredictable location in memory. Of course, SkTArray
> > won't actually use fItemArray in this way, and we don't want to
> > construct a T before the user requests one. There's no real risk here,
> > so disable CFI when doing these casts.
> >
> > Change-Id: I5708053339f4a600b12c841fcd38880f9932f7d6
> > Bug: skia:13339
> > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/542643
> > Commit-Queue: Ben Wagner <bungeman@google.com>
> > Auto-Submit: John Stiles <johnstiles@google.com>
> > Reviewed-by: Ben Wagner <bungeman@google.com>
>
> Bug: skia:13339
> Change-Id: I9f39100fc4a03359fa7712b0a8d8cbe3bc7de625
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/545365
> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> Auto-Submit: John Stiles <johnstiles@google.com>

Bug: skia:13339
Change-Id: I7629cb9045e0c7a804785f8c0ad569610e1c67e1
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/545366
Reviewed-by: Ben Wagner <bungeman@google.com>
Commit-Queue: John Stiles <johnstiles@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
2022-05-31 20:50:05 +00:00
Herb Derby
b018bcf5d5 Introduce SubRunContainer - common SubRun code from Blobs and Slugs
Factor out the common code for handling SubRuns from Blobs and
Slugs. SubRunContainer will be moved to its own file in the
next CL to reduce the size of TextBlob.cpp.

Change-Id: I185336c5fa7a70841ef7b706fa194aa01649dacc
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/544248
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Herb Derby <herb@google.com>
2022-05-31 20:32:16 +00:00
skia-autoroll
6c8ee260d5 Roll SK Tool from 42e81270f532 to 7488f1b9caa8
https://skia.googlesource.com/buildbot.git/+log/42e81270f532..7488f1b9caa8

2022-05-31 borenet@google.com [gerrit] Fix Auto-Submit label

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/sk-tool-skia
Please CC kjlubick@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Tbr: kjlubick@google.com
Change-Id: Ie96b0ef0805999006c2e3801ab955952574b6a26
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/545381
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2022-05-31 20:17:42 +00:00
Kevin Lubick
8d69d04579 [bazel] Add fixes for G3
Mostly, this adds placeholder BUILD.bazel files corresponding to files
used in public.bzl

The exception is src/ports/BUILD.bazel, which adds an explicit
link command for dl, needed for dlopen etc.

Bug: skia:12541
Change-Id: Id3801a4c718cec37bc2aa3920a8d810f8a80a373
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/545359
Reviewed-by: Ben Wagner <bungeman@google.com>
2022-05-31 19:50:47 +00:00