Ravi Mistry
0d056ba473
Update webpages_playback.py to use the new Golang impl of WPRs
...
NoTry: true
Bug: skia:6901
Change-Id: I1a0dc706f9494c261c2f609df81a37cc60970fdd
Reviewed-on: https://skia-review.googlesource.com/30060
Commit-Queue: Ravi Mistry <rmistry@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2017-08-02 16:56:16 +00:00
Ravi Mistry
863ffef385
Do not move over webpage archives, they are needed for capturing SKPs
...
NoTry: true
Bug: skia:6850
Change-Id: I35ac2c10ae58561ab5424033d9bb5e14b75c526f
Reviewed-on: https://skia-review.googlesource.com/24327
Commit-Queue: Ravi Mistry <rmistry@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2017-07-18 17:29:14 +00:00
borenet
27f93e00d2
RecreateSKPs: Fix another .join() issue
...
BUG=skia:5843
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2429513002
Review-Url: https://codereview.chromium.org/2429513002
2016-10-17 08:09:34 -07:00
borenet
7787463668
RecreateSKPs: Fix GoogleStorageDataStore.delete_path
...
BUG=skia:5843
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2423093002
Review-Url: https://codereview.chromium.org/2423093002
2016-10-17 05:12:10 -07:00
borenet
7535867371
More fixes for webpages_playback
...
BUG=skia:5843
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2409753002
Review-Url: https://codereview.chromium.org/2409753002
2016-10-10 13:20:49 -07:00
borenet
1cebf7b450
webpages_playback: Fix GS path with extra '/'
...
BUG=skia:5843
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2409593002
Review-Url: https://codereview.chromium.org/2409593002
2016-10-10 08:14:11 -07:00
borenet
644638c037
webpages_playback: use gsutil instead of API, no shell_utils
...
BUG=skia:5843
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2406863002
Review-Url: https://codereview.chromium.org/2406863002
2016-10-10 05:57:18 -07:00
borenet
a86952a5ef
webpages_playback: use new skia-skps bucket
...
BUG=skia:2969
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2393043003
Review-Url: https://codereview.chromium.org/2393043003
2016-10-05 08:23:04 -07:00
Ravi Mistry
57d6965562
Further increase run_benchmark timeout
...
Looks like the chromium page sets still hit the 10 min timeout.
BUG=skia:5700
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2342
# This code is not exercised by trybots.
NOTRY=true
Change-Id: I57aba4c1541a840d7e4e97112a6485abc20aa3c7
Reviewed-on: https://skia-review.googlesource.com/2342
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
2016-09-08 13:13:43 +00:00
rmistry
fd7f867a05
Increase run_benchmarks timeout because the two Chromium page sets can take a while
...
BUG=skia:5700
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2298453002
# Trybots do not exercise this code.
NOTRY=true
TBR=borenet
Review-Url: https://codereview.chromium.org/2298453002
2016-08-30 11:50:23 -07:00
borenet
1413d52c53
Speculative fix for SKP partner-dir upload
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2229433002
Review-Url: https://codereview.chromium.org/2229433002
2016-08-08 06:26:00 -07:00
borenet
2869847166
webpages_playback: Make --upload_to_partner_bucket work without --upload
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2182463002
Review-Url: https://codereview.chromium.org/2182463002
2016-07-25 05:18:15 -07:00
borenet
85f0e63ca4
Add "skp" asset
...
Don't get rid of SKP_VERSION and associated stuff just yet.
BUG=skia:5427
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2167763002
DOCS_PREVIEW= https://skia.org/?cl=2167763002
Review-Url: https://codereview.chromium.org/2167763002
2016-07-21 10:27:00 -07:00
rmistry
afaf496910
Add catapult to RecreateSKPs bot's PYTHONPATH
...
TBR=borenet
BUG=skia:5024
NOTRY=true
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1747623002
Review URL: https://codereview.chromium.org/1747623002
2016-02-27 10:04:57 -08:00
rmistry
f5e83951ad
Fix delete_path in webpages_playback.py
...
BUG=skia:3751
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1662673003
# Trybots do not exercise this code.
NOTRY=true
Review URL: https://codereview.chromium.org/1662673003
2016-02-03 05:58:31 -08:00
rmistry
c33c79c97d
Delete skp dir in partner bucket before uploading
...
BUG=skia:3751
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1660363002
# Trybots do not exercise this code.
NOTRY=true
TBR=borenet
Review URL: https://codereview.chromium.org/1660363002
2016-02-03 04:27:54 -08:00
rmistry
8870e94fe3
Recreate SKPs in a single directory for trusted partners.
...
Context: https://bugs.chromium.org/p/skia/issues/detail?id=3751#c15
BUG=skia:3751
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1662693002
# Trybots do not run this code
NOTRY=true
TBR=borenet
Review URL: https://codereview.chromium.org/1662693002
2016-02-02 13:55:38 -08:00
rmistry
0575c495bc
Upload SKPs to chrome-partner-telemetry
...
Context:
https://bugs.chromium.org/p/skia/issues/detail?id=3751#c4
and
https://bugs.chromium.org/p/skia/issues/detail?id=3751#c6
BUG=skia:3751
# Trybots do not run this code.
NOTRY=true
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1658653002
Review URL: https://codereview.chromium.org/1658653002
2016-02-01 10:27:05 -08:00
rmistry
aa31ee78ee
Add ability to specify extra browser args and a prefix for SKP names to webpages_playback.py
...
BUG=skia:3763
NOTRY=true
Review URL: https://codereview.chromium.org/1066933006
2015-04-23 12:47:33 -07:00
rmistry
80bd3ae9d7
Delete no longer needed pagesets, add new pagesets and make names more readable
...
Deleted all pagesets mentioned in https://code.google.com/p/skia/issues/detail?id=3574#c18
Added new Wikipedia and Unicodetable pagesets from https://code.google.com/p/skia/issues/detail?id=3574#c19
BUG=skia:3574
NOTRY=true
Review URL: https://codereview.chromium.org/1053253003
2015-04-03 08:22:51 -07:00
rmistry
2a3c8493af
Turn on Chromium's top 25 page set
...
#crskps
BUG=skia:
BUG=skia:3574
NOTRY=true
TBR=borenet
Review URL: https://codereview.chromium.org/1045153004
2015-03-31 10:59:15 -07:00
rmistry
39383a1946
Fix cr SKPs naming
...
#crskps
BUG=skia:
BUG=skia:3574
NOTRY=true
TBR=borenet
Review URL: https://codereview.chromium.org/1044193003
2015-03-31 08:03:02 -07:00
rmistry
5af9a3792f
Turn on key mobile sites cr page set and delete dashed desktop
...
#crskps
BUG=skia:3574
BUG=skia:3605
NOTRY=true
Review URL: https://codereview.chromium.org/1040233004
2015-03-31 06:22:55 -07:00
rmistry
009b069f52
Fix gs.upload_dir_contents arguments mismatch
...
Fixing bug introduced by https://codereview.chromium.org/737123005
BUG=skia:
NOTRY=true
TBR=borenet
Review URL: https://codereview.chromium.org/1041003003
2015-03-31 05:20:12 -07:00
rmistry
49d093cef9
Add ability to capture SKPs from Chromium's pagesets
...
Also added support for pagesets with multiple pages in them.
#crskps
BUG=skia:1723
BUG=skia:3574
NOTRY=true
Review URL: https://codereview.chromium.org/1047703003
2015-03-31 05:04:29 -07:00
kkinnunen
b4ee7ea834
webpages_playback.py: Support storing to local directories
...
Make webpages_playback support storing to local directories as an
alternative to Google Storage.
Rename argument --dest_gsbase to --data_store=<location>. Make this parameter
accept either gs:// url or directory for local file system storage.
Rename argument --upload_to_gs to --upload.
Implement file existence check, download and upload for the file
operation.
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/737123005
2015-03-31 00:18:27 -07:00
kkinnunen
f9310fe2be
webpages_playback.py: Avoid crash when retrying to capture skp
...
Move the .wpr files after recording, in the recording retry loop.
Previously they were moved in the skp capture retry loop.
Review URL: https://codereview.chromium.org/1033223005
2015-03-29 22:33:16 -07:00
kkinnunen
960fb50a1a
Make debugger not fail with webpages_playback script and multiple skp files
...
The debugger accepts either a single skp or a directory as a parameter.
The webpages_playback script used to pass multiple files using a '*'
glob.
Review URL: https://codereview.chromium.org/775073002
2014-12-03 06:18:12 -08:00
kkinnunen
fcf35c533b
Update webpages_playback documentation
...
Update the documentation on how to run webpages_playback. It was out of
date.
Review URL: https://codereview.chromium.org/778633002
2014-12-03 05:51:24 -08:00
kkinnunen
e75d2d2d99
Remove Google Storage scheme prefix correctly from gs base name in webpages_playback
...
In python, str.lstrip([chars]) means "lstrip any of the chars from str",
not "remove prefix". Thus "gs://skia".lstrip("gs://") yields "kia".
Replace with custom function stripping the prefix from lstrip()ed gs
base name.
Review URL: https://codereview.chromium.org/780493002
2014-12-03 04:38:46 -08:00
kkinnunen
3a6aa86978
Make render_pdfs not crash webpages_playback script
...
The render_pdfs nowadays seems to input the skps from
the dir passed as '-r' parameter.
The app will not output anything, but it will not crash the
webpages_playback script either. Affects only runs that have
--skia_tools=<dir> argument.
Review URL: https://codereview.chromium.org/776873004
2014-12-03 04:22:06 -08:00
rmistry
0ec28af1a7
Updated all page sets to capture new set of webpage archives.
...
Fixed the record_wpr retry mechanism in webpages_playback.py.
Updated all page sets to remove the no longer needed RunSmoothness and RunNavigateSteps.
Updated the key_silk_cases pagesets to point to a non svn location:
* skia_fontwipe_desktop.py
* skia_silkfinance_desktop.py
Removed mercurynews, record_wpr was timing out because of a popup.
Added back the following pagesets which were previously disabled but are now working again:
* skia_cnn_nexus10.py
* skia_wordpress_desktop.py
* skia_transformice_nexus10.py
BUG=skia:3049
Review URL: https://codereview.chromium.org/684863002
2014-10-28 14:25:17 -07:00
rmistry
7620bf0658
Fix ability to capture archives in webpages_playback.py
...
Updated all page sets to match the file name. This is to make it easier to call record_wpr with the page set class name.
Also updated the wait time for baidu to 60 seconds.
BUG=skia:3049
Review URL: https://codereview.chromium.org/683473002
2014-10-27 06:42:11 -07:00
rmistry
f802f326f4
Update webpages_playback script and all page_sets to use new skpicture_printer benchmark
...
The purpose of this CL is to turn the RecreateSKPs bot green after
https://codereview.chromium.org/665193002/ lands.
Description of changes in this CL:
* After https://codereview.chromium.org/665193002/ lands we will no longer need to copy the archives and pagesets to telemetry's data directory, I removed the code that did this in https://codereview.chromium.org/655313003/
* page_sets now need unique class names. Updated all page_sets to have unique class names.
* Using the new --page_set_name and --page_set_base_dir and --also-run-disabled-tests parameters
BUG=skia:3046
Review URL: https://codereview.chromium.org/671513009
2014-10-22 05:04:43 -07:00
borenet
783991585b
Fix recreate_skps?
...
run_measurement was removed in https://codereview.chromium.org/655563007 .
Based on the comments, I think the right thing to do is replace it with
run_benchmark. Hopefully this fixes the bot.
BUG=skia:
TBR=rmistry
NOTRY=true
Review URL: https://codereview.chromium.org/658513004
2014-10-17 12:15:46 -07:00
borenet
dc89ca56e6
Add recreate_skps script
...
BUG=skia:3008
Review URL: https://codereview.chromium.org/655313003
2014-10-17 07:37:05 -07:00