Commit Graph

15610 Commits

Author SHA1 Message Date
kkinnunen
4be0238b11 Avoid leaking render targets in debugger
Render targets were not unreffed when QGLWidget::resizeGL was called.

Review URL: https://codereview.chromium.org/817243002
2014-12-22 06:06:41 -08:00
reed
ac6692b606 rebaseline
BUG=skia:
TBR=
NOTRY=True

Review URL: https://codereview.chromium.org/816383002
2014-12-22 06:06:38 -08:00
kkinnunen
91f8e7f195 Initialize wrapped render target wrap status correctly
Make GrGLGpu::onWrapBackendRenderTarget update "is wrapped" flag.
Otherwise accessing the flag results in uninitialized read, possibly
resulting in wrapped render target ending up in the cache.

Review URL: https://codereview.chromium.org/818023002
2014-12-22 05:57:33 -08:00
kkinnunen
534c63ea91 Make debugger raster window background black
Make debugger raster window background black. This helps to understand
where the picture boundaries are. It is probably more common for pictures to
have non-black background vs non-white background.

This makes raster window similar to opengl window.

Review URL: https://codereview.chromium.org/816363002
2014-12-22 05:56:45 -08:00
reed
eeb4e26093 unsuppress after rebaselining
BUG=skia:
TBR=
NOTRY=True

Review URL: https://codereview.chromium.org/824703002
2014-12-22 05:52:30 -08:00
reed
5394d69a09 rebaselines for obsolete suppressions
BUG=skia:
TBR=
NOTRY=True

Review URL: https://codereview.chromium.org/822723002
2014-12-22 05:51:36 -08:00
reed
4a2a17dc83 unsuppress after rebaselining
BUG=skia:
TBR=
NOTRY=True

Review URL: https://codereview.chromium.org/824693002
2014-12-22 05:20:11 -08:00
skia.buildbots
6cc53f3fa7 Update SKP version
Automatic commit by the RecreateSKPs bot.

TBR=

Review URL: https://codereview.chromium.org/822673002
2014-12-21 23:02:07 -08:00
reed
3b40ee6009 remove dead SK_SUPPORT_LEGACY_N32_NAME code
BUG=skia:
TBR=

Review URL: https://codereview.chromium.org/818903004
2014-12-21 14:29:05 -08:00
reed
f65f0b92f5 remove dead SK_SUPPORT_LEGACY_GRTYPES dead
BUG=skia:
TBR=bsalomon@google.com

Review URL: https://codereview.chromium.org/823503002
2014-12-21 11:52:15 -08:00
reed
f7430ccfc0 removed dead SK_SUPPORT_LEGACY_DRAWTEXT_VIRTUAL code
BUG=skia:
TBR=

Review URL: https://codereview.chromium.org/817193002
2014-12-21 11:38:35 -08:00
reed
c8a21311e7 undef SK_SUPPORT_LEGACY_GRADIENT_FACTORIES to fix callers
BUG=skia:
TBR=

Review URL: https://codereview.chromium.org/824533002
2014-12-21 11:06:06 -08:00
reed
ec57b54ac7 remove dead SK_SUPPORT_LEGACY_DEVICE_CLEAR code
BUG=skia:
TBR=robertphilips@google.com

Review URL: https://codereview.chromium.org/807083003
2014-12-21 11:03:36 -08:00
robertphillips
ca32da7533 Allow the alpha folding optimization if the single draw's paint has a shader
Let's land this and then leave for 2 weeks.

BUG=skia:3119

Review URL: https://codereview.chromium.org/817033002
2014-12-21 10:52:01 -08:00
tfarina
fa4f6cba2f Cleanup: More override fixes - include version.
BUG=skia:3075
TEST=ninja -C out/Debug
TBR=reed@google.com

Review URL: https://codereview.chromium.org/800663003
2014-12-21 10:27:08 -08:00
skia.buildbots
ea735d1b1f Update SKP version
Automatic commit by the RecreateSKPs bot.

TBR=

Review URL: https://codereview.chromium.org/824483002
2014-12-20 22:55:43 -08:00
reed
5e8b1688ee remove dead SK_LEGACY_ENCODE_BITMAP flag
BUG=skia:
TBR=

Review URL: https://codereview.chromium.org/820903002
2014-12-20 15:23:55 -08:00
joshualitt
f53ff623fa rebase coloremoji
NOTRY=True
TBR=
BUG=skia:

Review URL: https://codereview.chromium.org/822553002
2014-12-20 10:30:09 -08:00
tfarina
752e7eb157 Cleanup: Another round of override fixes.
BUG=skia:3075
TEST=ninja -C out/Debug
TBR=mtklein@google.com

Review URL: https://codereview.chromium.org/815883002
2014-12-20 06:53:43 -08:00
skia.buildbots
bb1af8dd75 Update SKP version
Automatic commit by the RecreateSKPs bot.

TBR=

Review URL: https://codereview.chromium.org/814393002
2014-12-19 23:10:53 -08:00
joshualitt
c14e556f8c fix leak
NOTREECHECKS=True
TBR=
BUG=skia:

Review URL: https://codereview.chromium.org/817083002
2014-12-19 14:43:33 -08:00
robertphillips
65dc6f03dd Rebaseline (and ignore failure) on flaky NexusPlayer MPD GMs
BUG=skia:3267
TBR=reed@google.com

Review URL: https://codereview.chromium.org/814983004
2014-12-19 13:54:22 -08:00
reed
4f8684046d mega rebaseline --tiny differences
BUG=skia:
TBR=
NOTRY=True

Review URL: https://codereview.chromium.org/802433004
2014-12-19 13:50:39 -08:00
robertphillips
f3f5bad7de Add toString methods to SkImageFilter-derived classes
This isn't definitive but at least makes something show up in the debugger.

Review URL: https://codereview.chromium.org/789163006
2014-12-19 13:49:15 -08:00
joshualitt
290c09b8bb initial changes to add local matrix to primitive processor
BUG=skia:

Review URL: https://codereview.chromium.org/820523002
2014-12-19 13:45:20 -08:00
reed
bd2f0f34cf rebaselines after gradient fix
BUG=skia:
TBR=
NOTRY=True
NOTREECHECKS=True

Review URL: https://codereview.chromium.org/818853002
2014-12-19 12:53:11 -08:00
reed
d55b595748 fix SK_LEGACY_ENCODE_BITMAP missing cast
BUG=skia:
TBR=
NOTRY=True
NOTREECHECKS=True

Review URL: https://codereview.chromium.org/815223002
2014-12-19 12:43:47 -08:00
bsalomon
9ed7f57349 When bitmap is texture backed, don't download and reupload pixels
Review URL: https://codereview.chromium.org/820683002
2014-12-19 12:26:37 -08:00
reed
53b9e2e0f2 add const to encodePixels pixel parameter
BUG=skia:

Review URL: https://codereview.chromium.org/788143007
2014-12-19 12:26:07 -08:00
reed
7e38d99d03 rebaseline Nexus GMs
BUG=skia:
TBR=
NOTRY=True
NOTREECHECKS=True

Review URL: https://codereview.chromium.org/811263004
2014-12-19 12:21:32 -08:00
egdaniel
ef9db909c4 More ignores for complexclip2
TBR=
NOTRY=True
NOTREECHECKS=True
BUG=skia:

Review URL: https://codereview.chromium.org/814133003
2014-12-19 12:05:49 -08:00
reed
864e2b63fd rebaseline after gradient fix
BUG=skia:
TBR=
NOTRY=True
NOTREECHECKS=True

Review URL: https://codereview.chromium.org/807193004
2014-12-19 11:51:40 -08:00
bsalomon
a3ca6925fa disable GM that asserts on gpu
BUG=skia:3265

TBR=egdaniel@google.com
NOTRY=true
NOTREECHECKS=true

Review URL: https://codereview.chromium.org/818743002
2014-12-19 09:32:40 -08:00
reed
f4ceea5219 update ignore list for prev CL
BUG=skia:
TBR=
NOTRY=True
NOTREECHECKS=True

Review URL: https://codereview.chromium.org/810123003
2014-12-19 07:54:11 -08:00
reed
438b0d754d Enable new gradients + suppress gms for now
This reverts commit 2c770271e6.

BUG=skia:
TBR=

Review URL: https://codereview.chromium.org/811753003
2014-12-19 07:40:26 -08:00
scroggo
b64e56941c Remove legacy Picture defines.
No longer needed by Android.

Review URL: https://codereview.chromium.org/788903006
2014-12-19 07:28:00 -08:00
joshualitt
0cd35a24f2 rebase and update ignore
TBR=
NOTRY=True
BUG=skia:

Review URL: https://codereview.chromium.org/816963002
2014-12-19 06:47:20 -08:00
egdaniel
aa9513d705 Initial rebaselines for complexclip3
TBR=
NOTRY=True
BUG=skia:

Review URL: https://codereview.chromium.org/810423003
2014-12-19 06:26:48 -08:00
skia.buildbots
cf1ea73edc Update SKP version
Automatic commit by the RecreateSKPs bot.

TBR=

Review URL: https://codereview.chromium.org/810403002
2014-12-18 23:09:07 -08:00
joshualitt
c2625821b3 Remove the low hanging fruit with coord change matrices
BUG=skia:

Review URL: https://codereview.chromium.org/793013003
2014-12-18 16:40:55 -08:00
joshualitt
334c9fb492 rebase blurrects
NOTRY=True
TBR=
BUG=skia:

Review URL: https://codereview.chromium.org/810593004
2014-12-18 15:52:56 -08:00
joshualitt
0f296d184f quick adding to ignore
NOTRY=True
TBR=
BUG=skia:

Review URL: https://codereview.chromium.org/795943003
2014-12-18 14:36:17 -08:00
joshualitt
72a3b0f0b9 rebase and update ignores
NOTRY=True
TBR=
BUG=skia:

Review URL: https://codereview.chromium.org/816813002
2014-12-18 14:24:35 -08:00
mtklein
8aacf20856 Fill SkRRect::fType proactively.
I found no external mentions of SkRRect::kUnknown_Type.

Motivating race found by TSAN:
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu13.10-GCE-NoGPU-x86_64-Release-TSAN-Trybot/builds/48/steps/dm/logs/stdio

BUG=skia:

Review URL: https://codereview.chromium.org/801693003
2014-12-18 13:29:54 -08:00
reed
152d42f628 remove flag (not ready for it yet)
BUG=skia:
TBR=
NOTRY=True

Review URL: https://codereview.chromium.org/803553006
2014-12-18 13:01:40 -08:00
reed
2c770271e6 Revert of enable new gradients + suppress gms for now (patchset #1 id:1 of https://codereview.chromium.org/807513004/)
Reason for revert:
crashy

Original issue's description:
> enable new gradients + suppress gms for now
>
> BUG=skia:
> TBR=
> NOTRY=True
>
> Committed: https://skia.googlesource.com/skia/+/8142a57fa1bf582b66efde276cd43d40c525bc16

TBR=
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review URL: https://codereview.chromium.org/814963002
2014-12-18 12:59:39 -08:00
reed
8142a57fa1 enable new gradients + suppress gms for now
BUG=skia:
TBR=
NOTRY=True

Review URL: https://codereview.chromium.org/807513004
2014-12-18 12:53:37 -08:00
reed
68331cd92a remove dead code behind SK_SUPPORT_LEGACY_ALLOCPIXELS_BOOL
BUG=skia:

Review URL: https://codereview.chromium.org/814753004
2014-12-18 12:48:16 -08:00
egdaniel
9e4ecdc9f8 Add an InvariantOutput for the XPF.
The Invariant output holds information about final post blended color and other
general information like will it blend with dst. Having this new struct allowed
me to also remove some functions that were previously querying subsets of the
invariant output.

BUG=skia:

Review URL: https://codereview.chromium.org/814933002
2014-12-18 12:44:55 -08:00
reed
caf7e9313b improve precision of gradients (disabled for now)
BUG=skia:2898
TBR=caryclark

Review URL: https://codereview.chromium.org/815623004
2014-12-18 12:43:08 -08:00