AuroraMiddleware/skia2
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
16,562 Commits 1 Branch 0 Tags 544 MiB
706d98ef5b
Commit Graph

20 Commits

Author SHA1 Message Date
rmistry
f91b717a99 Ignore public API checks if COMMIT=false is in the description 
BUG=skia:
NOTRY=true

Committed: https://skia.googlesource.com/skia/+/d1783aefcc0da86c5ff1d124c54704252d817621

Review URL: https://codereview.chromium.org/1006473002
 2015-03-12 09:48:10 -07:00
mtklein
a10ea431cf Revert of Ignore public API checks if COMMIT=false is in the description (patchset #4 id:80001 of https://codereview.chromium.org/1006473002/) 
Reason for revert:
I cannot upload patches:

~/skia (skskp) $ git clu --bypass-hooks
++ git log -1 --pretty=%B
+ git cl upload -t update
Using 50% similarity for rename/copy detection. Override with --similarity.
Loaded authentication cookies from /Users/mtklein/.codereview_upload_cookies
Running presubmit upload checks ...

** Presubmit ERRORS **
Since the CL is editing public API, you must have an LGTM from one of: ('reed@chromium.org', 'reed@google.com', 'bsalomon@chromium.org', 'bsalomon@google.com', 'djsollen@chromium.org', 'djsollen@google.com')

Original issue's description:
> Ignore public API checks if COMMIT=false is in the description
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/d1783aefcc0da86c5ff1d124c54704252d817621

TBR=borenet@google.com,rmistry@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review URL: https://codereview.chromium.org/1005583002
 2015-03-12 09:33:46 -07:00
rmistry
d1783aefcc Ignore public API checks if COMMIT=false is in the description 
BUG=skia:

Review URL: https://codereview.chromium.org/1006473002
 2015-03-12 08:43:22 -07:00
rmistry
01cbf6c467 Make presubmit check that #if or #ifdef does not come before includes. 
BUG=skia:3362

Review URL: https://codereview.chromium.org/998273002
 2015-03-12 07:48:40 -07:00
rmistry
896f3932c8 Automatically add NOTREECHECKS when uploading CLs from non master branches 
These changes are possible due to the recently submitted depot_tools change
https://codereview.chromium.org/949273002/ ('Add ability to specify and run post upload hooks').

BUG=skia:

Review URL: https://codereview.chromium.org/963553002
 2015-02-26 11:52:05 -08:00
rmistry
d223fb21d6 Automatically add a docs preview link and NOTRY=true when there are only docs changes. 
These changes are possible due to the recently submitted depot_tools change
https://codereview.chromium.org/949273002/ ('Add ability to specify and run post upload hooks').

BUG=skia:3474

Review URL: https://codereview.chromium.org/960203002
 2015-02-26 10:16:13 -08:00
rmistry
9407eceb27 PRESUBMIT should only check owners for the top level include directory 
BUG=skia:1846
R=borenet@google.com

Author: rmistry@google.com

Review URL: https://codereview.chromium.org/511503002
 2014-08-26 14:00:55 -07:00
rmistry
f2d83caf13 Public API changes are allowed if an owner is TBR'ed. 
The following TBR formats are supported:
* TBR=reed
* TBR=reed@google.com
* TBR=xyz,reed
* TBR=xyz,reed@google.com

BUG=skia:2870
R=borenet@google.com

Author: rmistry@google.com

Review URL: https://codereview.chromium.org/504843003
 2014-08-26 10:30:30 -07:00
rmistry
83fab4732a Adding djsollen to list of owners 
(SkipBuildbotRuns)

BUG=skia:
R=djsollen@google.com

Author: rmistry@google.com

Review URL: https://codereview.chromium.org/397813007
 2014-07-18 05:25:57 -07:00
Eric Boren
bb0ef0a134 Use new common tools in Python scripts 
BUG=skia:2682
R=rmistry@google.com

Review URL: https://codereview.chromium.org/330423004
 2014-06-25 11:13:27 -04:00
commit-bot@chromium.org
745e08caf2 Check if the issue owner is in the AUTHORS file in PRESUBMIT.py 
BUG=skia:2072
NOTRY=true
(SkipBuildbotRuns)

R=borenet@google.com, hcm@google.com

Author: rmistry@google.com

Review URL: https://codereview.chromium.org/131293005

git-svn-id: http://skia.googlecode.com/svn/trunk@13277 2bbb7eff-a529-9590-31e7-b0007b416f81
 2014-02-03 14:18:32 +00:00
commit-bot@chromium.org
cfdc596227 Do not enforce the public API presubmit check for Revert CLs. 
NOTRY=true

BUG=skia:2068
R=borenet@google.com

Author: rmistry@google.com

Review URL: https://codereview.chromium.org/151573002

git-svn-id: http://skia.googlecode.com/svn/trunk@13270 2bbb7eff-a529-9590-31e7-b0007b416f81
 2014-01-31 17:33:04 +00:00
commit-bot@chromium.org
c249088061 Adding rmistry for emergency reverts. 
(SkipBuildbotRuns)

TBR=
NOTRY=true
NOTREECHECKS=true
BUG=skia:

Author: rmistry@google.com

Review URL: https://codereview.chromium.org/148583005

git-svn-id: http://skia.googlecode.com/svn/trunk@13212 2bbb7eff-a529-9590-31e7-b0007b416f81
 2014-01-28 01:52:49 +00:00
rmistry@google.com
fb4a68de43 If any change is made to the public API then make sure there is an LGTM from an owner. 
This feature has been requested by reed@.

If no LGTM is found from an owner then the following msg is displayed:

** Presubmit ERRORS **
Since the CL is editing public API, you must have an LGTM from one of: ('reed@chromium.org', 'reed@google.com', 'bsalomon@chromium.org', 'bsalomon@google.com')

(SkipBuildbotRuns)

R=borenet@google.com

Review URL: https://codereview.chromium.org/22453004

git-svn-id: http://skia.googlecode.com/svn/trunk@10676 2bbb7eff-a529-9590-31e7-b0007b416f81
 2013-08-12 14:51:20 +00:00
rmistry@google.com
547012dc05 If the tree is closed then print information about contacting the sheriff. 
The motivation for this CL is because it is not very obvious on how to submit when tree is closed in git.

Also added a section 'How to submit when tree is closed' in https://sites.google.com/site/skiadocs/developer-documentation/tree-sheriff

(SkipBuildbotRuns)
Review URL: https://codereview.chromium.org/13932026

git-svn-id: http://skia.googlecode.com/svn/trunk@8666 2bbb7eff-a529-9590-31e7-b0007b416f81
 2013-04-12 19:45:46 +00:00
rmistry@google.com
f6c5f75b3c Display prompt for caution only if it is an interactive shell. 
Created to fix https://code.google.com/p/skia/issues/detail?id=1197 : Skia Commit Queue quits if the tree is in Caution.

(SkipBuildbotRuns)
Review URL: https://codereview.chromium.org/13325002

git-svn-id: http://skia.googlecode.com/svn/trunk@8446 2bbb7eff-a529-9590-31e7-b0007b416f81
 2013-03-29 17:26:00 +00:00
rmistry@google.com
713276b143 Presubmit should check that source files end in atleast one newline 
Review URL: https://codereview.appspot.com/7193063

git-svn-id: http://skia.googlecode.com/svn/trunk@7399 2bbb7eff-a529-9590-31e7-b0007b416f81
 2013-01-25 18:27:34 +00:00
rmistry@google.com
c29934489f Display a warning prompt in presubmit if the tree status is in 'Caution'. 
Example presubmit output:


Running presubmit upload checks ...

** Presubmit Warnings **
Tree state is: caution

***************
Please use caution in checkins
http://skia-tree-status-staging.appspot.com/banner-status?format=json
***************

There were presubmit warnings. Are you sure you wish to continue? (y/N):
Review URL: https://codereview.appspot.com/7200043

git-svn-id: http://skia.googlecode.com/svn/trunk@7337 2bbb7eff-a529-9590-31e7-b0007b416f81
 2013-01-23 14:35:58 +00:00
rmistry@google.com
6be0b4c63d Adding CheckChangeHasOnlyOneEol to upload and commit presubmit checks 
Review URL: https://codereview.appspot.com/7151043

git-svn-id: http://skia.googlecode.com/svn/trunk@7247 2bbb7eff-a529-9590-31e7-b0007b416f81
 2013-01-17 14:50:59 +00:00
rmistry@google.com
8e3ff8cf0b Top-level presubmit script for Skia trunk that checks https://skia-tree-status.appspot.com/banner-status?format=json before a CL is committed. 
gcl and git-cl will check for and run the presubmit script before you upload and/or commit your changes.
Review URL: https://codereview.appspot.com/7138046

git-svn-id: http://skia.googlecode.com/svn/trunk@7242 2bbb7eff-a529-9590-31e7-b0007b416f81
 2013-01-17 12:55:34 +00:00