Commit Graph

1035 Commits

Author SHA1 Message Date
Ben Wagner
2388c5216b Remove redundant jobs.
Replacements added in:
https://skia-review.googlesource.com/c/skia/+/26365
https://skia-review.googlesource.com/c/skia/+/31143

Bug: skia:6881
No-Try: true
Change-Id: I35a212f55b9f2cd1240f2f072321ee118a3feecc
Reviewed-on: https://skia-review.googlesource.com/46306
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2017-09-14 14:02:31 +00:00
Ravi Mistry
489bef054e Use Chrome-GPU pool for CT GPU runs
Bug: chromium:700053
NoTry: true
Change-Id: Ib62ea29f5192df1b03e9d8caecb6af4daeee0e49
Reviewed-on: https://skia-review.googlesource.com/46060
Commit-Queue: Ravi Mistry <rmistry@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2017-09-13 12:25:40 +00:00
Ben Wagner
adf17dc52f Add new task to run the float-cast-overflow sanitizer.
Bug: skia:4632
No-Try: true
Change-Id: I85a0b23037d5885e5d762788d8bf5b7cc6fc19b2
Reviewed-on: https://skia-review.googlesource.com/45980
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
2017-09-13 03:59:40 +00:00
Ben Wagner
79a3aafc34 Add Clang GPU tasks.
No-Try: true
Change-Id: I5290942396a903fcaac94feaab83a5db31af1f93
Reviewed-on: https://skia-review.googlesource.com/45844
Commit-Queue: Mike Klein <mtklein@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
2017-09-12 23:37:20 +00:00
Ben Wagner
79a1256c22 Simpler version of wait-for-device.
This is a followup to https://skia-review.googlesource.com/43564

No-Try: true
Change-Id: I4bc2a24fe08e6b07f5512e3a1e03eac7e3397155
Reviewed-on: https://skia-review.googlesource.com/45120
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Kevin Lubick <kjlubick@google.com>
2017-09-12 17:25:30 +00:00
Stephan Altmueller
74dac54548 Make output of all tests verbose
Re-enable more verbose output across all bots. 
There is no good reason why we shouldn't collect additional
information that helps triaging failure. 
Some of the current output might have to be expanded down the road. 

Bug: skia:
Change-Id: I5ff89a803f1e390bbd859756cba53a359d2801ba
Reviewed-on: https://skia-review.googlesource.com/45140
Reviewed-by: Eric Boren <borenet@google.com>
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Commit-Queue: Stephan Altmueller <stephana@google.com>
2017-09-12 14:20:00 +00:00
Ben Wagner
cf9365a0bc Retry adb commands on flaky devices.
No-Try: true
Change-Id: I3519131cf064d0a9676abd0fb9d7e946646ce27f
Reviewed-on: https://skia-review.googlesource.com/43564
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2017-09-11 14:09:20 +00:00
Mike Klein
bc7b1eab6c update clang_linux package to Clang 5
Disable some new warning flags to get us building.

Change-Id: I10299d667b06fb61d03e52329883c634bd42f45c
Reviewed-on: https://skia-review.googlesource.com/44341
Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Mike Klein <mtklein@chromium.org>
2017-09-10 13:20:49 +00:00
UpdateSKPs
e5964bc7d4 Update SKP version
Automatic commit by the RecreateSKPs bot.

TBR=update-skps@skia.org
NO_MERGE_BUILDS

Change-Id: Ie30d4614101383044b76c9c2dcb959ce447c1a67
Reviewed-on: https://skia-review.googlesource.com/44640
Reviewed-by: update-skps <update-skps@skia.org>
Commit-Queue: update-skps <update-skps@skia.org>
2017-09-10 08:01:58 +00:00
Ben Wagner
2e4e73f732 Omit encode-platform also for Debug Mac CPU.
Bug: skia:6992
No-Try: true
Change-Id: I824e44f0e9f08f607aa3aaa5e0074bce72a2b4ee
Reviewed-on: https://skia-review.googlesource.com/44202
Reviewed-by: Mike Klein <mtklein@chromium.org>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2017-09-08 20:29:58 +00:00
Ben Wagner
407a3b7874 Update NexusPlayers to Android O PR6.
No-Try: true
Change-Id: I0abb5e6d9d705d352089024a303d2f8be0f051aa
Reviewed-on: https://skia-review.googlesource.com/43203
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Greg Daniel <egdaniel@google.com>
2017-09-08 14:22:58 +00:00
Chris Dalton
7c304ba402 Only run CPU SVG tests on a single bot
Runs the testing on Test-Debian9-Clang-GCE-CPU-AVX2-x86_64-Debug-ASAN.
We only care about parsing SVGs CPU-side so there's no need to retest
it on every bot.

Bug: skia:6918
Change-Id: If2c5afbc41a600ece63d9a6a60f0dab5ca7b3676
Reviewed-on: https://skia-review.googlesource.com/43461
Reviewed-by: Florin Malita <fmalita@chromium.org>
Reviewed-by: Ravi Mistry <rmistry@google.com>
Commit-Queue: Chris Dalton <csmartdalton@google.com>
2017-09-07 22:23:53 +00:00
Brian Osman
1e75f2a102 Blacklist more flaky GMs in gltestthreading config
Bug: skia:7011 skia:6544
Change-Id: Idacb5ff8090bea6ddbdef710bc0f4dbb8bd23549
Reviewed-on: https://skia-review.googlesource.com/43560
Commit-Queue: Brian Osman <brianosman@google.com>
Reviewed-by: Robert Phillips <robertphillips@google.com>
2017-09-07 16:07:01 +00:00
Ben Wagner
11f844e559 Update PixelC to Android O PR6.
No-Try: true
Change-Id: I31dd6f12cb7ab4195bfe61b0f267ad5020d09a7c
Reviewed-on: https://skia-review.googlesource.com/43161
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2017-09-06 20:05:38 +00:00
Ben Wagner
6f98bc648b Omit flaky encode-platform test for pic-8888 Mac CPU.
Bug: skia:6992
No-Try: true
Change-Id: I8141afb1706b1434bacc62f6b6f9b69876a92b2c
Reviewed-on: https://skia-review.googlesource.com/42680
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Mike Klein <mtklein@chromium.org>
2017-09-05 20:14:16 +00:00
UpdateSKPs
9cb11ab7e4 Update SKP version
Automatic commit by the RecreateSKPs bot.

TBR=update-skps@skia.org
NO_MERGE_BUILDS

Change-Id: I255191f21e7b185b212b35502d6ce00f91fc45c2
Reviewed-on: https://skia-review.googlesource.com/42220
Commit-Queue: update-skps <update-skps@skia.org>
Reviewed-by: update-skps <update-skps@skia.org>
2017-09-03 07:56:46 +00:00
Brian Osman
bef21ba565 Blacklist (flaky) textbloblooper on gltestthreading
Bug: skia:
Change-Id: I10ddc36f39800e3d86145054b994a6899573a63a
Reviewed-on: https://skia-review.googlesource.com/41501
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2017-08-31 19:51:00 +00:00
Kevin Lubick
5d303ed44b Fix chromecast perfs
Bug: skia:
NOTRY=true
Change-Id: I5efe4bc59efa4bc81e5f8811fed7867ec20447fb
Reviewed-on: https://skia-review.googlesource.com/41541
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
2017-08-31 17:50:01 +00:00
Kevin Lubick
2dafbd796d Add Correctness tests for Chromecast
Bug: skia:
NOTRY=true
Change-Id: Ib604bad8eda6ba4382b850f7c5f318fb0f114401
Reviewed-on: https://skia-review.googlesource.com/20051
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2017-08-31 14:40:51 +00:00
Brian Osman
f9810666bd Threaded generation of software paths
Re-land of: https://skia-review.googlesource.com/36560

All information needed by the thread is captured by the prepare
callback object, the lambda captures a pointer to that, and does the
mask render. Once it's done, it signals the semaphore (also owned by the
callback). The callback defers the semaphore wait even longer (into the
ASAP upload), so the odds of waiting for the thread are REALLY low.

Also did a bunch of cleanup along the way, and put in some trace markers
so we can monitor how well this is working.

Traces of a GM that includes GPU and SW path rendering (path-reverse):

Original:
    https://screenshot.googleplex.com/f5BG3901tQg.png
Threaded, with wait in the callback (notice pre flush callback blocking):
    https://screenshot.googleplex.com/htOSZFE2s04.png
Current version, with wait deferred to ASAP upload function:
    https://screenshot.googleplex.com/GHjD0U3C34q.png
Bug: skia:
Change-Id: Idb92f385590749f41328a9aec65b2a93f4775079
Reviewed-on: https://skia-review.googlesource.com/40775
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2017-08-30 15:27:42 +00:00
UpdateSKPs
7f810b4e10 Update SKP version
Automatic commit by the RecreateSKPs bot.

TBR=update-skps@skia.org
NO_MERGE_BUILDS

Change-Id: Id92722fbb5c24e9cd7e1547fda974115cc866b2d
Reviewed-on: https://skia-review.googlesource.com/39100
Reviewed-by: update-skps <update-skps@skia.org>
Commit-Queue: update-skps <update-skps@skia.org>
2017-08-27 07:58:05 +00:00
Brian Salomon
87ae989569 Revert "Threaded generation of software paths"
This reverts commit 76323bc061.

Reason for revert: Breaking NUC bots in threaded gm comparison:

https://chromium-swarm.appspot.com/task?id=382e589753187f10&refresh=10



Original change's description:
> Threaded generation of software paths
> 
> All information needed by the thread is captured by the prepare
> callback object, the lambda captures a pointer to that, and does the
> mask render. Once it's done, it signals the semaphore (also owned by the
> callback). The callback defers the semaphore wait even longer (into the
> ASAP upload), so the odds of waiting for the thread are REALLY low.
> 
> Also did a bunch of cleanup along the way, and put in some trace markers
> so we can monitor how well this is working.
> 
> Traces of a GM that includes GPU and SW path rendering (path-reverse):
> 
> Original:
>     https://screenshot.googleplex.com/f5BG3901tQg.png
> Threaded, with wait in the callback (notice pre flush callback blocking):
>     https://screenshot.googleplex.com/htOSZFE2s04.png
> Current version, with wait deferred to ASAP upload function:
>     https://screenshot.googleplex.com/GHjD0U3C34q.png
> 
> Bug: skia:
> Change-Id: I3d5a230bbd68eb35e1f0574b308485c691435790
> Reviewed-on: https://skia-review.googlesource.com/36560
> Commit-Queue: Brian Osman <brianosman@google.com>
> Reviewed-by: Brian Salomon <bsalomon@google.com>

TBR=egdaniel@google.com,mtklein@google.com,bsalomon@google.com,robertphillips@google.com,brianosman@google.com

Change-Id: Icac0918a3771859f671b69ae07ae0fedd3ebb3db
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: skia:
Reviewed-on: https://skia-review.googlesource.com/38560
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
2017-08-24 21:34:38 +00:00
Brian Osman
76323bc061 Threaded generation of software paths
All information needed by the thread is captured by the prepare
callback object, the lambda captures a pointer to that, and does the
mask render. Once it's done, it signals the semaphore (also owned by the
callback). The callback defers the semaphore wait even longer (into the
ASAP upload), so the odds of waiting for the thread are REALLY low.

Also did a bunch of cleanup along the way, and put in some trace markers
so we can monitor how well this is working.

Traces of a GM that includes GPU and SW path rendering (path-reverse):

Original:
    https://screenshot.googleplex.com/f5BG3901tQg.png
Threaded, with wait in the callback (notice pre flush callback blocking):
    https://screenshot.googleplex.com/htOSZFE2s04.png
Current version, with wait deferred to ASAP upload function:
    https://screenshot.googleplex.com/GHjD0U3C34q.png

Bug: skia:
Change-Id: I3d5a230bbd68eb35e1f0574b308485c691435790
Reviewed-on: https://skia-review.googlesource.com/36560
Commit-Queue: Brian Osman <brianosman@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
2017-08-24 15:22:57 +00:00
Ben Wagner
38db79f7ba Omit flakily failing test.
Bug: skia:6992
No-Try: true
Change-Id: Ie2726fd80f0baf03bdea5148e45b909ac88340f6
Reviewed-on: https://skia-review.googlesource.com/37740
Reviewed-by: Stephan Altmueller <stephana@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2017-08-23 19:38:06 +00:00
Ben Wagner
db816992bb Update Mac CPU tasks to 10.12.
Failing tests were disabled in https://skia-review.googlesource.com/36440

No-Try: true
Change-Id: Icd123f53aa6df24850bf72d16e7685799d9e1e37
Reviewed-on: https://skia-review.googlesource.com/36200
Reviewed-by: Stephan Altmueller <stephana@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2017-08-23 14:21:56 +00:00
UpdateSKPs
671abd1763 Update SKP version
Automatic commit by the RecreateSKPs bot.

TBR=update-skps@skia.org
NO_MERGE_BUILDS

Change-Id: Ia1bcdbfc301b5e7a073b362b2db16a18d88f65ab
Reviewed-on: https://skia-review.googlesource.com/36640
Reviewed-by: update-skps <update-skps@skia.org>
Commit-Queue: update-skps <update-skps@skia.org>
2017-08-20 07:49:32 +00:00
Leon Scroggins III
3a3cf43e1e Disable questionable bmps on Mac platform decoder
These are already disabled on WIC, but they are supported by SkCodec.

Bug: skia:6984
Change-Id: Ib248749f357debcc173dfaa2bcd5adc8da52df22
Reviewed-on: https://skia-review.googlesource.com/36440
Commit-Queue: Leon Scroggins <scroggo@google.com>
Reviewed-by: Greg Daniel <egdaniel@google.com>
2017-08-18 17:27:19 +00:00
Ben Wagner
f6df1cd993 Remove SurfacePro Test tasks.
Test tasks were added in https://skia-review.googlesource.com/c/35321,
but dm results are identical to to IntelIris540; just some differences
in fonts. Removing the Test tasks will allow the bot to run Perf more
frequently, providing better data.

Bug: skia:6978
Change-Id: Icb8b6af7267a879b2d761d0e7fca6064f53281f8
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/36161
Reviewed-by: Ravi Mistry <rmistry@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2017-08-18 14:22:19 +00:00
Ben Wagner
cc4221be58 Rename Mac bots to match reality.
Doing this separately from https://skia-review.googlesource.com/c/36040
to avoid confusion.

No-Try: true
Change-Id: I2d9e03c6da6096f9e14145d9654b9da7a8670036
Reviewed-on: https://skia-review.googlesource.com/35823
Reviewed-by: Brian Salomon <bsalomon@google.com>
Reviewed-by: Ravi Mistry <rmistry@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2017-08-18 12:20:19 +00:00
Ben Wagner
d76a184efd Update Mac dimensions for upgraded bots.
Bug: chromium:756463
No-Try: true
Change-Id: Ica864811e59162d6cfa1e89aec9c0ce8090d27df
Reviewed-on: https://skia-review.googlesource.com/36040
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2017-08-17 21:38:38 +00:00
Ben Wagner
8ab8f61c4e Add SurfacePro2017 tasks.
Not adding Vulkan configs because it mostly produces garbage -- see
skia:6398.

Bug: skia:6978
NoTry: true
Change-Id: I8f9fa7ecc5d195658944f8f29a91ddaf47c066fc
Reviewed-on: https://skia-review.googlesource.com/35321
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Ravi Mistry <rmistry@google.com>
2017-08-17 17:55:21 +00:00
Ravi Mistry
af10923819 Create new set of SVGs
Context is in the below bug

Bug: skia:6918
Change-Id: Ic9048311092bd7e73dd6ee182e79abea79baa07a
Reviewed-on: https://skia-review.googlesource.com/30586
Commit-Queue: Ravi Mistry <rmistry@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2017-08-16 15:42:55 +00:00
Chris Dalton
ecf78acaa0 Blacklist svgparse_* svgs on non-8888
This also required extending the blacklist argument to support
negative matching and wildcards.

Bug: skia:6918
Change-Id: I915e305c75fe23fc3e11c2dd3e91570967da0aaa
Reviewed-on: https://skia-review.googlesource.com/31444
Commit-Queue: Chris Dalton <csmartdalton@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2017-08-15 23:30:28 +00:00
Kevin Lubick
c14e5a71c0 Add tasks for Acer R13
Bug: skia:
NOTRY=true
Change-Id: Iafc9a00ff2a41919214cdea89251ceb0c5b443c5
Reviewed-on: https://skia-review.googlesource.com/34721
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
2017-08-15 17:41:37 +00:00
Ben Wagner
0d2b091c73 Upgrade GT610 drivers.
Bug: skia:6959
Change-Id: I5d89a5bdc8729f3bc7103710744158397a286899
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/34722
Reviewed-by: Stephan Altmueller <stephana@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2017-08-15 17:24:27 +00:00
Kevin Lubick
b40902b6b8 Add upload to task name schema file
Bug: skia:
Change-Id: I65cd5761bb01e648db706878b902e6b6ed67fab9
Reviewed-on: https://skia-review.googlesource.com/33761
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
2017-08-15 11:58:25 +00:00
Ben Wagner
2c600fb216 Upgrade NVIDIA drivers on Linux bots.
Bug: skia:6959
No-Try: true
Change-Id: I849645dc5043a181bcdf3a1bb84cbd989684a7d7
Reviewed-on: https://skia-review.googlesource.com/34400
Reviewed-by: Stephan Altmueller <stephana@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2017-08-14 19:55:45 +00:00
Ben Wagner
769faa2456 Run perf tests on glsrgb and glessrgb configs.
No-Try: true
Change-Id: I41dfddf21f8ed80582d5dc88150e1fbaf98326e6
Reviewed-on: https://skia-review.googlesource.com/33803
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2017-08-14 14:33:25 +00:00
UpdateSKPs
215922a1f1 Update SKP version
Automatic commit by the RecreateSKPs bot.

TBR=update-skps@skia.org
NO_MERGE_BUILDS

Change-Id: If399ed5d4ca9947621b22fcea3e134d83b1d4831
Reviewed-on: https://skia-review.googlesource.com/33920
Commit-Queue: update-skps <update-skps@skia.org>
Reviewed-by: update-skps <update-skps@skia.org>
2017-08-13 07:39:58 +00:00
Ben Wagner
be8ad45fc2 Omit failing test for IntelIris640 Ubuntu Vulkan.
Bug: skia:6245
Change-Id: Id5e0704f51537abf4ed2794d67ab8424a725e1bc
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/33801
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2017-08-11 20:28:16 +00:00
Ben Wagner
fef8fdde87 Add new Linux IntelIris640 jobs.
Bug: skia:6761
Change-Id: I635958a482a16fc7027d33152db431cb8c5bbe2c
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/33740
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2017-08-11 18:58:06 +00:00
Ben Wagner
3c28653745 Upgrade Intel HD4600 and Iris6100 drivers.
HD4400 was upgraded in https://skia-review.googlesource.com/c/31101

Bug: skia:6917
No-Try: true
Change-Id: I9009671d1f47535fb1d0bacd180d8cf075088552
Reviewed-on: https://skia-review.googlesource.com/33584
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2017-08-11 16:31:26 +00:00
Ben Wagner
32fa510414 Abort dm/nanobench on bad configs.
Adjust the configs specified by recipes to avoid the new error.

Change-Id: I23e31355e2faaab919d92abdb37a6f70cd2da1ff
Reviewed-on: https://skia-review.googlesource.com/32862
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2017-08-11 13:12:26 +00:00
Ben Wagner
6da8f79618 Fix undefined flag for MSAN.
MSAN started failing after https://skia-review.googlesource.com/c/32722.
This should fix it.

No-Try: true
Change-Id: I8956c8c211507923f078fe96921fedaadefae8a8
Reviewed-on: https://skia-review.googlesource.com/32942
Reviewed-by: Ben Wagner <bungeman@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2017-08-10 19:02:06 +00:00
Brian Salomon
f4874bc5c1 Test non-msaa instanced rendering on Mac
Change-Id: I28b67ccef7bb72e4853a0eb02d1de00b1ed40cce
Reviewed-on: https://skia-review.googlesource.com/33001
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
2017-08-10 14:06:05 +00:00
Ben Wagner
11ab43cf3a Remove --undefok from recipes.
Since recipes are now versioned with the code, this is unnecessary and
could mask recipe bugs.

Change-Id: Ic5aafbd3a7e9ccd3fd529c71b282cf6b037b78df
Reviewed-on: https://skia-review.googlesource.com/32722
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2017-08-10 13:52:05 +00:00
Ben Wagner
ab909b5cd3 Add duplicate Valgrind tasks on QuadroP400.
Valgrind 3.13.0 only supports up to AVX2, so I used SK_CPU_LIMIT_SSE41
to avoid failing with "Unrecognised instruction." (The existing Valgrind
tasks run on a ShuttleA machine, whose CPU only supports AVX.)

Needed to enable verbose output on all Valgrind tasks to avoid Swarming
I/O timeout. Opportunistically removed verbose output for Linux Intel
bots that are no longer failing.

Bug: skia:6881
Change-Id: I2ffa6efe901c97bd2e0bbc9b26632aafbb3cf9a6
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/31143
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Mike Klein <mtklein@chromium.org>
2017-08-09 21:46:46 +00:00
Eric Boren
bca3b8d8e0 Revert "Bring recipes up to date."
This reverts commit e4024d5dab.

Reason for revert: Breaking Win bots

Original change's description:
> Bring recipes up to date.
> 
>   * Move recipe_engine URL to new canonical URL
>   * Add README.recipes.md (auto-generated doc from docstrings in repo,
>     regenerated with `recipes.py test train`).
>   * Bring depot_tools up to date
> 
> recipe_engine:
> 464fc26 Update a couple more URLs.
> 38808d0 Switch recipes-py CQ to Gerrit
> c7cdc9c Update canonical URL.
> 6bac51f Fix urls to googlesource.
> 5cf5e58 Convert code review to Gerrit
> e92def4 Add source manifest proto to recipe_engine.
> e0ddd60 Move internal downstream recipe roll trybots to production
> 3cae8e9 Add file.filesizes to recipe engine core modules.
> 862f333 Vendor 'luci_context' library.
> 6de5241 Add add_json_log='on_failure' to json module.
> e183af0 [recipe_engine] Set presentation.status before OutputPlaceholder.result.
> 3b99cdd Fix "recipes.py test diff" not raising a failure
> 8e8339a [path] Fix root path mocking.
> 00799cc Add experimental internal downstream recipe trybots
> 0ca88ae Pretty up all recipe_engine documentation.
> de3238c Fix UnboundLocalError in find_recipe.
> 9b47d24 Move downstream recipe roll trybots to production
> da3467b Recursively apply recipe overrides
> 3d76281 [uuid] Remove unused uuid module
> 9959b07 Remove shutil module.
> 26475d6 Add more experimental downstream trybots
> 5c349eb [file] allow glob to handle nested patterns
> 12e7ca4 recipes.py test: enforce recipe expectations literally
> 241ddc2 [file] fix glob_paths when NO paths match, add tests.
> 11d7598 [file] Allow placeholders in file.copy
> 9419a0e [doc] Put all external URLs in a single section.
> 4b6b21e [doc] Fix randomization of DEPS link order, give DEPS links fully qualified names
> 3ac778e [recipe_autoroller] regen docs on trivial rolls too.
> c8d78bf [doc] Automatically generate and update cross-indexed recipe markdown files.
> 5873ef2 Fix "env_prefixes" rendering.
> 
> depot_tools:
> fb3fa785 Roll recipe dependencies (trivial).
> a643e9e3 Update patch_projects crap for googlesource repos in infra.
> fb391fcd [gclient config] Update luci project URLs (ugh)
> 590a4189 Roll recipe dependencies (trivial).
> 8e6a5e6e Roll recipe dependencies (trivial).
> 0e5f57ec [recipes.cfg] Update recipes.cfg to new canonical recipe URL.
> 704d6ad8 Roll recipe dependencies (trivial).
> f1205599 Roll recipe dependencies (trivial).
> 243c9643 Roll recipe dependencies (trivial).
> e866182f depot_tools: Fix executable bit for gerrit_*.py
> 4759fc62 Roll recipe dependencies (trivial).
> 7ab47354 Roll recipe dependencies (trivial).
> 554e2bff Roll recipe dependencies (trivial).
> 9e8c78d2 Roll recipe dependencies (trivial).
> b0ad16ee gclient flatten: do not recurse into deps not in recursedeps
> d9f97bc5 Use https for short URLs wherever applicable (MoarTLS).
> c9353605 gclient flatten: fixes for chromium/src
> ecdfa41d Fix quoting in update_depot_tools.
> 1407d00d gclient: make variables from parent DEPS scope override ones in inner scope
> 07a6bea9 Expose ast via InputApi
> e864a3f2 Remove presubmit check for DISALLOW_* macros
> e1054034 fetch_end_to_end_test: add recipe
> 8b478f04 PRESUBMIT: Be resilient to changes with no Code-Review label
> 8038dfe3 bot_update recipe: parameterize step name in apply_gerrit_ref
> 5aeeb72c [bootstraps] Sync at gclient, suppress output (#2)
> eb1feb90 [cipd] Bump version, log at warning (#2).
> 9f9d82ac Revert "[cipd] Bump version, log at warning."
> 18aa2d93 [cipd] Bump version, log at warning.
> fc6196b3 gclient flatten: preserve variable placeholders (reland #1)
> 5aa5cd76 depot_tools: add gerrit repo and ref to apply_gerrit_ref()
> 56766f1d Add experimental downstream recipe trybots to depot_tools
> 44855b94 Revert "[bootstraps] Sync at gclient, suppress output."
> 393ba066 Revert "gclient flatten: preserve variable placeholders"
> e79ddeaa gclient flatten: preserve variable placeholders
> 5a80eab0 Use -prerelease flag to vswhere when packaging VS
> 4d92fe43 [bootstraps] Sync at gclient, suppress output.
> 357415cb gclient flatten: fix a bug with some recursedeps not being processed
> 3d6363b3 Roll recipe dependencies (trivial).
> b396315c Bump led version.
> a3a515a4 Revert "Generalize git index refresh to bot_update."
> 06e1aa07 Generalize git index refresh to bot_update.
> 7f12a2e4 [bootstrap/win] Roll bleeding edge entry bat.
> f7543cdd git-cl: accept --force for -f everywhere
> 642dd84c [win/bootstrap] Use "for" instead of "set".
> ca01e2c8 git cl issue 0: Remove Change-Id from message, not description
> 290f5f56 Remove "create-ntfs-junction".
> ff9a5dec Roll recipe dependencies (trivial).
> d2dbea66 Roll recipe dependencies (trivial).
> fc62f768 Simplify notify behavior in git-cl
> cfbb775f Roll recipe dependencies (trivial).
> ae895075 Use doseq=True when re-encoding url query parameters
> 98681d11 Remove obsolete destination-branch-check flag
> 8aa774cf Fix bot_update example
> dd1bc7c0 [cipd] Generate other platform suffixes.
> 383ace4b Fix git-crrev-parse on Mac.
> e5adf612 Fix typo with --send-email [sic] flags
> 0ed616a4 Roll recipe dependencies (trivial).
> 636b13fc Let Changelist().AddComment() mark changes as Ready
> 68b54e78 [bootstrap/win] Upgrade Python to 2.7.13.
> f3d5a114 Enable Gerrit-destination-branch check by default
> 31f3e63c Revert "Revert "[tryserver] Remove unused methods.""
> c4dd3e82 [bootstrap/win] Remove support for legacy installs
> cc27ecb0 Revert "[tryserver] Remove unused methods."
> 68f6f279 [bootstrap/win] Always use "cipd.bat".
> 3a8717e1 [bootstrap/win] Remove legacy Git support.
> 6bac8a84 GitHyperBlameMainTest.testBadFilename: Work around git-blame bug.
> 4e5207d6 git-cl issue 0: Don't operate on empty description
> 22a9cf54 git_footers: fix bug stdin-based message input.
> 02e59414 Fix bot_update's usage of the destination branch
> 83eb1cd5 Roll recipe dependencies (trivial).
> 400e989b 'git cl issue 0': Remove Change-Id
> 133ac1ab [tryserver] Remove unused methods.
> b08ba657 git_footer: be more resilient to malformed footers
> 9d842bab [recipe_modules/git] Remove logging.
> 3d9b5881 [win_tools] Use bundled Python CIPD packages (#2).
> 209a681f [git] Remove hard-coded "depot_tools" Git.
> e8eed65f Always copy "python.bat".
> aab09ca6 Whitelist "python_bin_reldir.txt".
> af5c20f5 Revert "[win_tools] Use bundled Python CIPD packages."
> 7dadf05d Query Gerrit for destination branch in bot_update
> bf144679 [win_tools] Use bundled Python CIPD packages.
> b80fac66 Roll recipe dependencies (trivial).
> 265255f5 [bootstrap/win] Replace "python.bat" only on downgrade.
> 24025d3e tryserver: add support for gerrit footers
> 903ea731 [activity.py] Identify Gerrit-style bug annotations in commit messages
> 49b8147b Add support to query a CL's branch to gerrit recipe module
> 4cb9d742 [bootstrap/win] Enable revert from upcoming patch.
> 13e88538 Ignore the ".bleeding_edge" file.
> c8173825 git cl creds-check: improve report and give better recommendation.
> 4978917c Adjust CQ config for luci.infra.try -> luci.infra.depot_tools.try bucket move
> 9cb802ca Improve gerrit recipe_module example
> 79e897b0 [git_bootstrap] Support new Git bundles.
> 8af46469 Roll recipe dependencies (trivial).
> 1f767e17 Fix autoninja.py for ninja -t compatibility
> 7466d1a9 [cipd] Run client in .bat to preserve STDIN.
> 13f258bf Remove SVN bootstrapping and some tooling.
> b12c5256 Roll recipe dependencies (trivial).
> 016f92e6 Roll recipe dependencies (trivial).
> 68506985 Roll recipe dependencies (trivial).
> 215ded77 Fix testFlattenPinAllDeps
> 271a1680 gclient flatten: implement --pin-all-deps
> fb022017 gclient flatten: include vars
> e36a8431 Roll recipe dependencies (trivial).
> de37c012 Fix git-numberer swallowing of footers for Rietveld.
> 4e89144a git-cl: fix auth error message computation
> 7c2e05b4 [cipd] Fix CIPD bootstraps run concurrently.
> aaf93f48 gclient flatten: refactor flatten code to a class
> 807caf84 gclient flatten: remove --require-pinned-revisions
> 6fbf12f2 Enable query for changes in gerrit recipe module
> c6846aa2 gclient flatten: fix a bug with deps_os getting omitted for recursed deps
> 4baaa11c gclient: avoid adding potentially duplicate entries to work queue
> d3790251 gclient: apply custom_vars when evaluating conditions
> a8fdab96 Roll recipe dependencies (trivial).
> e82c0dec [cipd] Fail if setup has an error.
> b1ad2f04 Update CIPD client, vpython and "LUCI editor".
> 6a1ab843 Roll recipe dependencies (trivial).
> 32f0e5d7 Roll recipe dependencies (trivial).
> bc9c5ccf Roll recipe dependencies (trivial).
> 54adb2a3 Generate initial recipes README.
> 603545b7 Roll recipe dependencies (trivial).
> e015878d gclient flatten: fix an issue with an deps_os entry getting added to deps
> 6014b566 gclient flatten: also handle allowed_hosts
> 70b3f3aa [bot_update] Pass spec as file.
> 1af0a337 Roll recipe dependencies (trivial).
> dc598e82 [bot_update] Prefix PATH, cleanup.
> 
> Bug: skia:
> Change-Id: I0eea2dd126c130299ac39fe9b54a714cb0612563
> Reviewed-on: https://skia-review.googlesource.com/32420
> Reviewed-by: Eric Boren <borenet@google.com>
> Commit-Queue: Eric Boren <borenet@google.com>

TBR=borenet@google.com,iannucci@google.com

Change-Id: I6ed89db0757ffeb366da96d655372e9710aa589e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: skia:
Reviewed-on: https://skia-review.googlesource.com/32520
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
2017-08-09 13:03:15 +00:00
Robert Iannucci
e4024d5dab Bring recipes up to date.
* Move recipe_engine URL to new canonical URL
  * Add README.recipes.md (auto-generated doc from docstrings in repo,
    regenerated with `recipes.py test train`).
  * Bring depot_tools up to date

recipe_engine:
464fc26 Update a couple more URLs.
38808d0 Switch recipes-py CQ to Gerrit
c7cdc9c Update canonical URL.
6bac51f Fix urls to googlesource.
5cf5e58 Convert code review to Gerrit
e92def4 Add source manifest proto to recipe_engine.
e0ddd60 Move internal downstream recipe roll trybots to production
3cae8e9 Add file.filesizes to recipe engine core modules.
862f333 Vendor 'luci_context' library.
6de5241 Add add_json_log='on_failure' to json module.
e183af0 [recipe_engine] Set presentation.status before OutputPlaceholder.result.
3b99cdd Fix "recipes.py test diff" not raising a failure
8e8339a [path] Fix root path mocking.
00799cc Add experimental internal downstream recipe trybots
0ca88ae Pretty up all recipe_engine documentation.
de3238c Fix UnboundLocalError in find_recipe.
9b47d24 Move downstream recipe roll trybots to production
da3467b Recursively apply recipe overrides
3d76281 [uuid] Remove unused uuid module
9959b07 Remove shutil module.
26475d6 Add more experimental downstream trybots
5c349eb [file] allow glob to handle nested patterns
12e7ca4 recipes.py test: enforce recipe expectations literally
241ddc2 [file] fix glob_paths when NO paths match, add tests.
11d7598 [file] Allow placeholders in file.copy
9419a0e [doc] Put all external URLs in a single section.
4b6b21e [doc] Fix randomization of DEPS link order, give DEPS links fully qualified names
3ac778e [recipe_autoroller] regen docs on trivial rolls too.
c8d78bf [doc] Automatically generate and update cross-indexed recipe markdown files.
5873ef2 Fix "env_prefixes" rendering.

depot_tools:
fb3fa785 Roll recipe dependencies (trivial).
a643e9e3 Update patch_projects crap for googlesource repos in infra.
fb391fcd [gclient config] Update luci project URLs (ugh)
590a4189 Roll recipe dependencies (trivial).
8e6a5e6e Roll recipe dependencies (trivial).
0e5f57ec [recipes.cfg] Update recipes.cfg to new canonical recipe URL.
704d6ad8 Roll recipe dependencies (trivial).
f1205599 Roll recipe dependencies (trivial).
243c9643 Roll recipe dependencies (trivial).
e866182f depot_tools: Fix executable bit for gerrit_*.py
4759fc62 Roll recipe dependencies (trivial).
7ab47354 Roll recipe dependencies (trivial).
554e2bff Roll recipe dependencies (trivial).
9e8c78d2 Roll recipe dependencies (trivial).
b0ad16ee gclient flatten: do not recurse into deps not in recursedeps
d9f97bc5 Use https for short URLs wherever applicable (MoarTLS).
c9353605 gclient flatten: fixes for chromium/src
ecdfa41d Fix quoting in update_depot_tools.
1407d00d gclient: make variables from parent DEPS scope override ones in inner scope
07a6bea9 Expose ast via InputApi
e864a3f2 Remove presubmit check for DISALLOW_* macros
e1054034 fetch_end_to_end_test: add recipe
8b478f04 PRESUBMIT: Be resilient to changes with no Code-Review label
8038dfe3 bot_update recipe: parameterize step name in apply_gerrit_ref
5aeeb72c [bootstraps] Sync at gclient, suppress output (#2)
eb1feb90 [cipd] Bump version, log at warning (#2).
9f9d82ac Revert "[cipd] Bump version, log at warning."
18aa2d93 [cipd] Bump version, log at warning.
fc6196b3 gclient flatten: preserve variable placeholders (reland #1)
5aa5cd76 depot_tools: add gerrit repo and ref to apply_gerrit_ref()
56766f1d Add experimental downstream recipe trybots to depot_tools
44855b94 Revert "[bootstraps] Sync at gclient, suppress output."
393ba066 Revert "gclient flatten: preserve variable placeholders"
e79ddeaa gclient flatten: preserve variable placeholders
5a80eab0 Use -prerelease flag to vswhere when packaging VS
4d92fe43 [bootstraps] Sync at gclient, suppress output.
357415cb gclient flatten: fix a bug with some recursedeps not being processed
3d6363b3 Roll recipe dependencies (trivial).
b396315c Bump led version.
a3a515a4 Revert "Generalize git index refresh to bot_update."
06e1aa07 Generalize git index refresh to bot_update.
7f12a2e4 [bootstrap/win] Roll bleeding edge entry bat.
f7543cdd git-cl: accept --force for -f everywhere
642dd84c [win/bootstrap] Use "for" instead of "set".
ca01e2c8 git cl issue 0: Remove Change-Id from message, not description
290f5f56 Remove "create-ntfs-junction".
ff9a5dec Roll recipe dependencies (trivial).
d2dbea66 Roll recipe dependencies (trivial).
fc62f768 Simplify notify behavior in git-cl
cfbb775f Roll recipe dependencies (trivial).
ae895075 Use doseq=True when re-encoding url query parameters
98681d11 Remove obsolete destination-branch-check flag
8aa774cf Fix bot_update example
dd1bc7c0 [cipd] Generate other platform suffixes.
383ace4b Fix git-crrev-parse on Mac.
e5adf612 Fix typo with --send-email [sic] flags
0ed616a4 Roll recipe dependencies (trivial).
636b13fc Let Changelist().AddComment() mark changes as Ready
68b54e78 [bootstrap/win] Upgrade Python to 2.7.13.
f3d5a114 Enable Gerrit-destination-branch check by default
31f3e63c Revert "Revert "[tryserver] Remove unused methods.""
c4dd3e82 [bootstrap/win] Remove support for legacy installs
cc27ecb0 Revert "[tryserver] Remove unused methods."
68f6f279 [bootstrap/win] Always use "cipd.bat".
3a8717e1 [bootstrap/win] Remove legacy Git support.
6bac8a84 GitHyperBlameMainTest.testBadFilename: Work around git-blame bug.
4e5207d6 git-cl issue 0: Don't operate on empty description
22a9cf54 git_footers: fix bug stdin-based message input.
02e59414 Fix bot_update's usage of the destination branch
83eb1cd5 Roll recipe dependencies (trivial).
400e989b 'git cl issue 0': Remove Change-Id
133ac1ab [tryserver] Remove unused methods.
b08ba657 git_footer: be more resilient to malformed footers
9d842bab [recipe_modules/git] Remove logging.
3d9b5881 [win_tools] Use bundled Python CIPD packages (#2).
209a681f [git] Remove hard-coded "depot_tools" Git.
e8eed65f Always copy "python.bat".
aab09ca6 Whitelist "python_bin_reldir.txt".
af5c20f5 Revert "[win_tools] Use bundled Python CIPD packages."
7dadf05d Query Gerrit for destination branch in bot_update
bf144679 [win_tools] Use bundled Python CIPD packages.
b80fac66 Roll recipe dependencies (trivial).
265255f5 [bootstrap/win] Replace "python.bat" only on downgrade.
24025d3e tryserver: add support for gerrit footers
903ea731 [activity.py] Identify Gerrit-style bug annotations in commit messages
49b8147b Add support to query a CL's branch to gerrit recipe module
4cb9d742 [bootstrap/win] Enable revert from upcoming patch.
13e88538 Ignore the ".bleeding_edge" file.
c8173825 git cl creds-check: improve report and give better recommendation.
4978917c Adjust CQ config for luci.infra.try -> luci.infra.depot_tools.try bucket move
9cb802ca Improve gerrit recipe_module example
79e897b0 [git_bootstrap] Support new Git bundles.
8af46469 Roll recipe dependencies (trivial).
1f767e17 Fix autoninja.py for ninja -t compatibility
7466d1a9 [cipd] Run client in .bat to preserve STDIN.
13f258bf Remove SVN bootstrapping and some tooling.
b12c5256 Roll recipe dependencies (trivial).
016f92e6 Roll recipe dependencies (trivial).
68506985 Roll recipe dependencies (trivial).
215ded77 Fix testFlattenPinAllDeps
271a1680 gclient flatten: implement --pin-all-deps
fb022017 gclient flatten: include vars
e36a8431 Roll recipe dependencies (trivial).
de37c012 Fix git-numberer swallowing of footers for Rietveld.
4e89144a git-cl: fix auth error message computation
7c2e05b4 [cipd] Fix CIPD bootstraps run concurrently.
aaf93f48 gclient flatten: refactor flatten code to a class
807caf84 gclient flatten: remove --require-pinned-revisions
6fbf12f2 Enable query for changes in gerrit recipe module
c6846aa2 gclient flatten: fix a bug with deps_os getting omitted for recursed deps
4baaa11c gclient: avoid adding potentially duplicate entries to work queue
d3790251 gclient: apply custom_vars when evaluating conditions
a8fdab96 Roll recipe dependencies (trivial).
e82c0dec [cipd] Fail if setup has an error.
b1ad2f04 Update CIPD client, vpython and "LUCI editor".
6a1ab843 Roll recipe dependencies (trivial).
32f0e5d7 Roll recipe dependencies (trivial).
bc9c5ccf Roll recipe dependencies (trivial).
54adb2a3 Generate initial recipes README.
603545b7 Roll recipe dependencies (trivial).
e015878d gclient flatten: fix an issue with an deps_os entry getting added to deps
6014b566 gclient flatten: also handle allowed_hosts
70b3f3aa [bot_update] Pass spec as file.
1af0a337 Roll recipe dependencies (trivial).
dc598e82 [bot_update] Prefix PATH, cleanup.

Bug: skia:
Change-Id: I0eea2dd126c130299ac39fe9b54a714cb0612563
Reviewed-on: https://skia-review.googlesource.com/32420
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
2017-08-09 12:49:04 +00:00
Ravi Mistry
8d8b016f52 Fix config in run_ct_skps.py
This stopped working after https://skia-review.googlesource.com/c/9871

Bug: skia:6934
Change-Id: I5fe88518806ba68acf2315bf06ec845ce975cf7f
Reviewed-on: https://skia-review.googlesource.com/32185
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
2017-08-08 22:13:40 +00:00