Commit Graph

46543 Commits

Author SHA1 Message Date
Mike Klein
e47b0e5055 remove misleading Uniforms apis
There's no really good reason to push uniforms in bulk
if there's no supported way to use them as an array.

Change-Id: Iaad133b96067fd570889ed1510705e4e98a351a2
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/268646
Reviewed-by: Herb Derby <herb@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
2020-02-04 18:33:48 +00:00
Mike Klein
399ef6915d thread alloc through to color filters
Change-Id: I783c32d92fac8c78e26f15a8e9bb6f43395d1d3f
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/268648
Commit-Queue: Mike Klein <mtklein@google.com>
Reviewed-by: Mike Reed <reed@google.com>
2020-02-04 18:17:08 +00:00
Jim Van Verth
b339e77937 Set NSError on compilation/link timeouts.
When compilation fails GrCompileMtlShaderLibrary expects the error
result to be set. This also allows us to print out all errors with
compilation and pipeline creation in central locations.

Change-Id: I7c3d5dda5bd46a95b55365cb0b8f07d79c030db6
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/268625
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Jim Van Verth <jvanverth@google.com>
2020-02-04 17:59:51 +00:00
Mike Klein
95712dd429 run .skps on PDF bots
Change-Id: Icd1795a5b1aa59ffcaaa60e3d409ea8a3a0e36da
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/268644
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
2020-02-04 17:54:31 +00:00
Kevin Lubick
6e1320da6b [canvaskit] Fix flaky test
We accidentally were not waiting until all font files were loaded before
trying to process them.

Bug: skia:9858
Change-Id: I10decd5fbf0aa46e300d2ce5255f24f1ac1c12d4
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/268626
Reviewed-by: Nathaniel Nifong <nifong@google.com>
2020-02-04 17:50:35 +00:00
Robert Phillips
a2406f9218 Fix BC1 SW decompression on platforms with RGBA PM color order
Bug: skia:9680
Change-Id: Ibe802ea574d749ebd601118d0e6da32b2a18fab2
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/268619
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
2020-02-04 16:10:20 +00:00
Brian Osman
2aee7d24da Ignore warnings when compiling MSL
If there are errors, newLibraryWithSource returns nil and fills
out error. If there are warnings, it returns the compiled library,
and fills out error.

With changes to invokeChild, some lighting shaders were compiling
with warnings (unused variables).

Bug: skia:9830
Change-Id: I93f9f88998c64c8b4dbd64b81b6b7ab08921b9d2
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/268622
Reviewed-by: Ethan Nicholas <ethannicholas@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2020-02-04 15:37:00 +00:00
Florin Malita
d589916ebc Potentially-uninitialized Sk3LookAt result
Bug: oss-fuzz:20520
Change-Id: I383881571fa156c6faa5e798a1e126bb9e5e8dd0
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/268621
Commit-Queue: Florin Malita <fmalita@chromium.org>
Reviewed-by: Mike Reed <reed@google.com>
2020-02-04 15:31:30 +00:00
Mike Klein
4bcab23423 tweak screen math
Seems to help get past our r,g,b <= a asserts better.
I guess it keeps more precision from the small s*d term?

    Old:  (s+d) - (s*d)
    New:  s + (d - (s*d))

Change-Id: Ib9b9472e2c08aef688bbfdbccaf0bd45b7bf3ecd
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/268592
Commit-Queue: Mike Klein <mtklein@google.com>
Auto-Submit: Mike Klein <mtklein@google.com>
Reviewed-by: Mike Reed <reed@google.com>
2020-02-04 15:31:00 +00:00
Robert Phillips
d095b9f5d7 Fix SW decompression of BC1 and add a GM to check it (take 2).
Bug: skia:9680
Change-Id: I59a4c18f7ba7d04162715cfcbeefd70f84609edb
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/268439
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
2020-02-04 13:41:10 +00:00
Edward Lemur
2b7876cd04 Modify PostUploadHooks to remove dependency on cl objects.
In order to enable Python 3 migration, presubmit needs
to stop depending on git-cl internal objects.

Depends on [1] and [2].

[1] https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2007670
[2] https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2007262

Bug: 1042324
Change-Id: I84f48cf7915dc1d95979bd99e839c0bec4348d6d
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/265209
Auto-Submit: Edward Lemur <ehmaldonado@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2020-02-04 11:18:20 +00:00
skia-autoroll
71ce449d28 Roll third_party/externals/angle2 49a53d684aff..aa6dd50de0c5 (5 commits)
49a53d684a..aa6dd50de0

git log 49a53d684aff..aa6dd50de0c5 --date=short --first-parent --format='%ad %ae %s'
2020-02-03 geofflang@chromium.org Share scratch buffers between contexts.
2020-02-03 tdusnoki@inf.u-szeged.hu Skip failing end2end tests on Windows on ARM
2020-02-03 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-validation-layers/src bd4b3a888fca..e85fe4c3cc9f (3 commits)
2020-02-03 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/SwiftShader 79b36b640692..41a7302e9c62 (3 commits)
2020-02-03 cclao@google.com Remove getIndexRange call from ValidateDrawRangeElements

Created with:
  gclient setdep -r third_party/externals/angle2@aa6dd50de0c5

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-skia-autoroll
Please CC scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia/skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC8i5BEK-GPU-IntelIris655-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE
Bug: None
Tbr: scroggo@google.com
Change-Id: I958caad48e20be720854b64958c5f564b963e4a3
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/268562
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2020-02-04 04:47:28 +00:00
recipe-roller
c226530490 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (depot_tools) into this repository.

depot_tools:
  https://crrev.com/d7c06ac64d54e53648a164c6b47e35608dcb6a89 (ehmaldonado@google.com)
    presubmit_unittest: Mock time_time for ThreadPoolTest
  https://crrev.com/e93101895e74bae915fb1f456d15c21751cbd41d (ynovikov@chromium.org)
    Also set LIBPATH in Windows toolchain environment

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I1c3642b3f7288442c2066a6e4c4e4e3843e6a91c
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/268519
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
2020-02-04 00:39:37 +00:00
Mike Klein
0772b4bd33 Reland "unorm/unorm -> to_unorm/from_unorm"
This is a reland of cd4e5662ac

Original change's description:
> unorm/unorm -> to_unorm/from_unorm
> 
> Just better names, no real change.
> 
> Change-Id: I7a67ccb49d5367137b6a1f100434cb866f15ea71
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/268389
> Auto-Submit: Mike Klein <mtklein@google.com>
> Reviewed-by: Herb Derby <herb@google.com>
> Commit-Queue: Mike Klein <mtklein@google.com>

Change-Id: I2843cf77a4b3c8888ef835b2ad5045d900d44e3a
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/268516
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
2020-02-04 00:19:31 +00:00
Mike Reed
f6d668ec28 Reland "add skvm for tablecolorfilter"
This is a reland of bf3087f65d

Original change's description:
> add skvm for tablecolorfilter
> 
> Change-Id: I712bf165a8af956f7447cb4c43949a4abcb2fea6
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/268308
> Reviewed-by: Mike Klein <mtklein@google.com>
> Commit-Queue: Mike Klein <mtklein@google.com>

Change-Id: I76be0303a7df1db2ecd95a49ff6f29db2b8e41c0
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/268502
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
2020-02-03 23:50:41 +00:00
Mike Klein
59cd566536 gather pointers are not necessarily aligned
The pointers in the uniforms are copied in 4 byte
chunks and are not necessarily sizeof(void*) aligned.

Change-Id: Ied066faf8026cd30d72b88490883649c3624e763
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/268498
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
2020-02-03 23:34:02 +00:00
Mike Klein
6c80d24b5f Revert "add skvm for tablecolorfilter"
This reverts commit bf3087f65d.

Reason for revert: exposed at least one latent bug, I think.  Will reland as I can fix them.

Original change's description:
> add skvm for tablecolorfilter
> 
> Change-Id: I712bf165a8af956f7447cb4c43949a4abcb2fea6
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/268308
> Reviewed-by: Mike Klein <mtklein@google.com>
> Commit-Queue: Mike Klein <mtklein@google.com>

TBR=mtklein@google.com,reed@google.com

Change-Id: Iee6f64c70fed41230ad5de5c0fd34e915741102a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/268497
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
2020-02-03 22:41:21 +00:00
Mike Klein
8feac2d718 Revert "unorm/unorm -> to_unorm/from_unorm"
This reverts commit cd4e5662ac.

Reason for revert: reverting dependent changes

Original change's description:
> unorm/unorm -> to_unorm/from_unorm
> 
> Just better names, no real change.
> 
> Change-Id: I7a67ccb49d5367137b6a1f100434cb866f15ea71
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/268389
> Auto-Submit: Mike Klein <mtklein@google.com>
> Reviewed-by: Herb Derby <herb@google.com>
> Commit-Queue: Mike Klein <mtklein@google.com>

TBR=mtklein@google.com,herb@google.com,reed@google.com

Change-Id: I0afc659ad0bb9e5145873aaad559ceaf2b70ee0d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/268496
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
2020-02-03 22:40:41 +00:00
Mike Klein
c66882ebcd Revert "impl gather8/gather16 with gather32"
This reverts commit d4e3b9e8bc.

Reason for revert: will reland with fixes

Original change's description:
> impl gather8/gather16 with gather32
> 
> This is our quick path to JIT small gathers.
> 
> The idea is roughly,
> 
>    const uint32_t* ptr32 = ptr8;
>    uint32_t abcd = ptr32[ix/4];
>    switch (ix & 3) {
>      case 3: return (abcd >> 24)       ;
>      case 2: return (abcd >> 16) & 0xff;
>      case 1: return (abcd >>  8) & 0xff;
>      case 0: return (abcd      ) & 0xff;
>    }
> 
> With the idea that if we may load a given byte,
> we should also be allowed to load the four byte
> aligned word that byte falls within.
> 
> Change-Id: I7fb1085306050c918ccf505f1d2e1e87db3b8c9a
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/268381
> Reviewed-by: Herb Derby <herb@google.com>
> Commit-Queue: Mike Klein <mtklein@google.com>

TBR=mtklein@google.com,herb@google.com,reed@google.com

Change-Id: I48d800edc6517f37e04752c91616b666a5e0f384
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/268490
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
2020-02-03 21:55:22 +00:00
Herb Derby
c1d71d367c Arrange atlas image processing by frequency
Change-Id: I19948ba003c203805d145eb8dc644142573f3646
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/268456
Commit-Queue: Herb Derby <herb@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
2020-02-03 21:55:21 +00:00
Jim Van Verth
073d271864 Fix timeout for Metal compiler.
dispatch_time() takes nanoseconds, not microseconds.

Change-Id: Ia292eef0373fc8e48e6cc900f106ddf438cd74f1
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/268440
Commit-Queue: Jim Van Verth <jvanverth@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
Auto-Submit: Jim Van Verth <jvanverth@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
2020-02-03 21:36:21 +00:00
recipe-roller
d129e08366 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (depot_tools) into this repository.

depot_tools:
  https://crrev.com/69bb8bef75ff327e3a116ba9f3842cefa618d6f5 (ehmaldonado@google.com)
    presubmit_support: Support getting and adding footers.
  https://crrev.com/e4d329cc008260fcd2450d08cd827b118572c2ec (ehmaldonado@google.com)
    presubmit_support: Add support for setting the change description.

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ibecece670ed89e0be7e6aeee7712061eb2472c5c
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/268478
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
2020-02-03 21:11:25 +00:00
Robert Phillips
ab5da1f6b6 Revert "Fix SW decompression of BC1 and add a GM to check it."
This reverts commit 4238751bc3.

Reason for revert: This appears to be turning the PreAbandonGpuContext bot red

Original change's description:
> Fix SW decompression of BC1 and add a GM to check it.
> 
> Bug: skia:9680
> Change-Id: I8a8f9ee1aad783fc247c5516ac1effd0dab25936
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/268158
> Commit-Queue: Robert Phillips <robertphillips@google.com>
> Reviewed-by: Brian Osman <brianosman@google.com>

TBR=robertphillips@google.com,brianosman@google.com

Change-Id: I4304f13453579eb3ee6d3c0febe8c94ebfe915b2
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: skia:9680
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/268438
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
2020-02-03 21:03:41 +00:00
Robert Phillips
4238751bc3 Fix SW decompression of BC1 and add a GM to check it.
Bug: skia:9680
Change-Id: I8a8f9ee1aad783fc247c5516ac1effd0dab25936
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/268158
Commit-Queue: Robert Phillips <robertphillips@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
2020-02-03 20:42:31 +00:00
Greg Daniel
cc104db12c Have GrTextureProducer return views instead of proxies.
Bug: skia:9556
Change-Id: Ieedb9c48914c637278203d4d462c19b2d85b27d4
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/268396
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Greg Daniel <egdaniel@google.com>
2020-02-03 20:42:21 +00:00
Mike Klein
cd4e5662ac unorm/unorm -> to_unorm/from_unorm
Just better names, no real change.

Change-Id: I7a67ccb49d5367137b6a1f100434cb866f15ea71
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/268389
Auto-Submit: Mike Klein <mtklein@google.com>
Reviewed-by: Herb Derby <herb@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
2020-02-03 20:25:21 +00:00
Herb Derby
70c5fcc6d6 Move the bulk glyph calls up the stack
Moving this call up the stack gets thing in a better position
to bulkify this whole call stack.

Clean up some of the API to make more sense.

Change-Id: Iad7aca81f60b74a61344ff0679c1c323c49b7f48
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/268436
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Herb Derby <herb@google.com>
2020-02-03 20:21:01 +00:00
Mike Reed
bf3087f65d add skvm for tablecolorfilter
Change-Id: I712bf165a8af956f7447cb4c43949a4abcb2fea6
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/268308
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
2020-02-03 19:49:41 +00:00
Mike Klein
d4e3b9e8bc impl gather8/gather16 with gather32
This is our quick path to JIT small gathers.

The idea is roughly,

   const uint32_t* ptr32 = ptr8;
   uint32_t abcd = ptr32[ix/4];
   switch (ix & 3) {
     case 3: return (abcd >> 24)       ;
     case 2: return (abcd >> 16) & 0xff;
     case 1: return (abcd >>  8) & 0xff;
     case 0: return (abcd      ) & 0xff;
   }

With the idea that if we may load a given byte,
we should also be allowed to load the four byte
aligned word that byte falls within.

Change-Id: I7fb1085306050c918ccf505f1d2e1e87db3b8c9a
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/268381
Reviewed-by: Herb Derby <herb@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
2020-02-03 19:47:41 +00:00
Brian Salomon
63a04a8701 Choose a less evil scale factor texel_subset_nearest_upscale decal tests
The existing scale factor put the decal edge exactly on a pixel center
causing some jaggies as different row columns has slightly different
interpolated values and fell on different sides of the decal edge,

Change-Id: I396395f68366e3cfc3b0c0ce11466c43dd4e60ea
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/268306
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
2020-02-03 19:21:21 +00:00
Florin Malita
af99f3ee60 [skottie] Cleanup: finalize adapter conversion
Convert remaining bindProperty clients to adapters, and remove the
legacy API.

TBR=
Change-Id: I06eda513a75b55a1ba7eae328b0916e738c9ddd7
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/268309
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Florin Malita <fmalita@chromium.org>
2020-02-03 18:56:01 +00:00
Mike Klein
bc1ce2c0ca test premul/unpremul are no-ops when a==1.0f
Constant propagation means we can always notionally
unpremul and premul at the right points, and if alpha
was already opaque, they'll just drop away.

This has been true, but it's nice to put a test on it.

Change-Id: Iacd2002d9e1a10b73e800a452f377001d5ba3777
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/268336
Auto-Submit: Mike Klein <mtklein@google.com>
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
2020-02-03 18:51:05 +00:00
Sean Gilhuly
23e2ad174c SkiaDawn: Connect GrIOType in onWrapBackendTexture
Pass the GrIOType parameter through to GrDawnTexture::MakeWrapped(), and
flag the texture as read-only if necessary. For renderable backend
textures, use the read-write io type.

This fixes an assertion failure in GrTextureProxy::onValidateSurface().

Change-Id: Ia55fe6ccfdd42dc426524947b69f28199de8282b
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/255861
Commit-Queue: Stephen White <senorblanco@chromium.org>
Reviewed-by: Stephen White <senorblanco@chromium.org>
2020-02-03 18:33:09 +00:00
Leon Scroggins III
196f319b72 Allow decoding without color conversion
Bug: b/135133301

Especially for the Android NDK, which may not be able to report the
default profile, we should be able to decode the image without doing
any color correction. That way if the client wants to figure out
the color profile on their own (e.g. by parsing the data manually),
they can retrieve the un-corrected pixels and treat them appropriately.

Note that internally, we still require a destination profile for F16,
but we will use the source profile if there is one, or SRGB for source
and destination otherwise. Regardless, this will result in no color
correction.

Change-Id: Id1157bb99d3119a114b25f64b38620480a027f34
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/268157
Reviewed-by: Mike Klein <mtklein@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Leon Scroggins <scroggo@google.com>
2020-02-03 18:21:35 +00:00
recipe-roller
d33f5746e3 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (depot_tools) into this repository.

depot_tools:
  https://crrev.com/852d4aa1ba411c3d255330e9f3931654c356f538 (ynovikov@chromium.org)
    Don't drop windows.winmd when packaging Windows toolchain

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Iba3aa3393fb194b04bbbaf20e13882190125fd63
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/268331
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
2020-02-03 18:20:35 +00:00
Robert Phillips
eb77a76301 Make exoticformats GM a bit easier to triage
This makes it easier to see the red stroke around decompressed images.

Change-Id: I937dca205e0d1966ac0df27f4a8943850ddb54ff
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/268307
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
2020-02-03 18:04:25 +00:00
Herb Derby
5ddc34ca3d Remove 565 mask data from GrStrikeCache to constexpr varialbe
Move the 565 from the GrStrikeCache to the routine that uses it.
Remove all the plumbing needed to get it there.
Remove unused variable from GrStrikeCache's ctor.

Change-Id: I6d6630ace0e22ec9c4f68e4c359beda6354c323f
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/268168
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Herb Derby <herb@google.com>
2020-02-03 16:27:05 +00:00
Brian Salomon
1fe3c3d183 Use GrTextureEffect::MakeTexelSubset instead of MakeSubset in SkGpuBlurUtils
Change-Id: Ia3dad5cb12c3eb9526322fa846409c935e26d01a
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/268303
Reviewed-by: Michael Ludwig <michaelludwig@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
2020-02-03 16:13:55 +00:00
Jim Van Verth
fb39510008 Reland "Wrap page index packing in helper methods."
Also simplifies the shaders if we know there's only one atlas texture.

Reviewed-on: https://skia-review.googlesource.com/c/skia/+/266566
Commit-Queue: Jim Van Verth <jvanverth@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
Change-Id: Ibb21fa19b067879da411e9f08e1cc9275627cae9
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/268302
Reviewed-by: Jim Van Verth <jvanverth@google.com>
2020-02-03 15:38:35 +00:00
Leon Scroggins III
1ac12c4e4c Update link to BreakingTheBuildBots bugs
The old link just took me to a list of all open Skia bugs.

No-Try: true
Docs-Preview: https://skia.org/?cl=268300
Change-Id: I739d9243c7431df4704e0427c6958ea6a577cb24
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/268300
Auto-Submit: Leon Scroggins <scroggo@google.com>
Reviewed-by: Ravi Mistry <rmistry@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
2020-02-03 14:54:34 +00:00
Robert Phillips
d4f68317fe Add SW decode of ETC1 and a GM
The GM exercises the compressed image formats using externally created resources

Note: the original image for the new flower resources can be found on Wikimedia Commons and has a "CC0 1.0 Universal Public Domain Dedication" license.

Bug: skia:9680
Change-Id: I6c5f9a12fcbbecdc3ba548dbb078bc21522073fe
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/267836
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
2020-02-03 13:56:15 +00:00
skia-autoroll
9e8d8c4830 Roll third_party/externals/angle2 e196bc85ac2d..49a53d684aff (18 commits)
e196bc85ac..49a53d684a

git log e196bc85ac2d..49a53d684aff --date=short --first-parent --format='%ad %ae %s'
2020-02-01 syoussefi@chromium.org Vulkan: Request used features
2020-02-01 kbr@chromium.org Disable rewriteRowMajorMatrices workaround.
2020-02-01 spang@chromium.org Fuchsia: Switch ScenicWindow to use PresentOrReplaceView
2020-02-01 spang@chromium.org Fuchsia: Limit number of concurrent presents in ScenicWindow
2020-02-01 geofflang@chromium.org Mark MemoryBuffer allocation functions as NO_DISCARD
2020-01-31 tobine@google.com Vulkan: Remove transient cmd buffer workaround
2020-01-31 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-validation-layers/src 8317b28e672a..bd4b3a888fca (27 commits)
2020-01-31 ynovikov@chromium.org Add UWP builders to CQ
2020-01-31 jgilbert@mozilla.com Allow overriding ANGLE_PLATFORM_EXPORT.
2020-01-31 cclao@google.com Vulkan: Disable restartRenderPassAfterLoadOpClear workaround
2020-01-31 cnorthrop@google.com Capture/Replay: Implement Manhattan ES 3.0 support
2020-01-31 syoussefi@chromium.org Vulkan: Fix UtilsVk dirtying driver uniforms descriptor set binding
2020-01-31 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/SwiftShader 6c3dc3581eaf..79b36b640692 (13 commits)
2020-01-31 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-tools/src ebe1b7497acb..260679605f98 (1 commits)
2020-01-31 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-loader/src 44ac9b2f406f..fb94ccddb725 (1 commits)
2020-01-31 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/spirv-tools/src 97f1d485b763..7a2d408dea60 (4 commits)
2020-01-31 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/glslang/src 9a80305c0897..5e86b28ffb81 (1 commits)
2020-01-31 ynovikov@chromium.org Change uuid attributes to declspec in winrt.

Created with:
  gclient setdep -r third_party/externals/angle2@49a53d684aff

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-skia-autoroll
Please CC scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia/skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC8i5BEK-GPU-IntelIris655-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE
Bug: None
Tbr: scroggo@google.com
Change-Id: I86587b0c6c758694b881d9ce8e8d9dc9d5160703
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/268265
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2020-02-03 04:34:33 +00:00
skia-autoroll
fee22c7ade Roll third_party/externals/swiftshader 79b36b640692..41a7302e9c62 (3 commits)
https://swiftshader.googlesource.com/SwiftShader.git/+log/79b36b640692..41a7302e9c62

git log 79b36b640692..41a7302e9c62 --date=short --first-parent --format='%ad %ae %s'
2020-01-31 capn@google.com Split JIT creation from LLVMReactor.cpp into LLVMJIT.cpp
2020-01-31 bclayton@google.com CMake: Add build rules for google benchmark.
2020-01-31 bclayton@google.com Add google benchmark submodule to third_party.

Created with:
  gclient setdep -r third_party/externals/swiftshader@41a7302e9c62

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-skia-autoroll
Please CC scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Test-Debian9-Clang-GCE-GPU-SwiftShader-x86_64-Debug-All-SwiftShader
Bug: None
Tbr: scroggo@google.com
Change-Id: Ic9a11d4053227cc3ccabf01d40d6341ff2abda25
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/268266
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2020-02-03 04:34:27 +00:00
Brian Salomon
f1e316ff39 Make lines in texel_subset GM be at half pixel offsets
As it stands they're at integers and so snap differently on different
GPUs.

Change-Id: I80b955a728aa590af12d9307ba2c36731d333594
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/268170
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
2020-02-02 13:23:52 +00:00
skia-recreate-skps
cca2964cef Update Go Deps
Change-Id: I6c67fdced94a5837507dd880ef931f9c7eeb2215
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/268257
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
2020-02-02 05:24:51 +00:00
Brian Salomon
f033404de8 Improvements to texture_domain GMs
Rename to texel_subset.

Test different x/y wrap modes.

Use a real image that is non-square.

Add dividers to group MakeTexelSubset() with Make() reference draw.

Use a smaller image, fewer matrices, and only one subset rect to
make room for the additional mode combinations.

Change-Id: I3fab54cb7f160b92c7e5192e64a8a09f5c837492
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/267976
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
2020-02-01 22:27:31 +00:00
Herb Derby
3d05192abe Simplify subrun atlas generation tracking
The atlas generation's tracking was in two places. Gather
all into regenerate.

Gather more of the bulk use tracking into regenerate, and
cleanup some of the bulk use comments.

Change-Id: I87727b087d4605de9fa4684f4662fa49dc424863
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/268164
Commit-Queue: Herb Derby <herb@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
2020-02-01 22:06:21 +00:00
Brian Osman
5d92ae2b56 Implement constantOutputForConstantInput in GrColorSpaceXformEffect
Change-Id: I70e932a344d462e7d726d29285981f25214d9360
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/268161
Reviewed-by: Brian Salomon <bsalomon@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2020-02-01 14:33:31 +00:00
skia-recreate-skps
776293dcee Update Go Deps
Change-Id: I1eb2d7597da5f2c46e8e6a298557ec74e82e6a91
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/268203
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
2020-02-01 05:26:00 +00:00
Andrew Grieve
133177bd12 Add missing "const" to SkMD5::finish::PADDING
This moves it from .data to .rodata ELF section (more efficient)

Bug: chromium:747064
Change-Id: I4d12ce6622bd9d1264d46e48855a43f00671bee4
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/268200
Auto-Submit: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Mike Klein <mtklein@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
2020-02-01 03:21:51 +00:00