Organize code that will need to be the same into one file.
Have the template implementation confined to the .cpp
Change-Id: I0b256fe538566701c2a72e9f286b373b87f8bdb0
Reviewed-on: https://skia-review.googlesource.com/c/168272
Commit-Queue: Herb Derby <herb@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
We can make tracking whether we've sent a type already a bit more
streamlined by avoiding this string copy, and while we're at it, using a
smaller unique key, the type factory pointer.
This doesn't change the wire protocol of how we send across flattenable
types... first as a name string, then each time after as a 24-bit int.
The factory pointers still never hit the wire, so this can continue to
work cross-process.
Change-Id: I1ee754971dc48d56b5d62561d8e83209f1e33728
Reviewed-on: https://skia-review.googlesource.com/c/168264
Commit-Queue: Mike Klein <mtklein@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
37297a4f14..3d86e89bce
git log 37297a4f1440..3d86e89bce7a --date=short --no-merges --format='%ad %ae %s'
2018-11-05 syoussefi@chromium.org Vulkan: properly handle 0-width or 0-height framebuffers
Created with:
gclient setdep -r third_party/externals/angle2@3d86e89bce7a
The AutoRoll server is located here: https://autoroll.skia.org/r/angle-skia-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE
TBR=allanmac@google.com
Change-Id: I8a274abda334950d5a7f9c979f45f5cd67385544
Reviewed-on: https://skia-review.googlesource.com/c/168380
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
This class pertaining to painting into the Painter files. Reduce
the number of includes used in SkGlyphRun.
Change-Id: Iae00d57c85079b91cc6672d1ba1d52556a7e299d
Reviewed-on: https://skia-review.googlesource.com/c/168266
Reviewed-by: Ben Wagner <bungeman@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Herb Derby <herb@google.com>
Bug: skia:7901
Change-Id: I99cde1acc27c1cfb730671463a2c17537926cd99
Reviewed-on: https://skia-review.googlesource.com/c/164696
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Jim Van Verth <jvanverth@google.com>
This should make the logs in the bots more actionable by showing
the error and trace.
This also fixes the API change causing mysterious red.
Bug: skia:
Change-Id: I38df2bb4557041f8bdfefcae5c8d95b58e770033
Reviewed-on: https://skia-review.googlesource.com/c/168180
Reviewed-by: Kevin Lubick <kjlubick@google.com>
To support wacky explicit AE line breaking:
* add sksg::TextBlob (SG node backed by externally-built text blobs)
* add skottie::TextAdapter logic to handle \r line breaks and construct
the blob explicitly
Change-Id: I2eed9adf28a8c3c1f7de5bbec3d32abd7ddbd484
Reviewed-on: https://skia-review.googlesource.com/c/167384
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Florin Malita <fmalita@chromium.org>
This also does some clean up to how we name enums - the caps felt a bit
obnoxious. CAPS are reserved now for constants (like colors).
Small bug fix with leaking memory on discrete path effects
This also adds a few more things from PathKit
Bug: skia:
Change-Id: Iad7e21ac36d35a36a8b255dc82b1dcc886344db1
Reviewed-on: https://skia-review.googlesource.com/c/166804
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Mike Reed <reed@google.com>
This focuses the use of legacy blitters to situations where:
- there's a shader (and it can make a shader context); or
- the blend mode is SrcOver; or
- both
I've guarded this by SK_LEGACY_OP_COLOR_AS_BYTES, which is odd I know,
but I think we have no plans to actually use that to rebaseline anything
about op-color-bytes, and it's already in Chromium's SkUserConfig.h.
Change-Id: I04f80e6cef3c859a726bcd32931d0c0940ef5b61
Reviewed-on: https://skia-review.googlesource.com/c/167264
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
This reverts commit 2904121cd0.
Reason for revert: :(
Original change's description:
> Remove one field of unique data from SkGlyphCacheBuilder
>
> Change-Id: I9ba6e17de999933f1f71673fc98b21ab30e28e10
> Reviewed-on: https://skia-review.googlesource.com/c/167924
> Reviewed-by: Brian Osman <brianosman@google.com>
> Commit-Queue: Herb Derby <herb@google.com>
TBR=herb@google.com,brianosman@google.com
Change-Id: If95f1762c5c7993bdbdcd5027872a546db427e72
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/c/168026
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
6ba22ee137..37297a4f14
git log 6ba22ee13768..37297a4f1440 --date=short --no-merges --format='%ad %ae %s'
2018-11-02 ynovikov@chromium.org Don't build VulkanCommandBufferPerfTest on Linux
2018-11-02 geofflang@chromium.org Add a spec and tests for GL_ANGLE_memory_size.
2018-11-02 syoussefi@chromium.org Implement missing posix utils
Created with:
gclient setdep -r third_party/externals/angle2@37297a4f1440
The AutoRoll server is located here: https://autoroll.skia.org/r/angle-skia-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE
TBR=herb@google.com
Change-Id: I24229dcaf2eb211538200ec3990025adcbf4b849
Reviewed-on: https://skia-review.googlesource.com/c/168080
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Change-Id: I9ba6e17de999933f1f71673fc98b21ab30e28e10
Reviewed-on: https://skia-review.googlesource.com/c/167924
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Herb Derby <herb@google.com>
Bug: skia:
Change-Id: I6b3ad32c582504503eaa41374ba3f618b92b0414
Reviewed-on: https://skia-review.googlesource.com/c/167943
Commit-Queue: Brian Osman <brianosman@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
Auto-Submit: Brian Osman <brianosman@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
Bug: skia:
Change-Id: I294e70708aab2c39a6077a11de76518c6fe7f712
Reviewed-on: https://skia-review.googlesource.com/c/167941
Commit-Queue: Brian Osman <brianosman@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
Bug: skia:7903
Change-Id: I98a3133384d9ddb9cbc17da85fc175dc5ad559f2
Reviewed-on: https://skia-review.googlesource.com/c/167940
Commit-Queue: Jim Van Verth <jvanverth@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
Auto-Submit: Jim Van Verth <jvanverth@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I2b5fff033ae132334aa9ffcc312b330de81fb3d5
Reviewed-on: https://skia-review.googlesource.com/c/167920
Commit-Queue: Brian Osman <brianosman@google.com>
Auto-Submit: Mike Klein <mtklein@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
I kept reading and re-reading the existing logic and couldn't figure it
out until I looked at the AlphaOption enum. I think this direction
reads a bit more clearly.
(This is why we have those ->premul methods. Oddly, we fail for 4444.)
Change-Id: I74ea2e380d5ab9526ea1e6412929346ad9c0ead6
Reviewed-on: https://skia-review.googlesource.com/c/167921
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
This keeps the special handling for Alpha8 and Gray8. All other formats
are converted to 8888. To make everything simpler, we always convert to
kBGRA, so we can just use SkColor macros to get the components.
This maintains the neighbor-averaging for fully transparent pixels, but
the implementation is slightly different. Before, we averaged RGB and A
while the pixels were premul, then unpremultiplied. Now, we pre-convert
everything to unpremul, then just average RGB over the (not fully
transparent) neighbors.
Bug: skia:
Change-Id: Ib5a0d8536e2507952a44365347518b2d57d07549
Reviewed-on: https://skia-review.googlesource.com/c/167660
Commit-Queue: Brian Osman <brianosman@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
caeb1e895d..6ba22ee137
git log caeb1e895d7b..6ba22ee13768 --date=short --no-merges --format='%ad %ae %s'
2018-11-02 geofflang@chromium.org GL: Implement EGL_ANDROID_get_frame_timestamps.
2018-11-02 james.clarke@microsoft.com Windows: add support for SpriteVisuals as a native window type.
2018-11-02 jiajia.qin@intel.com ES31: Simplify IsInShaderStorageBlock function
Created with:
gclient setdep -r third_party/externals/angle2@6ba22ee13768
The AutoRoll server is located here: https://autoroll.skia.org/r/angle-skia-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE
TBR=herb@google.com
Change-Id: Iac2b21ffe2d5950c699fa73e3761feb70233f9a4
Reviewed-on: https://skia-review.googlesource.com/c/167900
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I8c0e47933538034a2ea6f77f86b4d2694014e6b3
Reviewed-on: https://skia-review.googlesource.com/c/167686
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
Bug: skia:
Change-Id: Ia82461153d7f263e7cda34dc9c98d588b3c5351c
Reviewed-on: https://skia-review.googlesource.com/c/167880
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
