rmistry
25f8538492
Add stephana@ to the list of Skia CQ commiters.
...
Note: This will take effect only after the Skia CQ is restarted
NOTRY=True
(SkipBuildbotRuns)
R=epoger@google.com
Author: rmistry@google.com
Review URL: https://codereview.chromium.org/469753002
2014-08-13 06:11:09 -07:00
rmistry
b2721f7372
Whitespace change to test the CQ commit message
...
(SkipBuildbotRuns)
TBR=
BUG=chromium:308792
NOTRY=true
Author: rmistry@google.com
Review URL: https://codereview.chromium.org/470603002
2014-08-13 05:36:43 -07:00
george
b62508be81
Add a parameter GR_ALWAYS_ALLOCATE_ON_HEAP to allow for only ever creating temporary buffers on the heap instead of allowing stack allocation
...
Unfortunately this can't be a GR_GL_* config like we'd discussed because there are SkAutoSMalloc buffers that are built outside of gl/
R=bsalomon@google.com , bsalomon
BUG=skia:
Author: george@mozilla.com
Review URL: https://codereview.chromium.org/459263003
2014-08-12 18:00:47 -07:00
dandov
cc03adb909
Proposal for the mesh gradient interface. Implemented as a grid of
...
patches and uses 4 private arrays to store the values of the control points and
colors. When it needs a patch at a certain position of the grid it just
builds it using the corresponding values of the array and the
grid coordinates provided. Details on implementation are documented in the corresponding classes' comments.
Also added a gm for mesh gradients.
BUG=skia:
R=egdaniel@google.com , reed@google.com
Author: dandov@google.com
Review URL: https://codereview.chromium.org/451723003
2014-08-12 17:14:57 -07:00
borenet
dc065f2c20
whitespace
...
BUG=skia:
TBR=bungeman
Author: borenet@google.com
Review URL: https://codereview.chromium.org/461123002
2014-08-12 13:02:26 -07:00
krajcevski
d211c547cb
Turn off pedantic blit rect
...
R=robertphillips@google.com
Author: krajcevski@google.com
Review URL: https://codereview.chromium.org/460253003
2014-08-12 12:48:18 -07:00
fmalita
9f49cfdbf6
Add missing DRAW_PICTURE_MATRIX_PAINT paint offset.
...
Also remove explicit gPaintOffsets sizing to make the existing compile
time size check effective.
R=reed@google.com , robertphillips@google.com
Author: fmalita@chromium.org
Review URL: https://codereview.chromium.org/467683003
2014-08-12 12:24:18 -07:00
tomhudson
94fa4b99e2
Update path to Android font config file
...
In version LMP, Android is expected to change the path to their font
configuration file (and condense several files into one), as well as
changing the format (qv http://crrev.com/446473003/ ). This patch tries
the new path before falling back to the old path.
The new fonts are incompatible with assumptions made by the old
SkFontConfigInterfaceAndroid, so this patch MUST NOT land until
https://crrev.com/462073002/ or the equivalent has turned on the
new SkFontManager.
BUG=chromium:400801
R=djsollen@google.com , bungeman@google.com , tomhudson@google.com
Author: tomhudson@chromium.org
Review URL: https://codereview.chromium.org/458543002
2014-08-12 11:05:29 -07:00
tomhudson
8e69676bf5
Turn on FontMgr for Android
...
Minimal change for activating the SkFontMgr on Android, broken out
of http://crrev.com/445143002/ .
BUG=chromium:400801
R=bungeman@google.com , djsollen@google.com , tomhudson@google.com
Author: tomhudson@chromium.org
Review URL: https://codereview.chromium.org/462073002
2014-08-12 10:55:09 -07:00
robertphillips
e94707505e
Update tools for use of picture stats in GPU optimization decision
...
R=bsalomon@google.com
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/466733004
2014-08-12 10:12:40 -07:00
halcanary
dea60f6db3
Replace LLU with ULL to make VS2012 work again.
...
R=bungeman@google.com
Author: halcanary@google.com
Review URL: https://codereview.chromium.org/458663004
2014-08-12 09:28:57 -07:00
halcanary
78ee93f545
Revert of SkImage::NewFromGenerator(SkImageGenerator*), and a unit test. ( https://codereview.chromium.org/465823003/ )
...
Reason for revert:
Mac bots are failing
Original issue's description:
> SkImage::NewFromGenerator(SkImageGenerator*), and a unit test.
>
> Committed: https://skia.googlesource.com/skia/+/186f7b04956a1742f185a4ca69b44b52bc50e7fc
R=reed@google.com
TBR=reed@google.com
NOTREECHECKS=true
NOTRY=true
Author: halcanary@google.com
Review URL: https://codereview.chromium.org/453723003
2014-08-12 09:07:08 -07:00
tfarina
35fbd014e3
Migrate SkRTConfRegistry test to DEF_TEST().
...
BUG=None
TEST=dm --tests=true --gms=false
R=mtklein@google.com , bsalomon@google.com
Author: tfarina@chromium.org
Review URL: https://codereview.chromium.org/444303002
2014-08-12 09:03:16 -07:00
dandov
b3c9d1c33c
SkCanvas::drawPatch param SkPoint[12]
...
drawPatch now receives as parameter const SkPoint cubics[12]
Adjusted derived classes and serialization.
Ajusted GM's and benches that take into account combinations of optional
parameters, the scale of the patch and 4 different types of patches.
Planning on adding the extra functionality of SkPatch in another CL.
BUG=skia:
R=egdaniel@google.com , reed@google.com
Author: dandov@google.com
Review URL: https://codereview.chromium.org/463493002
2014-08-12 08:34:29 -07:00
epoger
9c7695b0b5
rebaseline_server: periodically log tasks_queue size
...
Without this, it's hard to tell whether the server is stuck (or why it's taking so long).
NOTRY=true
R=stephana@google.com , rmistry@google.com
Author: epoger@google.com
Review URL: https://codereview.chromium.org/454953002
2014-08-12 08:30:10 -07:00
epoger
8d66dd1d43
change setA/setB labels if viewing actuals vs expectations
...
NOTRY=true
R=rmistry@google.com
Author: epoger@google.com
Review URL: https://codereview.chromium.org/451053004
2014-08-12 08:29:05 -07:00
Brian Salomon
b0c855146d
Mark degeneratesegments GM as flakly on nvpr/ubuntu/debug
...
BUG=skia:2826
Review URL: https://codereview.chromium.org/456653005
2014-08-12 11:19:54 -04:00
Brian Salomon
0a82f5be21
Rebaseline current failures and those ignored for GPU rect change.
...
BUG=skia:
Review URL: https://codereview.chromium.org/460343003
2014-08-12 11:10:35 -04:00
halcanary
186f7b0495
SkImage::NewFromGenerator(SkImageGenerator*), and a unit test.
...
R=reed@google.com
Author: halcanary@google.com
Review URL: https://codereview.chromium.org/465823003
2014-08-12 08:04:58 -07:00
caryclark
5e27e0eb1d
fix pathops skp-derived bugs; add more failing tests
...
TBR=
Author: caryclark@google.com
Review URL: https://codereview.chromium.org/463883002
2014-08-12 07:46:33 -07:00
tomhudson
b3d4af512e
Fix lower-casing error in font config parser
...
The Android font config parser was missing some SkAutoAsciiToLC
instantiations; this was discovered in https://crrev.com/458543002/
but should land independently.
BUG=chromium:400801
R=bungeman@google.com
Author: tomhudson@chromium.org
Review URL: https://codereview.chromium.org/465973002
2014-08-12 07:42:16 -07:00
krajcevski
9c6d4d744a
Change GR_COMPRESS_ALPHA_MASK from compile-time flag to run-time. We do this by introducing an Options struct to be passed to a GrContext on creation.
...
R=robertphillips@google.com , bsalomon@google.com
Author: krajcevski@google.com
Review URL: https://codereview.chromium.org/459033002
2014-08-12 07:26:26 -07:00
mtklein
03bde3e6fa
SkTileGrid: store insertion order, return results sorted by that.
...
This removes the need to assume the void* are SkPictureStateTree::Data*.
BUG=skia:
R=robertphillips@google.com , mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/466503002
2014-08-12 07:01:25 -07:00
bsalomon
db1f156231
Make comment ASCII in GrDrawTarget.h
...
R=robertphillips@google.com
TBR=robertphillips@google.com
NOTRYS=true
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/458383004
2014-08-12 06:58:17 -07:00
halcanary
b2edec2c39
Revert of SkImage_Codec is Lazy ( https://codereview.chromium.org/460823002/ )
...
Reason for revert:
breaks chromium - no SkDecodingImageGenerator::Create
Original issue's description:
> SkImage_Codec is Lazy
>
> Committed: https://skia.googlesource.com/skia/+/e36f499110da8c2e2aa05227bee6deb967309ead
R=reed@google.com
TBR=reed@google.com
NOTREECHECKS=true
NOTRY=true
Author: halcanary@google.com
Review URL: https://codereview.chromium.org/461043002
2014-08-12 06:53:28 -07:00
reed
d7127e7b83
re-add samplerstress gm, but use blurmaskfilter instead (std filter)
...
BUG=skia:
R=robertphillips@google.com
Author: reed@google.com
Review URL: https://codereview.chromium.org/468483002
2014-08-12 06:53:09 -07:00
halcanary
e36f499110
SkImage_Codec is Lazy
...
R=reed@google.com
Author: halcanary@google.com
Review URL: https://codereview.chromium.org/460823002
2014-08-12 06:37:21 -07:00
reed
5b1b2dbe76
remove SkStippleMaskFilter - no external clients
...
TBR=
Author: reed@google.com
Review URL: https://codereview.chromium.org/462013002
2014-08-12 05:50:10 -07:00
caryclark
80a83adaf2
relax quadratic binary search test
...
Extreme implicit quartic equations solve to roots that are different
enough that they appear to have failed. In this case, fall back on
binary searching to find an intersection.
Relax the condition when this happens; don't give up just because the
computed implicit root points aren't remotely the same.
TBR=reed
BUG=skia:2808
Author: caryclark@google.com
Review URL: https://codereview.chromium.org/456383003
2014-08-12 05:49:37 -07:00
robertphillips
c019ec412b
Add layer counting to SkPictureRecord
...
This will be used for a SkPicture::suitableForOptimization entry point.
Committed: https://skia.googlesource.com/skia/+/4a2b2e8ed2e35171bf98bad68a69daaced11ec7c
R=bsalomon@google.com
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/464433002
2014-08-12 05:35:58 -07:00
thakis
ea13afff6e
Let skia build with clang's integrated assembler.
...
1. vuzpq is a gcc instruction. Replace it with the equivalent vuzp
(see http://llvm.org/PR20423 )
2. .func / .endfunc only have an effect with -gstabs, which we don't
use. As it's unused and clang doesn't support it, remove
.func / .endfunc (also see http://llvm.org/20424 )
BUG=chromium:124610
R=mtklein@google.com
Author: thakis@chromium.org
Review URL: https://codereview.chromium.org/461693004
2014-08-11 15:27:24 -07:00
mtklein
3b73e0163c
Revert of Add layer counting to SkPictureRecord ( https://codereview.chromium.org/464433002/ )
...
Reason for revert:
DM's all segfaulty
http://108.170.220.120:10117/builders/Test-Mac10.7-MacMini4.1-GeForce320M-x86_64-Debug/builds/3866/steps/RunDM/logs/stdio
Original issue's description:
> Add layer counting to SkPictureRecord
>
> This will be used for a SkPicture::suitableForOptimization entry point.
>
> Committed: https://skia.googlesource.com/skia/+/4a2b2e8ed2e35171bf98bad68a69daaced11ec7c
R=bsalomon@google.com , robertphillips@google.com
TBR=bsalomon@google.com , robertphillips@google.com
NOTREECHECKS=true
NOTRY=true
Author: mtklein@google.com
Review URL: https://codereview.chromium.org/452673003
2014-08-11 15:20:23 -07:00
robertphillips
4a2b2e8ed2
Add layer counting to SkPictureRecord
...
This will be used for a SkPicture::suitableForOptimization entry point.
R=bsalomon@google.com
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/464433002
2014-08-11 14:45:38 -07:00
bsalomon
d4cb922ea1
Consider index8 a compressed config.
...
R=krajcevski@google.com , robertphillips@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/457333004
2014-08-11 14:19:09 -07:00
cdalton
c7103a104f
Wrap NV_path_rendering API with GrGLPathRendering
...
Adds a GrGLPathRendering class that wraps the NV_path_rendering
extension and manages its various API versions. It also provides
backup implementations when certain NVpr methods from later API
versions are not present on the current system.
BUG=skia:
R=bungeman@google.com , bsalomon@google.com , kkinnunen@nvidia.com
Author: cdalton@nvidia.com
Review URL: https://codereview.chromium.org/444223002
2014-08-11 14:05:05 -07:00
joshualitt
5acfea789d
2D kernel initial wiring for Guassian
...
BUG=skia:
R=senorblanco@chromium.org , bsalomon@chromium.org , bsalomon@google.com
Author: joshualitt@chromium.org
Review URL: https://codereview.chromium.org/418223009
2014-08-11 13:55:34 -07:00
krajcevski
a10555a354
Add BlitRect to SkTCompressedAlphaBlitter
...
R=robertphillips@google.com
Author: krajcevski@google.com
Review URL: https://codereview.chromium.org/456873003
2014-08-11 13:34:22 -07:00
halcanary
8b2cb3391d
clean up render_pdfs:
...
Remove unused headers
replace dynamic memory wstream with null wstream.
Use SkAutoTDelete when appropriate.
Replace PdfRenderer class with short function: pdf_to_stream.
Collapse render_pdf, process_input, tool_main_core functions
Split out process_input_files function.
Don't crash when no arguments given.
print out max rss on each skp.
prettier output
R=mtklein@google.com
Author: halcanary@google.com
Review URL: https://codereview.chromium.org/463603002
2014-08-11 13:08:27 -07:00
reed
8572fc01ac
mark all SkImage methods const, so we can make it thread-safe
...
BUG=skia:
R=mtklein@google.com , halcanary@google.com
Author: reed@google.com
Review URL: https://codereview.chromium.org/453613003
2014-08-11 13:03:56 -07:00
cdalton
3f860991ad
Fix crash in nvpr text after abandoning context
...
Don't implement GlyphPathRange::onAbandon/onRelease. Its path range is
also a GrGpuResource, registered with the gpu, and will automatically
handle abandoning and releasing the actual GL objects. Don't delete
the path range early, it is assumed to be a valid pointer throughout
the entire lifetime of GlyphPathRange.
BUG=skia:
R=bsalomon@google.com , kkinnunen@nvidia.com
Author: cdalton@nvidia.com
Review URL: https://codereview.chromium.org/452273003
2014-08-11 12:43:28 -07:00
Brian Salomon
4596c98908
Mark convex_poly_clip as flaky on msaa16/win8 bots. Add more tests to ignored_tests.txt after GPU rect change.
...
BUG=skia:
Review URL: https://codereview.chromium.org/460023002
2014-08-11 15:36:43 -04:00
mtklein
a7f7b168ae
More SkTileGrid refactoring.
...
I've rearranged the code a bit more and added more notes.
BUG=skia:
R=robertphillips@google.com , mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/463593003
2014-08-11 12:05:59 -07:00
halcanary
0d154eeaeb
Process Statistics header, add max RSS to render_pdfs
...
Committed: https://skia.googlesource.com/skia/+/6274baae7fe82ce6481da367687aa6168356e1e1
R=mtklein@google.com
Author: halcanary@google.com
Review URL: https://codereview.chromium.org/448993003
2014-08-11 11:33:51 -07:00
tomhudson
d3ddea284e
Parses sample code provided by Android project. Attempts to keep FontFamily data structures produced consistent with expectations of previous versions of Skia.
...
R=bungeman@google.com , djsollen@google.com , palmer@chromium.org , reed@google.com , hcm@google.com , tomhudson@google.com
BUG=400801
Committed: https://skia.googlesource.com/skia/+/07544757c9fcf0f359f1686a3779eb2e75dd5b36
Author: tomhudson@chromium.org
Review URL: https://codereview.chromium.org/446473003
2014-08-11 11:28:01 -07:00
bsalomon
9c0822a415
Always use both a color and coverage attribute in GrAARectRenderer.
...
R=robertphillips@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/435743002
2014-08-11 11:07:48 -07:00
bungeman
3e30af2dca
Actually use test configuration in SkFontMgr on Android.
...
BUG=chromium:401954
R=tomhudson@google.com
Author: bungeman@google.com
Review URL: https://codereview.chromium.org/461673002
2014-08-11 10:53:30 -07:00
mtklein
534cc4c569
De-parameterize SkNextDatumFunction.
...
Just a simple refactor to make it clear we're only using this
one method and this one type.
BUG=skia:
R=robertphillips@google.com , mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/465523002
2014-08-11 10:09:34 -07:00
thakis
81cc04d0a6
Replace a pre-UAL instruction with its modern form.
...
See the notes in the Chromium bug, and http://llvm.org/20427
BUG=chromium:124610,skia:900
R=djsollen@google.com , mtklein@google.com
Author: thakis@chromium.org
Review URL: https://codereview.chromium.org/455903002
2014-08-11 09:52:32 -07:00
robertphillips
6162af8d4c
Cleaning up SkPicture-related classes
...
R=mtklein@google.com
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/459043002
2014-08-11 09:50:11 -07:00
reed
addf2edf3d
add localMatrix to gradient Descriptor
...
this consolidation will also help transisition to new flattening pattern, where we want to
have a flatten/unflatten method on all of the common gradient params (i.e. Descriptor).
BUG=skia:
R=egdaniel@google.com
Author: reed@google.com
Review URL: https://codereview.chromium.org/461643002
2014-08-11 08:28:24 -07:00