commit-bot@chromium.org
2cce3df19a
The default size of mask canvas is not appropriate. its height is too small: 150, while its width is 300. As a result, for non-alphaMask canvas who doesn't update the mask canvas size, this tool just magnify the upper part of 'Expected Image' as well as 'Actual Image' when user open view.html to show skpdiff_output.json in browser for many cases. The other part can't be shown because it is out of the mask canvas. This CL update non-alphaMask canvas size according to baseline canvas for each case, then the tool can magnify anywhere you want for the whole image when you click and move mouse on the mask canvas.
...
R=djsollen@google.com
Author: yunchao.he@intel.com
Review URL: https://codereview.chromium.org/105823010
git-svn-id: http://skia.googlecode.com/svn/trunk@12638 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-12 14:55:45 +00:00
commit-bot@chromium.org
32f40ee8b0
Remove mutex around image decoding in skpdiff.
...
I removed the mutex to investigate BUG=skia:1803, and I get no
crashes. The crashes may have been related to other multithreading
issues.
Removing the mutex will allow skpdiff to run faster.
R=djsollen@google.com
Author: scroggo@google.com
Review URL: https://codereview.chromium.org/61603008
git-svn-id: http://skia.googlecode.com/svn/trunk@12339 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-21 15:22:18 +00:00
commit-bot@chromium.org
c32ce49df8
Remove unused kMaxPOI.
...
BUG=
R=djsollen@google.com
Author: mtklein@google.com
Review URL: https://codereview.chromium.org/62333026
git-svn-id: http://skia.googlecode.com/svn/trunk@12307 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-18 21:01:29 +00:00
commit-bot@chromium.org
da4d7cfa58
Remove unnecessary includes.
...
R=djsollen@google.com
Author: scroggo@google.com
Review URL: https://codereview.chromium.org/68893028
git-svn-id: http://skia.googlecode.com/svn/trunk@12304 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-18 17:27:16 +00:00
djsollen@google.com
efc51b79a2
fix multithread related crashes in skpdiff
...
BUG=skia:1798
R=mtklein@google.com , scroggo@google.com
Review URL: https://codereview.chromium.org/60833002
git-svn-id: http://skia.googlecode.com/svn/trunk@12252 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-12 18:29:17 +00:00
scroggo@google.com
086364b8e6
Changes to make SkPDiff more robost.
...
bitmap_to_cielab now returns a boolean. Instead of asserting that the
config is 8888, copy to 8888 (and return false on failure). This allows
skpdiff to work on Index8 bitmaps (without changing the code that does
the real work). If it returns false, do not attempt to create a pmetric.
In pmetric, exit early if maxLevels is <= 2, since this would crash later
in the function (creation of an ImageL3D if maxLevels is 0, and then the
creation of an array of a negative number of entries). maxLevels is small
if the width or height of the image is small (i.e. a bitmap with width 1
has maxLevels of 0).
R=djsollen@google.com
Review URL: https://codereview.chromium.org/65253002
git-svn-id: http://skia.googlecode.com/svn/trunk@12239 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-12 14:41:20 +00:00
djsollen@google.com
2761b30dfe
fix broken build on mac due to compiler warning
...
R=epoger@google.com
Review URL: https://codereview.chromium.org/64423004
git-svn-id: http://skia.googlecode.com/svn/trunk@12175 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-07 19:40:35 +00:00
djsollen@google.com
513a7bffd3
update skpdiff visualization (image magnification with alpha mask)
...
R=epoger@google.com
Review URL: https://codereview.chromium.org/29103005
git-svn-id: http://skia.googlecode.com/svn/trunk@12174 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-07 19:24:06 +00:00
djsollen@google.com
cbbf1ca304
add initial support ofr multi-threaded execution
...
Review URL: https://codereview.chromium.org/27541003
git-svn-id: http://skia.googlecode.com/svn/trunk@11823 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-16 18:36:49 +00:00
djsollen@google.com
1e391b5870
Update skpdiff to include a name with each file.
...
R=caryclark@google.com
Review URL: https://codereview.chromium.org/27512002
git-svn-id: http://skia.googlecode.com/svn/trunk@11808 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-16 15:00:11 +00:00
robertphillips@google.com
adacc7067a
Start cleaning up 64bit Win warnings
...
https://codereview.chromium.org/27192003/
git-svn-id: http://skia.googlecode.com/svn/trunk@11764 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-14 21:53:24 +00:00
commit-bot@chromium.org
fe87fb8a33
fix path issues on mac and win for skpdiff_server.py
...
R=djsollen@google.com , epoger@google.com , jvanverth@google.com
Author: zachr@google.com
Review URL: https://chromiumcodereview.appspot.com/22650009
git-svn-id: http://skia.googlecode.com/svn/trunk@10719 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-14 19:20:35 +00:00
zachr@google.com
74c5ab19fd
add ui for mutli-rebaselining
...
R=epoger@google.com
Review URL: https://codereview.chromium.org/22580004
git-svn-id: http://skia.googlecode.com/svn/trunk@10618 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-07 18:06:39 +00:00
zachr@google.com
6f8e2c5e87
download and rebaseline images using server
...
BUG=
R=epoger@google.com
Review URL: https://codereview.chromium.org/20654006
git-svn-id: http://skia.googlecode.com/svn/trunk@10607 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-07 15:43:04 +00:00
zachr@google.com
a479aa1366
fix skpdiff viewer bug when using relative paths
...
BUG=skia:1463
R=djsollen@google.com
Review URL: https://codereview.chromium.org/21601002
git-svn-id: http://skia.googlecode.com/svn/trunk@10515 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-02 15:54:30 +00:00
zachr@google.com
785ef5d521
process gm expectation violations
...
R=epoger@google.com
Review URL: https://codereview.chromium.org/20527002
git-svn-id: http://skia.googlecode.com/svn/trunk@10395 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-26 19:29:39 +00:00
zachr@google.com
48b8891194
add basic HTTP server for viewing skpdiff results
...
R=epoger@google.com
Review URL: https://codereview.chromium.org/19929007
git-svn-id: http://skia.googlecode.com/svn/trunk@10371 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-25 19:49:17 +00:00
zachr@google.com
55173f2ecc
fix trailing comma in outptu of SkDiffContext
...
R=djsollen@google.com
Review URL: https://codereview.chromium.org/20324004
git-svn-id: http://skia.googlecode.com/svn/trunk@10361 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-25 17:22:58 +00:00
edisonn@google.com
d2d9f563be
skpdiff: remove default value for output. Diifs can be very big, and fill a hard drive, no sense to generate them if not needed.
...
R=zachr@google.com
Review URL: https://codereview.chromium.org/20054003
git-svn-id: http://skia.googlecode.com/svn/trunk@10291 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-23 20:15:08 +00:00
zachr@google.com
ee0f46d87f
put max on outputted poi in skpdiff
...
R=djsollen@google.com
Review URL: https://codereview.chromium.org/19601006
git-svn-id: http://skia.googlecode.com/svn/trunk@10262 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-23 12:57:52 +00:00
zachr@google.com
5b3e2b9622
move skpdiff into tools
...
R=djsollen@google.com
Review URL: https://codereview.chromium.org/19608005
git-svn-id: http://skia.googlecode.com/svn/trunk@10249 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-22 18:46:45 +00:00
zachr@google.com
904f86e6aa
Revert "migrate skpdiff to tools"
...
This reverts commit 58a7ec70ce6b4548793a2ddc37c63d3d44edbc36.
git-svn-id: http://skia.googlecode.com/svn/trunk@10226 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-22 13:29:20 +00:00
zachr@google.com
a54aaf7fba
migrate skpdiff to tools
...
R=djsollen@google.com
Review URL: https://codereview.chromium.org/19671002
git-svn-id: http://skia.googlecode.com/svn/trunk@10225 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-22 13:14:04 +00:00