Commit Graph

8 Commits

Author SHA1 Message Date
Ravi Mistry
32f547a418 Fix bookmaker bot
Bug: skia:
Change-Id: Ic625889ca58237e8da8ab964f29e303ceb493faf
Reviewed-on: https://skia-review.googlesource.com/c/160760
Reviewed-by: Cary Clark <caryclark@google.com>
Commit-Queue: Cary Clark <caryclark@google.com>
2018-10-09 13:26:20 +00:00
Ravi Mistry
5c43d5ad88 Revert "Disable bookmaker CLs automatic CQ+2 for now"
This reverts commit 63fac808ee.

Reason for revert: Fiddle problem seems to be fixed

Original change's description:
> Disable bookmaker CLs automatic CQ+2 for now
> 
> Disable till problem described in
> https://bugs.chromium.org/p/skia/issues/detail?id=8151#c8 is fixed
> 
> Bug: skia:8151
> Change-Id: Ie726829f3b13b587e14192dbf0104d04934a18dc
> Reviewed-on: https://skia-review.googlesource.com/142503
> Reviewed-by: Ravi Mistry <rmistry@google.com>
> Reviewed-by: Cary Clark <caryclark@google.com>
> Commit-Queue: Ravi Mistry <rmistry@google.com>

TBR=rmistry@google.com,caryclark@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: skia:8151
Change-Id: If09f3ab783d3b616bc96ba8994e6220039f6fc00
Reviewed-on: https://skia-review.googlesource.com/145324
Reviewed-by: Ravi Mistry <rmistry@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
2018-08-03 13:29:56 +00:00
Ravi Mistry
63fac808ee Disable bookmaker CLs automatic CQ+2 for now
Disable till problem described in
https://bugs.chromium.org/p/skia/issues/detail?id=8151#c8 is fixed

Bug: skia:8151
Change-Id: Ie726829f3b13b587e14192dbf0104d04934a18dc
Reviewed-on: https://skia-review.googlesource.com/142503
Reviewed-by: Ravi Mistry <rmistry@google.com>
Reviewed-by: Cary Clark <caryclark@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
2018-07-19 17:25:25 +00:00
Ravi Mistry
faccf39fe0 Debug nightly bookmaker bot
* Output fiddle.json
* Do not send to CQ while we investigate

Bug: skia:8151
Change-Id: I309c732cc6b7db72054fd119b8c68dd32a765d6f
Reviewed-on: https://skia-review.googlesource.com/142301
Commit-Queue: Ravi Mistry <rmistry@google.com>
Reviewed-by: Cary Clark <caryclark@google.com>
2018-07-19 13:22:44 +00:00
Eric Boren
7817931a5c Switch RecreateSKPs and Bookmaker bots to use service accounts
Bug: skia:
Change-Id: I59aefe7c7e7a6861b00f0e22310e7ceaff3d6d0e
Reviewed-on: https://skia-review.googlesource.com/122944
Reviewed-by: Ravi Mistry <rmistry@google.com>
2018-04-23 13:00:19 +00:00
Ravi Mistry
4793d3bd2c [Infra] Automatically submit docs updates
No-Tree-Checks: true
Bug: skia:7310
Change-Id: I9c26ba4d4c3f4952ec37538b7125294de153e0e6
Reviewed-on: https://skia-review.googlesource.com/84864
Commit-Queue: Ravi Mistry <rmistry@google.com>
Reviewed-by: Ravi Mistry <rmistry@google.com>
2017-12-13 22:56:30 +00:00
Ravi Mistry
5ca9413b9b [Bookmaker bot] Output fiddleout.json earlier and do not send to CQ for now
Bug: skia:7310
Change-Id: Id6c2f15b72d6837f6536e25dbc3d01cac32af74b
Reviewed-on: https://skia-review.googlesource.com/83640
Reviewed-by: Ravi Mistry <rmistry@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
2017-12-11 22:17:29 +00:00
Ravi Mistry
edc4f3e604 Add new Bookmaker bot that runs nightly
The new bot:
1) Extracts all fiddles out of markdown files.
2) Forces fiddle.skia.org to compile all those fiddles and get output in JSON.
3) Scans the output and reports any compiletime/runtime errors.
4) Updates markdown in site/user/api/ using the new hashes (if any) from fiddle.skia.org.

To ensure the bot does not check in unexpected changes:
* upload_md.py makes sure that all modified files are under site/user/api/. It errors out if this is not the case.
* CLs with docs only changes normally have 'NoTry: true' added to their descriptions. This is not done for the new bot because we want to run it through trybots to make sure nothing unexpected snuck in.
* rmistry@ and caryclark@ are automatically CC'ed on all uploaded changes. I plan to watch the bot closely for at least a couple of weeks.


Bug: skia:7310
Change-Id: I759fc8bae1e32a6f175e3b1a895947d14ca5fe3a
Reviewed-on: https://skia-review.googlesource.com/79941
Commit-Queue: Ravi Mistry <rmistry@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2017-12-08 22:26:38 +00:00