Commit Graph

464 Commits

Author SHA1 Message Date
commit-bot@chromium.org
83d81c96de Turn NVPR on by default (but off in tools).
BUG=skia:2042
R=robertphillips@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/144003006

git-svn-id: http://skia.googlecode.com/svn/trunk@13164 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-24 14:38:13 +00:00
bungeman@google.com
1b532f1231 Rebaselines for r13156.
There seems to be an issue where expectations are missing from storage.
Either they didn't actually upload, we pointed at the wrong one.


git-svn-id: http://skia.googlecode.com/svn/trunk@13162 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-23 23:34:38 +00:00
bungeman@google.com
3bfd12d881 Rebaselines for r13156.
The thing blurred in imageblur is actually text.
Who knew?


git-svn-id: http://skia.googlecode.com/svn/trunk@13161 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-23 23:25:19 +00:00
skia.committer@gmail.com
8f7ed2cfd8 Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@13160 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-23 22:26:04 +00:00
bungeman@google.com
5aa1116177 Rebaselines for r13156.
These are for affected baselines which are now failing,
but the expected image appears to be unavailable.


git-svn-id: http://skia.googlecode.com/svn/trunk@13159 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-23 22:24:41 +00:00
bungeman@google.com
5a246719a5 Rebaseline for r13156.
git-svn-id: http://skia.googlecode.com/svn/trunk@13158 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-23 22:19:16 +00:00
commit-bot@chromium.org
764ea79201 Rename Logan skimage expectations: .jon -> .json
BUG=skia:
R=scroggo@google.com

Author: borenet@google.com

Review URL: https://codereview.chromium.org/144253002

git-svn-id: http://skia.googlecode.com/svn/trunk@13135 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-21 20:03:09 +00:00
commit-bot@chromium.org
4bd5177e4f ignore some verylargebitmap errors
BUG=skia:1978
NOTREECHECK=True
NOTRY=True
R=senorblanco@google.com
TBR=senorblanco

Author: epoger@google.com

Review URL: https://codereview.chromium.org/140643003

git-svn-id: http://skia.googlecode.com/svn/trunk@13124 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-17 20:16:05 +00:00
senorblanco@chromium.org
5fdaffdbcb Add new baselines for bitmapsource, dropshadowimagefilter, pictureimagefilter and resizeimagefilter GMs.
TBR=djsollen

Review URL: https://codereview.chromium.org/139513004

git-svn-id: http://skia.googlecode.com/svn/trunk@13096 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-15 19:28:53 +00:00
robertphillips@google.com
40299fe511 Rebaseline complexclip_aa_layer image for Nexus 4
https://codereview.chromium.org/138273008/



git-svn-id: http://skia.googlecode.com/svn/trunk@13085 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-15 14:52:03 +00:00
commit-bot@chromium.org
78f6ddc1a0 rebaseline blur related outputs
rebaseline for the differences introduced by https://codereview.chromium.org/105893003/

BUG=
R=senorblanco@chromium.org, reed@google.com

Author: zheng.xu@arm.com

Review URL: https://codereview.chromium.org/136483002

git-svn-id: http://skia.googlecode.com/svn/trunk@13080 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-15 02:37:57 +00:00
bsalomon@google.com
d0c53f1d51 Rebaseline bleed and simpleblurroundrect due to GPU blur changes. Also, misc blur GMs on N4.
BUG=skia:199s8

Review URL: https://codereview.chromium.org/138593002

git-svn-id: http://skia.googlecode.com/svn/trunk@13067 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-14 18:20:49 +00:00
commit-bot@chromium.org
df79acdbab Revert of Rebaselining bleed GMs due to recent GPU blur changes. (https://codereview.chromium.org/138353002/)
Reason for revert:
the bleed_gpu GM is failing on all the test builders.

Original issue's description:
> Rebaselining bleed GMs due to recent GPU blur changes.
>
> BUG=skia:1998
>
> Committed: https://code.google.com/p/skia/source/detail?r=13063

R=bsalomon@google.com
TBR=bsalomon@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:1998

Author: djsollen@google.com

Review URL: https://codereview.chromium.org/138133003

git-svn-id: http://skia.googlecode.com/svn/trunk@13064 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-14 16:21:31 +00:00
bsalomon@google.com
3f88f4d5ad Rebaselining bleed GMs due to recent GPU blur changes.
BUG=skia:1998

Review URL: https://codereview.chromium.org/138353002

git-svn-id: http://skia.googlecode.com/svn/trunk@13063 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-14 15:28:24 +00:00
commit-bot@chromium.org
3e62ebf93b make ignored-tests.txt specify full test name, not partial name
BUG=skia:2022
R=bsalomon@google.com

Author: epoger@google.com

Review URL: https://codereview.chromium.org/136883006

git-svn-id: http://skia.googlecode.com/svn/trunk@13060 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-14 02:54:11 +00:00
bsalomon@google.com
3c0ccff35e Misc rebaselines related to recent GPU blur changes.
Review URL: https://codereview.chromium.org/130523003

git-svn-id: http://skia.googlecode.com/svn/trunk@13053 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-13 19:06:10 +00:00
bsalomon@google.com
cd9175eddb remove _gpu suffix from tests in ignored-tests.txt that are changed on all gpu configs (msaa, ...).
Review URL: https://codereview.chromium.org/136713005

git-svn-id: http://skia.googlecode.com/svn/trunk@13049 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-13 18:26:14 +00:00
robertphillips@google.com
a3961374fe Rebaseline NVPR roundrects images
https://codereview.chromium.org/136753004/



git-svn-id: http://skia.googlecode.com/svn/trunk@13048 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-13 17:15:33 +00:00
commit-bot@chromium.org
439ff1b9ca Use correct matrix to adjust blur radius for gpu
BUG=skia:1998
R=robertphillips@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/134973002

git-svn-id: http://skia.googlecode.com/svn/trunk@13047 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-13 16:39:39 +00:00
bsalomon@google.com
4db7a31678 Remove rects GM from ignored-tests.txt and rebaseline
BUG=skia:1882

Review URL: https://codereview.chromium.org/136803002

git-svn-id: http://skia.googlecode.com/svn/trunk@13045 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-13 15:06:54 +00:00
commit-bot@chromium.org
a7d89c83a4 Handle drawBitmapRect src_rect->dst_rect mapping as a local matrix rather than view matrix when there is a mask filter.
BUG=skia:1998
R=robertphillips@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/131323004

git-svn-id: http://skia.googlecode.com/svn/trunk@13041 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-13 14:47:00 +00:00
commit-bot@chromium.org
c45ece5f7f NEON fast path for box blur
Calculate 8 channels in parallel by using 16-bits to store each channel. Due to the limitation of VQRDMULH, (int16 * int16 * 2 + 0x8000) >> 16, the fast path can only support kernelSize < 128.
8 significant bits are kept at least in each stage, the final error should less-equal than 1.

Pre-fetching memory for X-direction read. In fact pre-fetching memory doesn't help much for Y direction read, since it is a waste to load a cache line for only read 8 bytes.(I left it there to keep the symmetry. pre-fetch is cheap :) )

bench data on Nexus 10
before:
running bench [640 480]      blur_image_filter_large_10.00_10.00   8888:  cmsecs =  25081.48
running bench [640 480]      blur_image_filter_small_10.00_10.00   8888:  cmsecs =  25038.04
running bench [640 480]        blur_image_filter_large_1.00_1.00   8888:  cmsecs =  25209.04
running bench [640 480]        blur_image_filter_small_1.00_1.00   8888:  cmsecs =  24928.01
running bench [640 480]        blur_image_filter_large_0.00_1.00   8888:  cmsecs =  17160.98
running bench [640 480]       blur_image_filter_large_0.00_10.00   8888:  cmsecs =  17924.11
running bench [640 480]        blur_image_filter_large_1.00_0.00   8888:  cmsecs =  14609.19
running bench [640 480]       blur_image_filter_large_10.00_0.00   8888:  cmsecs =  14625.91

after:
running bench [640 480]      blur_image_filter_large_10.00_10.00   8888:  cmsecs =  14848.42
running bench [640 480]      blur_image_filter_small_10.00_10.00   8888:  cmsecs =  16037.29
running bench [640 480]        blur_image_filter_large_1.00_1.00   8888:  cmsecs =  14819.55
running bench [640 480]        blur_image_filter_small_1.00_1.00   8888:  cmsecs =  14563.69
running bench [640 480]        blur_image_filter_large_0.00_1.00   8888:  cmsecs =  11905.34
running bench [640 480]       blur_image_filter_large_0.00_10.00   8888:  cmsecs =  11883.85
running bench [640 480]        blur_image_filter_large_1.00_0.00   8888:  cmsecs =   9576.51
running bench [640 480]       blur_image_filter_large_10.00_0.00   8888:  cmsecs =   9793.84

BUG=
R=senorblanco@chromium.org, mtklein@google.com, reed@google.com, kevin.petit@arm.com, kevin.petit.arm@gmail.com

Author: zheng.xu@arm.com

Review URL: https://codereview.chromium.org/105893003

git-svn-id: http://skia.googlecode.com/svn/trunk@13036 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-13 08:16:45 +00:00
robertphillips@google.com
7095607705 Suppressing imagefiltersbase_gpu on RHB device
https://codereview.chromium.org/134093002/



git-svn-id: http://skia.googlecode.com/svn/trunk@13018 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-10 15:28:19 +00:00
robertphillips@google.com
6791138dc0 Suppress imagefiltersgraph_msaa4 failure on Nexus10
https://codereview.chromium.org/133643003/



git-svn-id: http://skia.googlecode.com/svn/trunk@13011 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-10 13:50:23 +00:00
borenet@google.com
6f0f5b4aad Remove references to Skia's SVN repository
BUG=
R=epoger@google.com

Review URL: https://codereview.chromium.org/132423002

git-svn-id: http://skia.googlecode.com/svn/trunk@13006 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-09 21:41:39 +00:00
reed@google.com
2e0f1ee593 remove bad gm expected images
BUG=skia:1986
R=epoger@google.com

Review URL: https://codereview.chromium.org/132023005

git-svn-id: http://skia.googlecode.com/svn/trunk@13004 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-09 21:05:59 +00:00
bsalomon@google.com
2b199e6d4d Mark imagefiltersgraph, IntelRhb, msaa4 config as ignore failure due to garbage on bottom line.
BUG=skia:2005

Review URL: https://codereview.chromium.org/132303002

git-svn-id: http://skia.googlecode.com/svn/trunk@12998 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-09 17:59:55 +00:00
robertphillips@google.com
6235b85b0b Update baselines for NVPR bot
git-svn-id: http://skia.googlecode.com/svn/trunk@12989 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-09 15:57:25 +00:00
senorblanco@chromium.org
efd0ff108e More rebaselines after r12895 for the mega-stragglers.
TBR=caryclark
BUG=1985

Review URL: https://codereview.chromium.org/126453007

git-svn-id: http://skia.googlecode.com/svn/trunk@12976 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-08 22:21:07 +00:00
bsalomon@google.com
a52209f162 one more filterbitmap ASAN ignore
BUG=skia:1984

Review URL: https://codereview.chromium.org/126813004

git-svn-id: http://skia.googlecode.com/svn/trunk@12960 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-08 15:46:19 +00:00
bsalomon@google.com
77bf27ee03 Rebaselines for filterbitmap and downsample GMs on gpu N4
BUG=skia:1984

Review URL: https://codereview.chromium.org/128433002

git-svn-id: http://skia.googlecode.com/svn/trunk@12959 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-08 15:42:53 +00:00
bsalomon@google.com
c75b25af9e Mark ASAN filterbitmap images as ignore failure
BUG=1984

Review URL: https://codereview.chromium.org/128423002

git-svn-id: http://skia.googlecode.com/svn/trunk@12957 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-08 15:34:27 +00:00
bsalomon@google.com
aed01c1e05 Mark filterbitmap_* on N4 (persp) as ignore failure because of skia issue 1966
BUG=skia:1966
BUG=skia:1984

Review URL: https://codereview.chromium.org/128383003

git-svn-id: http://skia.googlecode.com/svn/trunk@12956 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-08 15:26:01 +00:00
senorblanco@chromium.org
c62bdc7433 More rebaselines from r12895.
BUG=1985
TBR=caryclark

Review URL: https://codereview.chromium.org/128143003

git-svn-id: http://skia.googlecode.com/svn/trunk@12955 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-08 15:18:20 +00:00
bsalomon@google.com
b6b0cf3215 more PDF filterbitmap ignores
Review URL: https://codereview.chromium.org/123933005

git-svn-id: http://skia.googlecode.com/svn/trunk@12944 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-07 17:50:04 +00:00
bsalomon@google.com
f6c8aeb174 Mark pdf filterbitmap images as failure ignored
Review URL: https://codereview.chromium.org/121883006

git-svn-id: http://skia.googlecode.com/svn/trunk@12933 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-06 23:25:38 +00:00
bsalomon@google.com
ec7d9b7880 Rebaseline filterbitmap_image_mandrill N4 GPU images
BUG=skia:1879

Review URL: https://codereview.chromium.org/102963011

git-svn-id: http://skia.googlecode.com/svn/trunk@12931 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-06 22:50:28 +00:00
bsalomon@google.com
4fdf25e6cc rebaseline downsample_text and downsample_checkerboard GMs on gpu configs
BUG=skia:1879

Review URL: https://codereview.chromium.org/125463002

git-svn-id: http://skia.googlecode.com/svn/trunk@12930 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-06 22:31:14 +00:00
bsalomon@google.com
7b22744ff0 Rebaselines for filterbitmap_text GMs
BUG=skia:1879

Review URL: https://codereview.chromium.org/109403007

git-svn-id: http://skia.googlecode.com/svn/trunk@12929 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-06 22:00:04 +00:00
bsalomon@google.com
79c95324b1 Rebaselines for filterbitmap_checkerboard
BUG=skia:1879

Review URL: https://codereview.chromium.org/108653019

git-svn-id: http://skia.googlecode.com/svn/trunk@12928 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-06 21:48:23 +00:00
bsalomon@google.com
da0f7616e9 Rebaseline mandrill GMs
BUG=skia:1879

Review URL: https://codereview.chromium.org/114603008

git-svn-id: http://skia.googlecode.com/svn/trunk@12924 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-06 20:18:15 +00:00
senorblanco@chromium.org
4e4b09a44e Rebaselines for more straggling bots.
TBR=

Review URL: https://codereview.chromium.org/121943003

git-svn-id: http://skia.googlecode.com/svn/trunk@12902 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-04 17:22:04 +00:00
senorblanco@chromium.org
7b6d4d6783 Yet more rebaselines from straggling bots.
BUG=
TBR=

Review URL: https://codereview.chromium.org/116463005

git-svn-id: http://skia.googlecode.com/svn/trunk@12900 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-04 04:19:38 +00:00
senorblanco@chromium.org
4e13914e3c Stragglers.
TBR=

Review URL: https://codereview.chromium.org/124353004

git-svn-id: http://skia.googlecode.com/svn/trunk@12899 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-04 02:36:24 +00:00
senorblanco@chromium.org
323cc26308 New baselines for tileimagefilter, imagefiltersgraph, and everything Nexus4.
TBR=

Review URL: https://codereview.chromium.org/101693010

git-svn-id: http://skia.googlecode.com/svn/trunk@12898 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-04 00:14:54 +00:00
senorblanco@chromium.org
c8c599269d Widen suppression to tileimagefilter-pdf.
TBR=

Review URL: https://codereview.chromium.org/122683004

git-svn-id: http://skia.googlecode.com/svn/trunk@12897 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-03 22:27:05 +00:00
senorblanco@chromium.org
a502d60b93 Ignore failures on tileimagefilter-pdf_poppler.
TBR=

Review URL: https://codereview.chromium.org/124263003

git-svn-id: http://skia.googlecode.com/svn/trunk@12896 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-03 22:18:12 +00:00
senorblanco@chromium.org
6776b82d46 Make SkImageFilter crop rects relative to the primitive origin, instead of relative to their parent's crop rect. This is required by SVG semantics, and is more sane anyway.
To do this, this patch changes the "offset/loc" parameter in filterImage() / onFilterImage() from an inout-param to an out-param only, so that the calling filter can know how much the input filter wants its result offset (and doesn't include the original primitive position). This offset can then be applied to the current filter's crop rect. (I've renamed the parameter "offset" in all cases to make this clear.) This makes the call sites in SkCanvas/SkGpuDevice responsible for applying the resulting offset to the primitive's position, which is actually a fairly small change.

This change also fixes SkTileImageFilter and SkOffsetImageFilter to correctly handle an input offset, which they weren't before. This required modifying the GM's, since they assumed the broken behaviour.

NOTE: this will require rebaselining the imagefiltersgraph test, since it has a new test case.

NOTE: this will "break" the Blink layout tests css3/filters/effect-reference-subregion-chained-hw.html and css3/filters/effect-reference-subregion-hw.html, but it actually makes them give correct results. It should be suppressed on the skia roll, and I'll rebaseline it.

R=reed@google.com

Review URL: https://codereview.chromium.org/112803004

git-svn-id: http://skia.googlecode.com/svn/trunk@12895 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-03 21:48:22 +00:00
halcanary@google.com
dab032a4ba Update 4 skimage expectations.
Grab expectations missed in codereview:102213009, sicne the bots were slow:
-  Test-ChromeOS-Daisy-MaliT604-Arm7-Debug
-  Test-ChromeOS-Daisy-MaliT604-Arm7-Release
-  Test-Ubuntu12-ShuttleA-ATI5770-x86_64-Release-Valgrind
-  Test-Ubuntu13-ShuttleA-HD2000-x86_64-Debug-ASAN

BUG=
R=epoger@google.com

Review URL: https://codereview.chromium.org/93713007

git-svn-id: http://skia.googlecode.com/svn/trunk@12869 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-02 20:43:26 +00:00
borenet@google.com
4be2e001d2 Empty skimage expectations for Logan
R=scroggo@google.com

Review URL: https://codereview.chromium.org/110393005

git-svn-id: http://skia.googlecode.com/svn/trunk@12809 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-20 21:35:51 +00:00