AuroraMiddleware/skia2
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
60,305 Commits 1 Branch 0 Tags 544 MiB
84b0178e3e
Commit Graph

6 Commits

Author SHA1 Message Date
Brian Salomon
9fa47cc1c6 Make class members that are static constexpr also be inline. 
This is in prep for compiling with -std=c++14 and -Wno-c++17-extensions
when building with clang. Chrome has encountered problems with
third_party headers that are included both in Skia and other Chrome
sources that produce different code based on whether preprocessor macros
indicate a C++14 or C++17 compilation.

In C++17 they are already inline implicitly. When compiling with C++14
we can get linker errors unless they're explicitly inlined or defined
outside the class. With -Wno-c++17-extensions we can explicitly inline
them in the C++14 build because the warning that would be generated
about using a C++17 language extension is suppressed.

We cannot do this in public headers because we support compiling with
C++14 without suppressing the C++17 language extension warnings.

Bug: chromium:1257145
Change-Id: Iaf5f4c62a398f98dd4ca9b7dfb86f2d5cab21d66
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/457498
Reviewed-by: Ben Wagner <bungeman@google.com>
Reviewed-by: Herb Derby <herb@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
 2021-10-11 16:22:59 +00:00
Mike Reed
5ec22387ff Simplify common case of linear filtering with no mips 
Change-Id: I08b4a7bc088705b93a0aa680f6733d09c7ad23dd
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/354221
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Mike Reed <reed@google.com>
 2021-01-15 16:47:16 +00:00
Florin Malita
697e2467bd Reland "drawGlyphRunRSXform: post-compose shader local matrix adjustments" 
This reverts commit d150a58c04.

Reason for revert: hopefully not to culprit for roller issues

Original change's description:
> Revert "drawGlyphRunRSXform: post-compose shader local matrix adjustments"
>
> This reverts commit ff49f92e26.
>
> Reason for revert: Likely the CL that's making fushcia_x64 grumpy
>
> Original change's description:
> > drawGlyphRunRSXform: post-compose shader local matrix adjustments
> >
> > Bug: skia:11113
> > Change-Id: Ic34a0c80b44031d77d361d35e64301297b3f3189
> > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/347047
> > Commit-Queue: Florin Malita <fmalita@chromium.org>
> > Commit-Queue: Florin Malita <fmalita@google.com>
> > Reviewed-by: Mike Reed <reed@google.com>
>
> TBR=fmalita@chromium.org,fmalita@google.com,reed@google.com
>
> Change-Id: Ieb9ac7597f518f4209d07b063b5752a2265244b4
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: skia:11113
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/348656
> Reviewed-by: Chris Dalton <csmartdalton@google.com>
> Commit-Queue: Chris Dalton <csmartdalton@google.com>

TBR=csmartdalton@google.com,fmalita@chromium.org,fmalita@google.com,reed@google.com

# Not skipping CQ checks because this is a reland.

Bug: skia:11113
Change-Id: I598653d9b79f00d36e7a0f700af92d273bbf6305
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/348193
Reviewed-by: Florin Malita <fmalita@google.com>
Commit-Queue: Florin Malita <fmalita@google.com>
 2020-12-30 14:05:39 +00:00
Chris Dalton
d150a58c04 Revert "drawGlyphRunRSXform: post-compose shader local matrix adjustments" 
This reverts commit ff49f92e26.

Reason for revert: Likely the CL that's making fushcia_x64 grumpy

Original change's description:
> drawGlyphRunRSXform: post-compose shader local matrix adjustments
>
> Bug: skia:11113
> Change-Id: Ic34a0c80b44031d77d361d35e64301297b3f3189
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/347047
> Commit-Queue: Florin Malita <fmalita@chromium.org>
> Commit-Queue: Florin Malita <fmalita@google.com>
> Reviewed-by: Mike Reed <reed@google.com>

TBR=fmalita@chromium.org,fmalita@google.com,reed@google.com

Change-Id: Ieb9ac7597f518f4209d07b063b5752a2265244b4
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: skia:11113
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/348656
Reviewed-by: Chris Dalton <csmartdalton@google.com>
Commit-Queue: Chris Dalton <csmartdalton@google.com>
 2020-12-30 04:25:05 +00:00
Florin Malita
ff49f92e26 drawGlyphRunRSXform: post-compose shader local matrix adjustments 
Bug: skia:11113
Change-Id: Ic34a0c80b44031d77d361d35e64301297b3f3189
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/347047
Commit-Queue: Florin Malita <fmalita@chromium.org>
Commit-Queue: Florin Malita <fmalita@google.com>
Reviewed-by: Mike Reed <reed@google.com>
 2020-12-29 21:30:18 +00:00
Florin Malita
ce613004a2 Add rsx_blob_shader GM 
TBR=reed
Bug: skia:11113
Change-Id: I8165f9667f20d76c0af8469fb2a278f5581853ac
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/347044
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Florin Malita <fmalita@google.com>
Commit-Queue: Florin Malita <fmalita@chromium.org>
 2020-12-23 17:47:19 +00:00