Commit Graph

58664 Commits

Author SHA1 Message Date
John Stiles
d67f1f8f50 Provide bit-casted slot values from DebugTracePlayer.
Previously, the VariableData returned from a DebugTracePlayer contained
values in an int32_t, regardless of the slot's NumberKind. We had a
helper function which could stringize the bits, but otherwise the caller
was responsible for bit-casting the value manually.

Now, the DebugTracePlayer will automatically manage bit-casting for the
caller. The value returned in the VariableData is now a double (so it
is able to store an int32, uint32, or float at full precision).

This change was inspired by the recent Typescript port. (The value in
the Typescript VariableData uses a compound `number | boolean` type, so
it is able to fully represent any slot value natively.)

Change-Id: I5eec414236f76ad0ff51b0b19974e4a0025c4d62
Bug: skia:12666
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/489896
Auto-Submit: John Stiles <johnstiles@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2021-12-29 18:30:19 +00:00
skia-autoroll
0ada61c87e Roll ANGLE from 0a28c6c61b2f to 6f1c39b52b4f (3 revisions)
0a28c6c61b..6f1c39b52b

2021-12-28 lfy@google.com Vulkan: Restore color attachment mask-related blend states
2021-12-28 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 87c78ac5eb86 to 433b1bf9bff2 (2 revisions)
2021-12-28 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 0635acc4de22 to d09758fa672c (93 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-skia-autoroll
Please CC johnstiles@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Build-Debian10-Clang-x86_64-Release-ANGLE;skia/skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC8i5BEK-GPU-IntelIris655-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE
Tbr: johnstiles@google.com
Change-Id: Ic14b71e61dd075cbec4b503e2fce7310e48972e3
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/489758
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2021-12-29 07:13:19 +00:00
skia-autoroll
8dc6d1eee6 Roll Dawn from 5657f89f4489 to 3c3929abb191 (2 revisions)
https://dawn.googlesource.com/dawn.git/+log/5657f89f4489..3c3929abb191

2021-12-29 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 95f6e6865fa6 to 6f1c39b52b4f (1 revision)
2021-12-28 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 0a28c6c61b2f to 95f6e6865fa6 (2 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dawn-skia-autoroll
Please CC jrprice@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Build-Debian10-Clang-x86_64-Debug-Dawn
Bug: None
Tbr: jrprice@google.com
Change-Id: I7a9bad855356f657eb8b467aee7f7040d1d9a6ff
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/489760
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2021-12-29 06:08:46 +00:00
skia-autoroll
b409f78083 Roll Chromium from c657707aead4 to 43dfb5d2bb06 (153 revisions)
c657707aea..43dfb5d2bb

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-skia-autoroll
Please CC johnstiles@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Perf-Mac10.13-Clang-MacBookPro11.5-GPU-RadeonHD8870M-x86_64-Release-All-CommandBuffer;skia/skia.primary:Test-Mac10.13-Clang-MacBookPro11.5-GPU-RadeonHD8870M-x86_64-Debug-All-CommandBuffer
Tbr: johnstiles@google.com
Change-Id: Id3b60d5866f9e4c5ff594c7199cb7c2f6f27349b
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/489759
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2021-12-29 05:33:49 +00:00
John Stiles
bab224e1c2 Prevent interface block members from using invalid names.
Interface blocks now guard against naming their member variables with
built-in type names like "float" or "bool".

Change-Id: Ia767542ace76fb8fbc2d50c81772b7f54b1bf973
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/489616
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: John Stiles <johnstiles@google.com>
Auto-Submit: John Stiles <johnstiles@google.com>
2021-12-28 20:57:18 +00:00
John Stiles
aa09c782a8 Add test for structs/interface-blocks with invalid member names.
Structs already handled this appropriately, but interface blocks did not
guard against naming their member variables built-in type names like
"float" or "bool".

Change-Id: I12ec054b3f158b83e35031449cf2a088ff8d0dc2
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/489596
Auto-Submit: John Stiles <johnstiles@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
2021-12-28 20:55:32 +00:00
John Stiles
f604efbeb4 Add support for anonymous function parameters in SkSL.
Anonymous function parameters are now automatically assigned a name,
"_skAnonymousParamN", where N is the parameter index.

Change-Id: I87adcd51ed025c76ae2b333317f21b523a4632b4
Bug: skia:12769
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/489538
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: John Stiles <johnstiles@google.com>
Auto-Submit: John Stiles <johnstiles@google.com>
2021-12-28 20:47:05 +00:00
Leon Scroggins III
2cc656a89c ANDROIDFRAMEWORK_DEBUGF -> RENDERENGINE_ABORTF
Bug: b/206415266

We added ANDROIDFRAMEWORK_DEBUGF logs to help diagnose a crash, but the
bugreports start with the crash, which occurs after these logs. Change
the logs to ABORTs so the bugreports will contain this new information.

Only turn on the new abort statements when in RenderEngine. Add a new
define so that we can distinguish between the version of Skia used in
RenderEngine from the one in HWUI.

Change-Id: Ib096fc0b09741ec73ddedaa7cfdd21c5584d74cd
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/489476
Reviewed-by: Derek Sollenberger <djsollen@google.com>
Commit-Queue: Leon Scroggins <scroggo@google.com>
2021-12-28 20:22:11 +00:00
John Stiles
1c7d442b52 Add test containing anonymous function parameters.
SkSL will reject ES2-compatible code because function parameters always
require a name in SkSL. (A followup CL relaxes this restriction and
allows anonymous parameters in SkSL.)

Change-Id: Ifdcf0fcbe0f52d16007c018b545631ca4033a8c4
Bug: skia:12769
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/489537
Commit-Queue: John Stiles <johnstiles@google.com>
Auto-Submit: John Stiles <johnstiles@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2021-12-28 20:08:56 +00:00
John Stiles
106776364d Prevent structs/interface-blocks from claiming builtin types.
Structs and interface blocks allow a trailing identifier which is added
to the symbol table. This identifier is now prohibited from
overlapping built-in types.

Change-Id: I33b9d6156a27ce017e6744a05979748c04a04767
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/489516
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: John Stiles <johnstiles@google.com>
Auto-Submit: John Stiles <johnstiles@google.com>
2021-12-28 19:32:22 +00:00
John Stiles
48432e133e Add test demonstrating struct/interface-block name conflict.
Structs and interface blocks allow a trailing identifier which is added
to the symbol table. This identifier should be prohibited from
overlapping built-in types; at present, this is not checked. Add a test
demonstrating the issue.

Change-Id: I99aa915c1715c468cc369c97b7f12e031b86ea4a
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/489496
Auto-Submit: John Stiles <johnstiles@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: John Stiles <johnstiles@google.com>
2021-12-28 19:26:17 +00:00
John Stiles
1a746070ac Fix overzealous debug trace generation.
When the SkVM interpreter is operating in "stride=1" mode, we should
only look at the first lane of the trace/execution masks. The other
lanes are not being actively used, but the "index" opcode still fills
all the lanes, so it's entirely possible for the trace coordinate to
match in an unused lane.

Change-Id: I7f04f5c59431b3c50b4b072bc3ea4f52f8aa1a1b
Bug: skia:12752
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/488796
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: John Stiles <johnstiles@google.com>
Auto-Submit: John Stiles <johnstiles@google.com>
2021-12-28 15:39:16 +00:00
John Stiles
81134a7a62 Add checkbox to disable Shadertoy uniform support.
Generally these are harmless, but in some cases, they get in the way.
(e.g. when trying to make a minimal debug trace)

Change-Id: I2218e68c70fdbf85c3e10df232955038e2aaed29
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/488376
Auto-Submit: John Stiles <johnstiles@google.com>
Commit-Queue: John Stiles <johnstiles@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2021-12-28 15:04:50 +00:00
Brian Osman
2f2977e19d SkSL: Add color transform intrinsics
These convert a color between the working color space and a known,
useful space (linear TF, sRGB gamut).

Bug: skia:10479
Change-Id: I3308e691beeaca5120ed0c2e30cf08661caa3684
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/481416
Reviewed-by: Michael Ludwig <michaelludwig@google.com>
Reviewed-by: John Stiles <johnstiles@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2021-12-28 14:05:49 +00:00
skia-autoroll
fd3f23f90f Roll ANGLE from fce481863806 to 0a28c6c61b2f (3 revisions)
fce4818638..0a28c6c61b

2021-12-27 gert.wollny@collabora.com Capture/Replay: Capture some MultiDrawIndirect parameters
2021-12-27 gert.wollny@collabora.com Capture/Replay: Gather Program sources directly from call
2021-12-27 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 52c4c43d687f to 0635acc4de22 (149 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-skia-autoroll
Please CC johnstiles@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Build-Debian10-Clang-x86_64-Release-ANGLE;skia/skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC8i5BEK-GPU-IntelIris655-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE
Tbr: johnstiles@google.com
Change-Id: I43fb7a921c1ee9d456128cc7246b4d30876d917a
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/489097
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2021-12-28 05:24:19 +00:00
skia-autoroll
a66e1b204e Roll Dawn from b08e1e830776 to 5657f89f4489 (4 revisions)
https://dawn.googlesource.com/dawn.git/+log/b08e1e830776..5657f89f4489

2021-12-28 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 421ddb40e1c1 to 433b1bf9bff2 (1 revision)
2021-12-28 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from a92036893559 to 0a28c6c61b2f (2 revisions)
2021-12-27 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 87c78ac5eb86 to 421ddb40e1c1 (1 revision)
2021-12-27 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from fce481863806 to a92036893559 (1 revision)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dawn-skia-autoroll
Please CC jrprice@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Build-Debian10-Clang-x86_64-Debug-Dawn
Bug: None
Tbr: jrprice@google.com
Change-Id: I186a9c0ab846934583ab091b6809f61f3ede426c
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/489096
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2021-12-28 04:37:18 +00:00
skia-autoroll
137d540f93 Roll Chromium from af759c2dd2c7 to c657707aead4 (100 revisions)
af759c2dd2..c657707aea

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-skia-autoroll
Please CC johnstiles@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Perf-Mac10.13-Clang-MacBookPro11.5-GPU-RadeonHD8870M-x86_64-Release-All-CommandBuffer;skia/skia.primary:Test-Mac10.13-Clang-MacBookPro11.5-GPU-RadeonHD8870M-x86_64-Debug-All-CommandBuffer
Tbr: johnstiles@google.com
Change-Id: I19e8af410833d088f927d82142df83c6aac0d24c
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/489098
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2021-12-28 04:37:15 +00:00
skia-autoroll
26e3815278 Roll ANGLE from 4d893a93596e to fce481863806 (2 revisions)
4d893a9359..fce4818638

2021-12-24 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from f354daff5a2b to 87c78ac5eb86 (2 revisions)
2021-12-24 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 16dc16f9ec67 to 52c4c43d687f (244 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-skia-autoroll
Please CC johnstiles@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Build-Debian10-Clang-x86_64-Release-ANGLE;skia/skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC8i5BEK-GPU-IntelIris655-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE
Tbr: johnstiles@google.com
Change-Id: If999757fdb12a718e74db1edce4fc679d31ec036
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/489038
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2021-12-27 05:24:20 +00:00
skia-autoroll
f9e27a2725 Roll Chromium from f6bf4a6d25b2 to af759c2dd2c7 (150 revisions)
f6bf4a6d25..af759c2dd2

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-skia-autoroll
Please CC johnstiles@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Perf-Mac10.13-Clang-MacBookPro11.5-GPU-RadeonHD8870M-x86_64-Release-All-CommandBuffer;skia/skia.primary:Test-Mac10.13-Clang-MacBookPro11.5-GPU-RadeonHD8870M-x86_64-Debug-All-CommandBuffer
Tbr: johnstiles@google.com
Change-Id: I9f970b0956d792f51e4ff9b7bfc0422b724c24c5
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/489036
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2021-12-27 04:42:48 +00:00
skia-autoroll
a73b9b519d Roll Dawn from 7eb11f75c925 to b08e1e830776 (2 revisions)
https://dawn.googlesource.com/dawn.git/+log/7eb11f75c925..b08e1e830776

2021-12-24 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 4d893a93596e to fce481863806 (2 revisions)
2021-12-24 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from f1afdde60a81 to 87c78ac5eb86 (1 revision)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dawn-skia-autoroll
Please CC enga@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Build-Debian10-Clang-x86_64-Debug-Dawn
Bug: None
Tbr: enga@google.com
Change-Id: Ibe86095e04f4e084b82702ac39bd111c029f88da
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/489037
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2021-12-27 04:39:46 +00:00
skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com
e34674502d Update SKP version
Automatic commit by the RecreateSKPs bot.

Change-Id: Ic3f58787abd82dff63aa39cbae76729225ed7cd5
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/488877
Commit-Queue: skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Bot-Commit: skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
2021-12-26 07:32:49 +00:00
skia-autoroll
8261ed4cb6 Roll SK Tool from d2932d0690dc to 1fa06a8d9fd6
https://skia.googlesource.com/buildbot.git/+log/d2932d0690dc..1fa06a8d9fd6

2021-12-26 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update CIPD Packages

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/sk-tool-skia
Please CC borenet@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Tbr: borenet@google.com
Change-Id: Ic65d515c1391bb6f7d8672341e45fad734f52499
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/488896
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2021-12-26 06:11:49 +00:00
skia-autoroll
dc67736cd6 Roll ANGLE from 2ebd583edbf7 to 4d893a93596e (4 revisions)
2ebd583edb..4d893a9359

2021-12-23 jmadill@chromium.org Re-land: "Trace Tests: Remove auto-generated code."
2021-12-23 timvp@google.com Vulkan: Copy buffer data to correct cube map face
2021-12-23 angle-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from fbeca8f4ea6a to c32df39c11ce (3 revisions)
2021-12-23 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 274ab850e849 to 16dc16f9ec67 (303 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-skia-autoroll
Please CC egdaniel@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Build-Debian10-Clang-x86_64-Release-ANGLE;skia/skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC8i5BEK-GPU-IntelIris655-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE
Tbr: egdaniel@google.com
Test: Test: TextureCubeTestES3.CubeMapPixelUnpackBuffer
Change-Id: I4a935cda3dc102ec660b5cae5872f4fa314237f0
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/488602
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2021-12-24 05:22:48 +00:00
skia-autoroll
f4a2fc4c76 Roll Chromium from e6b9e8edc4d0 to f6bf4a6d25b2 (247 revisions)
e6b9e8edc4..f6bf4a6d25

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-skia-autoroll
Please CC egdaniel@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Perf-Mac10.13-Clang-MacBookPro11.5-GPU-RadeonHD8870M-x86_64-Release-All-CommandBuffer;skia/skia.primary:Test-Mac10.13-Clang-MacBookPro11.5-GPU-RadeonHD8870M-x86_64-Debug-All-CommandBuffer
Tbr: egdaniel@google.com
Change-Id: I47176d6c0e5040ac07cdb98ee660c82b4200306a
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/488600
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2021-12-24 04:57:18 +00:00
skia-autoroll
ad5f4f7e3b Roll Dawn from a83c434cc785 to 7eb11f75c925 (7 revisions)
https://dawn.googlesource.com/dawn.git/+log/a83c434cc785..7eb11f75c925

2021-12-24 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 582651bee8a9 to 4d893a93596e (2 revisions)
2021-12-23 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Tint from 9943de681369 to 7913982f8734 (1 revision)
2021-12-23 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from f354daff5a2b to f1afdde60a81 (1 revision)
2021-12-23 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 14af7a8da786 to 582651bee8a9 (3 revisions)
2021-12-23 jiawei.shao@intel.com Add a missing space in the error message of SetIndexBuffer
2021-12-23 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 8a76fb59b27e to c32df39c11ce (2 revisions)
2021-12-23 junwei.fu@intel.com Make the templates of webgpu_absl_format flexible

Also rolling transitive DEPS:
  https://dawn.googlesource.com/tint from 9943de681369 to 7913982f8734

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dawn-skia-autoroll
Please CC enga@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Build-Debian10-Clang-x86_64-Debug-Dawn
Bug: None
Tbr: enga@google.com
Change-Id: I7ac468fc0f2351f07f19c46553ec61e52359a22a
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/488601
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2021-12-24 04:38:47 +00:00
Michael Ludwig
bd05d877db Use clipped bounds for tessellation heuristic
The heuristic estimates the fill cost of the path based on its bounds.
The goal is to use the inner triangulator for large paths with a low
vertex count so that filling is simpler (no stencil), but triangulation
cost is manageable.

Considering the unclipped bounds means that very large path coordinates
can mislead the heuristic into thinking there is substantial fill cost,
when in fact that's always bounded by the clip dimensions.

Bug: skia:12764
Change-Id: I9d14bbdd2b35df121b6a55d4a278656bf16ae8eb
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/488528
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Michael Ludwig <michaelludwig@google.com>
2021-12-24 01:01:42 +00:00
Greg Daniel
c1bc0205d9 [graphite] Move GrResourceKey to skgpu::ResourceKey.
We'll want to reuse this key class for Graphite resources as well. There
is nothing special about these keys that is Ganesh specific.

Bug: skia:12754
Change-Id: I39fe5a9968156985865bccbfc4978583120ac2e8
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/487384
Reviewed-by: Michael Ludwig <michaelludwig@google.com>
Commit-Queue: Greg Daniel <egdaniel@google.com>
2021-12-23 22:55:19 +00:00
Michael Ludwig
c2b31fb04a Use unsigned int to track POD skip
Bug: chromium:1274323
Change-Id: I5d2a25c381ddfa21e56b630139fa61a0bdd8d4e0
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/488527
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Commit-Queue: Michael Ludwig <michaelludwig@google.com>
2021-12-23 20:44:09 +00:00
Leon Scroggins III
a7cb849eca Be more lenient with RLE BMPs
Bug: b/198566237

If the RLE data exceeds the width of the image, treat it as an incorrect
value in the number of pixels in the run. This allows decoding images
that are supported by other decoders (e.g. Mac Preview).

Add a test image to skimage tests.

Change-Id: I10955cbde3e28accf670417fa154a536c0732e6a
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/488296
Reviewed-by: Derek Sollenberger <djsollen@google.com>
Commit-Queue: Leon Scroggins <scroggo@google.com>
2021-12-23 20:32:52 +00:00
Kevin Lubick
c10950a60f [docs] Fix skottie.md
This adjusts the alignment as well as the loading of canvaskit
and the inline element.

Change-Id: I8adf28e08a714ac466b751183a3dd9c3cc5de1a6
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/488523
Reviewed-by: Ravi Mistry <rmistry@google.com>
2021-12-23 18:10:48 +00:00
Ravi Mistry
887e3422de Report metrics in RecreateSKPs bot
Failures in this bot are easy to miss since it runs infrequently
(nightly/weekly).
This change reports build and asset creation successes/failures to new
metrics. Alerts will be created from these metrics.

Bug: skia:12759
Change-Id: I07db58dcd5ee1929e16717cc7be66062f30d3670
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/487976
Reviewed-by: Joe Gregorio <jcgregorio@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
2021-12-23 15:32:51 +00:00
Kevin Lubick
24b62f8575 [skottie] Deploy Bazel-built version
Requires https://skia-review.googlesource.com/c/buildbot/+/487224/ to land

Change-Id: I677576ad4b0eca6fd356f99af9b389a0522891d6
Bug: skia:10614
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/488297
Reviewed-by: Ravi Mistry <rmistry@google.com>
2021-12-23 14:44:41 +00:00
Lei Zhang
7f99e8d824 Remove SkM44.h include from SkImage.h.
It is not needed there. Add it to files that do need it instead.

Change-Id: I2fa32d423972c4c91c4fbfe5508bd50323201714
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/463556
Reviewed-by: Derek Sollenberger <djsollen@google.com>
Auto-Submit: Lei Zhang <thestig@chromium.org>
Commit-Queue: Greg Daniel <egdaniel@google.com>
2021-12-23 13:45:20 +00:00
skia-autoroll
1a6f1618a7 Roll ANGLE from 0e9353f60cd3 to 2ebd583edbf7 (5 revisions)
0e9353f60c..2ebd583edb

2021-12-22 cnorthrop@google.com Android: Remove setenv from common path
2021-12-22 ynovikov@chromium.org Log subprocess output in run_perf_tests.py
2021-12-22 cclao@google.com Vulkan: Remove mShadowBuffer from BufferVk class.
2021-12-22 ynovikov@chromium.org Unskip MRTSigned and MRTUnsigned BlendIntegerTest
2021-12-22 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 9ca41364d3dc to 274ab850e849 (341 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-skia-autoroll
Please CC egdaniel@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Build-Debian10-Clang-x86_64-Release-ANGLE;skia/skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC8i5BEK-GPU-IntelIris655-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE
Tbr: egdaniel@google.com
Change-Id: I266844bf3a4a7914759d71050b64cff25100990e
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/488438
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2021-12-23 05:23:49 +00:00
skia-autoroll
fe04a1183e Roll Chromium from b854f9c7fff3 to e6b9e8edc4d0 (320 revisions)
b854f9c7ff..e6b9e8edc4

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-skia-autoroll
Please CC egdaniel@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Perf-Mac10.13-Clang-MacBookPro11.5-GPU-RadeonHD8870M-x86_64-Release-All-CommandBuffer;skia/skia.primary:Test-Mac10.13-Clang-MacBookPro11.5-GPU-RadeonHD8870M-x86_64-Debug-All-CommandBuffer
Tbr: egdaniel@google.com
Change-Id: Ic6c9910e333b98b3a4bf52f72db29d35da217dda
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/488436
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2021-12-23 04:43:18 +00:00
skia-autoroll
f55ababa0c Roll Dawn from 2b1dcd92b1ae to a83c434cc785 (8 revisions)
https://dawn.googlesource.com/dawn.git/+log/2b1dcd92b1ae..a83c434cc785

2021-12-23 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 993f388967f8 to 14af7a8da786 (3 revisions)
2021-12-22 enga@chromium.org Update tests to use wgpu::DeviceDescriptor
2021-12-22 enga@chromium.org Implement upstream RequestDevice, add native-only CreateDevice
2021-12-22 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Tint from cc4d97b6e319 to 9943de681369 (1 revision)
2021-12-22 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from fbeca8f4ea6a to 8a76fb59b27e (1 revision)
2021-12-22 cwallez@chromium.org Reland "Bump maxUniformBindingSize to 2^16 from 2^14"
2021-12-22 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from bc9d2d7de9d4 to 993f388967f8 (2 revisions)
2021-12-22 ningxin.hu@intel.com Make the template of ProcTable flexible

Also rolling transitive DEPS:
  https://dawn.googlesource.com/tint from cc4d97b6e319 to 9943de681369

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dawn-skia-autoroll
Please CC enga@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Build-Debian10-Clang-x86_64-Debug-Dawn
Bug: None
Tbr: enga@google.com
Change-Id: I53bfeb083b042e2e563e0e8371448649023a954e
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/488437
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2021-12-23 04:35:50 +00:00
Leon Scroggins III
ba7ad38faa Use wuffs for gif
Bug: b/195936927

Depends on aosp/Ic69acf8c3d1a783af7000a453117517475518329

Change-Id: I4d23f159ee6acf25c64693d642916f15fbc69f4a
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/484443
Reviewed-by: Derek Sollenberger <djsollen@google.com>
Commit-Queue: Leon Scroggins <scroggo@google.com>
2021-12-22 20:37:50 +00:00
John Stiles
87ced29082 Track line reachability on a step-by-step basis.
Since we know the entire flow of execution ahead of time, at any point
during trace playback, we can know if a line will be reached again or
not. We no longer highlight lines as reachable (or allow setting
breakpoints) if the line will not be reached again during trace
playback.

Change-Id: Iff563b13e2f6efb5d4f2ff37215f2ff4fb5945ed
Bug: skia:12666
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/486496
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: John Stiles <johnstiles@google.com>
Auto-Submit: John Stiles <johnstiles@google.com>
2021-12-22 19:33:17 +00:00
Brian Osman
1ba283e6b4 In GPU CanvasKit, default to sRGB surfaces
Change-Id: I1931b09e6a4a52fb7d91a0d3f013e1d0519919dd
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/487977
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2021-12-22 18:13:49 +00:00
Brian Salomon
c46cbd96bf Clear offscreen surface in custommesh_cs to white
Makes the GM draw better in 1010102 configs

Bug: skia:12720
Change-Id: I587c542e602b6e2d972444a45aa222a646f8ff70
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/488176
Commit-Queue: Brian Salomon <bsalomon@google.com>
Auto-Submit: Brian Salomon <bsalomon@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2021-12-22 18:06:19 +00:00
Brian Salomon
bc35172ce9 custom mesh produces color in user defined color space and alpha type
Bug: skia:12720
Change-Id: Icece250cd2642e63f9e04f139dc951f34f82c2ad
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/487383
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
2021-12-22 16:22:44 +00:00
Joe Gregorio
249afd964b Add Perf and Test bots for JioNext phones.
Change-Id: Ifd8b8506f9a00253dada0e8787d4dcc9907a42ee
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/484436
Reviewed-by: Ravi Mistry <rmistry@google.com>
Commit-Queue: Joe Gregorio <jcgregorio@google.com>
2021-12-22 15:43:49 +00:00
skia-autoroll
112f9f1273 Roll ANGLE from 171bc07e2f06 to 0e9353f60cd3 (11 revisions)
171bc07e2f..0e9353f60c

2021-12-21 ynovikov@chromium.org Skip RenderbufferDrawStencilThenUnresolveStencil on Linux Vulkan AMD
2021-12-21 cclao@google.com Vulkan: Consolidate BufferHelper's code paths into one
2021-12-21 syoussefi@chromium.org Vulkan: Simplify transform feedback emulation logic
2021-12-21 angle-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 5568048d205e to fbeca8f4ea6a (4 revisions)
2021-12-21 jmadill@chromium.org Upgrade restricted traces. (Re-land)
2021-12-21 jmadill@chromium.org Frame Capture: Allow for no FBO when running MEC.
2021-12-21 jmadill@chromium.org Capture/Replay: Fix uniform program indexing.
2021-12-21 jmadill@chromium.org Suppress capture/replay tests.
2021-12-21 jmadill@chromium.org Revert "Metal: Fix Webkit warnings in ANGLE build"
2021-12-21 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 81decb7250e1 to 9ca41364d3dc (272 revisions)
2021-12-21 syoussefi@chromium.org Temporarily skip failing tests on Chromium

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-skia-autoroll
Please CC egdaniel@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Build-Debian10-Clang-x86_64-Release-ANGLE;skia/skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC8i5BEK-GPU-IntelIris655-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE
Tbr: egdaniel@google.com
Change-Id: Ie572687a5c5c835e87565dd338b517808b3746f0
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/487738
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2021-12-22 05:24:16 +00:00
skia-autoroll
c9f9d0480f Roll Chromium from 67b5b8435f0d to b854f9c7fff3 (326 revisions)
67b5b8435f..b854f9c7ff

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-skia-autoroll
Please CC egdaniel@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Perf-Mac10.13-Clang-MacBookPro11.5-GPU-RadeonHD8870M-x86_64-Release-All-CommandBuffer;skia/skia.primary:Test-Mac10.13-Clang-MacBookPro11.5-GPU-RadeonHD8870M-x86_64-Debug-All-CommandBuffer
Tbr: egdaniel@google.com
Change-Id: I6c2ecf07f41f97476b0a50d2d8fdc701344a8054
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/487736
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2021-12-22 04:58:51 +00:00
skia-autoroll
f6e58b6020 Roll Dawn from bd5eb6fa269a to 2b1dcd92b1ae (10 revisions)
https://dawn.googlesource.com/dawn.git/+log/bd5eb6fa269a..2b1dcd92b1ae

2021-12-22 junwei.fu@intel.com Make the templates of ChainUtils and ObjectType flexible
2021-12-21 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 543f5750f70e to bc9d2d7de9d4 (31 revisions)
2021-12-21 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Tint from 821f9bb525a3 to cc4d97b6e319 (1 revision)
2021-12-21 enga@chromium.org Roll third_party/vulkan_memory_allocator/ e0216a548..5e49f57a6 (87 commits)
2021-12-21 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 39f3a18bdfbe to fbeca8f4ea6a (12 revisions)
2021-12-21 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 562df4889b81 to f354daff5a2b (164 revisions)
2021-12-21 enga@chromium.org Roll third_party/vulkan_memory_allocator/ 1ecb35c39..e0216a548 (103 commits)
2021-12-21 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Tint from 5965c6ed1fd5 to 821f9bb525a3 (1 revision)
2021-12-21 jiawei.shao@intel.com dawn_wire: use memcpy on structures when possible
2021-12-21 yunchao.he@intel.com Implement readonly depth/stencil without sample from it

Also rolling transitive DEPS:
  https://dawn.googlesource.com/tint from 5965c6ed1fd5 to cc4d97b6e319

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dawn-skia-autoroll
Please CC enga@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Build-Debian10-Clang-x86_64-Debug-Dawn
Bug: None
Tbr: enga@google.com
Change-Id: I0e96d4126d5150eb1cea150b3d852430ba1e2685
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/487737
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2021-12-22 04:36:18 +00:00
Greg Daniel
fe995770fe Remove all unused uniqueKey support from SkPromiseImageTexture.
At this point SkPromiseImageTexture is not much more than a wrapper
around a GrBackendTexture. The next steps would be to switch to just
directly using GrBackendTexture in the fulfill procs and deleting
SkPromiseImageTexture.

Bug: skia:12758
Change-Id: Ic0526b869a0730c25b41b46fd6523604dedaba40
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/487382
Auto-Submit: Greg Daniel <egdaniel@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
2021-12-21 21:32:43 +00:00
Michael Ludwig
bdc0bad2e2 [graphite] Implement inverse fills
Renderer::StencilAndFill() chooses between two instances based on fill
type (more to come when we add stencil pass). The inverse fill uses
different stencil settings and different geometry (hence why it must be
a distinct renderer, since stencil is part of the pipeline).

Also updates the command buffer asserts and types to support float3
attributes and has the fill bounds render step pre-transform vertices.
This matches the intended plan of device-space control points to
avoid matrix transform uniforms when no other coords are needed.

Makes DepthStencilSettings constexpr so they can be declared constants.

Cq-Include-Trybots: luci.skia.skia.primary:Test-Mac11-Clang-MacMini9.1-GPU-AppleM1-arm64-Release-All-Graphite,Test-Mac11-Clang-MacMini9.1-GPU-AppleM1-arm64-Debug-All-ASAN_Graphite,Build-Mac-Clang-arm64-Release-iOS_Graphite,Build-Mac-Clang-arm64-Release-Graphite,Build-Mac-Clang-arm64-Debug-iOS_Graphite,Build-Mac-Clang-arm64-Debug-Graphite_NoGpu,Build-Mac-Clang-arm64-Debug-Graphite,Build-Mac-Clang-arm64-Debug-ASAN_Graphite
Bug: skia:12703
Change-Id: I5be4151f533e4cc5c560baf96c59193162b48dab
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/484559
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Michael Ludwig <michaelludwig@google.com>
2021-12-21 20:44:51 +00:00
Ravi Mistry
bd7cb72770 Add new g3_canary_infra_failure metric
Using prometheus's pushgateway since the metric will be reported from a task driver (a short-lived service-level job).

Updated go.mod/go.sum to get pushgateway libraries with:
$ go get go.skia.org/infra@2dce552b7a
$ go mod download
$ make -C infra/bots train

Bug: skia:12521
Change-Id: Ic63487b08d06163ef92556999c4920e5f178e285
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/487227
Reviewed-by: Joe Gregorio <jcgregorio@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
2021-12-21 20:30:25 +00:00
Brian Osman
4c4cf43db4 Run SkVM Visualizer test on all platforms
Change-Id: Ibff6f08e569b5365732404a56fc3b9bf7c2fa1f9
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/487377
Reviewed-by: John Stiles <johnstiles@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2021-12-21 20:07:39 +00:00
Brian Salomon
12532a3a8f Add indexed support to custom mesh drawing
Bug: skia:12720
Change-Id: Ia40f2325e565d2dfbbac285b45eec6efc2944532
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/486896
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
2021-12-21 19:51:07 +00:00