Commit Graph

423 Commits

Author SHA1 Message Date
senorblanco@chromium.org
4e4b09a44e Rebaselines for more straggling bots.
TBR=

Review URL: https://codereview.chromium.org/121943003

git-svn-id: http://skia.googlecode.com/svn/trunk@12902 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-04 17:22:04 +00:00
senorblanco@chromium.org
7b6d4d6783 Yet more rebaselines from straggling bots.
BUG=
TBR=

Review URL: https://codereview.chromium.org/116463005

git-svn-id: http://skia.googlecode.com/svn/trunk@12900 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-04 04:19:38 +00:00
senorblanco@chromium.org
4e13914e3c Stragglers.
TBR=

Review URL: https://codereview.chromium.org/124353004

git-svn-id: http://skia.googlecode.com/svn/trunk@12899 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-04 02:36:24 +00:00
senorblanco@chromium.org
323cc26308 New baselines for tileimagefilter, imagefiltersgraph, and everything Nexus4.
TBR=

Review URL: https://codereview.chromium.org/101693010

git-svn-id: http://skia.googlecode.com/svn/trunk@12898 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-04 00:14:54 +00:00
senorblanco@chromium.org
c8c599269d Widen suppression to tileimagefilter-pdf.
TBR=

Review URL: https://codereview.chromium.org/122683004

git-svn-id: http://skia.googlecode.com/svn/trunk@12897 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-03 22:27:05 +00:00
senorblanco@chromium.org
a502d60b93 Ignore failures on tileimagefilter-pdf_poppler.
TBR=

Review URL: https://codereview.chromium.org/124263003

git-svn-id: http://skia.googlecode.com/svn/trunk@12896 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-03 22:18:12 +00:00
senorblanco@chromium.org
6776b82d46 Make SkImageFilter crop rects relative to the primitive origin, instead of relative to their parent's crop rect. This is required by SVG semantics, and is more sane anyway.
To do this, this patch changes the "offset/loc" parameter in filterImage() / onFilterImage() from an inout-param to an out-param only, so that the calling filter can know how much the input filter wants its result offset (and doesn't include the original primitive position). This offset can then be applied to the current filter's crop rect. (I've renamed the parameter "offset" in all cases to make this clear.) This makes the call sites in SkCanvas/SkGpuDevice responsible for applying the resulting offset to the primitive's position, which is actually a fairly small change.

This change also fixes SkTileImageFilter and SkOffsetImageFilter to correctly handle an input offset, which they weren't before. This required modifying the GM's, since they assumed the broken behaviour.

NOTE: this will require rebaselining the imagefiltersgraph test, since it has a new test case.

NOTE: this will "break" the Blink layout tests css3/filters/effect-reference-subregion-chained-hw.html and css3/filters/effect-reference-subregion-hw.html, but it actually makes them give correct results. It should be suppressed on the skia roll, and I'll rebaseline it.

R=reed@google.com

Review URL: https://codereview.chromium.org/112803004

git-svn-id: http://skia.googlecode.com/svn/trunk@12895 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-03 21:48:22 +00:00
halcanary@google.com
dab032a4ba Update 4 skimage expectations.
Grab expectations missed in codereview:102213009, sicne the bots were slow:
-  Test-ChromeOS-Daisy-MaliT604-Arm7-Debug
-  Test-ChromeOS-Daisy-MaliT604-Arm7-Release
-  Test-Ubuntu12-ShuttleA-ATI5770-x86_64-Release-Valgrind
-  Test-Ubuntu13-ShuttleA-HD2000-x86_64-Debug-ASAN

BUG=
R=epoger@google.com

Review URL: https://codereview.chromium.org/93713007

git-svn-id: http://skia.googlecode.com/svn/trunk@12869 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-02 20:43:26 +00:00
borenet@google.com
4be2e001d2 Empty skimage expectations for Logan
R=scroggo@google.com

Review URL: https://codereview.chromium.org/110393005

git-svn-id: http://skia.googlecode.com/svn/trunk@12809 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-20 21:35:51 +00:00
halcanary@google.com
89a38d3fb7 Rebaseline for WebP
What I did:

#!/bin/sh
cd expectations/skimage
for D in *; do
    [ -d "$D" ] || continue
    [ -f "${D}/expected-results.json" ] || continue
    gsutil cp \
        "gs://chromium-skia-gm/skimage/actuals/${D}/actual-results.json" \
        "${D}/expected-results.json"
done
cd ../..

R=robertphillips@google.com

Review URL: https://codereview.chromium.org/102213009

git-svn-id: http://skia.googlecode.com/svn/trunk@12805 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-20 19:22:35 +00:00
borenet@google.com
33c3b1e171 Skimage expectations for Valgrind builder
R=robertphillips@google.com

Review URL: https://codereview.chromium.org/115693005

git-svn-id: http://skia.googlecode.com/svn/trunk@12797 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-20 14:35:24 +00:00
bsalomon@google.com
3f2028e3e6 rebaselinedownsamplebitmap_image_high_mandrill_512.png
BUG=skia:1879

Review URL: https://codereview.chromium.org/101413010

git-svn-id: http://skia.googlecode.com/svn/trunk@12787 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-19 21:36:35 +00:00
bsalomon@google.com
cc36aab8ff Some more medium/MIP downsample gpu rebaslines and misc gpu innocuous rebaselines
Review URL: https://codereview.chromium.org/106523004

git-svn-id: http://skia.googlecode.com/svn/trunk@12785 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-19 20:54:47 +00:00
bsalomon@google.com
cf95fbad6b rebaseline clipped-bitmap-shaders GMs for gpu
Review URL: https://codereview.chromium.org/119443002

git-svn-id: http://skia.googlecode.com/svn/trunk@12784 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-19 20:44:04 +00:00
bsalomon@google.com
dc8efaba99 rebaseline medium quality downscale images after mipmap change
Review URL: https://codereview.chromium.org/113803004

git-svn-id: http://skia.googlecode.com/svn/trunk@12780 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-19 19:36:18 +00:00
commit-bot@chromium.org
6d7296aaa0 Accept displacement with no displacement input
BUG=
R=senorblanco@google.com, senorblanco@chromium.org, sugoi@google.com, bsalomon@google.com, bsalomon@chromium.org

Author: sugoi@chromium.org

Review URL: https://codereview.chromium.org/104853005

git-svn-id: http://skia.googlecode.com/svn/trunk@12773 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-19 17:00:46 +00:00
senorblanco@chromium.org
144cba079c New baselines for xfermodeimagefilter post-r12652.
TBR=reed@google.com
BUG=

Review URL: https://codereview.chromium.org/118803003

git-svn-id: http://skia.googlecode.com/svn/trunk@12769 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-19 15:41:12 +00:00
vandebo@chromium.org
7e5d24c22e Update expectations for r12729
"[PDF] Fix clipping in xfermode improvement."

TBR=bungeman@google.com

Review URL: https://codereview.chromium.org/112343007

git-svn-id: http://skia.googlecode.com/svn/trunk@12761 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-18 22:20:16 +00:00
commit-bot@chromium.org
d20f9b7358 Rebaselining displacement gms
Rebaseline needed because of changes made in https://codereview.chromium.org/101623007/

BUG=
R=senorblanco@chromium.org, senorblanco@google.com, bsalomon@google.com, bsalomon@chromium.org, sugoi@google.com

Author: sugoi@chromium.org

Review URL: https://codereview.chromium.org/101643003

git-svn-id: http://skia.googlecode.com/svn/trunk@12741 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-18 16:50:13 +00:00
commit-bot@chromium.org
4e8f1e56b1 [PDF] Fix clipping in xfermode improvement.
In some cases, the wrong clip (src clip instead of initial clip) was used.
Switch almost exclusively to initial clip because it is safe and generates a smaller result.

BUG=chromium:328009
R=reed@google.com, bungeman@google.com

Author: vandebo@chromium.org

Review URL: https://codereview.chromium.org/116423004

git-svn-id: http://skia.googlecode.com/svn/trunk@12729 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-17 23:38:28 +00:00
bsalomon@google.com
d6c1d58763 Remove bleed from ignored-tests.txt
BUG=skia:1880

Review URL: https://codereview.chromium.org/103213011

git-svn-id: http://skia.googlecode.com/svn/trunk@12726 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-17 21:27:39 +00:00
bsalomon@google.com
62bb849a88 Mark bleed gpu as ignore failure on Xoom (Release version)
BUG=skia:1938

Review URL: https://codereview.chromium.org/117633002

git-svn-id: http://skia.googlecode.com/svn/trunk@12725 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-17 21:20:41 +00:00
bsalomon@google.com
c1c6a4f552 Mark bleed gpu as ignore failure on Xoom
BUG=skia:1938

Review URL: https://codereview.chromium.org/116093005

git-svn-id: http://skia.googlecode.com/svn/trunk@12724 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-17 21:13:00 +00:00
bsalomon@google.com
7d0b613191 Mark 8888/565 bleed GMS as ignore-failure
BUG=skia:1934

Review URL: https://codereview.chromium.org/117563003

git-svn-id: http://skia.googlecode.com/svn/trunk@12722 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-17 20:30:17 +00:00
commit-bot@chromium.org
55f6b24eb8 Add unreviewed skimage expectations for Test-Win8-ShuttleA-GTX660-x86-Release-NVPR
NOTRY=True
BUG=
R=scroggo@google.com

Author: borenet@google.com

Review URL: https://codereview.chromium.org/110663006

git-svn-id: http://skia.googlecode.com/svn/trunk@12715 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-17 17:35:13 +00:00
commit-bot@chromium.org
bf8ba65cca Add Win8 bots to rebaseline.py, add baselines for Win8
NOTRY=True
BUG=
R=epoger@google.com

Author: borenet@google.com

Review URL: https://codereview.chromium.org/117433003

git-svn-id: http://skia.googlecode.com/svn/trunk@12714 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-17 17:29:33 +00:00
bsalomon@google.com
a34b638b90 Rebaseline gpu and pdf bleed GM images
BUG=1880

Review URL: https://codereview.chromium.org/100023006

git-svn-id: http://skia.googlecode.com/svn/trunk@12711 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-17 16:37:07 +00:00
commit-bot@chromium.org
4952516abe Create empty GM expectations for all Win8 builders
(SkipBuildbotRuns)
NOTRY=True
NOTREECHECKS=True
R=borenet@google.com

Author: epoger@google.com

Review URL: https://codereview.chromium.org/117233003

git-svn-id: http://skia.googlecode.com/svn/trunk@12710 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-17 16:33:35 +00:00
bsalomon@google.com
442fa37ffd Rebaseline innocuous image changes on Android.
Review URL: https://codereview.chromium.org/117343002

git-svn-id: http://skia.googlecode.com/svn/trunk@12708 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-17 15:34:17 +00:00
scroggo@google.com
c285864fb7 Add new baselines for Win8 decoding tests.
Taken from server, and unreviewed.

Review URL: https://codereview.chromium.org/114813005

git-svn-id: http://skia.googlecode.com/svn/trunk@12700 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-16 23:09:20 +00:00
bsalomon@google.com
477ed38504 rebaseline android images that use bicubic effect
Review URL: https://codereview.chromium.org/116573002

git-svn-id: http://skia.googlecode.com/svn/trunk@12693 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-16 18:51:33 +00:00
commit-bot@chromium.org
c7a8507e97 Perlin noise rebaseline
BUG=skia:1881

Committed: https://code.google.com/p/skia/source/detail?r=5f145c9

R=sugoi@google.com, mtklein@google.com

Author: sugoi@chromium.org

Review URL: https://codereview.chromium.org/99433007

git-svn-id: http://skia.googlecode.com/svn/trunk@12659 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-12 23:00:10 +00:00
commit-bot@chromium.org
5e79c2b707 Fixed a displacement issue
The displacement filter was assuming that both inputs were of the same size, which is true in blink, but not necessarily in a compromised stream.

BUG=327372
R=senorblanco@chromium.org, senorblanco@google.com, reed@google.com, fmalita@chromium.org, fmalita@google.com, sugoi@google.com

Author: sugoi@chromium.org

Review URL: https://codereview.chromium.org/101623007

git-svn-id: http://skia.googlecode.com/svn/trunk@12655 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-12 21:48:32 +00:00
senorblanco@chromium.org
0682019f21 Bounds fixes for SkXfermodeImageFilter:
1) Change the default bounds to the union of the foreground and background bounds.
2) Use a canvas translate instead of manually offsetting the foreground and background bounds by the union.
3) Apply the transfer mode to all pixels, including those outside the foreground rect by using a difference clip.

Covered by the offset test cases in the xfermodeimagefilter GM (will need rebaselines).

R=reed@google.com

Review URL: https://codereview.chromium.org/112683004

git-svn-id: http://skia.googlecode.com/svn/trunk@12652 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-12 21:00:58 +00:00
commit-bot@chromium.org
7eee8d60b9 GM: stroke-fill results for pdf-poppler
(some stragglers that snuck in overnight while pdf-poppler was still ignored)

NOTRY=True
NOTREECHECKS=True
R=rmistry@google.com
TBR=rmistry

Author: epoger@google.com

Review URL: https://codereview.chromium.org/103383003

git-svn-id: http://skia.googlecode.com/svn/trunk@12644 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-12 16:47:06 +00:00
commit-bot@chromium.org
7746c1c4c2 GM: stop ignoring pdf-poppler failures
BUG=skia:1657
NOTRY=True
R=vandebo@chromium.org

Author: epoger@google.com

Review URL: https://codereview.chromium.org/108813007

git-svn-id: http://skia.googlecode.com/svn/trunk@12643 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-12 16:34:50 +00:00
vandebo@chromium.org
c4558353a7 Update stroke-fill_pdf-native.png after r12625
TBR=bungeman@google.com

Review URL: https://codereview.chromium.org/102443006

git-svn-id: http://skia.googlecode.com/svn/trunk@12627 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-11 20:11:27 +00:00
commit-bot@chromium.org
3028217e16 remaining GM baselines for pdf-poppler
R=vandebo@chromium.org
TBR=vandebo
BUG=
(SkipBuildbotRuns)
NOTRY=True
NOTREECHECKS=True

Author: epoger@google.com

Review URL: https://codereview.chromium.org/112973004

git-svn-id: http://skia.googlecode.com/svn/trunk@12626 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-11 20:08:18 +00:00
robertphillips@google.com
2e7958f8fb Add clipped-bitmap-shaders-*-hq_angle.png to ignore-tests.txt
git-svn-id: http://skia.googlecode.com/svn/trunk@12594 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-10 12:56:56 +00:00
commit-bot@chromium.org
aee7e2d40b Correct baseline images for new "bitmapshaders" test
(SkipBuildbotRuns)
NOTRY=True
BUG=
R=djsollen@google.com

Author: epoger@google.com

Review URL: https://codereview.chromium.org/110643002

git-svn-id: http://skia.googlecode.com/svn/trunk@12593 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-10 12:54:21 +00:00
epoger@google.com
331e237890 GM expectations: create initial empty expectations for Test-Ubuntu12-ShuttleA-ATI5770-x86_64-Release-Valgrind
(SkipBuildbotRuns)
TBR=djsollen

Review URL: https://codereview.chromium.org/100643003

git-svn-id: http://skia.googlecode.com/svn/trunk@12585 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-09 21:02:11 +00:00
bsalomon@google.com
bc8b1ff885 add hq clipped biptmap shader GMs to ignored-tests.txt
TBR=robertphillips@google.com

Review URL: https://codereview.chromium.org/93633003

git-svn-id: http://skia.googlecode.com/svn/trunk@12584 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-09 20:52:47 +00:00
senorblanco@chromium.org
c80f2f7ab3 New Nexus4 baselines due to r12571.
R=robertphillips

Review URL: https://codereview.chromium.org/110603003

git-svn-id: http://skia.googlecode.com/svn/trunk@12583 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-09 20:52:40 +00:00
bsalomon@google.com
862c4d658f Mark rrect_clip_aa, skbug1719, and pathopsskpclip as ignored on N4 gpu
BUG=skia:1888
TBR=robertphillips@google.com

Review URL: https://codereview.chromium.org/107843003

git-svn-id: http://skia.googlecode.com/svn/trunk@12582 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-09 20:41:00 +00:00
jvanverth@google.com
ed41106ffb Nobody knows the rebaselines I've seen...
git-svn-id: http://skia.googlecode.com/svn/trunk@12535 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-06 17:59:33 +00:00
epoger@google.com
e605b8383a commit remaining pdf-poppler GM results as unreviewed-by-humans
BUG=skia:1884
TBR=vandebo

Review URL: https://codereview.chromium.org/103033004

git-svn-id: http://skia.googlecode.com/svn/trunk@12530 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-06 17:03:25 +00:00
epoger@google.com
990962bde8 pdf-poppler GM results: updated more still-unreviewed expectations
(The prior revision of these expectations were unreviewed-by-humans anyway)
BUG=skia:1578,skia:1759
TBR=vandebo

Review URL: https://codereview.chromium.org/93883003

git-svn-id: http://skia.googlecode.com/svn/trunk@12529 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-06 16:35:26 +00:00
jvanverth@google.com
650660212d Really truly final (?) rebaseline for https://codereview.chromium.org/102683002/
git-svn-id: http://skia.googlecode.com/svn/trunk@12526 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-06 15:23:15 +00:00
epoger@google.com
c94a9911b1 Update not-reviewed-by-human poppler baselines
BUG=skia:1657,skia:1578
TBR=vandebo

These were already annotated as belonging to
https://code.google.com/p/skia/issues/detail?id=1578 ('commit GM actuals 
as expectations for all tests, marking them as unreviewed'),
which means they had not been visually reviewed in the first place.
  
So we have no reason to believe their current results are incorrect
(for all we know, they were wrong before)

For these and all other expectations with the bug1578 annotation, we should
figure out a way to validate them.  But that's for another day...

Review URL: https://codereview.chromium.org/107293002

git-svn-id: http://skia.googlecode.com/svn/trunk@12521 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-05 22:07:08 +00:00
epoger@google.com
7787f2128d expectations/gm/ignored-tests.txt: add links to tracking bugs
(SkipBuildbotRuns)

Review URL: https://codereview.chromium.org/106643003

git-svn-id: http://skia.googlecode.com/svn/trunk@12516 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-05 18:45:18 +00:00