jvanverth
876f48b6cd
Adjust tolerance to fix GPU hairline curve issues
...
BUG=chromium:472847
Review URL: https://codereview.chromium.org/1126793003
2015-05-05 08:01:51 -07:00
halcanary
72266fd1fe
SkPDF: clean up uses of deprecated calls in SkDocument_PDF
...
BUG=skia:3585
Review URL: https://codereview.chromium.org/1107913002
2015-05-05 08:00:24 -07:00
kkinnunen
261694c98a
Avoid using SkPathEffect::DashInfo in GrStrokeInfo
...
Avoid using SkPathEffect::DashInfo for storing the phase
in GrStrokeInfo. Instead, just use normal instance variables.
Fixes the copy constructor pointing the DashInfo interval pointer
to the wrong interval data.
Also fixes GrStrokeInfo::setDashInfo(const SkPathEffect::DashInfo&)
by updating the fDashType correctly.
Makes it simpler to write code such as the operator== in the future.
Review URL: https://codereview.chromium.org/1110093002
2015-05-05 08:00:10 -07:00
reed
67383fcfc1
remove dead code for SK_SUPPORT_LEGACY_RADIAL_GRADIENT_SQRT
...
BUG=skia:
TBR=
Review URL: https://codereview.chromium.org/1122933002
2015-05-05 07:55:19 -07:00
stephana
deee2980f4
cleanup
...
BUG=skia:
Review URL: https://codereview.chromium.org/1085583006
2015-05-05 07:55:06 -07:00
reed
7d3bdc3aa5
remove dead SK_SUPPORT_LEGACY_CUBIC_CHOPPER code
...
BUG=skia:
TBR=
Review URL: https://codereview.chromium.org/1116263005
2015-05-05 07:49:56 -07:00
bsalomon
b5238a7571
Start on simplifying generateGeometry() overrides
...
Committed: https://skia.googlesource.com/skia/+/f28381c6866cad92af8ebe5b9d2db074613b1963
Review URL: https://codereview.chromium.org/1122673002
2015-05-05 07:49:49 -07:00
reed
119468b71f
Revert of Make drawImage a virtual on SkDevice (patchset #3 id:40001 of https://codereview.chromium.org/11188 … (patchset #2 id:20001 of https://codereview.chromium.org/1122813002/ )
...
Reason for revert:
did not update DeferredCanvas
Original issue's description:
> Make drawImage a virtual on SkDevice (patchset #3 id:40001 of https://codereview.chromium.org/1118823004/ )"
>
> Fixed serialization from prev CL
>
> This reverts commit 973d1f1f60
.
>
> BUG=skia:3803
> TBR=
>
> Committed: https://skia.googlesource.com/skia/+/5392785080001fe737fac9e5801fc2127a78d4fb
TBR=
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:3803
Review URL: https://codereview.chromium.org/1123743006
2015-05-05 05:42:02 -07:00
egdaniel
99bc9fdfb5
Remove canTweakAlphaForCoverage from XP's since batch reads flag.
...
BUG=skia:
Review URL: https://codereview.chromium.org/1127693002
2015-05-04 12:58:16 -07:00
bungeman
64fb51d36d
Fix typeface ids on Mac.
...
The current typeface ids with CoreText rely on ATS (which causes
memory use issues) or font data (which is unreliable, and will not
work with axes and synthetics). This changes the code so that stream
fonts never end up in the cache and always get a unique id, and
system fonts will be given an id as they are used.
Review URL: https://codereview.chromium.org/1125763002
2015-05-04 12:03:51 -07:00
bsalomon
07ab9f3bed
Don't attempt to draw path if dashing or stroking fails
...
TBR=egdaniel@google.com
Committed: https://skia.googlesource.com/skia/+/39202f12d37b6ef69ffaddcaa8cc92c621fcda41
Review URL: https://codereview.chromium.org/1119393002
2015-05-04 11:41:57 -07:00
bsalomon
8415abe44c
Revert of Start on simplifying generateGeometry() overrides (patchset #10 id:160001 of https://codereview.chromium.org/1122673002/ )
...
Reason for revert:
Breaking bots
Original issue's description:
> Start on simplifying generateGeometry() overrides
>
> Committed: https://skia.googlesource.com/skia/+/f28381c6866cad92af8ebe5b9d2db074613b1963
TBR=joshualitt@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/1124633003
2015-05-04 11:41:42 -07:00
bsalomon
f28381c686
Start on simplifying generateGeometry() overrides
...
Review URL: https://codereview.chromium.org/1122673002
2015-05-04 11:27:45 -07:00
bsalomon
b327c3a84a
Revert of Don't attempt to draw path if dashing or stroking fails (patchset #1 id:1 of https://codereview.chromium.org/1119393002/ )
...
Reason for revert:
Doesn't draw
Original issue's description:
> Don't attempt to draw path if dashing or stroking fails
>
>
> TBR=egdaniel@google.com
>
> Committed: https://skia.googlesource.com/skia/+/39202f12d37b6ef69ffaddcaa8cc92c621fcda41
TBR=egdaniel@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/1119423002
2015-05-04 11:21:34 -07:00
mtklein
19e259b1ee
ignore_result()
...
BUG=skia:3801
Review URL: https://codereview.chromium.org/1127603003
2015-05-04 10:54:48 -07:00
reed
5392785080
Make drawImage a virtual on SkDevice (patchset #3 id:40001 of https://codereview.chromium.org/1118823004/ )"
...
Fixed serialization from prev CL
This reverts commit 973d1f1f60
.
BUG=skia:3803
TBR=
Review URL: https://codereview.chromium.org/1122813002
2015-05-04 10:49:41 -07:00
robertphillips
4e11c0b54d
Get debugger compiling again
...
Review URL: https://codereview.chromium.org/1125543003
2015-05-04 10:42:05 -07:00
joshualitt
0911430dfb
Move state management to GrInOrderDrawBuffer
...
BUG=skia:
Committed: https://skia.googlesource.com/skia/+/5d6bb6f795143ca360b868560b52165de51fa269
Review URL: https://codereview.chromium.org/1120143002
2015-05-04 10:41:57 -07:00
bsalomon
39202f12d3
Don't attempt to draw path if dashing or stroking fails
...
TBR=egdaniel@google.com
Review URL: https://codereview.chromium.org/1119393002
2015-05-04 10:36:53 -07:00
bsalomon
ed0bcad9c8
Move instanced index buffer creation to flush time
...
Committed: https://skia.googlesource.com/skia/+/ab622c7b8cc8c39f0a594e4392b9e31b7e1ddb26
Review URL: https://codereview.chromium.org/1116943004
2015-05-04 10:36:43 -07:00
bsalomon
d8ed1b64a6
Revert of Move instanced index buffer creation to flush time (patchset #6 id:100001 of https://codereview.chromium.org/1116943004/ )
...
Reason for revert:
messed up caching, recreating index buffers all the time.
Original issue's description:
> Move instanced index buffer creation to flush time
>
> Committed: https://skia.googlesource.com/skia/+/ab622c7b8cc8c39f0a594e4392b9e31b7e1ddb26
TBR=joshualitt@google.com ,robertphillips@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/1126613003
2015-05-04 10:09:24 -07:00
reed
973d1f1f60
Revert of make drawImage a virtual on SkDevice (patchset #3 id:40001 of https://codereview.chromium.org/1118823004/ )
...
Reason for revert:
need to make serialization work for pictures, now that images are "real"
Original issue's description:
> make drawImage a virtual on SkDevice
>
> default impl will turn the Image into a (raster) bitmap and call drawBitmap.
>
> BUG=skia:3803
>
> Committed: https://skia.googlesource.com/skia/+/f603fb3d0e5fa57c3f228d66945bef198b001135
TBR=bsalomon@google.com ,robertphillips@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:3803
Review URL: https://codereview.chromium.org/1122803002
2015-05-04 09:00:46 -07:00
reed
71a6cbfc58
remove redundant/deprecated TwoPointRadial gradiet -- use TwoPointConical
...
This CL derived from https://codereview.chromium.org/1114243005/
BUG=skia:
Review URL: https://codereview.chromium.org/1117423003
2015-05-04 08:32:51 -07:00
reed
f603fb3d0e
make drawImage a virtual on SkDevice
...
default impl will turn the Image into a (raster) bitmap and call drawBitmap.
BUG=skia:3803
Review URL: https://codereview.chromium.org/1118823004
2015-05-04 08:32:02 -07:00
bsalomon
ab622c7b8c
Move instanced index buffer creation to flush time
...
Review URL: https://codereview.chromium.org/1116943004
2015-05-04 08:09:30 -07:00
borenet
f15132fdcf
Support SKIA_OUT on Mac and ChromeOS
...
BUG=skia:3774
Review URL: https://codereview.chromium.org/1122593003
2015-05-04 08:04:28 -07:00
joshualitt
edae3096af
Revert of Move state management to GrInOrderDrawBuffer (patchset #4 id:60001 of https://codereview.chromium.org/1120143002/ )
...
Reason for revert:
Breaks windows
Original issue's description:
> Move state management to GrInOrderDrawBuffer
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/5d6bb6f795143ca360b868560b52165de51fa269
TBR=bsalomon@google.com ,robertphillips@google.com,joshualitt@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/1119353002
2015-05-04 07:51:09 -07:00
joshualitt
5d6bb6f795
Move state management to GrInOrderDrawBuffer
...
BUG=skia:
Review URL: https://codereview.chromium.org/1120143002
2015-05-04 07:41:40 -07:00
tfarina
8566539f98
Update src/svg to follow C++11 style rule for {virtual,override}.
...
The Google style guide states that only one of {virtual,override,final}
should be used for each declaration, since override implies virtual
and final implies both virtual and override.
The entries were found using the following command line:
$ find src/ -iname "*.h" -o -iname "*.cpp" | xargs pcregrep -M
"[^\n/]+virtual\ [^;{]+\ [a-zA-Z0-9_]+\([^;{]+\ override[ \n]*[;{]"
The regex was a courtesy of nick@chromium.org
BUG=None
R=mtklein@google.com
Review URL: https://codereview.chromium.org/1123573004
2015-05-04 06:40:31 -07:00
gen.kim
b9ed884578
SkPictureShader: scale down if width or height is larger than maxTextureSize
...
Grdient renders black because of failure onCreateTexture
if one of width or height is larger than maxTextureSize
with --force-gpu-rasterization.
BUG=chromium:473166
Review URL: https://codereview.chromium.org/1101513004
2015-05-03 22:36:30 -07:00
skia.buildbots
05f7d5cbd8
Update SKP version
...
Automatic commit by the RecreateSKPs bot.
TBR=
Review URL: https://codereview.chromium.org/1124513002
2015-05-03 01:03:55 -07:00
reed
34fdcae28e
remove unneeded SK_SUPPORT_LEGACY_IMAGEFILTER_TO_COLORFILTER flag
...
BUG=skia:
TBR=
Review URL: https://codereview.chromium.org/1120033003
2015-05-02 08:00:03 -07:00
joshualitt
40ded32418
Add hairlines batch unit test
...
BUG=skia:
Review URL: https://codereview.chromium.org/1119563002
2015-05-02 07:07:17 -07:00
joshualitt
4af6580b44
Fix for valgrind
...
TBR=bsalomon@google.com
BUG=skia:
Review URL: https://codereview.chromium.org/1127453002
2015-05-02 06:58:10 -07:00
joshualitt
99c7c07e0f
Move bounds to GrBatch
...
BUG=skia:
Review URL: https://codereview.chromium.org/1121463002
2015-05-01 13:43:30 -07:00
reed
a499f905e9
clean up pre-storage in canvas
...
BUG=skia:
TBR=
Review URL: https://codereview.chromium.org/1117213003
2015-05-01 09:34:31 -07:00
joshualitt
3dc2ccae6c
Simple CL to add a joinWithPossiblyEmptyArg to SkRect
...
BUG=skia:
Review URL: https://codereview.chromium.org/1118293002
2015-05-01 08:51:48 -07:00
halcanary
f7a169e225
SkPDF: clean up uses of deprecated calls in tests
...
BUG=skia:3585
Review URL: https://codereview.chromium.org/1106163002
2015-05-01 07:35:45 -07:00
halcanary
0b9d4118ba
SkTime: return timezone information; format in ISO-8601
...
Motivation: PDF/A metadata will need the creation date embedded in it.
Also, GetDateTime returns local time in Win32. This now behaves the
same as on Unix systems.
BUG=skia:3110
Review URL: https://codereview.chromium.org/1109593002
2015-05-01 07:06:23 -07:00
bsalomon
d309e7aa0e
This replaces the texture creation/caching functions on GrContext with a GrTextureProvider interface. The goal is to pass this narrowly focused object in places that currently take a GrContext but don't need and shouldn't use its other methods. It also has an extended private interface for interacting with non-texture resource types.
...
Review URL: https://codereview.chromium.org/1107973004
2015-04-30 14:18:54 -07:00
bungeman
3ffa126066
Move resource fonts to common location.
...
Move resource fonts to resources/fonts, add a destortable font for
testing, and clean up how the tests create fonts from resources.
R=joshualitt@google.com
Review URL: https://codereview.chromium.org/1120823002
2015-04-30 17:12:58 -04:00
joshualitt
a09c046146
Simple CL to Compute bounds in GrContext::drawVertices
...
BUG=skia:
Review URL: https://codereview.chromium.org/1117953003
2015-04-30 14:03:02 -07:00
joshualitt
3e708c53f7
Add batch unit tests for ovals
...
BUG=skia:
Review URL: https://codereview.chromium.org/1108403005
2015-04-30 13:49:27 -07:00
reed
1c2c441fed
add heuristic to pour small pictures into recordings, rather than ref'ing
...
BUG=skia:
Review URL: https://codereview.chromium.org/1118693003
2015-04-30 13:09:25 -07:00
mtklein
4f7ec55f71
Make SkAutoTDelete's operator T*() const, like all the others.
...
BUG=skia:
Review URL: https://codereview.chromium.org/1114043005
2015-04-30 12:06:19 -07:00
senorblanco
d298121f5d
Fix gpu memory accounting for auto-resolving MSAA.
...
BUG=skia:
Review URL: https://codereview.chromium.org/1115233002
2015-04-30 12:06:10 -07:00
skia.buildbots
af2bd098ee
Update SKP version
...
Automatic commit by the RecreateSKPs bot.
TBR=
NOTREECHECKS=true
Review URL: https://codereview.chromium.org/1118053002
2015-04-30 10:59:13 -07:00
mtklein
0690735478
Add missing include to SkPictureContentInfo.
...
BUG=skia:
Review URL: https://codereview.chromium.org/1113023003
2015-04-30 09:15:44 -07:00
joshualitt
a30009bec5
simple cleanup in GrTargetCommands
...
BUG=skia:
Review URL: https://codereview.chromium.org/1116923003
2015-04-30 09:05:54 -07:00
robertphillips
f83be823e4
Fix for texture allocation failure in 'preAbandonGpuContext' mode
...
Review URL: https://codereview.chromium.org/1118723003
2015-04-30 08:55:06 -07:00