Commit Graph

512 Commits

Author SHA1 Message Date
Ben Wagner
5eaa297267 Revert "Temporarily add Ubuntu IntelHD4400 jobs."
This reverts commit 373588426b.

Reason for revert: Have enough digests on Gold now.

Original change's description:
> Temporarily add Ubuntu IntelHD4400 jobs.
> 
> I want to compare this with the IntelBayTrail and if the results are
> similar, replace those bots.
> 
> No-Try: true
> Change-Id: Ib5476fe91dc446182cd1b37e93fe17962dcf961a
> Reviewed-on: https://skia-review.googlesource.com/76900
> Reviewed-by: Kevin Lubick <kjlubick@google.com>
> Commit-Queue: Ben Wagner <benjaminwagner@google.com>

TBR=benjaminwagner@google.com,kjlubick@google.com

Change-Id: Ica07d1ee635e59e3d3da51ee73591ffe08310e34
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/77860
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
2017-11-29 21:11:06 +00:00
Brian Salomon
7072e226ab Ignore deserialized path convexity and first direction.
Change-Id: Ib7bfff6225774b83d9b6e9c5baae254aab17353b
Reviewed-on: https://skia-review.googlesource.com/77680
Commit-Queue: Brian Salomon <bsalomon@google.com>
Reviewed-by: Robert Phillips <robertphillips@google.com>
2017-11-29 20:38:56 +00:00
Eric Boren
0425febe61 Update CT bots to Debian-9.2
This has the side effect of using the bots in the new GCE project as
well.

Bug: skia:7278
Change-Id: Ie14c93d6e3d12ccbfb679089bc50bca482fbf605
Reviewed-on: https://skia-review.googlesource.com/76261
Commit-Queue: Eric Boren <borenet@google.com>
Reviewed-by: Ravi Mistry <rmistry@google.com>
2017-11-29 18:45:05 +00:00
Eric Boren
9a9e38753a [infra] Provide Buildbucket Build ID in dm.json
Bug: skia:
Change-Id: Iefef7d617e58de2b3be2e27aac075f822641e4ce
Reviewed-on: https://skia-review.googlesource.com/77641
Reviewed-by: Stephan Altmueller <stephana@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
2017-11-29 18:38:35 +00:00
Ben Wagner
3f67914c01 Upgrade Macs to 10.13.1.
Bug: skia:7203
Change-Id: I741d15eabe502fd4c130e8ab3c3cfb92e3794e43
NoTry: true
Reviewed-on: https://skia-review.googlesource.com/68080
Reviewed-by: Stephan Altmueller <stephana@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2017-11-29 17:46:35 +00:00
Ben Wagner
373588426b Temporarily add Ubuntu IntelHD4400 jobs.
I want to compare this with the IntelBayTrail and if the results are
similar, replace those bots.

No-Try: true
Change-Id: Ib5476fe91dc446182cd1b37e93fe17962dcf961a
Reviewed-on: https://skia-review.googlesource.com/76900
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2017-11-29 16:23:55 +00:00
Jim Van Verth
443a913b8f Add create_bundle support for GN
Docs-Preview: https://skia.org/?cl=75383
Bug: skia:7339
Change-Id: I985734e8b7b5af21a82cb8ee59acbfb5ff1d3ff7
Reviewed-on: https://skia-review.googlesource.com/75383
Commit-Queue: Jim Van Verth <jvanverth@google.com>
Reviewed-by: Mike Klein <mtklein@chromium.org>
2017-11-28 15:29:07 +00:00
Ben Wagner
9f553932a4 Switch Coverage GPU bot to Golo.
No-Try: true
Change-Id: I0b9f6ef3651e5309af316d7ea7e170b48f54cdeb
Reviewed-on: https://skia-review.googlesource.com/76620
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2017-11-28 14:39:57 +00:00
Kevin Lubick
082f00a60e Don't scale CPU for internal bots
For internal hardware, it tends not to work - they work at one
clock speed, despite advertising others.

Bug: skia:
NOTRY=true
Change-Id: I10bf0fc1ab4d60bfbc2eefcef5b42ceab9e3f435
Reviewed-on: https://skia-review.googlesource.com/76720
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Kevin Lubick <kjlubick@google.com>
2017-11-28 13:37:17 +00:00
Brian Salomon
cf7e1d06bc Make EGL test context access GL via GrGLInterface
Bug: skia:7334
Change-Id: I5153ef83ae350648a15d6dc427b03d464258608b
Reviewed-on: https://skia-review.googlesource.com/75980
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
2017-11-27 16:50:26 +00:00
Ben Wagner
2040ed2bd9 Rename AMDHD7770 to RadeonHD7770.
Also drive-by cleanup of "Win8-MSVC-ShuttleB", none of which currently
exist.

No-Try: true
Change-Id: Ide28481939b7ec2a0733ab07673379c951123f5d
Reviewed-on: https://skia-review.googlesource.com/75361
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2017-11-24 23:13:22 +00:00
Brian Osman
e1e926a79c Remove obsolete iOSShell references from infra scripts
Bug: skia:
Change-Id: I36cb94877d513fc81c211b0e58b5c4be0451ac91
Reviewed-on: https://skia-review.googlesource.com/74601
Commit-Queue: Brian Osman <brianosman@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2017-11-22 16:06:05 +00:00
Brian Osman
fe546d09f8 VisualBench is not a thing anymore
Bug: skia:
Change-Id: I391cbc6cb2bf2ae88af0612964f4265788c8e771
Reviewed-on: https://skia-review.googlesource.com/74600
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2017-11-22 16:00:54 +00:00
Kevin Lubick
3ad5e61d80 Fix scaling on Nexus 7 bots
Bug: skia:
NOTRY=true
Change-Id: I1a1755dd03f2e6ebd8d9b2c9235cca8eb34f04ad
Reviewed-on: https://skia-review.googlesource.com/75280
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
2017-11-22 15:34:34 +00:00
Kevin Lubick
d1bbd5f777 Make CPU scaling code cleaner
This also makes *sure* the CPU frequency we set the
device to actually "takes".  Along the way, I learned
if scaling_max_freq is < the frequency we set, the
scaling_max_freq will be used instead, which was
happening to the PixelCs and AndroidOnes.

As a result, this may make those two Test- configs faster.

Bug: skia:
Change-Id: I10c98d37e296a19e1cf67bfe7269bb59cdd912d5
Reviewed-on: https://skia-review.googlesource.com/74360
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2017-11-21 22:38:20 +00:00
Kevin Lubick
cac3819901 Remove Nexus 6ps
These will be replaced by the Nexus 5x.

Bug: skia:7309
No-Try: true
Change-Id: I2a56a494203f2af41f16dcfd55ebe1ca28e9e939
Reviewed-on: https://skia-review.googlesource.com/73881
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
2017-11-21 13:41:29 +00:00
Greg Daniel
0eef674a5e Add gm to win vulkan intell blacklist
Bug: skia:6398
Change-Id: Ic04fa93dfe59c3c2b9322ffbe24e4791da9056ee
Reviewed-on: https://skia-review.googlesource.com/73802
Reviewed-by: Herb Derby <herb@google.com>
Commit-Queue: Greg Daniel <egdaniel@google.com>
2017-11-20 21:28:18 +00:00
Kevin Lubick
bca95a5ac5 Put CPU frequency scaling in recipes
Bug: skia:
Change-Id: I994f67c3043306d7fa612feb03f8fbe8d7bf4c91
Reviewed-on: https://skia-review.googlesource.com/73760
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2017-11-20 21:14:18 +00:00
Ben Wagner
32eb5ba7af Add bug number to comment.
No-Try: true
Change-Id: I9fe2b133264eb74b066364d5a490aae2de232bd3
Reviewed-on: https://skia-review.googlesource.com/73820
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2017-11-20 19:28:18 +00:00
Ben Wagner
5ff3ee316a Expand Windows GPU test configs.
No-Try: true
Change-Id: I2511801c746d3e434cd5eb7cc553bdc7b35fcf74
Reviewed-on: https://skia-review.googlesource.com/72680
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2017-11-20 16:02:48 +00:00
Ben Wagner
b842703085 Add Linux IntelHD405 Vulkan jobs.
No-Try: true
Change-Id: Id2631fc8df97b2a76775b01db212085d94c82906
Reviewed-on: https://skia-review.googlesource.com/72902
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2017-11-20 15:23:48 +00:00
Ben Wagner
fd66b5f82b Remove/move remaining Win2k8 GCE jobs.
Bug: skia:7305
Change-Id: Ifb270cba27daaef75d3930f990e19215a251ca28
Reviewed-on: https://skia-review.googlesource.com/71921
Reviewed-by: Mike Klein <mtklein@chromium.org>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2017-11-15 20:42:42 +00:00
Brian Salomon
559f556d9d Remove support for image load/store
This isn't used and has become a maintenance burden.

Change-Id: I5f3af8f91e5c4f073fe4ea30e0a7f1f61efeea47
Reviewed-on: https://skia-review.googlesource.com/70640
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
2017-11-15 20:06:12 +00:00
Ben Wagner
78935c2455 Move FxAA jobs to Win2016.
Bug: skia:7305
Change-Id: I3cfdb15c11d08143dce66046d66b0ce633277384
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/71862
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Yuqian Li <liyuqian@google.com>
2017-11-15 19:01:32 +00:00
Mike Klein
7893212d1f remove COLR from the big Vulkan blacklist
Change-Id: I15b76d5da795ee01eb7e403721beebf5f67d1bc4
Reviewed-on: https://skia-review.googlesource.com/71920
Reviewed-by: Mike Klein <mtklein@chromium.org>
Commit-Queue: Mike Klein <mtklein@chromium.org>
2017-11-15 18:42:27 +00:00
Greg Daniel
41886c8913 Add back more nexus player blacklists for Vulkan
Bug: skia:
Change-Id: I020fe58771d2bd6fd029b5b6a688f78530ef359c
Reviewed-on: https://skia-review.googlesource.com/71760
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Greg Daniel <egdaniel@google.com>
2017-11-15 14:58:56 +00:00
Ben Wagner
9592817042 Add Win2016 jobs.
Bug: skia:7197
No-Try: true
Change-Id: If2c8939739bc0583a08c0fcb400d28a90599f047
Reviewed-on: https://skia-review.googlesource.com/69401
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2017-11-14 18:25:04 +00:00
Mike Klein
0030c5ed3c generalize IntelIris540 Win/Vulkan blacklists
These won't have the "Win" or "Win10" bits in them anymore.

Change-Id: I2917c4227efcac7c2169a111fdaf62fcd83ea94a
Reviewed-on: https://skia-review.googlesource.com/70800
Reviewed-by: Brian Osman <brianosman@google.com>
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>
2017-11-13 19:06:21 +00:00
Mike Klein
0c5fdcb189 streamline GDI bots
- Replace build-time GDI support in all of Skia
   with run-time GDI support only in DM.

 - Make the GDI bots NativeFont bots paralelling
   the other NativeFonts bots.

Change-Id: I424b20f6983d8a8ba8574650efefea2b8776bbe2
Reviewed-on: https://skia-review.googlesource.com/70721
Reviewed-by: Ben Wagner <bungeman@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>
2017-11-13 18:47:11 +00:00
Greg Daniel
4c723832df Add tilesmode_npot to nexus player blacklist
readd [scaled_]tilemodes_npot to blacklist after it was removed last week
since it is failing randomly on bots.

Bug: skia:
Change-Id: Ieef97470c1ae4c960fa6efb7294e2ff203cc0bd6
Reviewed-on: https://skia-review.googlesource.com/70740
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Greg Daniel <egdaniel@google.com>
2017-11-13 18:20:20 +00:00
Brian Salomon
f44754a42b Drop support for OSMesa in test tools and remove build bot
Change-Id: Ic85ee05fe292a36a053ca7a20ccce24a4da4fae2
Reviewed-on: https://skia-review.googlesource.com/70026
Reviewed-by: Joe Gregorio <jcgregorio@google.com>
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
2017-11-13 16:20:10 +00:00
Mike Klein
c207da8d40 disable native fonts except on NativeFonts bots
a.k.a. GM fontpocalypse

Change-Id: If834940574adea29b48f35abec61f0a1c9bd59d3
Reviewed-on: https://skia-review.googlesource.com/69881
Reviewed-by: Mike Klein <mtklein@chromium.org>
Commit-Queue: Mike Klein <mtklein@chromium.org>
2017-11-12 13:50:26 +00:00
Ben Wagner
0ecc2b7e19 Unomit NexusPlayer tests after latest OS upgrade.
NoTry: true
Change-Id: I1212830dcd997901d13208c4729477fda600e4d7
Reviewed-on: https://skia-review.googlesource.com/67960
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2017-11-10 16:07:37 +00:00
Ravi Mistry
42ceab02f3 Switch CT_BENCH_10k_SKPs bot to use QuadroP400
Bug: skia:7272
Change-Id: I634f00c57b0c999a65d22a748b83a6ff5c35fd74
Reviewed-on: https://skia-review.googlesource.com/68940
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
2017-11-08 21:43:37 +00:00
Chris Dalton
035fcdfe57 Blacklist path_text_clipped on Chromecast
The test takes so long that the bot times out.

Bug: skia:
Change-Id: I77e7b192a1df1f422e61f09a931b7576fa55fbde
Reviewed-on: https://skia-review.googlesource.com/68440
Commit-Queue: Chris Dalton <csmartdalton@google.com>
Reviewed-by: Kevin Lubick <kjlubick@google.com>
2017-11-07 22:58:46 +00:00
Brian Osman
09eba3cad9 Test SkColorSpaceXformCanvas on GTX1070 bots
Bug: skia:
Change-Id: I48e37d1449c14298d03eea9c07a9aee1af78b47a
Reviewed-on: https://skia-review.googlesource.com/67809
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2017-11-07 14:37:18 +00:00
Brian Osman
f4a95bc22b Add a new testcase to test.py (GTX1070 Windows)
I'm going to be adding changes to bots matching this pattern, but want
the previous expectation files in first.

Bug: skia:
Change-Id: I61101a0ce7c66dde1e28dc307f8f7c5f66d6644e
Reviewed-on: https://skia-review.googlesource.com/67852
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2017-11-06 19:34:19 +00:00
Mike Klein
9a01a215bb add a few NativeFonts bots
These are no different from other bots yet, except that they only run
8888 GMs and unit tests.  They will in the future pass --nativeFonts
true, while other bots will pass --nativeFonts false, the effect of
which has not quite yet been pinned down.

Change-Id: I467852269856dda05330957bc357ef15a2c2a1eb
Reviewed-on: https://skia-review.googlesource.com/67769
Commit-Queue: Mike Klein <mtklein@chromium.org>
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Ben Wagner <bungeman@google.com>
2017-11-06 18:54:50 +00:00
Mike Klein
7a13d871ca pass -k 0 to ninja
This makes failing builds print all failures, not just the first.
Successful builds, the usual case, are unaffected.

Change-Id: I8dde21e913f6715e7760b298a87f51d1b40a8789
Reviewed-on: https://skia-review.googlesource.com/67803
Reviewed-by: Ben Wagner <bungeman@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>
2017-11-06 15:01:19 +00:00
Yuqian Li
ab246cb58d Add a GPU calmbench bot
Bug: skia:
Change-Id: I354c295ce04f5e478e88f724e0b17ce90496a4cc
Reviewed-on: https://skia-review.googlesource.com/65341
Commit-Queue: Yuqian Li <liyuqian@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2017-11-02 19:04:21 +00:00
Kevin Lubick
d7af1dbb64 Rename chromebook jobs to be more human friendly
Bug: skia:
NOTRY=true
Change-Id: I500eae85ec334dc7121266ebd2f41dc526ec4695
Reviewed-on: https://skia-review.googlesource.com/66880
Reviewed-by: Mike Klein <mtklein@chromium.org>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
2017-11-02 18:07:34 +00:00
Kevin Lubick
b718fbb7f4 Add Pixelbook to tree
Bug: skia:7249
NOTRY=true
Change-Id: I7ab6bc28d567ca5ae75df9c1e56b46c307032024
Reviewed-on: https://skia-review.googlesource.com/66143
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
2017-11-02 13:36:21 +00:00
Kevin Lubick
af79192aa3 Make CPU coverage bot a bit faster
Adding -O1 and reducing the shards to cut down on overhead
in post-production.  This seems to save us a few minutes
(e.g. ~26 -> ~23 minutes).

The optimized code has about 600 fewer reachable lines of code
(according to the Coverage measurement), which is acceptable
given our tests run on -O1 or better.

Experiments (in this review) show that O3 is faster than O1, 
but not significantly enough where we want to deviate from 
our normal Debug bots:
Control: 73 minutes
-O1: 59 minutes
-O2: 60 minutes
-O3: 50 minutes

Bug: skia:
NOTRY=true
Change-Id: I33344c1cd2408373004d010e36ce27d6aa03deb2
Reviewed-on: https://skia-review.googlesource.com/65503
Reviewed-by: Mike Klein <mtklein@chromium.org>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
2017-11-02 13:15:51 +00:00
Stan Iliev
9d8850b93c Revert "Add testcase for gbr config running on GTX1070 bots to test.py"
This reverts commit 85e98387a3.

Reason for revert: brakes build

Original change's description:
> Add testcase for gbr config running on GTX1070 bots to test.py
> 
> Bug: skia:
> Change-Id: I1f993100af712ce688dd21b5e510ffae4b587dce
> Reviewed-on: https://skia-review.googlesource.com/66155
> Commit-Queue: Brian Osman <brianosman@google.com>
> Commit-Queue: Mike Klein <mtklein@chromium.org>
> Reviewed-by: Mike Klein <mtklein@chromium.org>

TBR=mtklein@chromium.org,mtklein@google.com,brianosman@google.com

Change-Id: I3abebe01bb0285377321ed150cca0c76e8636a39
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: skia:
Reviewed-on: https://skia-review.googlesource.com/66422
Reviewed-by: Stan Iliev <stani@google.com>
Commit-Queue: Stan Iliev <stani@google.com>
2017-11-01 21:40:41 +00:00
Stan Iliev
596c45eaec Revert "Test SkColorSpaceXformCanvas on GTX1070 bots"
This reverts commit d4685403e2.

Reason for revert: Brakes build on Test-Win10-Clang-ZBOX-GPU-GTX1070-x86_64-Debug-All

Original change's description:
> Test SkColorSpaceXformCanvas on GTX1070 bots
> 
> Bug: skia:
> Change-Id: I98042ea6e7fe8b81e5f1cb38d8287a6cff394279
> Reviewed-on: https://skia-review.googlesource.com/66151
> Reviewed-by: Brian Salomon <bsalomon@google.com>
> Commit-Queue: Brian Osman <brianosman@google.com>

TBR=mtklein@google.com,bsalomon@google.com,brianosman@google.com

Change-Id: I5567441404554c33c35f5487ffdac199640ddb70
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: skia:
Reviewed-on: https://skia-review.googlesource.com/66462
Reviewed-by: Stan Iliev <stani@google.com>
Commit-Queue: Stan Iliev <stani@google.com>
2017-11-01 21:15:11 +00:00
recipe-roller
acf02025fc Roll recipe dependencies (nontrivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


Please review the expectation changes, and LGTM+CQ.


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
depot_tools:
  https://crrev.com/47b67c426b1d7120803e09f570e1cca312b34249 Reland "bot_update recipe: Upload source manifest" (hinoka@google.com)


R=kjlubick@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I22d3c671c6d0e654be19661c8e0d9795f920dc56
Reviewed-on: https://skia-review.googlesource.com/66060
Commit-Queue: Eric Boren <borenet@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
Reviewed-by: Ryan Tseng <hinoka@google.com>
2017-11-01 19:00:50 +00:00
Brian Osman
85e98387a3 Add testcase for gbr config running on GTX1070 bots to test.py
Bug: skia:
Change-Id: I1f993100af712ce688dd21b5e510ffae4b587dce
Reviewed-on: https://skia-review.googlesource.com/66155
Commit-Queue: Brian Osman <brianosman@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>
Reviewed-by: Mike Klein <mtklein@chromium.org>
2017-11-01 17:24:40 +00:00
Brian Osman
d4685403e2 Test SkColorSpaceXformCanvas on GTX1070 bots
Bug: skia:
Change-Id: I98042ea6e7fe8b81e5f1cb38d8287a6cff394279
Reviewed-on: https://skia-review.googlesource.com/66151
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2017-11-01 16:24:30 +00:00
Mike Klein
0b78a6912e another batch of lowp stages
The 4444 image in all_bitmap_configs now draws slightly different before
and after serialization.  (It's serialized as 8888.)  Still looks fine.

Change-Id: I1396cf1550b6769a1734ed25d59bd5b1866dfacd
Reviewed-on: https://skia-review.googlesource.com/65960
Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Mike Klein <mtklein@chromium.org>
2017-11-01 12:13:37 +00:00
Mike Klein
b7ea3da8cf Revert "gbr- has been brg- this whole time..."
This reverts commit 5b9a037bf4.

Reason for revert: 

I got confused in here somewhere and everything is drawing wrong.

Original change's description:
> gbr- has been brg- this whole time...
> 
> Rewrite things to make that a little clearer.
> 
> A red pixel ends up in channel 2, what would naively draw as blue
> without a rotation.  A green pixel ends up in channel 0, which would
> naively draw as red without rotation.  A blue pixel ends up in channel
> 1, which would naively draw as green without this rotation.
> 
> So this transformation is:
> 
>    r -> b
>    g -> r
>    b -> g
> 
> i.e. rgb_to_brg
> 
> Change-Id: I12331ff2622194e34a44f421f656fbe4db5d3dca
> Reviewed-on: https://skia-review.googlesource.com/65521
> Commit-Queue: Brian Osman <brianosman@google.com>
> Reviewed-by: Brian Osman <brianosman@google.com>

TBR=mtklein@chromium.org,brianosman@google.com

Change-Id: Ib29800b242bf736b20d61375d3c437c8f4ffdce0
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/65781
Reviewed-by: Mike Klein <mtklein@chromium.org>
Commit-Queue: Mike Klein <mtklein@chromium.org>
2017-10-31 17:42:16 +00:00