Commit Graph

40192 Commits

Author SHA1 Message Date
Mike Klein
a907dcbda7 remove mention of SkPaintDefaults_Flags
Change-Id: I0294bf2e294761bccf2e05dbd55addb003538cd1
Reviewed-on: https://skia-review.googlesource.com/c/193361
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
2019-02-26 22:54:24 +00:00
skia-autoroll
a3d31cc5b3 Roll third_party/externals/swiftshader 8adf1fcd08d0..54c4772e855c (1 commits)
https://swiftshader.googlesource.com/SwiftShader.git/+log/8adf1fcd08d0..54c4772e855c


git log 8adf1fcd08d0..54c4772e855c --date=short --no-merges --format='%ad %ae %s'
2019-02-26 chrisforbes@google.com Fix point rendering


Created with:
  gclient setdep -r third_party/externals/swiftshader@54c4772e855c

The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Test-Debian9-Clang-GCE-GPU-SwiftShader-x86_64-Debug-All-SwiftShader
TBR=scroggo@google.com

Change-Id: I487f164684ef3fa6b0562ab30d2743644bfe9ae2
Reviewed-on: https://skia-review.googlesource.com/c/195642
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-02-26 22:29:06 +00:00
skia-autoroll
4dbb96dfaa Roll third_party/externals/swiftshader fe3d4978886b..8adf1fcd08d0 (2 commits)
https://swiftshader.googlesource.com/SwiftShader.git/+log/fe3d4978886b..8adf1fcd08d0


git log fe3d4978886b..8adf1fcd08d0 --date=short --no-merges --format='%ad %ae %s'
2019-02-26 chrisforbes@google.com OpAccessChain: Remove pointer walking inside loop
2019-02-26 sugoi@google.com Replace uses of sw::Surface with vk::ImageView in the Renderer


Created with:
  gclient setdep -r third_party/externals/swiftshader@8adf1fcd08d0

The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Test-Debian9-Clang-GCE-GPU-SwiftShader-x86_64-Debug-All-SwiftShader
TBR=scroggo@google.com

Change-Id: I9304ecb15fcd8c97c90d879e89dc3bc1471c7ced
Reviewed-on: https://skia-review.googlesource.com/c/195500
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-02-26 21:33:23 +00:00
recipe-roller
c5519c3014 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/81bee2d517dae82881c1193fe9e4860fc7355f5b Implement api.buildbucket.build_url helper property (sergiyb@chromium.org)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I9ba414e3b1dea20280fe3a1d8252abfeeaecc099
Reviewed-on: https://skia-review.googlesource.com/c/195369
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
2019-02-26 20:38:45 +00:00
skia-autoroll
6099a28bc8 Roll third_party/externals/swiftshader 024f271ae0c7..fe3d4978886b (1 commits)
https://swiftshader.googlesource.com/SwiftShader.git/+log/024f271ae0c7..fe3d4978886b


git log 024f271ae0c7..fe3d4978886b --date=short --no-merges --format='%ad %ae %s'
2019-02-26 chrisforbes@google.com Fix various issues in vertex fetch setup


Created with:
  gclient setdep -r third_party/externals/swiftshader@fe3d4978886b

The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Test-Debian9-Clang-GCE-GPU-SwiftShader-x86_64-Debug-All-SwiftShader
TBR=scroggo@google.com

Change-Id: I05b74477a44612023a450836105876ff47b07e34
Reviewed-on: https://skia-review.googlesource.com/c/195460
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-02-26 20:34:37 +00:00
Brian Osman
e5d532edae Particles: remove non-stable random, add better enum reflection
The other generator was never used (or useful). String-based serialization
of enums is quite helpful, though.

Bug: skia:
Change-Id: Ic9d58f8d20cfe7aba47722bd74f1e6f8f0f219e5
Reviewed-on: https://skia-review.googlesource.com/c/195368
Commit-Queue: Brian Osman <brianosman@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
2019-02-26 20:29:56 +00:00
Florin Malita
f12d675179 [skottie] Shape blending mode support
Starting in v. 5.4.4, BodyMovin also supports/exports per-shape
blending modes.

Change-Id: I9827f1db11df207da62bfb0de724e62489ed9255
Reviewed-on: https://skia-review.googlesource.com/c/195365
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Florin Malita <fmalita@chromium.org>
2019-02-26 18:48:25 +00:00
Brian Salomon
65cb3749fe Remove legacy types/methods from SkDeferredDisplayList recorder.
Change-Id: I7a9810e14734262ee608444bd9308bebfb788a8d
Reviewed-on: https://skia-review.googlesource.com/c/195364
Commit-Queue: Brian Salomon <bsalomon@google.com>
Commit-Queue: Greg Daniel <egdaniel@google.com>
Reviewed-by: Greg Daniel <egdaniel@google.com>
Auto-Submit: Brian Salomon <bsalomon@google.com>
2019-02-26 18:40:55 +00:00
skia-autoroll
adfc6e40df Roll third_party/externals/angle2 0546b5380780..9f20dd777b50 (1 commits)
0546b53807..9f20dd777b


git log 0546b5380780..9f20dd777b50 --date=short --no-merges --format='%ad %ae %s'
2019-02-26 jmadill@chromium.org Add draw call perf test using 5 vertex arrays.


Created with:
  gclient setdep -r third_party/externals/angle2@9f20dd777b50

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE
TBR=scroggo@google.com

Change-Id: I0f59dbf0cfd11f714f9e067a9728177d0e3226fb
Reviewed-on: https://skia-review.googlesource.com/c/195401
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-02-26 17:54:25 +00:00
Greg Daniel
cb32415753 Add support for VK_IMAGE_LAYOUT_PRESENT_SRC_KHR in skia vulkan.
This change allows Skia to handle transfering from the present layout.
Skia currently never changes to the present layout, though we are looking
at adding support for this in a different CL.

With this change a client can wrap a an VkImage into an SkSurface still in
the queue present layout and Skia will handle the transation to color
attachment. If a client uses this functiality they most likely will want
to immediately call wait(GrBackendSemaphore) on the SkSurface so that Skia
waits on the VkSemaphore that came from a call to vulkan aquire image before
doing any work on the wrapped VkImage.

Bug: skia:
Change-Id: Ia9bd12ad4e6cd972daaa972cce8698d396c002fc
Reviewed-on: https://skia-review.googlesource.com/c/194424
Reviewed-by: Jim Van Verth <jvanverth@google.com>
Commit-Queue: Greg Daniel <egdaniel@google.com>
2019-02-26 17:37:25 +00:00
skia-autoroll
317e5e2b5b Roll third_party/externals/swiftshader 2ff3639d85d7..024f271ae0c7 (1 commits)
https://swiftshader.googlesource.com/SwiftShader.git/+log/2ff3639d85d7..024f271ae0c7


git log 2ff3639d85d7..024f271ae0c7 --date=short --no-merges --format='%ad %ae %s'
2019-02-26 capn@google.com Fix fuzzer build


Created with:
  gclient setdep -r third_party/externals/swiftshader@024f271ae0c7

The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Test-Debian9-Clang-GCE-GPU-SwiftShader-x86_64-Debug-All-SwiftShader
TBR=scroggo@google.com

Change-Id: I66528279958870b758897d6e4c5f6240831e0f76
Reviewed-on: https://skia-review.googlesource.com/c/195397
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-02-26 17:25:35 +00:00
Stan Iliev
cb58060404 Pass render target VkImage in GrVkDrawableInfo
Test: Ran CTS
Bug: b/115613038
Change-Id: I9493de41e0bfaa53436676c8eed2a4f178b6e51e
Reviewed-on: https://skia-review.googlesource.com/c/186400
Commit-Queue: Stan Iliev <stani@google.com>
Reviewed-by: Greg Daniel <egdaniel@google.com>
Reviewed-by: Jim Van Verth <jvanverth@google.com>
2019-02-26 17:07:30 +00:00
Herb Derby
eafd81bf0b Make ARGB fallback use common strike lookup
This is a larger CL. It makes fallback ARGB glyphs use
the same strike lookup, and it introduces the two cases
for fallback -- source and device. Source assumes that the
strike data will be transformed while rendering. Device
assumes that the data in the strike is already in device
space.

Change-Id: I5857bc17c6aaec21d48de9ac9102adafff9688fe
Reviewed-on: https://skia-review.googlesource.com/c/192120
Commit-Queue: Herb Derby <herb@google.com>
Reviewed-by: Ben Wagner <bungeman@google.com>
2019-02-26 17:05:04 +00:00
Hal Canary
ed53505b43 gn/core.gni: add headers
motivation: add more headers to gen/skia.h

Change-Id: I23064ca37afa66123ad00059c1382b906b44cd9e
Reviewed-on: https://skia-review.googlesource.com/c/195362
Reviewed-by: Ben Wagner <bungeman@google.com>
Commit-Queue: Ben Wagner <bungeman@google.com>
Commit-Queue: Hal Canary <halcanary@google.com>
Auto-Submit: Hal Canary <halcanary@google.com>
2019-02-26 16:39:05 +00:00
skia-autoroll
f6b62b756a Roll third_party/externals/swiftshader 9a16248dedf3..2ff3639d85d7 (1 commits)
https://swiftshader.googlesource.com/SwiftShader.git/+log/9a16248dedf3..2ff3639d85d7


git log 9a16248dedf3..2ff3639d85d7 --date=short --no-merges --format='%ad %ae %s'
2019-02-26 capn@google.com Work around x86-64 calling convention bug


Created with:
  gclient setdep -r third_party/externals/swiftshader@2ff3639d85d7

The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Test-Debian9-Clang-GCE-GPU-SwiftShader-x86_64-Debug-All-SwiftShader
TBR=scroggo@google.com

Change-Id: Idf774e6470d09e2fd1026cabe3f4c03ebccd85db
Reviewed-on: https://skia-review.googlesource.com/c/195390
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-02-26 16:32:05 +00:00
Brian Osman
0c48681e58 Few more particle features and some generalization work
Add particle "frame" enum, to allow effects relative to local, world,
or velocity. Remove the "orient along velocity" and replace with a much
more general orientation affector (angle curve + frame). Add an angular
velocity affector to mirror the behavior of the linear velocity affector.

Bug: skia:
Change-Id: Ibbaaeb352c9547d00d81c7916d00148dd65ed2b9
Reviewed-on: https://skia-review.googlesource.com/c/195361
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2019-02-26 15:56:24 +00:00
jongdeok.kim
804f17e35b [Viewer] Set the current slide first before attaching the fBackendType to fWindow.
If call attach() first, Viewer::onBackendCreated() calls Window::show().
When WM_PAINT occurs, Viewer::drawSlide() is called, where a crash occurs using an uninitialized fCurrentSlide.

Bug: skia:https://bugs.chromium.org/p/skia/issues/detail?id=8792
Change-Id: I22ba6479052cb66e08d8bc2a94539473e899b604
Reviewed-on: https://skia-review.googlesource.com/c/195240
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2019-02-26 14:21:55 +00:00
Kevin Lubick
8abc842945 [pathkit] fix perf
Docs-Preview: https://skia.org/?cl=195360
Bug: skia:
Change-Id: I4109810832b69a71960f6e619e32288ae8fa5023
Reviewed-on: https://skia-review.googlesource.com/c/195360
Reviewed-by: Kevin Lubick <kjlubick@google.com>
2019-02-26 13:17:22 +00:00
skia-autoroll
346e10e8ae Roll third_party/externals/swiftshader 377d493a0847..9a16248dedf3 (2 commits)
https://swiftshader.googlesource.com/SwiftShader.git/+log/377d493a0847..9a16248dedf3


git log 377d493a0847..9a16248dedf3 --date=short --no-merges --format='%ad %ae %s'
2019-02-26 headlessclayton@gmail.com SpirvShader: Decouple SPIR-V type attributes from object representation
2019-02-26 bclayton@google.com Strongly type object / type identifiers.


Created with:
  gclient setdep -r third_party/externals/swiftshader@9a16248dedf3

The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Test-Debian9-Clang-GCE-GPU-SwiftShader-x86_64-Debug-All-SwiftShader
TBR=scroggo@google.com

Change-Id: I49b39ede8704317b8feb19f1459876841a21d9a3
Reviewed-on: https://skia-review.googlesource.com/c/195290
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-02-26 07:32:24 +00:00
skia-autoroll
202077e281 Roll third_party/externals/swiftshader 53c8957c337d..377d493a0847 (1 commits)
https://swiftshader.googlesource.com/SwiftShader.git/+log/53c8957c337d..377d493a0847


git log 53c8957c337d..377d493a0847 --date=short --no-merges --format='%ad %ae %s'
2019-02-26 chrisforbes@google.com Remove VertexProcessor::multisampling state bit


Created with:
  gclient setdep -r third_party/externals/swiftshader@377d493a0847

The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Test-Debian9-Clang-GCE-GPU-SwiftShader-x86_64-Debug-All-SwiftShader
TBR=scroggo@google.com

Change-Id: I68bd67a1e8536d2ad201894c8fad7b14493f5434
Reviewed-on: https://skia-review.googlesource.com/c/195280
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-02-26 06:18:34 +00:00
skia-recreate-skps
fe23736201 Update go_deps asset
Automatic commit by the UpdateGoDEPS bot.

TBR=borenet@google.com

Change-Id: Ia1678080061a0441e6d13bcf326c473c2c7b48e3
Reviewed-on: https://skia-review.googlesource.com/c/195260
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
2019-02-26 05:47:24 +00:00
skia-autoroll
ac6d4c0c8e Roll third_party/externals/swiftshader 9b433073ba38..53c8957c337d (1 commits)
https://swiftshader.googlesource.com/SwiftShader.git/+log/9b433073ba38..53c8957c337d


git log 9b433073ba38..53c8957c337d --date=short --no-merges --format='%ad %ae %s'
2019-02-26 hliatis@google.com Wrong macro being #undef'd in VkGetProcAddress


Created with:
  gclient setdep -r third_party/externals/swiftshader@53c8957c337d

The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Test-Debian9-Clang-GCE-GPU-SwiftShader-x86_64-Debug-All-SwiftShader
TBR=scroggo@google.com

Change-Id: I5eba4af6575b71a3534209478977292022316d49
Reviewed-on: https://skia-review.googlesource.com/c/195231
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-02-26 04:57:54 +00:00
skia-autoroll
bcfbf6e94c Roll third_party/externals/angle2 c63d95525cde..0546b5380780 (4 commits)
c63d95525c..0546b53807


git log c63d95525cde..0546b5380780 --date=short --no-merges --format='%ad %ae %s'
2019-02-25 ynovikov@chromium.org Revert "Vulkan:Adding custom pool allocator"
2019-02-25 jmadill@chromium.org Add third_party/googletest to .gitignore.
2019-02-25 ynovikov@chromium.org Revert "Add system util to execute app and retrieve its output"
2019-02-25 tobine@google.com Vulkan:Adding custom pool allocator


Created with:
  gclient setdep -r third_party/externals/angle2@0546b5380780

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE
TBR=scroggo@google.com

Change-Id: I22712d1a932ed11c2f995a6881519cc417fdba27
Reviewed-on: https://skia-review.googlesource.com/c/195203
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-02-26 00:50:23 +00:00
Ben Wagner
843909c91a Add full definition of SkStreamAsset.
When moving from pointer to smart pointer, the implementation of
the pointee must be available (so the destructor which isn't used
can be visible).

Change-Id: I5489365868d4a3ba48cb4e8cd10e38b262dec2da
Reviewed-on: https://skia-review.googlesource.com/c/195129
Reviewed-by: Ben Wagner <bungeman@google.com>
Commit-Queue: Ben Wagner <bungeman@google.com>
2019-02-25 23:51:53 +00:00
Chris Dalton
b8af5ad73a sksl: Negate dFdy when the Y axis is flipped
Bug: skia:
Change-Id: Icbdaa6b1ebbe00168f57ebb888c2345d4f7a5e7d
Reviewed-on: https://skia-review.googlesource.com/c/195160
Commit-Queue: Chris Dalton <csmartdalton@google.com>
Reviewed-by: Ethan Nicholas <ethannicholas@google.com>
2019-02-25 23:32:23 +00:00
Chris Dalton
35a3abe765 Revert "Stack-allocate pipelines for GrMeshDrawOp"
This reverts commit dfe5000a5f.

Reason for revert: HWAA pipeline flag not getting set for dashing.

Original change's description:
> Stack-allocate pipelines for GrMeshDrawOp
> 
> Stack-allocates the pipelines in onExecute. This saves us from having
> to store the pipelines on the heap, as well as delaying the need to
> detach processors until onExecute. The delay is an improvement because
> it allows us to keep visiting proxies after onPrepare. (Previously,
> they were moved out of GrProcessorSet and into a pipeline during
> onPrepare, so visiting proxies was impossible after that point.)
> 
> Bug: skia:8731
> Change-Id: Idc05063fb0dfbfed42b434e429fa5a497097bdae
> Reviewed-on: https://skia-review.googlesource.com/c/193368
> Commit-Queue: Chris Dalton <csmartdalton@google.com>
> Reviewed-by: Robert Phillips <robertphillips@google.com>

TBR=robertphillips@google.com,csmartdalton@google.com

Change-Id: If706f19423310846de70288f393ac12f17ffeee5
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: skia:8731
Reviewed-on: https://skia-review.googlesource.com/c/195161
Reviewed-by: Chris Dalton <csmartdalton@google.com>
Commit-Queue: Chris Dalton <csmartdalton@google.com>
2019-02-25 23:11:47 +00:00
recipe-roller
16076702e3 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
depot_tools:
  https://crrev.com/2afcf22ad1841a0fd653a4fca72ab37eee4b4b02 Check for impossible date ranges (brucedawson@chromium.org)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I54a1e225f31fba73299a742d7ddc9d7557dcb3ee
Reviewed-on: https://skia-review.googlesource.com/c/195128
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
2019-02-25 22:40:53 +00:00
Ben Wagner
4212a7d948 SkTypeface::onOpenStream to return unique_ptr.
This moves the smart pointer use up one more level in preparation for
changing SkTypeface::openStream to return unique_ptr as well.

Change-Id: Ib8173d59e03de38b06f6e1b4e6776f1961055ae7
Reviewed-on: https://skia-review.googlesource.com/c/195121
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Ben Wagner <bungeman@google.com>
2019-02-25 22:30:04 +00:00
skia-autoroll
d98d815ad3 Roll third_party/externals/swiftshader 8c1e8f1fb771..9b433073ba38 (1 commits)
https://swiftshader.googlesource.com/SwiftShader.git/+log/8c1e8f1fb771..9b433073ba38


git log 8c1e8f1fb771..9b433073ba38 --date=short --no-merges --format='%ad %ae %s'
2019-02-25 hliatis@google.com Fix minor issue in vkCreateInstance extension loop


Created with:
  gclient setdep -r third_party/externals/swiftshader@9b433073ba38

The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Test-Debian9-Clang-GCE-GPU-SwiftShader-x86_64-Debug-All-SwiftShader
TBR=scroggo@google.com

Change-Id: Ib5b8b6c668eced759939705c670ee6a19ef9ec75
Reviewed-on: https://skia-review.googlesource.com/c/195142
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-02-25 22:02:03 +00:00
Kevin Lubick
2722083cbe [pathkit][canvaskit] roll versions
This removes the buggy .then() constructor, primarily.

Docs-Preview: https://skia.org/?cl=195126
Bug: skia:
Change-Id: Ie20512267ce3f822eb0d68e71fc07f3d3245c1e9
Reviewed-on: https://skia-review.googlesource.com/c/195126
Auto-Submit: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Joe Gregorio <jcgregorio@google.com>
Commit-Queue: Joe Gregorio <jcgregorio@google.com>
2019-02-25 21:53:53 +00:00
Ethan Nicholas
0b2c05470b fixed SPIR-V constant swizzling
Bug: skia:
Change-Id: I27ccb48351eab7faa46ba65d0c4ec26592da383d
Reviewed-on: https://skia-review.googlesource.com/c/195122
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
2019-02-25 21:06:53 +00:00
Chris Dalton
dfe5000a5f Stack-allocate pipelines for GrMeshDrawOp
Stack-allocates the pipelines in onExecute. This saves us from having
to store the pipelines on the heap, as well as delaying the need to
detach processors until onExecute. The delay is an improvement because
it allows us to keep visiting proxies after onPrepare. (Previously,
they were moved out of GrProcessorSet and into a pipeline during
onPrepare, so visiting proxies was impossible after that point.)

Bug: skia:8731
Change-Id: Idc05063fb0dfbfed42b434e429fa5a497097bdae
Reviewed-on: https://skia-review.googlesource.com/c/193368
Commit-Queue: Chris Dalton <csmartdalton@google.com>
Reviewed-by: Robert Phillips <robertphillips@google.com>
2019-02-25 21:02:23 +00:00
Herbert Derby
22a4af020d Calculate SDFT strike in common code
Change-Id: I525d2fa083a84e03029a2babdac2933e32077d56
Reviewed-on: https://skia-review.googlesource.com/c/195020
Commit-Queue: Herb Derby <herb@google.com>
Reviewed-by: Ben Wagner <bungeman@google.com>
2019-02-25 20:51:23 +00:00
recipe-roller
1ee390d567 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/03539506d1955ecf403784d0e900dd4d71011d97 scheduler: allow to opt-out of default tags in BuildbucketTrigger. (tandrii@chromium.org)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Id00d50d61c241fc215a605e73dbe1d50593711f8
Reviewed-on: https://skia-review.googlesource.com/c/195125
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
2019-02-25 20:24:23 +00:00
Brian Osman
14a67a3a71 Change particle affector to work on N particles
This should severely cut down on the virtual call overhead when running
affectors. It also switches to model of "for each affector, do each
particle", rather than "for each particle, do each affector". This is
going to be an I$ improvement, and (if we ever care), make it possible
to do wide-mode threading of the affectors on disjoint blocks of
particles.

Bug: skia:
Change-Id: Ia4e8e8d461dba4e303c45766ea2b4ece1bca9196
Reviewed-on: https://skia-review.googlesource.com/c/195123
Commit-Queue: Brian Osman <brianosman@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
2019-02-25 19:59:04 +00:00
Brian Osman
1b20cd8d30 Add "enabled" flag to affectors, fix curve interaction with stable random
Flag is helpful while editing things (and could be a useful property to
animate, as well). The curve change fixes a bug where the stable generator
gets out of phase if all segments of a curve don't use the same options.

Bug: skia:
Change-Id: Ie151e775aee22957e79fa88feaafad72b6c781ff
Reviewed-on: https://skia-review.googlesource.com/c/195120
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2019-02-25 19:39:23 +00:00
skia-autoroll
9dc060116d Roll third_party/externals/swiftshader 1776af77065f..8c1e8f1fb771 (1 commits)
https://swiftshader.googlesource.com/SwiftShader.git/+log/1776af77065f..8c1e8f1fb771


git log 1776af77065f..8c1e8f1fb771 --date=short --no-merges --format='%ad %ae %s'
2019-02-25 sugoi@google.com PipelineLayout implementation


Created with:
  gclient setdep -r third_party/externals/swiftshader@8c1e8f1fb771

The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Test-Debian9-Clang-GCE-GPU-SwiftShader-x86_64-Debug-All-SwiftShader
TBR=scroggo@google.com

Change-Id: I1240b054f254373ea1183893458853d9fab7b871
Reviewed-on: https://skia-review.googlesource.com/c/195064
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-02-25 19:18:23 +00:00
Leon Scroggins III
194580dc60 Reland "Treat kWEBP encode with quality=100 as lossless"
This reverts commit 22170b3178.

It was reverted due to the test breaking Google3. This includes a
workaround.

    Original change's description:
    > Treat kWEBP encode with quality=100 as lossless
    >
    > In SkEncodeImage and friends, treat quality of 100 as a lossless encode
    > when using kWEBP. This seems a good fit for the intent - which is
    > presumably to save the highest quality image. This also matches
    > Chromium's blink::ImageEncoder::ComputeWebpOptions, which treats a
    > quality of 1 (on a float scale from 0 to 1) as a lossless encode.
    >
    > FWIW, Chromium has had this behavior since
    > https://codereview.chromium.org/1937433002, in response to
    > crbug.com/523098. The goal is to "maintain sharpness to
    > match the JPEG encoder behavior (use WEBP lossless encoding)".
    >
    > Add a test to verify the new behavior. This requires making tests
    > depend on libwebp to use WebPGetFeatures, since the Skia API does not
    > provide a way to determine whether an encoded webp file was encoded
    > lossless-ly or lossily.
    >
    > Bug: skia:8586
    > Change-Id: Ie9e09c2f7414ab701d696c4ad9edf405868a716f
    > Reviewed-on: https://skia-review.googlesource.com/c/175823
    > Commit-Queue: Leon Scroggins <scroggo@google.com>
    > Reviewed-by: Derek Sollenberger <djsollen@google.com>
    > Reviewed-by: Mike Reed <reed@google.com>

TBR=reed@google.com, based on prior approval

Bug: skia:8586
Change-Id: I09c73f71996422f797fd9456fef5dfad9af36839
Reviewed-on: https://skia-review.googlesource.com/c/194194
Reviewed-by: Leon Scroggins <scroggo@google.com>
Commit-Queue: Leon Scroggins <scroggo@google.com>
Auto-Submit: Leon Scroggins <scroggo@google.com>
2019-02-25 18:42:22 +00:00
Leon Scroggins III
06eaef8589 Add a wuffs Release bot
Bug: skia:8235

This way we can track performance in perf.

Change-Id: I0e1b6101d5642d3f22080abc1077215ca43b3aae
Reviewed-on: https://skia-review.googlesource.com/c/194421
Commit-Queue: Leon Scroggins <scroggo@google.com>
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
2019-02-25 18:00:38 +00:00
skia-autoroll
49fe0e9cf8 Roll third_party/externals/swiftshader 5efe61188243..1776af77065f (1 commits)
https://swiftshader.googlesource.com/SwiftShader.git/+log/5efe61188243..1776af77065f


git log 5efe61188243..1776af77065f --date=short --no-merges --format='%ad %ae %s'
2019-02-25 chrisforbes@google.com Suppress warnings for more instructions that require no work


Created with:
  gclient setdep -r third_party/externals/swiftshader@1776af77065f

The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Test-Debian9-Clang-GCE-GPU-SwiftShader-x86_64-Debug-All-SwiftShader
TBR=scroggo@google.com

Change-Id: Ib79fd2fcd937469fbb149dba875f9220b7c55ae8
Reviewed-on: https://skia-review.googlesource.com/c/194991
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-02-25 17:57:38 +00:00
skia-autoroll
f6b0439fb6 Roll third_party/externals/swiftshader e2d8b1286ce3..5efe61188243 (1 commits)
https://swiftshader.googlesource.com/SwiftShader.git/+log/e2d8b1286ce3..5efe61188243


git log e2d8b1286ce3..5efe61188243 --date=short --no-merges --format='%ad %ae %s'
2019-02-25 sugoi@google.com Assert there are no unmatched eglBindTexImage/eglReleaseTexImage


Created with:
  gclient setdep -r third_party/externals/swiftshader@5efe61188243

The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Test-Debian9-Clang-GCE-GPU-SwiftShader-x86_64-Debug-All-SwiftShader
TBR=scroggo@google.com

Change-Id: I5bb95b44d1c1ffe3beffb7ac2dc4ac3a129da590
Reviewed-on: https://skia-review.googlesource.com/c/194984
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-02-25 17:03:56 +00:00
Ben Wagner
7465943b1e Remove fuzz samples.
We now have a real fuzzer, and these samples only run on local dev
machine anyway, so their current utility is quite low since they don't
demonstrate any specific behavior.

Bug: skia:8259
Change-Id: If44a0eaa161b1d7688dd3de6431414a84b7bd6c6
Reviewed-on: https://skia-review.googlesource.com/c/194862
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Commit-Queue: Ben Wagner <bungeman@google.com>
2019-02-25 16:55:26 +00:00
Ethan Nicholas
2f103f0d04 fixed SkSL float literals in Arabic locale
Bug: skia:
Change-Id: I52c9ec56be6afa44f6282ff40a152d56bdb5584a
Reviewed-on: https://skia-review.googlesource.com/c/194863
Auto-Submit: Ethan Nicholas <ethannicholas@google.com>
Commit-Queue: Greg Daniel <egdaniel@google.com>
Reviewed-by: Greg Daniel <egdaniel@google.com>
2019-02-25 16:44:56 +00:00
Ben Wagner
5f50b75023 Remove defunct SkJSCanvas
Added disabled in 8ea69838a4 and appears
to never have been used. This seems now very superseded by CanvasKit.

Change-Id: I0fd3a8b2dc3a7207b8fa6ae9205842e4f5df450e
Reviewed-on: https://skia-review.googlesource.com/c/194604
Auto-Submit: Ben Wagner <bungeman@google.com>
Commit-Queue: Ben Wagner <bungeman@google.com>
Reviewed-by: Mike Reed <reed@google.com>
2019-02-25 16:29:06 +00:00
Jim Van Verth
2a330e689b Check for zero offsets for PolyUtils
Bug: oss-fuzz:13202
Change-Id: Iee0ec8bdfe6345c91a584607cc499d69d227a919
Reviewed-on: https://skia-review.googlesource.com/c/194422
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Commit-Queue: Jim Van Verth <jvanverth@google.com>
2019-02-25 16:11:06 +00:00
Eric Boren
b8960d0535 [infra] Make the presubmit bot use recipes from CIPD
Bug: skia:
Change-Id: I28f118521fc4f1f27c2601d70e855fb7f5623ba2
Reviewed-on: https://skia-review.googlesource.com/c/194861
Reviewed-by: Ravi Mistry <rmistry@google.com>
Reviewed-by: Robbie Iannucci <iannucci@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
2019-02-25 16:04:59 +00:00
Florin Malita
bd64f18947 [skottie] Layer blend mode support
Introduce sksg::BlendModeEffect and use to wrap Skottie layers based on
their "bm" property.

Depending on the presence of non-trivial layer blend modes and the nature
of the destination buffer (fully transparent vs. unknown/pre-filled), we
may now need to render animation frames into a separate layer for correct
compositing.

Track the presence of non-trivial layer blend modes such that we only incur
this extra layer overhead when needed.  Also allow clients to pass a "drawing
to fully transparent buffer" hint such that we can avoid the extra layer even
when blend modes are present.

Change-Id: Iaf645878666da4349d0bef8890bbecad23a0aa9b
Reviewed-on: https://skia-review.googlesource.com/c/194840
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Florin Malita <fmalita@chromium.org>
2019-02-25 15:48:07 +00:00
Mike Reed
5532c2a34f fill the layer if there is a backdrop filter
Bug: skia:8783
Change-Id: I92448382117b1bd05a0ad5cf7ecd72181631389b
Reviewed-on: https://skia-review.googlesource.com/c/194601
Auto-Submit: Mike Reed <reed@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
Reviewed-by: Robert Phillips <robertphillips@google.com>
2019-02-25 15:32:36 +00:00
Nigel Tao
e3b205b120 Update Wuffs version
Bug: skia:8764
Bug: skia:8767
Bug: skia:8764

This pulls in the Wuffs bug fix:
ab7d6de318
"Let Wuffs compile with MSVC (Microsoft Visual C++)".

This also pulls in fixes for
https://github.com/google/wuffs/issues/20
"Check for "not enough pixel data" and return an Error or Warning"

Change-Id: Ie75e57504f1ec872418e8851e10de9159f714bc5
Reviewed-on: https://skia-review.googlesource.com/c/193200
Reviewed-by: Leon Scroggins <scroggo@google.com>
Commit-Queue: Leon Scroggins <scroggo@google.com>
2019-02-25 15:25:36 +00:00
skia-autoroll
507158f88d Roll third_party/externals/swiftshader b47c816ad7e6..e2d8b1286ce3 (1 commits)
https://swiftshader.googlesource.com/SwiftShader.git/+log/b47c816ad7e6..e2d8b1286ce3


git log b47c816ad7e6..e2d8b1286ce3 --date=short --no-merges --format='%ad %ae %s'
2019-02-25 bclayton@google.com Fix CMake build documentation


Created with:
  gclient setdep -r third_party/externals/swiftshader@e2d8b1286ce3

The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Test-Debian9-Clang-GCE-GPU-SwiftShader-x86_64-Debug-All-SwiftShader
TBR=scroggo@google.com

Change-Id: I8a7ec3b88174c0e62857268589e62b6eb8b3bfa5
Reviewed-on: https://skia-review.googlesource.com/c/194805
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-02-25 12:43:56 +00:00