commit-bot@chromium.org
89558c9dcb
Fix skpdiff segfault caused by NaN computation.
...
BUG=skia:2574
R=mtklein@google.com , rmistry@google.com
Author: djsollen@google.com
Review URL: https://codereview.chromium.org/296033004
git-svn-id: http://skia.googlecode.com/svn/trunk@14818 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-21 11:57:12 +00:00
commit-bot@chromium.org
3056bdd236
Since we're only using it on Linux now, just require poppler as a system dependency.
...
The Ubuntu package needed is libpoppler-cpp-dev.
iconv and fontconfig were only used as Poppler dependencies. bson_c is also unused.
BUG=skia:
R=reed@google.com , rmistry@google.com , borenet@google.com , halcanary@google.com , mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/294683003
git-svn-id: http://skia.googlecode.com/svn/trunk@14802 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-20 15:07:53 +00:00
commit-bot@chromium.org
7126fef7b6
Update valgrind suppression file
...
BUG=skia:
R=bsalomon@google.com
Author: egdaniel@google.com
Review URL: https://codereview.chromium.org/292453010
git-svn-id: http://skia.googlecode.com/svn/trunk@14791 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-19 21:06:01 +00:00
commit-bot@chromium.org
abeb9589ec
make render_pictures properly handle empty expectations file
...
note that this changes the parameters taken by ImageResultsAndExpectations::Parse()
BUG=skia:1942
R=scroggo@google.com
Author: epoger@google.com
Review URL: https://codereview.chromium.org/289063010
git-svn-id: http://skia.googlecode.com/svn/trunk@14779 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-19 15:25:10 +00:00
commit-bot@chromium.org
90a17674f1
make buildbot_globals.py read global_variables.json file from googlesource
...
BUG=skia:2564
NOTRY=True
R=borenet@google.com
Author: epoger@google.com
Review URL: https://codereview.chromium.org/291563008
git-svn-id: http://skia.googlecode.com/svn/trunk@14770 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-16 19:19:31 +00:00
commit-bot@chromium.org
b3b0cfc4d4
Add lua scripts to scrape dashing info
...
BUG=skia:
R=reed@google.com
Author: egdaniel@google.com
Review URL: https://codereview.chromium.org/288883003
git-svn-id: http://skia.googlecode.com/svn/trunk@14754 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-15 20:35:50 +00:00
commit-bot@chromium.org
85fd193223
Factor out DumpRecord method from dump_record tool for later use
...
R=mtklein@google.com
Author: halcanary@google.com
Review URL: https://codereview.chromium.org/282233003
git-svn-id: http://skia.googlecode.com/svn/trunk@14751 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-15 16:10:37 +00:00
commit-bot@chromium.org
3f04517721
render_pictures: add --mismatchPath flag
...
When set, it will only write out images that don't match expectations.
BUG=skia:1942
R=rmistry@google.com
Author: epoger@google.com
Review URL: https://codereview.chromium.org/283123002
git-svn-id: http://skia.googlecode.com/svn/trunk@14748 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-15 15:10:48 +00:00
commit-bot@chromium.org
76ac7f81d3
delete no-longer-used update-doxygen.sh
...
BUG=skia:2470
NOTRY=True
R=borenet@google.com
Author: epoger@google.com
Review URL: https://codereview.chromium.org/290033002
git-svn-id: http://skia.googlecode.com/svn/trunk@14747 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-15 14:41:00 +00:00
commit-bot@chromium.org
f364521e75
Fix goauth path
...
BUG=skia:2551
R=scroggo@google.com
Author: borenet@google.com
Review URL: https://codereview.chromium.org/288763002
git-svn-id: http://skia.googlecode.com/svn/trunk@14737 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-14 16:57:49 +00:00
commit-bot@chromium.org
0fd0d4c7fe
Add warning about GOPATH to bug_chomper/run_server.sh
...
BUG=skia:2551
R=scroggo@google.com
Author: borenet@google.com
Review URL: https://codereview.chromium.org/285763003
git-svn-id: http://skia.googlecode.com/svn/trunk@14732 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-14 15:42:14 +00:00
commit-bot@chromium.org
44d4210146
BugChomper: Get the oauth_client_secret from GS
...
BUG=skia:
NOTRY=true
(SkipBuildbotRuns)
R=jcgregorio@google.com
Author: borenet@google.com
Review URL: https://codereview.chromium.org/288593003
git-svn-id: http://skia.googlecode.com/svn/trunk@14718 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-13 19:18:55 +00:00
commit-bot@chromium.org
5132461627
BugChomper utility - rewrite in Go
...
BUG=skia:
R=jcgregorio@google.com
Author: borenet@google.com
Review URL: https://codereview.chromium.org/274693002
git-svn-id: http://skia.googlecode.com/svn/trunk@14715 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-13 18:03:45 +00:00
commit-bot@chromium.org
9d439a707e
Adds dashboard link for one-line plot on each alert item.
...
BUG=skia:2523
NOTRY=true
R=kelvinly@google.com
TBR=rmistry@google.com
Author: bensong@google.com
Review URL: https://codereview.chromium.org/280663002
git-svn-id: http://skia.googlecode.com/svn/trunk@14713 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-13 17:38:17 +00:00
commit-bot@chromium.org
e7851cd75d
Update TSAN suppressions.
...
BUG=skia:2459, skia:1792
R=bsalomon@google.com , mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/288533002
git-svn-id: http://skia.googlecode.com/svn/trunk@14711 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-13 14:47:21 +00:00
commit-bot@chromium.org
5654d177d5
comment-only fix to tools/update-doxygen.sh
...
(SkipBuildbotRuns)
NOTREECHECKS=True
NOTRY=True
R=rmistry@google.com
TBR=rmistry
Author: epoger@google.com
Review URL: https://codereview.chromium.org/280703002
git-svn-id: http://skia.googlecode.com/svn/trunk@14703 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-12 20:47:02 +00:00
commit-bot@chromium.org
205ce48c38
add --readJsonSummaryPath to render_pictures
...
BUG=skia:1942
R=borenet@google.com
Author: epoger@google.com
Review URL: https://codereview.chromium.org/273783004
git-svn-id: http://skia.googlecode.com/svn/trunk@14695 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-12 15:37:20 +00:00
commit-bot@chromium.org
8fe89d3124
Use a tilegrid for bench_playback.
...
Using --tile wasn't a fair comparison: SkPicture didn't get to optimize its
playback, but SkRecord did. Numbers here are starting to agree with what I saw
in telemetry: SkRecord with culling is on average at 0.8-0.9 of the speed of
SkPicture (10-30% slower) than SkPicture SkPicture with a tile grid, but some
in some cases it's down at 0.3, taking almost 4x as long to draw a 256x256 tile.
0.4x tabl_mercurynews.skp 0.109889 0.252483
0.5x tabl_cnet.skp 0.250367 0.527789
1.0x desk_mapsvg.skp 1.48698 1.49939
1.2x desk_yahoogames.skp 0.07745 0.065343
0.9x tabl_mlb.skp 0.294509 0.312505
0.8x tabl_hsfi.skp 0.250678 0.316337
0.6x tabl_worldjournal.skp 0.510204 0.828798
0.7x desk_facebook.skp 0.318981 0.483744
0.9x desk_googlehome.skp 0.06983 0.078964
0.9x desk_tigersvg.skp 0.019232 0.022611
1.0x desk_youtubetvvideo.skp 0.401614 0.401862
1.1x desk_amazon.skp 0.415552 0.362111
0.7x desk_yahooanswers.skp 0.237995 0.358659
0.7x desk_twitter.skp 0.323466 0.439772
1.2x desk_fontwipe.skp 0.121577 0.097845
1.1x desk_css3gradients.skp 0.395335 0.362087
0.9x desk_googlespreadsheet.skp 0.362056 0.406688
1.0x tabl_frantzen.skp 15.2475 14.8521
0.6x desk_forecastio.skp 0.154236 0.276881
0.7x desk_pinterest.skp 0.077433 0.11324
0.5x tabl_cuteoverload.skp 0.173014 0.361815
0.5x tabl_androidpolice.skp 0.225903 0.465608
0.6x tabl_vnexpress.skp 0.151075 0.241104
0.6x tabl_nytimes.skp 0.06515 0.117229
0.8x desk_ebay.skp 0.353437 0.422586
0.8x tabl_deviantart.skp 0.223103 0.295496
1.1x tabl_culturalsolutions.skp 0.551348 0.506104
0.9x mobi_wikipedia.skp 0.302603 0.337292
0.6x desk_linkedin.skp 0.165102 0.276149
0.6x tabl_digg.skp 0.159074 0.281529
1.2x desk_oldinboxapp.skp 0.019815 0.017146
1.0x tabl_nofolo.skp 5.18914 5.42784
0.6x desk_jsfiddlehumperclip.skp 0.076869 0.133665
1.0x desk_blogger.skp 0.206702 0.19688
0.8x desk_espn.skp 0.346386 0.451871
1.0x desk_samoasvg.skp 3.60037 3.43147
0.8x desk_booking.skp 0.338818 0.438267
1.3x desk_yahoosports.skp 0.603811 0.470052
0.6x tabl_engadget.skp 0.248995 0.404372
0.7x desk_wowwiki.skp 0.325801 0.479559
0.8x tabl_ukwsj.skp 0.326985 0.405971
0.9x tabl_gmail.skp 0.2604 0.276744
0.9x desk_googleplus.skp 8.08874 8.71105
1.1x tabl_slashdot.skp 0.559332 0.524313
0.9x desk_gmailthread.skp 0.671569 0.74134
0.8x desk_weather.skp 0.194162 0.247681
1.3x desk_rectangletransition.skp 0.218372 0.173685
0.6x tabl_gamedeksiam.skp 0.243374 0.4134
0.9x desk_jsfiddlebigcar.skp 0.162282 0.186035
0.3x desk_pokemonwiki.skp 0.202878 0.778934
0.7x tabl_googleblog.skp 0.141203 0.209971
0.8x desk_sfgate.skp 0.229078 0.275248
1.0x desk_chalkboard.skp 2.28916 2.20101
0.9x tabl_googlecalendar.skp 0.687155 0.75413
1.1x tabl_gspro.skp 0.186399 0.169522
0.5x desk_googlespreadsheetdashed.skp 0.512622 1.02815
0.6x desk_mobilenews.skp 0.183506 0.293929
0.8x tabl_techmeme.skp 0.193074 0.229106
1.2x desk_carsvg.skp 5.33047 4.34058
0.5x desk_youtube.skp 0.132663 0.248236
0.7x tabl_pravda.skp 0.21644 0.308788
1.1x desk_gws.skp 0.698107 0.625371
0.5x tabl_mozilla.skp 0.189638 0.386801
1.0x desk_baidu.skp 0.353438 0.355965
1.1x tabl_sahadan.skp 0.476226 0.416737
summary: ≥0.3x (A 0.9x, G 0.8x) ≤1.3x
Whole SKP playback speed is fine of course.
BUG=skia:2378
R=fmalita@chromium.org , mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/277653002
git-svn-id: http://skia.googlecode.com/svn/trunk@14673 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-09 15:00:10 +00:00
commit-bot@chromium.org
27f6b0d013
Add timing to dump_record.
...
Prints microsecond timing for each command in the left-hand column:
optimized flat/http___mobile_news_sandbox_google_com_news_pt0_scroll_layer_7.skp
4.0 1 Save
2075.0 2 DrawRect
104.0 3 BoundedDrawPosTextH
135.4 4 DrawRect
9.4 5 DrawRect
5.6 6 DrawRect
8.2 7 DrawRect
6.8 8 DrawRect
...
(I'm sure Rietveld will just mangle the crap out of that. It's helpfully right-aligned.)
To do this, I made Draw from SkRecordDraw Skia-public as SkRecords::Draw,
and time it command-by-command.
BUG=skia:2378
R=fmalita@chromium.org , mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/272723007
git-svn-id: http://skia.googlecode.com/svn/trunk@14672 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-09 14:59:29 +00:00
commit-bot@chromium.org
90c0fbd349
reland "extract some common code from PictureRenderer"
...
re-lands https://codereview.chromium.org/273703006/
NOTRY=True
R=bungeman@google.com , djsollen@google.com
Author: epoger@google.com
Review URL: https://codereview.chromium.org/278633002
git-svn-id: http://skia.googlecode.com/svn/trunk@14662 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-09 03:18:41 +00:00
commit-bot@chromium.org
de3ad9e220
Revert of extract some common code from PictureRenderer ( https://codereview.chromium.org/273703006/ )
...
Reason for revert:
breaking the android debug builds. It seems to be the result of android using shared libs and not lumping everything into one big static lib or executable. So we have more than one copy of SkString which is the root of the issue.
Original issue's description:
> extract some common code from PictureRenderer
>
> Committed: http://code.google.com/p/skia/source/detail?r=14638
R=borenet@google.com , epoger@google.com
TBR=borenet@google.com , epoger@google.com
NOTREECHECKS=true
NOTRY=true
Author: djsollen@google.com
Review URL: https://codereview.chromium.org/274463004
git-svn-id: http://skia.googlecode.com/svn/trunk@14649 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-08 16:23:56 +00:00
commit-bot@chromium.org
ee18f2a3c9
extract some common code from PictureRenderer
...
R=borenet@google.com
Author: epoger@google.com
Review URL: https://codereview.chromium.org/273703006
git-svn-id: http://skia.googlecode.com/svn/trunk@14638 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-08 14:48:44 +00:00
commit-bot@chromium.org
c71da1f6ed
Convert all SkRecordPattern matchers into SkRecord mutators.
...
- Allow any return type from SkRecord mutators and visitors;
- update existing calls to mutate and visit;
- convert match to operator() in SkRecordPattern;
- tidy up a few inelegant bits of old code in tests.
The net result is that the generated code is much clearer. All the mutate() calls
inline as you'd hope, and you can now actually follow along with the disassembly.
BUG=skia:2378
R=fmalita@chromium.org , bungeman@google.com , mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/273643007
git-svn-id: http://skia.googlecode.com/svn/trunk@14631 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-07 21:16:09 +00:00
commit-bot@chromium.org
2db7fe7d3b
When solving the cubic line intersection directly fails, use binary search as a fallback.
...
The cubic line intersection math empirically works 99.99% of the time (fails 3100 out of 1B random tests) but when it fails, an intersection may be missed altogether.
The binary search is may not find a solution if the cubic line failed to find any solutions at all, but so far that case hasn't arisen.
BUG=skia:2504
TBR=reed@google.com
Author: caryclark@google.com
Review URL: https://codereview.chromium.org/266063003
git-svn-id: http://skia.googlecode.com/svn/trunk@14614 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-07 15:31:40 +00:00
commit-bot@chromium.org
bf07d2e17d
Add dump_record to make inspecting before/after SkRecordOptimize easy.
...
E.g.
dump_record -r http___groupcloned_com_test_plain_list_animation_simple_html_layer_109.skp
0 Save
1 DrawRect
2 DrawRect
3 DrawRect
4 DrawRect
5 Save
6 ClipRect
7 Restore
8 Save
9 ClipRect
10 Restore
11 Restore
dump_record -O -r http___groupcloned_com_test_plain_list_animation_simple_html_layer_109.skp
0 Save
1 DrawRect
2 DrawRect
3 DrawRect
4 DrawRect
5 NoOp
6 NoOp
7 NoOp
8 NoOp
9 NoOp
10 NoOp
11 Restore
(Reitveld sadly eats my kickass indentation.)
BUG=skia:2378
Committed: http://code.google.com/p/skia/source/detail?r=14596
R=fmalita@chromium.org , mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/265983007
git-svn-id: http://skia.googlecode.com/svn/trunk@14600 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-06 20:38:24 +00:00
commit-bot@chromium.org
545a21a714
Add dump_record to make inspecting before/after SkRecordOptimize easy.
...
E.g.
dump_record -r http___groupcloned_com_test_plain_list_animation_simple_html_layer_109.skp
0 Save
1 DrawRect
2 DrawRect
3 DrawRect
4 DrawRect
5 Save
6 ClipRect
7 Restore
8 Save
9 ClipRect
10 Restore
11 Restore
dump_record -O -r http___groupcloned_com_test_plain_list_animation_simple_html_layer_109.skp
0 Save
1 DrawRect
2 DrawRect
3 DrawRect
4 DrawRect
5 NoOp
6 NoOp
7 NoOp
8 NoOp
9 NoOp
10 NoOp
11 Restore
(Reitveld sadly eats my kickass indentation.)
BUG=skia:2378
R=fmalita@chromium.org , mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/265983007
git-svn-id: http://skia.googlecode.com/svn/trunk@14596 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-06 19:45:18 +00:00
commit-bot@chromium.org
3df4e95402
Spelling fix, comments explaining script.
...
R=mtklein@google.com
Author: halcanary@google.com
Review URL: https://codereview.chromium.org/261913006
git-svn-id: http://skia.googlecode.com/svn/trunk@14565 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-05 13:30:06 +00:00
commit-bot@chromium.org
1b3beef11b
Don't run GPU configs in bench_pictures on RHB
...
BUG=skia:2518
R=epoger@google.com , djsollen@google.com
Author: borenet@google.com
Review URL: https://codereview.chromium.org/262803012
git-svn-id: http://skia.googlecode.com/svn/trunk@14544 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-02 19:59:59 +00:00
commit-bot@chromium.org
71e39d57d8
remove self-tests for no-longer-supported rebaseline.py
...
see https://codereview.chromium.org/262703003 ('mark rebaseline.py as deprecated')
NOTREECHECKS=True
NOTRY=True
R=borenet@google.com
TBR=borenet
Author: epoger@google.com
Review URL: https://codereview.chromium.org/265073002
git-svn-id: http://skia.googlecode.com/svn/trunk@14538 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-02 16:48:30 +00:00
commit-bot@chromium.org
6a879be2d6
mark rebaseline.py as deprecated
...
(SkipBuildbotRuns)
NOTREECHECKS=True
NOTRY=True
R=senorblanco@google.com
Author: epoger@google.com
Review URL: https://codereview.chromium.org/262703003
git-svn-id: http://skia.googlecode.com/svn/trunk@14530 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-02 14:34:18 +00:00
commit-bot@chromium.org
1a98a0604b
one valgrind.supp to rule them all.
...
R=mtklein@google.com , robertphillips@google.com , borenet@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/268473004
git-svn-id: http://skia.googlecode.com/svn/trunk@14487 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-30 21:10:13 +00:00
senorblanco@chromium.org
9e3b485ac4
Update the list of bots in rebaseline.py.
...
This script was not updated for the new Ubuntu bots. Also, it was
attempting to rebaseline some bots for which we don't keep results
(NVPR, ASAN).
R=borenet@google.com , borenet
Review URL: https://codereview.chromium.org/267483002
git-svn-id: http://skia.googlecode.com/svn/trunk@14472 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-30 16:11:50 +00:00
commit-bot@chromium.org
8c4953c6f1
Cleanup of SSE optimization files.
...
General cleanup of optimization files for x86/SSEx.
Renamed the opts_check_SSE2.cpp file to _x86, since it's not specific
to SSE2. Commented out the ColorRect32 optimization, since it's
disabled anyway, to make it more visible.
Also fixed a lot of indentation, inclusion guards, spelling,
copyright headers, braces, whitespace, and sorting of includes.
Author: henrik.smiding@intel.com
Signed-off-by: Henrik Smiding <henrik.smiding@intel.com>
R=reed@google.com , mtklein@google.com , tomhudson@google.com , djsollen@google.com , joakim.landberg@intel.com
Author: henrik.smiding@intel.com
Review URL: https://codereview.chromium.org/264603002
git-svn-id: http://skia.googlecode.com/svn/trunk@14464 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-30 14:58:46 +00:00
commit-bot@chromium.org
359e4f0a5d
Increase picture bench inner loop iteration to 10 for testing number stableness.
...
BUG=skia:2473
NOTRY=true
R=caryclark@google.com
TBR=caryclark@google.com
Author: bensong@google.com
Review URL: https://codereview.chromium.org/254093002
git-svn-id: http://skia.googlecode.com/svn/trunk@14451 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-30 00:46:29 +00:00
commit-bot@chromium.org
4610a465b6
reland r14391 ('fix contents of render_pictures JSON summary')
...
BUG=skia:2043,skia:2044,skia:1942,skia:2466
R=caryclark@google.com
TBR=caryclark
Author: epoger@google.com
Review URL: https://codereview.chromium.org/262453002
git-svn-id: http://skia.googlecode.com/svn/trunk@14443 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-29 19:39:22 +00:00
commit-bot@chromium.org
95ead5b0e8
Fix buildbot_globals.py: Retrieve the file from our repo mirror
...
BUG=skia:2480
NOTRY=true
R=epoger@google.com
Author: borenet@google.com
Review URL: https://codereview.chromium.org/254013003
git-svn-id: http://skia.googlecode.com/svn/trunk@14439 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-29 17:11:19 +00:00
skia.committer@gmail.com
1c74374684
Sanitizing source files in Housekeeper-Nightly
...
git-svn-id: http://skia.googlecode.com/svn/trunk@14428 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-29 03:05:14 +00:00
commit-bot@chromium.org
172eb1baaf
Add --timescale to bench_record and bench_playback.
...
Default bench_record to report us, bench_playback ms.
BUG=skia:2378
R=mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/253843004
git-svn-id: http://skia.googlecode.com/svn/trunk@14417 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-28 19:41:17 +00:00
commit-bot@chromium.org
bde3cd8f1d
First version of gpuveto testing script
...
This CL just sketches out the structure of the gpuveto testing process. Two big areas for improvement are:
render the picture in tiles and label as unsuitable if any gpu tile is slower than raster
decide on whether tilegrid is used or not
As expected the current gpuveto heuristic isn't so good:
predicted suitable unsuitable
-------------------------------------------
actual suitable 10 17
actual unsuitable 15 27
R=rmistry@google.com , bsalomon@google.com
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/257723003
git-svn-id: http://skia.googlecode.com/svn/trunk@14416 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-28 19:41:01 +00:00
commit-bot@chromium.org
35203e467e
Add chrome_changes file
...
BUG=skia:2457
R=epoger@google.com , bsalomon@google.com , robertphillips@google.com , bungeman@google.com , reed@google.com , skia-team@google.com
Author: borenet@google.com
Review URL: https://codereview.chromium.org/252523002
git-svn-id: http://skia.googlecode.com/svn/trunk@14415 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-28 19:40:53 +00:00
commit-bot@chromium.org
8400b23ce6
use BenchTimer, print in µs
...
BUG=skia:2378
R=bungeman@google.com , mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/257563006
git-svn-id: http://skia.googlecode.com/svn/trunk@14405 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-28 15:30:02 +00:00
commit-bot@chromium.org
cced37d2c3
Revert of fix contents of render_pictures JSON summary ( https://codereview.chromium.org/259703002/ )
...
Reason for revert:
This appears to have caused regressions such as this one: http://108.170.220.120:10117/builders/Perf-Win7-ShuttleA-HD2000-x86-Release/builds/2117/steps/CheckForRegressions/logs/stdio
Original issue's description:
> fix contents of render_pictures JSON summary
>
> BUG=skia:2043,skia:2044,skia:1942
>
> Committed: http://code.google.com/p/skia/source/detail?r=14391
R=scroggo@google.com , epoger@google.com
TBR=epoger@google.com , scroggo@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:2043,skia:2044,skia:1942
Author: caryclark@google.com
Review URL: https://codereview.chromium.org/251103004
git-svn-id: http://skia.googlecode.com/svn/trunk@14399 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-28 14:07:10 +00:00
commit-bot@chromium.org
2349a1e369
git-sync-deps - handle symbolic links to directories
...
NOTRY=true
R=mtklein@google.com , borenet@google.com
Author: halcanary@google.com
Review URL: https://codereview.chromium.org/258053005
git-svn-id: http://skia.googlecode.com/svn/trunk@14396 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-28 13:39:47 +00:00
commit-bot@chromium.org
fe78847f12
gpuveto tool
...
This CL adds a command line tool to report the suitableForGpuRasterization status of a single skp file.
R=bsalomon@google.com , rmistry@google.com
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/259663004
git-svn-id: http://skia.googlecode.com/svn/trunk@14393 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-28 13:19:34 +00:00
commit-bot@chromium.org
eecdcb9e8a
fix contents of render_pictures JSON summary
...
BUG=skia:2043,skia:2044,skia:1942
R=scroggo@google.com
Author: epoger@google.com
Review URL: https://codereview.chromium.org/259703002
git-svn-id: http://skia.googlecode.com/svn/trunk@14391 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-28 13:18:39 +00:00
commit-bot@chromium.org
830628e7ce
Add TSAN suppressions.
...
BUG=skia:1792,skia:2459
R=bsalomon@google.com , mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/259843002
git-svn-id: http://skia.googlecode.com/svn/trunk@14381 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-25 13:59:27 +00:00
commit-bot@chromium.org
8cb1daaa1e
fix minor skp-found bugs
...
remove globals from pathops_unittest
BUG=skia:2460
TBR=mtklein
Author: caryclark@google.com
Review URL: https://codereview.chromium.org/239563004
git-svn-id: http://skia.googlecode.com/svn/trunk@14378 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-25 12:59:11 +00:00
commit-bot@chromium.org
e2cb12a82a
First pass at GPU veto
...
As a short term solution this CL collects information during the recording process for use in suitableForGpuRasterization.
BUG=366495
R=bsalomon@google.com , reed@google.com , alokp@chromium.org
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/251533004
git-svn-id: http://skia.googlecode.com/svn/trunk@14368 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-24 21:53:13 +00:00
commit-bot@chromium.org
d0306a1593
Revert of Add nanosecond timer. ( https://codereview.chromium.org/250243002/ )
...
Reason for revert:
breaks EVERYTHING
Original issue's description:
> Add nanosecond timer.
>
> I've been finding it hard to get enough resolution out of our existing timers when measuring really tiny pictures.
>
> BUG=skia:2378
>
> Committed: http://code.google.com/p/skia/source/detail?r=14362
R=bsalomon@google.com , bungeman@google.com , mtklein@chromium.org
TBR=bsalomon@google.com , bungeman@google.com , mtklein@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=skia:2378
Author: mtklein@google.com
Review URL: https://codereview.chromium.org/258703002
git-svn-id: http://skia.googlecode.com/svn/trunk@14364 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-24 20:17:24 +00:00
commit-bot@chromium.org
74b43a9d4c
Add nanosecond timer.
...
I've been finding it hard to get enough resolution out of our existing timers when measuring really tiny pictures.
BUG=skia:2378
R=bsalomon@google.com , mtklein@google.com , bungeman@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/250243002
git-svn-id: http://skia.googlecode.com/svn/trunk@14362 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-24 20:04:20 +00:00