Commit Graph

7826 Commits

Author SHA1 Message Date
epoger@google.com
5f99545de6 GM: add --missingExpectationsPath option, similar to --mismatchPath
This will allow us to make the buildbots record all images EXCEPT those which
match expectations to Google Storage.

R=borenet@google.com

Review URL: https://codereview.chromium.org/17552012

git-svn-id: http://skia.googlecode.com/svn/trunk@9725 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-21 18:16:47 +00:00
reed@google.com
da2b21fa9b add rect-output parameter to isRect, allowing us to return the correct bounds even if a rectagular path has a trailing moveTo
https://code.google.com/p/chromium/issues/detail?id=247770

R=caryclark@google.com

Review URL: https://codereview.chromium.org/16950021

git-svn-id: http://skia.googlecode.com/svn/trunk@9724 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-21 17:32:32 +00:00
commit-bot@chromium.org
56a57aeb3c SkDebugCanvas: remove unused <iostream> include.
No only this is unused, but it's pulling in a static initializer (which makes SkDebugCanvas unusable in Chromium).

BUG=
R=robertphillips@google.com, bungeman@google.com

Author: fmalita@chromium.org

Review URL: https://chromiumcodereview.appspot.com/17553006

git-svn-id: http://skia.googlecode.com/svn/trunk@9723 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-21 17:14:48 +00:00
bungeman@google.com
28eadc9e4d Fix macro for r9718.
git-svn-id: http://skia.googlecode.com/svn/trunk@9720 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-21 15:28:54 +00:00
bungeman@google.com
a5809a3e4c SkPath::rewind needs to have same reset as SkPath::reset.
R=caryclark@google.com, reed@google.com

Review URL: https://codereview.chromium.org/17432003

git-svn-id: http://skia.googlecode.com/svn/trunk@9718 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-21 15:13:34 +00:00
reed@google.com
8ea69838a4 add (disabled) wrapper for javascript canvas
git-svn-id: http://skia.googlecode.com/svn/trunk@9717 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-21 15:11:40 +00:00
skia.committer@gmail.com
09ebe0be26 Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@9713 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-21 07:00:53 +00:00
bungeman@google.com
e9d8319576 Add maxCharWidth and a compile flag to use old metrics (needed by Blink).
Review URL: https://codereview.chromium.org/17502006

git-svn-id: http://skia.googlecode.com/svn/trunk@9712 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-21 05:31:38 +00:00
egdaniel@google.com
45a3071498 Change window size on GM to fit objects properly
BUG=
R=reed@google.com

Review URL: https://codereview.chromium.org/17419010

git-svn-id: http://skia.googlecode.com/svn/trunk@9711 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-20 21:18:05 +00:00
commit-bot@chromium.org
06b3864ce8 Add gyp define for optimization level
R=tomhudson@google.com, djsollen@google.com, epoger@google.com, bungeman@google.com

Author: borenet@google.com

Review URL: https://chromiumcodereview.appspot.com/17370005

git-svn-id: http://skia.googlecode.com/svn/trunk@9710 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-20 20:28:54 +00:00
egdaniel@google.com
6fd5317512 Turn off conic GM for now
BUG=

Review URL: https://codereview.chromium.org/17500004

git-svn-id: http://skia.googlecode.com/svn/trunk@9707 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-20 18:05:31 +00:00
bungeman@google.com
0afc6bb1b4 Fixed invalid cast on mingw.
Fixes GCC error:
SkThread_win.cpp:39:61: error: invalid static_cast from type ‘int32_t {aka int}’ to type ‘const volatile LONG& {aka const volatile long int&}’

Review URL: https://codereview.chromium.org/17047004

git-svn-id: http://skia.googlecode.com/svn/trunk@9706 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-20 17:54:26 +00:00
reed@google.com
7bce9988af formally declare luaskia extern guy, and then define it
BUG=

Review URL: https://codereview.chromium.org/17503003

git-svn-id: http://skia.googlecode.com/svn/trunk@9705 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-20 17:40:21 +00:00
reed@google.com
c464cbd121 disable PDF for now, until it knows about conics
git-svn-id: http://skia.googlecode.com/svn/trunk@9704 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-20 17:37:24 +00:00
zachr@google.com
28c27c8b79 enable shared lib support in linux for lua
R=bungeman@google.com, reed@google.com

Review URL: https://codereview.chromium.org/16099014

git-svn-id: http://skia.googlecode.com/svn/trunk@9703 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-20 17:15:05 +00:00
egdaniel@google.com
def9f6e3eb Add GM to test conic path rendering
R=reed@google.com

Review URL: https://codereview.chromium.org/17365006

git-svn-id: http://skia.googlecode.com/svn/trunk@9702 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-20 16:54:31 +00:00
bungeman@google.com
05a729ff90 Fix limit on size of glyph paths.
Some web fonts have been observed to contain glyphs which require a buffer
greater than 20KB. In these rare cases we should allocate space on the heap.
Most glyphs require less than 8KB, and Windows has a 1MB stack, so in the
common case just use the stack.

This change also removes the gFTMutex which was both poorly named and used.
The constructor does not appear to have any need for it, and with this change
the path generation code does not need it. The mask generating code does need
memory barriers for correctness, but these bariers are no-ops on x86. We will
need another change to clean up this sort of static initialization code.

R=caryclark@google.com

Review URL: https://codereview.chromium.org/17435003

git-svn-id: http://skia.googlecode.com/svn/trunk@9700 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-20 15:29:16 +00:00
robertphillips@google.com
a154dc8985 Rebaselining some performance trigger flakes
git-svn-id: http://skia.googlecode.com/svn/trunk@9696 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-20 07:06:44 +00:00
skia.committer@gmail.com
4d494f031c Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@9695 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-20 07:00:59 +00:00
bungeman@google.com
5e4fe21689 Fix shift detection in views on X.
On X, the meta keys are encoded in xkey.state, not xkey.keycode.
This fixes 'h' and 's' not working in SampleApp.



git-svn-id: http://skia.googlecode.com/svn/trunk@9694 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-19 23:06:00 +00:00
reed@google.com
d1f1b67f5e post Expose event when we see an inval
git-svn-id: http://skia.googlecode.com/svn/trunk@9693 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-19 20:56:45 +00:00
borenet@google.com
68b5bae2bc Allow specification of a non-default boto file in chromeos_make
This is needed because our GS bucket needs a different auth key from the
ChromeOS bucket.

(SkipBuildbotRuns)

R=epoger@google.com

Review URL: https://codereview.chromium.org/16975017

git-svn-id: http://skia.googlecode.com/svn/trunk@9692 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-19 19:44:18 +00:00
reed@google.com
6757a3c71f combine glyph and image bulk alloc, and adjust initial alloc size, to reduce total waste from 50% to 30%
add diagnostics to measure cache efficiency

BUG=

Review URL: https://codereview.chromium.org/17449012

git-svn-id: http://skia.googlecode.com/svn/trunk@9691 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-19 19:25:36 +00:00
scroggo@google.com
3832da1e9c Allow skimage expectations file to not exist.
If the file is not there, assume that all images are mismatches.
This allows running the test before the initial rebaseline.

R=epoger@google.com

Review URL: https://codereview.chromium.org/17448011

git-svn-id: http://skia.googlecode.com/svn/trunk@9690 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-19 19:12:53 +00:00
epoger@google.com
99a8ec9705 rebaseline.py: split image-based rebaselining, which will go away soon, into its own script
(part of step 3 in https://goto.google.com/ChecksumTransitionDetail )

also adds new --expectations-root option

R=scroggo@google.com, senorblanco@chromium.org

Review URL: https://codereview.chromium.org/17379004

git-svn-id: http://skia.googlecode.com/svn/trunk@9689 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-19 18:56:59 +00:00
epoger@google.com
27d302581a fix https://code.google.com/p/skia/issues/detail?id=1356
('32-bit Mac compiler doesn't like https://code.google.com/p/skia/source/detail?r=9686')



git-svn-id: http://skia.googlecode.com/svn/trunk@9688 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-19 18:52:42 +00:00
epoger@google.com
6f7f14d061 Reland r9682, using new SkString::appendU64()
Review URL: https://codereview.chromium.org/17157005

git-svn-id: http://skia.googlecode.com/svn/trunk@9687 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-19 18:28:31 +00:00
epoger@google.com
d88a3d8336 Add SkString::appendU32() and SkString::appendU64()
as needed to re-land r9682

R=reed@google.com

Review URL: https://codereview.chromium.org/17448012

git-svn-id: http://skia.googlecode.com/svn/trunk@9686 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-19 18:27:20 +00:00
edisonn@google.com
afe5e9e417 Deal with ca and CA transparency operators in pdf. add comments to generated classes.
Review URL: https://codereview.chromium.org/16975013

git-svn-id: http://skia.googlecode.com/svn/trunk@9685 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-19 17:42:17 +00:00
epoger@google.com
628de5f1f4 Reverting r9682, which broke on some compilers
git-svn-id: http://skia.googlecode.com/svn/trunk@9684 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-19 15:58:00 +00:00
epoger@google.com
6324ac5d81 GM: add --writeChecksumBasedFilenames option
as needed for Step 2 of https://goto.google.com/ChecksumTransitionDetail :
make GenerateGMs upload actual images to Google Storage instead of skia-autogen

R=scroggo@google.com

Review URL: https://codereview.chromium.org/17365002

git-svn-id: http://skia.googlecode.com/svn/trunk@9682 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-19 15:50:09 +00:00
borenet@google.com
5ec130524e Use "Simple Chrome for Chrome OS Workflow" to build Skia for ChromeOS
(SkipBuildbotRuns) since this isn't used yet.

R=djsollen@google.com

Review URL: https://codereview.chromium.org/17412007

git-svn-id: http://skia.googlecode.com/svn/trunk@9681 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-19 15:13:32 +00:00
commit-bot@chromium.org
afb0e9c7b1 Remove unused NormalizeBench::fUsePortable field.
To address build warnings:

../bench/MathBench.cpp:442:10: error: private field 'fUsePortable' is not used
[-Werror,-Wunused-private-field]
bool fUsePortable;
     ^

R=reed@google.com

Author: fmalita@chromium.org

Review URL: https://chromiumcodereview.appspot.com/17463002

git-svn-id: http://skia.googlecode.com/svn/trunk@9677 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-19 13:28:44 +00:00
robertphillips@google.com
f3488427da Performance trigger rebaselines
git-svn-id: http://skia.googlecode.com/svn/trunk@9673 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-19 11:50:18 +00:00
commit-bot@chromium.org
b4e200ec6b Make GrGLConfigConversionEffect work on Intel GPUs
BUG=247664
R=noel@chromium.org, bsalomon@chromium.org, reed@google.com, tomhudson@chromium.org, bsalomon@google.com

Author: jun.a.jiang@intel.com

Review URL: https://chromiumcodereview.appspot.com/15719007

git-svn-id: http://skia.googlecode.com/svn/trunk@9672 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-19 11:41:02 +00:00
skia.committer@gmail.com
c32f1d46d4 Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@9671 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-19 07:01:12 +00:00
edisonn@google.com
59543d34df Continue to contain podofo, shorter enums
Review URL: https://codereview.chromium.org/17395005

git-svn-id: http://skia.googlecode.com/svn/trunk@9670 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-18 22:00:40 +00:00
zachr@google.com
6ef5a85bf4 force linking inside of skdiff
Review URL: https://codereview.chromium.org/16879012

git-svn-id: http://skia.googlecode.com/svn/trunk@9669 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-18 21:23:31 +00:00
commit-bot@chromium.org
1f7928663f Refactor: clean up some unused or mostly-unused API I saw here.
BUG=
R=bungeman@google.com, reed@google.com

Author: mtklein@google.com

Review URL: https://chromiumcodereview.appspot.com/17414003

git-svn-id: http://skia.googlecode.com/svn/trunk@9668 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-18 20:50:34 +00:00
commit-bot@chromium.org
7a11591e5e Rename SkDrawCommand subclasses
SkDrawCommand subclass names are too generic and likely to clash in the default namespace.
This makes the header unusable in Chrome - for example, on Mac builders:

../../third_party/skia/src/utils/debugger/SkDrawCommand.h:251:7: error: redefinition of 'Comment'
class Comment : public SkDrawCommand {
	      ^
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.6.sdk/System/Library/Frameworks/CoreServices.framework/Frameworks/CarbonCore.framework/Headers/AIFF.h:192:8: note: previous definition is here
struct Comment {


This CL renames SkDrawCommand subclasses using the following pattern: "${cmd}" -> "Sk${cmd}Command".

R=robertphillips@google.com, bungeman@google.com, djsollen@google.com

Author: fmalita@chromium.org

Review URL: https://chromiumcodereview.appspot.com/17101005

git-svn-id: http://skia.googlecode.com/svn/trunk@9667 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-18 20:20:55 +00:00
commit-bot@chromium.org
c41295d122 remove double including of libpng decoder
R=bungeman@google.com

Author: zachr@google.com

Review URL: https://chromiumcodereview.appspot.com/17408002

git-svn-id: http://skia.googlecode.com/svn/trunk@9666 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-18 20:06:36 +00:00
commit-bot@chromium.org
3da6c56f14 Allow files, making ".skp files or directories are required." less of a lie.
BUG=
R=reed@google.com

Author: mtklein@google.com

Review URL: https://chromiumcodereview.appspot.com/17151008

git-svn-id: http://skia.googlecode.com/svn/trunk@9665 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-18 18:35:58 +00:00
edisonn@google.com
29247629b6 put each generated pdf api class in a file (step 1, add new files)
Review URL: https://codereview.chromium.org/17395005

git-svn-id: http://skia.googlecode.com/svn/trunk@9661 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-18 16:28:29 +00:00
commit-bot@chromium.org
7fa22f3329 Smallest possible desktop application that uses Skia to render stuff.
Small Hello World smaple. Subclasses SkOSWindow.

R=caryclark@google.com

Author: sglez@google.com

Review URL: https://chromiumcodereview.appspot.com/16337012

git-svn-id: http://skia.googlecode.com/svn/trunk@9657 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-18 15:37:27 +00:00
edisonn@google.com
60533dc4bf add value() functions to podofo wrapers to isolate the client from knowing it is using podofo internally
Review URL: https://codereview.chromium.org/17101011

git-svn-id: http://skia.googlecode.com/svn/trunk@9654 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-18 14:51:21 +00:00
robertphillips@google.com
e63296e5d6 Fuse skgr & gr targets in gyp files
https://codereview.chromium.org/17101010/



git-svn-id: http://skia.googlecode.com/svn/trunk@9653 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-18 14:43:53 +00:00
robertphillips@google.com
44f7c230a5 Performance trigger rebaselines after hard reboot
(SkipBuildbotRuns)



git-svn-id: http://skia.googlecode.com/svn/trunk@9651 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-18 13:29:32 +00:00
skia.committer@gmail.com
a48595d863 Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@9648 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-18 07:00:52 +00:00
epoger@google.com
c7e1873c85 skimage: revert r9642
git-svn-id: http://skia.googlecode.com/svn/trunk@9647 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-18 02:53:16 +00:00
edisonn@google.com
1277cf05cc Pdfviewer: generate isAFoo() and getAsFoo() api for fields that can have multiple types.
Review URL: https://codereview.chromium.org/16968007

git-svn-id: http://skia.googlecode.com/svn/trunk@9646 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-17 23:36:45 +00:00