Commit Graph

38152 Commits

Author SHA1 Message Date
Nigel Tao
9803e0c522 Remove some #ifdef's from SkAndroidCodec
SkSampledCodec is always defined, and if we got a codec that claims to
be one of these (PNG, ICO, JPEG, GIF, BMP, WBMP, HEIF), we should pass
it to SkSampledCodec.

Bug: skia:
Change-Id: Id2e3a1798cb5aaaf4d44f019b665b6ece463097e
Reviewed-on: https://skia-review.googlesource.com/c/168540
Reviewed-by: Leon Scroggins <scroggo@google.com>
Commit-Queue: Leon Scroggins <scroggo@google.com>
2018-11-07 16:39:52 +00:00
Mike Klein
b5c2cf84ca back out SK_CODEC_DECODES_RAW in Google3
This implies a pretty big code size dependency,
and I suspect we're not actually using it.

There can be some more BUILD-side cleanup after
this rolls in, I think, but this ought to be the
key to making everything else strippable dead code.

Change-Id: I30be8f4e8d83635eec80a16292200eeb9a43c778
Reviewed-on: https://skia-review.googlesource.com/c/169184
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
2018-11-07 16:36:40 +00:00
Kevin Lubick
70273a92aa Make the skia-wasm-release image only have the build products
The previous version had several gigs of buildtools, source code, etc.
This is much smaller and easier to download for tools like
jsfiddles.skia.org and (soon) skottie.skia.org

Bug: skia:
Change-Id: I748487abb1c6f6e82476076d22a27a5d4f90f75a
Reviewed-on: https://skia-review.googlesource.com/c/169240
Reviewed-by: Kevin Lubick <kjlubick@google.com>
2018-11-07 16:35:44 +00:00
Mike Klein
62cc5f5817 move this define to be with its friends in flutter_defines.gni
I'd like to get to the point where the only Flutter-specific
configuration is defines, in flutter_defines.gni.

Change-Id: Idda141c4dcdb5f18275e29d2ab60bb73bf416d59
Reviewed-on: https://skia-review.googlesource.com/c/169102
Auto-Submit: Mike Klein <mtklein@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
2018-11-07 15:56:55 +00:00
Kevin Lubick
e5a06e7bd3 [canvaskit] Update examples after enum name change
Docs-Preview: https://skia.org/?cl=169186
Bug: skia:
Change-Id: I083a07cc44e1534f4aeedc4e25e8ed786e29f168
Reviewed-on: https://skia-review.googlesource.com/c/169186
Reviewed-by: Kevin Lubick <kjlubick@google.com>
2018-11-07 15:45:14 +00:00
Stan Iliev
762ba1038d Skottie Android demo app improvements
Changed SkottieView base class to TextureView.
Implemented new SkottieAnimation interface, which allows to
get animation duration, set and get animation progress.
SkottieView will draw correctly even if animation is stopped.

Test: Ran Skottie app
Bug: skia:
Change-Id: I952793b75518107f515ddec8ad6524f4048f42e7
Reviewed-on: https://skia-review.googlesource.com/c/167945
Commit-Queue: Stan Iliev <stani@google.com>
Reviewed-by: Derek Sollenberger <djsollen@google.com>
Reviewed-by: Florin Malita <fmalita@chromium.org>
2018-11-07 15:41:34 +00:00
Mike Klein
e475f4ee69 remove -DSK_DISABLE_RENDER_TARGET_SORTING from Flutter
It doesn't do anything.

Change-Id: I569421c2ecb1226bd2701e6546f4826e4133a168
Reviewed-on: https://skia-review.googlesource.com/c/169101
Commit-Queue: Mike Klein <mtklein@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
Auto-Submit: Mike Klein <mtklein@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
2018-11-07 15:06:18 +00:00
skia-autoroll@skia-public.iam.gserviceaccount.com
1f95806e33 Roll skia/third_party/skcms 26679709b32f..ee5557693416 (1 commits)
https://skia.googlesource.com/skcms.git/+log/26679709b32f..ee5557693416

2018-11-07 mtklein@google.com these can be the same buffer


The AutoRoll server is located here: https://autoroll.skia.org/r/skcms-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=allanmac@google.com

Change-Id: I48ad88345f7bd1d81d05ebedac5ed1af3cb4b372
Reviewed-on: https://skia-review.googlesource.com/c/169164
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2018-11-07 14:53:31 +00:00
Mike Klein
d282860c94 get rid of SkScalarDiv
It looks like it's possible to divide by zero safely in the one place
it's used, so I've replaced it with sk_ieee_float_divide().

Change-Id: I3ebfa697869bc7d4da61b6fc5711421a833c9081
Reviewed-on: https://skia-review.googlesource.com/c/169080
Reviewed-by: Florin Malita <fmalita@chromium.org>
2018-11-07 14:15:09 +00:00
Mike Klein
4991cd3441 move third_party/gif deps to codec_srcs
SkCodec is built as its own cc_library and is missing
these sources.  We've been getting away with it because
:skia is still built with alwayslink=1.

(After this CL, I think it need not be built with alwayslink=1
anymore.  We used to use SkTRegistry to hook in codecs, but
we only use that registration trick in tools now.)

Change-Id: I79dbfc0080a438ecf1ee00e532ff40cd6f45d5b3
Reviewed-on: https://skia-review.googlesource.com/c/169140
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
2018-11-07 13:51:31 +00:00
recipe-roller
273fa2f3bd Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
depot_tools:
  https://crrev.com/4d2d5b4bbe385b37659efcdd7e7641622c05bd2a Fix unhelpful error when gn.py run in wrong directory. (lowell@google.com)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ide3a164146abdaa3907b51e14b381dfc2c54d55d
Reviewed-on: https://skia-review.googlesource.com/c/169040
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
2018-11-07 10:18:20 +00:00
skia-recreate-skps
67f5c0ceac Update go_deps asset
Automatic commit by the UpdateGoDEPS bot.

TBR=borenet@google.com

Change-Id: I11bb0315b4fb35ff1ddf110d76e734ceb192ee5a
Reviewed-on: https://skia-review.googlesource.com/c/169020
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
2018-11-07 06:12:31 +00:00
skia-autoroll
cd6738bd10 Roll third_party/externals/swiftshader 6e8ec338eb25..825d344daa31 (1 commits)
https://swiftshader.googlesource.com/SwiftShader.git/+log/6e8ec338eb25..825d344daa31


git log 6e8ec338eb25..825d344daa31 --date=short --no-merges --format='%ad %ae %s'
2018-11-07 capn@google.com Only enable Clang-specific errors on Clang.


Created with:
  gclient setdep -r third_party/externals/swiftshader@825d344daa31

The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Test-Debian9-Clang-GCE-GPU-SwiftShader-x86_64-Debug-All-SwiftShader
TBR=allanmac@google.com

Change-Id: I1a0b303838da1b80ec02c6701bb219adf2cebc30
Reviewed-on: https://skia-review.googlesource.com/c/169000
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2018-11-07 06:12:30 +00:00
recipe-roller
2a13921745 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
depot_tools:
  https://crrev.com/4b49707cb5caf3c05e5a3449319e98c29b84ac02 autoninja: use ninja in the autoninja.py directory (yyanagisawa@chromium.org)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Icd96b791dac1ac2dd011307c327faf7c67a49dd2
Reviewed-on: https://skia-review.googlesource.com/c/168924
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
2018-11-07 03:28:22 +00:00
skia-autoroll
3daed9b12d Roll third_party/externals/angle2 77b2436e28f4..1bf18ce9e2ca (2 commits)
77b2436e28..1bf18ce9e2


git log 77b2436e28f4..1bf18ce9e2ca --date=short --no-merges --format='%ad %ae %s'
2018-11-06 enga@chromium.org Implement GL_ANGLE_multi_draw
2018-11-06 jmadill@chromium.org Vulkan: Use dynamic state for Viewport and Scissor.


Created with:
  gclient setdep -r third_party/externals/angle2@1bf18ce9e2ca

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE
TBR=allanmac@google.com

Change-Id: I659ffce67c6dffe5ce996feab11d7c33e6d62286
Reviewed-on: https://skia-review.googlesource.com/c/168980
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2018-11-07 02:21:12 +00:00
Cary Clark
7e69c8f348 fix paint docs
quick and dirty edit to get the bots green.
Larger edit is in the works to bring docs
related to these changes up to date.

TBR=reed@google.com

Docs-Preview: https://skia.org/?cl=168923
Bug: skia:
Change-Id: I38af409e75e46439288e94de2758b34094d0e08f
Reviewed-on: https://skia-review.googlesource.com/c/168923
Commit-Queue: Cary Clark <caryclark@skia.org>
Auto-Submit: Cary Clark <caryclark@skia.org>
Reviewed-by: Cary Clark <caryclark@skia.org>
2018-11-07 02:10:01 +00:00
recipe-roller
fa7d3706d9 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
depot_tools:
  https://crrev.com/52a091f419505471cac24ccf5d70ef8340747ed0 Add android_internal fetch spec. (jbudorick@chromium.org)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ia68d2d4da9ac4e0c7b17cb9097f38139456325d6
Reviewed-on: https://skia-review.googlesource.com/c/168922
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
2018-11-07 01:42:29 +00:00
Mike Klein
d3ed301a36 remove SkScalarFastInvert
Its implementation is just 1/x,
and looks like we never expect x == 0.

Change-Id: I405a3bd02b04d9ac0b13cea17573e32fc80ac0b2
Reviewed-on: https://skia-review.googlesource.com/c/168920
Reviewed-by: Florin Malita <fmalita@chromium.org>
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
2018-11-07 01:06:30 +00:00
Mike Klein
5c8d3e17ab clean up SK_LEGACY_OP_COLOR_AS_BYTES
Change-Id: I5a63e8185060b78c9e038159bbd4e5288ee2539f
Reviewed-on: https://skia-review.googlesource.com/c/168881
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
2018-11-07 00:22:51 +00:00
Mike Klein
987e76ccf6 make SkColorShader RP-only
Now that we're not creating them internally,
they should be rare-to-non-existent.

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ib8414a7096252e4c8c94d9ba447938fa467f0b26
Reviewed-on: https://skia-review.googlesource.com/c/168880
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
2018-11-07 00:03:00 +00:00
Mike Klein
630e7d651a remove Gauss option from SkGaussFilter
Unused except in unit tests.

Change-Id: I07bb70515a383898ad59c0fa918461052b582e35
Reviewed-on: https://skia-review.googlesource.com/c/168860
Reviewed-by: Herb Derby <herb@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
2018-11-06 23:16:59 +00:00
skia-autoroll
0e50a38dca Roll third_party/externals/swiftshader dc2966a15b0c..6e8ec338eb25 (1 commits)
https://swiftshader.googlesource.com/SwiftShader.git/+log/dc2966a15b0c..6e8ec338eb25


git log dc2966a15b0c..6e8ec338eb25 --date=short --no-merges --format='%ad %ae %s'
2018-11-06 capn@google.com Fix deterministic loops within conditional blocks, again.


Created with:
  gclient setdep -r third_party/externals/swiftshader@6e8ec338eb25

The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Test-Debian9-Clang-GCE-GPU-SwiftShader-x86_64-Debug-All-SwiftShader
TBR=allanmac@google.com

Change-Id: I14df31021158d2772255b709a2e0ac105f2b2679
Reviewed-on: https://skia-review.googlesource.com/c/168780
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2018-11-06 22:10:05 +00:00
Mike Klein
a4c277b07f make float divide-by-zero fatal
Change-Id: I9ba1caa4862bdf9ffc9c0e637bd69cce91fd8468
Reviewed-on: https://skia-review.googlesource.com/c/168740
Reviewed-by: Herb Derby <herb@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
2018-11-06 21:56:27 +00:00
Leon Scroggins III
e5eb1a5904 Remove SkBitmap::[setH/h]asHardwareMipMap
These are no longer used by Android.

Change-Id: Ie3b9aa60af681f9e076a0d0680fc716ae51f9cd8
Reviewed-on: https://skia-review.googlesource.com/c/168486
Reviewed-by: Cary Clark <caryclark@google.com>
Reviewed-by: Derek Sollenberger <djsollen@google.com>
Auto-Submit: Leon Scroggins <scroggo@google.com>
Commit-Queue: Leon Scroggins <scroggo@google.com>
2018-11-06 21:44:01 +00:00
skia-autoroll
775ee901d3 Roll third_party/externals/swiftshader 1d8c8dba995a..dc2966a15b0c (1 commits)
https://swiftshader.googlesource.com/SwiftShader.git/+log/1d8c8dba995a..dc2966a15b0c


git log 1d8c8dba995a..dc2966a15b0c --date=short --no-merges --format='%ad %ae %s'
2018-11-06 capn@google.com Eliminate legacy functionality.


Created with:
  gclient setdep -r third_party/externals/swiftshader@dc2966a15b0c

The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Test-Debian9-Clang-GCE-GPU-SwiftShader-x86_64-Debug-All-SwiftShader
TBR=allanmac@google.com

Change-Id: I3e6921e47f27b77ab05567fed8aae10b9a28b666
Reviewed-on: https://skia-review.googlesource.com/c/168663
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2018-11-06 20:11:53 +00:00
Ben Wagner
2aa9a22fe1 Add subset of Ubuntu18 jobs.
We currently have only one bot for these jobs, so we should treat them
as experimental for now.

Bug: 837351
Change-Id: I1ea9f1bf1635c36895eede80df6709509a85df90
Reviewed-on: https://skia-review.googlesource.com/c/168489
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
Auto-Submit: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2018-11-06 19:54:01 +00:00
Mike Klein
eda2ac2091 send 3D masks through raster pipeline blitter
This makes the emboss mask filter work correctly with anything that's
SkRasterPipeline-only, like color filters or color spaces.

PS5 implements lowp too.

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ic2bf4d37a0f85670f47ec875e692e5b4cdc02271
Reviewed-on: https://skia-review.googlesource.com/c/168620
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
2018-11-06 19:42:08 +00:00
skia-autoroll
fe454acf5e Roll third_party/externals/swiftshader 4169b31090db..1d8c8dba995a (1 commits)
https://swiftshader.googlesource.com/SwiftShader.git/+log/4169b31090db..1d8c8dba995a


git log 4169b31090db..1d8c8dba995a --date=short --no-merges --format='%ad %ae %s'
2018-11-06 capn@google.com Fix include paths.


Created with:
  gclient setdep -r third_party/externals/swiftshader@1d8c8dba995a

The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Test-Debian9-Clang-GCE-GPU-SwiftShader-x86_64-Debug-All-SwiftShader
TBR=allanmac@google.com

Change-Id: Ie03d7dd8408fa318bdc8c6b5760c89fe646354f7
Reviewed-on: https://skia-review.googlesource.com/c/168660
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2018-11-06 18:36:50 +00:00
Mike Reed
cb6f53efbc split out fontmetrics into its own struct
Future CLs will migrate all callers to use SkFontMetrics,
so we can remove the SkPaint typedef.

Next migrate the world to use SkFont::getMetrics() instead

Bug: skia:2664
Change-Id: I2aa45cd88762c3d3589c12f5074974af7fb85410
Reviewed-on: https://skia-review.googlesource.com/c/168641
Reviewed-by: Herb Derby <herb@google.com>
Commit-Queue: Mike Reed <reed@google.com>
2018-11-06 18:16:48 +00:00
Mike Klein
3674336c33 Reland "make enum santizer fatal"
This is a reland of 166dbd3135

Since last attempt,
   - update SkPath::Direction docs
   - kIllegal is not an advanced blend mode

Original change's description:
> make enum santizer fatal
>
> This enum sanitizer checks that all the values of the enum we use fall
> within the range of the enumerated values.
>
> The main thing this helps point out is that the size of enum types in
> C++ need only be large enough to hold the largest declared value; larger
> values are undefined.  In practice, most enums are implemented as ints
> for compatibility with C, so while this hasn't pointed out anything
> egregiously broken, the sanitizer has found a couple possibly dangerous
> situations in our codebase.
>
> For most types using values outside the enum range, we can just
> explicitly size them to int.  This makes their de facto size de jure.
>
> But we need to actually make GrBlendEquation and GrBlendCoeff not store
> values outside their enumerated range.  They're packed into bitfields
> that really can't represent those (negative) values.  So for these I've
> added new kIllegal values to the enums, forcing us to deal with our
> once-silent illegal values a bit more explicitly.
>
> Change-Id: Ib617694cf1aaa83ae99289e9e760f49cb6393a2f
> Reviewed-on: https://skia-review.googlesource.com/c/168484
> Reviewed-by: Brian Osman <brianosman@google.com>

Cq-Include-Trybots: skia.primary:Housekeeper-PerCommit-Bookmaker,Test-Android-Clang-AndroidOne-GPU-Mali400MP2-arm-Debug-All-Android
Change-Id: Id93b80bbeae11872542c9b76715e3c3cb10609fd
Reviewed-on: https://skia-review.googlesource.com/c/168582
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
2018-11-06 17:31:00 +00:00
Florin Malita
5d3deb7301 [skottie] Preserve image aspect ratio
When the intrinsic image dimensions don't match the declared asset size,
use an aspect-preserving matrix for scaling.

Bug: skia:
TBR=
Change-Id: Ie361f464fdbc2c32cb898c9f97103521162b46a7
Reviewed-on: https://skia-review.googlesource.com/c/168274
Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Florin Malita <fmalita@chromium.org>
Auto-Submit: Florin Malita <fmalita@chromium.org>
2018-11-06 17:24:58 +00:00
skia-autoroll
fe24b83bf7 Roll third_party/externals/angle2 3d86e89bce7a..77b2436e28f4 (1 commits)
3d86e89bce..77b2436e28


git log 3d86e89bce7a..77b2436e28f4 --date=short --no-merges --format='%ad %ae %s'
2018-11-06 jmadill@chromium.org Vulkan: Reduce PipelineDesc size.


Created with:
  gclient setdep -r third_party/externals/angle2@77b2436e28f4

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE
TBR=allanmac@google.com

Change-Id: I767084e0ceba77a1d2af9e247302831fd352b037
Reviewed-on: https://skia-review.googlesource.com/c/168522
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2018-11-06 17:11:25 +00:00
Mike Klein
f2b35e4fb8 Revert "make enum santizer fatal"
This reverts commit 166dbd3135.

Reason for revert: illegal is not advanced, docs

Original change's description:
> make enum santizer fatal
> 
> This enum sanitizer checks that all the values of the enum we use fall
> within the range of the enumerated values.
> 
> The main thing this helps point out is that the size of enum types in
> C++ need only be large enough to hold the largest declared value; larger
> values are undefined.  In practice, most enums are implemented as ints
> for compatibility with C, so while this hasn't pointed out anything
> egregiously broken, the sanitizer has found a couple possibly dangerous
> situations in our codebase.
> 
> For most types using values outside the enum range, we can just
> explicitly size them to int.  This makes their de facto size de jure.
> 
> But we need to actually make GrBlendEquation and GrBlendCoeff not store
> values outside their enumerated range.  They're packed into bitfields
> that really can't represent those (negative) values.  So for these I've
> added new kIllegal values to the enums, forcing us to deal with our
> once-silent illegal values a bit more explicitly.
> 
> Change-Id: Ib617694cf1aaa83ae99289e9e760f49cb6393a2f
> Reviewed-on: https://skia-review.googlesource.com/c/168484
> Reviewed-by: Brian Osman <brianosman@google.com>

TBR=mtklein@chromium.org,mtklein@google.com,brianosman@google.com

Change-Id: I691c08092340a6273e442c0f098b844f7d0363ba
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/c/168581
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
2018-11-06 16:30:19 +00:00
Mike Reed
4529cb56e0 change MakeRecAndEffects to take SkFont
Bug: skia:
Change-Id: I35be940a27e917b18f698addeb8827cb0216f067
Reviewed-on: https://skia-review.googlesource.com/c/168277
Reviewed-by: Herb Derby <herb@google.com>
Commit-Queue: Mike Reed <reed@google.com>
2018-11-06 16:16:32 +00:00
Hal Canary
7a305a2ef7 Enums: specify base
Change-Id: I540435869bfd22b47eaa4f2f1471654c53707ea1
Reviewed-on: https://skia-review.googlesource.com/c/168279
Commit-Queue: Cary Clark <caryclark@google.com>
Auto-Submit: Hal Canary <halcanary@google.com>
Reviewed-by: Cary Clark <caryclark@google.com>
2018-11-06 15:47:19 +00:00
Kevin Lubick
96175696de Add skia-wasm-release image.
This should let us pipe continuous builds into jsfiddle.skia.org and
skottie.skia.org

Bug: skia:
Change-Id: I587e1293237d42dfdacae0757f44634f29d6f251
Reviewed-on: https://skia-review.googlesource.com/c/168440
Reviewed-by: Joe Gregorio <jcgregorio@google.com>
2018-11-06 15:45:51 +00:00
Mike Klein
166dbd3135 make enum santizer fatal
This enum sanitizer checks that all the values of the enum we use fall
within the range of the enumerated values.

The main thing this helps point out is that the size of enum types in
C++ need only be large enough to hold the largest declared value; larger
values are undefined.  In practice, most enums are implemented as ints
for compatibility with C, so while this hasn't pointed out anything
egregiously broken, the sanitizer has found a couple possibly dangerous
situations in our codebase.

For most types using values outside the enum range, we can just
explicitly size them to int.  This makes their de facto size de jure.

But we need to actually make GrBlendEquation and GrBlendCoeff not store
values outside their enumerated range.  They're packed into bitfields
that really can't represent those (negative) values.  So for these I've
added new kIllegal values to the enums, forcing us to deal with our
once-silent illegal values a bit more explicitly.

Change-Id: Ib617694cf1aaa83ae99289e9e760f49cb6393a2f
Reviewed-on: https://skia-review.googlesource.com/c/168484
Reviewed-by: Brian Osman <brianosman@google.com>
2018-11-06 15:39:50 +00:00
Brian Osman
00b2939890 Remove some more GrColor references
Bug: skia:
Change-Id: I395395b1cd81a1d45ca779b2273015c8ed9fb882
Reviewed-on: https://skia-review.googlesource.com/c/168361
Commit-Queue: Brian Osman <brianosman@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
2018-11-06 13:34:25 +00:00
Kevin Lubick
e70c6b13dd Update emsdk-release image
Bug: skia:
Change-Id: I780912e1c481765d2d17d2ce66a27470ee8b4912
Reviewed-on: https://skia-review.googlesource.com/c/168483
Reviewed-by: Kevin Lubick <kjlubick@google.com>
2018-11-06 13:21:34 +00:00
skia-bookmaker
e6c8575583 Update markdown files
Automatic commit by the Housekeeper-Nightly-Bookmaker bot.

TBR=rmistry@google.com
NO_MERGE_BUILDS

Change-Id: I38e7f006aba87f7dd3fdc87ca4d2090b715bc15e
Reviewed-on: https://skia-review.googlesource.com/c/168521
Commit-Queue: <skia-bookmaker@skia-swarming-bots.iam.gserviceaccount.com>
Reviewed-by: <skia-bookmaker@skia-swarming-bots.iam.gserviceaccount.com>
2018-11-06 06:11:56 +00:00
skia-recreate-skps
8042bc2e0b Update go_deps asset
Automatic commit by the UpdateGoDEPS bot.

TBR=borenet@google.com

Change-Id: If344f21f6f54fc963cc07cbd7213c1a68bbf110c
Reviewed-on: https://skia-review.googlesource.com/c/168520
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
2018-11-06 06:11:46 +00:00
Cary Clark
11407e56f2 fix paint docs
fix bookmaker build for setHinting

TBR=reed@google.com

Bug: skia:
Change-Id: Ieade1bca4cd369eb5a9431796c83e039ae69e81c
Reviewed-on: https://skia-review.googlesource.com/c/168480
Reviewed-by: Cary Clark <caryclark@skia.org>
Commit-Queue: Cary Clark <caryclark@skia.org>
Auto-Submit: Cary Clark <caryclark@skia.org>
2018-11-06 03:06:20 +00:00
Brian Osman
5b2bda70e5 Fix FP / header inconsistency
Bug: skia:
Change-Id: I99673d19ae7ce6dd7f781ffd58318e8abd524db9
Reviewed-on: https://skia-review.googlesource.com/c/168364
Commit-Queue: Brian Osman <brianosman@google.com>
Commit-Queue: Allan MacKinnon <allanmac@google.com>
Auto-Submit: Brian Osman <brianosman@google.com>
Reviewed-by: Allan MacKinnon <allanmac@google.com>
2018-11-06 01:23:00 +00:00
Brian Osman
2dfab27d69 Revert "Fix div-by-zero loophole in gradient factory func"
This reverts commit c34dd6c526.

Reason for revert: Speculative fix for Chrome roll (gradient layout test failures)

Original change's description:
> Fix div-by-zero loophole in gradient factory func
> 
> Bug: oss-fuzz:10373
> Change-Id: I4277fb63e3186ee34feaf09ecf6aeddeb532f9c1
> Reviewed-on: https://skia-review.googlesource.com/c/168269
> Reviewed-by: Kevin Lubick <kjlubick@google.com>
> Commit-Queue: Michael Ludwig <michaelludwig@google.com>

TBR=jvanverth@google.com,kjlubick@google.com,michaelludwig@google.com

Change-Id: I6333390d2ecc559ad98bd4d734ab1c674e23037f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: oss-fuzz:10373
Reviewed-on: https://skia-review.googlesource.com/c/168460
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2018-11-06 00:41:49 +00:00
Brian Osman
422f95bce8 Revert "Revert "Use float colors for blend constant""
This reverts commit 5a4f2a341a.

Bug: skia:
Change-Id: I706009343dc1976311a88d57800a140efd776861
Reviewed-on: https://skia-review.googlesource.com/c/168363
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2018-11-05 23:46:20 +00:00
recipe-roller
7064a6efbd Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/c00f13df3e9b3c9bbd191ace36502341f1f2cc52 [isolated] Add ability to add an array of files. (joshuaseaton@google.com)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: If7d58c8de48424b39ee6d442148ae7c23916ec22
Reviewed-on: https://skia-review.googlesource.com/c/168444
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
2018-11-05 23:41:35 +00:00
skia-autoroll
d3ab447853 Roll third_party/externals/swiftshader 20622c0194bd..4169b31090db (1 commits)
https://swiftshader.googlesource.com/SwiftShader.git/+log/20622c0194bd..4169b31090db


git log 20622c0194bd..4169b31090db --date=short --no-merges --format='%ad %ae %s'
2018-11-05 tikuta@google.com Fix for unused-lambda-capture warning


Created with:
  gclient setdep -r third_party/externals/swiftshader@4169b31090db

The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Test-Debian9-Clang-GCE-GPU-SwiftShader-x86_64-Debug-All-SwiftShader
TBR=allanmac@google.com

Change-Id: I331c92ff342a619346a4b744fe8dd9763d1bbd8e
Reviewed-on: https://skia-review.googlesource.com/c/168381
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2018-11-05 23:41:15 +00:00
recipe-roller
df8225e253 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/834ac61e122d54c0409b2789490f7b5d5684aea2 [cipd] Permit unicode cipd tags (joshuaseaton@google.com)
  https://crrev.com/0aa0d59a984e8a2fbc99205ea3de860416bc5107 [isolated] Update path to isolated binary (joshuaseaton@google.com)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I65de819171bb0df2569529167a26ec05c07a3909
Reviewed-on: https://skia-review.googlesource.com/c/168441
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
2018-11-05 23:01:34 +00:00
Mike Reed
d9b16dfe71 add alternative setters for hinting
Bug: skia:2664
Change-Id: I77248d9012e44d6ed5de92731fb0769c61fd7298
Reviewed-on: https://skia-review.googlesource.com/c/168278
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Reed <reed@google.com>
2018-11-05 22:16:36 +00:00
Brian Osman
5a4f2a341a Revert "Use float colors for blend constant"
This reverts commit 52065473ee.

Reason for revert: Typo messed up LCD blending

Original change's description:
> Use float colors for blend constant
> 
> Bug: skia:
> Change-Id: Ie2a4b341a5e7762c3e8031fbd0f0d8b1ebae27f1
> Reviewed-on: https://skia-review.googlesource.com/c/168268
> Commit-Queue: Brian Osman <brianosman@google.com>
> Reviewed-by: Mike Klein <mtklein@google.com>

TBR=egdaniel@google.com,mtklein@google.com,bsalomon@google.com,brianosman@google.com

Change-Id: Ieaad5724099e18727296ce312d728a1a9ed45c4b
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: skia:
Reviewed-on: https://skia-review.googlesource.com/c/168362
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2018-11-05 21:35:26 +00:00