AuroraMiddleware/skia2
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
23,631 Commits 1 Branch 0 Tags 544 MiB
93f366d675
Commit Graph

125 Commits

Author SHA1 Message Date
rmistry
93f366d675 Add gerrit config lines to cq.cfg 
Needed for the CQ to see Gerrit. Eg:
https://cs.chromium.org/chromium/tools/depot_tools/infra/config/cq.cfg?q=cq.cfg&sq=package:chromium&dr=C&l=9

BUG=skia:5627
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2251643005

Review-Url: https://codereview.chromium.org/2251643005
 2016-08-17 07:51:57 -07:00
mtklein
8079ba688c GN: add extra_cflags et al. 
Adding flags to the end of cc or cxx is pretty useful, but these always end up
on the command line before the GN generated flags, thus setting defaults that
GN will override.

For full flexibility we want to be able to add flags after the flags GN has
added, so that custom flags can override _it_.

I've updated the Fast bots with an example here: if we said cc="clang -O3 ...",
that '-O3' would be overriden later by the default Release-mode '-Os'.  By
putting it in extra_cflags, we get the last word: our '-O3' overrides the
default '-Os'.

Another good use case is a hypothetical Actually-Shippable-Release mode.  Our
Release mode bundles in tons of debug symbols via '-g'.  libskia.a is about 10x
larger than it needs to be when built that way, but it helps us debug the bot
failures immensely.  To build a libskia.{a,so} that you'd really ship, you can
now set extra_cflags="-g0" to override '-g'.  You could set '-march' flags there
too, '-fomit-frame-pointer', etc.

There are lots of flags that won't matter where they end up in the command line.
To keep everything simple I've put them in extra_cflags with the rest.  This means
the only time we change 'cc' or 'cxx' in our recipes is to prefix 'ccache'.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2241263003

Review-Url: https://codereview.chromium.org/2241263003
 2016-08-16 09:31:16 -07:00
fmalita
b5b6de9b94 Disable Nebraska-StateSeal.svg on Win8 bots 
Temporary suppression, pending bug fix.

BUG=skia:5636
R=robertphillips@google.com,senorblanco@chromium.org
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2249763002

Review-Url: https://codereview.chromium.org/2249763002
 2016-08-16 07:08:48 -07:00
fmalita
9ea494afd0 Fix up infra bot change 
Follow up to https://codereview.chromium.org/2246943002/.

R=mtklein@google.com,robertphillips@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2247903002

Review-Url: https://codereview.chromium.org/2247903002
 2016-08-15 13:38:18 -07:00
fmalita
6fb0648c35 [SVGDom] Add opacity support 
Group opacity support.  Unlike the other presentation attributes we
support thus far, group opacity is not inherited.

R=robertphillips@google.com,stephana@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2246943002

Review-Url: https://codereview.chromium.org/2246943002
 2016-08-15 12:45:11 -07:00
rmistry
ea246cd5fb Increase hard and io timeouts for CT builds. 
BUG=skia:5641
TBR=borenet
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2249523004

Review-Url: https://codereview.chromium.org/2249523004
 2016-08-15 09:54:56 -07:00
mtklein
d5d3287fe2 Skip CompressCheckerboard unit test on N6. 
This is at least one of the failures making the bot red.
The particular signal indicates it's probably an alignment problem.

BUG=skia:5637
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2245063002

CQ_INCLUDE_TRYBOTS=master.client.skia.android:Test-Android-GCC-Nexus6-CPU-NEON-Arm7-Debug-Trybot

TBR=robertphillips@google.com

Review-Url: https://codereview.chromium.org/2245063002
 2016-08-15 07:47:57 -07:00
update-skps
1e4a389dbf Update SKP version 
Automatic commit by the RecreateSKPs bot.

TBR=
NO_MERGE_BUILDS
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2249443002

Review-Url: https://codereview.chromium.org/2249443002
 2016-08-14 01:56:40 -07:00
jcgregorio
106a9ff313 Add extracting GM comments to the housekeeper bot. 
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2237033002

Review-Url: https://codereview.chromium.org/2237033002
 2016-08-12 08:50:29 -07:00
rmistry
70c43efb6e Turn on SVGs for all Test bots 
BUG=skia:5628
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2240153002

Review-Url: https://codereview.chromium.org/2240153002
 2016-08-12 07:25:53 -07:00
rmistry
bcba19dd02 Use SVGs CIPD package and use SVG as a DM source. 
Currently only turned on for one bot. May turn it on for more after more conversations.

BUG=skia:5628

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2231943002

Review-Url: https://codereview.chromium.org/2231943002
 2016-08-11 12:36:58 -07:00
mtklein
18655efb7a GN: take over some exisiting bots 
As an experiment, instead of replacing these with -GN twins, take
them over in-place.  This should take over:

  -FAST
  -SKFOO

CQ_INCLUDE_TRYBOTS=master.client.skia:Perf-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-SK_USE_DISCARDABLE_SCALEDIMAGECACHE-Trybot,Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-SK_USE_DISCARDABLE_SCALEDIMAGECACHE-Trybot,Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot,Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Fast-Trybot

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2229463002

Review-Url: https://codereview.chromium.org/2229463002
 2016-08-11 07:51:53 -07:00
rmistry
d71fe83ac2 Update VERSION of "svg" asset. 
Removing the SVG due to the reason in https://docs.google.com/document/d/1kYRvUxZTnm1tI_0bTU0BX9jqSSTqPUhGXJVcD3Rcg2c/edit?disco=AAAAAqQSPSc

BUG=skia:5628
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2232003002

Review-Url: https://codereview.chromium.org/2232003002
 2016-08-10 16:36:15 -07:00
jcgregorio
9d155afef4 Package Go 1.6.2 in CIPD 
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2230853003

Review-Url: https://codereview.chromium.org/2230853003
 2016-08-10 08:44:44 -07:00
rmistry
d1cfb5bebe Add "svg" asset 
BUG=skia:5628
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2235763002

Review-Url: https://codereview.chromium.org/2235763002
 2016-08-10 07:23:51 -07:00
rmistry
5eab99183c Move ct_skps recipe from tools repo to Skia repo. 
Also move the isolate file and script from Chromium repo to the Skia repo.

BUG=skia:5620
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2221413002

Review-Url: https://codereview.chromium.org/2221413002
 2016-08-09 13:46:48 -07:00
rmistry
3df72283ee Use slave_build instead of checkout in run/api.py 
BUG=skia:5620
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2221423002

Review-Url: https://codereview.chromium.org/2221423002
 2016-08-09 11:15:57 -07:00
borenet
1413d52c53 Speculative fix for SKP partner-dir upload 
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2229433002

Review-Url: https://codereview.chromium.org/2229433002
 2016-08-08 06:26:00 -07:00
borenet
dfa55f2db4 [recipes] Smush the rest of builder_spec into appropriate places, other cleanup 
BUG=skia:5578
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2219873003

Review-Url: https://codereview.chromium.org/2219873003
 2016-08-08 04:34:01 -07:00
mtklein
03591a762c finish SkLiteDL 
- makeThreadsafe()
    - fix up some alignment problems
    - drawVertices / drawPatch
    - work around drawPicture() + default paint bugs?
    - turn on tests.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2219343002

Review-Url: https://codereview.chromium.org/2219343002
 2016-08-07 13:35:47 -07:00
update-skps
dad1aef9a8 Update SKP version 
Automatic commit by the RecreateSKPs bot.

TBR=
NO_MERGE_BUILDS
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2220833002

Review-Url: https://codereview.chromium.org/2220833002
 2016-08-07 01:52:47 -07:00
borenet
2c3112d517 [recipes] Increase test coverage 
Remove a bunch of "pragma: no cover" by removing unused code or adding test bots to cover.

BUG=skia:5578
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2215443003

Review-Url: https://codereview.chromium.org/2215443003
 2016-08-05 06:30:10 -07:00
borenet
e2251acbaa [recipes] Separate builder_spec into compile/test/perf recipes 
BUG=skia:5578
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2205473002

Review-Url: https://codereview.chromium.org/2205473002
 2016-08-05 05:40:59 -07:00
borenet
d460a3c256 [recipes] Remove build environment vars from default_env 
BUG=skia:5578
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2209423002

Review-Url: https://codereview.chromium.org/2209423002
 2016-08-05 05:18:06 -07:00
msarett
b8d1aac87a Create a separate src for colorspace tests 
This will allow me to run these tests in sRGB mode, while
leaving most of the image tests disabled.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2206953006

Review-Url: https://codereview.chromium.org/2206953006
 2016-08-04 12:22:06 -07:00
borenet
3f5a47599b [recipes] Fixes for Coverage bot 
BUG=skia:5578
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2217523002

Review-Url: https://codereview.chromium.org/2217523002
 2016-08-04 12:16:03 -07:00
borenet
c7233ef925 [recipes] Stop pretending that buildbot_spec is a step, simplify 
Since we no longer have to call out to obtain the buildbot_spec, merge
the two functions in vars API.  As a side effect, this applies
default_env to the sync steps as well, which shouldn't have an
appreciable effect on bot behavior.

BUG=skia:5578
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2209343002

Review-Url: https://codereview.chromium.org/2209343002
 2016-08-04 11:33:02 -07:00
borenet
538d5b68e8 Move builder_spec, [dm|nanobench]_flags, builder_name_schema to recipes 
- builder_name_schema becomes its own recipe module.
- builder_spec, dm, and nanobench flags move into vars module.
- recipe expectation diffs include:
  - no more buildbot_spec.py step
  - "real" dm and nanobench flags, instead of --dummy-flags
  - some inconsequential stuff in visualbench, which is removed anyway.

BUG=skia:5578
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2215803002

Review-Url: https://codereview.chromium.org/2215803002
 2016-08-04 11:07:10 -07:00
msarett
6fc699aab7 Update skimage VERSION: attempt 3 
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2211973002

Review-Url: https://codereview.chromium.org/2211973002
 2016-08-04 10:39:22 -07:00
mtklein
691b78423e Slim the CQ down to the GN bots, where they exist. 
If no one objects to my "GN bot plan" email, this unblocks us from removing
a bunch of non-GN bots.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2207073002

CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-GN-Trybot,Test-Ubuntu-GCC-ShuttleA-GPU-GTX660-x86_64-Release-GN-Trybot

Review-Url: https://codereview.chromium.org/2207073002
 2016-08-04 09:47:38 -07:00
msarett
2825bad08c Revert of Update skimage VERSION: attempt 2 (patchset #1 id:1 of https://codereview.chromium.org/2213973002/ ) 
Reason for revert:
Think this is going to break Windows again.

Original issue's description:
> Update skimage VERSION: attempt 2
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2213973002
>
> Committed: https://skia.googlesource.com/skia/+/d6dec3f4a1365d34e147234acf3c4a3629146457

TBR=borenet@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review-Url: https://codereview.chromium.org/2216523003
 2016-08-04 07:46:44 -07:00
msarett
d6dec3f4a1 Update skimage VERSION: attempt 2 
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2213973002

Review-Url: https://codereview.chromium.org/2213973002
 2016-08-04 07:29:09 -07:00
borenet
aa6a80526f Revert of Update to new skimage VERSION (patchset #1 id:1 of https://codereview.chromium.org/2211633002/ ) 
Reason for revert:
The CIPD package is broken

Original issue's description:
> Update to new skimage VERSION
> TBR=borenet@google.com
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2211633002
>
> Committed: https://skia.googlesource.com/skia/+/52d1be5ca7b1ba8cc450be7dd6377ea5bb73386a

TBR=msarett@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review-Url: https://codereview.chromium.org/2216613002
 2016-08-04 04:47:23 -07:00
msarett
52d1be5ca7 Update to new skimage VERSION 
TBR=borenet@google.com
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2211633002

Review-Url: https://codereview.chromium.org/2211633002
 2016-08-03 15:48:32 -07:00
borenet
bc20a701d8 [Recipes] Move test and perf steps into test and perf recipes 
This looks like another big change, but I really just moved blocks of code around.  Again, no expectations diffs because no behavior is changed.

BUG=skia:5578
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2198973002

Review-Url: https://codereview.chromium.org/2198973002
 2016-08-03 10:38:44 -07:00
borenet
9e3d3d8b36 Fix fake_specs.py, update recipe expectation 
BUG=skia:5578
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2200763002

Review-Url: https://codereview.chromium.org/2200763002
 2016-08-03 10:10:07 -07:00
borenet
1436a09e1f Re-organize Skia recipes 
Break Skia recipe module into:
  - skia_vars: defines and stores variables (eg. paths)
  - skia_step: utilities for running Skia steps
  - skia_flavor: flavor-specific stuff
  - skia: top-level setup, checkout, test/perf steps, etc etc

This establishes a saner dependency structure for the recipes; skia_vars
is at the bottom level, skia_step depends on it, skia_flavor depends on
both of them, skia depends on all of the above, and the recipes
themselves may depend on any or all of them.

Next steps:
  - Merge buildbot_spec into skia_vars
  - Move test_steps and perf_steps from skia recipe_module into
    swarm_test and swarm_perf recipes
  - Cleaner checkout_steps process

BUG=skia:5578
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2198173002

Review-Url: https://codereview.chromium.org/2198173002
 2016-08-03 08:23:10 -07:00
borenet
b6aafe66a0 Fix Chrome build for RecreateSKPs and CommandBuffer bots for GYP->GN 
BUG=skia:5597
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2199273002

Review-Url: https://codereview.chromium.org/2199273002
 2016-08-02 07:02:52 -07:00
borenet
ed696276fd More fixes for SwarmBucket 
BUG=skia:5581
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2202053005
NOTRY=true

Review-Url: https://codereview.chromium.org/2202053005
 2016-08-02 06:50:50 -07:00
borenet
d6dd44140d Roll recipe DEPS 
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2205863002

Review-Url: https://codereview.chromium.org/2205863002
 2016-08-02 05:11:16 -07:00
borenet
f5b675efbe Stop running nanobench on Test.*Debug bots 
We'll need to add Perf.*Debug bots to achieve the same coverage.

BUG=skia:4768
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2189393002
NOTREECHECKS=true

Review-Url: https://codereview.chromium.org/2189393002
 2016-08-01 05:08:52 -07:00
jcgregorio
01f696e30f perf: Upload results to gs://skia-perf, not gs://chromium-skia-gm. 
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2197643002

Review-Url: https://codereview.chromium.org/2197643002
 2016-07-29 10:54:30 -07:00
mtklein
f6593a68d9 Add some GN builders to the CQ. 
This parallels the set of bots we use to gate commits already.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2189283003

Review-Url: https://codereview.chromium.org/2189283003
 2016-07-29 10:41:37 -07:00
mtklein
830c913625 GN: ccache+clang needs -Qunused-arguments 
An alternative is to define CCACHE_CPP2, but
I thought I'd try this more visible way first.

(CCACHE_CPP2 may turn out to be required anyway
if we start seeing warnings about tautological compares.)

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2193203002

TBR=jcgregorio@google.com
NOTRY=true

Review-Url: https://codereview.chromium.org/2193203002
 2016-07-29 06:03:52 -07:00
mtklein
2a1134e3f5 GN: Always quote cc and cxx. 
To fix:
    ERROR at the command-line "--args":1:34: Unexpected token '+'
    is_debug=true cc=clang cxx=clang++

TBR=jcgregorio@google.com
NOTRY=true

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2193593003

Review-Url: https://codereview.chromium.org/2193593003
 2016-07-29 05:39:35 -07:00
mtklein
9081ceb123 GN: use ccache if available and the requested compiler. 
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2186553006

Review-Url: https://codereview.chromium.org/2186553006
 2016-07-29 05:07:39 -07:00
jcgregorio
50d1847815 Fix expectations for GN bot. 
BUG=skia:

Review-Url: https://codereview.chromium.org/2191933002
 2016-07-28 11:55:51 -07:00
borenet
f49d9d77bb Add swarmbucket_wrapper recipe 
BUG=skia:5581
NOTRY=true
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2185203003

Review-Url: https://codereview.chromium.org/2185203003
 2016-07-28 10:50:54 -07:00
jcgregorio
ba59595ea3 recipes: Add a GN flavor. 
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2189713003

Review-Url: https://codereview.chromium.org/2189713003
 2016-07-28 09:38:59 -07:00
borenet
9c18546b78 Fixes for SwarmBucket bot 
- Print all build properties for debugging purposes.
- Use correct path root for swarmbucket.
- Write a dummy .gclient file if missing.

BUG=skia:5581
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2190933002

Review-Url: https://codereview.chromium.org/2190933002
 2016-07-28 08:58:38 -07:00