Commit Graph

507 Commits

Author SHA1 Message Date
senorblanco@chromium.org
9d6e7e5b13 Rebaselines for stragglers (Nexus4 Debug looks like it was really stale.)
TBR=fmalita@chromium.org
BUG=skia:

Review URL: https://codereview.chromium.org/148253008

git-svn-id: http://skia.googlecode.com/svn/trunk@13337 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-02-06 13:39:48 +00:00
senorblanco@chromium.org
c01eeb30d7 Add new baselines for tests affected by https://code.google.com/p/skia/source/detail?r=13323, namely:
colorfilterimagefilter
dropshadowimagefilter
imageblur
imageblur_large
imagefiltersbase
imagefilterscropped
imagefiltersgraph
imagefiltersscaled
morphology
offsetimagefilter
spritebitmap
xfermodeimagefilter

TBR=fmalita@chromium.org

Review URL: https://codereview.chromium.org/156243003

git-svn-id: http://skia.googlecode.com/svn/trunk@13335 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-02-06 01:04:50 +00:00
bsalomon@google.com
d2e88f67c9 Rebase gpu images on N4 where persp rect clip is handled by convex poly clip effect.
BUG=skia:2136

Review URL: https://codereview.chromium.org/156203002

git-svn-id: http://skia.googlecode.com/svn/trunk@13329 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-02-05 22:29:35 +00:00
bsalomon@google.com
78bfa79ebf More canvas-state GM rebaselines
BUG=skia:2051

Review URL: https://codereview.chromium.org/150573015

git-svn-id: http://skia.googlecode.com/svn/trunk@13327 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-02-05 20:44:56 +00:00
bsalomon@google.com
d2184d61d1 canvas-state GM rebaselines after r13320.
BUG=skia:2051

Review URL: https://codereview.chromium.org/138833008

git-svn-id: http://skia.googlecode.com/svn/trunk@13326 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-02-05 20:34:44 +00:00
senorblanco@chromium.org
c4b12f19a4 Implement correct clipping for image filters.
Image filters in Skia currently clip the size of the the offscreen
bitmap used for filtering to the device clip bounds. This means that
any pixel-moving filter (e.g., blur) has edge artifacts at the clip
boundaries. This is problematic for tiling, where a single SkPicture
is played back with a clip set to the tile boundaries.

By implementing the onFilterBounds() traversal, and using it in
saveLayer() when a filter is present, we can clip the layer to the
expanded clip rect. Note that this requires that the traversal be
performed in reverse as compared to computeFastBounds().  (It's also
done in device space, unlike computeFastBounds()).

New test imagefiltersclipped tests pixel-moving filters when clipped
by various clip rects.
New test imageblurtiled tests tiled (compositor-style) rendering of
blurred text. There should be no artifacts at the tile boundaries.

BUG=337831
R=reed@google.com

Review URL: https://codereview.chromium.org/23011012

git-svn-id: http://skia.googlecode.com/svn/trunk@13323 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-02-05 17:51:22 +00:00
reed@google.com
76f10a3bd9 remove SkCanvas::createCompatibleDevice, and add SkCanvas::newSurface
BUG=skia:
R=bsalomon@google.com

Review URL: https://codereview.chromium.org/154163002

git-svn-id: http://skia.googlecode.com/svn/trunk@13319 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-02-05 15:32:21 +00:00
robertphillips@google.com
f48a90c06f Ignore failures on GalaxyNexus and NexusS
https://codereview.chromium.org/154223002/



git-svn-id: http://skia.googlecode.com/svn/trunk@13312 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-02-04 20:26:04 +00:00
commit-bot@chromium.org
65ee5f424c Use GrConvexPolyEffect when clip is a single convex polygon
BUG=skia:2051

Committed: http://code.google.com/p/skia/source/detail?r=13286

R=robertphillips@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/151523005

git-svn-id: http://skia.googlecode.com/svn/trunk@13306 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-02-04 17:49:48 +00:00
bsalomon@google.com
d3066bd9b4 Revert of Use GrConvexPolyEffect when clip is a single convex polygon (https://codereview.chromium.org/151523005/)
Reason for revert:
unit tests crashing on windows?

Original issue's description:
> Use GrConvexPolyEffect when clip is a single convex polygon
>
> BUG=skia:2051
>
> Committed: http://code.google.com/p/skia/source/detail?r=13286

TBR=robertphillips@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:2051

Review URL: https://codereview.chromium.org/142443006

git-svn-id: http://skia.googlecode.com/svn/trunk@13288 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-02-03 20:09:56 +00:00
commit-bot@chromium.org
e89d903378 Use GrConvexPolyEffect when clip is a single convex polygon
BUG=skia:2051
R=robertphillips@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/151523005

git-svn-id: http://skia.googlecode.com/svn/trunk@13286 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-02-03 19:42:42 +00:00
fmalita@google.com
c048afc3df Rebaseline imagefiltersgraph_gpu (Test-Mac10.6-MacMini4.1-GeForce320M-x86-Release)
BUG=skia:2118
TBR=senorblanco@chromium.org

Review URL: https://codereview.chromium.org/148283012

git-svn-id: http://skia.googlecode.com/svn/trunk@13281 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-02-03 17:58:31 +00:00
commit-bot@chromium.org
c6ba74cb56 hopefully last set of rebaselines for blurrect
BUG=skia:2108
R=epoger@google.com
TBR=epoger

Author: humper@google.com

Review URL: https://codereview.chromium.org/152803002

git-svn-id: http://skia.googlecode.com/svn/trunk@13280 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-02-03 15:11:48 +00:00
commit-bot@chromium.org
973d1211c6 rebaselines for https://skia.googlesource.com/skia.git/+/0b9ada1318acf7d5fe90c57331c2a4548aad8b98
BUG=skia:2113

NOTREECHECKS=True
NOTRY=True
R=epoger@google.com

Author: reed@google.com

Review URL: https://codereview.chromium.org/151623002

git-svn-id: http://skia.googlecode.com/svn/trunk@13268 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-31 17:05:33 +00:00
commit-bot@chromium.org
4fbac292ab remaining rebaselines for rects GM test
BUG=skia:2108
NOTREECHECKS=True
NOTRY=True
R=humper@google.com
TBR=humper

Author: epoger@google.com

Review URL: https://codereview.chromium.org/148483005

git-svn-id: http://skia.googlecode.com/svn/trunk@13267 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-31 16:52:15 +00:00
commit-bot@chromium.org
1da3bc6d4c remaining GM rebaselines for blurquickreject and megalooper tests
BUG=skia:2108
NOTREECHECKS=True
NOTRY=True
R=humper@google.com
TBR=humper

Author: epoger@google.com

Review URL: https://codereview.chromium.org/134923007

git-svn-id: http://skia.googlecode.com/svn/trunk@13266 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-31 16:47:18 +00:00
bsalomon@google.com
2739684716 Rebase simpleblurroundrect and bleed GMs after GPU blur radius changes.
BUG=skia:1998

Review URL: https://codereview.chromium.org/151503005

git-svn-id: http://skia.googlecode.com/svn/trunk@13263 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-31 15:17:34 +00:00
commit-bot@chromium.org
b5302b2cb4 even more rebaselines for blur
BUG=skia:2108
R=epoger@google.com

Author: humper@google.com

Review URL: https://codereview.chromium.org/149823003

git-svn-id: http://skia.googlecode.com/svn/trunk@13255 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-30 23:10:41 +00:00
commit-bot@chromium.org
7d7e5bc296 mark imageblur_gpu gm tests as ignore-failure on IntelRhb
BUG=skia:2085
NOTRY=True
R=senorblanco@google.com
TBR=senorblanco

Author: epoger@google.com

Review URL: https://codereview.chromium.org/150813002

git-svn-id: http://skia.googlecode.com/svn/trunk@13250 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-30 22:08:36 +00:00
commit-bot@chromium.org
3f01449afe remove GM expectations for all ASAN/Valgrind builders
BUG=skia:2112
NOTRY=True
R=borenet@google.com

Author: epoger@google.com

Review URL: https://codereview.chromium.org/140323020

git-svn-id: http://skia.googlecode.com/svn/trunk@13248 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-30 22:00:56 +00:00
commit-bot@chromium.org
59a43f46fa more blurrect rebaselines
BUG=skia:2108
R=epoger@google.com

Author: humper@google.com

Review URL: https://codereview.chromium.org/136813005

git-svn-id: http://skia.googlecode.com/svn/trunk@13247 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-30 21:07:33 +00:00
commit-bot@chromium.org
844c3dc6a8 create empty expectations for Logan bots
BUG=skia:2107
NOTRY=True
R=borenet@google.com

Author: epoger@google.com

Review URL: https://codereview.chromium.org/150543004

git-svn-id: http://skia.googlecode.com/svn/trunk@13246 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-30 19:22:33 +00:00
commit-bot@chromium.org
fd1fdfc3a5 rebaseline GM changes resulting from fast GPU blur algorithm
BUG=skia:
R=bsalomon@google.com

Author: humper@google.com

Review URL: https://codereview.chromium.org/150493005

git-svn-id: http://skia.googlecode.com/svn/trunk@13243 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-30 18:17:06 +00:00
commit-bot@chromium.org
fd191a135f rebaseline imagefiltersgraph_gpu GMs on Nexus10
BUG=skia:2106
NOTREECHECKS=True
NOTRY=True
R=bsalomon@google.com
TBR=bsalomon

Author: epoger@google.com

Review URL: https://codereview.chromium.org/150113003

git-svn-id: http://skia.googlecode.com/svn/trunk@13241 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-30 17:59:22 +00:00
commit-bot@chromium.org
cf34bc0634 patch from issue 119343003
compile on 10.6, exclude failing gms

Sorry for making another CL; rebasing ToT on the old one ended up with code in a tangled mess; was easier to start over.

NOTRY=true
R=bsalomon@google.com, epoger@google.com, reed@google.com

Author: humper@google.com

Review URL: https://codereview.chromium.org/148883005

git-svn-id: http://skia.googlecode.com/svn/trunk@13238 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-30 15:34:43 +00:00
senorblanco@chromium.org
09dd1abc54 Win8 baselines for displacement GM (razzin' frazzin' --keep-going-on-failure).
TBR=epoger
BUG=skia:

Review URL: https://codereview.chromium.org/149073008

git-svn-id: http://skia.googlecode.com/svn/trunk@13232 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-29 22:28:26 +00:00
senorblanco@chromium.org
200d75c074 New baselines for displacement GM.
This had a new test case added in r12773.

TBR=epoger@google.com
BUG=skia:

Review URL: https://codereview.chromium.org/143263020

git-svn-id: http://skia.googlecode.com/svn/trunk@13231 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-29 21:41:39 +00:00
senorblanco@chromium.org
7824768e5e New baselines for GM tests affected by r13221.
The following tests were affected:

imagefiltersbase
imagefilterscropped
imagefiltersgraph
imagefiltersscaled
dropshadowimagefilter
offsetimagefilter
spritebitmap
tileimagefilter

TBR=epoger@google.com
BUG=skia:

Review URL: https://codereview.chromium.org/148283008

git-svn-id: http://skia.googlecode.com/svn/trunk@13230 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-29 20:00:54 +00:00
commit-bot@chromium.org
6df2f2b539 Rebaslines for https://codereview.chromium.org/23835006/
Signed-off-by: Kévin PETIT <kevin.petit@arm.com>

BUG=skia:
R=djsollen@google.com, mtklein@google.com, reed@google.com

Author: kevin.petit.arm@gmail.com

Review URL: https://codereview.chromium.org/137833005

git-svn-id: http://skia.googlecode.com/svn/trunk@13229 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-29 11:48:31 +00:00
senorblanco@chromium.org
78cf11980d Give correct bounds to SkCanvas's AutoDrawLooper use for filter draws.
In conjuction with https://codereview.chromium.org/137423005/, this allows the canvas to tighten the bounds passed to saveLayer() only the affected region.

R=reed@google.com
BUG=100703

Review URL: https://codereview.chromium.org/141433017

git-svn-id: http://skia.googlecode.com/svn/trunk@13221 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-28 19:22:35 +00:00
commit-bot@chromium.org
a96176dc03 ARM Skia NEON patches - 20 - New improved BitmapProcState code
BitmapProcState: new factorised code

This one basically factorises the clamp and repeat transformations with
some performance improvements. It has the benefit of being faster, much
easier to maintain (nearly three times less code for more work
done :-)), and more complete (all persp transformations weren't optimised
in the previous version).

It also introduces the use of can_truncate_to_fixed_for_decal where
useful.

The effect on benchmarks ranges from a 5% penalty to a 25% gain on a
Cortex-A9 and from a 5% penalty to a 100% gain on a Cortex-A15.

Signed-off-by: Kévin PETIT <kevin.petit@arm.com>

BUG=
R=djsollen@google.com, mtklein@google.com, luisjoseromeroesclusa@hotmail.com, reed@google.com

Author: kevin.petit.arm@gmail.com

Review URL: https://codereview.chromium.org/23835006

git-svn-id: http://skia.googlecode.com/svn/trunk@13218 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-28 15:18:54 +00:00
senorblanco@chromium.org
619ba7434a Trying once again to rebaseline IntelRhb bots.
This seems to be putting the hashes back to what they were at r13191, so if this doesn't work I'm going to call flake and suppress the failures.

TBR=epoger@google.com

Review URL: https://codereview.chromium.org/148573003

git-svn-id: http://skia.googlecode.com/svn/trunk@13205 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-27 20:47:11 +00:00
commit-bot@chromium.org
d15d469a6e Revert "Revert of nvpr baselines (https://codereview.chromium.org/132333008/)"
BUG=skia:2042

TBR=robertphillips@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/131513012

git-svn-id: http://skia.googlecode.com/svn/trunk@13202 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-27 19:45:02 +00:00
senorblanco@chromium.org
f532e01e4c Rebaseline imageblur on IntelRhb Debug.
TBR=epoger@google.com
BUG=skia:

Review URL: https://codereview.chromium.org/148263004

git-svn-id: http://skia.googlecode.com/svn/trunk@13201 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-27 18:15:49 +00:00
commit-bot@chromium.org
be39f37e11 Revert of nvpr baselines (https://codereview.chromium.org/132333008/)
Reason for revert:
broke the build

Original issue's description:
> nvpr baselines
> 
> BUG=skia:2042
> 
> Committed: https://code.google.com/p/skia/source/detail?r=13195

TBR=
NOTREECHECKS=true
NOTRY=true
BUG=skia:2042

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/148013003

git-svn-id: http://skia.googlecode.com/svn/trunk@13198 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-27 18:05:21 +00:00
senorblanco@chromium.org
dd13af8449 New baselines for Win7 DirectWrite (shader2 and bezier_conic) and Intel Rhb (imagefiltersbase and imageblur). All failures are pixel intensity mismatch <= 3.
BUG=skia:2085,skia:2081
TBR=epoger@google.com

Review URL: https://codereview.chromium.org/138623007

git-svn-id: http://skia.googlecode.com/svn/trunk@13197 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-27 17:51:12 +00:00
bsalomon@google.com
0655389978 nvpr baselines
BUG=skia:2042

Review URL: https://codereview.chromium.org/132333008

git-svn-id: http://skia.googlecode.com/svn/trunk@13195 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-27 17:04:00 +00:00
senorblanco@chromium.org
b3bf362ce2 Rebaseline some GPU and ANGLE results which started failing on Win7.
BUG=skia:2081
TBR=epoger@google.com

Review URL: https://codereview.chromium.org/135593005

git-svn-id: http://skia.googlecode.com/svn/trunk@13193 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-27 16:22:36 +00:00
senorblanco@chromium.org
83c39db913 Remove misc. suppressions from ignored-tests.txt added in https://codereview.chromium.org/105893003. These tests were rebaselined shortly after that patch landed, but the suppressions weren't removed, so differences have snuck in and not been rebaselined.
New Android baselines for imagefiltersgraph, imagefilterscropped, imagefiltersbase, imageblur GMs.
New Nexus4 baselines for testimagefilters, spritebitmap GM.

R=borenet@google.com
TBR=borenet, bungeman
BUG=skia:

Review URL: https://codereview.chromium.org/141033008

git-svn-id: http://skia.googlecode.com/svn/trunk@13191 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-27 15:05:39 +00:00
bsalomon@google.com
2865839f45 rebaselines from NVPR enable and nexus4 blur radius
BUG=skia:2042

Review URL: https://codereview.chromium.org/146593003

git-svn-id: http://skia.googlecode.com/svn/trunk@13186 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-26 17:51:22 +00:00
commit-bot@chromium.org
d8ed85101e Turn NVPR on by default (but off in tools).
BUG=skia:2042

Committed: http://code.google.com/p/skia/source/detail?r=13164

R=robertphillips@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/144003006

git-svn-id: http://skia.googlecode.com/svn/trunk@13176 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-24 20:49:44 +00:00
halcanary@google.com
68c74884d0 Revert "Turn NVPR on by default (but off in tools)."
This reverts commit 83d81c96de.

Broke Windows build.  Autorevert didn't work.

TBR=bsalomon@google.com,robertphillips@google.com
NOTREECHECKS=true
NOTRY=true
NOPRESUBMIT=true
BUG=skia:2042

Review URL: https://codereview.chromium.org/146863003

git-svn-id: http://skia.googlecode.com/svn/trunk@13169 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-24 16:04:09 +00:00
senorblanco@chromium.org
0903c3473c Add new baselines for imagefiltersscaled GM.
TBR=borenet

Review URL: https://codereview.chromium.org/145993005

git-svn-id: http://skia.googlecode.com/svn/trunk@13166 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-24 15:02:11 +00:00
commit-bot@chromium.org
83d81c96de Turn NVPR on by default (but off in tools).
BUG=skia:2042
R=robertphillips@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/144003006

git-svn-id: http://skia.googlecode.com/svn/trunk@13164 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-24 14:38:13 +00:00
bungeman@google.com
1b532f1231 Rebaselines for r13156.
There seems to be an issue where expectations are missing from storage.
Either they didn't actually upload, we pointed at the wrong one.


git-svn-id: http://skia.googlecode.com/svn/trunk@13162 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-23 23:34:38 +00:00
bungeman@google.com
3bfd12d881 Rebaselines for r13156.
The thing blurred in imageblur is actually text.
Who knew?


git-svn-id: http://skia.googlecode.com/svn/trunk@13161 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-23 23:25:19 +00:00
skia.committer@gmail.com
8f7ed2cfd8 Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@13160 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-23 22:26:04 +00:00
bungeman@google.com
5aa1116177 Rebaselines for r13156.
These are for affected baselines which are now failing,
but the expected image appears to be unavailable.


git-svn-id: http://skia.googlecode.com/svn/trunk@13159 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-23 22:24:41 +00:00
bungeman@google.com
5a246719a5 Rebaseline for r13156.
git-svn-id: http://skia.googlecode.com/svn/trunk@13158 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-23 22:19:16 +00:00
commit-bot@chromium.org
764ea79201 Rename Logan skimage expectations: .jon -> .json
BUG=skia:
R=scroggo@google.com

Author: borenet@google.com

Review URL: https://codereview.chromium.org/144253002

git-svn-id: http://skia.googlecode.com/svn/trunk@13135 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-21 20:03:09 +00:00