No-Try: true
Change-Id: Ief4e48a6bc2f126b31af3e8a381f8a6d5a73d523
Reviewed-on: https://skia-review.googlesource.com/117083
Reviewed-by: Mike Klein <mtklein@chromium.org>
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
Valgrind doesn't support half<->float x86 conversion instructions,
so we build those bots with SK_CPU_LIMIT_SSE41. We now also need
to limit skcms on those same bots.
Easiest thing to do is build completely portable scalar code, using
the existing -DSKCMS_PORTABLE. We can get fancier later if needed.
Change-Id: Icf14c72a220818be9df7b97bcf203e4412c3c6b7
Reviewed-on: https://skia-review.googlesource.com/118264
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>
I don't believe any of these have any effect now that all
builds are done through GN. My best recollection is that
they used to affect GYP-based builds.
Change-Id: Ifde9f7c4d531dab43e8d407fc779d2ab6e38411c
Reviewed-on: https://skia-review.googlesource.com/118263
Commit-Queue: Mike Klein <mtklein@chromium.org>
Reviewed-by: Eric Boren <borenet@google.com>
This reverts commit e027e19477.
Reason for revert: capacity problem resolved
Original change's description:
> Temporarily remove Win10 QuadroP400 from CQ.
>
> This tryjob is currently just experimental/non-blocking, and we are
> severely short on capacity due to chromium:821040.
>
> Bug: chromium:821040
> Change-Id: I36b193cecd4f7ecf4c6f5769e869ee37a1285582
> No-Try: true
> Reviewed-on: https://skia-review.googlesource.com/114221
> Reviewed-by: Eric Boren <borenet@google.com>
> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
TBR=borenet@google.com,benjaminwagner@google.com
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: chromium:821040
Change-Id: Idf305b56bc511b1072c6b7c524c963efd35a643c
Reviewed-on: https://skia-review.googlesource.com/117661
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
Bug: skia:
Change-Id: If7eec995d8683ef6cd7c90db11bc28d777ef2e56
NOTRY=true
Reviewed-on: https://skia-review.googlesource.com/117635
Reviewed-by: Greg Daniel <egdaniel@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
This reverts commit d234c9e6b9.
Reason for revert: GM/TSAN unhappiness
Original change's description:
> Switch bots to use ViaDDL (i.e., ddl-gl) instead of old --ddl flag
>
> Change-Id: I9c5f27bacf7d9fa7a9ac123379e2556913810cba
> Reviewed-on: https://skia-review.googlesource.com/116464
> Reviewed-by: Eric Boren <borenet@google.com>
> Commit-Queue: Robert Phillips <robertphillips@google.com>
TBR=borenet@google.com,robertphillips@google.com
Change-Id: I95388ee582bdd9561b8ebf24250f58b361657b7c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/116621
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
Change-Id: I9c5f27bacf7d9fa7a9ac123379e2556913810cba
Reviewed-on: https://skia-review.googlesource.com/116464
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
To run on these older bots, looks like we need to statically link
libstdc++ and libgcc. Luckily that is straightforward.
Change-Id: If523067df196e943c2ba2f64c52eea0711dbfcbd
Reviewed-on: https://skia-review.googlesource.com/115743
Commit-Queue: Mike Klein <mtklein@chromium.org>
Reviewed-by: Ravi Mistry <rmistry@google.com>
Bug: skia:
Change-Id: Ie72dee00c5160ce329c74a12d64bc68ce264c1bf
Reviewed-on: https://skia-review.googlesource.com/115990
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Joe Gregorio <jcgregorio@google.com>
No-Try: true
Change-Id: Iaf292ac9875312d3f1fcc81fdc64c3c587f68286
Reviewed-on: https://skia-review.googlesource.com/113674
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
BUG=chromium:731979
Change-Id: Ief5917b06e6c9164cc3bccdd89da169d1e169ba7
Reviewed-on: https://skia-review.googlesource.com/115703
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
Should be used for running karma tests on skia-elements and also
for running lottiecap on bots.
Bug: skia:
Change-Id: I5c48cb741017be4eda014faea77ab88dec2e9637
Reviewed-on: https://skia-review.googlesource.com/115622
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Joe Gregorio <jcgregorio@google.com>
Change-Id: Icbbbe7275cf9bc62cbc175d4453affa12ded495a
Reviewed-on: https://skia-review.googlesource.com/115526
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
BUG=chromium:815092
Change-Id: I7ec1d448c94bbdb6931fb315d6daf3d882430497
Reviewed-on: https://skia-review.googlesource.com/115362
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
Change-Id: I0d1aa9a137809349e34ab773b5ee41b69e813f9e
Reviewed-on: https://skia-review.googlesource.com/115220
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
In compile recipes, add a dummy define (e.g.
-DDUMMY_clang_linux_version=42) to the compiler flags so that ninja will
recompile from scratch when the toolchain changes.
Bug: skia:7720
Change-Id: I9a330b21af364b3aa6a1eebbe6ac2022cfa82fdc
Reviewed-on: https://skia-review.googlesource.com/115160
Reviewed-by: Eric Boren <borenet@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
Bug: skia:7720
Change-Id: I044ca5281354b21c9deffa408ad7ec20c51d2e2e
Reviewed-on: https://skia-review.googlesource.com/115122
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
This reverts commit be5947c2f3.
Bug: skia:
Change-Id: I06dc15b31042d7827511d0ac2a7f4262c3f09622
Reviewed-on: https://skia-review.googlesource.com/115079
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
This reverts commit c9a642edf2.
Reason for revert: 1010102 gms broke
Original change's description:
> New read pixels implementation that is simpler but does all conversions on CPU.
>
> Change-Id: Ia548cd24a8544b35a233311706faf48de353b7cf
> Reviewed-on: https://skia-review.googlesource.com/109902
> Commit-Queue: Brian Salomon <bsalomon@google.com>
> Reviewed-by: Robert Phillips <robertphillips@google.com>
TBR=bsalomon@google.com,robertphillips@google.com,brianosman@google.com
Change-Id: I7724a6eef79885ba2a32c1ac871e5b2a9a3c0c12
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/115140
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
Bug: skia:7050
Change-Id: I53b141bf76ab4773909df968f69ba04dc29e0dc9
Reviewed-on: https://skia-review.googlesource.com/114960
Reviewed-by: Ravi Mistry <rmistry@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
This reverts commit 2ab6f7e580.
Reason for revert: Server back with more cores
Original change's description:
> Remove Android Framework bot from CQ while server is being upgraded
>
> NoTry: true
> Bug: skia:7716
> Change-Id: I67695c5f45ac5b9c57d0599ba2ab2e825fa75e4b
> Reviewed-on: https://skia-review.googlesource.com/114788
> Reviewed-by: Ravi Mistry <rmistry@google.com>
> Reviewed-by: Ben Wagner <benjaminwagner@google.com>
> Commit-Queue: Ravi Mistry <rmistry@google.com>
> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
TBR=benjaminwagner@google.com,rmistry@google.com
Change-Id: I01626d9a4de98a27a350b053cb1aa7612d71d136
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: skia:7716
Reviewed-on: https://skia-review.googlesource.com/114820
Reviewed-by: Ravi Mistry <rmistry@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
Bug: skia:
Change-Id: Id4c613385a6948af9808dfbaef8f437e765fb9b5
Reviewed-on: https://skia-review.googlesource.com/114571
Commit-Queue: Ravi Mistry <rmistry@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
Change-Id: If9402ad5a3ae7d17221cf1bca621b8aad4d9e9d0
Reviewed-on: https://skia-review.googlesource.com/114466
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
Bug: skia:
Change-Id: I1eca549d38b64869a763951b8469712d620e24bf
Reviewed-on: https://skia-review.googlesource.com/114516
Reviewed-by: Ravi Mistry <rmistry@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
This reverts commit aa504cddb9.
Reason for revert: Kevin asked me to revert since this broke things
Original change's description:
> Scale the GPU when running perf on Pixel(2)
>
> This is a similar followup to:
> https://skia-review.googlesource.com/c/skia/+/93561
>
> Bug: skia:
> Change-Id: I9b11dbf3d063fd64b1dd712cf1c596618f2c9ffc
> Reviewed-on: https://skia-review.googlesource.com/114340
> Reviewed-by: Eric Boren <borenet@google.com>
> Commit-Queue: Kevin Lubick <kjlubick@google.com>
TBR=borenet@google.com,kjlubick@google.com
Change-Id: Idbc7234f2b7ff8c5e632680903836e1f4eaa50d5
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: skia:
Reviewed-on: https://skia-review.googlesource.com/114425
Reviewed-by: Ravi Mistry <rmistry@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
The experiment with using Goma to speed up Windows compiles was very
close to being successful, but at this point the ongoing maintenance
does not seem to be worth the 50-70 seconds saved.
Change-Id: Ie3900b9a681e448a3e47634efbab7695ebccad33
Reviewed-on: https://skia-review.googlesource.com/114363
Reviewed-by: Mike Klein <mtklein@chromium.org>
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
It is well after December 2017
Bug: skia:
Change-Id: I3e48735dac9885606bdecab301379a1312966ff1
Reviewed-on: https://skia-review.googlesource.com/114361
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
No-Try: true
Change-Id: I119c7853299b6eef65f991b41cbb2afb0a35f431
Reviewed-on: https://skia-review.googlesource.com/113673
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
Also switch CQ Win 32-bit Build from MSVC to Clang.
No-Try: true
Change-Id: Ic312ee611b1e99143480840c08a9266a4d8b448b
Reviewed-on: https://skia-review.googlesource.com/113672
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
Change-Id: Iea0f841f7c9a3449213c549ba310ab2a3d928ca2
Reviewed-on: https://skia-review.googlesource.com/114093
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Mike Klein <mtklein@chromium.org>
Enable /arch:SSE2 for Win x86 builds (both MSVC and Clang).
Change-Id: I0618e938b6542b60fae3947b7e0dcde22650ba54
Reviewed-on: https://skia-review.googlesource.com/56721
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
This tryjob is currently just experimental/non-blocking, and we are
severely short on capacity due to chromium:821040.
Bug: chromium:821040
Change-Id: I36b193cecd4f7ecf4c6f5769e869ee37a1285582
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/114221
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
