Commit Graph

34 Commits

Author SHA1 Message Date
Joe Gregorio
710b5e616e Fix HOME directory in Docker containers built under cloudbuild.
The line:
    USER skia

also sets the $HOME environment variable to /home/skia unless
useradd is given another directory to use as the user's home
directory. So HOME was set to /home/skia, but that directory
doesn't exist in subsequent containers.

Bug: chromuim:993053
Change-Id: I3525d7cf11a1c1e5559cf9216c3bf6071a236949
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/244116
Reviewed-by: Ravi Mistry <rmistry@google.com>
Reviewed-by: Robbie Iannucci <iannucci@google.com>
Commit-Queue: Joe Gregorio <jcgregorio@google.com>
2019-09-26 02:31:35 +00:00
Joe Gregorio
557309bf30 Add env vars to cloudbuild.yaml to enable vpython for depot_tools.
Bug: skia:9348
Change-Id: Ibcdb6448ab5573afb77506f2884093579c2e423f
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/239886
Auto-Submit: Joe Gregorio <jcgregorio@google.com>
Reviewed-by: Ravi Mistry <rmistry@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
2019-09-06 16:59:15 +00:00
Joe Gregorio
87b57d0833 Revert "Add HOME env variable to cloudbuild so vpython can move forward."
This reverts commit feb3fc29b3.

Reason for revert: Might have broken the wasm cloudbuild.

Original change's description:
> Add HOME env variable to cloudbuild so vpython can move forward.
> 
> Bug: skia:9348
> Change-Id: Ic9d835f38b028c9a60f07b56f52527bcb440c454
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/236918
> Reviewed-by: Joe Gregorio <jcgregorio@google.com>
> Commit-Queue: Joe Gregorio <jcgregorio@google.com>

TBR=borenet@google.com,jcgregorio@google.com

Change-Id: I678e7027ad5f60a57b38c5d375ba16498b2cfa95
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: skia:9348
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/237037
Reviewed-by: Joe Gregorio <jcgregorio@google.com>
Commit-Queue: Joe Gregorio <jcgregorio@google.com>
2019-08-24 12:49:26 +00:00
Joe Gregorio
feb3fc29b3 Add HOME env variable to cloudbuild so vpython can move forward.
Bug: skia:9348
Change-Id: Ic9d835f38b028c9a60f07b56f52527bcb440c454
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/236918
Reviewed-by: Joe Gregorio <jcgregorio@google.com>
Commit-Queue: Joe Gregorio <jcgregorio@google.com>
2019-08-23 21:40:50 +00:00
Mike Klein
d5555c88e5 fix Dockerfile?
Change-Id: I5cd133f9de490340a958403c06ab1c8c44017001
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/223186
Commit-Queue: Mike Klein <mtklein@google.com>
Reviewed-by: Ben Wagner aka dogben <benjaminwagner@google.com>
2019-06-24 16:34:59 +00:00
Mike Klein
6bbeb4ab72 remove xbyak
For now, disable the vpmovusdb AVX-512 instruction, using the compound
AVX2 fallback instead.  I need to learn how to encode EVEX prefixes
before we can use that, and it's not very important.

That's everything!  We're fully in control now, and should be able to
run this on any x86-64 Linux or Mac.  And we can relax some of the
defined(SKVM_JIT) guards so that, e.g., we can unit test Assembler even
on all platforms.

Stifle some warnings about ~bool by ~(int)bool.

Would like to enable when is_mac too but can't seem to get past
(bogus?) thread annotation on the bots.  My local Mac is fine. :/

Change-Id: If00bdd97ebd9684ed109933e2fa70c5e6f6ea339
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/222631
Commit-Queue: Mike Klein <mtklein@google.com>
Reviewed-by: Herb Derby <herb@google.com>
2019-06-22 00:16:38 +00:00
Joe Gregorio
024a912136 Make debugger-assets part of cloudbuild CI.
Change-Id: I5d5946304e3c20ffad5b0af69d7d43b6847ab724
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/222097
Reviewed-by: Nathaniel Nifong <nifong@google.com>
Commit-Queue: Joe Gregorio <jcgregorio@google.com>
2019-06-19 20:44:40 +00:00
Eric Boren
34d63e6b4e [infra] Fix Cloud Build
Bug: skia:9184
Change-Id: Ia78094f5bd2a0cf3c8368933b3719df01ab1e646
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/221540
Commit-Queue: Eric Boren <borenet@google.com>
Reviewed-by: Joe Gregorio <jcgregorio@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
2019-06-18 14:45:24 +00:00
Nathaniel Nifong
036503b07e Include wasm debugger in continuous build part 2
Merge branch 'master' of https://skia.googlesource.com/skia into buildwasm


Two-part commit required, compile.sh changes first.


needed hashbang line to run in docker


Include wasm debugger in continuous build

Bug: skia:
Change-Id: I378bff703bdf884ca4da266d00069405ed8613d9
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/205266
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Commit-Queue: Nathaniel Nifong <nifong@google.com>
2019-04-01 19:51:43 +00:00
Joe Gregorio
df5b72535d Turn on CI/CD for api.skia.org. (skia)
Bug: skia:
Change-Id: I9f9b39f9903a4fa6476adbfb8c41d7aa7f06c0bc
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/199841
Reviewed-by: Kevin Lubick <kjlubick@google.com>
2019-03-12 18:30:38 +00:00
Kevin Lubick
b6b3188f81 [particles] Turn on CI/CD for particles.skia.org
Add entry to cloudbuild.yaml

Bug: skia:
Change-Id: I649e42f3e4e97e33a673a816ba7815abe1bc08a7
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/200462
Reviewed-by: Joe Gregorio <jcgregorio@google.com>
2019-03-12 16:29:42 +00:00
Kevin Lubick
3f67f411d8 [canvaskit] Move from experimental to modules
Bug: skia:
Change-Id: I2ffd54cf81c974f3a80103e1726a06067cc90d82
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/200044
Reviewed-by: Mike Reed <reed@google.com>
Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
2019-03-11 21:09:52 +00:00
Kevin Lubick
402bf74ea8 Build code size treemaps for skottie_tool
Bug: skia:
Change-Id: I3364fa6b89674f65bf493467198740e1862d215e
Reviewed-on: https://skia-review.googlesource.com/c/191291
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2019-02-12 13:54:00 +00:00
Kevin Lubick
9a2bb09202 CMake: distinguish between file and dir copies by presence of '.' in src path
ANGLE's build requires a file copy. Nema's build requires a dir copy. CMake
uses a different command for each. gn does not distinguish which. We make
a guess that happens to work for these two use cases based on the whether
the base file name of the src contains a '.'


Change-Id: I3503fd9d632abda3f8f952d0eef964019d932bea
Reviewed-on: https://skia-review.googlesource.com/c/188626
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
2019-02-01 18:58:46 +00:00
Kevin Lubick
3105238ed5 Add CMake bot
It uses a docker container to handle the installation of CMake.

Depends on https://skia-review.googlesource.com/c/skia/+/188305/

Bug: skia:8732
Change-Id: Ib84a46b4f0ca7f88fca4e6123c1517a84f3444b2
Reviewed-on: https://skia-review.googlesource.com/c/188036
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
2019-01-31 22:05:22 +00:00
Kevin Lubick
22d6c27f31 Convert skottie's cloud build to use CanvasKit
Bug: skia:
Change-Id: Id550fe3a051e5000bc1254e3a300fb88c8e6a61e
Reviewed-on: https://skia-review.googlesource.com/c/170261
Reviewed-by: Joe Gregorio <jcgregorio@google.com>
2018-11-10 12:06:32 +00:00
Kevin Lubick
df3a6eee13 Add JSFiddle to cloudbuild
This is a little more complicated than other builds because we need
the webassembly binaries out fo skia-wasm-release when we do the webpack
step and we can't run docker (e.g. docker run skia-wasm-release cp foo.wasm)
inside of the skia-public/infra:prod image.

To get around this limitation, we add a step that extracts the binaries to
a /workspace/wasm-products folder (which persists between steps) and mount
that folder as a volume for when we make the jsfiddle output. The only tricky
thing is that we must manually mount the /workspace/__jsfiddle_staging folder
as a volume too, or it doesn't persist to the build step.

Something similar will be needed for skottie.skia.org after
https://skia-review.googlesource.com/c/buildbot/+/169700 lands.

Bug: skia:
Change-Id: Iec05fff7231a28ecfa209489e5c75a9621b334d2
Reviewed-on: https://skia-review.googlesource.com/c/169821
Reviewed-by: Joe Gregorio <jcgregorio@google.com>
2018-11-08 22:53:25 +00:00
Kevin Lubick
36b85be494 Revert "Autobuild the jsfiddle docker image"
This reverts commit 2969d27760.

Reason for revert: command "docker" not found inside image

Original change's description:
> Autobuild the jsfiddle docker image
> 
> With https://skia-review.googlesource.com/c/skia-public-config/+/169300
> it will auto-deploy too.
> 
> Bug: skia:
> Change-Id: Ic0a186c0e5c44328cc29085a74ac36e4a0c632ac
> Reviewed-on: https://skia-review.googlesource.com/c/169246
> Reviewed-by: Kevin Lubick <kjlubick@google.com>

TBR=jcgregorio@google.com,kjlubick@google.com

Change-Id: Ifad1dbf9cce4b70e42c2a4c70f8fa045becf9aea
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: skia:
Reviewed-on: https://skia-review.googlesource.com/c/169321
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
2018-11-07 19:55:21 +00:00
Kevin Lubick
2969d27760 Autobuild the jsfiddle docker image
With https://skia-review.googlesource.com/c/skia-public-config/+/169300
it will auto-deploy too.

Bug: skia:
Change-Id: Ic0a186c0e5c44328cc29085a74ac36e4a0c632ac
Reviewed-on: https://skia-review.googlesource.com/c/169246
Reviewed-by: Kevin Lubick <kjlubick@google.com>
2018-11-07 18:33:51 +00:00
Kevin Lubick
70273a92aa Make the skia-wasm-release image only have the build products
The previous version had several gigs of buildtools, source code, etc.
This is much smaller and easier to download for tools like
jsfiddles.skia.org and (soon) skottie.skia.org

Bug: skia:
Change-Id: I748487abb1c6f6e82476076d22a27a5d4f90f75a
Reviewed-on: https://skia-review.googlesource.com/c/169240
Reviewed-by: Kevin Lubick <kjlubick@google.com>
2018-11-07 16:35:44 +00:00
Kevin Lubick
96175696de Add skia-wasm-release image.
This should let us pipe continuous builds into jsfiddle.skia.org and
skottie.skia.org

Bug: skia:
Change-Id: I587e1293237d42dfdacae0757f44634f29d6f251
Reviewed-on: https://skia-review.googlesource.com/c/168440
Reviewed-by: Joe Gregorio <jcgregorio@google.com>
2018-11-06 15:45:51 +00:00
Joe Gregorio
e9326bebdf Use new build targets in continuous build of skottie and debugger.
The new targets were added here: https://skia-review.googlesource.com/c/buildbot/+/155820

Bug: skia:
Change-Id: Iac387fb033cf66dff353efb83f52a442b3441539
Reviewed-on: https://skia-review.googlesource.com/155841
Reviewed-by: Ravi Mistry <rmistry@google.com>
Commit-Queue: Joe Gregorio <jcgregorio@google.com>
2018-09-20 15:26:18 +00:00
Joe Gregorio
b78becc40c Fix container builder command line.
The gcloud commands have moved.

Bug: skia:
Change-Id: I2af39ccfe0efe121766b7b0e2fe3cdb8cd8c4012
Reviewed-on: https://skia-review.googlesource.com/154040
Auto-Submit: Joe Gregorio <jcgregorio@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
2018-09-12 18:44:59 +00:00
Joe Gregorio
a83bb57bfe Use a larger machine for our cloud build.
Bug: skia:
Change-Id: I51ea222fb36f521f34f7a870a225423f8a46c887
Reviewed-on: https://skia-review.googlesource.com/144609
Auto-Submit: Joe Gregorio <jcgregorio@google.com>
Reviewed-by: Ravi Mistry <rmistry@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
2018-07-31 20:40:33 +00:00
Joe Gregorio
6407c3d41d Add continuous deploy for skottie and debugger.
Bug: skia:
Change-Id: I90ad3445224a529f7b92951be9f43e37b4a063bd
Reviewed-on: https://skia-review.googlesource.com/142891
Auto-Submit: Joe Gregorio <jcgregorio@google.com>
Reviewed-by: Ravi Mistry <rmistry@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
2018-07-23 18:05:24 +00:00
Joe Gregorio
3eff1e9647 cloudbuild.yaml also needs a top level timeout.
Bug: skia:
Change-Id: Idab02c36778feab40bf6750646929d037db7321a
Reviewed-on: https://skia-review.googlesource.com/139168
Reviewed-by: Joe Gregorio <jcgregorio@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Joe Gregorio <jcgregorio@google.com>
2018-07-03 19:02:55 +00:00
Joe Gregorio
28e2423afd Add timeouts to cloudbuild.yaml
Bug: skia:
Change-Id: Ibe95223343bbb9980bca84c336ac3ef162a13c2a
Reviewed-on: https://skia-review.googlesource.com/139164
Auto-Submit: Joe Gregorio <jcgregorio@google.com>
Reviewed-by: Joe Gregorio <jcgregorio@google.com>
Commit-Queue: Joe Gregorio <jcgregorio@google.com>
2018-07-03 18:00:45 +00:00
Joe Gregorio
0725bdb787 Add cloudbuild.yaml file for continous builds of fiddler and skia-release.
Bug: skia:
Change-Id: I713fea23ce88af4dd2a1f28082274535119defee
Reviewed-on: https://skia-review.googlesource.com/139107
Reviewed-by: Joe Gregorio <jcgregorio@google.com>
Commit-Queue: Joe Gregorio <jcgregorio@google.com>
2018-07-03 14:43:43 +00:00
Joe Gregorio
fba19c37f5 docker - Record the skia git hash.
Puts the git hash in an easy place for dependent docker files to retrieve it from.

Bug: skia:
Change-Id: I096c25554df76779b088d6aab91ddce31304ffde
Reviewed-on: https://skia-review.googlesource.com/136067
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Commit-Queue: Joe Gregorio <jcgregorio@google.com>
2018-06-20 14:19:01 +00:00
Kevin Lubick
fe6b48948c Add Dockerfile for building and running local Skia checkout with SwiftShader
This also adds a little helper to fuzz that allows us to see what
GPU is being targeted.

This is the first step in getting a SwiftShader fuzz target.

To prove that this works, simply download this patch and run:

./docker/skia-with-swift-shader-base/build-with-swift-shader-and-run "out/with-swift-shader/fuzz --gpuInfo -t api -n NativeGLCanvas -b out/with-swift-shader/fiddle"
Running supplied command ['out/with-swift-shader/fuzz', '--gpuInfo', '-t', 'api', '-n', 'NativeGLCanvas', '-b', 'out/with-swift-shader/fiddle']
Fuzzing NativeGLCanvas...
GL_RENDERER Google SwiftShader
GL_VENDOR Google Inc.
GL_VERSION OpenGL ES 3.0 SwiftShader 4.0.0.6

Bug: skia:
Change-Id: I3cc11a6bcd14f70f6025011722f9a73c94cb1f65
Reviewed-on: https://skia-review.googlesource.com/132269
Reviewed-by: Joe Gregorio <jcgregorio@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
2018-06-06 18:23:24 +00:00
Joe Gregorio
8e9810ce0f [fiddle] Init gpu using the GLTestContext.
The previous way was failing with SwiftShader.

Bug: skia:
Change-Id: I6f3937d4d3bc36851476e29be891dc0a38871ef0
Reviewed-on: https://skia-review.googlesource.com/130325
Commit-Queue: Joe Gregorio <jcgregorio@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
2018-05-29 18:20:46 +00:00
Joe Gregorio
ca8b0bd237 Fix Dockerfile so args.gn actually applies, also drop debug symbols.
The part of the Dockerfile that extracted the skiaserve executable
will be done in the skiabot repo.

Bug: skia:
Change-Id: Ieb913908d92626a7b9e68649b5c56b8f92646fd2
Reviewed-on: https://skia-review.googlesource.com/130323
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Joe Gregorio <jcgregorio@google.com>
2018-05-28 18:58:45 +00:00
Joe Gregorio
5702d8cbca [docker] Move to testing-slim as the base image.
Also clean out more unneeded packages.

Bug: skia:
Change-Id: Iae642c8878e6d65cda0862e92a881b54634f8f30
Reviewed-on: https://skia-review.googlesource.com/128409
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Joe Gregorio <jcgregorio@google.com>
2018-05-16 13:32:54 +00:00
Joe Gregorio
f2dbd7546c [docker] Add Dockerfile that builds skiaserve.
Bug: skia:
Change-Id: If43c546fd7909329a015302580bc50925f4b7630
Reviewed-on: https://skia-review.googlesource.com/128313
Commit-Queue: Joe Gregorio <jcgregorio@google.com>
Auto-Submit: Joe Gregorio <jcgregorio@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
2018-05-15 22:12:23 +00:00