Commit Graph

40480 Commits

Author SHA1 Message Date
Leon Scroggins III
631dbc82f0 Fix Android host-side Windows build
Bug: b/123085931
Bug: b/117921091

Based on ag/6614841

Don't use the default Windows FontMgr/FontHost. Android will
handle fonts.

Remove _HAS_EXCEPTIONS=0, which was added by gn/BUILD.gn

Change-Id: I93a72a550b2dbb9adc498638853f6e95c5d4e94f
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/197041
Commit-Queue: Leon Scroggins <scroggo@google.com>
Reviewed-by: Leon Scroggins <scroggo@google.com>
Reviewed-by: Ben Wagner <bungeman@google.com>
2019-03-05 18:57:07 +00:00
Chris Dalton
ff8065c2d2 Make sure to apply the stencil settings for GrDashOp
Bug: skia:8807
Change-Id: I0389d4836382aac289732effb41221e84978cc66
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/197789
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Chris Dalton <csmartdalton@google.com>
2019-03-05 18:23:03 +00:00
Ben Wagner
bd66269c5b [infra] Upgrade Debian GCE bots to 9.8.
Change-Id: I4996779ad7a634bce6e39eb6defa4bc0cea026d7
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/197203
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2019-03-05 17:42:23 +00:00
Herb Derby
d3898b987d Have SkGlyphRunListPainter close over SkStrikeCacheInterface
Change-Id: I7b07cc7f7fc4335fd614b45c7d19bdefe55fe8e8
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/197165
Commit-Queue: Herb Derby <herb@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
2019-03-05 16:47:45 +00:00
skia-autoroll
273ef686c5 Roll third_party/externals/swiftshader e95eeb19a770..e57f10e4041d (1 commits)
https://swiftshader.googlesource.com/SwiftShader.git/+log/e95eeb19a770..e57f10e4041d


git log e95eeb19a770..e57f10e4041d --date=short --no-merges --format='%ad %ae %s'
2019-03-05 chrisforbes@google.com Assert on unimplemented instructions


Created with:
  gclient setdep -r third_party/externals/swiftshader@e57f10e4041d

The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Test-Debian9-Clang-GCE-GPU-SwiftShader-x86_64-Debug-All-SwiftShader
TBR=reed@google.com

Change-Id: I38cb5f23e81ed2d19c1e1a26816e76977f2f2382
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/197670
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-03-05 16:31:45 +00:00
Ben Wagner
68efb2122d Clarify ownership of typefaces in implementation.
This converts a number of ownership semantics by using sk_sp and
unique_ptr instead of comments.

Change-Id: I4c584a5a8ea54fd22a4d23deddb5ce844f883117
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/197206
Commit-Queue: Ben Wagner <bungeman@google.com>
Reviewed-by: Herb Derby <herb@google.com>
2019-03-05 16:20:45 +00:00
Nathaniel Nifong
ad5f6cdb7e Initial wasm debugger
Bug: skia:
Change-Id: I4d38e60f03bb315dee9c9db655ce168e9b3b475f
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/195580
Commit-Queue: Nathaniel Nifong <nifong@google.com>
Reviewed-by: Kevin Lubick <kjlubick@google.com>
2019-03-05 16:10:15 +00:00
Ben Wagner
a1810551f2 Add fetch-gn to canvaskit and cmake compile scripts
If fetch-gn is omitted, the scripts fail in a clean checkout.

Change-Id: Idc944f7e8c5cd2ca998ab685b942df280e17dbab
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/197207
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Auto-Submit: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Kevin Lubick <kjlubick@google.com>
2019-03-05 16:03:27 +00:00
Ethan Nicholas
a70693b234 Add support for runtime color filters written in SkSL.
Bug: skia:
Change-Id: I9b930e81cff1c656908125dcf900279f73570204
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/195581
Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
2019-03-05 16:03:25 +00:00
Mike Reed
72542816ca add sample for retained vertices
Bug: skia:
Change-Id: I79d9aa533af3f912017b83cec59c23859a822dd9
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/197241
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Reed <reed@google.com>
Auto-Submit: Mike Reed <reed@google.com>
2019-03-05 15:47:03 +00:00
Florin Malita
6041d315c7 Reland "SkMixerColorFilter GPU impl"
This reverts commit c2949ec67b.

Reason for revert: not related to crossfade

Original change's description:
> Revert "SkMixerColorFilter GPU impl"
> 
> This reverts commit e80f7eb9d6.
> 
> Reason for revert: break crossfade in chrome roll?
> 
> Original change's description:
> > SkMixerColorFilter GPU impl
> > 
> > Bug: skia:
> > Change-Id: Ia1e25e0c99737d9720c17f92f0d76a1cb7897ea8
> > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/193163
> > Commit-Queue: Florin Malita <fmalita@chromium.org>
> > Reviewed-by: Brian Salomon <bsalomon@google.com>
> 
> TBR=bsalomon@google.com,ethannicholas@google.com,fmalita@chromium.org,reed@google.com
> 
> Change-Id: Ib9464fcabc649b95ba131146690d6208af728436
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: skia:
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/197760
> Reviewed-by: Mike Reed <reed@google.com>
> Commit-Queue: Mike Reed <reed@google.com>

TBR=bsalomon@google.com,ethannicholas@google.com,fmalita@chromium.org,reed@google.com

Change-Id: Ie96e80e153aeab16c4ea35d5f1350372060228aa
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: skia:
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/197763
Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Florin Malita <fmalita@chromium.org>
2019-03-05 15:03:34 +00:00
Mike Reed
c2949ec67b Revert "SkMixerColorFilter GPU impl"
This reverts commit e80f7eb9d6.

Reason for revert: break crossfade in chrome roll?

Original change's description:
> SkMixerColorFilter GPU impl
> 
> Bug: skia:
> Change-Id: Ia1e25e0c99737d9720c17f92f0d76a1cb7897ea8
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/193163
> Commit-Queue: Florin Malita <fmalita@chromium.org>
> Reviewed-by: Brian Salomon <bsalomon@google.com>

TBR=bsalomon@google.com,ethannicholas@google.com,fmalita@chromium.org,reed@google.com

Change-Id: Ib9464fcabc649b95ba131146690d6208af728436
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: skia:
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/197760
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Reed <reed@google.com>
2019-03-05 14:45:08 +00:00
Mike Reed
c9273997fd Reland "check if we can use legacy blits"
This reverts commit 2b28b1c12d.

Reason for revert: hmmm, maybe not

Original change's description:
> Revert "check if we can use legacy blits"
> 
> This reverts commit 5539390c53.
> 
> Reason for revert: broke chrome roll?
> 
> Original change's description:
> > check if we can use legacy blits
> > 
> > depends on https://skia-review.googlesource.com/c/skia/+/196647
> > 
> > Bug: skia:
> > Change-Id: I85ea7aac34558838d120c2c02abaaeebd77d8b8a
> > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/196651
> > Reviewed-by: Mike Klein <mtklein@google.com>
> > Commit-Queue: Mike Reed <reed@google.com>
> 
> TBR=mtklein@google.com,brianosman@google.com,reed@google.com
> 
> Change-Id: Ib05f310e428145ffb79c27a077c8c31ef937487e
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: skia:
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/197658
> Reviewed-by: Mike Reed <reed@google.com>
> Commit-Queue: Mike Reed <reed@google.com>

TBR=mtklein@google.com,brianosman@google.com,reed@google.com

Change-Id: I14180cd0025a33a3c9c3cd8a1652e4a6cf8be141
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: skia:
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/197659
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Reed <reed@google.com>
2019-03-05 14:42:56 +00:00
Mike Reed
2b28b1c12d Revert "check if we can use legacy blits"
This reverts commit 5539390c53.

Reason for revert: broke chrome roll?

Original change's description:
> check if we can use legacy blits
> 
> depends on https://skia-review.googlesource.com/c/skia/+/196647
> 
> Bug: skia:
> Change-Id: I85ea7aac34558838d120c2c02abaaeebd77d8b8a
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/196651
> Reviewed-by: Mike Klein <mtklein@google.com>
> Commit-Queue: Mike Reed <reed@google.com>

TBR=mtklein@google.com,brianosman@google.com,reed@google.com

Change-Id: Ib05f310e428145ffb79c27a077c8c31ef937487e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: skia:
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/197658
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Reed <reed@google.com>
2019-03-05 14:40:05 +00:00
Brian Osman
fbe9fa73f5 Remove dithering during SkConvertPixels
Now that https://chromium-review.googlesource.com/c/chromium/src/+/1495208
has landed, this is safe to land.

Bug: b/124403051 skia:8787
Change-Id: I087cd2313343229176a1814c2097dbe8f77620cc
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/195886
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2019-03-05 14:23:22 +00:00
Brian Salomon
eb716bde99 Remove legacy promise image APIs
Change-Id: Ied33a6b57b776aaa91ec4ce0ccf668b22c317a70
Bug: skia:8800
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/197656
Commit-Queue: Brian Salomon <bsalomon@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
Auto-Submit: Brian Salomon <bsalomon@google.com>
Reviewed-by: Robert Phillips <robertphillips@google.com>
2019-03-05 14:23:03 +00:00
Jim Van Verth
6e8174e957 Fix issue with offsetting polygon by 0 distance.
Need to output matching indices as well.

Bug: skia:13417, chromium:937412
Change-Id: I251a70eb07fda8b3a257d9f57ebdd9f20ad01b5a
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/197160
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Commit-Queue: Jim Van Verth <jvanverth@google.com>
2019-03-05 14:06:02 +00:00
skia-autoroll
8c48f022eb Roll third_party/externals/swiftshader d69cdaba1445..e95eeb19a770 (1 commits)
https://swiftshader.googlesource.com/SwiftShader.git/+log/d69cdaba1445..e95eeb19a770


git log d69cdaba1445..e95eeb19a770 --date=short --no-merges --format='%ad %ae %s'
2019-03-05 bclayton@google.com SpirvShader: Add relational ops for integers


Created with:
  gclient setdep -r third_party/externals/swiftshader@e95eeb19a770

The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Test-Debian9-Clang-GCE-GPU-SwiftShader-x86_64-Debug-All-SwiftShader
TBR=reed@google.com

Change-Id: Id0ca9c98aeb58c623171edd03dec374e6a1db778
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/197665
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-03-05 13:44:52 +00:00
Brian Salomon
1c1c666382 Default implementation of onSetRelease() on GrSurface
Change-Id: I96ca2a8372d0748b56d5048ea294d7e2be80d22a
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/197040
Commit-Queue: Brian Salomon <bsalomon@google.com>
Reviewed-by: Greg Daniel <egdaniel@google.com>
2019-03-05 13:24:52 +00:00
Brian Salomon
b2c5dae65d Simplify promise image lazy instantiation callbacks.
Now that we never re-fulfill a promise image we no longer need to deinstantiate
promise image proxies. They now can use kSingleUse callback semantics.

This was the only usage of the kDeinstantiate lazy callback type so it is
removed. The DeinstantiateProxyTracker is also no longer required and is
removed.

The GrTexture idle callback mechanism now uses GrReleaseProcHelper, which has
been extended to support chaining multiple callbacks together and an abandon()
method that aborts calling the callback in the destructor. It has been renamed
GrRefCntedCallback to reflect its more general usage.

Bug: skia:8800
Change-Id: I857c9eec57fdf706631a266ec8bea682d6657a7c
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/196500
Commit-Queue: Brian Salomon <bsalomon@google.com>
Reviewed-by: Robert Phillips <robertphillips@google.com>
2019-03-05 13:18:22 +00:00
Robert Phillips
920d488d5f Lay some groundwork for depowering SkGpuDevice's and SkImage_GpuBase's context pointer
In future Ganesh these classes will, respectively, have a RecordingContext and an ImageContext.

Change-Id: I69ced004a2edae5c410e9c00c2de6c0246699caa
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/197167
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
2019-03-05 13:14:32 +00:00
skia-autoroll
6b7c770f6f Roll third_party/externals/swiftshader d318dd329423..d69cdaba1445 (4 commits)
https://swiftshader.googlesource.com/SwiftShader.git/+log/d318dd329423..d69cdaba1445


git log d318dd329423..d69cdaba1445 --date=short --no-merges --format='%ad %ae %s'
2019-03-05 loganchien@google.com Add -Wno-implicit-fallthrough
2019-03-04 chrisforbes@google.com Fix setup code to deal with inverted area sign
2019-03-04 hliatis@google.com Implement vkGetSwapchainImagesKHR
2019-03-04 chiur@google.com Create CI for gcp_windows


Created with:
  gclient setdep -r third_party/externals/swiftshader@d69cdaba1445

The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Test-Debian9-Clang-GCE-GPU-SwiftShader-x86_64-Debug-All-SwiftShader
TBR=reed@google.com

Change-Id: I7bc01d535e1de380d13477af2a0b3d58e9549690
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/197662
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-03-05 12:32:02 +00:00
Mike Reed
5539390c53 check if we can use legacy blits
depends on https://skia-review.googlesource.com/c/skia/+/196647

Bug: skia:
Change-Id: I85ea7aac34558838d120c2c02abaaeebd77d8b8a
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/196651
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Mike Reed <reed@google.com>
2019-03-05 11:49:02 +00:00
skia-autoroll
25bc174cf6 Roll third_party/externals/swiftshader bb305299f4de..d318dd329423 (7 commits)
https://swiftshader.googlesource.com/SwiftShader.git/+log/bb305299f4de..d318dd329423


git log bb305299f4de..d318dd329423 --date=short --no-merges --format='%ad %ae %s'
2019-03-04 chrisforbes@google.com Remove some GL/D3D legacy format quirks from vulkan vertex buffers
2019-03-04 hliatis@google.com VkCreateSwapchainKHR and VkDestroySwapchainKHR
2019-03-04 chrisforbes@google.com Add support for conversion instructions
2019-03-04 chrisforbes@google.com Add support for OpDot
2019-03-04 chrisforbes@google.com Add support for OpUMulExtended, OpSMulExtended
2019-03-04 bclayton@google.com SpirvShader: Add debug checks on Intermediate.
2019-03-04 chrisforbes@google.com regres: fix wsi test list


Created with:
  gclient setdep -r third_party/externals/swiftshader@d318dd329423

The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Test-Debian9-Clang-GCE-GPU-SwiftShader-x86_64-Debug-All-SwiftShader
TBR=reed@google.com

Change-Id: I71ec3e52237563d18641903c564318d21ca50883
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/197085
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-03-05 11:40:28 +00:00
Florin Malita
e80f7eb9d6 SkMixerColorFilter GPU impl
Bug: skia:
Change-Id: Ia1e25e0c99737d9720c17f92f0d76a1cb7897ea8
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/193163
Commit-Queue: Florin Malita <fmalita@chromium.org>
Reviewed-by: Brian Salomon <bsalomon@google.com>
2019-03-05 11:35:47 +00:00
Chris Dalton
4c56b03cfd Drop support for GL_EXT_raster_multisample
We had only used this extension in conjunction with
GL_NV_framebuffer_mixed_samples to draw directly to the framebuffer.
However, it's faster and higher quality to just use our own analytic
AA if we can draw directly to the framebuffer.

It might have been interesting to fake mixed samples using
GL_EXT_raster_multisample and PLS together, but those two extensions
don't appear to ever exist together.

Bug: skia:
Change-Id: Iea489cb0e03fc55aa64d3ea7fccc61b539cc461e
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/197082
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Chris Dalton <csmartdalton@google.com>
2019-03-05 11:35:21 +00:00
skia-recreate-skps
e1d3a28ed2 Update go_deps asset
Automatic commit by the UpdateGoDEPS bot.

TBR=borenet@google.com

Change-Id: I006d9e296705dc5f3495dcb598ef8db53f6434ce
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/197480
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
2019-03-05 11:30:40 +00:00
Ben Wagner
93ed80de4f Roll HarfBuzz.
1e06282105..4f37ab63de

Picks up changes to make glyph subsetting work.

Change-Id: I5d5b81cc0849e3a549d57c7d70a393a8bc978b3d
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/196761
Auto-Submit: Ben Wagner <bungeman@google.com>
Commit-Queue: Hal Canary <halcanary@google.com>
Reviewed-by: Hal Canary <halcanary@google.com>
2019-03-05 11:30:15 +00:00
skia-autoroll
13623c141e Roll third_party/externals/angle2 0e1ce2e55387..b8cff9e9347c (6 commits)
0e1ce2e553..b8cff9e934


git log 0e1ce2e55387..b8cff9e9347c --date=short --no-merges --format='%ad %ae %s'
2019-03-05 jiajia.qin@intel.com ES31: Add MAX_COMPUTE_SHARED_MEMORY_SIZE
2019-03-04 kpschoedel@google.com Update gpu_test_expectations
2019-03-04 tobine@google.com Vulkan:Add SecondaryCommandBuffer class
2019-03-04 jmadill@google.com Revert "Vulkan: Update code hash after roll."
2019-03-04 geofflang@chromium.org D3D: Asynchronously load program binaries.
2019-03-04 syoussefi@chromium.org Vulkan: Rename vk::Shared* to vk::RefCounted*


Created with:
  gclient setdep -r third_party/externals/angle2@b8cff9e9347c

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE
TBR=reed@google.com

Change-Id: I0a6b8b0e2a652e9d2f42021c036757ea686723ae
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/197540
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-03-05 11:25:27 +00:00
recipe-roller
9082af32a1 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/aa56edf9619152ce9971d90461d909f215e7fab4 [third_party/logdog] Rev to latest. (iannucci@chromium.org)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I4f4c02f0d78f0bafd4ce84df7c853a017c8d5a25
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/197641
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
2019-03-05 11:25:09 +00:00
Mike Reed
fbc887df72 Revert "Remove (unnecessary?) flush in RenderYUVAToRGBA"
This reverts commit 49b293a7d5.

Reason for revert: speculative to fix chrome roll

Original change's description:
> Remove (unnecessary?) flush in RenderYUVAToRGBA
> 
> I don't think we need a flush here.
> 
> Change-Id: I87bf41b491835578e7df9bea4e15ea24dd551c1e
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/196645
> Reviewed-by: Greg Daniel <egdaniel@google.com>
> Commit-Queue: Robert Phillips <robertphillips@google.com>

TBR=egdaniel@google.com,jvanverth@google.com,robertphillips@google.com

Change-Id: I49305a5a2bcd5fe112b5f55b64511fd05d6c8548
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/197305
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Reed <reed@google.com>
Auto-Submit: Mike Reed <reed@google.com>
2019-03-05 02:47:38 +00:00
recipe-roller
0a57971f05 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
depot_tools:
  https://crrev.com/a3be9a522b8adb8443d4f7a1a8884a787d8cce33 Add --no-branch-color option to git cl status (alancutter@chromium.org)
  https://crrev.com/cf661acb705fccc302901a1f8a251ad43ce2dd62 [bot_update] Downstream change for buildbucket proto update. (iannucci@chromium.org)
recipe_engine:
  https://crrev.com/9bd140be04588f5956a3ee1cd42afec809a77618 [buildbucket] Use PB for buildbucket protos. (iannucci@chromium.org)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ic4238e645dd2610989b97b54e93f179559687545
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/197208
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
2019-03-04 22:14:41 +00:00
Hal Canary
9e9653cd94 SkQP: fix five tests
set `skia_use_expat` to true:
  - coloremoji_blendmodes
  - scaledemoji
  - scaledemojipos

disable bad tests:
  - arcs_as_paths
  - ovals_as_paths

Change-Id: I883cf13f54b424b8d3964fc045bd6282cbc028c9
Reviewed-on: https://skia-review.googlesource.com/c/196644
Reviewed-by: Ben Wagner <bungeman@google.com>
Cherry-Pick: e7e803e3a96948526c52220941594b0a6d3cdc24
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/197014
Reviewed-by: Hal Canary <halcanary@google.com>
Commit-Queue: Hal Canary <halcanary@google.com>
2019-03-04 22:14:21 +00:00
Robert Phillips
9882dae24d Reduce usage of SkCanvas::flush
SkCanvas::flush is problematic and we wish to deprecate it. As a first step, this CL begins to remove Skia's internal usage of it.

Ideally clients would use SkSurface::flush and/or GrContext::flush.

Change-Id: I39bb0702f8230134a97961a4ee70833fd5bd0dcc
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/196641
Commit-Queue: Robert Phillips <robertphillips@google.com>
Reviewed-by: Greg Daniel <egdaniel@google.com>
2019-03-04 22:09:39 +00:00
Florin Malita
390f9bd8ba Fix handling of SkSL nullable FPs
Bug: skia:8798
Change-Id: Iec311c9d834a6f35b0a4481dbd748532107cd4b1
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/197108
Reviewed-by: Ethan Nicholas <ethannicholas@google.com>
Commit-Queue: Florin Malita <fmalita@chromium.org>
2019-03-04 22:09:20 +00:00
Mike Klein
5ece363ff4 mark lowp TODOs
Change-Id: I14b39a77039d26ca5a98310c41d328a7126ee90a
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/196621
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
2019-03-04 22:04:32 +00:00
Brian Osman
bdcdf1a7c3 Add SkParticleValue to allow further customization of curve behavior
All curves (and path affectors) are driven by an SkParticleValue. The
value can derive its value from the current defaults (age of particle
or effect), or explicitly choose the other one, a random value, or any
other particle value. Values can be range adjusted and support repeat,
clamp, and mirror tiling.

Also fixed some more issues related to resource path in the slide GUI.

Bug: skia:
Change-Id: I4755018d5b57ae2d5ec400d541055ca4fb542978
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/196760
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2019-03-04 22:04:17 +00:00
Herb Derby
0f27b5ee2b Introduce SkStrikeCacheInterface
Introduce SkStrikeCacheInterface in order to move from a
template a based interface on SkGlyphRunListPainter to
a class based interface.

Change-Id: Ib15e437420c00f4e11242ac1a4d8a87ee2af9ee1
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/197101
Reviewed-by: Ben Wagner <bungeman@google.com>
Commit-Queue: Herb Derby <herb@google.com>
2019-03-04 21:59:30 +00:00
Greg Daniel
b6c15babd5 Add API for creating SkImage from AHB while uploading data to it.
Bug: skia:
Change-Id: I893b511450df7f15bdde202fe01ce223ea2294a9
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/195366
Commit-Queue: Greg Daniel <egdaniel@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
2019-03-04 21:59:12 +00:00
skia-autoroll
ad39760239 Roll third_party/externals/angle2 4d153383bd3a..0e1ce2e55387 (1 commits)
4d153383bd..0e1ce2e553


git log 4d153383bd3a..0e1ce2e55387 --date=short --no-merges --format='%ad %ae %s'
2019-03-04 jmadill@chromium.org Vulkan: Update code hash after roll.


Created with:
  gclient setdep -r third_party/externals/angle2@0e1ce2e55387

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE
TBR=reed@google.com

Change-Id: I7e446f954496d2654ccdfeff2cebe0bceb04a9dd
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/197080
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-03-04 21:54:12 +00:00
Robert Phillips
0d075de863 Clean up GrSurfaceContext's relationship with GrRecordingContext
GrSurfaceContext was explicitly holding a lot of things it could just get from its GrRecordingContext.

Change-Id: Ia2e9708d71318dc0c101d56aadf5ae797230bc75
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/194360
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
2019-03-04 21:54:05 +00:00
Mike Klein
b70990eda4 add kRGBA_F16Norm_SkColorType
For now this is distinct from kRGBA_F16_SkColorType but treated the
same.  Next steps are to see if we can keep it clamped to [0,1].

Switched a few switches away from default to exhaustive.

Took away any explicit SW clamps for now except the one we definitely
want in append_gamut_clamp_if_normalized().

Skip F16Norm in the DDL test because we can't yet distinguish it from
F16.

Change-Id: I021a864fe078e4fa4e2b399982e6c38350e10d74
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/196371
Commit-Queue: Mike Klein <mtklein@google.com>
Commit-Queue: Mike Reed <reed@google.com>
Reviewed-by: Mike Reed <reed@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
Auto-Submit: Mike Klein <mtklein@google.com>
2019-03-04 21:49:07 +00:00
Robert Phillips
49b293a7d5 Remove (unnecessary?) flush in RenderYUVAToRGBA
I don't think we need a flush here.

Change-Id: I87bf41b491835578e7df9bea4e15ea24dd551c1e
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/196645
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
2019-03-04 21:49:03 +00:00
skia-autoroll
12ea3e6beb Roll ../src aae499d4d09d..8e3cddfd5a43 (217 commits)
aae499d4d0..8e3cddfd5a


git log aae499d4d09d..8e3cddfd5a43 --date=short --no-merges --format='%ad %ae %s'
2019-03-04 yusufo@google.com Add junit and DummyUIActivity tests for GridTabSwitcher
2019-03-04 xiaohuic@google.com assistant: http connection header response
2019-03-04 lanwei@chromium.org Add pause action to touch scroll action in WPT pointerevent touch tests
2019-03-04 thestig@chromium.org Remove unneeded base/debug/stack_trace.h includes.
2019-03-04 jdiggs@igalia.com Improve logic determining the accessible role of non-scoped th elements
2019-03-04 xiaohuic@google.com assistant: pin audio device
2019-03-04 olivierrobin@chromium.org ProtoDatabaseTest Flush thread on lock release
2019-03-04 collinbaker@chromium.org Fix IPH menu button animation for non-unit scale factors
2019-03-04 sczs@chromium.org [ios] Displays InfobarBadge when an Infobar is presented.
2019-03-04 bpastene@chromium.org Swtich android_compile_x(86|64)_dbg trybots to luci in CQ config.
2019-03-04 cbiesinger@chromium.org Inline MinimumValueForLength for better performance
2019-03-04 akihiroota@chromium.org Change how rich text attributes are reported within editable text
2019-03-04 riajiang@chromium.org Delete event-source in all transform request calls.
2019-03-04 danan@chromium.org Enable hiding of supervised users for M74
2019-03-04 johannes@chromium.org [DevTools] Roll of inspector protocol ...
2019-03-04 kevers@chromium.org Implement 2D matrix decomposition in ui/gfx.
2019-03-04 lindsayw@google.com [ios] Rolls EG2 to ad70b511da47793e27e77c1a69c7895e8403be45.
2019-03-04 tbarzic@chromium.org webui login: Remove lock screen app focus handling
2019-03-04 chrishtr@chromium.org [PE] Remove RunPostLayoutTasks enum.
2019-03-04 chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com Roll src-internal a72882291163..93bee44895a6 (2 commits)
2019-03-04 wutao@chromium.org app_list: Remove back button in dialog plate
2019-03-04 lpz@chromium.org Begin importing WPT runner codebase into Chromium.
2019-03-04 dmblack@google.com Moves more view delegation to AssistantViewDelegate.
2019-03-04 smaier@chromium.org Android: ensuring onDestroy called between tests
2019-03-04 fs@opera.com Remove TODO in svg_fe_convolve_matrix_element.idl
2019-03-04 ellyjones@chromium.org flags: remove windows10-custom-titlebar
2019-03-04 joenotcharles@google.com Add RESULT_CODE_TEST_ENGINE_SANDBOX_DISCONNECTED_TOO_SOON
2019-03-04 sadallst@microsoft.com Fixed bug where calling speak immediately after cancel would fail. The problem was that the windows speech API expects a NULL argument when only clearing the queue, otherwise it will try to speak the word given after flushing the queue, even if the word is an empty string.
2019-03-04 olivierrobin@chromium.org Disable failing tests in google_services_settings_egtests
2019-03-04 rdevlin.cronin@chromium.org [Extensions] Update updater owners
2019-03-04 xidachen@chromium.org [Code health] Remove an un-necessary lines in TestExpectations
2019-03-04 manucornet@chromium.org CrOS Shelf: Replace some test API calls with existing public APIs
2019-03-04 stevenjb@chromium.org NetworkStateHandler: Only scan when technology is enabled
2019-03-04 yigu@chromium.org [BlinkGenPropertyTrees] Mark compositing/overflow/overflow-scroll-with-local-background.html as flaky on Linux Debug
2019-03-04 rdevlin.cronin@chromium.org [Extensions Cleanup] Fix a couple typos
2019-03-04 thestig@chromium.org Fix various nits in print_browsertest.cc.
2019-03-04 orinj@chromium.org [omnibox] Remove flag omnibox::kEnableClipboardProvider
2019-03-04 manukh@chromium.org [omnibox chrome:omnibox]: Remove 'Copy as text' button.
2019-03-04 erikchen@chromium.org Remove broken priority adjustment code.
2019-03-04 katie@chromium.org Mark all images dirty when the user requests image annotations once.
2019-03-04 manukh@chromium.org [omnibox chrome:omnibox]: Add classifications for contents & description
2019-03-04 tbansal@chromium.org Resource Scheduler: Add metrics to record gap between non-delayable requests
2019-03-04 dtseng@chromium.org Add support for virtual accessibility hierarchies in Chrome OS using wrappers.
2019-03-04 csharrison@chromium.org Remove experiment_percentage for flatbuffers_unittests
2019-03-04 olivierrobin@chromium.org Register OfflinePageTabHelper as ReadingListModelObserver.
2019-03-04 newcomer@chromium.org Remove touchable app context menu flags
2019-03-04 yigu@chromium.org Revert "Disable flaky test AccessibilityWinBrowserTest.TestIScrollProvider"
2019-03-04 yigu@chromium.org Disable flaky test AccessibilityWinBrowserTest.TestIScrollProvider
2019-03-04 afakhry@chromium.org Virtual Desks 2.1: Desks mini views behavior.
2019-03-04 mrefaat@chromium.org Reland "Reduce the use of tabModel & Tab inside SideSwipeController"
2019-03-04 katie@chromium.org Updates autoclick ring widget size from movement threshold.
2019-03-04 syoussefi@chromium.org Enable EXT_sRGB webgl tests on ANGLE
2019-03-04 backer@chromium.org Seed the GPU fuzzers with SharedImages
2019-03-04 carlosil@chromium.org Call HandleSSLError without posting from nav throttle.
2019-03-04 pasko@chromium.org Revert "Add stacktrace scripts to telemetry isolate"
2019-03-04 bratell@opera.com Drop crash workaround for scrollbar clicking
2019-03-04 amithi@chromium.org Exposing RID attribute in RTCRtpCodingParameters.
2019-03-04 ellyjones@chromium.org flags: remove enable-background-blur
2019-03-04 sdefresne@chromium.org Convert away from method JSONReader::ReadDeprecated
2019-03-04 jinsukkim@chromium.org Android: Fix NPE accessing Tab
2019-03-04 tiborg@chromium.org [vr] Fix GVR JNI calls
2019-03-04 jennyz@chromium.org Fix the vk flashing issue when closing remove query dialog.
2019-03-04 chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com Roll src-internal c51a3ddd3012..a72882291163 (2 commits)
2019-03-04 ayui@chromium.org Replace deprecated RunLoop::QuitCurrentWhenIdleClosureDeprecated() with Quit[WhenIdle]Closure()
2019-03-04 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll src/third_party/angle 4d153383bd3a..0e1ce2e55387 (1 commits)
2019-03-04 bratell@opera.com Remove variable shadowing in blink/animation
2019-03-04 tangltom@chromium.org Remove GetAvatarIconForMenu()
2019-03-04 mlippautz@chromium.org unified-heap: Move all snapshot logic into cc file
2019-03-04 etienneb@chromium.org Move fonts related trace events in 'fonts' category
2019-03-04 mamir@chromium.org [Sync::USS] Merge local and remote passwords with the most recent
2019-03-04 lanwei@chromium.org Set ui::Event's coordinates correctly in SyntheticGestureTargetAura
2019-03-04 digit@google.com android: crazy_linker: Fix search path handling.
2019-03-04 bokan@chromium.org Fix doubletap-to-jump-forwards.html
2019-03-04 ellyjones@chromium.org flags: remove enable-content-suggestions-new-favicon-server
2019-03-04 eae@chromium.org [LayoutNG] Handle empty runs in LineLeftBounds
2019-03-04 lgrey@chromium.org Dark mode: update profile badge colors
2019-03-04 riajiang@chromium.org Include hit-test data for pointer-events:none regions and set Ignore.
2019-03-04 perezju@chromium.org [tools/perf] Disable failing load_accessibility:media:wikipedia:2018
2019-03-04 brianosman@google.com Use Skia drawing when doing conversion operations that may need dither
2019-03-04 tikuta@chromium.org [zip_analyzer] remove unused include
2019-03-04 kylechar@chromium.org Use base::BindOnce for Post[Delayed]TaskWithTraits callbacks.
2019-03-04 smcgruer@chromium.org Mark StylePropertyMapReadOnly methods const
2019-03-04 szermatt@chromium.org [Autofill Assistant] Allow scripts to specify Cancel or Close actions.
2019-03-04 xiaochengh@chromium.org Fix caret rendering when at the end of a block after an ineditable inline
2019-03-04 tangltom@chromium.org Refactor GetRandomAvatarIconIndex
2019-03-04 chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com Roll src-internal 794439738e8e..c51a3ddd3012 (2 commits)
2019-03-04 yigu@chromium.org Mark external/wpt/ambient-light/AmbientLightSensor.https.html flaky on debug bots
2019-03-04 tikuta@chromium.org [reading_list] remove unused deps
2019-03-04 msalama@google.com Android: Fix orderfile clankium bot failure.
2019-03-04 jkarlin@chromium.org [NetInfo] Fix memory leak
2019-03-04 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll src/third_party/webrtc 87e05b5df58c..b678940d3a44 (7 commits)
2019-03-04 yigu@chromium.org Mark external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/counter-styles-3/symbols-function.html as flaky
2019-03-04 mmenke@chromium.org Fix crash in ClientSocketPoolBaseHelper::GetLoadState.
2019-03-04 phweiss@google.com Remove VPN Disconnect button if VpnConfigAllowed is false
2019-03-04 jlebel@chromium.org [iOS] Updating "Change Accounts" string in the sign-in promo
2019-03-04 obrufau@igalia.com [css-grid] Always consider baseline shim for the minimum contribution
2019-03-04 bsalomon@google.com [SkiaRenderer] Remove usage of legacy promise image param and typename.
2019-03-04 bsazonov@chromium.org Add Android to the list of platforms for UnifiedConsent.
2019-03-04 bratell@opera.com Remove variable shadowing in blink/input
2019-03-04 huangs@chromium.org [Bundles] Add Bundle support to Trichrome Chrome
2019-03-04 backer@chromium.org Build RasterDecoder fuzzer with passthrough
2019-03-04 szermatt@chromium.org Fix ControllerTest.Stop fails on android-marshmallow-arm64-rel
2019-03-04 chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com Roll src-internal 2978aa5db94c..794439738e8e (1 commits)
2019-03-04 mslekova@chromium.org flags: assign harmony-await-optimization
2019-03-04 mamir@chromium.org [Sync::USS] Use correct the order in DCHECK_LE  in PasswordSyncBridge
2019-03-04 rayankans@chromium.org Update Background service proto with new schema.
2019-03-04 knollr@chromium.org Run pending tasks in ~TestBrowserThreadBundle.
2019-03-04 rayankans@chromium.org Create a protocol + handler for Background Service recording.
2019-03-04 jbroman@chromium.org Don't leak the device serial number in BrowserDMTokenStorageMac.
2019-03-04 backer@chromium.org Run video pixels tests with SkiaRenderer
2019-03-04 caitlinfischer@google.com [Autofill] Renamed files with shorter, more descriptive names.
2019-03-04 jonross@chromium.org Add Vulkan Integration Test on GPU FYI Bots
2019-03-04 treib@chromium.org Remove dead code from SyncTest
2019-03-04 lowell@chromium.org Make IdentityAccessorImplTest a friend of IdentityTestEnvironment.
2019-03-04 tonikitoo@igalia.com Generate <out>/gen/.../core/css/properties/css_property.cc|h using downcast helpers
2019-03-04 yigu@chromium.org Mark http/tests/security/xss-DENIED-cross-origin-stack-overflow.html non flaky
2019-03-04 stkhapugin@chromium.org Remove pre-UI Refresh code in Location Bar, Omnibox, Popup.
2019-03-04 tikuta@chromium.org [web_applications] remove unused deps
2019-03-04 jkarlin@chromium.org [NetInfo] Fix a broken browsertest
2019-03-04 gyuyoung@igalia.com BlinkMemoryMgt: Annotate Blink's platform/graphics with the macros of Allocator
2019-03-04 ellyjones@chromium.org flags: remove enable-gamepad-vibration from metadata
2019-03-04 chinglinyu@chromium.org Suppress memory pressure notifications when tab discarder is in action.
2019-03-04 treib@chromium.org Mark elements-panel-shadow-selection-on-refresh-[2,3].js flaky on Win and Linux
2019-03-04 chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com Roll src-internal 8d29f4238a2c..2978aa5db94c (2 commits)
2019-03-04 rayankans@chromium.org [Background Fetch] Remove cache migration DB task.
2019-03-04 ericrobinson@google.com Add a cpu task duration pipe for PageLoadMetricsObserver.
2019-03-04 javierrobles@chromium.org [iOS][MF] Pass only the needed origin.
2019-03-04 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll src/third_party/webrtc 4a42742dc6e4..87e05b5df58c (2 commits)
2019-03-04 olivierrobin@chromium.org Add VirtualURL to OpenURLCommand
2019-03-04 lowell@chromium.org Update IdentityManagerImpl to use IdentityManager::Observer.
2019-03-04 yoavweiss@chromium.org [Client hints] Move navigation CH logic to content
2019-03-04 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll src/third_party/dawn a8ce0a434e12..081d5c2f6480 (1 commits)
2019-03-04 chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com Roll src-internal 672eb32910a9..8d29f4238a2c (3 commits)
2019-03-04 sdefresne@chromium.org Remove LegacyMergeSigninCredentialIntoCookieJar()
2019-03-04 treib@chromium.org Revert "Add end-to-end browser tests for PluginVm setup flow"
2019-03-04 tikuta@chromium.org [deterministic] update whitelist
2019-03-04 jkim@igalia.com OnionSoup: Move app_banner.mojom in public/platform to public/mojom
2019-03-04 lowell@chromium.org Revert "Eliminate IdentityTestEnvironment's public complex constructor"
2019-03-04 treib@chromium.org Mark VideoPathTraceTest_DirectComposition_ComplexOverlays flaky on Win10
2019-03-04 treib@chromium.org Revert "DocumentLoader: commit navigation synchronously"
2019-03-04 myid.shin@igalia.com Change short to int16_t/int32_t in third_party/blink/renderer/core/css
2019-03-04 okalitova@chromium.org Add end-to-end browser tests for PluginVm setup flow
2019-03-04 bratell@opera.com Remove variable shadowing in blink/html
2019-03-04 chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com Roll src-internal 246fc71a449d..672eb32910a9 (1 commits)
2019-03-04 mrsuyi@chromium.org Add test asserts for WebClient in plugin_placeholder_inttest.
2019-03-04 jlebel@chromium.org [iOS] Moving the sync status from the account to Google services cell
2019-03-04 olivierrobin@chromium.org Offline page without native page content
2019-03-04 yhirano@chromium.org Revert "Fix HeadlessProtocolBrowserTest.VirtualTimeFetchStream"
2019-03-04 leon.han@intel.com [ServiceWorker] Apply provider hosts precreate/complete logic in tests
2019-03-04 pastarmovj@chromium.org Mark the Always Open PDFs externally to be a syncable pref.
2019-03-04 rhalavati@chromium.org Remove dead code from ProfileChooserView.
2019-03-04 v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update V8 to version 7.4.271.
2019-03-04 jkim@igalia.com fixup! OnionSoup: Move web_feature.mojom in public/platform to public/mojom
2019-03-04 myid.shin@igalia.com Change short/uint16_t to int16_t in third_party/blink/core/events/mouse_event.h and the related codes
2019-03-04 myid.shin@igalia.com Change short to int16_t in third_party/blink/renderer/platform/wtf/typed_arrays/int16_array.h
2019-03-04 mamir@chromium.org [Sync::USS] Adding the flag to enable USS Passwords on iOS
2019-03-04 jlebel@chromium.org [iOS] Removing preload feature from Sync and Google services
2019-03-04 fhorschig@chromium.org [Mfill Android] Add white scrolling shadows to accessory bar
2019-03-04 pkotwicz@chromium.org [Android WebAPK] Make WebappDirectoryManager work with new-style WebAPKs
2019-03-04 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll src/third_party/depot_tools da4dbf85f950..8f418985f120 (1 commits)
2019-03-04 justincohen@google.com [ios] Ignore NTP omnibox progress updates when the NTP isn't visible.
2019-03-04 wtlee@google.com Add hotkeys to launch dev-tool for Chrome Camera App
2019-03-04 fhorschig@chromium.org [Android][Tests] Move autofill integration test to keyboard_accessory/
2019-03-04 falken@chromium.org service worker: Remove kServiceWorkerServicification feature.
2019-03-04 falken@chromium.org service worker: Removed unused weak ptr for EmbeddedWorkerTestHelper.
2019-03-04 alancutter@chromium.org Make '/' focus search bar in History, Bookmarks, Downloads and Settings
2019-03-04 rhalavati@chromium.org Implement MemoryFileStreamReader.
2019-03-04 falken@chromium.org service worker: Return true in IsServicificationEnabled().
2019-03-04 treib@chromium.org Cleanup dependencies and includes in ProfileSyncServiceFactory
2019-03-04 wutao@chromium.org app_list: Assistant page to peeking when clicking scrim
2019-03-04 wutao@chromium.org app_list: Start Assistant in half or full state
2019-03-04 tkent@chromium.org Remove unnecessary blink:: in renderer/core/editing
2019-03-04 kbr@chromium.org Print the actual GL error (in hex) with --generate-dchecks.
2019-03-04 kbr@chromium.org Bind a clean vertex array object in YUVToRGBConverter.
2019-03-04 chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com Roll src-internal cbe8756f8a6d..246fc71a449d (1 commits)
2019-03-04 v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update V8 to version 7.4.270.
2019-03-04 rhalavati@chromium.org Implement ObfuscatedFileUtilMemoryDelegate.
2019-03-04 tkent@chromium.org Deprecate unimplemented -webkit-appearance keywords
2019-03-04 chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com Roll src-internal 50cfd59a72c7..cbe8756f8a6d (1 commits)
2019-03-04 bashi@chromium.org bindings: Remove Web Agent
2019-03-04 adanilo@chromium.org Add sub-menu arrow for sub-menu host items.
2019-03-04 abhijeet@igalia.com Generate 'platform_probe' sources to follow Blink coding style.
2019-03-04 falken@chromium.org Documentation: service worker performance
2019-03-04 dpapad@chromium.org WebUI cleanup: Remove dead code cr.LinkController.
2019-03-04 chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com Roll src-internal 85fe2405c4e4..50cfd59a72c7 (2 commits)
2019-03-04 lucmult@chromium.org [Files app] Convert ui/file_manager/integration_tests/ to arrow function
2019-03-04 kojii@chromium.org [auto] Update FlagExpectations for LayoutNG
2019-03-04 dstockwell@google.com pdf: Ensure annotation mode and rotation do not overlap
2019-03-04 abhijeet@igalia.com Generate 'core/probe' sources to follow Blink coding style.
2019-03-04 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll src/third_party/depot_tools e9e89e3aa538..da4dbf85f950 (1 commits)
2019-03-04 falken@chromium.org service worker: Bind Mojo interfaces using the WorkerThread's task runner.
2019-03-04 chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com Roll src-internal 8a2215122b55..85fe2405c4e4 (1 commits)
2019-03-04 harrisjay@chromium.org Parses file handling information from the manifest.
2019-03-04 chrome-release-bot@chromium.org Updating trunk VERSION from 3724.0 to 3725.0
2019-03-04 qinmin@chromium.org Fix a crash when resolving download display names
2019-03-04 lucmult@chromium.org [Files app] Convert ui/file_manager/integration_tests/ to let/const
2019-03-04 adanilo@chromium.org Adding keyboard nav between menu and sub menu.
2019-03-04 chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com Roll src-internal 9d54d4e02689..8a2215122b55 (1 commits)
2019-03-04 wzang@chromium.org cros: Do not show palette welcome bubble in public sessions
2019-03-04 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll src/third_party/dawn 1c92c159adf9..a8ce0a434e12 (1 commits)
2019-03-04 chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com Roll src-internal adaf99005d75..9d54d4e02689 (1 commits)
2019-03-04 chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com Roll src-internal 8518d46bdc51..adaf99005d75 (1 commits)
2019-03-04 jiameng@chromium.org [On-device adaptive brightness] Implement a ModelConfigLoader.
2019-03-04 falken@chromium.org service worker: Remove unused code in EmbeddedWorkerTestHelper.
2019-03-04 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll src/third_party/skia c1a9feb6f06e..5800f2e8a920 (2 commits)
2019-03-03 chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com Roll src-internal 086b87279975..8518d46bdc51 (2 commits)
2019-03-03 dfried@chromium.org Disable actions bar resize when it cannot be resized.
2019-03-03 metzman@chromium.org [libFuzzer][Windows] Assert is_asan is true
2019-03-03 joelhockey@chromium.org Fix login_utils_browsertest for renaming Contained Shell to Kiosk Next Shell
2019-03-03 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll src/third_party/skia 14f03d515823..c1a9feb6f06e (1 commits)
2019-03-03 chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com Roll src-internal ab0b469d2c84..086b87279975 (1 commits)
2019-03-03 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll src/third_party/perfetto 00da64ab2e55..82b33f4ea601 (1 commits)
2019-03-03 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll src/third_party/skia c6671be0ea75..14f03d515823 (1 commits)
2019-03-03 chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com Roll src-internal 2e1cc15680e6..ab0b469d2c84 (2 commits)
2019-03-03 yusufo@google.com Add unit tests for TabListMediator
2019-03-03 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll src/third_party/depot_tools 71bae22f623e..e9e89e3aa538 (1 commits)
2019-03-03 chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com Roll src-internal b3d3ddb6af8a..2e1cc15680e6 (1 commits)


Created with:
  gclient setdep -r ../src@8e3cddfd5a

The AutoRoll server is located here: https://autoroll.skia.org/r/chromium-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Perf-Mac10.13-Clang-MacBookPro11.5-GPU-RadeonHD8870M-x86_64-Release-All-CommandBuffer;skia.primary:Test-Mac10.13-Clang-MacBookPro11.5-GPU-RadeonHD8870M-x86_64-Debug-All-CommandBuffer
TBR=reed@google.com

Change-Id: Ia0e1b0213341a5e8c550edf632d95bf8b365b2ae
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/197083
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-03-04 21:44:05 +00:00
Hal Canary
197a39eac7 SkQP: fix androidx (follows 2ccdd2bc1d)
No-Try: true
Change-Id: Ifdcc96d4133f5b05b47665ee7bdd9fbd0c004b03
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/197011
Commit-Queue: Hal Canary <halcanary@google.com>
Reviewed-by: Hal Canary <halcanary@google.com>
2019-03-04 21:43:58 +00:00
Robert Phillips
193c421f2f Remove peekProxy's side-effect behavior
Prior to this CL peekProxy could cause the conversion of YUVA planes to RGBA. This switches peekProxy back to just peeking.

In future Ganesh asTextureProxyRef is going to require a GrRecordingContext (bc it can actually do work). The options were to either add a GrRecordingContext parameter to peekProxy or remove its ability to do work (as in this CL).

Change-Id: I42d7dcd41f7c99a7712446d3f6629ffde91bfe5b
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/197105
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
2019-03-04 21:38:54 +00:00
skia-autoroll
e1c6d464cc Roll third_party/externals/swiftshader 823ca85404fb..bb305299f4de (1 commits)
https://swiftshader.googlesource.com/SwiftShader.git/+log/823ca85404fb..bb305299f4de


git log 823ca85404fb..bb305299f4de --date=short --no-merges --format='%ad %ae %s'
2019-03-04 chrisforbes@google.com Fix culling to match Vulkan convention


Created with:
  gclient setdep -r third_party/externals/swiftshader@bb305299f4de

The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Test-Debian9-Clang-GCE-GPU-SwiftShader-x86_64-Debug-All-SwiftShader
TBR=reed@google.com

Change-Id: Ic3d88c352fe562fb8908e13eca9099a02c7cb48b
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/197081
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-03-04 21:38:52 +00:00
skia-recreate-skps
e3e80b7edf Update go_deps asset
Automatic commit by the UpdateGoDEPS bot.

TBR=borenet@google.com

Change-Id: Ie6af3c493df45dda589956005c835efe4a0d5a05
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/196961
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
2019-03-04 21:33:48 +00:00
recipe-roller
df0f362438 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
depot_tools:
  https://crrev.com/da4dbf85f95051345f147cfe69d909d85e81a429 autoninja: limit j value for mac (tikuta@chromium.org)
recipe_engine:
  https://crrev.com/ae3604f2d2ae0291ecdc690672cc173e06a965ba [proto_support] Handle unicode filesystem walks. (iannucci@chromium.org)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I8e683b0559c9f4a8247e298c01cf2d095ddea99c
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/197019
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
2019-03-04 21:33:45 +00:00
Mike Reed
5800f2e8a9 Reland "use colorspace steps to determine legacy blits"
This reverts commit c945f0e31a.

Reason for revert: looks like this did not help

Original change's description:
> Revert "use colorspace steps to determine legacy blits"
> 
> This reverts commit 0919852526.
> 
> Reason for revert: speculative: unblock android roll
> 
> Original change's description:
> > use colorspace steps to determine legacy blits
> > 
> > Bug: skia:8793
> > Change-Id: I1de4bde25f7dcb12175733a3213c43f92410dc4a
> > Reviewed-on: https://skia-review.googlesource.com/c/196647
> > Commit-Queue: Mike Reed <reed@google.com>
> > Reviewed-by: Mike Klein <mtklein@google.com>
> > Reviewed-by: Brian Osman <brianosman@google.com>
> 
> TBR=mtklein@google.com,brianosman@google.com,reed@google.com
> 
> Change-Id: I79a21df9a3c3a9f3127f57131feff0f3e417e642
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: skia:8793
> Reviewed-on: https://skia-review.googlesource.com/c/196774
> Reviewed-by: Mike Reed <reed@google.com>
> Commit-Queue: Mike Reed <reed@google.com>

TBR=mtklein@google.com,brianosman@google.com,reed@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: skia:8793
Change-Id: I2b70c6e3763bf27112b54ed0d0611a6addc755b9
Reviewed-on: https://skia-review.googlesource.com/c/196981
Reviewed-by: Mike Reed <reed@google.com>
2019-03-03 22:13:00 +00:00