3 Commits

Author	SHA1	Message	Date
John Stiles	08070f6f65	Report the correct line number when vardecls have an error. ... Previously, the Type's fOffset was set to -1 during parsing, so any errors related to the Type would be reported on line 1. Change-Id: I9834f733bc763c5946b3ff81d8aef4807cdc13d1 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/335584 Commit-Queue: John Stiles <johnstiles@google.com> Commit-Queue: Brian Osman <brianosman@google.com> Auto-Submit: John Stiles <johnstiles@google.com> Reviewed-by: Brian Osman <brianosman@google.com>	2020-11-17 16:32:23 +00:00
Brian Osman	034f78a466	Detect non-2D textures in MetalCodeGenerator and fail cleanly ... We were letting this get further, then asserting. Bug: skia:10797 Change-Id: Iff6fe43aa32450b5a517c94773031d593f1f62a2 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/321794 Commit-Queue: Brian Osman <brianosman@google.com> Auto-Submit: Brian Osman <brianosman@google.com> Reviewed-by: John Stiles <johnstiles@google.com>	2020-10-02 20:36:04 +00:00
John Stiles	aeae3a58e3	Add golden outputs for the Metal backend. ... This CL also updates the blend tests to use sk_FragColor instead of returning a half4, as the Metal backend assumes that a fragment processor's `main` will return void and always synthesizes a `return *_out;` at the end. (context link: https://osscs.corp.google.com/android/platform/superproject/+/master:external/skqp/src/sksl/SkSLMetalCodeGenerator.cpp;l=803;drc=842d31b14159626054e01dd32826563a8f4214bf ) BYPASS_INCLUSIVE_LANGUAGE_REASON=see http://b/168134166 Change-Id: I330a456bf25ee72d3a29c59cd624625378ae80a0 Bug: skia:10649, skia:10757, skia:10758, skia:10759, skia:10760, skia:10761, skia:10762 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/319409 Commit-Queue: John Stiles <johnstiles@google.com> Reviewed-by: Ethan Nicholas <ethannicholas@google.com>	2020-09-25 17:46:43 +00:00