Commit Graph

8 Commits

Author SHA1 Message Date
Kevin Lubick
daa9717416 [infra] Cleanup better after BuildStats
Followup to https://skia-review.googlesource.com/c/skia/+/436816

Change-Id: I564c5a160588e5d9f843e297bf04baea50024dc5
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/436896
Reviewed-by: Eric Boren <borenet@google.com>
2021-08-05 13:22:22 +00:00
Eric Boren
a1db799824 Fix Python3 compatibility
Bug: skia:11768
Change-Id: I6107362457dce380e3fb1647ad58d8e33e453e2d
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/388743
Commit-Queue: Eric Boren <borenet@google.com>
Reviewed-by: Ravi Mistry <rmistry@google.com>
2021-03-25 14:15:35 +00:00
Ravi Mistry
441f3c72d7 Set "binary_size_plugin" output.property on Build-Stats-* bots
* The output.property looks like this: {"canvaskit.wasm": 7394679}
  (from https://ci.chromium.org/raw/build/logs.chromium.org/skia/5236eb95c4490b11/+/annotations)

* Refactored scripts to avoid hardcoding the magic_seperator and total_size_bytes.

* Added this capability to all 4 infra/bots/buildstats/* scripts.

* Added missing tests for analyze_web_file and analyze_cpp_lib.


The output.property will be eventually consumed by a Gerrit plugin to display change in bytes in the UI.

Note: buildstats_cpp.py is not currently used by any bot. But if it is in the future it will work.

No-Tree-Checks: true
Bug: skia:11744
Change-Id: I593bae8ff73c35089cc2785a1cc4bc5b630007c4
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/377840
Commit-Queue: Ravi Mistry <rmistry@google.com>
Reviewed-by: Kevin Lubick <kjlubick@google.com>
2021-03-14 23:26:38 +00:00
Kevin Lubick
402bf74ea8 Build code size treemaps for skottie_tool
Bug: skia:
Change-Id: I3364fa6b89674f65bf493467198740e1862d215e
Reviewed-on: https://skia-review.googlesource.com/c/191291
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2019-02-12 13:54:00 +00:00
Kevin Lubick
8875baf99d Add Bloaty (with demangling) for wasm BuildStats
The bloaty here was compiled with this patch:
https://github.com/google/bloaty/pull/149

Hopefully that lands upstream and we can track master again.

This adds BuildStats.+Debug because we need symbols
to get sensical data. Bloaty's WASM support is experimental
and currently doesn't support having a stripped (Release)
version be profiled using the symbols of a Debug version.

This means that the buildStats for debug will be higher
than actual, but hopefully the absolute positioning will be
the same and thus the outputs useful.

Bug: skia:
Change-Id: Id7bf721843e8c52a0aae2b7e57ff95397693b3dd
Reviewed-on: https://skia-review.googlesource.com/c/163256
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
2018-10-18 19:00:38 +00:00
Kevin Lubick
3655e4059e Have BuildStats use Flutter's stripped lib
That's what their treemap says and we should try to match it.

Bug: skia:
Change-Id: Iefa95c0440eb6b45a94a72c1beffb8a1199152a4
Reviewed-on: https://skia-review.googlesource.com/c/161825
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
2018-10-12 21:32:54 +00:00
Kevin Lubick
2626104520 Track Skia's Code size in Flutter
This creates a nice readable display, since Bloaty
doesn't allow filtering through the CLI.

Additionally, rename the flutter job to accurately
represent what settings it actually is (32 bit ARM built
with clang).

Bug: skia:
Change-Id: Iaed313caf43a31105adc8c85c545cc6cb2bcbe30
Reviewed-on: https://skia-review.googlesource.com/c/160920
Reviewed-by: Mike Klein <mtklein@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
2018-10-10 14:24:57 +00:00
Kevin Lubick
6ca0d8a767 Add BuildStats job for Mini
Bug: skia:
Change-Id: Ibb47179315d191af5023039212e4c9b5e784bb75
Reviewed-on: https://skia-review.googlesource.com/c/160765
Reviewed-by: Eric Boren <borenet@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
2018-10-09 17:33:46 +00:00