We ended up with two SkEmptyTypefaces it differnt places. Avoid this odr violation by sticking these in anonymous namespaces. Review URL: https://codereview.chromium.org/1887093002
The typeface cache contains typefaces which can be compared against to determine if an already known typeface will work instead of creating a new typeface id. This is primarily for sharing scaler contexts. How that typeface was requested is not relevant to this comparison, so don't cache it. Request caching must be handled separately. GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1879423002 Review URL: https://codereview.chromium.org/1879423002
DOCS_PREVIEW= https://skia.org/?cl=1316233002 Review URL: https://codereview.chromium.org/1316233002
DM builds all of {bench,gm,test}/*.cpp. A Windows build warned us that we were trying to link typeface.obj twice. This must have something to do with there existing gm/typeface.cpp and tests/Typeface.cpp. To be safe, make sure tests have a Test.cpp suffix to disambiguate. BUG=skia: R=rmistry@google.com, mtklein@google.com Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/185923002 git-svn-id: http://skia.googlecode.com/svn/trunk@13644 2bbb7eff-a529-9590-31e7-b0007b416f81
