mtklein
3da80f5ecd
Only run recipe simulation tests if infra/ changes.
...
This should lessen the need for mortals to have coverage.py,
and saves 1.8s (of 3.6s) on my desktop for this non-infra change.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2187713002
Review-Url: https://codereview.chromium.org/2187713002
2016-07-27 04:14:07 -07:00
reed
eb560284c5
add unittests for roundtripping premul
...
BUG=skia:5579
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2179123005
Review-Url: https://codereview.chromium.org/2179123005
2016-07-26 19:42:04 -07:00
fmalita
6ceef3dd67
Initial SVG model
...
A minimal subset needed to render tiger.svg: <svg>, <g>, <path>, 'd', 'fill'/'stroke' (color-only), 'transform'.
R=reed@google.com ,robertphillips@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2164193002
Review-Url: https://codereview.chromium.org/2164193002
2016-07-26 18:46:34 -07:00
csmartdalton
fc49d56feb
Implement coverage AA for skewed rects with local coords
...
Adds a path fallback for rects with local coords that can't be drawn
with an analytic shader. This is accomplished by modifying the view
matrix and then drawing the local rect/quad.
BUG=skia:5500, 7508
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2183223002
Review-Url: https://codereview.chromium.org/2183223002
2016-07-26 17:05:47 -07:00
jcgregorio
aef94d1818
Avoid warnings on GCC 4.8.4
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2183243002
[mtklein adds...]
TBR=reed@google.com
No public API changes.
Review-Url: https://codereview.chromium.org/2183243002
2016-07-26 14:10:17 -07:00
mtklein
1211e0ca74
Start on fiddle.
...
Mostly stolen from Joe.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2188493002
Review-Url: https://codereview.chromium.org/2188493002
2016-07-26 13:55:45 -07:00
msarett
ae76f49a76
Make yasm-android executable
...
TBR=mtklein@google.com
NOTRY=true
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2188583002
Review-Url: https://codereview.chromium.org/2188583002
2016-07-26 13:46:16 -07:00
msarett
75a5ff63f7
Rename yasm binary and make it executable
...
TBR=mtklein@google.com
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2187663002
Review-Url: https://codereview.chromium.org/2187663002
2016-07-26 13:33:46 -07:00
jvanverth
141a14e3e6
Update iOS to new SkSurface interface
...
BUG=skia:5558
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2179363003
Review-Url: https://codereview.chromium.org/2179363003
2016-07-26 13:33:07 -07:00
mtklein
7fd93e349a
Start measuring f16 and srgb speed.
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2181073003
Review-Url: https://codereview.chromium.org/2181073003
2016-07-26 13:05:31 -07:00
bsalomon
6c471f75b2
Add sw support to viewer on Linux.
...
This doesn't yet do anything with srgb/colorspace.
Replaces the --vulkan flag with --backend which takes 'gl', 'vk', or 'sw'.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2165813002
Review-Url: https://codereview.chromium.org/2165813002
2016-07-26 12:56:32 -07:00
mtklein
1b51e0ec46
Move SkJSONCPP.h to tools. It tool-only.
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2184483003
CQ_INCLUDE_TRYBOTS=master.client.skia.compile:Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot,Build-Mac-Clang-x86_64-Release-CMake-Trybot
TBR=reed@google.com
Review-Url: https://codereview.chromium.org/2184483003
2016-07-26 12:41:27 -07:00
reed
e93393b311
don't specialize drawBitmapRect for minirecorder; no longer called by blink
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2183193002
Review-Url: https://codereview.chromium.org/2183193002
2016-07-26 12:21:10 -07:00
bsalomon
d1bdd1fcbd
Use Windowing system-specific WindowContext factories.
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2169543002
Review-Url: https://codereview.chromium.org/2169543002
2016-07-26 12:02:51 -07:00
borenet
1ed2ae45f5
Move Skia recipes from build repo
...
BUG=skia:5563
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2175373002
Review-Url: https://codereview.chromium.org/2175373002
2016-07-26 11:52:17 -07:00
robertphillips
7e92276554
Reduce usage of MakeRenderTargetDirect
...
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2187573002
Review-Url: https://codereview.chromium.org/2187573002
2016-07-26 11:38:17 -07:00
brianosman
3a0dbde1cf
Remove SkSurfaceProps gamma-correctness flag entirely.
...
This is no longer required - gamma-correctness is now just based on the
presence or absence of a color space.
Public API change is just removal of (unused) flag.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2188463002
TBR=bsalomon@google.com
Review-Url: https://codereview.chromium.org/2188463002
2016-07-26 11:36:05 -07:00
msarett
dc2257bfab
Fix yasm for Android build
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2180333002
Review-Url: https://codereview.chromium.org/2180333002
2016-07-26 11:24:28 -07:00
borenet
917d6f3005
Fix docs for checking out Skia
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2179023003
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=2179023003
Review-Url: https://codereview.chromium.org/2179023003
2016-07-26 11:11:50 -07:00
brianosman
9dc935fa11
Remove all usage of SkSurfaceProps::isGammaCorrect()
...
DrawContext's isGammaCorrect now just based on presence of color space.
Next change will remove the function and flag entirely, but I wanted to
land this separately. This alters a few GMs in srgb/f16 mode, generally
those that are creating off-screen surfaces in ways that were somewhat
lossy before. No unexplained changes.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2186633002
Review-Url: https://codereview.chromium.org/2186633002
2016-07-26 10:21:55 -07:00
mtklein
a5e1e33d39
Fix alignment problems in NEON Sk4b.
...
As written at head, the compiler can assume these loads and stores are 4
byte aligned [1]. We want Sk4b to load from any 1-byte aligned address,
to prevent crashes like [2].
[1] https://llvm.org/bugs/show_bug.cgi?id=24421
[2] https://luci-milo.appspot.com/swarming/task/304079e125b1b910/steps/nanobench/0/stdout
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2183133002
CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
Review-Url: https://codereview.chromium.org/2183133002
2016-07-26 10:07:34 -07:00
caryclark
e25a4f6cbe
fix fuzz bugs
...
Add ability for intersection template to detect that
the test contains bounded numbers so that extra
asserts can trigger.
Add some exit points for out of range numbers
in those templates.
TBR=reed@google.com
BUG=631383,631374,631360
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2185703002
Review-Url: https://codereview.chromium.org/2185703002
2016-07-26 09:26:29 -07:00
bsalomon
eeb4c387dd
Don't unnecessarily resize windows in sk_app on X
...
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2182163002
Review-Url: https://codereview.chromium.org/2182163002
2016-07-26 08:50:27 -07:00
egdaniel
26318c984f
Update bleed-downscale GM to use power of 2 texture
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2179303004
Review-Url: https://codereview.chromium.org/2179303004
2016-07-26 08:26:46 -07:00
brianosman
efded51cd8
Always supply a color space (sRGB for now) with F16
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2177193004
Review-Url: https://codereview.chromium.org/2177193004
2016-07-26 08:11:50 -07:00
mtklein
f660b7cfcf
Add Sk4h_load4 for loading F16.
...
Should feel very similar to Sk4h_store4:
NEON uses its native instruction, SSE unpacks manually.
Since we'll have our F16s in 4 Sk4h by the time we're done here,
this also extracts an Sk4h->Sk4f routine from the old uint64_t->Sk4f one.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2184753002
CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
Review-Url: https://codereview.chromium.org/2184753002
2016-07-26 08:01:20 -07:00
robertphillips
8c523e0f3f
Move prepareForExternalIO from GrRenderTarget to GrDrawContext
...
This is part of the push to remove GrRenderTarget from SkGpuDevice
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2182543003
Review-Url: https://codereview.chromium.org/2182543003
2016-07-26 07:41:01 -07:00
egdaniel
707bbd622b
Reuse sampler descriptor set allocations in Vulkan
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2172873003
Review-Url: https://codereview.chromium.org/2172873003
2016-07-26 07:19:48 -07:00
brianosman
fe8d2cf520
Add special Windows instructions for getting SKPs
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2184723002
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=2184723002
Review-Url: https://codereview.chromium.org/2184723002
2016-07-26 06:43:51 -07:00
reed
27efa2371e
respect kFast_SrcRectConstraint by allowing shader access to entire bitmap
...
BUG=355305
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2176193002
Review-Url: https://codereview.chromium.org/2176193002
2016-07-25 19:10:10 -07:00
msarett
a18c3b8306
Use sk_srgb_to_linear_trunc in SkColorXform_opts
...
This gives us a little more control over instruction order, allowing
us to pipeline the muls and get better performance. Technically,
clang should be able to do this for us anyway...
Performance on HP z620 (201295.jpg):
toSRGB: 371us -> 356us
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2175413002
CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
Review-Url: https://codereview.chromium.org/2175413002
2016-07-25 18:58:11 -07:00
msarett
3418c0e797
Delete SkDefaultXform, handle edge cases in SkColorSpaceXform_Base
...
"Edge" cases include:
(1) Matrices with translation
(2) colorLUTs
Performance on HP z620:
201295.jpg
to2Dot2: 386us -> 414us
toSRGB: 346us -> 371us
toHalf: 282us -> 302us
strange0-translate.jpg
toSRGB: 1060us -> 244us
strange1-colorLUT.jpg
toSRGB: 2.74ms -> 2.00ms
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2177173003
CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
Review-Url: https://codereview.chromium.org/2177173003
2016-07-25 18:23:18 -07:00
brianosman
9ac6d8d9f1
Fix F16 raster text masks. We don't want fake gamma in that case.
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2184443002
Review-Url: https://codereview.chromium.org/2184443002
2016-07-25 17:41:44 -07:00
bungeman
b8113780c3
Update typeface serialization style.
...
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2030683002
Committed: https://skia.googlesource.com/skia/+/7ae1c72e593823e6e300e4199558555765bcec17
Review-Url: https://codereview.chromium.org/2030683002
2016-07-25 16:54:59 -07:00
mtklein
0f7748ab38
DM: print which task caused the crash.
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2177843003
Review-Url: https://codereview.chromium.org/2177843003
2016-07-25 15:27:29 -07:00
bungeman
6e45bda29e
Add test for typeface style round trip.
...
This also fixes the CG and GDI ports so they pass the test.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2171163002
Review-Url: https://codereview.chromium.org/2171163002
2016-07-25 15:11:49 -07:00
mtklein
4e90e3eb5e
Have SkRasterPipelineBlitter take over for F16 when it can.
...
3 minor diffs to a couple GMs from fixed transfermodes (arithmetic and plus).
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2181033002
Review-Url: https://codereview.chromium.org/2181033002
2016-07-25 14:35:31 -07:00
reed
bd2bd5c56d
lock special-raster while the caller's bitmap is in-scope
...
previous CL that removed the specialimage subclass that wrapped the original image: https://codereview.chromium.org/2164073004
BUG=skia:5574
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2183483003
Review-Url: https://codereview.chromium.org/2183483003
2016-07-25 14:26:02 -07:00
halcanary
56586b6f3d
SkPDF: re-work SkPDFUtils::FloatToDecimal
...
* do a lot less floating-point math by converting to
an integer as early as possible [faster].
* round rather than truncate.
* use 8 significant digits rather than 9 when possible.
* remove trailing zeros in fractions.
before:
0.12 ! PDFScalar nonrendering
after:
0.07 ! PDFScalar nonrendering
Accuracy guaranteed by existing unit test.
Example diffs:
-/Shading <</Function <</C0 [.321568638 .333333343 .321568638]
+/Shading <</Function <</C0 [.32156864 .33333334 .32156864]
-/C1 [.258823543 .270588248 .258823543]
+/C1 [.25882354 .27058825 .25882354]
-1 0 0 -1 20 120.394500 Tm
+1 0 0 -1 20 120.394501 Tm
-1 0 0 -1 20 184.789001 Tm
+1 0 0 -1 20 184.789 Tm
-291.503997 0 l
+291.504 0 l
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2146103004
Review-Url: https://codereview.chromium.org/2146103004
2016-07-25 13:59:30 -07:00
mtklein
1ab9e59da0
Google3 <functional> has a global "using std::plus"...
...
... so we can't use the name plus(). -_-
TBR=tomhudson@google.com
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2183453003
Review-Url: https://codereview.chromium.org/2183453003
2016-07-25 13:24:09 -07:00
brianosman
8fe485b793
Just pass the draw context to paint conversion
...
Concentrate on using draw context functionality to answer gamma and color
related queries in more places.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2182603003
Review-Url: https://codereview.chromium.org/2182603003
2016-07-25 12:31:51 -07:00
chrishtr
20a272d024
Fix debugger build by specifying nullptr for color space.
...
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2181733002
Review-Url: https://codereview.chromium.org/2181733002
2016-07-25 11:21:34 -07:00
mtklein
64665440ef
stages for most xfermodes
...
also assumes the clamp from https://codereview.chromium.org/2178793002/ is present
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2177103002
Review-Url: https://codereview.chromium.org/2177103002
2016-07-25 11:00:47 -07:00
ethannicholas
d598f7981f
SkSL performance improvements (plus a couple of minor warning fixes)
...
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2131223002
Committed: https://skia.googlesource.com/skia/+/9fd67a1f53809f5eff1210dd107241b450c48acc
Review-Url: https://codereview.chromium.org/2131223002
2016-07-25 10:08:54 -07:00
reed
d9ddad2952
add SK_SUPPORT_LEGACY_BITMAP_GETTEXTURE for out-of-date google3 callers
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2177993002
Review-Url: https://codereview.chromium.org/2177993002
2016-07-25 09:41:58 -07:00
reed
c7ec7c9cab
remove/deprecate SkBitmap::getTexture, as it now always returns false
...
oh happy day
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2175873002
Review-Url: https://codereview.chromium.org/2175873002
2016-07-25 08:29:10 -07:00
reed
2adecda92b
add gm to test bleed with downscale
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2182503002
TBR=
Review-Url: https://codereview.chromium.org/2182503002
2016-07-25 08:11:58 -07:00
reed
2c9e20055b
remove fClipStack and attach/deattach-from-canvas
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2180793002
Review-Url: https://codereview.chromium.org/2180793002
2016-07-25 08:05:23 -07:00
halcanary
d0e95a524c
typedef uint16_t SkGlyphID
...
This goes well with our existing `typedef int32_t SkUnichar`.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2095263003
Review-Url: https://codereview.chromium.org/2095263003
2016-07-25 07:18:12 -07:00
benjaminwagner
1d35231e7b
Remove long-running sk_linear_to_srgb test for ASAN in public.bzl.
...
This unit test takes >~5m and causes the ASAN test to time out.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2175303002
Review-Url: https://codereview.chromium.org/2175303002
2016-07-25 06:32:13 -07:00