epoger@google.com
80f9cf18cc
rebaseline.py: add bug-filing URL to error message
...
R=bsalomon@google.com
Review URL: https://codereview.chromium.org/23968002
git-svn-id: http://skia.googlecode.com/svn/trunk@11133 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-06 17:26:09 +00:00
epoger@google.com
7f5f6e6e30
Revert r11102 (mistakenly committed)
...
git-svn-id: http://skia.googlecode.com/svn/trunk@11103 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-05 17:19:37 +00:00
epoger@google.com
e5ee52e1f0
whitespace-only fix to manually-modified GM expectations
...
git-svn-id: http://skia.googlecode.com/svn/trunk@11102 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-05 17:18:08 +00:00
epoger@google.com
d73531a722
svndiff.py: properly handle empty expectations dictionary
...
BUG=skia:1588
R=jvanverth@google.com
Review URL: https://codereview.chromium.org/23769005
git-svn-id: http://skia.googlecode.com/svn/trunk@11078 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-04 16:27:16 +00:00
epoger@google.com
c206dfcf01
Add forgotten file from https://code.google.com/p/skia/source/detail?r=11063
...
Review URL: https://codereview.chromium.org/23911002
git-svn-id: http://skia.googlecode.com/svn/trunk@11064 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-03 18:31:25 +00:00
epoger@google.com
93acfd2b49
rebaseline.py: fix --add-new when there are no expectations at all
...
BUG=skia:1582
R=rmistry@google.com
Review URL: https://codereview.chromium.org/23899003
git-svn-id: http://skia.googlecode.com/svn/trunk@11063 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-03 18:27:19 +00:00
epoger@google.com
06e626d69e
rebaseline.py: add --bugs and --unreviewed flags
...
BUG=skia:1569
R=borenet@google.com
Review URL: https://codereview.chromium.org/23478011
git-svn-id: http://skia.googlecode.com/svn/trunk@11058 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-03 17:32:15 +00:00
sglez@google.com
3e3cdadefd
Fix rtree bench
...
R=caryclark@google.com
Review URL: https://codereview.chromium.org/23609009
git-svn-id: http://skia.googlecode.com/svn/trunk@11041 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-30 18:38:53 +00:00
sglez@google.com
ffb71f2dd5
Fix rtree tests build error
...
Review URL: https://codereview.chromium.org/23531019
git-svn-id: http://skia.googlecode.com/svn/trunk@11038 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-30 17:43:31 +00:00
sglez@google.com
8c902126a9
R-Tree -- Don't sort draw commands unless specified.
...
We expect Webkit and Bink to give us draw commands in a reasonable x,y order.
We can maintain correctness and get a 17% recording speedup for the R-Tree by
not sorting in x and y when bulk-loading.
R=caryclark@google.com , reed@google.com
Review URL: https://codereview.chromium.org/23480002
git-svn-id: http://skia.googlecode.com/svn/trunk@11037 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-30 17:27:47 +00:00
commit-bot@chromium.org
a6f37e77c1
Add ShouldSkip variant that can read a --match flag directly.
...
Just seemed like we were going through lots of hoops for this common case.
BUG=
R=scroggo@google.com
Author: mtklein@google.com
Review URL: https://chromiumcodereview.appspot.com/23708009
git-svn-id: http://skia.googlecode.com/svn/trunk@11034 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-30 15:52:46 +00:00
borenet@google.com
9f6c23e34e
Stop running bench_pictures with msaa4 on Galaxy Nexus
...
Hopefully this works around https://code.google.com/p/skia/issues/detail?id=1560
R=robertphillips@google.com
Review URL: https://codereview.chromium.org/23449017
git-svn-id: http://skia.googlecode.com/svn/trunk@11023 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-30 13:19:18 +00:00
epoger@google.com
8209b183da
rebaseline.py self-test: validate that unknown fields are maintained
...
BUG=skia:1569
R=bsalomon@google.com
Review URL: https://codereview.chromium.org/23702006
git-svn-id: http://skia.googlecode.com/svn/trunk@11008 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-29 18:04:20 +00:00
epoger@google.com
3f0a108586
Remove temporary workaround TODOs from tools/tests/run.sh
...
R=rmistry@google.com
Review URL: https://codereview.chromium.org/23490009
git-svn-id: http://skia.googlecode.com/svn/trunk@10989 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-28 19:04:05 +00:00
scroggo@google.com
cd7a73c200
Test decoders when hasLength returns false.
...
Compare the result of a decode of a stream without a length to the
result of the same stream with a length. Ensures that our decoders
work regardless of whether hasLength returns true (since the decode
potentially follows two paths).
R=epoger@google.com
Review URL: https://codereview.chromium.org/23598004
git-svn-id: http://skia.googlecode.com/svn/trunk@10984 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-28 18:33:31 +00:00
commit-bot@chromium.org
6241754c84
bbh_shootout: Move bitmap rendering out of the timing codepath.
...
R=reed@google.com
Author: sglez@google.com
Review URL: https://chromiumcodereview.appspot.com/23639003
git-svn-id: http://skia.googlecode.com/svn/trunk@10983 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-28 16:02:47 +00:00
robertphillips@google.com
a99aba7d55
Remove less then useful configs from bench_pictures runs
...
https://codereview.chromium.org/23618004/
git-svn-id: http://skia.googlecode.com/svn/trunk@10973 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-28 12:31:49 +00:00
epoger@google.com
44f165f6ce
temporarily hard-code builder list in rebaseline.py, for quick startup
...
BUG=skia:1544
R=borenet@google.com
Review URL: https://codereview.chromium.org/22866023
git-svn-id: http://skia.googlecode.com/svn/trunk@10908 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-24 20:45:31 +00:00
mtklein@google.com
330313a8a8
My clang now doesn't complain about !"foo".
...
BUG=
R=robertphillips@google.com
Review URL: https://codereview.chromium.org/22875037
git-svn-id: http://skia.googlecode.com/svn/trunk@10874 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-22 15:37:26 +00:00
epoger@google.com
c192aa4937
Update references to buildbot globals deprecated by r10856
...
R=borenet@google.com
Review URL: https://codereview.chromium.org/23011035
git-svn-id: http://skia.googlecode.com/svn/trunk@10860 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-21 17:35:59 +00:00
epoger@google.com
fd040116c5
Remove base-* directories from gm expected/actual paths; just use platform names
...
BUG=skia:1512
The buildbot master continues to set gm_image_subdir, but the slaves no longer
use that component when building GM paths (they just use builder_name instead).
But gm_image_subdir is still used for SKP storage paths under
gs://chromium-skia-gm/playback/gm-actual , for now...
Immediately before committing this CL, I will copy the actual-results.json files
from their old locations to their new locations (within the skia-autogen repo)
so that both old and new versions of rebaseline.py will be able to retrieve
actual results, like so:
svn cp base-android-galaxy-nexus/Test-Android-GalaxyNexus-SGX540-Arm7-Debug/base-android-galaxy-nexus Test-Android-GalaxyNexus-SGX540-Arm7-Debug
svn cp base-android-galaxy-nexus/Test-Android-GalaxyNexus-SGX540-Arm7-Release/base-android-galaxy-nexus Test-Android-GalaxyNexus-SGX540-Arm7-Release
svn cp base-android-nexus-10/Test-Android-Nexus10-MaliT604-Arm7-Debug/base-android-nexus-10 Test-Android-Nexus10-MaliT604-Arm7-Debug
...
svn cp base-shuttle-win7-intel-float/Test-Win7-ShuttleA-HD2000-x86-Debug/base-shuttle-win7-intel-float Test-Win7-ShuttleA-HD2000-x86-Debug
svn cp base-shuttle-win7-intel-float/Test-Win7-ShuttleA-HD2000-x86-Release/base-shuttle-win7-intel-float Test-Win7-ShuttleA-HD2000-x86-Release
Once we see this CL land successfully, I will delete the actual-results.json
files from their OLD location within skia-autogen, like so:
svn rm base-android-galaxy-nexus
svn rm base-android-nexus-10
...
svn rm base-shuttle-win7-intel-directwrite
svn rm base-shuttle-win7-intel-float
R=borenet@google.com , rmistry@google.com
Review URL: https://codereview.chromium.org/23120002
git-svn-id: http://skia.googlecode.com/svn/trunk@10821 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-20 16:21:55 +00:00
commit-bot@chromium.org
2e915b3234
Add correctness test to bbh_shootout.
...
R=caryclark@google.com , reed@google.com
Author: sglez@google.com
Review URL: https://chromiumcodereview.appspot.com/23121002
git-svn-id: http://skia.googlecode.com/svn/trunk@10809 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-20 12:23:18 +00:00
commit-bot@chromium.org
fe87fb8a33
fix path issues on mac and win for skpdiff_server.py
...
R=djsollen@google.com , epoger@google.com , jvanverth@google.com
Author: zachr@google.com
Review URL: https://chromiumcodereview.appspot.com/22650009
git-svn-id: http://skia.googlecode.com/svn/trunk@10719 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-14 19:20:35 +00:00
epoger@google.com
8e6b7c3c98
Delete compare_baselines.py and download_baselines.py ; we use rebaseline.py now
...
Review URL: https://codereview.chromium.org/23082002
git-svn-id: http://skia.googlecode.com/svn/trunk@10714 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-14 18:14:31 +00:00
borenet@google.com
065224dbf3
Add Android config for Intel RHB
...
Corresponding buildbot change: https://codereview.chromium.org/22840005/
R=djsollen@google.com
Review URL: https://codereview.chromium.org/23046003
git-svn-id: http://skia.googlecode.com/svn/trunk@10699 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-13 20:32:22 +00:00
zachr@google.com
74c5ab19fd
add ui for mutli-rebaselining
...
R=epoger@google.com
Review URL: https://codereview.chromium.org/22580004
git-svn-id: http://skia.googlecode.com/svn/trunk@10618 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-07 18:06:39 +00:00
zachr@google.com
6f8e2c5e87
download and rebaseline images using server
...
BUG=
R=epoger@google.com
Review URL: https://codereview.chromium.org/20654006
git-svn-id: http://skia.googlecode.com/svn/trunk@10607 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-07 15:43:04 +00:00
scroggo@google.com
6d99de11c4
Add config option to skimage.
...
Allows testing 565 and A8, in addition to 8888.
Also makes the preference consistent for each test (in one run).
BUG=skia:1465
R=djsollen@google.com
Review URL: https://codereview.chromium.org/22297007
git-svn-id: http://skia.googlecode.com/svn/trunk@10579 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-06 18:56:53 +00:00
scroggo@google.com
e339eb054b
Do not fail skimage on missing expectations.
...
This will allow adding new images to test without turning the bots
red.
R=epoger@google.com
Review URL: https://codereview.chromium.org/22301006
git-svn-id: http://skia.googlecode.com/svn/trunk@10578 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-06 18:51:30 +00:00
epoger@google.com
2a192a8577
Delete image-based rebaselining tool; we have switched to checksums
...
R=borenet@google.com
Review URL: https://codereview.chromium.org/21901004
git-svn-id: http://skia.googlecode.com/svn/trunk@10524 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-02 20:54:46 +00:00
scroggo@google.com
65e508d0b1
Restore a default timer to bench_pictures.
...
https://codereview.chromium.org/19862002 removed the default timer
to display from PictureBenchmark. Restore a default by putting it
in the flag description.
R=mtklein@google.com
Review URL: https://codereview.chromium.org/21567005
git-svn-id: http://skia.googlecode.com/svn/trunk@10516 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-02 16:09:10 +00:00
zachr@google.com
a479aa1366
fix skpdiff viewer bug when using relative paths
...
BUG=skia:1463
R=djsollen@google.com
Review URL: https://codereview.chromium.org/21601002
git-svn-id: http://skia.googlecode.com/svn/trunk@10515 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-02 15:54:30 +00:00
commit-bot@chromium.org
74f96b9c4c
Added 3-color gradient scraper for detecting symmetrical gradients.
...
Made changes to lua to scrape info about 3 color gradients
BUG=
R=reed@google.com
Author: dierk@google.com
Review URL: https://chromiumcodereview.appspot.com/21571002
git-svn-id: http://skia.googlecode.com/svn/trunk@10490 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-01 17:32:56 +00:00
commit-bot@chromium.org
55fd612adf
Committed: http://code.google.com/p/skia/source/detail?r=10372
...
R=borenet@google.com , bungeman@google.com , robertphillips@google.com , scroggo@google.com , sglez@google.com
Author: bsalomon@google.com
Review URL: https://chromiumcodereview.appspot.com/19862002
git-svn-id: http://skia.googlecode.com/svn/trunk@10473 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-31 20:00:56 +00:00
bungeman@google.com
0abbff9987
Fix metrics on Windows.
...
With this change, Skia's metrics are much better in general, and
specifically can be made to match the metrics produced by current
Blink code. This allows Blink to use Skia's metrics.
This change will require a number of rebaselines in Skia, since
previous metrics were quite different. This will require about five
rebaslines in Blink, as the new code may cause GDI's matrix to differ
in the low bits.
Review URL: https://codereview.chromium.org/20585004
git-svn-id: http://skia.googlecode.com/svn/trunk@10399 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-27 20:37:56 +00:00
zachr@google.com
785ef5d521
process gm expectation violations
...
R=epoger@google.com
Review URL: https://codereview.chromium.org/20527002
git-svn-id: http://skia.googlecode.com/svn/trunk@10395 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-26 19:29:39 +00:00
humper@google.com
0f48ee0a07
add more stats to the bitmap matrix locator
...
BUG=
R=reed@google.com
Review URL: https://codereview.chromium.org/19091006
git-svn-id: http://skia.googlecode.com/svn/trunk@10392 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-26 15:23:43 +00:00
bsalomon@google.com
68f2a0df14
This reverts commit 4052fd051db67bd1099fde2c4fe400cfbe1f2426.
...
git-svn-id: http://skia.googlecode.com/svn/trunk@10374 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-25 21:30:52 +00:00
commit-bot@chromium.org
47fad70da3
R=borenet@google.com, bungeman@google.com, robertphillips@google.com
...
Author: bsalomon@google.com
Review URL: https://chromiumcodereview.appspot.com/19862002
git-svn-id: http://skia.googlecode.com/svn/trunk@10372 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-25 20:01:20 +00:00
zachr@google.com
48b8891194
add basic HTTP server for viewing skpdiff results
...
R=epoger@google.com
Review URL: https://codereview.chromium.org/19929007
git-svn-id: http://skia.googlecode.com/svn/trunk@10371 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-25 19:49:17 +00:00
zachr@google.com
55173f2ecc
fix trailing comma in outptu of SkDiffContext
...
R=djsollen@google.com
Review URL: https://codereview.chromium.org/20324004
git-svn-id: http://skia.googlecode.com/svn/trunk@10361 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-25 17:22:58 +00:00
commit-bot@chromium.org
ff36a1d07f
Start from scratch on a faster SkFlatDictionary.
...
This is like codereview.chromium.org/19276003, except it fits in better with the existing code, doesn't leak memory, and because it's back using SkChunkFlatController it's a little faster too, now a win across the board:
Slowdown bench
-1.59% desk_youtubetvbrowse.skp
-2.56% desk_googlehome.skp
-6.40% tabl_androidpolice.skp
-6.45% desk_youtubetvvideo.skp
-6.91% tabl_googlecalendar.skp
...
-29.70% desk_yahoogames.skp
-32.17% desk_googlespreadsheet.skp
-32.23% mobi_wikipedia.skp
-37.16% desk_chalkboard.skp
-41.57% desk_pokemonwiki.skp
Overall slowdown: -22.74%
running bench [640 480] picture_record_recurring_paint_dictionary NONRENDERING: cmsecs = 9.92
running bench [640 480] picture_record_unique_paint_dictionary NONRENDERING: cmsecs = 22.16
running bench [640 480] picture_record_dictionaries NONRENDERING: cmsecs = 9.18
BUG=
Committed: http://code.google.com/p/skia/source/detail?r=10328
R=tomhudson@google.com , reed@google.com , scroggo@google.com
Author: mtklein@google.com
Review URL: https://chromiumcodereview.appspot.com/19564007
git-svn-id: http://skia.googlecode.com/svn/trunk@10336 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-24 20:37:30 +00:00
epoger@google.com
c60e745356
rebaseline.py: add ability to write new expectations to a different file
...
(instead of overwriting the original expectations file)
R=zachr@google.com
Review URL: https://codereview.chromium.org/19805007
git-svn-id: http://skia.googlecode.com/svn/trunk@10333 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-24 19:36:51 +00:00
mtklein@google.com
5174286bc5
Revert "Start from scratch on a faster SkFlatDictionary."
...
This reverts commit fec9bfa02d5d2b27bfa2dad3e37e5825a720784d.
git-svn-id: http://skia.googlecode.com/svn/trunk@10331 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-24 19:11:15 +00:00
commit-bot@chromium.org
cae5d8d570
Start from scratch on a faster SkFlatDictionary.
...
This is like codereview.chromium.org/19276003, except it fits in better with the existing code, doesn't leak memory, and because it's back using SkChunkFlatController it's a little faster too, now a win across the board:
Slowdown bench
-1.59% desk_youtubetvbrowse.skp
-2.56% desk_googlehome.skp
-6.40% tabl_androidpolice.skp
-6.45% desk_youtubetvvideo.skp
-6.91% tabl_googlecalendar.skp
...
-29.70% desk_yahoogames.skp
-32.17% desk_googlespreadsheet.skp
-32.23% mobi_wikipedia.skp
-37.16% desk_chalkboard.skp
-41.57% desk_pokemonwiki.skp
Overall slowdown: -22.74%
running bench [640 480] picture_record_recurring_paint_dictionary NONRENDERING: cmsecs = 9.92
running bench [640 480] picture_record_unique_paint_dictionary NONRENDERING: cmsecs = 22.16
running bench [640 480] picture_record_dictionaries NONRENDERING: cmsecs = 9.18
BUG=
R=tomhudson@google.com , reed@google.com , scroggo@google.com
Author: mtklein@google.com
Review URL: https://chromiumcodereview.appspot.com/19564007
git-svn-id: http://skia.googlecode.com/svn/trunk@10328 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-24 18:45:27 +00:00
sglez@google.com
586db93c44
refactor duplication (shouldSkip and skip_name) into a utility function
...
R=caryclark@google.com , reed@google.com
Committed: https://code.google.com/p/skia/source/detail?r=10280
Review URL: https://codereview.chromium.org/19807005
git-svn-id: http://skia.googlecode.com/svn/trunk@10317 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-24 17:24:23 +00:00
reed@google.com
5fdc983f58
expose shaders
...
git-svn-id: http://skia.googlecode.com/svn/trunk@10312 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-24 15:47:52 +00:00
epoger@google.com
27e1c0070d
rebaseline.py: set text mimetype for all .json files, so text diffs work
...
BUG=https://code.google.com/p/skia/issues/detail?id=1442
R=fmalita@google.com
Review URL: https://codereview.chromium.org/20017009
git-svn-id: http://skia.googlecode.com/svn/trunk@10311 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-24 15:38:39 +00:00
edisonn@google.com
d2d9f563be
skpdiff: remove default value for output. Diifs can be very big, and fill a hard drive, no sense to generate them if not needed.
...
R=zachr@google.com
Review URL: https://codereview.chromium.org/20054003
git-svn-id: http://skia.googlecode.com/svn/trunk@10291 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-23 20:15:08 +00:00
epoger@google.com
e94a7d2936
Move gm-expected to trunk/expectations/gm , and modify scripts that use it.
...
Left dummy content in the old gm-expected dir to keep Update step happy,
to avoid the breakages caused by r10281.
R=borenet@google.com
Review URL: https://codereview.chromium.org/19668009
git-svn-id: http://skia.googlecode.com/svn/trunk@10288 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-23 19:37:03 +00:00