bungeman
a9bf1aadcd
Tolerate unstarted builds in rebaseline server.
...
Currently server.py --rietveld-issue will crash if there are any
unstarted trybots on the latest patch. Instead of crashing, warn
that the bot hasn't started yet.
Review URL: https://codereview.chromium.org/758793003
2014-12-05 07:14:53 -08:00
skia.buildbots
0be41a06d7
Update SKP version
...
Automatic commit by the RecreateSKPs bot.
TBR=
Review URL: https://codereview.chromium.org/781043002
2014-12-04 23:03:33 -08:00
jvanverth
b35760e286
Ignore failures for n7 and n10 dftext GM.
...
BUG=skia:3188
TBR=halcanary@google.com
Review URL: https://codereview.chromium.org/785433002
2014-12-04 16:01:53 -08:00
bsalomon
c92aadcf9a
clean up default precision handling
...
R=joshualitt@google.com
Review URL: https://codereview.chromium.org/766753006
2014-12-04 13:02:47 -08:00
joshualitt
eb2a676165
Remove backend factories
...
BUG=skia:
Review URL: https://codereview.chromium.org/778453002
2014-12-04 11:35:34 -08:00
mtklein
e109145bf3
nanobench: upload peak memory usage as its own trace.
...
We'll end up with a result like this:
"memory_usage" : {
"meta" : {
"max_rss_mb" : 57
}
}
BUG=skia:
Review URL: https://codereview.chromium.org/780013002
2014-12-04 10:47:02 -08:00
jvanverth
787cdf9ab0
Ganesh text rendering cleanup.
...
Rename GrTextStrike.{cpp.h} to GrFontCache.{cpp,h}
Move contents of GrTextStrike_impl.h to GrFontCache.h
Move glyph uploading to a separate function and remove harmful gotos
Add assert on glyph upload failure (shouldn't happen)
Review URL: https://codereview.chromium.org/780923002
2014-12-04 10:46:52 -08:00
halcanary
32fee2907e
rebaseline pdf-native
...
TBR=
NOTRY=true
Review URL: https://codereview.chromium.org/779073002
2014-12-04 10:41:45 -08:00
joshualitt
87f48d997e
create and thread batch tracker object
...
I remove the factory on the next CL
BUG=skia:
Committed: https://skia.googlesource.com/skia/+/c3a6eb23483e5d28073b509a5f637f41660de294
Review URL: https://codereview.chromium.org/772513002
2014-12-04 10:41:40 -08:00
halcanary
4b8128ce9a
pdf-mac clear to black rebaseline
...
NOTRY=true
TBR=
NOTREECHECKS=true
Review URL: https://codereview.chromium.org/783543002
2014-12-04 10:21:04 -08:00
joshualitt
dafa4d09cb
move program descriptor generation to flush
...
BUG=skia:
Committed: https://skia.googlesource.com/skia/+/829e1b80b1020b17f2078020c990e079b70c077c
Review URL: https://codereview.chromium.org/777673003
2014-12-04 08:59:10 -08:00
mtklein
051e56df8f
Upload picture byte size and op count metrics for SKP recording.
...
Look okay?
{
"results" : {
"desk_amazon.skp_1264_3999" : {
"nonrendering" : {
"bytes" : 75656,
"max_ms" : 1.150187,
"mean_ms" : 1.150187,
"median_ms" : 1.150187,
"min_ms" : 1.150187,
"ops" : 659,
"options" : {
"bench_type" : "recording",
"clip" : "0 0 1000 1000",
"name" : "desk_amazon.skp",
"scale" : "1",
"source_type" : "skp"
}
}
},
...
BUG=skia:
Review URL: https://codereview.chromium.org/773323002
2014-12-04 08:46:51 -08:00
robertphillips
eeb6f0c3c0
Rebaseline multipicturedraw GMs
...
This is clean up after https://codereview.chromium.org/753253002/ (Use variable length key (rather than accumulated matrix) as save layer hoisting key)
TBR=halcanary@google.com
Review URL: https://codereview.chromium.org/783523002
2014-12-04 08:43:54 -08:00
reed
b19ce3146c
quick fix to land clear() change
...
BUG=skia:
TBR=
NOTRY=True
Review URL: https://codereview.chromium.org/774863003
2014-12-04 08:39:09 -08:00
robertphillips
63242d7d24
Fix SKPBench tiling so MPD and non-MPD match
...
Two issues with the SKPBench tile computation were causing the MPD path to do more work:
The clip from the parent canvas wasn't being used to trim content off the edges of the MPD tiles
The non-MPD path was not taking the scale into account in its tile placement (resulting in it having fewer, larger active tiles when scaling).
Review URL: https://codereview.chromium.org/776273002
2014-12-04 08:31:03 -08:00
reed
89dee4298e
check (thread-tricky) colortable after we've copied the bitmap into a per-thread context
...
BUG=skia:
Review URL: https://codereview.chromium.org/766283004
2014-12-04 08:06:18 -08:00
mtklein
c88cedaf88
Fix up RecordReplaceDrawTest memory leak.
...
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu12-ShuttleA-GTX550Ti-x86_64-Release-Valgrind/builds/151/steps/dm/logs/stdio
BUG=skia:
Review URL: https://codereview.chromium.org/779973002
2014-12-04 07:53:21 -08:00
reed
8eddfb50c0
Change clear() to respect the clip
...
This reverts commit af641a1c10
.
BUG=skia:
TBR=
Review URL: https://codereview.chromium.org/783493002
2014-12-04 07:50:14 -08:00
qiankun.miao
60f3c657cc
Add SSSE3 acceleration for S32_D16_filter_DXDY
...
With this CL, related nanobench can be improved for 565 config.
bitmap_BGRA_8888_scale_rotate_bilerp 115us -> 70.5us 0.61x
bitmap_BGRA_8888_update_volatile_scale_rotate_bilerp 115us -> 70.5us 0.61x
bitmap_BGRA_8888_update_scale_rotate_bilerp 112us -> 68us 0.6x
BUG=skia:
Committed: https://skia.googlesource.com/skia/+/45a05780867a06b9f8a8d5240cf6c5d5a2c15a35
Review URL: https://codereview.chromium.org/773753002
2014-12-04 06:27:03 -08:00
joshualitt
f78c60c92a
Revert of move program descriptor generation to flush (patchset #7 id:120001 of https://codereview.chromium.org/777673003/ )
...
Reason for revert:
breaking linux build
Original issue's description:
> move program descriptor generation to flush
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/829e1b80b1020b17f2078020c990e079b70c077c
TBR=egdaniel@google.com ,bsalomon@google.com,joshualitt@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/776243005
2014-12-04 06:01:45 -08:00
joshualitt
841a6b54c1
Revert of create and thread batch tracker object (patchset #9 id:160001 of https://codereview.chromium.org/772513002/ )
...
Reason for revert:
Breaking linux layout test
Original issue's description:
> create and thread batch tracker object
>
> I remove the factory on the next CL
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/c3a6eb23483e5d28073b509a5f637f41660de294
TBR=bsalomon@google.com ,joshualitt@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/774133003
2014-12-04 06:00:41 -08:00
reed
b8eb85cd2f
make clear private (before we delete it)
...
BUG=skia:
Review URL: https://codereview.chromium.org/781593002
2014-12-04 03:48:34 -08:00
skia.buildbots
748ea60790
Update SKP version
...
Automatic commit by the RecreateSKPs bot.
TBR=
Review URL: https://codereview.chromium.org/776873006
2014-12-03 23:04:09 -08:00
jam
9da051ad41
Revert of Add SSSE3 acceleration for S32_D16_filter_DXDY (patchset #3 id:40001 of https://codereview.chromium.org/773753002/ )
...
Reason for revert:
breaks build when not using SSE3, since the two method definitions differ in parameter types (typo)
Original issue's description:
> Add SSSE3 acceleration for S32_D16_filter_DXDY
>
> With this CL, related nanobench can be improved for 565 config.
> bitmap_BGRA_8888_scale_rotate_bilerp 115us -> 70.5us 0.61x
> bitmap_BGRA_8888_update_volatile_scale_rotate_bilerp 115us -> 70.5us 0.61x
> bitmap_BGRA_8888_update_scale_rotate_bilerp 112us -> 68us 0.6x
>
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/45a05780867a06b9f8a8d5240cf6c5d5a2c15a35
TBR=mtklein@google.com ,qkmiao@gmail.com,qiankun.miao@intel.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/761103003
2014-12-03 15:56:36 -08:00
joshualitt
c3a6eb2348
create and thread batch tracker object
...
I remove the factory on the next CL
BUG=skia:
Review URL: https://codereview.chromium.org/772513002
2014-12-03 15:34:20 -08:00
joshualitt
829e1b80b1
move program descriptor generation to flush
...
BUG=skia:
Review URL: https://codereview.chromium.org/777673003
2014-12-03 13:57:37 -08:00
reed
e5750729e4
Revert of Revert of remove unused device::eraseColor (patchset #1 id:1 of https://codereview.chromium.org/777003002/ )
...
Reason for revert:
fix landed in chrome to allow this (I hope)
Original issue's description:
> Revert of remove unused device::eraseColor (patchset #1 id:1 of https://codereview.chromium.org/765643004/ )
>
> Reason for revert:
> ../../skia/ext/bitmap_platform_device_cairo.cc:131:13: error: no member named 'eraseColor' in 'skia::BitmapPlatformDevice'
>
>
> Original issue's description:
> > remove unused device::eraseColor
> >
> > BUG=skia:
> > TBR=
> >
> > Committed: https://skia.googlesource.com/skia/+/b1ab276c3719d6690e58f347c25126d2b8929c5d
>
> TBR=reed@google.com
> NOTREECHECKS=true
> NOTRY=true
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/8b0197ef2e32be9d62e79d58f8b50811975c79c6
TBR=halcanary@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/779543004
2014-12-03 13:17:29 -08:00
tfarina
9ed02e40d1
Add SK_SUPPORT_LEGACY_PORTER_DUFF macro.
...
This trick will be used to remove deprecated SkPorterDuff API. But first
we need to add it so Android can be updated later.
BUG=skia:3178
R=scroggo@google.com
Review URL: https://codereview.chromium.org/758133004
2014-12-03 13:13:02 -08:00
mtklein
4f10844149
Turn on MPD threading in nanobench.
...
Seems okay after this small patch to skip lockPixels() / unlockPixels().
BUG=skia:3149
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu13.10-GCE-NoGPU-x86_64-Release-TSAN-Trybot
Review URL: https://codereview.chromium.org/773203003
2014-12-03 13:07:39 -08:00
egdaniel
4de8a4dcf7
Remove guard on and enable vertexAttrib function pts on GrGLInterface.
...
BUG=skia:
Review URL: https://codereview.chromium.org/774303003
2014-12-03 12:22:51 -08:00
egdaniel
c016fb8f9f
Use static XPF for porter duff xp factories.
...
BUG=skia:
Review URL: https://codereview.chromium.org/776843004
2014-12-03 11:41:55 -08:00
mtklein
96a6c4df41
Copy src in SkDrawLooper::computeFastBounds().
...
We do alias src and dst when building the BBH. This meant we calculated
the wrong bounds in LayoutTests/ietestcenter/css3/text/textshadow-010.htm.
Not sure how best to test this inside Skia. It may become moot after I
work through the API changes we were talking about today, but if not I'll
make sure it's tested somehow before I'm done with SkDrawLoopers.
BUG=skia:3186
Review URL: https://codereview.chromium.org/760023004
2014-12-03 11:08:47 -08:00
halcanary
85a5750ffa
Fix PdfViewer BGR byte order
...
BUG=skia:3184
Review URL: https://codereview.chromium.org/775763003
2014-12-03 11:03:52 -08:00
bsalomon
ee64d6ef49
Add glGetShaderPrecisionFormat
...
Review URL: https://codereview.chromium.org/778703003
2014-12-03 10:46:08 -08:00
halcanary
8b0197ef2e
Revert of remove unused device::eraseColor (patchset #1 id:1 of https://codereview.chromium.org/765643004/ )
...
Reason for revert:
../../skia/ext/bitmap_platform_device_cairo.cc:131:13: error: no member named 'eraseColor' in 'skia::BitmapPlatformDevice'
Original issue's description:
> remove unused device::eraseColor
>
> BUG=skia:
> TBR=
>
> Committed: https://skia.googlesource.com/skia/+/b1ab276c3719d6690e58f347c25126d2b8929c5d
TBR=reed@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/777003002
2014-12-03 10:41:11 -08:00
egdaniel
378092f3d1
Add XferProcessor factory in GrPaint and GrDrawState.
...
In this CL the XP should have zero effect on the actual rendering pipeline.
BUG=skia:
Review URL: https://codereview.chromium.org/751283002
2014-12-03 10:40:13 -08:00
Brian Salomon
5ab7e80f2b
rebaseline images
...
TBR=
Review URL: https://codereview.chromium.org/776983003
2014-12-03 13:36:10 -05:00
jvanverth
3e5d4a124c
Update color emoji GMs after https://codereview.chromium.org/759613005/ .
...
TBR=halcanary@google.com
Review URL: https://codereview.chromium.org/775163002
2014-12-03 10:35:37 -08:00
reed
b1ab276c37
remove unused device::eraseColor
...
BUG=skia:
TBR=
Review URL: https://codereview.chromium.org/765643004
2014-12-03 09:47:48 -08:00
joshualitt
ed8bdc5193
bug fix for cubic low precision
...
TBR=
BUG=skia:
Review URL: https://codereview.chromium.org/776953002
2014-12-03 09:29:53 -08:00
halcanary
e2158a52e9
update tileimagefilter gm expectations
...
TBR=reed@google.com
NOTRY=true
Review URL: https://codereview.chromium.org/777683002
2014-12-03 08:59:48 -08:00
mtklein
4bfd58723b
Decompose a weird assert.
...
I got my hands on a list of new warnings coming out of MSVC when run with /analyze.
I scanned over them and didn't see any bugs, but I did notice this is just a weird
way to write this expression. (MSVC /analyze was wary of '=' in a boolean expression.)
BUG=skia:
Review URL: https://codereview.chromium.org/776033002
2014-12-03 08:48:57 -08:00
Mike Klein
43c79b9c64
Rebaseline verylargebitmap
...
BUG=skia:
Review URL: https://codereview.chromium.org/778693002
2014-12-03 11:32:37 -05:00
mtklein
a89a95eb72
Remove unused constants.
...
BUG=skia:
Review URL: https://codereview.chromium.org/773193004
2014-12-03 08:18:46 -08:00
halcanary
cd948b56c9
(re)baseline several of my gms
...
TBR=
NOTRY=true
Review URL: https://codereview.chromium.org/780593002
2014-12-03 08:17:58 -08:00
robertphillips
e99d499caa
Fuse GrReplacements and GrLayerCache
...
The conversion step from GrCachedLayer to ReplacementInfo isn't necessary.
Review URL: https://codereview.chromium.org/769533004
2014-12-03 07:33:57 -08:00
joshualitt
2dd1ae016d
First step to moving vertex attributes to the geometryProcessor
...
BUG=skia:
Review URL: https://codereview.chromium.org/761563002
2014-12-03 06:24:10 -08:00
kkinnunen
960fb50a1a
Make debugger not fail with webpages_playback script and multiple skp files
...
The debugger accepts either a single skp or a directory as a parameter.
The webpages_playback script used to pass multiple files using a '*'
glob.
Review URL: https://codereview.chromium.org/775073002
2014-12-03 06:18:12 -08:00
kkinnunen
fcf35c533b
Update webpages_playback documentation
...
Update the documentation on how to run webpages_playback. It was out of
date.
Review URL: https://codereview.chromium.org/778633002
2014-12-03 05:51:24 -08:00
kkinnunen
e75d2d2d99
Remove Google Storage scheme prefix correctly from gs base name in webpages_playback
...
In python, str.lstrip([chars]) means "lstrip any of the chars from str",
not "remove prefix". Thus "gs://skia".lstrip("gs://") yields "kia".
Replace with custom function stripping the prefix from lstrip()ed gs
base name.
Review URL: https://codereview.chromium.org/780493002
2014-12-03 04:38:46 -08:00