scroggo@google.com
9dfac2366d
Suppress test output.
...
This output is for debugging purposes, and does not report an error.
BUG=skia:1616
Review URL: https://codereview.chromium.org/24110003
git-svn-id: http://skia.googlecode.com/svn/trunk@11292 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-16 17:36:39 +00:00
caryclark@google.com
570863f2e2
path ops work in progress
...
path ops work in progress
BUG=
Review URL: https://codereview.chromium.org/21359002
git-svn-id: http://skia.googlecode.com/svn/trunk@11291 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-16 15:55:01 +00:00
mtklein@google.com
cf78540576
rebaseline radial_gradient2
...
BUG=
Review URL: https://codereview.chromium.org/24099003
git-svn-id: http://skia.googlecode.com/svn/trunk@11290 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-16 14:55:15 +00:00
robertphillips@google.com
1588354a87
Compiler fix for r11288
...
git-svn-id: http://skia.googlecode.com/svn/trunk@11289 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-16 14:42:48 +00:00
robertphillips@google.com
24ddde9758
Revert 11247, 11250, 11251, 11257, and 11279 to unblock DEPS roll ( https://codereview.chromium.org/24159002/ )
...
11279 Sanitizing source files in Housekeeper-Nightly - https://code.google.com/p/skia/source/detail?r=11279
11257 Canary build fix - https://codereview.chromium.org/23532068
11251 More warnings as errors fixes - https://code.google.com/p/skia/source/detail?r=11251
11250 Warnings as errors fix - https://code.google.com/p/skia/source/detail?r=11250
11247 Initial error handling code - https://chromiumcodereview.appspot.com/23021015
git-svn-id: http://skia.googlecode.com/svn/trunk@11288 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-16 14:04:05 +00:00
robertphillips@google.com
ba6e954140
Revert the revert of 11247, 11250, 11251 and 11279 (Chrome already relies on changes in r11247)
...
git-svn-id: http://skia.googlecode.com/svn/trunk@11287 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-16 13:40:12 +00:00
robertphillips@google.com
478884f7d3
Revert 11247, 11250, 11251 and 11279 to unblock DEPS roll ( https://codereview.chromium.org/24159002/ )
...
11279 Sanitizing source files in Housekeeper-Nightly - https://code.google.com/p/skia/source/detail?r=11279
11251 More warnings as errors fixes - https://code.google.com/p/skia/source/detail?r=11251
11250 Warnings as errors fix - https://code.google.com/p/skia/source/detail?r=11250
11247 Initial error handling code - https://chromiumcodereview.appspot.com/23021015
git-svn-id: http://skia.googlecode.com/svn/trunk@11285 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-16 13:19:11 +00:00
mtklein@google.com
3ef7eeac9a
Split radial_gradients2 GM into two to reproduce its bug.
...
Android HW rendering seems to be taking the premul-first path, while
Skia takes the interpolate-first path (both SW and HW).
BUG=
R=reed@google.com
Review URL: https://codereview.chromium.org/23637008
git-svn-id: http://skia.googlecode.com/svn/trunk@11284 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-16 13:02:52 +00:00
skia.committer@gmail.com
469fec8fee
Sanitizing source files in Housekeeper-Nightly
...
git-svn-id: http://skia.googlecode.com/svn/trunk@11282 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-15 07:01:33 +00:00
epoger@google.com
cd7838d3cb
Fix mimetype on expectations live-viewer
...
(SkipBuildbotRuns)
git-svn-id: http://skia.googlecode.com/svn/trunk@11281 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-15 02:22:05 +00:00
epoger@google.com
7687a83272
Add live Javascript viewer for GM expectations
...
BUG=skia:1599
This is similar to the live viewer for GM actuals, at
https://skia-autogen.googlecode.com/svn/gm-actual/view.html
It will be the basis for GM expectations analysis as described in bug 1599.
R=rmistry@google.com
Review URL: https://codereview.chromium.org/23493024
git-svn-id: http://skia.googlecode.com/svn/trunk@11280 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-15 02:18:07 +00:00
skia.committer@gmail.com
dc9888c409
Sanitizing source files in Housekeeper-Nightly
...
git-svn-id: http://skia.googlecode.com/svn/trunk@11279 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-14 07:01:34 +00:00
epoger@google.com
6a1f89717c
Rebaseline single GM test: Test-Mac10.6-MacMini4.1-GeForce320M-x86-Release__gradients_local_perspective_pdf-poppler
...
See http://c128.i.corp.google.com/skia/pixeldiffs/gradients_local_perspective/diffs/
TBR=bsalomon
Review URL: https://codereview.chromium.org/23457009
git-svn-id: http://skia.googlecode.com/svn/trunk@11278 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-13 21:15:17 +00:00
epoger@google.com
be4ec742e8
Rebaseline known-bad hairline-gpu GM test on ASAN
...
Marked as unreviewed and ignore-failure
See http://c128.i.corp.google.com/skia/pixeldiffs/hairmodes/diffs/
TBR=bsalomon
Review URL: https://codereview.chromium.org/23619053
git-svn-id: http://skia.googlecode.com/svn/trunk@11277 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-13 21:06:00 +00:00
epoger@google.com
7251743209
Rebaseline GM tests for Test-Mac10.6-MacMini4.1-GeForce320M-x86_64-Release
...
See http://c128.i.corp.google.com/skia/pixeldiffs/Test-Mac10.6-MacMini4.1-GeForce320M-x86_64-Release/diffs/
TBR=bsalomon
Review URL: https://codereview.chromium.org/24078010
git-svn-id: http://skia.googlecode.com/svn/trunk@11276 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-13 20:56:54 +00:00
epoger@google.com
7c18494634
Rebaseline known-bad scaled_tilemodes tests on GalaxyNexus
...
TBR=bsalomon
Review URL: https://codereview.chromium.org/24038005
git-svn-id: http://skia.googlecode.com/svn/trunk@11275 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-13 20:50:33 +00:00
epoger@google.com
f7d859aebd
Rebaseline scaled_tilemode_gradient GM tests
...
See http://c128.i.corp.google.com/skia/pixeldiffs/scaled_tilemode_gradient/diffs/
Review URL: https://codereview.chromium.org/23661006
git-svn-id: http://skia.googlecode.com/svn/trunk@11273 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-13 20:41:16 +00:00
mtklein@google.com
9ef1d21dc8
OK windows, please take my infinity.
...
BUG=
Review URL: https://codereview.chromium.org/23526045
git-svn-id: http://skia.googlecode.com/svn/trunk@11272 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-13 20:39:50 +00:00
epoger@google.com
7e72693a6d
Rebaseline "lighting" GM tests
...
See diffs at http://c128.i.corp.google.com/skia/pixeldiffs/lighting/diffs/
TBR=bsalomon
Review URL: https://codereview.chromium.org/23441069
git-svn-id: http://skia.googlecode.com/svn/trunk@11271 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-13 20:36:24 +00:00
rmistry@google.com
91042c26ca
Whitespace change to test commits.
...
(SkipBuildbotRuns)
Review URL: https://codereview.chromium.org/23522045
git-svn-id: http://skia.googlecode.com/svn/trunk@11269 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-13 20:29:55 +00:00
mtklein@google.com
dbd41c8857
It looks like we're not always running long enough to give the GPU counters time to converge (and possibly the same for CPU too, but GPU is definitely worse off).
...
This CL changes our convergence logic from
- did the last run take more than x milliseconds?
to
- did the last run take more x milliseconds and are the last two runs within y% of each other?
There's also now an upper limit where we bail out with an error if we haven't yet met the convergence criteria. Keeping the lower bound is important for benches where the constant overhead is much larger than the work done in the loop; without it we'll see T(1 loop) == T(2 loops) and converge way too early.
This CL also exposed that DeferredCanvasBench had a bug: it was running N^2 loops when we told it to run N. (My fault.)
I threw in a couple other linty changes that I'd be happy to split off.
BUG=
R=robertphillips@google.com
Review URL: https://codereview.chromium.org/23536046
git-svn-id: http://skia.googlecode.com/svn/trunk@11267 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-13 20:11:09 +00:00
epoger@google.com
3ad5dd009f
Speed up GM ~50% by NOT running most renderModes by default
...
BUG=skia:1566
R=borenet@google.com , bsalomon@google.com
Review URL: https://codereview.chromium.org/23889030
git-svn-id: http://skia.googlecode.com/svn/trunk@11265 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-13 19:56:14 +00:00
mtklein@google.com
410e6e80f0
Refactoring: get rid of the SkBenchmark void* parameter.
...
While I was doing massive sed-ing, I also converted every bench to use DEF_BENCH instead of registering the ugly manual way.
BUG=
R=scroggo@google.com
Review URL: https://codereview.chromium.org/23876006
git-svn-id: http://skia.googlecode.com/svn/trunk@11263 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-13 19:52:27 +00:00
edisonn@google.com
af54a513a5
pdfviewer: do not submit, uploaded for backup, and will be done actually after I refactor the params for functions, to put the char* params in a structure: report errors and warnings in pdf, infrastructure
...
Review URL: https://codereview.chromium.org/23902018
git-svn-id: http://skia.googlecode.com/svn/trunk@11262 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-13 19:33:42 +00:00
mtklein@google.com
1fb04e2540
add a way to get code coverage
...
BUG=
R=borenet@google.com
Review URL: https://codereview.chromium.org/23523055
git-svn-id: http://skia.googlecode.com/svn/trunk@11261 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-13 19:32:43 +00:00
reed@google.com
cee9dcb837
start to remove lockPixels from bitmapshader
...
BUG=
R=scroggo@google.com
Review URL: https://codereview.chromium.org/23591030
git-svn-id: http://skia.googlecode.com/svn/trunk@11258 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-13 16:04:49 +00:00
sugoi@google.com
f4dc60457b
Canary build fix
...
BUG=
R=bsalomon@google.com , robertphillips@google.com
Review URL: https://codereview.chromium.org/23532068
git-svn-id: http://skia.googlecode.com/svn/trunk@11257 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-13 15:42:46 +00:00
robertphillips@google.com
96bf2b53f2
N7 Performance trigger rebaselines
...
git-svn-id: http://skia.googlecode.com/svn/trunk@11256 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-13 15:42:08 +00:00
bsalomon@google.com
9e488d8294
I don't know what you've been told, rebaselining images never gets old
...
R=epoger@google.com
Review URL: https://codereview.chromium.org/23531047
git-svn-id: http://skia.googlecode.com/svn/trunk@11255 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-13 14:27:54 +00:00
bsalomon@google.com
8c762c61bd
They're RRRRRrrrrrrreeebaseline!
...
R=epoger@google.com
Review URL: https://codereview.chromium.org/23771006
git-svn-id: http://skia.googlecode.com/svn/trunk@11254 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-13 14:19:53 +00:00
bsalomon@google.com
33cd0cada2
319 bottles of rebaseline on the wall...
...
R=epoger@google.com
Review URL: https://codereview.chromium.org/23629042
git-svn-id: http://skia.googlecode.com/svn/trunk@11252 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-13 13:49:18 +00:00
robertphillips@google.com
40fcb59894
More warnings as errors fixes
...
git-svn-id: http://skia.googlecode.com/svn/trunk@11251 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-13 13:13:29 +00:00
robertphillips@google.com
558d5d3f08
Warnings as errors fix
...
git-svn-id: http://skia.googlecode.com/svn/trunk@11250 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-13 12:54:33 +00:00
commit-bot@chromium.org
4b681bc95b
Fixed issues found by fuzzer
...
Last week, the fuzzer found a few numerical issue with filters and I had written some fixes for them. Here are the fixes with some unit tests.
For senorblanco : So I figured out what was asserting when we'd get a 0 width "result" in SkBicubicImageFilter::onFilterImage(). Basically, if the "result" SkBitmap object calls SkBitmap::setConfig() with "width" and/or "height" set to 0, then the SkBitmap object will call SkBitmap::reset(), making the SkBitmap object's config invalid. At this point, calling SkBitmap::getAddr32() will assert, even without attempting to dereference the data pointer, because the SkBitmap's config is invalid. If height is valid, but width is 0, then this call to SkBitmap::getAddr32() happens directly in SkBicubicImageFilter::onFilterImage() a few lines lower and asserts right away.
BUG=
R=senorblanco@google.com , senorblanco@chromium.org , bsalomon@google.com
Author: sugoi@chromium.org
Review URL: https://chromiumcodereview.appspot.com/23533042
git-svn-id: http://skia.googlecode.com/svn/trunk@11249 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-13 12:40:02 +00:00
commit-bot@chromium.org
ab13167410
Removes uses of unnamed namespace from samplecode.
...
Skia code prefers static over unnamed namespace.
R=bsalomon@google.com , robertphillips@google.com
Author: tfarina@chromium.org
Review URL: https://chromiumcodereview.appspot.com/23498028
git-svn-id: http://skia.googlecode.com/svn/trunk@11248 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-13 12:39:55 +00:00
commit-bot@chromium.org
5792cded61
Initial error handling code
...
I made it as simple as possible. The impact seems minimal and it should do what's necessary to make this code secure.
BUG=
R=reed@google.com , scroggo@google.com , djsollen@google.com , sugoi@google.com , bsalomon@google.com , mtklein@google.com , senorblanco@google.com , senorblanco@chromium.org
Author: sugoi@chromium.org
Review URL: https://chromiumcodereview.appspot.com/23021015
git-svn-id: http://skia.googlecode.com/svn/trunk@11247 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-13 12:39:34 +00:00
commit-bot@chromium.org
2db4eabb77
ARM Skia NEON patches - 19 - Intrinsics version of the Filter32 routines
...
BitmapProcState: translate the filtering routines to intrinsics
Signed-off-by: Kévin PETIT <kevin.petit@arm.com>
BUG=
R=djsollen@google.com , mtklein@google.com
Author: kevin.petit.arm@gmail.com
Review URL: https://chromiumcodereview.appspot.com/21915004
git-svn-id: http://skia.googlecode.com/svn/trunk@11246 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-13 12:39:09 +00:00
epoger@google.com
4907b30312
whitespace change to trigger buildbots
...
Review URL: https://codereview.chromium.org/23620048
git-svn-id: http://skia.googlecode.com/svn/trunk@11240 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-12 19:50:17 +00:00
bsalomon@google.com
6924e9bbce
Rebaseline ANGLE Release bot
...
(SkipBuildbotRuns)
R=epoger@google.com
BUG=
Review URL: https://codereview.chromium.org/23851025
git-svn-id: http://skia.googlecode.com/svn/trunk@11227 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-12 17:23:21 +00:00
borenet@google.com
3fef76a0e0
Whitespace change to trigger rebuilds
...
Review URL: https://codereview.chromium.org/23523054
git-svn-id: http://skia.googlecode.com/svn/trunk@11224 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-12 15:59:32 +00:00
epoger@google.com
6f3fe63bdf
Whitespace commit to trigger the buildbots, and possible downfall of society.
...
Review URL: https://codereview.chromium.org/23542031
git-svn-id: http://skia.googlecode.com/svn/trunk@11221 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-12 05:37:01 +00:00
bsalomon@google.com
3075134de9
The final rebasline?
...
(SkipBuildbotRuns)
R=epoger@google.com
Review URL: https://codereview.chromium.org/23964009
git-svn-id: http://skia.googlecode.com/svn/trunk@11214 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-11 21:43:26 +00:00
bsalomon@google.com
49986400e1
Rererererebaseline
...
(SkipBuildbotRuns)
R=epoger@google.com
Review URL: https://codereview.chromium.org/23981010
git-svn-id: http://skia.googlecode.com/svn/trunk@11213 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-11 21:36:56 +00:00
bsalomon@google.com
e24890b51f
Did you say rebaseline?
...
(SkipBuildbotRuns)
R=epoger@google.com
Review URL: https://codereview.chromium.org/23964008
git-svn-id: http://skia.googlecode.com/svn/trunk@11212 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-11 21:24:00 +00:00
bsalomon@google.com
78399a98f7
Fresh baselines!
...
(SkipBuildbotRuns)
R=epoger@google.com
Review URL: https://codereview.chromium.org/24079005
git-svn-id: http://skia.googlecode.com/svn/trunk@11211 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-11 21:11:47 +00:00
bsalomon@google.com
9da31ed0a8
More rebaselines due to re-enabling gpu batching.
...
(SkipBuildbotRuns)
R=epoger@google.com
Review URL: https://codereview.chromium.org/23754011
git-svn-id: http://skia.googlecode.com/svn/trunk@11210 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-11 20:47:19 +00:00
bsalomon@google.com
bb50d6148b
Rebase after re-enabling GPU batching.
...
(SkipBuildbotRuns)
R=epoger@google.com
Review URL: https://codereview.chromium.org/23546011
git-svn-id: http://skia.googlecode.com/svn/trunk@11208 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-11 19:20:12 +00:00
epoger@google.com
bfe9167c66
Add README file so git will create empty dir
...
BUG=skia:1613
(SkipBuildbotRuns)
R=rmistry@google.com
Review URL: https://codereview.chromium.org/24112002
git-svn-id: http://skia.googlecode.com/svn/trunk@11203 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-11 17:31:49 +00:00
djsollen@google.com
3a98ed7658
various bug fixes.
...
1. update mac support for md5
2. update default build to be thumb
(SkipBuildbotRuns)
R=mtklein@google.com
Review URL: https://codereview.chromium.org/23514051
git-svn-id: http://skia.googlecode.com/svn/trunk@11201 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-11 16:56:20 +00:00
borenet@google.com
7aa8044da5
Ignore the .git directory in sanitize_source_files, remove .git directory...
...
R=rmistry@google.com
Review URL: https://codereview.chromium.org/23981006
git-svn-id: http://skia.googlecode.com/svn/trunk@11193 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-11 13:01:27 +00:00