commit-bot@chromium.org
a60d0370b1
make compare_rendered_pictures_test.py run end-to-end test
...
1. generate test SKPs using skpmaker
2. render those SKPs using render_pictures
3. compare results using compare_rendered_pictures.py
BUG=skia:1942,skia:2230
NOTRY=True
R=borenet@google.com
Author: epoger@google.com
Review URL: https://codereview.chromium.org/274623002
git-svn-id: http://skia.googlecode.com/svn/trunk@14624 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-07 19:29:03 +00:00
commit-bot@chromium.org
7418bd8cad
make compare_rendered_pictures process render_pictures's new JSON output format
...
BUG=skia:1942,skia:2230
NOTRY=True
R=borenet@google.com
Author: epoger@google.com
Review URL: https://codereview.chromium.org/265793013
git-svn-id: http://skia.googlecode.com/svn/trunk@14591 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-06 15:31:31 +00:00
commit-bot@chromium.org
658e59507d
tweaks to tab CSS for rebaseline server page; moar pretty
...
BUG=skia:
R=epoger@google.com
Author: humper@google.com
Review URL: https://codereview.chromium.org/264853004
git-svn-id: http://skia.googlecode.com/svn/trunk@14512 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-01 19:29:53 +00:00
commit-bot@chromium.org
6323844cb3
rebaseline_server: ignore builders we don't have any expectations for
...
(SkipBuildbotRuns)
BUG=skia:2486
NOTREECHECKS=True
NOTRY=True
R=rmistry@google.com
TBR=rmistry
Author: epoger@google.com
Review URL: https://codereview.chromium.org/269543002
git-svn-id: http://skia.googlecode.com/svn/trunk@14488 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-30 21:32:37 +00:00
commit-bot@chromium.org
9d3fdbeb7b
rebaseline_server unittests: output tkdiff lines when actuals don't match expectations
...
(SkipBuildbotRuns)
NOTREECHECKS=True
NOTRY=True
R=rmistry@google.com
TBR=rmistry
Author: epoger@google.com
Review URL: https://codereview.chromium.org/252583005
git-svn-id: http://skia.googlecode.com/svn/trunk@14385 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-25 19:59:44 +00:00
commit-bot@chromium.org
c9b511f0e6
Revert of rebaseline_server: multithreaded loading/diffing of images ( https://codereview.chromium.org/235923002/ )
...
Reason for revert:
Caused https://code.google.com/p/skia/issues/detail?id=2423 ('"Deadline exceeded" error when connecting to live rebaseline_server'). Reverting until I can figure it out.
Original issue's description:
> rebaseline_server: multithreaded loading/diffing of images
>
> BUG=skia:2414
> NOTRY=True
>
> Committed: http://code.google.com/p/skia/source/detail?r=14184
R=rmistry@google.com
TBR=rmistry@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:2414
Author: epoger@google.com
Review URL: https://codereview.chromium.org/239623002
git-svn-id: http://skia.googlecode.com/svn/trunk@14207 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-15 18:50:12 +00:00
commit-bot@chromium.org
280ea8296f
rebaseline_server: multithreaded loading/diffing of images
...
BUG=skia:2414
NOTRY=True
R=rmistry@google.com
Author: epoger@google.com
Review URL: https://codereview.chromium.org/235923002
git-svn-id: http://skia.googlecode.com/svn/trunk@14184 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-14 18:15:29 +00:00
commit-bot@chromium.org
e93a4c0fea
rebaseline_server: fix sorting by perceptual diff column
...
(SkipBuildbotRuns)
BUG=skia:2410
NOTREECHECKS=True
NOTRY=True
R=rmistry@google.com
TBR=rmistry
Author: epoger@google.com
Review URL: https://codereview.chromium.org/235993002
git-svn-id: http://skia.googlecode.com/svn/trunk@14167 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-11 21:45:41 +00:00
commit-bot@chromium.org
1f75ab9c66
add some .gitignores related to gm and tools
...
NOTREECHECKS=True
NOTRY=True
R=scroggo@google.com
TBR=scroggo
Author: epoger@google.com
Review URL: https://codereview.chromium.org/234603004
git-svn-id: http://skia.googlecode.com/svn/trunk@14150 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-11 14:49:50 +00:00
commit-bot@chromium.org
d0b8904521
rebaseline_server: eliminate meaningless 404 errors while waiting for content to load
...
(SkipBuildbotRuns)
NOTREECHECKS=True
NOTRY=True
R=jcgregorio@google.com
Author: epoger@google.com
Review URL: https://codereview.chromium.org/231513004
git-svn-id: http://skia.googlecode.com/svn/trunk@14138 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-10 20:41:13 +00:00
commit-bot@chromium.org
defe6fdbc8
rebaseline_server: allow user to specify which builders to process
...
BUG=skia:1543,skia:1915
NOTRY=True
R=borenet@google.com
Author: epoger@google.com
Review URL: https://codereview.chromium.org/232103002
git-svn-id: http://skia.googlecode.com/svn/trunk@14131 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-10 15:05:24 +00:00
commit-bot@chromium.org
3eb77e4d5a
teach rebaseline_server how to compare results of multiple render_pictures runs
...
BUG=skia:2230,skia:1942
NOTRY=True
R=rmistry@google.com
Author: epoger@google.com
Review URL: https://codereview.chromium.org/216103004
git-svn-id: http://skia.googlecode.com/svn/trunk@14062 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-04 16:40:25 +00:00
commit-bot@chromium.org
6844958fff
rebaseline_server: display as much info as possible if expected/actual image is missing
...
BUG=skia:2368
NOTRY=True
R=borenet@google.com
Author: epoger@google.com
Review URL: https://codereview.chromium.org/221423003
git-svn-id: http://skia.googlecode.com/svn/trunk@14019 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-01 22:16:33 +00:00
commit-bot@chromium.org
31d0b3d806
rebaseline_server: add --compare-configs option
...
This allows us to compare GMs between configs across all builders, so we can see the largest deviations between raster and GPU renderings.
BUG=skia:1919
NOTREECHECKS=True
NOTRY=True
R=rmistry@google.com
Author: epoger@google.com
Review URL: https://codereview.chromium.org/215503002
git-svn-id: http://skia.googlecode.com/svn/trunk@13991 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-03-31 15:17:52 +00:00
commit-bot@chromium.org
c0df2fb5d0
rebaseline_server: add option to read actuals from local disk
...
(SkipBuildbotRuns)
BUG=skia:1908
NOTREECHECKS=True
NOTRY=True
R=halcanary@google.com
Author: epoger@google.com
Review URL: https://codereview.chromium.org/212673013
git-svn-id: http://skia.googlecode.com/svn/trunk@13971 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-03-28 14:28:04 +00:00
commit-bot@chromium.org
da0ceb2299
rebaseline_server: delete invalid image files from local disk cache
...
BUG=skia:2247
NOTREECHECKS=True
NOTRY=True
R=borenet@google.com
Author: epoger@google.com
Review URL: https://codereview.chromium.org/211733004
git-svn-id: http://skia.googlecode.com/svn/trunk@13951 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-03-26 13:38:29 +00:00
commit-bot@chromium.org
41056232e4
fix compare_to_expectations command line launch
...
(SkipBuildbotRuns)
NOTREECHECKS=True
NOTRY=True
R=rmistry@google.com
TBR=rmistry
Author: epoger@google.com
Review URL: https://codereview.chromium.org/210093003
git-svn-id: http://skia.googlecode.com/svn/trunk@13921 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-03-24 19:51:57 +00:00
commit-bot@chromium.org
b463d5668a
rebaseline_server: rename results.py to compare_to_expectations.py
...
BUG=skia:1919
NOTREECHECKS=True
NOTRY=True
R=borenet@google.com
Author: epoger@google.com
Review URL: https://codereview.chromium.org/208243003
git-svn-id: http://skia.googlecode.com/svn/trunk@13894 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-03-21 17:54:14 +00:00
commit-bot@chromium.org
a25c4e4fef
rebaseline_server: fix --editable mode
...
complete revert of https://skia.googlesource.com/skia/+/736be3527214ddbd3dd7e42a89a374c62d98f370
partial revert of https://skia.googlesource.com/skia/+/579942387bed9259b03419c593503022e1399931
and glue made necessary by the above.
(SkipBuildbotRuns)
BUG=skia:2319
NOTREECHECKS=True
NOTRY=True
R=senorblanco@google.com , senorblanco@chromium.org
Author: epoger@google.com
Review URL: https://codereview.chromium.org/208473004
git-svn-id: http://skia.googlecode.com/svn/trunk@13893 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-03-21 17:30:12 +00:00
commit-bot@chromium.org
736be35272
rebaseline_server: when first started, tell client results are still being generated
...
(SkipBuildbotRuns)
NOTREECHECKS=True
NOTRY=True
R=senorblanco@google.com , senorblanco@chromium.org
Author: epoger@google.com
Review URL: https://codereview.chromium.org/206723002
git-svn-id: http://skia.googlecode.com/svn/trunk@13879 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-03-20 18:31:00 +00:00
commit-bot@chromium.org
579942387b
rebaseline_server: serve JSON from static file, rather than generating it live
...
BUG=skia:1455, skia:2230
NOTREECHECKS=True
NOTRY=True
R=borenet@google.com
Author: epoger@google.com
Review URL: https://codereview.chromium.org/197213033
git-svn-id: http://skia.googlecode.com/svn/trunk@13876 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-03-20 17:27:46 +00:00
commit-bot@chromium.org
b42105a4a2
rebaseline_server: image URLs are relative to JSON file's location
...
BUG=skia:1455, skia:2230
NOTREECHECKS=True
NOTRY=True
R=borenet@google.com
Author: epoger@google.com
Review URL: https://codereview.chromium.org/205273002
git-svn-id: http://skia.googlecode.com/svn/trunk@13874 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-03-20 15:27:34 +00:00
commit-bot@chromium.org
d1c85d2920
rebaseline_server: make intermediate JSON specify base urls for diff images
...
BUG=skia:1919,skia:2230
NOTREECHECKS=True
NOTRY=True
R=rmistry@google.com
Author: epoger@google.com
Review URL: https://codereview.chromium.org/196533021
git-svn-id: http://skia.googlecode.com/svn/trunk@13830 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-03-17 14:22:02 +00:00
commit-bot@chromium.org
addcddeda6
make rebaseline_server client check schema version number
...
(SkipBuildbotRuns)
NOTREECHECKS=True
NOTRY=True
R=rmistry@google.com
Author: epoger@google.com
Review URL: https://codereview.chromium.org/195763013
git-svn-id: http://skia.googlecode.com/svn/trunk@13792 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-03-13 17:44:01 +00:00
commit-bot@chromium.org
ea770f155e
add schema version to rebaseline_server intermediate JSON
...
NOTREECHECKS=True
NOTRY=True
R=rmistry@google.com
Author: epoger@google.com
Review URL: https://codereview.chromium.org/196343009
git-svn-id: http://skia.googlecode.com/svn/trunk@13790 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-03-13 16:33:36 +00:00
commit-bot@chromium.org
7498d95bde
rebaseline_server: generate JSON that can be viewed without a live server
...
BUG=skia:1919
NOTREECHECKS=True
NOTRY=True
R=rmistry@google.com
Author: epoger@google.com
Review URL: https://codereview.chromium.org/195943004
git-svn-id: http://skia.googlecode.com/svn/trunk@13783 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-03-13 14:56:29 +00:00
commit-bot@chromium.org
6e3ee3339c
rebaseline_server: disable image magnifier, for huge UI speedup
...
BUG=skia:2248
NOTREECHECKS=True
NOTRY=True
R=rmistry@google.com
TBR=rmistry
Author: epoger@google.com
Review URL: https://codereview.chromium.org/193073003
git-svn-id: http://skia.googlecode.com/svn/trunk@13727 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-03-10 19:12:53 +00:00
commit-bot@chromium.org
5865ec5f3a
rebaseline_server: add actual_repo and actual_revision command line options
...
So, if you want to see divergences from expectations as of https://code.google.com/p/skia-autogen/source/detail?r=29365 , specify --actuals-revision 29365
This is also handy for testing rebaseline_server performance improvements against a static set of results.
BUG=skia:2248
NOTREECHECKS=True
NOTRY=True
R=borenet@google.com , bsalomon@google.com
Author: epoger@google.com
Review URL: https://codereview.chromium.org/193023002
git-svn-id: http://skia.googlecode.com/svn/trunk@13726 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-03-10 18:09:25 +00:00
commit-bot@chromium.org
ed19107c1b
rebaseline_server: fix reload delay when there is client/server clock skew
...
Currently, if there is >10 second clock skew between client and server, the
client will attempt to reload constantly while the server is still loading
results.
NOTREECHECKS=True
NOTRY=True
R=borenet@google.com
Author: epoger@google.com
Review URL: https://codereview.chromium.org/192833003
git-svn-id: http://skia.googlecode.com/svn/trunk@13725 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-03-10 18:05:15 +00:00
commit-bot@chromium.org
fadc749bd0
rebaseline_server: display how long it took to render the list
...
BUG=skia:2248
NOTREECHECKS=True
NOTRY=True
R=borenet@google.com
Author: epoger@google.com
Review URL: https://codereview.chromium.org/189833008
git-svn-id: http://skia.googlecode.com/svn/trunk@13720 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-03-10 15:36:06 +00:00
commit-bot@chromium.org
61f1606236
rebaseline_server: add "show thumbnails" option, and skip display of nonexistent images
...
BUG=skia:2248,skia:2231
NOTRY=True
R=borenet@google.com
Author: epoger@google.com
Review URL: https://codereview.chromium.org/183893030
git-svn-id: http://skia.googlecode.com/svn/trunk@13676 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-03-05 19:46:17 +00:00
commit-bot@chromium.org
8cc39a6567
rebaseline_server: better reporting for bad URL fetch
...
context: https://codereview.chromium.org/183763025/ ('vm_run_skia_try/write_json_summary: run skpdiff within imagediffdb, not on its own')
NOTREECHECKS=True
NOTRY=True
R=rmistry@google.com
TBR=rmistry
Author: epoger@google.com
Review URL: https://codereview.chromium.org/183833019
git-svn-id: http://skia.googlecode.com/svn/trunk@13654 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-03-04 16:46:22 +00:00
commit-bot@chromium.org
3b98759529
rebaseline_server: keep going on exception in ImagePair.__init__()
...
BUG=skia:2247
NOTREECHECKS=True
NOTRY=True
R=borenet@google.com
TBR=borenet
Author: epoger@google.com
Review URL: https://codereview.chromium.org/184103022
git-svn-id: http://skia.googlecode.com/svn/trunk@13650 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-03-04 00:58:21 +00:00
commit-bot@chromium.org
8dab8ecc93
rebaseline_server: fix "Results current as of <timestamp>" banner
...
(SkipBuildbotRuns)
BUG=skia:2232
NOTREECHECKS=True
NOTRY=True
R=rmistry@google.com
TBR=rmistry
Author: epoger@google.com
Review URL: https://codereview.chromium.org/183523002
git-svn-id: http://skia.googlecode.com/svn/trunk@13612 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-02-27 18:13:07 +00:00
commit-bot@chromium.org
16f418080f
rebaseline_server: use new intermediate JSON format as described in https://goto.google.com/ChangingRbsJson
...
There are still some places in the frontend (HTML+Javascript) code where
we assume we are handling expectations vs actuals, but there are just a few
and we should be able to remove them easily in a coming CL.
At that point, the frontend will work just as well for displaying any set
of image pairs.
BUG=skia:1919
NOTRY=True
R=rmistry@google.com
Author: epoger@google.com
Review URL: https://codereview.chromium.org/178253010
git-svn-id: http://skia.googlecode.com/svn/trunk@13598 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-02-26 19:05:20 +00:00
commit-bot@chromium.org
f679e2b90d
rebaseline_server: extract common unittest code, and rename tests/ -> testdata/
...
NOTRY=True
R=rmistry@google.com
Author: epoger@google.com
Review URL: https://codereview.chromium.org/170803005
git-svn-id: http://skia.googlecode.com/svn/trunk@13499 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-02-19 15:38:13 +00:00
commit-bot@chromium.org
4d0f008895
rebaseline_server: fail fast if skpdiff binary is not available
...
NOTRY=True
R=rmistry@google.com
Author: epoger@google.com
Review URL: https://codereview.chromium.org/169943002
git-svn-id: http://skia.googlecode.com/svn/trunk@13484 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-02-18 14:38:22 +00:00
commit-bot@chromium.org
536b15ffb0
rebaseline_server: create ImagePairSet-- holds a number of ImagePairs to examine
...
See https://goto.google.com/ChangingRbsJson and bug 1919 for additional context
BUG=skia:1919
NOTRY=True
R=rmistry@google.com
Author: epoger@google.com
Review URL: https://codereview.chromium.org/139343018
git-svn-id: http://skia.googlecode.com/svn/trunk@13434 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-02-13 17:17:05 +00:00
commit-bot@chromium.org
44546f85d9
Add the perceptual difference metric to the rebaseline server
...
* Finds the location of the skpdiff binary.
* Calculates the perceptual difference percentage using the skpdiff binary (treats -1 as 0% perceptual similarity).
* Replaces the weightedDiffMeasure in view.html with perceptualDifferent.
BUG=skia:2019
NOTRY=true
Committed: http://code.google.com/p/skia/source/detail?r=13398
R=epoger@google.com
Author: rmistry@google.com
Review URL: https://codereview.chromium.org/147453003
git-svn-id: http://skia.googlecode.com/svn/trunk@13410 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-02-11 18:21:26 +00:00
commit-bot@chromium.org
589bd3da34
Revert of Add the perceptual difference metric to the rebaseline server ( https://codereview.chromium.org/147453003/ )
...
Reason for revert:
Caused failure in RunGmSelfTests:
http://108.170.219.160:10117/builders/Housekeeper-PerCommit/builds/154/steps/RunGmSelfTests/logs/stdio
Filed:
https://code.google.com/p/skia/issues/detail?id=2160
Original issue's description:
> Add the perceptual difference metric to the rebaseline server
>
> * Finds the location of the skpdiff binary.
> * Calculates the perceptual difference percentage using the skpdiff binary.
> * Replaces the weightedDiffMeasure in view.html with perceptualDifferent.
>
> BUG=skia:2019
> NOTRY=true
>
> Committed: http://code.google.com/p/skia/source/detail?r=13398
R=epoger@google.com
TBR=epoger@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:2019
Author: rmistry@google.com
Review URL: https://codereview.chromium.org/131453017
git-svn-id: http://skia.googlecode.com/svn/trunk@13399 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-02-11 13:30:33 +00:00
commit-bot@chromium.org
af34eb9b74
Add the perceptual difference metric to the rebaseline server
...
* Finds the location of the skpdiff binary.
* Calculates the perceptual difference percentage using the skpdiff binary.
* Replaces the weightedDiffMeasure in view.html with perceptualDifferent.
BUG=skia:2019
NOTRY=true
R=epoger@google.com
Author: rmistry@google.com
Review URL: https://codereview.chromium.org/147453003
git-svn-id: http://skia.googlecode.com/svn/trunk@13398 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-02-11 12:33:58 +00:00
commit-bot@chromium.org
9985ef5ed8
rebaseline_server: add ImagePair class, a step towards new intermediate JSON schema
...
See https://goto.google.com/ChangingRbsJson and bug 1919 for additional context
BUG=skia:1919
NOTRY=True
R=rmistry@google.com
Author: epoger@google.com
Review URL: https://codereview.chromium.org/157593006
git-svn-id: http://skia.googlecode.com/svn/trunk@13385 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-02-10 18:19:30 +00:00
commit-bot@chromium.org
e6af4fb34b
rebaseline_server: properly handle unexpected GETs
...
BUG=skia:2147
NOTRY=True
R=rmistry@google.com
Author: epoger@google.com
Review URL: https://codereview.chromium.org/157773002
git-svn-id: http://skia.googlecode.com/svn/trunk@13366 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-02-07 18:21:59 +00:00
commit-bot@chromium.org
6f0ba479a8
rebaseline_server: add "show only"/"show all" buttons to some columns
...
BUG=skia:2143
NOTRY=True
R=bsalomon@google.com
Author: epoger@google.com
Review URL: https://codereview.chromium.org/156773003
git-svn-id: http://skia.googlecode.com/svn/trunk@13349 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-02-06 20:22:25 +00:00
commit-bot@chromium.org
1c188ed9fa
rebaseline_server: get "image size" working again
...
BUG=skia:2134
NOTRY=True
R=rmistry@google.com
Author: epoger@google.com
Review URL: https://codereview.chromium.org/155973003
git-svn-id: http://skia.googlecode.com/svn/trunk@13343 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-02-06 15:17:28 +00:00
commit-bot@chromium.org
ceba079e3b
rebaseline_server: add bgcolor slider for pixelDiff column
...
BUG=skia:1904
NOTRY=True
R=robertphillips@google.com , rmistry@google.com
Author: epoger@google.com
Review URL: https://codereview.chromium.org/143273003
git-svn-id: http://skia.googlecode.com/svn/trunk@13325 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-02-05 19:49:17 +00:00
commit-bot@chromium.org
076f078a5e
Add magnifier to rebaseline server.
...
NOTRY=true
BUG=skia:1917
R=epoger@google.com
Author: rmistry@google.com
Review URL: https://codereview.chromium.org/149473005
git-svn-id: http://skia.googlecode.com/svn/trunk@13315 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-02-04 22:45:40 +00:00
commit-bot@chromium.org
d1630e8fc0
new tool: download all GM images for a given builder, ready for skdiff
...
BUG=skia:1919
R=rmistry@google.com , bsalomon@google.com
Author: epoger@google.com
Review URL: https://codereview.chromium.org/143653006
git-svn-id: http://skia.googlecode.com/svn/trunk@13172 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-24 18:34:11 +00:00
commit-bot@chromium.org
dd10e0ec4c
make GM self-test run gm/rebaseline_server unittests
...
R=borenet@google.com
Author: epoger@google.com
Review URL: https://codereview.chromium.org/143983017
git-svn-id: http://skia.googlecode.com/svn/trunk@13170 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-24 18:28:35 +00:00
commit-bot@chromium.org
04747a53d3
rebaseline_server: ignore TSAN, ASAN, Valgrind bots
...
BUG=skia:2036
R=bsalomon@google.com
Author: epoger@google.com
Review URL: https://codereview.chromium.org/134643010
git-svn-id: http://skia.googlecode.com/svn/trunk@13094 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-15 19:16:09 +00:00
borenet@google.com
6f0f5b4aad
Remove references to Skia's SVN repository
...
BUG=
R=epoger@google.com
Review URL: https://codereview.chromium.org/132423002
git-svn-id: http://skia.googlecode.com/svn/trunk@13006 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-09 21:41:39 +00:00
commit-bot@chromium.org
2a78e82f5e
create gm/rebaseline_server/test_all.py
...
Uses proper Python unittest framework to launch all unittests within the directory.
NOTRY=True
R=rmistry@google.com
Author: epoger@google.com
Review URL: https://codereview.chromium.org/125253002
git-svn-id: http://skia.googlecode.com/svn/trunk@12915 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-06 18:33:19 +00:00
commit-bot@chromium.org
0bf919c89a
make results_test.py work better within python unittest framework
...
BUG=
R=rmistry@google.com
Author: epoger@google.com
Review URL: https://codereview.chromium.org/122443006
git-svn-id: http://skia.googlecode.com/svn/trunk@12882 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-03 16:04:11 +00:00
commit-bot@chromium.org
7b06c8ee61
create unittest for gm/rebaseline_server/results.py
...
NOTRY=True
R=rmistry@google.com
Author: epoger@google.com
Review URL: https://codereview.chromium.org/117413006
git-svn-id: http://skia.googlecode.com/svn/trunk@12819 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-23 22:47:15 +00:00
rmistry@google.com
5861e52715
Adding additional optional parameters to imagediffdb to make calling from Cluster Telemetry possible.
...
R=epoger@google.com
Review URL: https://codereview.chromium.org/117823008
git-svn-id: http://skia.googlecode.com/svn/trunk@12816 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-21 19:07:40 +00:00
commit-bot@chromium.org
a47e7acbc0
rebaseline_server: stop catching KeyboardInterrupt (ctrl-C)
...
(SkipBuildbotRuns)
NOTRY=True
NOTREECHECKS=True
R=rmistry@google.com
TBR=rmistry
Author: epoger@google.com
Review URL: https://codereview.chromium.org/115863003
git-svn-id: http://skia.googlecode.com/svn/trunk@12783 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-19 20:01:34 +00:00
commit-bot@chromium.org
a6ecbb8414
rebaseline_server: add more timing and progress info to server-side log
...
(SkipBuildbotRuns)
BUG=skia:1941
NOTRY=True
NOTREECHECKS=True
R=bsalomon@google.com
Author: epoger@google.com
Review URL: https://codereview.chromium.org/105213007
git-svn-id: http://skia.googlecode.com/svn/trunk@12777 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-19 19:08:31 +00:00
commit-bot@chromium.org
50ad8e4d8e
rebaseline_server: return rebaseline results faster, and reload UI page automatically after
...
Old way:
Wait until server has loaded the updated results before telling the user the rebaseline
was successful, and trust the user to reload the page before submitting more baselines.
New way:
Make server load the updated results in a separate thread, and automatically reload the page
so that the user can submit more baselines if she wants to.
(SkipBuildbotRuns)
NOTRY=True
NOTREECHECKS=True
R=bsalomon@google.com
Author: epoger@google.com
Review URL: https://codereview.chromium.org/117453002
git-svn-id: http://skia.googlecode.com/svn/trunk@12717 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-17 18:06:13 +00:00
commit-bot@chromium.org
7dd5d6e5d7
Tiny, urgent fix for rebaseline_server to accept new baselines.
...
(SkipBuildbotRuns)
R=jcgregorio@google.com
TBR=jcgregorio
NOTREECHECKS=True
NOTRY=True
BUG=
Author: epoger@google.com
Review URL: https://codereview.chromium.org/99763007
git-svn-id: http://skia.googlecode.com/svn/trunk@12628 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-11 20:19:42 +00:00
epoger@google.com
62a5ef0a9b
rebaseline_server: add "deep linking" to allow bookmarking of particular views
...
(SkipBuildbotRuns)
R=jcgregorio@google.com
Review URL: https://codereview.chromium.org/104623003
git-svn-id: http://skia.googlecode.com/svn/trunk@12513 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-05 18:03:24 +00:00
epoger@google.com
2682c90860
rebaseline_server: start HTTP server immediately, auto-reload once results are available
...
BUG=skia:1877
(SkipBuildbotRuns)
R=vandebo@chromium.org
Review URL: https://codereview.chromium.org/106453002
git-svn-id: http://skia.googlecode.com/svn/trunk@12509 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-05 16:05:16 +00:00
rmistry@google.com
d6bab02386
Reverting r12427
...
git-svn-id: http://skia.googlecode.com/svn/trunk@12428 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-02 13:50:38 +00:00
skia.committer@gmail.com
5b39f5ba9c
Sanitizing source files in Housekeeper-Nightly
...
git-svn-id: http://skia.googlecode.com/svn/trunk@12427 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-02 13:36:22 +00:00
epoger@google.com
d7255b6ae4
rebaseline_server: make --reload work in git checkout
...
(SkipBuildbotRuns)
R=rmistry@google.com
Review URL: https://codereview.chromium.org/86343002
git-svn-id: http://skia.googlecode.com/svn/trunk@12397 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-26 17:59:28 +00:00
epoger@google.com
b063e13428
rebaseline_server: remove deprecated-expectations-dir option
...
followup to https://codereview.chromium.org/81243002/ ('rebaseline_server:
deprecate --expectations-dir option in advance of git transition')
(SkipBuildbotRuns)
R=borenet@google.com
Review URL: https://codereview.chromium.org/86043002
git-svn-id: http://skia.googlecode.com/svn/trunk@12381 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-25 18:06:29 +00:00
epoger@google.com
214a024e8c
rebaseline_server: improve pixel diff reporting
...
- fix differing pixels count (we weren't always doing this right)
- report number of differing pixels, as well as percentage
- report worst difference per RGB channel
- apply alpha mask to difference image (changed pixels = opaque, unchanged = transparent)
- add tooltips with further explanation of pixel diffs
(SkipBuildbotRuns)
R=mtklein@google.com
Review URL: https://codereview.chromium.org/82823005
git-svn-id: http://skia.googlecode.com/svn/trunk@12366 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-22 19:26:18 +00:00
epoger@google.com
cc64e7dff8
rebaseline_server: deprecate --expectations-dir option in advance of git transition
...
(SkipBuildbotRuns)
R=bsalomon@google.com
Review URL: https://codereview.chromium.org/81243002
git-svn-id: http://skia.googlecode.com/svn/trunk@12351 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-21 18:11:34 +00:00
epoger@google.com
591469b1e9
rebaseline_server: clean up thread locks
...
followup to https://codereview.chromium.org/66803004/ ('rebaseline_server: improve thread locks to allow read access during updates')
(SkipBuildbotRuns)
R=jcgregorio@google.com
Review URL: https://codereview.chromium.org/64273011
git-svn-id: http://skia.googlecode.com/svn/trunk@12323 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-20 19:58:06 +00:00
epoger@google.com
61952904ae
rebaseline_server: improve thread locks to allow read access during updates
...
(SkipBuildbotRuns)
TBR=jcgregorio
Review URL: https://codereview.chromium.org/66803004
git-svn-id: http://skia.googlecode.com/svn/trunk@12195 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-08 17:23:54 +00:00
epoger@google.com
9dddf6f6b9
rebaseline_server: add pixel diffs, and sorting by diff metrics
...
(SkipBuildbotRuns)
R=bsalomon@google.com , jcgregorio@google.com
Review URL: https://codereview.chromium.org/59283006
git-svn-id: http://skia.googlecode.com/svn/trunk@12193 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-08 16:25:25 +00:00
epoger@google.com
1e698afbc2
rebaseline_server was not allowing tests to be marked ignore-failure
...
(SkipBuildbotRuns)
TBR=jcgregorio
Review URL: https://codereview.chromium.org/59063005
git-svn-id: http://skia.googlecode.com/svn/trunk@12143 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-05 21:00:24 +00:00
epoger@google.com
045c3d330c
rebaseline_server: make default landing page list supported query URLs
...
(SkipBuildbotRuns)
Originally, the default landing page redirected to view.html?resultsToLoad=all
(which displays all results, and can take a while).
Instead, start with a fast-loading page that shows the user all the result
sets that are available.
R=scroggo@google.com
Review URL: https://codereview.chromium.org/46413004
git-svn-id: http://skia.googlecode.com/svn/trunk@12088 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-01 16:46:41 +00:00
epoger@google.com
7b1c2c102e
rebaseline_server: right-align "select/clear/toggle all tests" buttons with results table
...
(SkipBuildbotRuns)
R=edisonn@google.com
Review URL: https://codereview.chromium.org/55073003
git-svn-id: http://skia.googlecode.com/svn/trunk@12079 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-01 14:29:03 +00:00
epoger@google.com
b08c707847
rebaseline_server: report proper URL upon launch
...
BUG=skia:1767
(SkipBuildbotRuns)
R=jcgregorio@google.com
Review URL: https://codereview.chromium.org/51353002
git-svn-id: http://skia.googlecode.com/svn/trunk@12016 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-30 14:09:04 +00:00
epoger@google.com
4259ef3dbd
rebaseline_server: replace TODOs section with link to documentation/roadmap
...
(SkipBuildbotRuns)
R=bsalomon@google.com
Review URL: https://codereview.chromium.org/47543008
git-svn-id: http://skia.googlecode.com/svn/trunk@12002 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-29 17:39:09 +00:00
epoger@google.com
f4394d5531
rebaseline_server: allow substring filtering for builder and test
...
If the user clicks on a particular value for one of these fields, that field's
value will go into the filtering box (so you will only see results matching
that field value).
(SkipBuildbotRuns)
R=borenet@google.com
Review URL: https://codereview.chromium.org/47423002
git-svn-id: http://skia.googlecode.com/svn/trunk@12000 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-29 15:49:40 +00:00
epoger@google.com
92165bc09b
rebaseline_server: tiny fix to un-break UI when ng-repeate (key, value) has duplicate values
...
See https://github.com/angular/angular.js/pull/2505
(SkipBuildbotRuns)
TBR=jcgregorio
Review URL: https://codereview.chromium.org/46063005
git-svn-id: http://skia.googlecode.com/svn/trunk@11972 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-26 15:01:08 +00:00
epoger@google.com
055e3b5f92
rebaseline_server: UI improvements + set reviewed-by-human on commit
...
- select/clear/toggle all tests
- display "bugs" column
- set reviewed-by-human on commit
- a couple more tiny fixes, TODOs adjusted, etc.
(SkipBuildbotRuns)
R=senorblanco@chromium.org
Review URL: https://codereview.chromium.org/44123004
git-svn-id: http://skia.googlecode.com/svn/trunk@11970 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-26 14:31:11 +00:00
epoger@google.com
ad0e552fef
rebaseline_server: cleanup of HTML/Javascript
...
No behavioral change at all.
(SkipBuildbotRuns)
R=borenet@google.com
Review URL: https://codereview.chromium.org/31583007
git-svn-id: http://skia.googlecode.com/svn/trunk@11946 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-24 15:38:27 +00:00
epoger@google.com
eb832599b6
rebaseline_server: add tabs, and ability to submit new baselines to the server
...
Tabs allow the user to divide the tests into groups:
hide these for now, approve these, etc.
(SkipBuildbotRuns)
R=borenet@google.com
Review URL: https://codereview.chromium.org/28903008
git-svn-id: http://skia.googlecode.com/svn/trunk@11915 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-23 15:07:26 +00:00
epoger@google.com
cce4e09a5c
Revert r11860, which was supposed to just be a whitespace change (argh)
...
(SkipBuildbotRuns)
Review URL: https://codereview.chromium.org/29603002
git-svn-id: http://skia.googlecode.com/svn/trunk@11861 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-18 18:36:25 +00:00
epoger@google.com
94041c6d8b
Whitespace change to trigger buildbots after https://code.google.com/p/skia/source/detail?r=11859
...
git-svn-id: http://skia.googlecode.com/svn/trunk@11860 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-18 18:33:03 +00:00
epoger@google.com
542b65f234
rebaseline_server: add --editable and --reload flags
...
This is a variation on the --browseonly flag we came up with in
https://codereview.chromium.org/24274003/#msg6 .
The long-lived "view only" server will probably be run like this:
server.py --export --reload 300
And when rebaselining you'll run your own server like this:
server.py --editable
(SkipBuildbotRuns)
R=jcgregorio@google.com
Review URL: https://codereview.chromium.org/27218005
git-svn-id: http://skia.googlecode.com/svn/trunk@11788 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-15 20:10:33 +00:00
epoger@google.com
dcb4e65998
rebaseline_server: allow client to pull all results, or just failures
...
(SkipBuildbotRuns)
This will be handy for constrained networks or devices, where we don't want
to bother downloading info about all the successful tests.
R=jcgregorio@google.com
Review URL: https://codereview.chromium.org/26891003
git-svn-id: http://skia.googlecode.com/svn/trunk@11737 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-11 18:45:33 +00:00
epoger@google.com
9fb6c8ac9c
rebaseline_server: extend returned JSON dict to allow for result-editing in coming CL
...
(SkipBuildbotRuns)
R=jcgregorio@google.com
Review URL: https://codereview.chromium.org/26659002
git-svn-id: http://skia.googlecode.com/svn/trunk@11679 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-09 18:05:58 +00:00
epoger@google.com
cb55f11a8f
HTTP GM baseline viewer: server should serve files from gm/rebaseline_server dir
...
(SkipBuildbotRuns)
R=jcgregorio@google.com
Review URL: https://codereview.chromium.org/25774002
git-svn-id: http://skia.googlecode.com/svn/trunk@11583 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-02 19:27:35 +00:00
epoger@google.com
5f2bb002bd
More improvements to HTTP baseline viewer (for GM results)
...
(SkipBuildbotRuns)
R=borenet@google.com , bsalomon@google.com
Review URL: https://codereview.chromium.org/25555003
git-svn-id: http://skia.googlecode.com/svn/trunk@11581 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-02 18:57:48 +00:00
epoger@google.com
afaad3dd70
HTTP GM results viewer: server now returns category summaries along with testData
...
(SkipBuildbotRuns)
R=borenet@google.com
Review URL: https://codereview.chromium.org/25045003
git-svn-id: http://skia.googlecode.com/svn/trunk@11520 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-30 15:06:25 +00:00
epoger@google.com
f9d134da93
Create HTTP-based GM results viewer.
...
For now, it only allows VIEWING results... next, it will allow the user to
rebaseline GM results via the web interface.
R=borenet@google.com
Review URL: https://codereview.chromium.org/24274003
git-svn-id: http://skia.googlecode.com/svn/trunk@11500 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-27 15:02:44 +00:00