Commit Graph

34148 Commits

Author SHA1 Message Date
recipe-roller
f04c73f414 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
depot_tools:
  https://crrev.com/e38cf570fc8c0df53b576c179701efe6d683f7d2 Reland "bot_update: Patch on gclient by default." (ehmaldonado@chromium.org)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I132f51f6f407c8a2e77abef4b0adc7a2f9d5ced9
Reviewed-on: https://skia-review.googlesource.com/123938
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
2018-04-26 18:20:53 +00:00
Eric Boren
1eec99cf94 AUTHORS check: Allow service accounts from skia-swarming-bots
Bug: skia:7833, skia:7050
Change-Id: Id5b3fdd1b0a4ae50fce7a5d1212c744a85274012
Reviewed-on: https://skia-review.googlesource.com/123936
Reviewed-by: Ravi Mistry <rmistry@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
2018-04-26 17:34:43 +00:00
Kevin Lubick
88611a1a71 Update test expectations for Debian9
The removal of the blacklists is really a no-op because of
https://skia-review.googlesource.com/c/skia/+/9339

Bug: skia:7840
Change-Id: I72e2e03bbbc813737655a3d5f3a1e874d3a41909
Reviewed-on: https://skia-review.googlesource.com/123925
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
2018-04-26 17:16:53 +00:00
Cary Clark
d98f78cd01 alternative no anonymous enums
Anonymous enums play havoc with documentation;
there's no name to refer to. It may be that all
enums may either be named or replaced with constexpr
without breaking anything. Try replacing all
anonymous enums in include/core to see what happens.

This names SkCanvas::SaveLayerFlagsSet but leaves
SkCanvas::SaveLayerFlags as a uint32_t, to reduce
risk as compared to review.skia.org/123584.

There's also some chance that external linkage will
break if some client refers to anonymous enum in a way
that could require its address: see
https://stackoverflow.com/questions/22867654/enum-vs-constexpr-for-actual-static-constants-inside-classes
(This CL does not require definitions + declarations)

Brought bookmaker docs in line with this change.
This also tripped over missing code in bookmaker
handling constexpr so added that as well.

R=reed@google.com,bsalomon@google.com

Docs-Preview: https://skia.org/?cl=123920
Docs-Preview: https://skia.org/?cl=123584
Bug: skia:6898
Change-Id: I14a342edcfd59e139ef9e4501f562417c4c60391
Reviewed-on: https://skia-review.googlesource.com/123920
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Cary Clark <caryclark@skia.org>
2018-04-26 17:11:53 +00:00
Chris Dalton
ba37e5b1c9 ccpr: Don't use varying matrices
Bug: skia:7869
Change-Id: Ie6071fd49d0eb32b2f5dfdf6413f99a9a8d41637
Reviewed-on: https://skia-review.googlesource.com/123908
Reviewed-by: Ethan Nicholas <ethannicholas@google.com>
Commit-Queue: Chris Dalton <csmartdalton@google.com>
2018-04-26 16:53:24 +00:00
Eric Boren
e7950e3923 [infra] RecreateSKPs and Bookmaker need the Git packages
Bug: skia:7833, skia:7050
Change-Id: I8272e4b0beaed2a56260546f4a599a4586c71792
Reviewed-on: https://skia-review.googlesource.com/123921
Reviewed-by: Ravi Mistry <rmistry@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
2018-04-26 16:28:53 +00:00
Herb Derby
927fcb13f2 Make rounding code public
Change-Id: I37fec55277fe99734980c7473f964d37ca4248b8
Reviewed-on: https://skia-review.googlesource.com/123931
Reviewed-by: Ben Wagner <bungeman@google.com>
Commit-Queue: Herb Derby <herb@google.com>
2018-04-26 16:26:13 +00:00
Eric Boren
c2a8870316 [infra] Enable retries for Windows compiles
They're flaky due to https://github.com/golang/go/issues/21376

Bug: skia:
Change-Id: Ic629c84b72c492b35d393328aa2178762ce3c7d8
Reviewed-on: https://skia-review.googlesource.com/123932
Reviewed-by: Ravi Mistry <rmistry@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
2018-04-26 16:18:23 +00:00
Yuqian Li
f695cf117f Count the correct number of pos using text encoding.
Otherwise, the following will crash:

out/ASAN/dm --config t8888 --verbose --src gm -m skbug_5321

Bug: skia:
Change-Id: I9b1d3412b9695b0fbd8a9afb0e6d3ae7159aeee6
Reviewed-on: https://skia-review.googlesource.com/123750
Commit-Queue: Ben Wagner <bungeman@google.com>
Reviewed-by: Ben Wagner <bungeman@google.com>
Auto-Submit: Yuqian Li <liyuqian@google.com>
2018-04-26 15:13:13 +00:00
Yuqian Li
c79e2d1551 Check negative width before blitAntiRect
Since we decrease the width when clipped, it might be negative.

Bug: skia:7858
Change-Id: I348bd07d917905a55bec1a4b4e0915c6528fe6b1
Reviewed-on: https://skia-review.googlesource.com/123927
Auto-Submit: Yuqian Li <liyuqian@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Yuqian Li <liyuqian@google.com>
2018-04-26 14:51:53 +00:00
Florin Malita
abc8575380 Remove stale gradient color space assert
SkGradientShaderBase asserts gammaIsLinear() -- but we don't enforce
this in factories.

Based on comments, this may be a stale restriction.  Can we drop it?

Bug: chromium:798208
Change-Id: Id9639cb2bb87f112b26c05372f2a3181c139e5ec
Reviewed-on: https://skia-review.googlesource.com/123860
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Florin Malita <fmalita@chromium.org>
2018-04-26 13:50:13 +00:00
Xiao Yu
97126018d9 Add more granularity inside of SkCanvas::Flush traces.
We currently just get a big nondescript block when trying to understand what's taking rendering time. This will help us get an idea of the general categories of time consuming things when we toggle skia traces on.

Bug: skia:
Change-Id: Ia231cfc0e6e984172ad04547e95e269e8cc2d12a
Reviewed-on: https://skia-review.googlesource.com/123820
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Greg Daniel <egdaniel@google.com>
2018-04-26 13:47:43 +00:00
Eric Boren
1178ea0f7b [infra] Make the Android_Framework bot run on demand
This causes it to never get triggered automatically, so it will only run
as a try job or when force-triggered.

Caveat: if the job is defined on non-master branches, it will still
trigger for those branches.

Bug: skia:
Change-Id: Idff63bd22536b21ec21eb4b569cc392642297d7b
Reviewed-on: https://skia-review.googlesource.com/123923
Reviewed-by: Ravi Mistry <rmistry@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
2018-04-26 13:22:43 +00:00
Brian Osman
2755488a53 Disable optimizing xforms for speed on Flutter
Ironically, this is a giant slowdown, because xforms are being
constructed every frame, and this takes multiple ms.

Change-Id: Ib242b6b7b212c715d20fdd572ed6db5a167f07e2
Reviewed-on: https://skia-review.googlesource.com/123922
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2018-04-26 13:14:03 +00:00
Kevin Lubick
72d92a0b42 Move Braswell HD 405 bots to Debian 9.4
Bug: skia:7840
Change-Id: I36114c55322a886a02d5588cc403984ea3c09aca
Reviewed-on: https://skia-review.googlesource.com/123745
Reviewed-by: Eric Boren <borenet@google.com>
2018-04-26 12:29:07 +00:00
angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com
2aaeff4bfb Roll third_party/externals/angle2/ 197d52949..0086de179 (1 commit)
197d52949e..0086de1794

$ git log 197d52949..0086de179 --date=short --no-merges --format='%ad %ae %s'
2018-04-25 lucferron Vulkan: Add test to reproduce graph issue when draw->subImage->draw

Created with:
  roll-dep third_party/externals/angle2


The AutoRoll server is located here: https://angle-skia-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE
TBR=stani@google.com

Change-Id: I461f7bcdaa78c2c9483e265748391a9013e8dc43
Reviewed-on: https://skia-review.googlesource.com/123881
Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
2018-04-26 12:02:00 +00:00
recipe-roller
5c9369eb14 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
depot_tools:
  https://crrev.com/3cb0767ac14e06a63a6e90d34c1c139b128dd87b recipes: cache destination branch of a Gerrit change. (tandrii@chromium.org)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ia51e2e05c41b375483ab88b5a99f8973f7de9690
Reviewed-on: https://skia-review.googlesource.com/123868
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
2018-04-26 08:24:00 +00:00
recipe-roller
643ab1bf52 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/c93ee0e7a9941356e1a7489af1abc2dca43f2c97 Add OWNERS to LUCI recipe modules. (tandrii@chromium.org)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I9eb65fd8b6d65c7a5116cf9800e8bb455d977875
Reviewed-on: https://skia-review.googlesource.com/123867
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
2018-04-26 07:11:00 +00:00
recipe-roller
5b1bc694a6 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/0a82af179bce717e9be1240286497312309487d0 service_account: remove ability to vary lifetime and set it to 180s. (tandrii@chromium.org)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I953b7f1a8ddb6b9f289f580e79dbdf01d6700001
Reviewed-on: https://skia-review.googlesource.com/123863
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
2018-04-26 06:29:30 +00:00
recipe-roller
e56ced15da Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
depot_tools:
  https://crrev.com/355b11a31f0d2bd2fcc4e14f8abc8681edbf3b2d bot_update: Patch on gclient by default. (ehmaldonado@chromium.org)
  https://crrev.com/cab00ccf8edb80933cd74612c232959fc3beae05 CQ: switch to 100% LUCI builders. (tandrii@chromium.org)
  https://crrev.com/2acf4957984643d8ac1a856afed0730c4449e190 Revert "bot_update: Patch on gclient by default." (ehmaldonado@chromium.org)
recipe_engine:
  https://crrev.com/e315ab3c7742e21b293911eb61e0c0a2e877acab cq: switch to 100% LUCI. (tandrii@chromium.org)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I764502e99af4388c917db514f55763ff031e15d2
Reviewed-on: https://skia-review.googlesource.com/123861
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
2018-04-26 05:58:10 +00:00
angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com
6b043cb9cc Roll third_party/externals/angle2/ f827123d9..197d52949 (2 commits)
f827123d99..197d52949e

$ git log f827123d9..197d52949 --date=short --no-merges --format='%ad %ae %s'
2018-04-25 geofflang Wrap all preprocessor code in the angle namespace.
2018-04-23 lfy GLES1: Enable/disable for texture targets

Created with:
  roll-dep third_party/externals/angle2


The AutoRoll server is located here: https://angle-skia-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE
TBR=stani@google.com

Change-Id: Ib8cb85f7a1ba14dcba4f7c3192ce5f576ce30900
Reviewed-on: https://skia-review.googlesource.com/123821
Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
2018-04-26 02:46:00 +00:00
Florin Malita
cd05b19609 [skottie] Add support for inverse mask paths
TBR=
Change-Id: I442033b2e82777c90ee497d8a5b2310af1d2e631
Reviewed-on: https://skia-review.googlesource.com/123840
Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Florin Malita <fmalita@chromium.org>
2018-04-26 02:35:10 +00:00
swiftshader-skia-autoroll
1366282bc2 Roll third_party/externals/swiftshader/ c8eedebdf..840f47ea8 (5 commits)
https://swiftshader.googlesource.com/SwiftShader/+log/c8eedebdf51e..840f47ea853b

$ git log c8eedebdf..840f47ea8 --date=short --no-merges --format='%ad %ae %s'
2018-04-25 capn Fix Linux build.
2018-04-24 jemoreira Use the correct constant name for the Android SDK version
2018-04-25 tikuta Use override for overridden function
2018-04-24 sugoi Fixed sampler within struct uniform used as function argument
2018-04-16 sugoi Load sibling libraries from the same directory

Created with:
  roll-dep third_party/externals/swiftshader


The AutoRoll server is located here: https://swiftshader-skia-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=skia.primary:Test-Debian9-Clang-GCE-CPU-AVX2-x86_64-Debug-All-SwiftShader
TBR=stani@google.com

Change-Id: I19c13710a072bfdbf7e07431874f845e533e2acb
Reviewed-on: https://skia-review.googlesource.com/123801
Reviewed-by: swiftshader-skia-autoroll <swiftshader-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: swiftshader-skia-autoroll <swiftshader-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
2018-04-25 23:35:29 +00:00
Adrienne Walker
890a8cc604 Fix GrAAConvexTessellator trying to fan a 0 point ring
This prevents accessing off an empty array.

Bug: chromium:830038
Change-Id: I5ad019d56659c667564efc498dcef7fb112da4af
Reviewed-on: https://skia-review.googlesource.com/123800
Commit-Queue: Adrienne Walker <enne@chromium.org>
Commit-Queue: Mike Klein <mtklein@google.com>
Auto-Submit: Adrienne Walker <enne@chromium.org>
Reviewed-by: Mike Klein <mtklein@google.com>
2018-04-25 23:15:30 +00:00
Brian Salomon
580aee2fa4 Reland "Revert "Add arcs as a specialized geometry to GrShape.""
This reverts commit 8a98bc9674.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> Revert "Revert "Add arcs as a specialized geometry to GrShape.""
> 
> This reverts commit af88ec3712.
> 
> Bug: skia:7794
> Change-Id: I2d0e1d7b4e025481241d823b09f5de5d0f1a13eb
> Reviewed-on: https://skia-review.googlesource.com/123627
> Reviewed-by: Robert Phillips <robertphillips@google.com>
> Commit-Queue: Brian Salomon <bsalomon@google.com>

TBR=bsalomon@google.com,robertphillips@google.com

Change-Id: Ib09a533600028b76a69b455c952f3dd12b39bdba
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: skia:7794
Reviewed-on: https://skia-review.googlesource.com/123780
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
2018-04-25 21:20:30 +00:00
Yuqian Li
46b08123b3 Remove SkASSERT(fConvexity == kUnknown_Convexity) due to racing
Bug: skia:7822
Change-Id: I2def72a6d032c43376906d189e5ee834c76b0898
Reviewed-on: https://skia-review.googlesource.com/123749
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
Commit-Queue: Yuqian Li <liyuqian@google.com>
Auto-Submit: Yuqian Li <liyuqian@google.com>
2018-04-25 21:06:30 +00:00
Brian Salomon
43227522e4 Make SkString::appendf safe for long strings.
Bug: skia:7841
Change-Id: I5bc77f5230b63da74e42d756ab4a1fefcfab9926
Reviewed-on: https://skia-review.googlesource.com/123634
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
2018-04-25 20:58:09 +00:00
skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com
abc1976c12 Roll skia/third_party/skcms 2c9b55f..ba9fcb3 (1 commits)
https://skia.googlesource.com/skcms.git/+log/2c9b55f..ba9fcb3

2018-04-25 mtklein@chromium.org retry SKCMS_API


The AutoRoll server is located here: https://skcms-skia-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



TBR=stani@google.com

Change-Id: I10a0794974e6ecb45e712a3621c35c2395726b72
Reviewed-on: https://skia-review.googlesource.com/123738
Commit-Queue: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
2018-04-25 20:26:09 +00:00
Mike Reed
c247a4ea02 fix android-framework
Bug: skia:
Change-Id: Iac3f306808d931ce46380ec1ed4bda940cd7181d
Reviewed-on: https://skia-review.googlesource.com/123746
Reviewed-by: Mike Reed <reed@google.com>
Reviewed-by: Stan Iliev <stani@google.com>
Commit-Queue: Mike Reed <reed@google.com>
2018-04-25 20:22:29 +00:00
Chris Dalton
218c29453f Remove the MSAA path renderer
Bug: skia:
Change-Id: Ib18bede613c8d27fd6326f655dc2d638e35870ff
Reviewed-on: https://skia-review.googlesource.com/123726
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Chris Dalton <csmartdalton@google.com>
2018-04-25 19:59:59 +00:00
Greg Daniel
25af671a3d Add GrCap check for whether we can do a copy or not, and implement in Vk backend
Today, we only know if we fail a copy during the flush so we have no
way to cleanly handle a failed copy. This will allow us to know if we'll
fail a copy during recording and allow us to do some appropriate fallback
and/or dropping of the draw.

Bug: skia:
Change-Id: I38f209dbd4ebb4e762210b4609147d4b0a1b01b1
Reviewed-on: https://skia-review.googlesource.com/123560
Reviewed-by: Brian Salomon <bsalomon@google.com>
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Greg Daniel <egdaniel@google.com>
2018-04-25 19:38:57 +00:00
Eric Boren
b66099b9fb [infra] Run presubmit like a normal bot
Bug: skia:
Change-Id: If01c10c21477bd61c4ec1d4f59921745eb3bf494
Reviewed-on: https://skia-review.googlesource.com/123622
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
2018-04-25 19:36:47 +00:00
skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com
1dfaf2da2e Roll skia/third_party/skcms a893aa3..2c9b55f (1 commits)
https://skia.googlesource.com/skcms.git/+log/a893aa3..2c9b55f

2018-04-25 brianosman@google.com Revert "SKCMS_API"


The AutoRoll server is located here: https://skcms-skia-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



TBR=stani@google.com

Change-Id: Ib7f2cc3abf204e484f031c3279438285dc06f73b
Reviewed-on: https://skia-review.googlesource.com/123732
Reviewed-by: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
2018-04-25 19:28:54 +00:00
Adrienne Walker
6f719aeeae Add CheckGeneratedFiles recipe check for gpu workarounds
Followup to https://skia-review.googlesource.com/122800

Bug: chromium: 829614
Change-Id: Idde753e0f8943290208625ba5b6332a5fdc07184
Reviewed-on: https://skia-review.googlesource.com/123536
Commit-Queue: Adrienne Walker <enne@chromium.org>
Commit-Queue: Eric Boren <borenet@google.com>
Auto-Submit: Adrienne Walker <enne@chromium.org>
Reviewed-by: Eric Boren <borenet@google.com>
2018-04-25 19:26:27 +00:00
Ben Wagner
d3c84fff65 Clean up xfermodes3 gm.
Update temporary surface creation so that cpu and gpu are doing the same
thing, reducing confusion around what the test is doing.

Also clip to the bounds of the saved layer when a temporary surface cannot
be created. This prevents the underspecified behavior of drawing outside
the bounds of a saved layer.

Change-Id: Iad35b394f50b4e1867a8bffdc9f5b3d2ae9c1645
Reviewed-on: https://skia-review.googlesource.com/123741
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Ben Wagner <bungeman@google.com>
2018-04-25 19:25:47 +00:00
skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com
6078776ee5 Roll skia/third_party/skcms 509a65e..a893aa3 (1 commits)
https://skia.googlesource.com/skcms.git/+log/509a65e..a893aa3

2018-04-25 mtklein@chromium.org test OptimizeForSpeed()


The AutoRoll server is located here: https://skcms-skia-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



TBR=stani@google.com

Change-Id: I740a9097cf3795ed889af8c18dea5a762afe2261
Reviewed-on: https://skia-review.googlesource.com/123727
Commit-Queue: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
2018-04-25 19:09:17 +00:00
Yuqian Li
f1331ad76f Snap bitmap for SkThreadedBMPDevice::drawBitmapRect
Otherwise, dm --config t8888 -m rects_as_paths will fail in ASAN.

Bug: skia:
Change-Id: I2b69b3544af7303a1e052c67f087d3ac9d26689d
Reviewed-on: https://skia-review.googlesource.com/123685
Auto-Submit: Yuqian Li <liyuqian@google.com>
Commit-Queue: Mike Reed <reed@google.com>
Reviewed-by: Mike Reed <reed@google.com>
2018-04-25 19:03:59 +00:00
Brian Salomon
8a98bc9674 Revert "Revert "Add arcs as a specialized geometry to GrShape.""
This reverts commit af88ec3712.

Bug: skia:7794
Change-Id: I2d0e1d7b4e025481241d823b09f5de5d0f1a13eb
Reviewed-on: https://skia-review.googlesource.com/123627
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
2018-04-25 18:54:07 +00:00
Kevin Lubick
cfd650e43f Move Baytrail to stretch
Bug: skia:
Change-Id: Ib7fe82df428038e1be773446c121010665fe7472
Reviewed-on: https://skia-review.googlesource.com/123628
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
2018-04-25 18:52:07 +00:00
skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com
677809ac16 Roll skia/third_party/skcms 48c6ca0..509a65e (1 commits)
https://skia.googlesource.com/skcms.git/+log/48c6ca0..509a65e

2018-04-25 mtklein@chromium.org Reland "use linear segment instead of recalculating it"


The AutoRoll server is located here: https://skcms-skia-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



TBR=stani@google.com

Change-Id: I61527be2081ed737ca323a4e87ff778270a59104
Reviewed-on: https://skia-review.googlesource.com/123723
Reviewed-by: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
2018-04-25 18:19:47 +00:00
skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com
de5cffbc48 Roll skia/third_party/skcms 9e351c0..48c6ca0 (1 commits)
https://skia.googlesource.com/skcms.git/+log/9e351c0..48c6ca0

2018-04-25 mtklein@chromium.org evaluate skcms_PolyTF carefully


The AutoRoll server is located here: https://skcms-skia-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



TBR=stani@google.com

Change-Id: I8fb39fbacfe84a0ceec668b5221f8f32cc225f26
Reviewed-on: https://skia-review.googlesource.com/123657
Reviewed-by: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
2018-04-25 17:52:07 +00:00
angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com
412d411d66 Roll third_party/externals/angle2/ 023371b3a..f827123d9 (5 commits)
023371b3af..f827123d99

$ git log 023371b3a..f827123d9 --date=short --no-merges --format='%ad %ae %s'
2018-04-25 oetuaho Handle negative float to uint conversion robustly
2018-04-24 lucferron Vulkan: Enable UnpackAlignmentTest and remove useless warning.
2018-04-24 lucferron Vulkan: Fix issue with texsubimage2d barriers
2018-04-25 jmadill Clean up DEPS style.
2018-04-24 lucferron Vulkan: Issue when drawing with a texture and rebinding after.

Created with:
  roll-dep third_party/externals/angle2


The AutoRoll server is located here: https://angle-skia-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE
TBR=stani@google.com

Change-Id: I10362056f2079bde891d905cae2caf3391ba083b
Reviewed-on: https://skia-review.googlesource.com/123655
Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
2018-04-25 17:47:57 +00:00
Brian Osman
6cd9268907 Don't 'require' external image extensions, 'enable' them
We trigger this when we don't necessarily have support for both
extensions, so requiring them can cause compilation failures.

Bug: https://github.com/flutter/flutter/issues/16178
Change-Id: I54c190709a677bc9ec2fa46f612e8958e3de38cb
Reviewed-on: https://skia-review.googlesource.com/123683
Reviewed-by: Ethan Nicholas <ethannicholas@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2018-04-25 17:38:37 +00:00
Mike Reed
910ca0fd01 Experiment to track coverage in a layer
Bug: skia:
Change-Id: I5ed334f63e64991944394dc8103092a2c6280546
Reviewed-on: https://skia-review.googlesource.com/122000
Commit-Queue: Mike Reed <reed@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
2018-04-25 17:34:27 +00:00
skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com
f0db23633f Roll skia/third_party/skcms f3a576b..9e351c0 (1 commits)
https://skia.googlesource.com/skcms.git/+log/f3a576b..9e351c0

2018-04-25 mtklein@chromium.org relax is_identity_tf()


The AutoRoll server is located here: https://skcms-skia-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



TBR=stani@google.com

Change-Id: I8e85719c85ca3ebbe3da2bf66e75968fd251c7a2
Reviewed-on: https://skia-review.googlesource.com/123656
Commit-Queue: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
2018-04-25 17:25:57 +00:00
Ethan Nicholas
3c6ae62e0f cache SkSL headers
This reduces the cost of successive shader compilations by caching the
results of compiling SkSL's headers.

Bug: skia:
Change-Id: If7fc21a9877021c4025ad99dd0981523a25855e0
Reviewed-on: https://skia-review.googlesource.com/123422
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
2018-04-25 16:53:27 +00:00
Ben Wagner
f8f1839cc8 Upgrade Win Radeon driver.
Bug: skia:7809
Change-Id: I9266a16acee92f5a5fcb8e723890c1793c957bf3
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/123589
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Auto-Submit: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Kevin Lubick <kjlubick@google.com>
2018-04-25 16:45:57 +00:00
Robert Phillips
115a12f849 Fix GrRRectBlurEffect.fp
Change-Id: I40192fd1bcc0af7f06edddfd2e961b69b14546f5
Reviewed-on: https://skia-review.googlesource.com/123630
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
2018-04-25 16:42:37 +00:00
skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com
dc3aa7d3ce Roll skia/third_party/skcms 40a5028..f3a576b (1 commits)
https://skia.googlesource.com/skcms.git/+log/40a5028..f3a576b

2018-04-25 mtklein@chromium.org SKCMS_API


The AutoRoll server is located here: https://skcms-skia-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



TBR=stani@google.com

Change-Id: Ie0a8bc53904ae098ce5ca5909d3e39dd62e437c6
Reviewed-on: https://skia-review.googlesource.com/123649
Commit-Queue: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
2018-04-25 16:40:47 +00:00
skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com
e8b6ddabb2 Roll skia/third_party/skcms 86807d3..40a5028 (1 commits)
https://skia.googlesource.com/skcms.git/+log/86807d3..40a5028

2018-04-25 mtklein@google.com Revert "use linear segment instead of recalculating it"


The AutoRoll server is located here: https://skcms-skia-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



TBR=stani@google.com

Change-Id: Ib70f9037f9acaf6357b2877c977df8a8c09eb268
Reviewed-on: https://skia-review.googlesource.com/123648
Reviewed-by: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
2018-04-25 16:15:27 +00:00